From owner-freebsd-audit Sun Apr 30 13:17: 9 2000 Delivered-To: freebsd-audit@freebsd.org Received: from florence.pavilion.net (florence.pavilion.net [212.74.0.25]) by hub.freebsd.org (Postfix) with ESMTP id C72DC37BEAB for ; Sun, 30 Apr 2000 13:17:05 -0700 (PDT) (envelope-from joe@pavilion.net) Received: from genius.systems.pavilion.net (genesis.tao.org.uk [194.242.131.254]) by florence.pavilion.net (8.9.3/8.8.8) with ESMTP id VAA70290; Sun, 30 Apr 2000 21:16:23 +0100 (BST) (envelope-from joe@pavilion.net) Received: by genius.systems.pavilion.net (Postfix, from userid 100) id 1DA78362; Sat, 29 Apr 2000 14:10:39 +0100 (BST) Date: Sat, 29 Apr 2000 14:10:39 +0100 From: Joe Karthauser To: Mike Heffner Cc: FreeBSD-audit Subject: Re: three small patches - oflows Message-ID: <20000429141039.A48739@pavilion.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: ; from mheffner@mailandnews.com on Mon, Mar 20, 2000 at 02:12:42AM -0500 X-NCC-RegID: uk.pavilion Organisation: Pavilion Internet plc, Lees House, 21-23 Dyke Road, Brighton, England Phone: +44-845-333-5000 Fax: +44-845-333-5001 Mobile: +44-403-596893 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, Mar 20, 2000 at 02:12:42AM -0500, Mike Heffner wrote: > > Index: bin/ed/main.c I'll commit this when I next get connected. I've changed the second patch slightly to: REALLOC(file, filesz, MAXPATHLEN + 1, NULL); - /* assert: no trailing escape */ - while ((file[i++] = (*s == '\\') ? *++s : *s)) + while (i < filesz - 1 /* Worry about a possible trailing escape */ + && (file[i++] = (*s == '\\') ? *++s : *s)) s++; return file; > - natd patch, fixes "natd -w [17000] blah" overflow > Index: sbin/natd/natd.c This too looks good. > - startslip patch, fixes "startslip -d [8192] -c [8192]" overflow > Index: sbin/startslip/startslip.c This too. I'll commit them all on Sunday or Monday. Joe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message