From owner-freebsd-audit  Tue Aug 29  4: 2: 3 2000
Delivered-To: freebsd-audit@freebsd.org
Received: from burka.carrier.kiev.ua (burka.carrier.kiev.ua [193.193.193.107])
	by hub.freebsd.org (Postfix) with ESMTP
	id E273637B422; Tue, 29 Aug 2000 04:01:59 -0700 (PDT)
Received: from netch@localhost
	by burka.carrier.kiev.ua  id OAT56202;
	Tue, 29 Aug 2000 14:01:56 +0300 (EEST)
	(envelope-from netch)
Date: Tue, 29 Aug 2000 14:01:56 +0300 (EEST)
Message-Id: <200008291101.OAT56202@burka.carrier.kiev.ua>
From: netch@carrier.kiev.ua (Valentin Nechayev)
To: Kris Kennaway <kris@hub.freebsd.org>, freebsd-audit@freebsd.org
Subject: Re: ether_line() patch
User-Agent: tin/1.4.1-19991201 ("Polish") (UNIX) (FreeBSD/3.5-STABLE (i386))
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

KK> @@ -156,8 +178,8 @@
KK>  				strlen(ether_a), &result, &resultlen)) {
KK>  				continue;
KK>  			}
KK> -			strncpy(buf, result, resultlen);
KK> -			buf[resultlen] = '\0';
KK> +			strncpy(buf, result, sizeof(buf) - 1);
KK> +			buf[sizeof(buf)] = '\0';
KK>  			free(result);

Will it be better to write `strlcpy(buf, result, sizeof(buf))' ?


/netch


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message