From owner-freebsd-audit Sun Jan 7 8:59: 2 2001 Delivered-To: freebsd-audit@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id A9D6837B699; Sun, 7 Jan 2001 08:58:37 -0800 (PST) Received: from dragon.nuxi.com (Ipitythefoolthattrustsident@trang.nuxi.com [209.152.133.57]) by relay.nuxi.com (8.9.3/8.9.3) with ESMTP id IAA15764; Sun, 7 Jan 2001 08:57:11 -0800 (PST) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.1/8.11.1) id f07Guxt94453; Sun, 7 Jan 2001 08:56:59 -0800 (PST) (envelope-from obrien) Date: Sun, 7 Jan 2001 08:56:58 -0800 From: "David O'Brien" To: Fernando Schapachnik Cc: Daniel Hagan , Warner Losh , Roman Shterenzon , audit@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG, greid@dogma.freebsd-uk.eu.org Subject: Re: bin/23944: Proposed modification to ftpd Message-ID: <20010107085658.A94429@dragon.nuxi.com> Reply-To: audit@FreeBSD.ORG References: <3A536F7C.71DA4C2E@colltech.com> <200101041351.KAA96373@ns1.via-net-works.net.ar> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: <200101041351.KAA96373@ns1.via-net-works.net.ar>; from fpscha@ns1.via-net-works.net.ar on Thu, Jan 04, 2001 at 10:51:52AM -0300 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, Jan 04, 2001 at 10:51:52AM -0300, Fernando Schapachnik wrote: > En un mensaje anterior, Daniel Hagan escribió: > > I've been poking around GNATS today, and I noticed misc/24034, a > > semi-related patch. If this (bin/23944) gets committed, someone needs > > to update the code from 24034 as well. > > The patch I'm attaching contains a reworked version of my original > patch and a fix for misc/24034 under the new scenario. The only People do realize that ftpd is going away in a month don't they?? -- -- David (obrien@FreeBSD.org) GNU is Not Unix / Linux Is Not UniX To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Jan 7 9: 3:18 2001 Delivered-To: freebsd-audit@freebsd.org Received: from harmony.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 1E6E237B6A0; Sun, 7 Jan 2001 09:01:31 -0800 (PST) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f07H1Ts32049; Sun, 7 Jan 2001 10:01:29 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200101071701.f07H1Ts32049@harmony.village.org> To: audit@FreeBSD.ORG Subject: Re: bin/23944: Proposed modification to ftpd Cc: Fernando Schapachnik , Daniel Hagan , Roman Shterenzon , freebsd-bugs@FreeBSD.ORG, greid@dogma.freebsd-uk.eu.org In-reply-to: Your message of "Sun, 07 Jan 2001 08:56:58 PST." <20010107085658.A94429@dragon.nuxi.com> References: <20010107085658.A94429@dragon.nuxi.com> <3A536F7C.71DA4C2E@colltech.com> <200101041351.KAA96373@ns1.via-net-works.net.ar> Date: Sun, 07 Jan 2001 10:01:28 -0700 From: Warner Losh Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20010107085658.A94429@dragon.nuxi.com> "David O'Brien" writes: : On Thu, Jan 04, 2001 at 10:51:52AM -0300, Fernando Schapachnik wrote: : > En un mensaje anterior, Daniel Hagan escribió: : > > I've been poking around GNATS today, and I noticed misc/24034, a : > > semi-related patch. If this (bin/23944) gets committed, someone needs : > > to update the code from 24034 as well. : > : > The patch I'm attaching contains a reworked version of my original : > patch and a fix for misc/24034 under the new scenario. The only : : People do realize that ftpd is going away in a month don't they?? I didn't realize this had been a done deal. I had thought that my list of "features that we have now, but netbsd's ftpd doesn't have" was enough to slow that down. Should I repost that rather lengthy list again? Or is it somehow irrelevant? Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Jan 7 9:10:51 2001 Delivered-To: freebsd-audit@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id 79F0837B400; Sun, 7 Jan 2001 09:10:32 -0800 (PST) Received: from dragon.nuxi.com (Ipitythefoolthattrustsident@trang.nuxi.com [209.152.133.57]) by relay.nuxi.com (8.9.3/8.9.3) with ESMTP id JAA15813; Sun, 7 Jan 2001 09:09:10 -0800 (PST) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.1/8.11.1) id f07H98E94599; Sun, 7 Jan 2001 09:09:08 -0800 (PST) (envelope-from obrien) Date: Sun, 7 Jan 2001 09:09:08 -0800 From: "David O'Brien" To: audit@FreeBSD.ORG Cc: Fernando Schapachnik , Daniel Hagan , Warner Losh , Roman Shterenzon , freebsd-bugs@FreeBSD.ORG, greid@dogma.freebsd-uk.eu.org Subject: Re: bin/23944: Proposed modification to ftpd Message-ID: <20010107090908.A94566@dragon.nuxi.com> Reply-To: freebsd-arch@FreeBSD.ORG References: <3A536F7C.71DA4C2E@colltech.com> <200101041351.KAA96373@ns1.via-net-works.net.ar> <20010107085658.A94429@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: <20010107085658.A94429@dragon.nuxi.com>; from TrimYourCc@NUXI.com on Sun, Jan 07, 2001 at 08:56:58AM -0800 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, Jan 07, 2001 at 08:56:58AM -0800, David O'Brien wrote: > On Thu, Jan 04, 2001 at 10:51:52AM -0300, Fernando Schapachnik wrote: > > En un mensaje anterior, Daniel Hagan escribió: > > > I've been poking around GNATS today, and I noticed misc/24034, a > > > semi-related patch. If this (bin/23944) gets committed, someone needs > > > to update the code from 24034 as well. > > > > The patch I'm attaching contains a reworked version of my original > > patch and a fix for misc/24034 under the new scenario. The only > > People do realize that ftpd is going away in a month don't they?? Let me clarify this -- the existing ftpd we have is going away in favor the of much improved LukeM/NetBSD one (which also gives us more code shareing). I will import it around Feb 10th. -- -- David (obrien@FreeBSD.org) GNU is Not Unix / Linux Is Not UniX To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Jan 7 9:14:41 2001 Delivered-To: freebsd-audit@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id 860C637B400; Sun, 7 Jan 2001 09:14:22 -0800 (PST) Received: from dragon.nuxi.com (Ipitythefoolthattrustsident@trang.nuxi.com [209.152.133.57]) by relay.nuxi.com (8.9.3/8.9.3) with ESMTP id JAA15826; Sun, 7 Jan 2001 09:12:26 -0800 (PST) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.1/8.11.1) id f07HCKl94620; Sun, 7 Jan 2001 09:12:20 -0800 (PST) (envelope-from obrien) Date: Sun, 7 Jan 2001 09:12:20 -0800 From: "David O'Brien" To: Warner Losh Cc: audit@FreeBSD.ORG, Fernando Schapachnik , Daniel Hagan , Roman Shterenzon , freebsd-bugs@FreeBSD.ORG, greid@dogma.freebsd-uk.eu.org Subject: Re: bin/23944: Proposed modification to ftpd Message-ID: <20010107091220.B94566@dragon.nuxi.com> Reply-To: freebsd-audit@FreeBSD.ORG References: <20010107085658.A94429@dragon.nuxi.com> <3A536F7C.71DA4C2E@colltech.com> <200101041351.KAA96373@ns1.via-net-works.net.ar> <20010107085658.A94429@dragon.nuxi.com> <200101071701.f07H1Ts32049@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101071701.f07H1Ts32049@harmony.village.org>; from imp@harmony.village.org on Sun, Jan 07, 2001 at 10:01:28AM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, Jan 07, 2001 at 10:01:28AM -0700, Warner Losh wrote: > : People do realize that ftpd is going away in a month don't they?? > > I didn't realize this had been a done deal. I'll forward them to Luke. You were also one that wanted to see us use a common ftpd. IMO we can loose a few of those features to get all the features LukeFTPD gives us. Or is someone going to add the features to our ftpd so that so many poeple can stop using wu-ftpd and proftpd -- we know about their vunlerability records. > I had thought that my list of "features that we have now, but netbsd's > ftpd doesn't have" was enough to slow that down. >1mo. is a slow down in my book. -- -- David (obrien@FreeBSD.org) GNU is Not Unix / Linux Is Not UniX To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Jan 7 9:23:41 2001 Delivered-To: freebsd-audit@freebsd.org Received: from harmony.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id DF62437B400; Sun, 7 Jan 2001 09:23:22 -0800 (PST) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f07HNMs32219; Sun, 7 Jan 2001 10:23:22 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200101071723.f07HNMs32219@harmony.village.org> To: freebsd-audit@FreeBSD.ORG Subject: Re: bin/23944: Proposed modification to ftpd Cc: freebsd-bugs@FreeBSD.ORG In-reply-to: Your message of "Sun, 07 Jan 2001 09:12:20 PST." <20010107091220.B94566@dragon.nuxi.com> References: <20010107091220.B94566@dragon.nuxi.com> <20010107085658.A94429@dragon.nuxi.com> <3A536F7C.71DA4C2E@colltech.com> <200101041351.KAA96373@ns1.via-net-works.net.ar> <20010107085658.A94429@dragon.nuxi.com> <200101071701.f07H1Ts32049@harmony.village.org> Date: Sun, 07 Jan 2001 10:23:22 -0700 From: Warner Losh Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20010107091220.B94566@dragon.nuxi.com> "David O'Brien" writes: : I'll forward them to Luke. You were also one that wanted to see us use a : common ftpd. IMO we can loose a few of those features to get all the : features LukeFTPD gives us. Or is someone going to add the features to : our ftpd so that so many poeple can stop using wu-ftpd and proftpd -- we : know about their vunlerability records. I want a common ftpd. I'd like to see those features (at least the important ones) added to LukeFTPD. I use both the anonymous only and the read-only features on different machines. : > I had thought that my list of "features that we have now, but netbsd's : > ftpd doesn't have" was enough to slow that down. : : >1mo. is a slow down in my book. Ah. OK. I thought that was the original schedule. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Jan 7 14:25:37 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ns.yogotech.com (ns.yogotech.com [206.127.123.66]) by hub.freebsd.org (Postfix) with ESMTP id 02C7837B402; Sun, 7 Jan 2001 14:25:20 -0800 (PST) Received: from nomad.yogotech.com (nomad.yogotech.com [206.127.123.131]) by ns.yogotech.com (8.9.3/8.9.3) with ESMTP id PAA21414; Sun, 7 Jan 2001 15:24:32 -0700 (MST) (envelope-from nate@nomad.yogotech.com) Received: (from nate@localhost) by nomad.yogotech.com (8.8.8/8.8.8) id PAA06911; Sun, 7 Jan 2001 15:24:31 -0700 (MST) (envelope-from nate) From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <14936.60575.611515.181585@nomad.yogotech.com> Date: Sun, 7 Jan 2001 15:24:31 -0700 (MST) To: audit@FreeBSD.ORG Cc: Fernando Schapachnik , Daniel Hagan , Warner Losh , Roman Shterenzon , freebsd-bugs@FreeBSD.ORG, greid@dogma.freebsd-uk.eu.org Subject: Re: bin/23944: Proposed modification to ftpd In-Reply-To: <20010107085658.A94429@dragon.nuxi.com> References: <3A536F7C.71DA4C2E@colltech.com> <200101041351.KAA96373@ns1.via-net-works.net.ar> <20010107085658.A94429@dragon.nuxi.com> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Reply-To: nate@yogotech.com (Nate Williams) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > > I've been poking around GNATS today, and I noticed misc/24034, a > > > semi-related patch. If this (bin/23944) gets committed, someone needs > > > to update the code from 24034 as well. > > > > The patch I'm attaching contains a reworked version of my original > > patch and a fix for misc/24034 under the new scenario. The only > > People do realize that ftpd is going away in a month don't they?? Huh? Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Mon Jan 8 22:20:12 2001 Delivered-To: freebsd-audit@freebsd.org Received: from scientia.demon.co.uk (scientia.demon.co.uk [212.228.14.13]) by hub.freebsd.org (Postfix) with ESMTP id 4604E37B400 for ; Mon, 8 Jan 2001 22:19:54 -0800 (PST) Received: from strontium.scientia.demon.co.uk ([192.168.91.36] ident=root) by scientia.demon.co.uk with esmtp (Exim 3.20 #1) id 14Fs7p-000LH2-00 for audit@FreeBSD.org; Tue, 09 Jan 2001 06:19:17 +0000 Received: (from ben@localhost) by strontium.scientia.demon.co.uk (8.11.1/8.11.1) id f096JHf66113 for audit@FreeBSD.org; Tue, 9 Jan 2001 06:19:17 GMT (envelope-from ben) Date: Tue, 9 Jan 2001 06:19:16 +0000 From: Ben Smithurst To: audit@FreeBSD.org Subject: stupid bug in getsid() Message-ID: <20010109061916.E79365@strontium.scientia.demon.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Anyone object terribly if I fix this really stupid bug? --- kern_prot.c~ Tue Jan 9 05:59:10 2001 +++ kern_prot.c Tue Jan 9 05:59:22 2001 @@ -162,7 +162,7 @@ if (uap->pid == 0) goto found; - if ((pt == pfind(uap->pid)) == 0) + if ((pt = pfind(uap->pid)) == 0) return ESRCH; found: p->p_retval[0] = pt->p_session->s_sid; -- Ben Smithurst / ben@FreeBSD.org / PGP: 0x99392F7D To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Jan 9 21:43:36 2001 Delivered-To: freebsd-audit@freebsd.org Received: from harmony.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id C847737B698; Tue, 9 Jan 2001 21:43:18 -0800 (PST) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f0A5hIs59275; Tue, 9 Jan 2001 22:43:18 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200101100543.f0A5hIs59275@harmony.village.org> To: Ben Smithurst Subject: Re: stupid bug in getsid() Cc: audit@FreeBSD.ORG In-reply-to: Your message of "Tue, 09 Jan 2001 06:19:16 GMT." <20010109061916.E79365@strontium.scientia.demon.co.uk> References: <20010109061916.E79365@strontium.scientia.demon.co.uk> Date: Tue, 09 Jan 2001 22:43:18 -0700 From: Warner Losh Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20010109061916.E79365@strontium.scientia.demon.co.uk> Ben Smithurst writes: : Anyone object terribly if I fix this really stupid bug? : : --- kern_prot.c~ Tue Jan 9 05:59:10 2001 : +++ kern_prot.c Tue Jan 9 05:59:22 2001 : @@ -162,7 +162,7 @@ : if (uap->pid == 0) : goto found; : : - if ((pt == pfind(uap->pid)) == 0) : + if ((pt = pfind(uap->pid)) == 0) : return ESRCH; : found: : p->p_retval[0] = pt->p_session->s_sid; My first thought is that I would. pt is specifically set in earlier in the function. However, in getpgid() it uses 1 = sign, so I think that's the right thing to do. What are the impacts of this bug? What does it allow you to do that you shouldn't be able to do, if any? Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Jan 9 21:56:20 2001 Delivered-To: freebsd-audit@freebsd.org Received: from scientia.demon.co.uk (scientia.demon.co.uk [212.228.14.13]) by hub.freebsd.org (Postfix) with ESMTP id 0950837B400 for ; Tue, 9 Jan 2001 21:56:03 -0800 (PST) Received: from strontium.scientia.demon.co.uk ([192.168.91.36] ident=root) by scientia.demon.co.uk with esmtp (Exim 3.20 #1) id 14GEEr-000NU6-00; Wed, 10 Jan 2001 05:56:01 +0000 Received: (from ben@localhost) by strontium.scientia.demon.co.uk (8.11.1/8.11.1) id f0A5txH35146; Wed, 10 Jan 2001 05:56:00 GMT (envelope-from ben) Date: Wed, 10 Jan 2001 05:55:59 +0000 From: Ben Smithurst To: Warner Losh Cc: audit@FreeBSD.ORG Subject: Re: stupid bug in getsid() Message-ID: <20010110055559.N79365@strontium.scientia.demon.co.uk> References: <20010109061916.E79365@strontium.scientia.demon.co.uk> <200101100543.f0A5hIs59275@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101100543.f0A5hIs59275@harmony.village.org> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Warner Losh wrote: > What are the impacts of this bug? What does it allow you to do that > you shouldn't be able to do, if any? I don't think it does, it seems that you can basically only use getsid() on the current process (the test is basically pt != pfind(uap->pid), with pt initialized to the process making the sytem call). Here's what revision 1.43 said: ---------------------------- revision 1.43 date: 1998/12/13 07:07:51; author: truckman; state: Exp; lines: +11 -5 branches: 1.43.2; getpgid() and getsid() were doing a comparision rather than an assignment, which is fortunate, because otherwise another bug would allow them to be used to stomp on the syscall return value of another process. ---------------------------- Unfortunately, while getpgid() was fixed with that commit: - if ((p == pfind(uap->pid)) == 0) + if ((pt = pfind(uap->pid)) == 0) getsid() got missed: - if ((p == pfind(uap->pid)) == 0) + if ((pt == pfind(uap->pid)) == 0) -- Ben Smithurst / ben@FreeBSD.org / PGP: 0x99392F7D To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Jan 11 7:18:18 2001 Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id A58EB37B400 for ; Thu, 11 Jan 2001 07:18:00 -0800 (PST) Received: by peitho.fxp.org (Postfix, from userid 1000) id DB53913614; Thu, 11 Jan 2001 10:18:13 -0500 (EST) Date: Thu, 11 Jan 2001 10:18:13 -0500 From: Chris Faulhaber To: freebsd-audit@FreeBSD.org Subject: temp dirs in Makefile.inc1 Message-ID: <20010111101813.A76735@peitho.fxp.org> Mail-Followup-To: Chris Faulhaber , freebsd-audit@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Currently for an installworld, Makefile.inc1 defines the temporary directory used as: TMPDIR?= /tmp TMPPID!= echo $$$$ INSTALLTMP= ${TMPDIR}/install.${TMPPID} I submitted a patch to marcel (who did not object) to use mktemp(1) for a more secure directory name. However, I wanted to run it by -audit before committing... Personally, I have been running with this patch on -current for over a month without problems. -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org Index: Makefile.inc1 =================================================================== RCS file: /home/ncvs/src/Makefile.inc1,v retrieving revision 1.180 diff -u -r1.180 Makefile.inc1 --- Makefile.inc1 2000/12/24 14:58:34 1.180 +++ Makefile.inc1 2001/01/11 15:15:01 @@ -130,9 +130,7 @@ STRICTTMPPATH= ${WORLDTMP}/usr/sbin:${WORLDTMP}/usr/bin:${WORLDTMP}/usr/games TMPPATH= ${STRICTTMPPATH}:${PATH} -TMPDIR?= /tmp -TMPPID!= echo $$$$ -INSTALLTMP= ${TMPDIR}/install.${TMPPID} +INSTALLTMP!= mktemp -d -t install # # Building a world goes through the following stages @@ -295,7 +293,6 @@ # Installs everything compiled by a 'buildworld'. # installworld: - mkdir -p ${INSTALLTMP} for prog in [ awk cat chflags chmod chown date echo egrep find grep \ install ln make makewhatis mtree mv perl rm sed sh sysctl \ test true uname wc zic; do \ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 12 18:56:40 2001 Delivered-To: freebsd-audit@freebsd.org Received: from citusc.usc.edu (citusc.usc.edu [128.125.38.123]) by hub.freebsd.org (Postfix) with ESMTP id 3A0C937B699 for ; Fri, 12 Jan 2001 18:56:22 -0800 (PST) Received: (from kris@localhost) by citusc.usc.edu (8.9.3/8.9.3) id SAA25361; Fri, 12 Jan 2001 18:57:33 -0800 Date: Fri, 12 Jan 2001 18:57:33 -0800 From: Kris Kennaway To: Chris Faulhaber Cc: freebsd-audit@FreeBSD.ORG Subject: Re: temp dirs in Makefile.inc1 Message-ID: <20010112185733.C25168@citusc.usc.edu> References: <20010111101813.A76735@peitho.fxp.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="1ccMZA6j1vT5UqiK" Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20010111101813.A76735@peitho.fxp.org>; from jedgar@fxp.org on Thu, Jan 11, 2001 at 10:18:13AM -0500 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --1ccMZA6j1vT5UqiK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 11, 2001 at 10:18:13AM -0500, Chris Faulhaber wrote: > I submitted a patch to marcel (who did not object) to use mktemp(1) > for a more secure directory name. However, I wanted to run it by > -audit before committing... Personally, I have been running with > this patch on -current for over a month without problems. Doesn't it have problems cleaning up the temporary directory once finished? It also creates the directory when it's not needed (e.g. for other make targets) because the creation is done at an earlier point. I've been running with this almost identical patch for a few months, which works, but I don't like the way it does it. Kris Index: Makefile.inc1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /mnt/ncvs/src/Makefile.inc1,v retrieving revision 1.180 diff -u -r1.180 Makefile.inc1 --- Makefile.inc1 2000/12/24 14:58:34 1.180 +++ Makefile.inc1 2001/01/13 00:26:27 @@ -130,9 +130,7 @@ STRICTTMPPATH=3D ${WORLDTMP}/usr/sbin:${WORLDTMP}/usr/bin:${WORLDTMP}/usr/= games TMPPATH=3D ${STRICTTMPPATH}:${PATH} =20 -TMPDIR?=3D /tmp -TMPPID!=3D echo $$$$ -INSTALLTMP=3D ${TMPDIR}/install.${TMPPID} +INSTALLTMP!=3D /usr/bin/mktemp -d -t install =20 # # Building a world goes through the following stages @@ -295,7 +293,6 @@ # Installs everything compiled by a 'buildworld'. # installworld: - mkdir -p ${INSTALLTMP} for prog in [ awk cat chflags chmod chown date echo egrep find grep \ install ln make makewhatis mtree mv perl rm sed sh sysctl \ test true uname wc zic; do \ @@ -781,5 +778,8 @@ .endfor par-${__target}: ${SUBDIR:S/$/.${__target}__D/} .endfor + +.END: + rm -rf ${INSTALLTMP} =20 .include --1ccMZA6j1vT5UqiK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6X8QdWry0BWjoQKURAttsAKCBwTpTsMY0y+NU6I2tywzr1kKu1wCfY1LU ba9BaAQi2he2O8m/ueqan+U= =83JP -----END PGP SIGNATURE----- --1ccMZA6j1vT5UqiK-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 13 5:28:26 2001 Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id E5D5E37B400; Sat, 13 Jan 2001 05:28:08 -0800 (PST) Received: by peitho.fxp.org (Postfix, from userid 1000) id C88DC1360C; Sat, 13 Jan 2001 08:28:51 -0500 (EST) Date: Sat, 13 Jan 2001 08:28:51 -0500 From: Chris Faulhaber To: Kris Kennaway Cc: freebsd-audit@FreeBSD.ORG Subject: Re: temp dirs in Makefile.inc1 Message-ID: <20010113082851.A25433@peitho.fxp.org> Mail-Followup-To: Chris Faulhaber , Kris Kennaway , freebsd-audit@FreeBSD.ORG References: <20010111101813.A76735@peitho.fxp.org> <20010112185733.C25168@citusc.usc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010112185733.C25168@citusc.usc.edu>; from kris@FreeBSD.ORG on Fri, Jan 12, 2001 at 06:57:33PM -0800 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, Jan 12, 2001 at 06:57:33PM -0800, Kris Kennaway wrote: > On Thu, Jan 11, 2001 at 10:18:13AM -0500, Chris Faulhaber wrote: > > > I submitted a patch to marcel (who did not object) to use mktemp(1) > > for a more secure directory name. However, I wanted to run it by > > -audit before committing... Personally, I have been running with > > this patch on -current for over a month without problems. > > Doesn't it have problems cleaning up the temporary directory once finished? > > It also creates the directory when it's not needed (e.g. for other > make targets) because the creation is done at an earlier point. > > I've been running with this almost identical patch for a few months, > which works, but I don't like the way it does it. > Yeah, guess I overlooked the other targets. Lemme see if I can come up with a better method that doesn't involve creating the dir only when needed. -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 13 5:29:15 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id D62DA37B400 for ; Sat, 13 Jan 2001 05:28:54 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0DDRYI20099; Sat, 13 Jan 2001 15:27:36 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101131327.f0DDRYI20099@gratis.grondar.za> To: Chris Faulhaber Cc: freebsd-audit@FreeBSD.ORG Subject: Re: temp dirs in Makefile.inc1 References: <20010111101813.A76735@peitho.fxp.org> In-Reply-To: <20010111101813.A76735@peitho.fxp.org> ; from Chris Faulhaber "Thu, 11 Jan 2001 10:18:13 EST." Date: Sat, 13 Jan 2001 15:27:27 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Looks good to me! M > Currently for an installworld, Makefile.inc1 defines the temporary > directory used as: > > TMPDIR?= /tmp > TMPPID!= echo $$$$ > INSTALLTMP= ${TMPDIR}/install.${TMPPID} > > I submitted a patch to marcel (who did not object) to use mktemp(1) > for a more secure directory name. However, I wanted to run it by > -audit before committing... Personally, I have been running with > this patch on -current for over a month without problems. > > -- > Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org > -------------------------------------------------------- > FreeBSD: The Power To Serve - http://www.FreeBSD.org > > Index: Makefile.inc1 > =================================================================== > RCS file: /home/ncvs/src/Makefile.inc1,v > retrieving revision 1.180 > diff -u -r1.180 Makefile.inc1 > --- Makefile.inc1 2000/12/24 14:58:34 1.180 > +++ Makefile.inc1 2001/01/11 15:15:01 > @@ -130,9 +130,7 @@ > STRICTTMPPATH= ${WORLDTMP}/usr/sbin:${WORLDTMP}/usr/bin:${WORLDTMP}/usr/games > TMPPATH= ${STRICTTMPPATH}:${PATH} > > -TMPDIR?= /tmp > -TMPPID!= echo $$$$ > -INSTALLTMP= ${TMPDIR}/install.${TMPPID} > +INSTALLTMP!= mktemp -d -t install > > # > # Building a world goes through the following stages > @@ -295,7 +293,6 @@ > # Installs everything compiled by a 'buildworld'. > # > installworld: > - mkdir -p ${INSTALLTMP} > for prog in [ awk cat chflags chmod chown date echo egrep find grep \ > install ln make makewhatis mtree mv perl rm sed sh sysctl \ > test true uname wc zic; do \ > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-audit" in the body of the message > -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 13 5:35:56 2001 Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 070F137B400; Sat, 13 Jan 2001 05:35:40 -0800 (PST) Received: by peitho.fxp.org (Postfix, from userid 1501) id A33191360C; Sat, 13 Jan 2001 08:36:23 -0500 (EST) Date: Sat, 13 Jan 2001 08:36:23 -0500 From: Chris Faulhaber To: Mark Murray Cc: Kris Kennaway , freebsd-audit@FreeBSD.ORG Subject: Re: temp dirs in Makefile.inc1 Message-ID: <20010113083623.A44479@peitho.fxp.org> Mail-Followup-To: Chris Faulhaber , Mark Murray , Kris Kennaway , freebsd-audit@FreeBSD.ORG References: <20010111101813.A76735@peitho.fxp.org> <200101131327.f0DDRYI20099@gratis.grondar.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101131327.f0DDRYI20099@gratis.grondar.za>; from mark@grondar.za on Sat, Jan 13, 2001 at 03:27:27PM +0200 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Jan 13, 2001 at 03:27:27PM +0200, Mark Murray wrote: > > Looks good to me! > Unfortunately, as Kris pointed out, it creates INSTALLTMP for all targets, not just installworld (at least Kris's patch removes the unused dir for non-installworld targets). We could use the -u option to mktemp(1) and continue to create the dir in the installworld: target, though. -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 13 7:16:46 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mailout04.sul.t-online.com (mailout04.sul.t-online.com [194.25.134.18]) by hub.freebsd.org (Postfix) with ESMTP id 98B0537B698 for ; Sat, 13 Jan 2001 07:16:23 -0800 (PST) Received: from fwd01.sul.t-online.com by mailout04.sul.t-online.com with smtp id 14HSPm-0000Ab-06; Sat, 13 Jan 2001 16:16:22 +0100 Received: from neutron.cichlids.com (520050424122-0001@[62.158.39.108]) by fmrl01.sul.t-online.com with esmtp id 14HSPj-0oq7cmC; Sat, 13 Jan 2001 16:16:19 +0100 Received: from cichlids.cichlids.com (cichlids.cichlids.com [192.168.0.10]) by neutron.cichlids.com (Postfix) with ESMTP id E7CF9AB0C for ; Sat, 13 Jan 2001 16:17:41 +0100 (CET) Received: by cichlids.cichlids.com (Postfix, from userid 1001) id A0C3F14BB5; Sat, 13 Jan 2001 16:16:19 +0100 (CET) Date: Sat, 13 Jan 2001 16:16:19 +0100 From: Alexander Langer To: audit@freebsd.org Subject: dxr3 driver now busspacified + indented (but still gnu) Message-ID: <20010113161619.B18508@cichlids.cichlids.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i X-PGP-Fingerprint: 44 28 CA 4C 46 5B D3 A8 A8 E3 BA F3 4E 60 7D 7F X-PGP-at: finger alex@big.endian.de X-Verwirrung: Dieser Header dient der allgemeinen Verwirrung. X-Sender: 520050424122-0001@t-dialin.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hello! The DXR3 driver is now finally busspacified and properbly indented. It's still GNU sourcecode, though, since the original author hasn't answered to emails yet. Additionally to some small issues, which are kinda trivial, I think the driver contains an ugly hack when the main-driver tries to attach the childs on the board (three or four additional chips). This can be reworked. I already mailed the author. However, the whole driver looks good already, and I wondered, if one is interested in taking a look at it: http://www.cs.duke.edu/~gadde/freebsd/em8300/ Alex To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 13 8:17:32 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 2385F37B402; Sat, 13 Jan 2001 08:17:12 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0DGGoI20517; Sat, 13 Jan 2001 18:16:56 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101131616.f0DGGoI20517@gratis.grondar.za> To: Chris Faulhaber Cc: Kris Kennaway , freebsd-audit@FreeBSD.ORG Subject: Re: temp dirs in Makefile.inc1 References: <20010113083623.A44479@peitho.fxp.org> In-Reply-To: <20010113083623.A44479@peitho.fxp.org> ; from Chris Faulhaber "Sat, 13 Jan 2001 08:36:23 EST." Date: Sat, 13 Jan 2001 18:16:42 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Sat, Jan 13, 2001 at 03:27:27PM +0200, Mark Murray wrote: > > > > Looks good to me! > > > > Unfortunately, as Kris pointed out, it creates INSTALLTMP for > all targets, not just installworld (at least Kris's patch > removes the unused dir for non-installworld targets). We > could use the -u option to mktemp(1) and continue to create > the dir in the installworld: target, though. Oops! Right. What does a "make buildworld", "make installworld" say? M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 13 8:44:34 2001 Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id CDC1337B401; Sat, 13 Jan 2001 08:44:16 -0800 (PST) Received: by peitho.fxp.org (Postfix, from userid 1000) id B351E1360C; Sat, 13 Jan 2001 11:44:15 -0500 (EST) Date: Sat, 13 Jan 2001 11:44:15 -0500 From: Chris Faulhaber To: Mark Murray Cc: Kris Kennaway , freebsd-audit@FreeBSD.ORG Subject: Re: temp dirs in Makefile.inc1 Message-ID: <20010113114415.A21411@peitho.fxp.org> Mail-Followup-To: Chris Faulhaber , Mark Murray , Kris Kennaway , freebsd-audit@FreeBSD.ORG References: <20010113083623.A44479@peitho.fxp.org> <200101131616.f0DGGoI20517@gratis.grondar.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101131616.f0DGGoI20517@gratis.grondar.za>; from mark@grondar.za on Sat, Jan 13, 2001 at 06:16:42PM +0200 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Jan 13, 2001 at 06:16:42PM +0200, Mark Murray wrote: > > On Sat, Jan 13, 2001 at 03:27:27PM +0200, Mark Murray wrote: > > > > > > Looks good to me! > > > > > > > Unfortunately, as Kris pointed out, it creates INSTALLTMP for > > all targets, not just installworld (at least Kris's patch > > removes the unused dir for non-installworld targets). We > > could use the -u option to mktemp(1) and continue to create > > the dir in the installworld: target, though. > > Oops! Right. What does a "make buildworld", "make installworld" say? > I just successfully finished a buildworld/installworld with the following patch. Unfortunately, it does not provide all the safety mktemp(1) would have if the -u options was not used, but is better than $TMPDIR/install. and works with the current build structure. Alternatively, we could modify the IMAKE invocation in the installworld target and properly use mktemp(1), setting PATH in the target instead of using IMAKEENV. Unfortunately, this would be uglier than just using mktemp -u. -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org Index: Makefile.inc1 =================================================================== RCS file: /home/ncvs/src/Makefile.inc1,v retrieving revision 1.180 diff -u -r1.180 Makefile.inc1 --- Makefile.inc1 2000/12/24 14:58:34 1.180 +++ Makefile.inc1 2001/01/13 16:24:16 @@ -130,9 +130,7 @@ STRICTTMPPATH= ${WORLDTMP}/usr/sbin:${WORLDTMP}/usr/bin:${WORLDTMP}/usr/games TMPPATH= ${STRICTTMPPATH}:${PATH} -TMPDIR?= /tmp -TMPPID!= echo $$$$ -INSTALLTMP= ${TMPDIR}/install.${TMPPID} +INSTALLTMP!= /usr/bin/mktemp -d -u -t install # # Building a world goes through the following stages To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 13 9:48:50 2001 Delivered-To: freebsd-audit@freebsd.org Received: from scientia.demon.co.uk (scientia.demon.co.uk [212.228.14.13]) by hub.freebsd.org (Postfix) with ESMTP id 6BE6037B400; Sat, 13 Jan 2001 09:48:32 -0800 (PST) Received: from strontium.scientia.demon.co.uk ([192.168.91.36] ident=root) by scientia.demon.co.uk with esmtp (Exim 3.20 #1) id 14HUeV-0008kC-00; Sat, 13 Jan 2001 17:39:43 +0000 Received: (from ben@localhost) by strontium.scientia.demon.co.uk (8.11.1/8.11.1) id f0DHdhr66659; Sat, 13 Jan 2001 17:39:43 GMT (envelope-from ben) Date: Sat, 13 Jan 2001 17:39:43 +0000 From: Ben Smithurst To: Chris Faulhaber Cc: Mark Murray , Kris Kennaway , freebsd-audit@FreeBSD.ORG Subject: Re: temp dirs in Makefile.inc1 Message-ID: <20010113173943.G35575@strontium.scientia.demon.co.uk> References: <20010113083623.A44479@peitho.fxp.org> <200101131616.f0DGGoI20517@gratis.grondar.za> <20010113114415.A21411@peitho.fxp.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010113114415.A21411@peitho.fxp.org> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Chris Faulhaber wrote: > I just successfully finished a buildworld/installworld with the > following patch. Unfortunately, it does not provide all the > safety mktemp(1) would have if the -u options was not used, but > is better than $TMPDIR/install. and works with the current > build structure. I'd say if you're going to fix it, fix it properly, but I guess others may have other views. Hmm, what about something like: INSTALLTMP?= /nonexistent (or something, just so paths which include it don't end up with an empty bit which might get treated as "current directory".) installworld: ${MAKE} -f Makefile.inc1 realinstallworld INSTALLTMP=`mktemp -d -t install` and rename the installworld target to realinstallworld? Or is that a bit ugly? It seems it would work to me, though I haven't tested it. -- Ben Smithurst / ben@FreeBSD.org / PGP: 0x99392F7D To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 13 23:57:34 2001 Delivered-To: freebsd-audit@freebsd.org Received: from spammie.svbug.com (unknown [198.79.110.2]) by hub.freebsd.org (Postfix) with ESMTP id 1943937B400; Sat, 13 Jan 2001 23:57:14 -0800 (PST) Received: from spammie.svbug.com (localhost.mozie.org [127.0.0.1]) by spammie.svbug.com (8.9.3/8.9.3) with ESMTP id XAA00669; Sat, 13 Jan 2001 23:55:01 -0800 (PST) (envelope-from jessem@spammie.svbug.com) Message-Id: <200101140755.XAA00669@spammie.svbug.com> Date: Sat, 13 Jan 2001 23:54:59 -0800 (PST) From: opentrax@email.com Reply-To: opentrax@email.com Subject: Re: Proposed modification to ftpd To: fschapachnik@vianetworks.com.ar Cc: imp@bsdimp.com, roman@xpert.com, security@FreeBSD.ORG, audit@FreeBSD.ORG In-Reply-To: <200101030016.VAA49573@ns1.via-net-works.net.ar> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG No follow-ups to this please. On 2 Jan, Fernando Schapachnik wrote: > En un mensaje anterior, Warner Losh escribió: >> In message <200101021500.MAA18599@ns1.via-net-works.net.ar> Fernando Schapachnik writes: >> : In the patch I made "/./" is an easely changeable #define. >> >> Maybe I missed the pointer to it, but can you post a pointer to your >> patch for review? Audit@ might be a good list to cc it to as well. > > I did in my first post, but here it goes again: PR bin/23944. I also > submitted a follow up that for some reason can't be seen through the > web interface which add checks for strdup result values that are > missing in the first patch. > I'm stating for the record, that I don't believe this option is useful or needed. The authors intent is to emulate wuftpd. My arguement is that people should use wuftpd, if they want hat feature. Nothing suggest that this won't add new security issues. I beleive it will. I remind those reading that Linux has had many security issues, just because of this type of feature-itise. I recommend against this. Warner Losh states he believes it is useful. This issue now passes to those who will review it. If you feel this is also a bad idea, write me I'll help gather evidence against this. If you feel this is a good idea and should be implemented, it is upon you to decide it's next course of action. Lastly, if you feel like telling me I'm wrong, don't bother - just do what you will with this code. best regards, Jessem. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message