From owner-freebsd-audit Sun May 27 20:27:27 2001 Delivered-To: freebsd-audit@freebsd.org Received: from cowpie.acm.vt.edu (cowpie.acm.vt.edu [128.173.42.253]) by hub.freebsd.org (Postfix) with ESMTP id 885EC37B422 for ; Sun, 27 May 2001 20:27:24 -0700 (PDT) (envelope-from mheffner@cowpie.acm.vt.edu) Received: (from mheffner@localhost) by cowpie.acm.vt.edu (8.11.3/8.11.3) id f4S3QjL85863 for freebsd-audit@freebsd.org; Sun, 27 May 2001 23:26:45 -0400 (EDT) (envelope-from mheffner) Date: Sun, 27 May 2001 23:26:45 -0400 From: Mike Heffner To: freebsd-audit@freebsd.org Subject: biff(1) patch Message-ID: <20010527232645.A85851@cowpie.acm.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Use S_IXUSR instead of direct bitmask, BDECFLAGS cleanup. Please review. Index: biff.c =================================================================== RCS file: /home/ncvs/src/usr.bin/biff/biff.c,v retrieving revision 1.7 diff -u -r1.7 biff.c --- biff.c 2000/07/10 08:40:14 1.7 +++ biff.c 2001/05/26 20:17:12 @@ -52,6 +52,7 @@ #include #include +int main __P((int, char *[])); static void usage __P((void)); int @@ -80,23 +81,23 @@ err(2, "stat"); if (*argv == NULL) { - (void)printf("is %s\n", sb.st_mode&0100 ? "y" : "n"); - return(sb.st_mode & 0100 ? 0 : 1); + (void)printf("is %s\n", sb.st_mode & S_IXUSR ? "y" : "n"); + return(sb.st_mode & S_IXUSR ? 0 : 1); } switch(argv[0][0]) { case 'n': - if (chmod(name, sb.st_mode & ~0100) < 0) + if (chmod(name, sb.st_mode & ~S_IXUSR) < 0) err(2, "%s", name); break; case 'y': - if (chmod(name, sb.st_mode | 0100) < 0) + if (chmod(name, sb.st_mode | S_IXUSR) < 0) err(2, "%s", name); break; default: usage(); } - return(sb.st_mode & 0100 ? 0 : 1); + return(sb.st_mode & S_IXUSR ? 0 : 1); } static void Also: http://people.freebsd.org/~mikeh/diffs/biff.diff Mike -- Mike Heffner Fredericksburg, VA http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun May 27 20:30:16 2001 Delivered-To: freebsd-audit@freebsd.org Received: from cowpie.acm.vt.edu (cowpie.acm.vt.edu [128.173.42.253]) by hub.freebsd.org (Postfix) with ESMTP id 1420237B42C for ; Sun, 27 May 2001 20:30:06 -0700 (PDT) (envelope-from mheffner@cowpie.acm.vt.edu) Received: (from mheffner@localhost) by cowpie.acm.vt.edu (8.11.3/8.11.3) id f4S3TR485888 for freebsd-audit@freebsd.org; Sun, 27 May 2001 23:29:27 -0400 (EDT) (envelope-from mheffner) Date: Sun, 27 May 2001 23:29:27 -0400 From: Mike Heffner To: freebsd-audit@freebsd.org Subject: cmp(1) patch Message-ID: <20010527232926.A85869@cowpie.acm.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG BDECFLAGS cleanup, respect -s flag in one place, return instead of exit() at end of main. Please review. Index: cmp.c =================================================================== RCS file: /home/ncvs/src/usr.bin/cmp/cmp.c,v retrieving revision 1.9 diff -u -r1.9 cmp.c --- cmp.c 2000/07/25 13:01:34 1.9 +++ cmp.c 2001/05/26 21:57:56 @@ -58,6 +58,7 @@ int lflag, sflag, xflag, zflag; +int main __P((int, char *[])); static void usage __P((void)); int @@ -68,7 +69,7 @@ struct stat sb1, sb2; off_t skip1, skip2; int ch, fd1, fd2, special; - char *file1, *file2; + const char *file1, *file2; while ((ch = getopt(argc, argv, "-lsxz")) != -1) switch (ch) { @@ -117,9 +118,13 @@ exit(1); } if (strcmp(file2 = argv[1], "-") == 0) { - if (special) - errx(ERR_EXIT, + if (special) { + if (!sflag) + errx(ERR_EXIT, "standard input may only be specified once"); + else + exit(1); + } special = 1; fd2 = 0; file2 = "stdin"; @@ -160,14 +165,14 @@ else { if (zflag && sb1.st_size != sb2.st_size) { if (!sflag) - (void) printf("%s %s differ: size\n", + (void)printf("%s %s differ: size\n", file1, file2); exit(DIFF_EXIT); } c_regular(fd1, file1, skip1, sb1.st_size, fd2, file2, skip2, sb2.st_size); } - exit(0); + return (0); } static void Index: extern.h =================================================================== RCS file: /home/ncvs/src/usr.bin/cmp/extern.h,v retrieving revision 1.2 diff -u -r1.2 extern.h --- extern.h 2000/05/15 08:30:43 1.2 +++ extern.h 2001/05/26 21:57:56 @@ -40,9 +40,10 @@ #define DIFF_EXIT 1 #define ERR_EXIT 2 /* error exit code */ -void c_regular __P((int, char *, off_t, off_t, int, char *, off_t, off_t)); -void c_special __P((int, char *, off_t, int, char *, off_t)); -void diffmsg __P((char *, char *, off_t, off_t)); -void eofmsg __P((char *)); +void c_regular __P((int, const char *, off_t, off_t, int, + const char *, off_t, off_t)); +void c_special __P((int, const char *, off_t, int, const char *, off_t)); +void diffmsg __P((const char *, const char *, off_t, off_t)); +void eofmsg __P((const char *)); extern int lflag, sflag, xflag; Index: misc.c =================================================================== RCS file: /home/ncvs/src/usr.bin/cmp/misc.c,v retrieving revision 1.2 diff -u -r1.2 misc.c --- misc.c 1998/12/06 22:58:15 1.2 +++ misc.c 2001/05/26 21:57:57 @@ -45,7 +45,7 @@ void eofmsg(file) - char *file; + const char *file; { if (!sflag) warnx("EOF on %s", file); @@ -54,11 +54,11 @@ void diffmsg(file1, file2, byte, line) - char *file1, *file2; + const char *file1, *file2; off_t byte, line; { if (!sflag) - (void)printf("%s %s differ: char %qd, line %qd\n", - file1, file2, byte, line); + (void)printf("%s %s differ: char %lld, line %lld\n", + file1, file2, (long long)byte, (long long)line); exit(DIFF_EXIT); } Index: regular.c =================================================================== RCS file: /home/ncvs/src/usr.bin/cmp/regular.c,v retrieving revision 1.10 diff -u -r1.10 regular.c --- regular.c 2000/06/20 20:28:40 1.10 +++ regular.c 2001/05/26 21:57:57 @@ -56,7 +56,7 @@ void c_regular(fd1, file1, skip1, len1, fd2, file2, skip2, len2) int fd1, fd2; - char *file1, *file2; + const char *file1, *file2; off_t skip1, len1, skip2, len2; { u_char ch, *p1, *p2; @@ -81,8 +81,10 @@ off2 = ROUNDPAGE(skip2); length = MIN(len1, len2); - if (length > SIZE_T_MAX) - return (c_special(fd1, file1, skip1, fd2, file2, skip2)); + if (length > SIZE_T_MAX) { + c_special(fd1, file1, skip1, fd2, file2, skip2); + return; + } if ((p1 = (u_char *)mmap(NULL, (size_t)len1 + skip1 % pagesize, PROT_READ, MAP_SHARED, fd1, off1)) == (u_char *)MAP_FAILED) @@ -101,10 +103,12 @@ if ((ch = *p1) != *p2) { if (xflag) { dfound = 1; - (void)printf("%08qx %02x %02x\n", byte - 1, ch, *p2); + (void)printf("%08llx %02x %02x\n", + (long long)byte - 1, ch, *p2); } else if (lflag) { dfound = 1; - (void)printf("%6qd %3o %3o\n", byte, ch, *p2); + (void)printf("%6lld %3o %3o\n", (long long)byte, + ch, *p2); } else diffmsg(file1, file2, byte, line); /* NOTREACHED */ Index: special.c =================================================================== RCS file: /home/ncvs/src/usr.bin/cmp/special.c,v retrieving revision 1.4 diff -u -r1.4 special.c --- special.c 1999/04/25 22:37:57 1.4 +++ special.c 2001/05/26 21:57:57 @@ -47,7 +47,7 @@ void c_special(fd1, file1, skip1, fd2, file2, skip2) int fd1, fd2; - char *file1, *file2; + const char *file1, *file2; off_t skip1, skip2; { int ch1, ch2; @@ -76,7 +76,8 @@ if (ch1 != ch2) { if (lflag) { dfound = 1; - (void)printf("%6qd %3o %3o\n", byte, ch1, ch2); + (void)printf("%6lld %3o %3o\n", + (long long)byte, ch1, ch2); } else { diffmsg(file1, file2, byte, line); /* NOTREACHED */ Mike -- Mike Heffner Fredericksburg, VA http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun May 27 20:34:46 2001 Delivered-To: freebsd-audit@freebsd.org Received: from cowpie.acm.vt.edu (cowpie.acm.vt.edu [128.173.42.253]) by hub.freebsd.org (Postfix) with ESMTP id 728A137B422 for ; Sun, 27 May 2001 20:34:39 -0700 (PDT) (envelope-from mheffner@cowpie.acm.vt.edu) Received: (from mheffner@localhost) by cowpie.acm.vt.edu (8.11.3/8.11.3) id f4S3Y0O85918 for freebsd-audit@freebsd.org; Sun, 27 May 2001 23:34:00 -0400 (EDT) (envelope-from mheffner) Date: Sun, 27 May 2001 23:34:00 -0400 From: Mike Heffner To: freebsd-audit@freebsd.org Subject: col(1) patch Message-ID: <20010527233400.B85869@cowpie.acm.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG From NetBSD add -p option to pass unknown control sequences instead of the default of dropping them. Also, use err(3) and style(9) cleanup. Please review. Index: col.1 =================================================================== RCS file: /home/ncvs/src/usr.bin/col/col.1,v retrieving revision 1.7 diff -u -r1.7 col.1 --- col.1 2001/05/11 23:53:46 1.7 +++ col.1 2001/05/27 04:55:41 @@ -43,7 +43,7 @@ .Nd filter reverse line feeds from input .Sh SYNOPSIS .Nm -.Op Fl bfhx +.Op Fl bfhpx .Op Fl l Ar num .Sh DESCRIPTION .Nm Col @@ -69,6 +69,12 @@ on the following line. .It Fl h Don't output multiple spaces instead of tabs (default). +.It Fl p +Force unknown control sequences to be passed through unchanged. +Normally, +.Nm +will filter out any control sequences from the input other than those +recognized and interpreted by itself, which are listed below. .It Fl x Output multiple spaces instead of tabs. .It Fl l Ar num Index: col.c =================================================================== RCS file: /home/ncvs/src/usr.bin/col/col.c,v retrieving revision 1.9 diff -u -r1.9 col.c --- col.c 2001/05/26 22:45:14 1.9 +++ col.c 2001/05/27 04:55:42 @@ -101,7 +101,6 @@ void free_line __P((LINE *)); int main __P((int, char **)); void usage __P((void)); -void wrerr __P((void)); void *xmalloc __P((void *, size_t)); CSET last_set; /* char_set of last char printed */ @@ -111,11 +110,12 @@ int max_bufd_lines; /* max # lines to keep in memory */ int nblank_lines; /* # blanks after last flushed line */ int no_backspaces; /* if not to output any backspaces */ +int pass_unknown_seqs; /* pass unknown control sequences */ #define PUTC(ch) \ - do { \ - if (putchar(ch) == EOF) \ - wrerr(); \ + do { \ + if (putchar(ch) == EOF) \ + errx(1, "write error"); \ } while (0) int @@ -135,11 +135,11 @@ int nflushd_lines; /* number of lines that were flushed */ int adjust, opt, warned; - (void) setlocale(LC_CTYPE, ""); + (void)setlocale(LC_CTYPE, ""); max_bufd_lines = 128; compress_spaces = 1; /* compress spaces into tabs */ - while ((opt = getopt(argc, argv, "bfhl:x")) != -1) + while ((opt = getopt(argc, argv, "bfhl:px")) != -1) switch (opt) { case 'b': /* do not output backspaces */ no_backspaces = 1; @@ -154,6 +154,9 @@ if ((max_bufd_lines = atoi(optarg)) <= 0) errx(1, "bad -l argument %s", optarg); break; + case 'p': /* pass unknown control sequences */ + pass_unknown_seqs = 1; + break; case 'x': /* do not compress spaces into tabs */ compress_spaces = 0; break; @@ -221,7 +224,8 @@ cur_line -= 2; continue; } - continue; + if (!pass_unknown_seqs) + continue; } /* Must stuff ch in a line - are we at the right one? */ @@ -284,8 +288,8 @@ int need; need = l->l_lsize ? l->l_lsize * 2 : 90; - l->l_line = (CHAR *)xmalloc((void *) l->l_line, - (unsigned) need * sizeof(CHAR)); + l->l_line = xmalloc(l->l_line, + (unsigned)need * sizeof(CHAR)); l->l_lsize = need; } c = &l->l_line[l->l_line_len++]; @@ -340,7 +344,7 @@ } nblank_lines++; if (l->l_line) - (void)free((void *)l->l_line); + (void)free(l->l_line); free_line(l); } if (lines) @@ -401,15 +405,15 @@ */ if (l->l_lsize > sorted_size) { sorted_size = l->l_lsize; - sorted = (CHAR *)xmalloc((void *)sorted, + sorted = xmalloc(sorted, (unsigned)sizeof(CHAR) * sorted_size); } if (l->l_max_col >= count_size) { count_size = l->l_max_col + 1; - count = (int *)xmalloc((void *)count, + count = xmalloc(count, (unsigned)sizeof(int) * count_size); } - memset((char *)count, 0, sizeof(int) * l->l_max_col + 1); + memset(count, 0, sizeof(int) * l->l_max_col + 1); for (i = nchars, c = l->l_line; --i >= 0; c++) count[c->c_column]++; @@ -494,7 +498,7 @@ int i; if (!line_freelist) { - l = (LINE *)xmalloc((void *)NULL, sizeof(LINE) * NALLOC); + l = xmalloc(NULL, sizeof(LINE) * NALLOC); line_freelist = l; for (i = 1; i < NALLOC; i++, l++) l->l_next = l + 1; @@ -522,8 +526,8 @@ size_t size; { - if (!(p = (void *)realloc(p, size))) - err(1, NULL); + if (!(p = realloc(p, size))) + err(1, (char *)NULL); return (p); } @@ -531,15 +535,8 @@ usage() { - (void)fprintf(stderr, "usage: col [-bfhx] [-l nline]\n"); + (void)fprintf(stderr, "usage: col [-bfhpx] [-l nline]\n"); exit(1); -} - -void -wrerr() -{ - - errx(1, "write error"); } void Also at: http://people.freebsd.org/~mikeh/diffs/col.diff Mike -- Mike Heffner Fredericksburg, VA http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Mon May 28 0: 1:16 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.13]) by hub.freebsd.org (Postfix) with SMTP id E374D37B423 for ; Mon, 28 May 2001 00:01:12 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 9231 invoked by uid 1000); 28 May 2001 07:00:17 -0000 Date: Mon, 28 May 2001 10:00:17 +0300 From: Peter Pentchev To: Mike Heffner Cc: freebsd-audit@freebsd.org Subject: Re: cmp(1) patch Message-ID: <20010528100017.B8450@ringworld.oblivion.bg> Mail-Followup-To: Mike Heffner , freebsd-audit@freebsd.org References: <20010527232926.A85869@cowpie.acm.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010527232926.A85869@cowpie.acm.vt.edu>; from mheffner@cowpie.acm.vt.edu on Sun, May 27, 2001 at 11:29:27PM -0400 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, May 27, 2001 at 11:29:27PM -0400, Mike Heffner wrote: > BDECFLAGS cleanup, respect -s flag in one place, return instead of > exit() at end of main. Please review. > > Index: cmp.c > =================================================================== > RCS file: /home/ncvs/src/usr.bin/cmp/cmp.c,v > retrieving revision 1.9 > diff -u -r1.9 cmp.c > --- cmp.c 2000/07/25 13:01:34 1.9 > +++ cmp.c 2001/05/26 21:57:56 > @@ -58,6 +58,7 @@ > > int lflag, sflag, xflag, zflag; > > +int main __P((int, char *[])); > static void usage __P((void)); Does gcc with BDECFLAGS really complain for a missing prototype on main()? I thought gcc was smart enough (it is, at least on -stable).. [roam@ringworld:v4 ~/c/misc/foo]$ cat Makefile CFLAGS+= ${BDECFLAGS} PROG= foo NOMAN= yes .include [roam@ringworld:v4 ~/c/misc/foo]$ cat foo.c #include int main(int argc __unused, char *argv[] __unused) { printf("Hell world!\n"); return (0); } [roam@ringworld:v4 ~/c/misc/foo]$ make clean all rm -f foo foo.o Warning: Object directory not changed from original /usr/home/roam/lang/c/misc/foo cc -O -pipe -W -Wall -ansi -pedantic -Wbad-function-cast -Wcast-align -Wcast-qual -Wchar-subscripts -Winline -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings -c foo.c cc -O -pipe -W -Wall -ansi -pedantic -Wbad-function-cast -Wcast-align -Wcast-qual -Wchar-subscripts -Winline -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings -o foo foo.o G'luck, Peter -- If I had finished this sentence, To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Mon May 28 0: 2:55 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.13]) by hub.freebsd.org (Postfix) with SMTP id 7747137B422 for ; Mon, 28 May 2001 00:02:52 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 9249 invoked by uid 1000); 28 May 2001 07:01:58 -0000 Date: Mon, 28 May 2001 10:01:58 +0300 From: Peter Pentchev To: Mike Heffner Cc: freebsd-audit@freebsd.org Subject: Re: cmp(1) patch Message-ID: <20010528100158.C8450@ringworld.oblivion.bg> Mail-Followup-To: Mike Heffner , freebsd-audit@freebsd.org References: <20010527232926.A85869@cowpie.acm.vt.edu> <20010528100017.B8450@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010528100017.B8450@ringworld.oblivion.bg>; from roam@orbitel.bg on Mon, May 28, 2001 at 10:00:17AM +0300 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, May 28, 2001 at 10:00:17AM +0300, Peter Pentchev wrote: > On Sun, May 27, 2001 at 11:29:27PM -0400, Mike Heffner wrote: > > BDECFLAGS cleanup, respect -s flag in one place, return instead of > > exit() at end of main. Please review. > > > > Index: cmp.c > > =================================================================== > > RCS file: /home/ncvs/src/usr.bin/cmp/cmp.c,v > > retrieving revision 1.9 > > diff -u -r1.9 cmp.c > > --- cmp.c 2000/07/25 13:01:34 1.9 > > +++ cmp.c 2001/05/26 21:57:56 > > @@ -58,6 +58,7 @@ > > > > int lflag, sflag, xflag, zflag; > > > > +int main __P((int, char *[])); > > static void usage __P((void)); > > Does gcc with BDECFLAGS really complain for a missing prototype on main()? > I thought gcc was smart enough (it is, at least on -stable).. Eh, nevermind. Of course you're modifying programs with old K&R function declarations, where the declarations themselves are not prototypes. Sorry. G'luck, Peter -- When you are not looking at it, this sentence is in Spanish. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Mon May 28 1:42:20 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id F33F937B424 for ; Mon, 28 May 2001 01:42:14 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA07315; Mon, 28 May 2001 18:42:03 +1000 Date: Mon, 28 May 2001 18:40:31 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Mike Heffner Cc: freebsd-audit@FreeBSD.ORG Subject: Re: cmp(1) patch In-Reply-To: <20010527232926.A85869@cowpie.acm.vt.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 27 May 2001, Mike Heffner wrote: > BDECFLAGS cleanup, respect -s flag in one place, return instead of > exit() at end of main. Please review. > > Index: cmp.c > =================================================================== > RCS file: /home/ncvs/src/usr.bin/cmp/cmp.c,v > retrieving revision 1.9 > diff -u -r1.9 cmp.c > --- cmp.c 2000/07/25 13:01:34 1.9 > +++ cmp.c 2001/05/26 21:57:56 > ... > @@ -117,9 +118,13 @@ > exit(1); > } > if (strcmp(file2 = argv[1], "-") == 0) { > - if (special) > - errx(ERR_EXIT, > + if (special) { > + if (!sflag) > + errx(ERR_EXIT, > "standard input may only be specified once"); > + else > + exit(1); > + } > special = 1; > fd2 = 0; > file2 = "stdin"; This change seems to be just a bug. -s is only required (by POSIX) to suppress output to stdout (in particular, it must suppress the message about differing files). The above suppresses output to stderr for a usage error. Output to stderr is still done for other usage errors. > ... > @@ -160,14 +165,14 @@ > else { > if (zflag && sb1.st_size != sb2.st_size) { > if (!sflag) > - (void) printf("%s %s differ: size\n", > + (void)printf("%s %s differ: size\n", > file1, file2); > exit(DIFF_EXIT); > } > c_regular(fd1, file1, skip1, sb1.st_size, > fd2, file2, skip2, sb2.st_size); > } > - exit(0); > + return (0); gcc should understand that exit() doesn't return, and not warn for exit(0). > Index: regular.c > =================================================================== > RCS file: /home/ncvs/src/usr.bin/cmp/regular.c,v > retrieving revision 1.10 > diff -u -r1.10 regular.c > --- regular.c 2000/06/20 20:28:40 1.10 > +++ regular.c 2001/05/26 21:57:57 > ... > @@ -81,8 +81,10 @@ > off2 = ROUNDPAGE(skip2); > > length = MIN(len1, len2); > - if (length > SIZE_T_MAX) > - return (c_special(fd1, file1, skip1, fd2, file2, skip2)); > + if (length > SIZE_T_MAX) { > + c_special(fd1, file1, skip1, fd2, file2, skip2); > + return; > + } > > if ((p1 = (u_char *)mmap(NULL, (size_t)len1 + skip1 % pagesize, > PROT_READ, MAP_SHARED, fd1, off1)) == (u_char *)MAP_FAILED) This code has several bugs that should be fixed someday: - casting len1 (and later len2) to size_t may overflow. We only checked that MIN(len1, len2) fits in a size_t. mmap()'ing more than `length' (rounded up a little?) bytes is a bug. The CSRG version was missing this bug, but apparently had others. - adding skip1 % pagesize may cause another overflow. - the mmap() (or the later one) may fail for various reasons. E.g., the files may have length 3GB each. It is impossible for mmap() to map two files of length 3GB each on i386's, since there is at most 4GB of vm to map them in (the mmap() will actually fail much earlier, near 2 * 1.25GB). c_special() should be used if either of the mmap()s fails. Note that the SIZE_T_MAX check isn't intended to make mmap() work. It is just intended to prevent overflow when the size arg for mmap is squeezed into a size_t. But even that is botched here. Many utilities that call mmap() have similar bugs. One already has a wrong fix for mmap() failure. > @@ -101,10 +103,12 @@ > if ((ch = *p1) != *p2) { > if (xflag) { > dfound = 1; > - (void)printf("%08qx %02x %02x\n", byte - 1, ch, *p2); > + (void)printf("%08llx %02x %02x\n", > + (long long)byte - 1, ch, *p2); Using hard "long long" breaks ISO C (C90) support, not to mention K&R support, and is also wrong for C99. intmax_t should be used for C99, but we don't have either intma_t or a C99 compiler yet. There are still printf format errors here. %llx is for unsigned type, but both the type of `byte' and "long long" are signed types. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Mon May 28 9: 2:58 2001 Delivered-To: freebsd-audit@freebsd.org Received: from cowpie.acm.vt.edu (cowpie.acm.vt.edu [128.173.42.253]) by hub.freebsd.org (Postfix) with ESMTP id 019B537B423 for ; Mon, 28 May 2001 09:02:53 -0700 (PDT) (envelope-from mheffner@cowpie.acm.vt.edu) Received: (from mheffner@localhost) by cowpie.acm.vt.edu (8.11.3/8.11.3) id f4SG28b88082; Mon, 28 May 2001 12:02:08 -0400 (EDT) (envelope-from mheffner) Date: Mon, 28 May 2001 12:02:08 -0400 From: Mike Heffner To: Bruce Evans Cc: freebsd-audit@freebsd.org Subject: Re: cmp(1) patch Message-ID: <20010528120208.A87924@cowpie.acm.vt.edu> References: <20010527232926.A85869@cowpie.acm.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from bde@zeta.org.au on Mon, May 28, 2001 at 06:40:31PM +1000 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, May 28, 2001 at 06:40:31PM +1000, Bruce Evans wrote: | On Sun, 27 May 2001, Mike Heffner wrote: | | > BDECFLAGS cleanup, respect -s flag in one place, return instead of | > exit() at end of main. Please review. | > | > Index: cmp.c | > =================================================================== | > RCS file: /home/ncvs/src/usr.bin/cmp/cmp.c,v | > retrieving revision 1.9 | > diff -u -r1.9 cmp.c | > --- cmp.c 2000/07/25 13:01:34 1.9 | > +++ cmp.c 2001/05/26 21:57:56 | > ... | > @@ -117,9 +118,13 @@ | > exit(1); | > } | > if (strcmp(file2 = argv[1], "-") == 0) { | > - if (special) | > - errx(ERR_EXIT, | > + if (special) { | > + if (!sflag) | > + errx(ERR_EXIT, | > "standard input may only be specified once"); | > + else | > + exit(1); | > + } | > special = 1; | > fd2 = 0; | > file2 = "stdin"; | | This change seems to be just a bug. -s is only required (by POSIX) to | suppress output to stdout (in particular, it must suppress the message | about differing files). The above suppresses output to stderr for a | usage error. Output to stderr is still done for other usage errors. However it is also used to suppress output from open and fstat failing, but I guess in the case of scripts this might be favorable. I'll reverse this part since it's a usage error though. | | > ... | > @@ -160,14 +165,14 @@ | > else { | > if (zflag && sb1.st_size != sb2.st_size) { | > if (!sflag) | > - (void) printf("%s %s differ: size\n", | > + (void)printf("%s %s differ: size\n", | > file1, file2); | > exit(DIFF_EXIT); | > } | > c_regular(fd1, file1, skip1, sb1.st_size, | > fd2, file2, skip2, sb2.st_size); | > } | > - exit(0); | > + return (0); | | gcc should understand that exit() doesn't return, and not warn for exit(0). Ok, I just thought return looked better at the end of main =), but I'll leave exit() in there. | | > Index: regular.c | > =================================================================== | > RCS file: /home/ncvs/src/usr.bin/cmp/regular.c,v | > retrieving revision 1.10 | > diff -u -r1.10 regular.c | > --- regular.c 2000/06/20 20:28:40 1.10 | > +++ regular.c 2001/05/26 21:57:57 | > ... | > @@ -81,8 +81,10 @@ | > off2 = ROUNDPAGE(skip2); | > | > length = MIN(len1, len2); | > - if (length > SIZE_T_MAX) | > - return (c_special(fd1, file1, skip1, fd2, file2, skip2)); | > + if (length > SIZE_T_MAX) { | > + c_special(fd1, file1, skip1, fd2, file2, skip2); | > + return; | > + } | > | > if ((p1 = (u_char *)mmap(NULL, (size_t)len1 + skip1 % pagesize, | > PROT_READ, MAP_SHARED, fd1, off1)) == (u_char *)MAP_FAILED) | | This code has several bugs that should be fixed someday: | - casting len1 (and later len2) to size_t may overflow. We only checked | that MIN(len1, len2) fits in a size_t. mmap()'ing more than `length' | (rounded up a little?) bytes is a bug. The CSRG version was missing | this bug, but apparently had others. Changing the 'if (length > SIZE_T_MAX)' to 'if (MAX(len1, len2) > SIZE_T_MAX)' (plus possibly the skip lengths) should fix the overflowing on size_t issue right? | - adding skip1 % pagesize may cause another overflow. | - the mmap() (or the later one) may fail for various reasons. E.g., the | files may have length 3GB each. It is impossible for mmap() to map | two files of length 3GB each on i386's, since there is at most 4GB of | vm to map them in (the mmap() will actually fail much earlier, near | 2 * 1.25GB). c_special() should be used if either of the mmap()s fails. | Note that the SIZE_T_MAX check isn't intended to make mmap() work. It | is just intended to prevent overflow when the size arg for mmap is | squeezed into a size_t. But even that is botched here. I'll try to address this issue, to call c_special when mmap fails and fix the overflow checks, when I redo the patch. | | Many utilities that call mmap() have similar bugs. One already has a wrong | fix for mmap() failure. | | > @@ -101,10 +103,12 @@ | > if ((ch = *p1) != *p2) { | > if (xflag) { | > dfound = 1; | > - (void)printf("%08qx %02x %02x\n", byte - 1, ch, *p2); | > + (void)printf("%08llx %02x %02x\n", | > + (long long)byte - 1, ch, *p2); | | Using hard "long long" breaks ISO C (C90) support, not to mention K&R | support, and is also wrong for C99. intmax_t should be used for C99, | but we don't have either intma_t or a C99 compiler yet. | | There are still printf format errors here. %llx is for unsigned type, but | both the type of `byte' and "long long" are signed types. So should it be left with `%qx', or should byte be typecasted unsigned and use `%llx'? Thanks for looking at this by the way ;) -- Mike Heffner Fredericksburg, VA http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue May 29 11:39:31 2001 Delivered-To: freebsd-audit@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id AA37E37B423; Tue, 29 May 2001 11:39:28 -0700 (PDT) (envelope-from mike@q9media.com) Received: from [192.168.1.10] (vega.tct.net [216.94.230.13]) by coffee.q9media.com (8.11.2/8.11.2) with ESMTP id f4TIlrL84631; Tue, 29 May 2001 14:47:53 -0400 (EDT) (envelope-from mike@q9media.com) User-Agent: Microsoft-Outlook-Express-Macintosh-Edition/5.02.2022 Date: Tue, 29 May 2001 14:39:22 -0400 Subject: whois(1) patch From: Mike Barcroft To: Cc: Message-ID: Mime-version: 1.0 Organization: q9 media Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Please review the patch at the following URL: http://testbed.q9media.net/freebsd/whois.patch It does the following: o Silence warnings and set WARNS=2 o Fix two memory leaks o asprint -> strdup where appropriate o calloc/strcpy/strcat -> aprintf o Convert to ANSI C to avoid having to prototype main() Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue May 29 20:23:28 2001 Delivered-To: freebsd-audit@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id CAB3B37B422 for ; Tue, 29 May 2001 20:23:24 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 6D5A13E0B for ; Tue, 29 May 2001 20:23:24 -0700 (PDT) To: audit@freebsd.org Subject: last(1) WARNS patch for review Date: Tue, 29 May 2001 20:23:24 -0700 From: Dima Dorfman Message-Id: <20010530032324.6D5A13E0B@bazooka.unixfreak.org> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Please review the attached patch to last(1) which silences most of the warnings. I'm particuarly doubtful about the printf formatting changes. They seem to be correct, but there might've been a reason why they were originally written incorrectly (a reason other than not compiling with the right -W flags). With this, last(1) is ready for WARNS=2 modulo the lack of a prototype for main(), but that shouldn't be a problem once David O'Brien applies my patch to gcc which shuts it up in this case (see cvs-all thread about jot). Thanks, Dima Dorfman dima@unixfreak.org Index: last.c =================================================================== RCS file: /stl/src/FreeBSD/src/usr.bin/last/last.c,v retrieving revision 1.18 diff -u -r1.18 last.c --- last.c 2001/05/28 09:57:19 1.18 +++ last.c 2001/05/30 02:32:28 @@ -34,13 +34,13 @@ */ #ifndef lint -static char copyright[] = +static const char copyright[] = "@(#) Copyright (c) 1987, 1993, 1994\n\ The Regents of the University of California. All rights reserved.\n"; #endif /* not lint */ #ifndef lint -static char sccsid[] = "@(#)last.c 8.2 (Berkeley) 4/2/94"; +static const char sccsid[] = "@(#)last.c 8.2 (Berkeley) 4/2/94"; #endif /* not lint */ #include @@ -86,7 +86,7 @@ static long currentout, /* current logout value */ maxrec; /* records to display */ -static char *file = _PATH_WTMP; /* wtmp file */ +static const char *file = _PATH_WTMP; /* wtmp file */ static int sflag = 0; /* show delta in seconds */ static int width = 5; /* show seconds in delta */ static int d_first; @@ -102,6 +102,7 @@ time_t dateconv __P((char *)); int want __P((struct utmp *)); void wtmp __P((void)); +void usage __P((void)); void usage(void) @@ -196,7 +197,7 @@ long bl; time_t delta; /* time difference */ int bytes, wfd; - char *crmsg; + const char *crmsg; char ct[80]; struct tm *tm; int snapfound = 0; /* found snapshot entry? */ @@ -338,7 +339,7 @@ } delta = tt->logout - bp->ut_time; if ( sflag ) { - printf(" (%8lu)\n", + printf(" (%8u)\n", delta); } else { tm = gmtime(&delta); @@ -348,7 +349,7 @@ if (delta < 86400) printf(" (%s)\n", ct); else - printf(" (%ld+%s)\n", + printf(" (%d+%s)\n", delta / 86400, ct); } } @@ -359,7 +360,7 @@ } } tm = localtime(&buf[0].ut_time); - (void) strftime(ct, sizeof(ct), "\nwtmp begins %c\n", tm); + (void) strftime(ct, sizeof(ct), "\nwtmp begins %+\n", tm); printf("%s", ct); } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed May 30 1:23:30 2001 Delivered-To: freebsd-audit@freebsd.org Received: from kawoserv.kawo2.rwth-aachen.de (kawoserv.kawo2.RWTH-Aachen.DE [134.130.180.1]) by hub.freebsd.org (Postfix) with ESMTP id D082637B43C for ; Wed, 30 May 2001 01:23:27 -0700 (PDT) (envelope-from alex@big.endian.de) Received: from zerogravity.kawo2.rwth-aachen.de (zerogravity.kawo2.rwth-aachen.de [134.130.181.28]) by kawoserv.kawo2.rwth-aachen.de (8.9.3/8.6.9) with ESMTP id KAA27758; Wed, 30 May 2001 10:23:23 +0200 Received: by zerogravity.kawo2.rwth-aachen.de (Postfix, from userid 1001) id 31BB614AE7; Wed, 30 May 2001 10:23:23 +0200 (CEST) Date: Wed, 30 May 2001 10:23:23 +0200 From: Alexander Langer To: Dima Dorfman Cc: audit@FreeBSD.ORG Subject: Re: last(1) WARNS patch for review Message-ID: <20010530102323.B610@zerogravity.kawo2.rwth-aachen.d> References: <20010530032324.6D5A13E0B@bazooka.unixfreak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010530032324.6D5A13E0B@bazooka.unixfreak.org>; from dima@unixfreak.org on Tue, May 29, 2001 at 08:23:24PM -0700 X-PGP-Fingerprint: 44 28 CA 4C 46 5B D3 A8 A8 E3 BA F3 4E 60 7D 7F X-PGP-at: finger alex@big.endian.de X-Verwirrung: Dieser Header dient der allgemeinen Verwirrung. Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Thus spake Dima Dorfman (dima@unixfreak.org): > changes. They seem to be correct, but there might've been a reason > why they were originally written incorrectly (a reason other than not > compiling with the right -W flags). Yes, the reason was, that time_t was long before on some platforms. Alex -- cat: /home/alex/.sig: No such file or directory To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed May 30 19:37:43 2001 Delivered-To: freebsd-audit@freebsd.org Received: from iatl0x01.coxmail.com (iatl0x02.coxmail.com [206.157.225.11]) by hub.freebsd.org (Postfix) with ESMTP id 5E44637B424; Wed, 30 May 2001 19:37:40 -0700 (PDT) (envelope-from mheffner@novacoxmail.com) Received: from enterprise.muriel.penguinpowered.com ([208.138.198.178]) by iatl0x01.coxmail.com (InterMail vK.4.03.02.00 201-232-124 license 85f4f10023be2bd3bce00b3a38363ea2) with ESMTP id <20010531023714.MAIU19826.iatl0x01@enterprise.muriel.penguinpowered.com>; Wed, 30 May 2001 22:37:14 -0400 Message-ID: X-Mailer: XFMail 1.4.7 on FreeBSD X-Priority: 3 (Normal) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="_=XFMail.1.4.7.FreeBSD:20010530223446:495=_"; micalg=pgp-md5; protocol="application/pgp-signature" In-Reply-To: Date: Wed, 30 May 2001 22:34:46 -0400 (EDT) Reply-To: Mike Heffner From: Mike Heffner To: Mike Barcroft Subject: RE: whois(1) patch Cc: phk@freebsd.org, freebsd-audit@freebsd.org Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This message is in MIME format --_=XFMail.1.4.7.FreeBSD:20010530223446:495=_ Content-Type: text/plain; charset=us-ascii On 29-May-2001 Mike Barcroft wrote: | | Please review the patch at the following URL: | http://testbed.q9media.net/freebsd/whois.patch | | | It does the following: | | o Silence warnings and set WARNS=2 | o Fix two memory leaks | o asprint -> strdup where appropriate | o calloc/strcpy/strcat -> aprintf | o Convert to ANSI C to avoid having to prototype main() You don't need the space between (void) and asprintf(). Also, I think dd had a patch for gcc to quiet the warning about main() not having a prototype, so I don't know if the ANSI-fication is truly needed. Otherwise, looks alright ;) Mike -- Mike Heffner Fredericksburg, VA http://filebox.vt.edu/users/mheffner --_=XFMail.1.4.7.FreeBSD:20010530223446:495=_ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7Fa3FFokZQs3sv5kRAhvyAJ0cPsKqhzBNkw8v4CXqi9RVA8LJMwCgkKLD i9HNo2yIHd62cxQC4B5r8QM= =8m0m -----END PGP SIGNATURE----- --_=XFMail.1.4.7.FreeBSD:20010530223446:495=_-- End of MIME message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed May 30 23:45:24 2001 Delivered-To: freebsd-audit@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id A367E37B424 for ; Wed, 30 May 2001 23:45:22 -0700 (PDT) (envelope-from imp@harmony.village.org) Received: (from imp@localhost) by harmony.village.org (8.11.3/8.11.1) id f4V6jLo89823 for audit@freebsd.org; Thu, 31 May 2001 00:45:21 -0600 (MDT) (envelope-from imp) Date: Thu, 31 May 2001 00:45:21 -0600 (MDT) From: Warner Losh Message-Id: <200105310645.f4V6jLo89823@harmony.village.org> To: audit@freebsd.org Subject: pciconf change Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Here's a change to allow one to say pciconf -r 0:0xbf and have it read all registers from 0 though 0xbf, rounded up to the width size. Please review and let me know what you think http://people.freebsd.org/~imp/pciconf.diff Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu May 31 11:30:36 2001 Delivered-To: freebsd-audit@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id D6C0B37B422; Thu, 31 May 2001 11:30:33 -0700 (PDT) (envelope-from mike@q9media.com) Received: from [192.168.1.10] (vega.tct.net [216.94.230.13]) by coffee.q9media.com (8.11.2/8.11.2) with ESMTP id f4VIdBL87734; Thu, 31 May 2001 14:39:12 -0400 (EDT) (envelope-from mike@q9media.com) User-Agent: Microsoft-Outlook-Express-Macintosh-Edition/5.02.2022 Date: Thu, 31 May 2001 14:30:21 -0400 Subject: Re: whois(1) patch From: Mike Barcroft To: Mike Heffner Cc: , Message-ID: In-Reply-To: Mime-version: 1.0 Organization: q9 media Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 5/30/01 10:34 PM, Mike Heffner at mheffner@novacoxmail.com wrote: > On 29-May-2001 Mike Barcroft wrote: > | > | Please review the patch at the following URL: > | http://testbed.q9media.net/freebsd/whois.patch > | > | > | It does the following: > | > | o Silence warnings and set WARNS=2 > | o Fix two memory leaks > | o asprint -> strdup where appropriate > | o calloc/strcpy/strcat -> aprintf > | o Convert to ANSI C to avoid having to prototype main() > > You don't need the space between (void) and asprintf(). Also, I think dd had a > patch for gcc to quiet the warning about main() not having a prototype, so I > don't know if the ANSI-fication is truly needed. Otherwise, looks alright ;) Oops, how'd that space sneak in there. I've removed the space from the patch. I must be spending too much time looking at sendmail's source. :) I originally made the ANSI C change to silence a warning, but is there any reason not to bring the code up to ANSI C spec? Is it likely that anyone will need to compile whois with a K&R compiler? Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu May 31 15:28:47 2001 Delivered-To: freebsd-audit@freebsd.org Received: from iatl0x01.coxmail.com (iatl0x02.coxmail.com [206.157.225.11]) by hub.freebsd.org (Postfix) with ESMTP id 0C96D37B423; Thu, 31 May 2001 15:28:44 -0700 (PDT) (envelope-from mheffner@novacoxmail.com) Received: from enterprise.muriel.penguinpowered.com ([208.138.198.178]) by iatl0x01.coxmail.com (InterMail vK.4.03.02.00 201-232-124 license 85f4f10023be2bd3bce00b3a38363ea2) with ESMTP id <20010531222819.NTGD19826.iatl0x01@enterprise.muriel.penguinpowered.com>; Thu, 31 May 2001 18:28:19 -0400 Message-ID: X-Mailer: XFMail 1.4.7 on FreeBSD X-Priority: 3 (Normal) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="_=XFMail.1.4.7.FreeBSD:20010531182606:495=_"; micalg=pgp-md5; protocol="application/pgp-signature" In-Reply-To: Date: Thu, 31 May 2001 18:26:06 -0400 (EDT) Reply-To: Mike Heffner From: Mike Heffner To: Mike Barcroft Subject: Re: whois(1) patch Cc: freebsd-audit@freebsd.org, phk@freebsd.org, Mike Heffner Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This message is in MIME format --_=XFMail.1.4.7.FreeBSD:20010531182606:495=_ Content-Type: text/plain; charset=us-ascii On 31-May-2001 Mike Barcroft wrote: | | I originally made the ANSI C change to silence a warning, but is there any | reason not to bring the code up to ANSI C spec? Is it likely that anyone | will need to compile whois with a K&R compiler? It's not likely, but I'm not sure on what the consensus is on ANSI-fication. Technically, style(9) says it shouldn't be done in this case, but people (myself included) have been removing K&R support in small patches like this one. I think there was also talk of doing a full sweep to remove __P. Mike -- Mike Heffner Fredericksburg, VA http://filebox.vt.edu/users/mheffner --_=XFMail.1.4.7.FreeBSD:20010531182606:495=_ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7FsT+FokZQs3sv5kRAgUnAJ9/uA4un4VZ6tgJez1Tb/BXMn0BNQCdEr7a sVL7deK2qsrXsBKXInMHHoc= =tYAY -----END PGP SIGNATURE----- --_=XFMail.1.4.7.FreeBSD:20010531182606:495=_-- End of MIME message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu May 31 21:50:10 2001 Delivered-To: freebsd-audit@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 0488F37B423 for ; Thu, 31 May 2001 21:50:08 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 629243E2F for ; Thu, 31 May 2001 21:50:07 -0700 (PDT) To: audit@freebsd.org Subject: sysctl fix for zero-length data Date: Thu, 31 May 2001 21:50:07 -0700 From: Dima Dorfman Message-Id: <20010601045007.629243E2F@bazooka.unixfreak.org> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Please review the attached patch to fix the sysctl interface to accept data of zero length. This fixes the case where one wants to clear a string exported via sysctl, as in: sysctl kern.hostname= Right now, the above will do nothing. With this patch, it will clear (i.e., set to "") "kern.hostname". Thanks, Dima Dorfman dima@unixfreak.org Index: kern_sysctl.c =================================================================== RCS file: /stl/src/FreeBSD/src/sys/kern/kern_sysctl.c,v retrieving revision 1.107 diff -u -r1.107 kern_sysctl.c --- kern_sysctl.c 2001/05/19 05:45:55 1.107 +++ kern_sysctl.c 2001/06/01 04:46:47 @@ -862,7 +907,7 @@ req.oldptr= old; } - if (newlen) { + if (new != NULL) { req.newlen = newlen; req.newptr = new; } @@ -1126,7 +1171,7 @@ req.oldptr= old; } - if (newlen) { + if (new != NULL) { if (!useracc(new, req.newlen, VM_PROT_READ)) return (EFAULT); req.newlen = newlen; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jun 1 14: 8:40 2001 Delivered-To: freebsd-audit@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id 3582A37B423; Fri, 1 Jun 2001 14:08:36 -0700 (PDT) (envelope-from mike@q9media.com) Received: from [192.168.1.10] (vega.tct.net [216.94.230.13]) by coffee.q9media.com (8.11.2/8.11.2) with ESMTP id f51LHYL89393; Fri, 1 Jun 2001 17:17:35 -0400 (EDT) (envelope-from mike@q9media.com) User-Agent: Microsoft-Outlook-Express-Macintosh-Edition/5.02.2022 Date: Fri, 01 Jun 2001 17:08:30 -0400 Subject: Removing __P() (was Re: whois(1) patch) From: Mike Barcroft To: Cc: Mike Heffner Message-ID: In-Reply-To: Mime-version: 1.0 Organization: q9 media Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [Moved to -arch, BCC'd to -audit] On 5/31/01 6:26 PM, Mike Heffner at mheffner@novacoxmail.com wrote: > On 31-May-2001 Mike Barcroft wrote: > | > | I originally made the ANSI C change to silence a warning, but is there any > | reason not to bring the code up to ANSI C spec? Is it likely that anyone > | will need to compile whois with a K&R compiler? > > It's not likely, but I'm not sure on what the consensus is on ANSI-fication. > Technically, style(9) says it shouldn't be done in this case, but people > (myself included) have been removing K&R support in small patches like this > one. I think there was also talk of doing a full sweep to remove __P. Does anyone have any objections to removing __P() and converting prototypes to ANSI C, as part of binary cleaning up/auditing? Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jun 1 17: 8:58 2001 Delivered-To: freebsd-audit@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 0888037B423; Fri, 1 Jun 2001 17:08:54 -0700 (PDT) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.11.3/8.11.3) id f5208qn34539; Sat, 2 Jun 2001 04:08:53 +0400 (MSD) (envelope-from ache) Date: Sat, 2 Jun 2001 04:08:51 +0400 From: "Andrey A. Chernov" To: i18n@freebsd.org, audit@freebsd.org Subject: 2CFR: locale names renaming Message-ID: <20010602040851.A34526@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Well, I decide to move to X11 codeset and stay compatible with other *BSD locale names, here is new proposed scheme: *.ISO_*.src -> *.ISO*.src map.ISO_* -> map.ISO* (in colldef) *.ASCII.src -> *.US-ASCII.src ja_JP.EUC.src -> ja_JP.eucJP.src ko_KR.EUC.src -> ko_KR.eucKR.src zh_CN.EUC.src -> zh_CN.eucCN.src zh_TW.Big5.src -> zh_TW.BIG5.src Any comments? -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jun 1 23:40:47 2001 Delivered-To: freebsd-audit@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 04C6837B423 for ; Fri, 1 Jun 2001 23:40:45 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id AD9263E32 for ; Fri, 1 Jun 2001 23:40:44 -0700 (PDT) To: audit@freebsd.org Subject: cut(1) WARNS patch Date: Fri, 01 Jun 2001 23:40:44 -0700 From: Dima Dorfman Message-Id: <20010602064044.AD9263E32@bazooka.unixfreak.org> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Attached is a patch which silences the remaining warnings for cut(1). It's rather trivial, but I'd like someone to confirm that the first change is correct. 'stop' is a size_t, which is long on the Alpha but int on the i386. The fix below to print it using %ld and cast it to long seems to be logically correct (and it works). Thanks in advance, Dima Dorfman dima@unixfreak.org Index: cut.c =================================================================== RCS file: /stl/src/FreeBSD/src/usr.bin/cut/cut.c,v retrieving revision 1.13 diff -u -r1.13 cut.c --- cut.c 2001/04/25 05:42:53 1.13 +++ cut.c 2001/06/02 06:37:39 @@ -172,8 +172,8 @@ if (!stop || !start) errx(1, "[-cf] list: values may not include zero"); if (stop > _POSIX2_LINE_MAX) - errx(1, "[-cf] list: %d too large (max %d)", - stop, _POSIX2_LINE_MAX); + errx(1, "[-cf] list: %ld too large (max %d)", + (long)stop, _POSIX2_LINE_MAX); if (maxval < stop) maxval = stop; for (pos = positions + start; start++ <= stop; *pos++ = 1); @@ -223,7 +223,7 @@ void f_cut(fp, fname) FILE *fp; - const char *fname; + const char *fname __unused; { int ch, field, isdelim; char *pos, *p, sep; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 0:42:46 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.13]) by hub.freebsd.org (Postfix) with SMTP id 57C1037B43F for ; Sat, 2 Jun 2001 00:42:41 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 25066 invoked by uid 1000); 2 Jun 2001 07:41:38 -0000 Date: Sat, 2 Jun 2001 10:41:38 +0300 From: Peter Pentchev To: Dima Dorfman Cc: audit@freebsd.org Subject: Re: sysctl fix for zero-length data Message-ID: <20010602104137.A24747@ringworld.oblivion.bg> Mail-Followup-To: Dima Dorfman , audit@freebsd.org References: <20010601045007.629243E2F@bazooka.unixfreak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010601045007.629243E2F@bazooka.unixfreak.org>; from dima@unixfreak.org on Thu, May 31, 2001 at 09:50:07PM -0700 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, May 31, 2001 at 09:50:07PM -0700, Dima Dorfman wrote: > Please review the attached patch to fix the sysctl interface to accept > data of zero length. This fixes the case where one wants to clear a > string exported via sysctl, as in: > > sysctl kern.hostname= > > Right now, the above will do nothing. With this patch, it will clear > (i.e., set to "") "kern.hostname". About time, too! Hope this one gets committed soon :) FWIW, I've been running it here for a couple of months (ever since it came up back in January), and there have been no adverse effects of setting string sysctl's to empty strings. G'luck, Peter -- If this sentence didn't exist, somebody would have invented it. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 1:20:11 2001 Delivered-To: freebsd-audit@freebsd.org Received: from daemon.kr.FreeBSD.org (daemon.kr.freebsd.org [211.176.62.31]) by hub.freebsd.org (Postfix) with ESMTP id 6D02B37B424; Sat, 2 Jun 2001 01:20:05 -0700 (PDT) (envelope-from cjh@kr.FreeBSD.ORG) Received: from gradius.wdb.co.kr (daemon [211.176.62.31]) by daemon.kr.FreeBSD.org (Postfix) with ESMTP id 230D08F61D; Sat, 2 Jun 2001 17:21:46 +0900 (KST) Received: (from cjh@localhost) by gradius.wdb.co.kr (8.11.4/8.11.3) id f528I1003435; Sat, 2 Jun 2001 17:18:01 +0900 (KST) (envelope-from cjh@kr.FreeBSD.ORG) X-Authentication-Warning: gradius.wdb.co.kr: cjh set sender to cjh@kr.FreeBSD.ORG using -f To: "Andrey A. Chernov" Cc: i18n@freebsd.org, audit@freebsd.org Subject: Re: 2CFR: locale names renaming References: <20010602040851.A34526@nagual.pp.ru> From: CHOI Junho Organization: Korea FreeBSD Users Group Date: 02 Jun 2001 17:17:53 +0900 In-Reply-To: <20010602040851.A34526@nagual.pp.ru> Message-ID: <86ofs7thvy.fsf@gradius.wdb.co.kr> Lines: 30 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >>>>> "AAC" == Andrey A Chernov writes: AAC> Well, I decide to move to X11 codeset and stay compatible with other *BSD AAC> locale names, here is new proposed scheme: AAC> *.ISO_*.src -> *.ISO*.src AAC> map.ISO_* -> map.ISO* (in colldef) AAC> *.ASCII.src -> *.US-ASCII.src AAC> ja_JP.EUC.src -> ja_JP.eucJP.src AAC> ko_KR.EUC.src -> ko_KR.eucKR.src AAC> zh_CN.EUC.src -> zh_CN.eucCN.src AAC> zh_TW.Big5.src -> zh_TW.BIG5.src AAC> Any comments? Is backward compatibility preserved? Currently FreeBSD locale system doesn't permit aliases, so if ko_KR.EUC changed to ko_KR.eucKR (I definitely agree with it), it can break many application or user configuration of locale. -- +++ Any opinions in this posting are my own and not those of my employers +++ CHOI Junho [sleeping now] [while sleeping] Korea FreeBSD Users Group Web Data Bank To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 3:31:55 2001 Delivered-To: freebsd-audit@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 3134F37B424; Sat, 2 Jun 2001 03:31:50 -0700 (PDT) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.11.3/8.11.3) id f52AVgL43329; Sat, 2 Jun 2001 14:31:43 +0400 (MSD) (envelope-from ache) Date: Sat, 2 Jun 2001 14:31:40 +0400 From: "Andrey A. Chernov" To: CHOI Junho Cc: i18n@freebsd.org, audit@freebsd.org Subject: Re: 2CFR: locale names renaming Message-ID: <20010602143139.A43237@nagual.pp.ru> References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <86ofs7thvy.fsf@gradius.wdb.co.kr>; from cjh@kr.FreeBSD.ORG on Sat, Jun 02, 2001 at 05:17:53PM +0900 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jun 02, 2001 at 17:17:53 +0900, CHOI Junho wrote: > > Is backward compatibility preserved? Currently FreeBSD locale > system doesn't permit aliases, so if ko_KR.EUC changed to ko_KR.eucKR > (I definitely agree with it), it can break many application or user > configuration of locale. It is possible (via symlinks) but I don't think it is good idea, even for transition period. If we preserve compatibility, people never change their environment LANG variables, so programs which parse LANG directly will be in trouble since in each and every such programs we need to add both variants. So there is no advantage of using new scheme since old scheme must be coded each time too. We already have too many locale changes in -current to make it is already incompatible with 4.3 locale, so yet one incompatible change don't play role here. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 4: 9:12 2001 Delivered-To: freebsd-audit@freebsd.org Received: from daemon.kr.FreeBSD.org (daemon.kr.freebsd.org [211.176.62.31]) by hub.freebsd.org (Postfix) with ESMTP id 5EEC737B422; Sat, 2 Jun 2001 04:09:07 -0700 (PDT) (envelope-from cjh@kr.FreeBSD.ORG) Received: from gradius.wdb.co.kr (daemon [211.176.62.31]) by daemon.kr.FreeBSD.org (Postfix) with ESMTP id 843DC8F620; Sat, 2 Jun 2001 20:10:46 +0900 (KST) Received: (from cjh@localhost) by gradius.wdb.co.kr (8.11.4/8.11.3) id f52B74Q05675; Sat, 2 Jun 2001 20:07:04 +0900 (KST) (envelope-from cjh@kr.FreeBSD.ORG) X-Authentication-Warning: gradius.wdb.co.kr: cjh set sender to cjh@kr.FreeBSD.ORG using -f To: "Andrey A. Chernov" Cc: i18n@freebsd.org, audit@freebsd.org Subject: Re: 2CFR: locale names renaming References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> From: CHOI Junho Organization: Korea FreeBSD Users Group Date: 02 Jun 2001 20:07:01 +0900 In-Reply-To: <20010602143139.A43237@nagual.pp.ru> Message-ID: <86wv6vrvhm.fsf@gradius.wdb.co.kr> Lines: 19 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >>>>> "AAC" == Andrey A Chernov writes: AAC> It is possible (via symlinks) but I don't think it is good idea, even for AAC> transition period. If we preserve compatibility, people never change their AAC> environment LANG variables, so programs which parse LANG directly will be AAC> in trouble since in each and every such programs we need to add both AAC> variants. So there is no advantage of using new scheme since old scheme AAC> must be coded each time too. We already have too many locale changes in AAC> -current to make it is already incompatible with 4.3 locale, so yet one AAC> incompatible change don't play role here. If so, why we still have libxpg4 in -current? We can remove that dummy library now. -- +++ Any opinions in this posting are my own and not those of my employers +++ CHOI Junho [sleeping now] [while sleeping] Korea FreeBSD Users Group Web Data Bank To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 4:51:22 2001 Delivered-To: freebsd-audit@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 15D2837B423; Sat, 2 Jun 2001 04:51:17 -0700 (PDT) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.11.3/8.11.3) id f52BpCl44015; Sat, 2 Jun 2001 15:51:12 +0400 (MSD) (envelope-from ache) Date: Sat, 2 Jun 2001 15:51:11 +0400 From: "Andrey A. Chernov" To: CHOI Junho Cc: i18n@freebsd.org, audit@freebsd.org Subject: Re: 2CFR: locale names renaming Message-ID: <20010602155111.A43979@nagual.pp.ru> References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> <86wv6vrvhm.fsf@gradius.wdb.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <86wv6vrvhm.fsf@gradius.wdb.co.kr>; from cjh@kr.FreeBSD.ORG on Sat, Jun 02, 2001 at 08:07:01PM +0900 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jun 02, 2001 at 20:07:01 +0900, CHOI Junho wrote: > >>>>> "AAC" == Andrey A Chernov writes: > > AAC> It is possible (via symlinks) but I don't think it is good idea, even for > AAC> transition period. If we preserve compatibility, people never change their > AAC> environment LANG variables, so programs which parse LANG directly will be > AAC> in trouble since in each and every such programs we need to add both > AAC> variants. So there is no advantage of using new scheme since old scheme > AAC> must be coded each time too. We already have too many locale changes in > AAC> -current to make it is already incompatible with 4.3 locale, so yet one > AAC> incompatible change don't play role here. > > If so, why we still have libxpg4 in -current? We can remove that dummy > library now. I will not object. BTW, the case you mention is different because no per-program changes required with or without libxpg4. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 6:45:29 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail.mk.bsdclub.org (adsl2049.ea.rim.or.jp [202.247.148.49]) by hub.freebsd.org (Postfix) with ESMTP id 0691D37B423; Sat, 2 Jun 2001 06:45:25 -0700 (PDT) (envelope-from motoyuki@mk.bsdclub.org) Received: from sakura.mk.bsdclub.org (sakura.mk.bsdclub.org [3ffe:505:2022:0:2a0:c9ff:fe20:9aff]) by mail.mk.bsdclub.org (8.11.3+3.4W/3.7W/smtpfeed 1.12) with ESMTP/inet6 id f52DjJW65224; Sat, 2 Jun 2001 22:45:19 +0900 (JST) Received: from sakura.mk.bsdclub.org (localhost.mk.bsdclub.org [127.0.0.1]) by sakura.mk.bsdclub.org (8.11.3/3.7W) with ESMTP/inet id f52DjJ218044; Sat, 2 Jun 2001 22:45:19 +0900 (JST) Message-Id: <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> To: "Andrey A. Chernov" Cc: CHOI Junho , i18n@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: 2CFR: locale names renaming From: Motoyuki Konno X-Mailer: mh-e on Mule 2.3 / Emacs 19.34.1 References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII Date: Sat, 02 Jun 2001 22:45:19 +0900 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Andrey A. Chernov" wrote: > It is possible (via symlinks) but I don't think it is good idea, even for > transition period. If we preserve compatibility, people never change their > environment LANG variables, so programs which parse LANG directly will be > in trouble since in each and every such programs we need to add both > variants. In Japan, many scripts and many programs set LANG environment variable. For example, see ports/japanese/mozilla-jlp/files/mozilla.{no,}xpg4. -------- #!/bin/sh LANG=ja_JP.EUC; export LANG cd @PREFIX@/lib/mozilla exec ./mozilla "$@" -------- So, we have to take enough time for transition period. -- ------------------------------------------------------------------------ Motoyuki Konno motoyuki@bsdclub.org (Home) motoyuki@FreeBSD.ORG (FreeBSD Project) http://www.freebsd.org/~motoyuki/ (WWW) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 9:27: 7 2001 Delivered-To: freebsd-audit@freebsd.org Received: from peace.mahoroba.org (peace.calm.imasy.or.jp [202.227.26.34]) by hub.freebsd.org (Postfix) with ESMTP id 8627037B423; Sat, 2 Jun 2001 09:26:58 -0700 (PDT) (envelope-from ume@mahoroba.org) Received: from localhost (IDENT:kFdg6ZoBH/Y7+XursfgRAOEtq7YRmmD6eKia6qs/vTEuFTlWal2kqGVru7OddOtk@localhost [::1]) (authenticated as ume with CRAM-MD5) by peace.mahoroba.org (8.11.3/8.11.3/peace) with ESMTP/inet6 id f52GPpr93665; Sun, 3 Jun 2001 01:25:51 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Sun, 03 Jun 2001 01:25:51 +0900 (JST) Message-Id: <20010603.012551.08401034.ume@mahoroba.org> To: motoyuki@bsdclub.org Cc: ache@nagual.pp.ru, cjh@kr.FreeBSD.ORG, i18n@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: 2CFR: locale names renaming From: Hajimu UMEMOTO In-Reply-To: <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> References: <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> X-Mailer: xcite1.38> Mew version 1.95b119 on Emacs 20.7 / Mule 4.0 =?iso-2022-jp?B?KBskQjJWMWMbKEIp?= X-PGP-Public-Key: http://www.imasy.org/~ume/publickey.asc X-PGP-Fingerprint: 6B 0C 53 FC 5D D0 37 91 05 D0 B3 EF 36 9B 6A BC X-URL: http://www.imasy.org/~ume/ X-Operating-System: FreeBSD 5.0-CURRENT Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >>>>> On Sat, 02 Jun 2001 22:45:19 +0900 >>>>> Motoyuki Konno said: motoyuki> "Andrey A. Chernov" wrote: > It is possible (via symlinks) but I don't think it is good idea, even for > transition period. If we preserve compatibility, people never change their > environment LANG variables, so programs which parse LANG directly will be > in trouble since in each and every such programs we need to add both > variants. motoyuki> In Japan, many scripts and many programs set LANG environment variable. motoyuki> For example, see ports/japanese/mozilla-jlp/files/mozilla.{no,}xpg4. Changing to use ja_JP.eucJP instead of ja_JP.EUC is good thing. However, ja_JP.EUC is widely deployed and we Japanese have been using ja_JP.EUC for a long time. Cannot we have alias to former ja_JP.EUC? -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 13:22:30 2001 Delivered-To: freebsd-audit@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 3215737B423; Sat, 2 Jun 2001 13:22:26 -0700 (PDT) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.11.3/8.11.3) id f52KLs248892; Sun, 3 Jun 2001 00:21:55 +0400 (MSD) (envelope-from ache) Date: Sun, 3 Jun 2001 00:21:53 +0400 From: "Andrey A. Chernov" To: Motoyuki Konno Cc: CHOI Junho , i18n@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: 2CFR: locale names renaming Message-ID: <20010603002153.A48861@nagual.pp.ru> References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200106021345.f52DjJ218044@sakura.mk.bsdclub.org>; from motoyuki@bsdclub.org on Sat, Jun 02, 2001 at 10:45:19PM +0900 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jun 02, 2001 at 22:45:19 +0900, Motoyuki Konno wrote: > "Andrey A. Chernov" wrote: > > It is possible (via symlinks) but I don't think it is good idea, even for > > transition period. If we preserve compatibility, people never change their > > environment LANG variables, so programs which parse LANG directly will be > > in trouble since in each and every such programs we need to add both > > variants. > > So, we have to take enough time for transition period. Transition period means just delay whole thing until transition period end. After the end the same thing happens like without transition period, because people don't touch their setups when they works, so you can consider that transition period ends now. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 13:23:14 2001 Delivered-To: freebsd-audit@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 69CFD37B422; Sat, 2 Jun 2001 13:23:10 -0700 (PDT) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.11.3/8.11.3) id f52KMbE48948; Sun, 3 Jun 2001 00:22:37 +0400 (MSD) (envelope-from ache) Date: Sun, 3 Jun 2001 00:22:36 +0400 From: "Andrey A. Chernov" To: Hajimu UMEMOTO Cc: motoyuki@bsdclub.org, cjh@kr.FreeBSD.ORG, i18n@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: 2CFR: locale names renaming Message-ID: <20010603002236.B48861@nagual.pp.ru> References: <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> <20010603.012551.08401034.ume@mahoroba.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010603.012551.08401034.ume@mahoroba.org>; from ume@mahoroba.org on Sun, Jun 03, 2001 at 01:25:51AM +0900 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jun 03, 2001 at 01:25:51 +0900, Hajimu UMEMOTO wrote: > Changing to use ja_JP.eucJP instead of ja_JP.EUC is good thing. > However, ja_JP.EUC is widely deployed and we Japanese have been using > ja_JP.EUC for a long time. Cannot we have alias to former ja_JP.EUC? I already describe why having alias is bad. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 13:24:47 2001 Delivered-To: freebsd-audit@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 3C56737B422; Sat, 2 Jun 2001 13:24:43 -0700 (PDT) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.11.3/8.11.3) id f52KOVv48978; Sun, 3 Jun 2001 00:24:31 +0400 (MSD) (envelope-from ache) Date: Sun, 3 Jun 2001 00:24:29 +0400 From: "Andrey A. Chernov" To: Motoyuki Konno Cc: CHOI Junho , i18n@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: 2CFR: locale names renaming Message-ID: <20010603002428.C48861@nagual.pp.ru> References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> <20010603002153.A48861@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010603002153.A48861@nagual.pp.ru>; from ache@nagual.pp.ru on Sun, Jun 03, 2001 at 12:21:53AM +0400 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jun 03, 2001 at 00:21:53 +0400, Andrey A. Chernov wrote: > On Sat, Jun 02, 2001 at 22:45:19 +0900, Motoyuki Konno wrote: > > "Andrey A. Chernov" wrote: > > > It is possible (via symlinks) but I don't think it is good idea, even for > > > transition period. If we preserve compatibility, people never change their > > > environment LANG variables, so programs which parse LANG directly will be > > > in trouble since in each and every such programs we need to add both > > > variants. > > > > So, we have to take enough time for transition period. > > Transition period means just delay whole thing until transition period > end. After the end the same thing happens like without transition period, > because people don't touch their setups when they works, so you can > consider that transition period ends now. Remember this is for -current only and not planned to be merged to -stable so you have _big_ transition period until 5.0 will be released. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 17:36: 5 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail.mk.bsdclub.org (adsl2049.ea.rim.or.jp [202.247.148.49]) by hub.freebsd.org (Postfix) with ESMTP id 6608737B422; Sat, 2 Jun 2001 17:35:59 -0700 (PDT) (envelope-from motoyuki@mk.bsdclub.org) Received: from sakura.mk.bsdclub.org (sakura.mk.bsdclub.org [3ffe:505:2022:0:2a0:c9ff:fe20:9aff]) by mail.mk.bsdclub.org (8.11.3+3.4W/3.7W/smtpfeed 1.12) with ESMTP/inet6 id f530ZvW94831; Sun, 3 Jun 2001 09:35:57 +0900 (JST) Received: from sakura.mk.bsdclub.org (localhost.mk.bsdclub.org [127.0.0.1]) by sakura.mk.bsdclub.org (8.11.3/3.7W) with ESMTP/inet id f530Zu247879; Sun, 3 Jun 2001 09:35:56 +0900 (JST) Message-Id: <200106030035.f530Zu247879@sakura.mk.bsdclub.org> To: "Andrey A. Chernov" Cc: Motoyuki Konno , CHOI Junho , i18n@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: 2CFR: locale names renaming From: Motoyuki Konno X-Mailer: mh-e on Mule 2.3 / Emacs 19.34.1 References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> <20010603002153.A48861@nagual.pp.ru> Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII Date: Sun, 03 Jun 2001 09:35:56 +0900 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Andrey A. Chernov" wrote: > > So, we have to take enough time for transition period. > > Transition period means just delay whole thing until transition period > end. After the end the same thing happens like without transition period, > because people don't touch their setups when they works, so you can > consider that transition period ends now. If so, why both ru_SU.* and ru_RU.* co-exist in 4-stable? We took a long time for transition from ru_SU to ru_RU. 3-stable branch (all 3.*-RELEASE) : ru_RU.* only 4-stable branch (all 4.*-RELEASE) : ru_RU.* and ru_SU.* 5-current branch (5.*-RELEASE ?) : ru_SU.* only I think immediate transition (even in -current) is a bad idea. I propose the following plan. 5-current (5-stable after 5.0-RELEASE) branch : both old and new locale future 6-currnt branch : only new locale -- ------------------------------------------------------------------------ Motoyuki Konno motoyuki@bsdclub.org (Home) motoyuki@FreeBSD.ORG (FreeBSD Project) http://www.freebsd.org/~motoyuki/ (WWW) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 17:53:53 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail.mk.bsdclub.org (adsl2049.ea.rim.or.jp [202.247.148.49]) by hub.freebsd.org (Postfix) with ESMTP id 6E9B437B423; Sat, 2 Jun 2001 17:53:49 -0700 (PDT) (envelope-from motoyuki@mk.bsdclub.org) Received: from sakura.mk.bsdclub.org (sakura.mk.bsdclub.org [3ffe:505:2022:0:2a0:c9ff:fe20:9aff]) by mail.mk.bsdclub.org (8.11.3+3.4W/3.7W/smtpfeed 1.12) with ESMTP/inet6 id f530rmW95306; Sun, 3 Jun 2001 09:53:48 +0900 (JST) Received: from sakura.mk.bsdclub.org (localhost.mk.bsdclub.org [127.0.0.1]) by sakura.mk.bsdclub.org (8.11.3/3.7W) with ESMTP/inet id f530rm284206; Sun, 3 Jun 2001 09:53:48 +0900 (JST) Message-Id: <200106030053.f530rm284206@sakura.mk.bsdclub.org> To: Motoyuki Konno Cc: "Andrey A. Chernov" , CHOI Junho , i18n@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: 2CFR: locale names renaming From: Motoyuki Konno X-Mailer: mh-e on Mule 2.3 / Emacs 19.34.1 References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> <20010603002153.A48861@nagual.pp.ru> <200106030035.f530Zu247879@sakura.mk.bsdclub.org> Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII Date: Sun, 03 Jun 2001 09:53:48 +0900 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Motoyuki Konno wrote: > If so, why both ru_SU.* and ru_RU.* co-exist in 4-stable? > We took a long time for transition from ru_SU to ru_RU. > > 3-stable branch (all 3.*-RELEASE) : ru_RU.* only > 4-stable branch (all 4.*-RELEASE) : ru_RU.* and ru_SU.* > 5-current branch (5.*-RELEASE ?) : ru_SU.* only I found typo. correct is: : 3-stable branch (all 3.*-RELEASE) : ru_SU.* only : 4-stable branch (all 4.*-RELEASE) : ru_SU.* and ru_RU.* : 5-current branch (5.*-RELEASE ?) : ru_RU.* only -- ------------------------------------------------------------------------ Motoyuki Konno motoyuki@bsdclub.org (Home) motoyuki@FreeBSD.ORG (FreeBSD Project) http://www.freebsd.org/~motoyuki/ (WWW) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 22:28:15 2001 Delivered-To: freebsd-audit@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 1967B37B422; Sat, 2 Jun 2001 22:28:10 -0700 (PDT) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.11.3/8.11.3) id f535Rm554325; Sun, 3 Jun 2001 09:27:49 +0400 (MSD) (envelope-from ache) Date: Sun, 3 Jun 2001 09:27:47 +0400 From: "Andrey A. Chernov" To: Motoyuki Konno Cc: CHOI Junho , i18n@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: 2CFR: locale names renaming Message-ID: <20010603092746.A53677@nagual.pp.ru> References: <20010602040851.A34526@nagual.pp.ru> <86ofs7thvy.fsf@gradius.wdb.co.kr> <20010602143139.A43237@nagual.pp.ru> <200106021345.f52DjJ218044@sakura.mk.bsdclub.org> <20010603002153.A48861@nagual.pp.ru> <200106030035.f530Zu247879@sakura.mk.bsdclub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200106030035.f530Zu247879@sakura.mk.bsdclub.org>; from motoyuki@bsdclub.org on Sun, Jun 03, 2001 at 09:35:56AM +0900 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jun 03, 2001 at 09:35:56 +0900, Motoyuki Konno wrote: > "Andrey A. Chernov" wrote: > > > So, we have to take enough time for transition period. > > > > Transition period means just delay whole thing until transition period > > end. After the end the same thing happens like without transition period, > > because people don't touch their setups when they works, so you can > > consider that transition period ends now. > > If so, why both ru_SU.* and ru_RU.* co-exist in 4-stable? They should not. ru_SU should be deleted. I don't have -stable machine available and can't devote time for its development, so don't know exact state of -stable changes made by other people. > 5-current (5-stable after 5.0-RELEASE) branch : both old and new locale It is already impossible, -current and -stable locales are incompatible. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 2 22:51: 0 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 288E737B422; Sat, 2 Jun 2001 22:50:58 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f535onS87312; Sun, 3 Jun 2001 01:50:49 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: References: Date: Sun, 3 Jun 2001 01:50:46 -0400 To: Mike Heffner , Mike Barcroft From: Garance A Drosihn Subject: Re: whois(1) patch Cc: freebsd-audit@FreeBSD.ORG, phk@FreeBSD.ORG, Mike Heffner Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 6:26 PM -0400 5/31/01, Mike Heffner wrote: >On 31-May-2001 Mike Barcroft wrote: >| >| I originally made the ANSI C change to silence a warning, but is >| there any reason not to bring the code up to ANSI C spec? Is it >| likely that anyone will need to compile whois with a K&R compiler? > >It's not likely, but I'm not sure on what the consensus is on >ANSI-fication. Technically, style(9) says it shouldn't be done in >this case, but people (myself included) have been removing K&R >support in small patches like this one. I think there was also talk >of doing a full sweep to remove __P. It is not likely that there will be a specific sweep to get rid of _P() and to ansi-ify routine declarations. However, the consensus is that if you are going to be changing the declarations in some module for OTHER reasons, then you might want to ansi-ify. If you're going to ansi-ify, then you should ansi-ify the whole source file, instead of mixing styles. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message