From owner-freebsd-current Sun Feb 4 0:35:59 2001 Delivered-To: freebsd-current@freebsd.org Received: from mobile.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id 9BCFC37B4EC; Sun, 4 Feb 2001 00:35:40 -0800 (PST) Received: from netplex.com.au (localhost [127.0.0.1]) by mobile.wemm.org (8.11.1/8.11.1) with ESMTP id f148ZTt19389; Sun, 4 Feb 2001 00:35:34 -0800 (PST) (envelope-from peter@netplex.com.au) Message-Id: <200102040835.f148ZTt19389@mobile.wemm.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Greg Lehey Cc: Robert Watson , freebsd-current@FreeBSD.ORG, freebsd-hackers@FreeBSD.ORG Subject: Re: Watch your devfs permissions in driver make_dev calls In-Reply-To: <20010204115741.G27504@sydney.worldwide.lemis.com> Date: Sun, 04 Feb 2001 00:35:29 -0800 From: Peter Wemm Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Greg Lehey wrote: > On Friday, 2 February 2001 at 20:10:10 -0800, Peter Wemm wrote: > > Robert Watson wrote: > > > >> crw-r--r-- 1 root wheel 78, 0 Dec 31 1969 pci > > > > This one may appear harmless, but it is not. It is trivially easy to creat e > > an alignment fault (fatal on an alpha) with the userland pciconf tool. > > We must not allow this to be used by users until the kernel part is fixed. > > > > Eg: try this on an alpha: pciconf -r -l pci0:x:x 0x3 - ie: read a longword > > at byte offset 3 in configuration space.. kaboom! > > This looks like a separate issue. Presumably you can do this as root > as well. pciconf should check the parameters. The kernel should check the parameters passed in from the userland, at least, it should not die like this. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message