From owner-freebsd-hackers Sun Dec 9 0:11:38 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 7C00437B416 for ; Sun, 9 Dec 2001 00:11:36 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id fB98BYD35974; Sun, 9 Dec 2001 00:11:34 -0800 (PST) (envelope-from dillon) Date: Sun, 9 Dec 2001 00:11:34 -0800 (PST) From: Matthew Dillon Message-Id: <200112090811.fB98BYD35974@apollo.backplane.com> To: D J Hawkey Jr Cc: hackers@FreeBSD.ORG Subject: Re: FreeBSD performs worse that Linux - Patches #2 & #3 References: <20011206114725.A836@sheol.localdomain> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :Hello all. : :I read with interest (and fair ignorance ;-) ) the thread about delayed :ACKs in the TCP/IP stack. :... :If Matt or any other qualified hackers can make the time to double-check :my patches, I'd appreciate it. Matt's first patch didn't apply (no NewReno :in 4.2REL), and the third patch (to tcp_input.c) required a little more work :(I changed tests for 'tcp_delack_enabled' to 'DELAY_ACK()'). I'd just like :some assurance I got it right. : :All in all, kudos to Matt for this. In day-to-day use, I can "feel" the :improvementi, and everything seems as solid as ever! : :Dave Ach. If you want my specific attention (or any FreeBSD developer's specific attention) you should always Cc: the person specifically. Otherwise my mail filter won't put it in my personal mail box :-) In anycase, your patches look fine. In fact, you not only applied my fixes you also applied a fix in the delayed-ack check that was made (by someone else) some time after 4.2Rel -- the callout_pending() check in DELAY_ACK() fixed a serious bug in prior releases all by itself. Kudos! I'm glad people have been testing this and getting such good results. I MFC'd it fairly quickly into stable (because TCP was seriously messed up) and its nice to get feedback that justifies the decision. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message