From owner-freebsd-net Sun Sep 23 2:36:23 2001 Delivered-To: freebsd-net@freebsd.org Received: from sasami.jurai.net (sasami.jurai.net [64.0.106.45]) by hub.freebsd.org (Postfix) with ESMTP id 51CE037B416 for ; Sun, 23 Sep 2001 02:36:18 -0700 (PDT) Received: from localhost (winter@localhost) by sasami.jurai.net (8.9.3/8.8.7) with ESMTP id FAA73528 for ; Sun, 23 Sep 2001 05:36:17 -0400 (EDT) Date: Sun, 23 Sep 2001 05:36:17 -0400 (EDT) From: "Matthew N. Dodd" To: freebsd-net@freebsd.org Subject: review request. Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-1070860394-1001237777=:3806" Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1070860394-1001237777=:3806 Content-Type: TEXT/PLAIN; charset=US-ASCII sys/net/if.c and bpf.c have problems with if_detach() and bpfdetach() when they are called with a struct ifnet that has not had if_attach() and bpfattach() called on it. Null pointer reference -> *boom* etc. This patch fixes the test already present in bpfdetach() and adds a test to if_detach(). Thanks. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | --0-1070860394-1001237777=:3806 Content-Type: TEXT/plain; name="diff.txt" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="diff.txt" SW5kZXg6IGlmLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxl OiAvY3ZzL3NyYy9zeXMvbmV0L2lmLmMsdg0KcmV0cmlldmluZyByZXZpc2lv biAxLjExNg0KZGlmZiAtdSAtcjEuMTE2IGlmLmMNCi0tLSBpZi5jCTE4IFNl cCAyMDAxIDE3OjQxOjQyIC0wMDAwCTEuMTE2DQorKysgaWYuYwkyMyBTZXAg MjAwMSAwOToxNzoxMSAtMDAwMA0KQEAgLTI0OCw2ICsyNDgsMTQgQEANCiAJ ICogUmVtb3ZlIHJvdXRlcyBhbmQgZmx1c2ggcXVldWVzLg0KIAkgKi8NCiAJ cyA9IHNwbG5ldCgpOw0KKw0KKwlpZiAoaWZwLT5pZl9pbmRleCA9PSAwKSB7 DQorCQlzcGx4KHMpOw0KKwkJcHJpbnRmKCJpZl9kZXRhY2g6ICVzJWQgd2Fz IG5vdCBhdHRhY2hlZFxuIiwgaWZwLT5pZl9uYW1lLA0KKwkJICAgIGlmcC0+ aWZfdW5pdCk7DQorCQlyZXR1cm47DQorCX0NCisNCiAJaWZfZG93bihpZnAp Ow0KIA0KIAkvKg0KSW5kZXg6IGJwZi5jDQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09DQpSQ1MgZmlsZTogL2N2cy9zcmMvc3lzL25ldC9icGYuYyx2DQpyZXRy aWV2aW5nIHJldmlzaW9uIDEuODINCmRpZmYgLXUgLXIxLjgyIGJwZi5jDQot LS0gYnBmLmMJMjEgU2VwIDIwMDEgMjI6NDY6NTQgLTAwMDAJMS44Mg0KKysr IGJwZi5jCTIzIFNlcCAyMDAxIDAzOjU4OjA0IC0wMDAwDQpAQCAtMTI2NCw3 ICsxMjY0LDcgQEANCiAJfQ0KIA0KIAkvKiBJbnRlcmZhY2Ugd2Fzbid0IGF0 dGFjaGVkICovDQotCWlmIChicC0+YmlmX2lmcCA9PSBOVUxMKSB7DQorCWlm IChicCA9PSBOVUxMKSB7DQogCQltdHhfdW5sb2NrKCZicGZfbXR4KTsNCiAJ CXByaW50ZigiYnBmZGV0YWNoOiAlcyVkIHdhcyBub3QgYXR0YWNoZWRcbiIs IGlmcC0+aWZfbmFtZSwNCiAJCSAgICBpZnAtPmlmX3VuaXQpOw0K --0-1070860394-1001237777=:3806-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message