From owner-freebsd-audit Mon Jan 28 1:44:52 2002 Delivered-To: freebsd-audit@freebsd.org Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201]) by hub.freebsd.org (Postfix) with ESMTP id BCF4537B402; Mon, 28 Jan 2002 01:44:48 -0800 (PST) Received: from sheldonh (helo=axl.seasidesoftware.co.za) by axl.seasidesoftware.co.za with local-esmtp (Exim 3.33 #1) id 16V8Nf-000JeR-00; Mon, 28 Jan 2002 11:47:15 +0200 From: Sheldon Hearn To: Alexey Zelkin Cc: audit@freebsd.org, ache@freebsd.org Subject: Re: CFR: strncpy -> strlcpy in setlocale() In-reply-to: Your message of "Thu, 24 Jan 2002 21:58:35 +0200." <20020124215835.A58294@gate.sim.ionidea.com> Date: Mon, 28 Jan 2002 11:47:15 +0200 Message-ID: <75542.1012211235@axl.seasidesoftware.co.za> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 24 Jan 2002 21:58:35 +0200, Alexey Zelkin wrote: > Any objections against this patch ? It's based on > rev 1.23 of NetBSD's setlocale.c. Are you sure the use of strlcpy() in libc won't cause build bootstrap problems for the build-tools build? Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Feb 1 8: 5: 4 2002 Delivered-To: freebsd-audit@freebsd.org Received: from straylight.ringlet.net (discworld.nanolink.com [217.75.135.248]) by hub.freebsd.org (Postfix) with SMTP id 7A3BD37B400 for ; Fri, 1 Feb 2002 08:04:52 -0800 (PST) Received: (qmail 1982 invoked by uid 1000); 1 Feb 2002 16:05:32 -0000 Date: Fri, 1 Feb 2002 18:05:32 +0200 From: Peter Pentchev To: audit@FreeBSD.org Subject: CFR: a fix for newsyslog(8) -F Message-ID: <20020201180532.A1960@straylight.oblivion.bg> Mail-Followup-To: audit@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, newsyslog(8) seems to have a minor buglet in its forced processing of logfiles for which date/time is the only rotate condition. Due to a missed check for -F, it refuses to forcibly rotate them if the time is not ripe yet. Attached is a trivial patch. G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org This sentence every third, but it still comprehensible. Index: src/usr.sbin/newsyslog/newsyslog.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/newsyslog/newsyslog.c,v retrieving revision 1.38 diff -u -r1.38 newsyslog.c --- src/usr.sbin/newsyslog/newsyslog.c 14 Nov 2001 17:00:58 -0000 1.38 +++ src/usr.sbin/newsyslog/newsyslog.c 28 Jan 2002 17:23:10 -0000 @@ -159,7 +159,7 @@ if (verbose) printf("does not exist.\n"); } else { - if (ent->flags & CE_TRIMAT) { + if (ent->flags & CE_TRIMAT && !force) { if (timenow < ent->trim_at || difftime(timenow, ent->trim_at) >= 60 * 60) { if (verbose) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message