From owner-freebsd-audit Sun Jun 9 17:59:46 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id 98C9F37B400 for ; Sun, 9 Jun 2002 17:59:40 -0700 (PDT) Received: from hades.hell.gr (patr530-b143.otenet.gr [212.205.244.151]) by mailsrv.otenet.gr (8.12.3/8.12.3) with ESMTP id g5A0xKZN020689 for ; Mon, 10 Jun 2002 03:59:29 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.3/8.12.3) with ESMTP id g5A0xDTp016916 for ; Mon, 10 Jun 2002 03:59:14 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Received: (from charon@localhost) by hades.hell.gr (8.12.3/8.12.3/Submit) id g5A0fvGv010802 for audit@freebsd.org; Mon, 10 Jun 2002 03:41:58 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Date: Mon, 10 Jun 2002 03:41:56 +0300 From: Giorgos Keramidas To: audit@FreeBSD.org Subject: nested extern shuffle in makewhatis.c Message-ID: <20020610004156.GA10607@hades.hell.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG One of the warnings printed by WARNS=6 for makewhatis is about the declaration of optind and optarg as extern. Any objections to me removing these as shown below? - Giorgos %%% Index: makewhatis.c =================================================================== RCS file: /home/ncvs/src/usr.bin/makewhatis/makewhatis.c,v retrieving revision 1.5 diff -u -r1.5 makewhatis.c --- makewhatis.c 22 May 2002 11:08:41 -0000 1.5 +++ makewhatis.c 7 Jun 2002 01:23:18 -0000 @@ -960,8 +960,6 @@ main(int argc, char **argv) { int opt; - extern int optind; - extern char *optarg; FILE *fp = NULL; while ((opt = getopt(argc, argv, "ai:n:o:vL")) != -1) { %%% To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message