From owner-freebsd-audit Mon Jun 17 13: 5:22 2002 Delivered-To: freebsd-audit@freebsd.org Received: from leviathan.inethouston.net (leviathan.inethouston.net [66.64.12.249]) by hub.freebsd.org (Postfix) with ESMTP id 3D1C637B400; Mon, 17 Jun 2002 13:05:09 -0700 (PDT) Received: by leviathan.inethouston.net (Postfix, from userid 1001) id AE7553198E1; Mon, 17 Jun 2002 15:00:41 -0500 (CDT) Date: Mon, 17 Jun 2002 15:00:41 -0500 From: "David W. Chapman Jr." To: audit@freebsd.org Cc: ports@freebsd.org Subject: Early work on making bsd.port.mk like kmod Message-ID: <20020617200041.GF17783@leviathan.inethouston.net> Reply-To: "David W. Chapman Jr." Mail-Followup-To: audit@freebsd.org, ports@freebsd.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="oyUTqETQ0mS9luUI" Content-Disposition: inline X-Operating-System: FreeBSD 4.5-STABLE i386 User-Agent: Mutt/1.5.1i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This is my first attempt any any type of shell scripting or bsd.port.mk work so take that into consideration when you review. This is just the early phase of making bsd.port.mk like kmod ports and does not have anything fancy, its more for concept right now. I would like to see if anyone agrees with the approach I'm taking right now and suggestions are welcome. -- David W. Chapman Jr. dwcjr@inethouston.net Raintree Network Services, Inc. dwcjr@freebsd.org FreeBSD Committer --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="bsd.port.mk.patch" Index: bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.414 diff -u -r1.414 bsd.port.mk --- bsd.port.mk 13 Jun 2002 18:20:40 -0000 1.414 +++ bsd.port.mk 17 Jun 2002 19:58:05 -0000 @@ -527,6 +527,9 @@ # when you noticed the distfile you just fetched has # a different checksum and you intend to verify if # the port still works with it. +# Not sure where this should go, so here is a good start +# USE_KMOD - Port uses kernel sources to build. +# KMOD_DIR - Directory for kmod files to be installed to. # Start of pre-makefile section. .if !defined(AFTERPORTMK) @@ -781,6 +784,17 @@ #RESTRICTED= "Contains cryptography." .endif +.if defined(USE_KMOD) +.if !exists(/usr/src/sys/Makefile) +BROKEN= "Kernel source files required" +.endif +.if ${OSVERSION} >= 500000 +KMOD_DIR?= /boot/kernel +.else +KMOD_DIR?= /modules +.endif +.endif + .if defined(EMACS_PORT_NAME) .include "${PORTSDIR}/Mk/bsd.emacs.mk" .endif @@ -3310,6 +3324,9 @@ @>${TMPPLIST} @for man in ${__MANPAGES}; do \ ${ECHO_CMD} $${man} >> ${TMPPLIST}; \ + done + @for kmod in ${INSTALL_KMOD}; do \ + ${ECHO_CMD} @unexec ${RM} ${KMOD_DIR}/`${BASENAME} $$kmod` >> ${TMPPLIST}; \ done .for _PREFIX in ${PREFIX} .if ${_TMLINKS:M${_PREFIX}*}x != x --oyUTqETQ0mS9luUI-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Jun 19 22:49:53 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id BD5D737B400 for ; Wed, 19 Jun 2002 22:49:47 -0700 (PDT) Received: from hades.hell.gr (patr530-b219.otenet.gr [212.205.244.227]) by mailsrv.otenet.gr (8.12.3/8.12.3) with ESMTP id g5K5nhqK020427 for ; Thu, 20 Jun 2002 08:49:45 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.4/8.12.4) with ESMTP id g5K5ngdv067951 for ; Thu, 20 Jun 2002 08:49:42 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Received: (from charon@localhost) by hades.hell.gr (8.12.4/8.12.4/Submit) id g5K5dE5M067800 for audit@freebsd.org; Thu, 20 Jun 2002 08:39:14 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Date: Thu, 20 Jun 2002 08:39:14 +0300 From: Giorgos Keramidas To: audit@FreeBSD.org Subject: Add empty ; after labels in ftpd? Message-ID: <20020620053914.GA67695@hades.hell.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG How does the following look? I was trying to make some other, unrelated changes to ftpd and this is something that keeps gcc3 unhappy. Should I commit this, or is there some other better way of fixing such warnings? %%% Add empty statements after two labels at the end of blocks, that trigger warnings with gcc3. Index: ftpcmd.y =================================================================== RCS file: /home/ncvs/src/libexec/ftpd/ftpcmd.y,v retrieving revision 1.33 diff -u -r1.33 ftpcmd.y --- ftpcmd.y 14 Mar 2002 16:05:06 -0000 1.33 +++ ftpcmd.y 20 Jun 2002 05:32:04 -0000 @@ -198,6 +198,7 @@ port_check_v6("pcmd"); #endif port_done: + ; } | LPRT check_login SP host_long_port CRLF { @@ -219,6 +220,7 @@ goto lprt_done; #endif lprt_done: + ; } | EPRT check_login SP STRING CRLF { %%% To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Jun 20 15:25:13 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mailb.telia.com (mailb.telia.com [194.22.194.6]) by hub.freebsd.org (Postfix) with ESMTP id A896337B40E; Thu, 20 Jun 2002 15:25:00 -0700 (PDT) Received: from d1o1075.telia.com (d1o1075.telia.com [213.67.243.241]) by mailb.telia.com (8.11.6/8.11.6) with ESMTP id g5KMOxg21270; Fri, 21 Jun 2002 00:24:59 +0200 (CEST) Received: from ludd.luth.se (h183n1fls22o1075.telia.com [217.209.40.183]) by d1o1075.telia.com (8.10.2/8.10.1) with ESMTP id g5KMOws14919; Fri, 21 Jun 2002 00:24:58 +0200 (CEST) Message-ID: <3D125661.9040704@ludd.luth.se> Date: Fri, 21 Jun 2002 00:25:37 +0200 From: =?ISO-8859-1?Q?Joachim_Str=F6mbergson?= Organization: =?ISO-8859-1?Q?Str=F6mbergson_Intergalactic_AB?= User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.0.0) Gecko/20020607 X-Accept-Language: en-US MIME-Version: 1.0 To: Mike Barcroft Cc: Giorgos Keramidas , audit@FreeBSD.ORG Subject: Minor change to rusers (Was: Re: minor header change in src/bin/dd/misc.c) References: <20020609014512.GA72307@hades.hell.gr> <20020608220030.D87326@espresso.q9media.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Aloha! Mike Barcroft wrote: > Giorgos Keramidas writes: > >>The source of bin/dd/misc.c doesn't use any of the functions of >> but uses strlen, which is defined in . The >>following seems to fix the only warning this file triggers for me. >>Does it seem ok to you all? > > > Yes, it's correct. is almost always wrong for BSD code. > I removed the include of from when I cleaned up > those headers for POSIX compatibility, so there are probably other > mis-includes throughout the system. It seems that this applies to /usr/bin/rusers too. AFAIK the compilation goes through and the behaviour seems to be unaltered. How about this patch? --- rusers.c Wed Jul 4 22:20:31 2001 +++ rusers.c Fri Jun 21 00:18:02 2002 @@ -46,7 +46,7 @@ #include #include #include -#include +#include #include #define MAX_INT 0x7fffffff -- Med vänlig hälsning, Cheers! Joachim Strömbergson ============================================================================ Joachim Strömbergson - ASIC designer, nice to *cute* animals. snail: phone: mail & web: Sävenäsgatan 5A +46 31 - 27 98 47 watchman@ludd.luth.se 416 72 Göteborg +46 733 75 97 02 www.ludd.luth.se/~watchman ============================================================================ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Jun 20 16:46:38 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id DF75337B411; Thu, 20 Jun 2002 16:46:16 -0700 (PDT) Received: from hades.hell.gr (patr530-b140.otenet.gr [212.205.244.148]) by mailsrv.otenet.gr (8.12.3/8.12.3) with ESMTP id g5KNkCMW000788; Fri, 21 Jun 2002 02:46:13 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.4/8.12.4) with ESMTP id g5KNkALa001696; Fri, 21 Jun 2002 02:46:11 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Received: (from charon@localhost) by hades.hell.gr (8.12.4/8.12.4/Submit) id g5KNk7i5001691; Fri, 21 Jun 2002 02:46:07 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Date: Fri, 21 Jun 2002 02:45:42 +0300 From: Giorgos Keramidas To: Joachim Str?mbergson Cc: Mike Barcroft , audit@FreeBSD.org Subject: Re: Minor change to rusers (Was: Re: minor header change in src/bin/dd/misc.c) Message-ID: <20020620234542.GA1651@hades.hell.gr> References: <20020609014512.GA72307@hades.hell.gr> <20020608220030.D87326@espresso.q9media.com> <3D125661.9040704@ludd.luth.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D125661.9040704@ludd.luth.se> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 2002-06-21 00:25 +0000, Joachim Str?mbergson wrote: >Mike Barcroft wrote: >> Giorgos Keramidas writes: >>>The source of bin/dd/misc.c doesn't use any of the functions of >>> but uses strlen, which is defined in . The >>>following seems to fix the only warning this file triggers for me. >>>Does it seem ok to you all? >> >> Yes, it's correct. is almost always wrong for BSD code. >> I removed the include of from when I cleaned up >> those headers for POSIX compatibility, so there are probably other >> mis-includes throughout the system. > > It seems that this applies to /usr/bin/rusers too. AFAIK the compilation > goes through and the behaviour seems to be unaltered. How about this patch? This is already in -CURRENT. It can probably me MFC'ed but I don't have a STABLE machine running the r-series of programs to test this. Seems OK to me though... - Giorgos To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 22 11:41:17 2002 Delivered-To: freebsd-audit@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 6DF8B37B401; Sat, 22 Jun 2002 11:41:14 -0700 (PDT) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.3/8.12.2) with ESMTP id g5MIfEP8070144; Sat, 22 Jun 2002 11:41:14 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.4/8.12.3/Submit) id g5MIfEbZ070143; Sat, 22 Jun 2002 11:41:14 -0700 (PDT) Date: Sat, 22 Jun 2002 11:41:14 -0700 From: "David O'Brien" To: Giorgos Keramidas Cc: audit@FreeBSD.org Subject: Re: Add empty ; after labels in ftpd? Message-ID: <20020622114114.A69972@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , Giorgos Keramidas , audit@FreeBSD.org References: <20020620053914.GA67695@hades.hell.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020620053914.GA67695@hades.hell.gr>; from keramida@FreeBSD.org on Thu, Jun 20, 2002 at 08:39:14AM +0300 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Jun 20, 2002 at 08:39:14AM +0300, Giorgos Keramidas wrote: > Add empty statements after two labels at the end of blocks, > that trigger warnings with gcc3. Gcc 3.0 or 3.1? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jun 22 13:11:28 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id D6AE937B400; Sat, 22 Jun 2002 13:11:24 -0700 (PDT) Received: from hades.hell.gr (patr530-a145.otenet.gr [212.205.215.145]) by mailsrv.otenet.gr (8.12.3/8.12.3) with ESMTP id g5MKBLuD017628; Sat, 22 Jun 2002 23:11:23 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.4/8.12.4) with ESMTP id g5MKBKLN017614; Sat, 22 Jun 2002 23:11:20 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Received: (from charon@localhost) by hades.hell.gr (8.12.4/8.12.4/Submit) id g5MKBJNR017613; Sat, 22 Jun 2002 23:11:19 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Date: Sat, 22 Jun 2002 23:11:18 +0300 From: Giorgos Keramidas To: "David O'Brien" , audit@FreeBSD.org Subject: Re: Add empty ; after labels in ftpd? Message-ID: <20020622201118.GA17572@hades.hell.gr> References: <20020620053914.GA67695@hades.hell.gr> <20020622114114.A69972@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020622114114.A69972@dragon.nuxi.com> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 2002-06-22 11:41 +0000, David O'Brien wrote: > On Thu, Jun 20, 2002 at 08:39:14AM +0300, Giorgos Keramidas wrote: > > Add empty statements after two labels at the end of blocks, > > that trigger warnings with gcc3. > > Gcc 3.0 or 3.1? GCC 3.1. My world hasn't been updated for a while, but my Jun 18 installation of CURRENT prints: 23:11 hades!charon:[/home/charon]$ gcc -v Using built-in specs. Configured with: FreeBSD/i386 system compiler Thread model: posix gcc version 3.1 [FreeBSD] 20020509 (prerelease) - Giorgos To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message