From owner-freebsd-current  Sun Jun  2  0: 9:20 2002
Delivered-To: freebsd-current@freebsd.org
Received: from web20905.mail.yahoo.com (web20905.mail.yahoo.com [216.136.226.227])
	by hub.freebsd.org (Postfix) with SMTP id B283B37B404
	for <current@freebsd.org>; Sun,  2 Jun 2002 00:08:55 -0700 (PDT)
Message-ID: <20020602070855.73453.qmail@web20905.mail.yahoo.com>
Received: from [218.108.145.174] by web20905.mail.yahoo.com via HTTP; Sun, 02 Jun 2002 00:08:55 PDT
Date: Sun, 2 Jun 2002 00:08:55 -0700 (PDT)
From: David Xu <bsddiy@yahoo.com>
Subject: Re: Seeking OK to commit KSE MIII
To: Julian Elischer <julian@elischer.org>
Cc: FreeBSD current users <current@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Sorry for this OT, I found a point in kern_switch.c, when choosethread() runs, 
you reset kg_last_assigned to NULL, I suspect it is incorrect, should it be:

--- kern_switch.c.orig	Sun Jun  2 14:52:24 2002
+++ kern_switch.c	Sun Jun  2 14:53:28 2002
@@ -67,7 +67,9 @@
 			kg = ke->ke_ksegrp;
 			TAILQ_REMOVE(&kg->kg_runq, td, td_runq);
 			if (kg->kg_last_assigned == td) 
-				kg->kg_last_assigned = NULL;
+				kg->kg_last_assigned =
+					TAILQ_PREV(td,
+					    threadlist_head, td_runq);
 		}
 		CTR2(KTR_RUNQ, "choosethread: td=%p pri=%d",
 		    td, td->td_priority);


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message