From owner-freebsd-cvsweb Mon Nov 25 6:46:50 2002 Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73FED37B404; Mon, 25 Nov 2002 06:46:49 -0800 (PST) Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.31.123]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19A3243E88; Mon, 25 Nov 2002 06:46:48 -0800 (PST) (envelope-from tnovak@atrey.karlin.mff.cuni.cz) Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 15349) id 879F54FC03; Mon, 25 Nov 2002 15:46:37 +0100 (CET) Date: Mon, 25 Nov 2002 15:46:37 +0100 From: Tomas Novak To: Ville =?iso-8859-2?Q?Skytt=E4?= Cc: freebsd-cvsweb@FreeBSD.org Subject: Re: Missing files in the list Message-ID: <20021125144637.GA11223@atrey.karlin.mff.cuni.cz> References: <20021122163527.GD21698@atrey.karlin.mff.cuni.cz> <1038008235.24390.46.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1038008235.24390.46.camel@localhost.localdomain> User-Agent: Mutt/1.3.28i Sender: owner-freebsd-cvsweb@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi Ville, playing with it I found that ,v repository files was corrupted. There was an error in repository files that 'cvs log' complains: >> cvs [log aborted]: mismatch in rcs file /home/cvs/iss/common/twilist.cc,v >> between deltas and deltatexts and rlog: >> rlog: /home/cvs/iss/common/twilist.cc,v: bad diff output line: #ifndef WITH_SKLIB >> rlog aborted and all following files was missing. 'cvs checkout' worked well so nobody have noticed it. By calling rlog per-partes only the corrupted file was skipped. It is my fault - someone have edited these files by hand and I have copied them directly to the repository. Sorry. Now it works well (~ 1200 files). With about 3000 test files in one repository directory I get it as you wrote: >> Can't exec "/usr/bin/rlog": Argument list too long at cvsweb.cgi line 2140 Cheers, TNT To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-cvsweb" in the body of the message From owner-freebsd-cvsweb Mon Nov 25 13:33: 2 2002 Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D50A37B40B for ; Mon, 25 Nov 2002 13:32:57 -0800 (PST) Received: from smtp3.pp.htv.fi (smtp3.pp.htv.fi [213.243.153.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id D16EA43EC2 for ; Mon, 25 Nov 2002 13:32:56 -0800 (PST) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp3.pp.htv.fi (Postfix) with ESMTP id 8BC9E27AD32; Mon, 25 Nov 2002 23:32:55 +0200 (EET) Received: from cs78128237.pp.htv.fi ([62.78.128.237]) by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id gAPLWtW07088; Mon, 25 Nov 2002 23:32:55 +0200 (EET) Subject: Re: Missing files in the list From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: Tomas Novak Cc: freebsd-cvsweb@FreeBSD.org In-Reply-To: <20021125144637.GA11223@atrey.karlin.mff.cuni.cz> References: <20021122163527.GD21698@atrey.karlin.mff.cuni.cz> <1038008235.24390.46.camel@localhost.localdomain> <20021125144637.GA11223@atrey.karlin.mff.cuni.cz> Content-Type: text/plain; charset=ISO-8859-1 Organization: FreeBSD Message-Id: <1038260146.24390.229.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.0 (1.2.0-ms1) Date: 25 Nov 2002 23:35:47 +0200 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-cvsweb@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 2002-11-25 at 16:46, Tomas Novak wrote: > It is my fault - someone have edited these files by hand and I have copied > them directly to the repository. Sorry. Hey, no problem, as a result I now have a rough patch in my working dir (based on yours) that adds support for dirs with *lots* of files :) And too bad rlog doesn't seem to have a -quiet or -errors-only option, some of its error messages obviously shouldn't be blindly discarded as we do now... -- \/ille Skyttä scop at FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-cvsweb" in the body of the message From owner-freebsd-cvsweb Tue Nov 26 14:47: 2 2002 Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A6A237B401 for ; Tue, 26 Nov 2002 14:47:00 -0800 (PST) Received: from relay1.amsterdam.lostboys.com (relay1.amsterdam.lostboys.com [194.151.1.116]) by mx1.FreeBSD.org (Postfix) with ESMTP id E095A43E88 for ; Tue, 26 Nov 2002 14:46:54 -0800 (PST) (envelope-from paul.gelderblom@lostboys.nl) Received: from ptok (vpn-63-6-100-10.clt.ams.nl.intern) [10.100.6.63] by relay1.amsterdam.lostboys.com [194.151.1.116] with SMTP (MDaemon.PRO.v4.0.5.R) for ; Tue, 26 Nov 2002 23:46:49 +0100 Message-ID: <003701c2959d$e260e440$0b00000a@lostboys.nl> From: "Paul Gelderblom" To: Subject: possible additions to cvsweb offered Date: Tue, 26 Nov 2002 23:48:05 +0100 Organization: Lost Boys Interactive Media MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4920.2300 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4920.2300 X-Lookup-Warning: reverse lookup on original sender failed X-MDRemoteIP: 10.100.6.63 X-Return-Path: paul.gelderblom@lostboys.nl X-MDaemon-Deliver-To: freebsd-cvsweb@FreeBSD.org Sender: owner-freebsd-cvsweb@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, I have made some additions to cvsweb, and am willing to submit them for inclusion. The new features are: 1 * different sorting option: case-insensitive sort in all pages sorted on filename in cvsweb (this is a matter of taste, but my users prefer it. It should be an option in cvsweb.conf) 2 * picture previews: for files that are web-aware pictures (png,gif,jpeg, bmp): the option to show the picture in the page in directory listings and version histories for a file . The same is possible on the version history page of a single file: then it shows all the versions. This is useful for web developers & designers. CVS-Diffing gif's is not really useful :)) but in this way they can easily see what changed between versions. 3 * customizable cross-linking: Since directories in a repository often correspond to projects, an option to put 1 or more crosslinks next to the directory which bring you to a page that is defined in a custom way in the config file. For example: on the freebsd site, on page http://www.freebsd.org/cgi/cvsweb.cgi/projects/, next to the trustedbsd site there could be a link to the trustedbsd project page. The content of these links is left to a site-dependant function to be written by the repository administrator. 4 * interface to cvs history file: This is basically a new tool that provides an interface to the history file. I look directly at the history file and do not use "cvs history" , mostly for perfrmance reasons. It crosslinks with the cvswevb tool, and they could share the same configuration file. You can select the directory (0,1, many) user(s), and the timeframe (days back from now) it runs over If you run it on the toplevel, it gives you an overview of all projects changed in a certain timeframe. It can make a nice home page for a set of projectys (I actually use it like that) to see what is happening in a large repository: our repository has 400+ toplevel projects, many of which are non active; running the tool with a backlog of 20 days gives you a list of "active projects" Crosslinks (see above) bring you to the history, or the cvsweb page, or the site-dependant home page of the project. If you run it on a directory, it gives you an overview of all changes in that directory *and its children* in the selected timeframe. It is also possible to filter based on usernames. I have all of this working on the repository I maintain, but I cannot show it to you because it is on a LAN. I do have some screenshots but didn't want to mail them to this list. My questions are: * should I mail the screenshots (send me an email) * do you think these additions would be worthwhile? * should I submit them to freebsd-cvsweb or to the Zeller site. It seems that that site is pretty silent - is freebsd-cvsweb the most active version of cvsweb? * I started my developments based on cvsweb 2.0.0 ($FreeBSD: projects/cvsweb/cvsweb.cgi,v 1.87 2001/11/07 21:08:33 knu Exp $) which was on my Freebsd system. I see in the repository that quite a lot has changed since then. So I will need to do some patching. I am very willing to do that, but first let me know whether (and which of) the suggested additions are worthwhile. Cheers, Paul Gelderblom paul@lostboys.nl To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-cvsweb" in the body of the message From owner-freebsd-cvsweb Tue Nov 26 15:29:12 2002 Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5A1B37B401 for ; Tue, 26 Nov 2002 15:29:09 -0800 (PST) Received: from smtp2.pp.htv.fi (smtp2.pp.htv.fi [213.243.153.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 248B443E4A for ; Tue, 26 Nov 2002 15:29:09 -0800 (PST) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp2.pp.htv.fi (Postfix) with ESMTP id B2F01296D71; Wed, 27 Nov 2002 01:29:02 +0200 (EET) Received: from cs78128237.pp.htv.fi ([62.78.128.237]) by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id gAQNT2M07652; Wed, 27 Nov 2002 01:29:02 +0200 (EET) Subject: Re: possible additions to cvsweb offered From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: Paul Gelderblom Cc: freebsd-cvsweb@FreeBSD.org In-Reply-To: <003701c2959d$e260e440$0b00000a@lostboys.nl> References: <003701c2959d$e260e440$0b00000a@lostboys.nl> Content-Type: text/plain; charset=ISO-8859-1 Organization: FreeBSD Message-Id: <1038353540.25230.38.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.0 (1.2.0-ms1) Date: 27 Nov 2002 01:32:21 +0200 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-cvsweb@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 2002-11-27 at 00:48, Paul Gelderblom wrote: > Hi, > > I have made some additions to cvsweb, and am willing to submit them for > inclusion. Cool, let's see... > The new features are: > > 1 * different sorting option: > case-insensitive sort in all pages sorted on filename in cvsweb (this is a > matter of taste, but my users prefer it. It should be an option in > cvsweb.conf) Sounds useful, but I think it should be a per-user setting, perhaps with the default setting configured in cvsweb.conf. > 2 * picture previews: Hmm, I get your point. But I'm not 100% sure about how this could be sensibly implemented. Are you "forcing" the image sizes to something fixed? Some screenshots would be nice. See also [1]. > 3 * customizable cross-linking: Again, see [1] below... > 4 * interface to cvs history file: Sounds useful. Some history file stuff is definitely in The Roadmap, for example integration with CVSps, . > My questions are: > * should I mail the screenshots (send me an email) That'd be useful. If you don't want to use this list for that (though I guess it wouldn't hurt, eg. in a [bg]zipped tarball), please send 'em at least to me. > * do you think these additions would be worthwhile? Yep, that's my first impression. > * should I submit them to freebsd-cvsweb or to the Zeller site. It seems > that that site is pretty silent - is freebsd-cvsweb the most active version > of cvsweb? AFAICT, yes. I don't think anything has happened with Zeller's version for some time now. > * I started my developments based on cvsweb 2.0.0 ($FreeBSD: > projects/cvsweb/cvsweb.cgi,v 1.87 2001/11/07 21:08:33 knu Exp $) > which was on my Freebsd system. I see in the repository that quite a lot has > changed since then. So I will need to do some patching. I am very willing to > do that, but first let me know whether (and which of) the suggested > additions are worthwhile. As said, the features sound interesting. Version 2.0.x of FreeBSD-CVSweb is feature-frozen, only bug fixes will go into it. I suggest that you take a look at the 3.0-dev version, ie. the CVS HEAD, and consider porting to that. A good way to start would be to minimize the diffs against the 2.0.0 version you started with (which can be retrieved from FreeBSD CVS in case you don't have it around any more), and split it into multiple, self-contained patches, each of which do one thing. And then start porting them to 3.0. Oops, almost forgot the footnote, here goes [1]: For UI customizations, i18n stuff and all that, I'm planning to use some templating system or XML/XSLT (or both :). The code just gets too hairy even with one HTML UI output directly from it, let alone the customizations. I've begun that by moving most of styling stuff to an external CSS file, but I have intentions to rip all the HTML out of the Perl code as well. Template Toolkit, is a strong candidate at the moment. Maybe it's best to work with non-UI features first to avoid redundant work. Cheers, -- \/ille Skyttä scop at FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-cvsweb" in the body of the message From owner-freebsd-cvsweb Wed Nov 27 10:16: 8 2002 Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9074937B401 for ; Wed, 27 Nov 2002 10:16:07 -0800 (PST) Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [212.90.64.111]) by mx1.FreeBSD.org (Postfix) with ESMTP id 018C743E9C for ; Wed, 27 Nov 2002 10:16:07 -0800 (PST) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp1.pp.htv.fi (Postfix) with ESMTP id 988C57FD4A; Wed, 27 Nov 2002 18:16:00 +0200 (EET) Received: from cs78128237.pp.htv.fi ([62.78.128.237]) by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id gARIFxM05880; Wed, 27 Nov 2002 20:15:59 +0200 (EET) Subject: Re: possible additions to cvsweb offered From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: Paul Gelderblom Cc: freebsd-cvsweb@FreeBSD.org In-Reply-To: <001e01c295fd$27be90a0$0300000a@PAULLAP> References: <003701c2959d$e260e440$0b00000a@lostboys.nl> <1038353540.25230.38.camel@localhost.localdomain> <001e01c295fd$27be90a0$0300000a@PAULLAP> Content-Type: text/plain; charset=ISO-8859-1 Organization: FreeBSD Message-Id: <1038421176.25229.77.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.0 (1.2.0-ms1) Date: 27 Nov 2002 20:19:37 +0200 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-cvsweb@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 2002-11-27 at 12:08, Paul Gelderblom wrote: > I agree, but I'm not exactly sure how to do that sensibly in the UI: now you > select name sorting by clicking on the header. I could of course make it > such that a second click on the Filename header toggles the sort type, but > that is not what most users expect. No, I don't think that's a good idea. > Otherwise we would need a user-settings panel or an extra switch at the > bottom. Pretty easy to implement, but wouldn't that be a bit overdone? We already have user options, like preferred diff type, sort log by [___] etc. I think this would fit there just fine. Maybe if the options start to pile up they deserve a view of their own view. And cookie support... > > > 2 * picture previews: > > > > Hmm, I get your point. But I'm not 100% sure about how this could be > > sensibly implemented. Are you "forcing" the image sizes to something > > fixed? Some screenshots would be nice. See also [1]. > No, I'm not forcing it. I basically use the auto-layout of the browser. > (which works if you do not fill in the image size). It doesn't look that > stylish, but it works very well. ...at least when, like in your screenshot, the image sizes are close to each other in size and relatively small. Anyway, I think this and the crosslinks are prime examples of what should be customized using templates. -- \/ille Skyttä scop at FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-cvsweb" in the body of the message