From owner-freebsd-fs  Wed May 22 21:28:18 2002
Delivered-To: freebsd-fs@freebsd.org
Received: from viola.sinor.ru (viola.sinor.ru [217.70.106.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id AC09D37B403; Wed, 22 May 2002 21:28:13 -0700 (PDT)
Received: from p162.bass3.sinor.ru (p162.bass3.sinor.ru [217.70.108.162])
	by viola.sinor.ru (8.9.3/8.9.3) with ESMTP id LAA02001;
	Thu, 23 May 2002 11:28:09 +0700
Date: Thu, 23 May 2002 11:28:50 +0700 (NOVST)
From: "Semen A. Ustimenko" <semenu@FreeBSD.org>
X-X-Sender: semenu@def.the.net
To: freebsd-net@FreeBSD.org
Cc: freebsd-fs@FreeBSD.org
Subject: NFS don't set sopt.sopt_dir sometimes... Maybe sosetopt() should?
Message-ID: <20020523111658.N405-100000@def.the.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-fs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-fs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-fs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-fs>
X-Loop: FreeBSD.org

Hi!

Looks like nfs_socket.c and nfs_syscalls.c lack strings

	sopt.sopt_dir = SOPT_SET;

when setting TCP_NODELAY and SO_KEEPALIVE. For SO_KEEPALIVE, it doesn't
matter, sosetopt() doesn't examine it, but TCP_NODELAY is actually
ignored.

Obviously, it's easy to add these lines, but maybe it's better to make
sosetopt() set sopt_dir for callers?

BYe!


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-fs" in the body of the message