From owner-freebsd-libh Sun Jun 2 14:15:37 2002 Delivered-To: freebsd-libh@freebsd.org Received: from postal.sdsc.edu (postal.sdsc.edu [132.249.20.114]) by hub.freebsd.org (Postfix) with ESMTP id 21CF637B405 for ; Sun, 2 Jun 2002 14:15:35 -0700 (PDT) Received: from multivac.sdsc.edu (multivac.sdsc.edu [132.249.20.57]) by postal.sdsc.edu (8.11.6/8.11.6/server/38) with ESMTP id g52LFVN17835; Sun, 2 Jun 2002 14:15:31 -0700 (PDT) Received: by multivac (8.11.6+Sun/1.11-SolarisClient) id g52LFVb24686; Sun, 2 Jun 2002 14:15:31 -0700 (PDT) To: The Anarcat Cc: libh@FreeBSD.ORG Subject: Re: cvs commit: libh/include/hui HuiTVObjects.hh libh/lib/hui HuiTVision_ButtonsGroupWidget.cc HuiTVision_CheckBoxesWidget.cc HuiTVision_InputLineWidget.cc HuiTVision_LabelWidget.cc HuiTVision_ListBoxWidget.cc HuiTVision_ProgressIndicatorWidget.cc HuiTVision_RadioMenuWidget.cc References: <20020601074915.C9BFB17407@usw4.freebsd.org> <20020602004111.GC357@lenny.anarcat.ath.cx> From: Max Okumoto Date: 02 Jun 2002 14:15:31 -0700 In-Reply-To: The Anarcat's message of "Sat, 1 Jun 2002 20:41:11 -0400" Message-ID: Lines: 28 X-Mailer: Gnus v5.5/XEmacs 20.4 - "Emerald" Sender: owner-freebsd-libh@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I am trying to find bugs in the widget layout code. The only time these functions are called is from the constructors. No other objects call minSize() or maxSize(), nor can you call them from tcl. In all cases the results are directly feed into resize() in the constructor. But in most cases, the widget constructor already sizes the object to the correct size... so its redundent to resize it again. The constructors that require resize need to be fixed. FooWidget { /** Constructor. */ FooWidget() { resize(minSize()); } }; The Anarcat writes: > On Sat Jun 01, 2002 at 02:49:15AM -0500, Max Okumoto wrote: > > > > Removed minSize() from all the HuiTVision objects. > > Why is this necessary? > > A. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-libh" in the body of the message