From owner-freebsd-net Sun Nov 3 0:20:36 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55EA837B401; Sun, 3 Nov 2002 00:20:35 -0800 (PST) Received: from smtp.inode.at (smtp-02.inode.at [62.99.194.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A38D43E75; Sun, 3 Nov 2002 00:20:34 -0800 (PST) (envelope-from mbretter@inode.at) Received: from line-c-98.adsl-dynamic.inode.at ([62.99.151.98]:1168 helo=inode.at) by smtp.inode.at with esmtp (Exim 4.05) id 188Fta-000578-00; Sun, 03 Nov 2002 09:14:10 +0100 Message-ID: <3DC4DB96.9070402@inode.at> Date: Sun, 03 Nov 2002 09:17:26 +0100 From: Michael Bretterklieber User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.2b) Gecko/20021016 X-Accept-Language: de-at, de-de, de, en, en-us MIME-Version: 1.0 To: freebsd-net@freebsd.org Cc: brian@freebsd.org Subject: ppp radius programmer question Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi, I'm implementing radius for mpd and I found maybe a leak in radius.c of the userland-ppp. in the function radius_Process, I think there is a missing free function call: snip case RAD_MICROSOFT_MS_MPPE_RECV_KEY: free(r->mppe.recvkey); demangle(r, data, len, &r->mppe.recvkey, &r->mppe.recvkeylen); log_Printf(LogPHASE, " MS-MPPE-Recv-Key ********\n"); break; case RAD_MICROSOFT_MS_MPPE_SEND_KEY: <--- isn't here missing: free(r->mppe.sendkey); --> demangle(r, data, len, &r->mppe.sendkey, &r->mppe.sendkeylen); log_Printf(LogPHASE, " MS-MPPE-Send-Key ********\n"); break; Am I right or is this just a bug in my brain? bye, -- ------------------------------- ---------------------------------- Michael Bretterklieber - Michael.Bretterklieber@jawa.at JAWA Management Software GmbH - http://www.jawa.at Liebenauer Hauptstr. 200 -------------- privat ------------ A-8041 GRAZ GSM: ++43-(0)676-93 96 698 Tel: ++43-(0)316-403274-12 E-mail: mbretter@inode.at Fax: ++43-(0)316-403274-10 http://www.inode.at/mbretter ------------------------------- ---------------------------------- "...the number of UNIX installations has grown to 10, with more expected..." - Dennis Ritchie and Ken Thompson, June 1972 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message