From owner-freebsd-arch@FreeBSD.ORG  Tue Apr 15 08:12:34 2003
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5CA8837B40A; Tue, 15 Apr 2003 08:12:34 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 315A943FD7; Tue, 15 Apr 2003 08:12:33 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.8/8.12.3) with ESMTP id h3FFCWA7063351;
	Tue, 15 Apr 2003 09:12:32 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Tue, 15 Apr 2003 09:12:09 -0600 (MDT)
Message-Id: <20030415.091209.108403664.imp@bsdimp.com>
To: mdodd@FreeBSD.ORG
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030415104824.H99028@sasami.jurai.net>
References: <20030415102955.S99028@sasami.jurai.net>
	<20030415.083615.91276433.imp@bsdimp.com>
	<20030415104824.H99028@sasami.jurai.net>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: arch@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Apr 2003 15:12:34 -0000

[[ moved to arch ]]

In message: <20030415104824.H99028@sasami.jurai.net>
            "Matthew N. Dodd" <mdodd@FreeBSD.ORG> writes:
: On Tue, 15 Apr 2003, M. Warner Losh wrote:
: > How do you tell if a BAR is enabled?  I assume you mean 'check to see
: > if the BAR has an allocated resource' here?  In that case, my XXX
: > applies :-(  We should allocate a resonable resource.
: 
: Actually I misspoke; we should modify pci_enable_io_method() so that we
: can indicate a failure to enable the requested space.

foo |= BIT;
if ((foo & BIT) == 0)
   whine-and-fail;

is that what you are saying?

: This would keep drivers from having to check and see if PCIM_CMD_PORTEN or
: PCIM_CMD_MEMEN is set.

Yes.

: This requires changing the definition of the 'enable_io' method.
:
: Since we're here we should change 'disable_io' and
: '{enable,disable}_busmaster' as well.

If we're going to do this, then we need to do it soon.

Warner