From owner-freebsd-audit@FreeBSD.ORG Sun Aug 10 07:33:45 2003 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8A3037B401 for ; Sun, 10 Aug 2003 07:33:45 -0700 (PDT) Received: from srv1.cosmo-project.de (srv1.cosmo-project.de [213.83.6.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC68C43F85 for ; Sun, 10 Aug 2003 07:33:44 -0700 (PDT) (envelope-from ticso@cicely12.cicely.de) Received: from cicely5.cicely.de (cicely5.cicely.de [IPv6:3ffe:400:8d0:301:200:92ff:fe9b:20e7]) (authenticated bits=0) by srv1.cosmo-project.de (8.12.9/8.12.9) with ESMTP id h7AEXdaK072238 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK) for ; Sun, 10 Aug 2003 16:33:42 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (cicely12.cicely.de [IPv6:3ffe:400:8d0:301::12]) by cicely5.cicely.de (8.12.9/8.12.9) with ESMTP id h7AEXcA4008580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 10 Aug 2003 16:33:39 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (localhost [127.0.0.1]) by cicely12.cicely.de (8.12.9/8.12.9) with ESMTP id h7AEXcNS060376 for ; Sun, 10 Aug 2003 16:33:38 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: (from ticso@localhost) by cicely12.cicely.de (8.12.9/8.12.9/Submit) id h7AEXbfQ060375 for freebsd-audit@freebsd.org; Sun, 10 Aug 2003 16:33:37 +0200 (CEST) Date: Sun, 10 Aug 2003 16:33:37 +0200 From: Bernd Walter To: freebsd-audit@freebsd.org Message-ID: <20030810143336.GT46866@cicely12.cicely.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: FreeBSD cicely12.cicely.de 5.1-CURRENT alpha User-Agent: Mutt/1.5.4i Subject: review for newbus usage needed X-BeenThere: freebsd-audit@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: ticso@cicely.de List-Id: FreeBSD Security Audit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Aug 2003 14:33:46 -0000 Index: iicbus.c =================================================================== RCS file: /home/ncvs/src/sys/dev/iicbus/iicbus.c,v retrieving revision 1.16 diff -u -r1.16 iicbus.c --- iicbus.c 23 Mar 2002 15:47:17 -0000 1.16 +++ iicbus.c 10 Aug 2003 14:29:39 -0000 @@ -132,9 +132,7 @@ printf("\n"); #endif - /* attach any known device */ - device_add_child(dev, NULL, -1); - + bus_generic_probe(dev); bus_generic_attach(dev); return (0); Exit 1 Without this change only iic attaches to iicbus. With this change iic and iicsmd attaches as intended. Is this the correct fix? Is it correct bahavour that device_add_child(dev, NULL, -1); only attaches a single match? -- B.Walter BWCT http://www.bwct.de ticso@bwct.de info@bwct.de