From owner-freebsd-cvsweb Mon Jan 20 2:46:26 2003 Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F068737B401 for ; Mon, 20 Jan 2003 02:46:24 -0800 (PST) Received: from fapdns01.systor.com (fapdns01.systor.com [193.192.230.116]) by mx1.FreeBSD.org (Postfix) with SMTP id 9F97D43F43 for ; Mon, 20 Jan 2003 02:46:23 -0800 (PST) (envelope-from peter.klausner@systor.com) Received: (qmail 10566 invoked from network); 20 Jan 2003 10:35:53 -0000 Received: from unknown (HELO henderson.systor.com) (172.17.247.196) by fapdns01.systor.com with SMTP; 20 Jan 2003 10:35:53 -0000 Subject: Patch for vendor branch tags To: freebsd-cvsweb@FreeBSD.org X-Mailer: Lotus Notes Release 5.0.2c (Intl) 2 February 2000 Message-ID: From: "Peter Klausner" Date: Mon, 20 Jan 2003 11:46:15 +0100 X-MIMETrack: Serialize by Router on HENDERSON/SYSTOR(Release 5.0.11 |July 24, 2002) at 20.01.2003 11:46:16 MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii Sender: owner-freebsd-cvsweb@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Using vendor branch tags of CVS, I run into a bug: If you do a "normal" cvs import, the stuff shows up on the branch 1.1.1, named "vendor" For multiple vendors, you add branches 1.1.x named "vendorx". The cvs log view of a file does show all the vendor tags and branch numbers, but if you restrict the view to such a branch, the directory always will be empty. Here is a patch agains 2.0.6 which seems to fix the problem; although I don't really understand what is going on. HTH + Bye, Peter Klausner PS: most of the diff is due to the debug output; I changed the raw print do sth. redirectable. The decisive change is: ! if (($revwanted eq '' || $revwanted =~ /^1\.1\.\d+$/) ! && $branch ne '' && $branch eq $revbranch || !defined($tag)) { ! DBG "File revision $rev found for branch $branch\n"; $revwanted = $rev; } PPS: I realized, that the current cvsweb.cgi has zillions of changes relative to the latest stable release 2.0.6. It seems, that 95% of those changes are only due to indentation and reformatting. It is futile to discuss coding style, but I think such _changes_ greatly reduce the usefulness of CVS - and cvsweb. So the cvsweb sources should not give a negative example here... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-cvsweb" in the body of the message