From owner-freebsd-cvsweb@FreeBSD.ORG Wed Nov 12 10:48:36 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B1D116A4CF; Wed, 12 Nov 2003 10:48:36 -0800 (PST) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.198.39]) by mx1.FreeBSD.org (Postfix) with ESMTP id 542E843FAF; Wed, 12 Nov 2003 10:48:35 -0800 (PST) (envelope-from bryce1@obviously.com) Received: from obviously.com (h0010a4e2603c.ne.client2.attbi.com[24.61.43.4]) by comcast.net (rwcrmhc13) with SMTP id <2003111218483401500aver7e>; Wed, 12 Nov 2003 18:48:35 +0000 Message-ID: <3FB28082.6070707@obviously.com> Date: Wed, 12 Nov 2003 13:48:34 -0500 From: "Bryce Nesbitt (spam account)" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en-us, es, en, de, he MIME-Version: 1.0 To: =?ISO-8859-1?Q?Ville_Skytt=E4?= References: <3FB23C1F.6040502@obviously.com> <1068661352.4763.72.camel@bobcat.mine.nu> In-Reply-To: <1068661352.4763.72.camel@bobcat.mine.nu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit cc: freebsd-cvsweb@freebsd.org Subject: Re: Patch to cvsweb? X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2003 18:48:36 -0000 I am working with CVS HEAD. My modified version is at: http://www.obviously.com/test/cvsweb.cgi/MassGIS/ I implemented an external diff utility. In this case, it compares binary application files stored inside a .zip archive. What I found in the process was a lot of hassle with the mime types. Several places the $mimetype does not match the current file. The moment I added: %MTYPES = ( "gif" => "image/gif", "zip" -> "application/zup", ); cvsweb wanted to display compressed .zip files "as text". Give it a try, this is easy to reproduce. Some files are inherently "viewable" in a web browser, and some have to be downloaded to be useful. With CVS HEAD that distinction is a bit confusing both for the user, and in the code base. -Bryce Ville Skyttä wrote: >On Wed, 2003-11-12 at 15:56, Bryce Nesbitt wrote: > > > >>Would you accept a patch to cvsweb related to proper mime types >>for downloading zip files? >> >> > >Some work with MIME types has been lately done to cvsweb, be sure to >check out CVS HEAD or the new beta, 2.9.1 (I assume that is not the >version you're talking about). The MIME type support is now pretty >good, however it exposes other annoying things that need to be taken >care of before 3.0. > >(And if possible, please also use the freebsd-cvsweb@freebsd.org mailing >list for FreeBSD-CVSweb related discussion, TIA!) > >