From owner-freebsd-doc@FreeBSD.ORG Sun Aug 17 04:07:26 2003 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2E6A37B401; Sun, 17 Aug 2003 04:07:26 -0700 (PDT) Received: from arthur.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8820943FB1; Sun, 17 Aug 2003 04:07:25 -0700 (PDT) (envelope-from simon@arthur.nitro.dk) Received: by arthur.nitro.dk (Postfix, from userid 1000) id C460510BFA8; Sun, 17 Aug 2003 13:07:23 +0200 (CEST) Date: Sun, 17 Aug 2003 13:07:23 +0200 From: "Simon L. Nielsen" To: Joe Marcus Clarke Message-ID: <20030817110722.GA391@FreeBSD.org> References: <1061069299.54862.34.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/9DWx/yDrRhgMJTb" Content-Disposition: inline In-Reply-To: <1061069299.54862.34.camel@shumai.marcuscom.com> User-Agent: Mutt/1.5.4i cc: freebsd-doc@FreeBSD.org Subject: Re: Review of porters-handbook changes X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Aug 2003 11:07:27 -0000 --/9DWx/yDrRhgMJTb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2003.08.16 17:28:19 -0400, Joe Marcus Clarke wrote: > Can someone review the attached diff to the porter's handbook? It was > submitted by Sergey Matveychuk for some of the recent > ports infrastructure changes. It is technically accurate, and I fixed a > few grammar and spelling nits, but I would like a doc committers take on > it before committing. Also, if one of you would rather commit, that's > fine. Thanks! There are some places where 8 spaces have been used instead of a tab (can be fixed by marking the regions and using 'meta-x tabify' in emacs'). There are also some end of line white-spaces which should be removed. > --- doc/en_US.ISO8859-1/books/porters-handbook/book.sgml 10 Aug 2003 20:3= 4:31 -0000 1.319 > +++ doc/en_US.ISO8859-1/books/porters-handbook/book.sgml 16 Aug 2003 21:2= 4:46 -0000 > @@ -3216,11 +3227,23 @@ > =20 > Says that the port uses Perl 5 to build and run. > > - =20 > + > > - PERL > + PERL_CONFIGURE > + > + Configure using Perl's MakeMaker. It implies USE_PERL5. ^^^^^^^^^ Missing makevar tag. > @@ -4316,6 +4083,19 @@ > > > =20 > + > + <filename>pkg-deinstall</filename> > + > + This script executes when a package is removed. > + > + > + Like the pkg-install script it will be run twice. > + The first time as ${SH} pkg-install ${PKGNAME} > + DEINSTALL and the second time as > + ${SH} pkg-install ${PKGNAME} POST-DEINSTALL. > + Perhaps a reference to pkg_delete(1) ? Otherwise it looks OK to me, but I have only checked the markup, not the language. --=20 Simon L. Nielsen FreeBSD Documentation Team --/9DWx/yDrRhgMJTb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/P2Hqh9pcDSc1mlERAkMvAKDMSmoC0/LvV1cd3KNmeoyvomgTBQCfaDUT X1dQ6lXGAZVn5JbQdeI5rlU= =aKJJ -----END PGP SIGNATURE----- --/9DWx/yDrRhgMJTb--