From owner-freebsd-fs@FreeBSD.ORG Sun Jul 13 04:57:33 2003 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E844D37B401; Sun, 13 Jul 2003 04:57:33 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87B3C43FA3; Sun, 13 Jul 2003 04:57:33 -0700 (PDT) (envelope-from maxim@FreeBSD.org) Received: from freefall.freebsd.org (maxim@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h6DBvXUp056085; Sun, 13 Jul 2003 04:57:33 -0700 (PDT) (envelope-from maxim@freefall.freebsd.org) Received: (from maxim@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h6DBvXMe056081; Sun, 13 Jul 2003 04:57:33 -0700 (PDT) Date: Sun, 13 Jul 2003 04:57:33 -0700 (PDT) From: Maxim Konovalov Message-Id: <200307131157.h6DBvXMe056081@freefall.freebsd.org> To: Arne.Juul@fast.no, maxim@FreeBSD.org, freebsd-fs@FreeBSD.org Subject: Re: bin/43635: filesystem damage not detected by fsck X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jul 2003 11:57:34 -0000 Synopsis: filesystem damage not detected by fsck State-Changed-From-To: open->closed State-Changed-By: maxim State-Changed-When: Sun Jul 13 04:56:53 PDT 2003 State-Changed-Why: Duplicate of bin/40697. http://www.freebsd.org/cgi/query-pr.cgi?pr=43635 From owner-freebsd-fs@FreeBSD.ORG Sun Jul 13 06:52:55 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFE1837B401 for ; Sun, 13 Jul 2003 06:52:55 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 10A2B43F93 for ; Sun, 13 Jul 2003 06:52:55 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.9/8.12.9) with ESMTP id h6DDqjai027834; Sun, 13 Jul 2003 09:52:45 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)h6DDqZvV027829; Sun, 13 Jul 2003 09:52:45 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sun, 13 Jul 2003 09:52:35 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Oliver Fromme In-Reply-To: <200307090913.h699DnK3053575@lurza.secnetix.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-fs@FreeBSD.ORG Subject: Re: NFS problem FreeBSD vs NetApp Filer using tomcat / java X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jul 2003 13:52:56 -0000 On Wed, 9 Jul 2003, Oliver Fromme wrote: > Someone asked me off-list whether I use the "interruptible" flag for > the NFS mounts, and suggested switching it off. > > Well, I always set the interruptible flag, so that processes don't hang > in case of NFS problems (so I can kill or Ctrl-C them). Otherwise they > will hang forever until I reboot. > > It is my understanding that the interruptible flag has only an effect > when a signal is delivered to a process which is blocked on NFS I/O. Or > am I wrong? My recollection is that the linux threading mechanism uses signals between threads as part of its synchronization primitives, etc. It could be that we're seeing a nasty interaction between NFS being unable to distinguish between "user" signals (Ctrl-C from a tty) and "system" signals from the thread library interrupting an NFS operation generated by the pager on a program image file, resulting in a segfault. So it would be interesting to know if turning off that flag makes the program run properly. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories From owner-freebsd-fs@FreeBSD.ORG Thu Jul 17 23:41:25 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C64E637B404 for ; Thu, 17 Jul 2003 23:41:25 -0700 (PDT) Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12D2A43FA3 for ; Thu, 17 Jul 2003 23:41:25 -0700 (PDT) (envelope-from tim@robbins.dropbear.id.au) Received: from mail.robbins.dropbear.id.au (210.50.202.39) by smtp01.syd.iprimus.net.au (7.0.018) id 3F146D0A000AEB89 for freebsd-fs@freebsd.org; Fri, 18 Jul 2003 16:41:23 +1000 Received: by mail.robbins.dropbear.id.au (Postfix, from userid 1000) id F0872C96E; Fri, 18 Jul 2003 16:41:20 +1000 (EST) Date: Fri, 18 Jul 2003 16:41:20 +1000 From: Tim Robbins To: freebsd-fs@freebsd.org Message-ID: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: NFS ftruncate patch for review X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2003 06:41:26 -0000 Any comments on this patch? The referenced PR contains more comments and a test program. It's not obvious from the diff, but the changes are to nfs_setattr() in the va_size != VNOVAL && v_type == VREG case. Change 34590 by tjr@tjr_dev on 2003/07/16 04:40:35 Fix a nasty problem when truncating files over NFS that was introduced between FreeBSD 4.4 and 4.5: we need to set np->n_size again after flushing/truncating buffers in case the cache calls nfs_write(). For example, if the file is truncated to 0 bytes, nfs_write() will often detect that the file is being appended to (since the file is 0 bytes long and we're writing to offset 0), so it then updates np->n_size to reflect the size the file was before it was truncated. PR: 41792 Affected files ... ... //depot/user/tjr/freebsd-tjr/src/sys/nfsclient/nfs_vnops.c#7 edit Differences ... ==== //depot/user/tjr/freebsd-tjr/src/sys/nfsclient/nfs_vnops.c#7 (text+ko) ==== @@ -662,7 +662,13 @@ return (error); } } - np->n_vattr.va_size = vap->va_size; + /* + * np->n_size has already been set to vap->va_size + * in nfs_meta_setsize(). We must set it again since + * nfs_write() could be called when flushing dirty + * buffers, and nfs_write() can modify np->n_size. + */ + np->n_vattr.va_size = np->n_size = vap->va_size; }; } else if ((vap->va_mtime.tv_sec != VNOVAL || vap->va_atime.tv_sec != VNOVAL) && (np->n_flag & NMODIFIED) && From owner-freebsd-fs@FreeBSD.ORG Fri Jul 18 00:38:17 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E76DF37B401; Fri, 18 Jul 2003 00:38:17 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 626BC43F3F; Fri, 18 Jul 2003 00:38:16 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id RAA29591; Fri, 18 Jul 2003 17:38:14 +1000 Date: Fri, 18 Jul 2003 17:38:12 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Tim Robbins In-Reply-To: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> Message-ID: <20030718173517.D22235@gamplex.bde.org> References: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-fs@freebsd.org Subject: Re: NFS ftruncate patch for review X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2003 07:38:18 -0000 On Fri, 18 Jul 2003, Tim Robbins wrote: > Any comments on this patch? The referenced PR contains more comments and a > test program. It's not obvious from the diff, but the changes are to > nfs_setattr() in the va_size != VNOVAL && v_type == VREG case. Good work. I've thought that the PR (41792) was quite serious since it was submitted. BTW, what stopped PRs being mailed to the "normal" lists? freebsd-bugs is normal I think. Bruce From owner-freebsd-fs@FreeBSD.ORG Fri Jul 18 20:35:35 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6076537B401 for ; Fri, 18 Jul 2003 20:35:35 -0700 (PDT) Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFDCB43F75 for ; Fri, 18 Jul 2003 20:35:34 -0700 (PDT) (envelope-from tim@robbins.dropbear.id.au) Received: from mail.robbins.dropbear.id.au (210.50.44.240) by smtp01.syd.iprimus.net.au (7.0.018) id 3F146D0A000D7CA3; Sat, 19 Jul 2003 13:35:33 +1000 Received: by mail.robbins.dropbear.id.au (Postfix, from userid 1000) id 2EA7CC96E; Sat, 19 Jul 2003 13:35:31 +1000 (EST) Date: Sat, 19 Jul 2003 13:35:31 +1000 From: Tim Robbins To: Bruce Evans Message-ID: <20030719033531.GA79812@dilbert.robbins.dropbear.id.au> References: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> <20030718173517.D22235@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030718173517.D22235@gamplex.bde.org> User-Agent: Mutt/1.4.1i cc: freebsd-fs@freebsd.org Subject: Re: NFS ftruncate patch for review X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2003 03:35:35 -0000 On Fri, Jul 18, 2003 at 05:38:12PM +1000, Bruce Evans wrote: > On Fri, 18 Jul 2003, Tim Robbins wrote: > > > Any comments on this patch? The referenced PR contains more comments and a > > test program. It's not obvious from the diff, but the changes are to > > nfs_setattr() in the va_size != VNOVAL && v_type == VREG case. > > Good work. I've thought that the PR (41792) was quite serious since it > was submitted. > > BTW, what stopped PRs being mailed to the "normal" lists? freebsd-bugs is > normal I think. The PRs are still getting mailed to freebsd-bugs. The reason you didn't see my patch when I replied to the PR is because Kris assigned the PR to me. The reason followups go to the freebsd-bugs list is because, by default, the Responsible: field in the PR is set to freebsd-bugs. It would be better if Gnats would always Cc the bugs list. Tim From owner-freebsd-fs@FreeBSD.ORG Fri Jul 18 23:25:04 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF33537B401; Fri, 18 Jul 2003 23:25:04 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A52443FB1; Fri, 18 Jul 2003 23:25:03 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id QAA04415; Sat, 19 Jul 2003 16:25:00 +1000 Date: Sat, 19 Jul 2003 16:24:59 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Tim Robbins In-Reply-To: <20030719033531.GA79812@dilbert.robbins.dropbear.id.au> Message-ID: <20030719161449.O25754@gamplex.bde.org> References: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> <20030719033531.GA79812@dilbert.robbins.dropbear.id.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-fs@freebsd.org Subject: PR mail (was: Re: NFS ftruncate patch for review) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2003 06:25:05 -0000 On Sat, 19 Jul 2003, Tim Robbins wrote: > On Fri, Jul 18, 2003 at 05:38:12PM +1000, Bruce Evans wrote: > > BTW, what stopped PRs being mailed to the "normal" lists? freebsd-bugs is > > normal I think. > > The PRs are still getting mailed to freebsd-bugs. The reason you didn't see my > patch when I replied to the PR is because Kris assigned the PR to me. The I still feel I'm missing many of them. I'll do a more scientific survey. > reason followups go to the freebsd-bugs list is because, by default, the > Responsible: field in the PR is set to freebsd-bugs. It would be better if > Gnats would always Cc the bugs list. I've got the feeling that the default is sometimes (and more often than it used to be) freebsd-list-that-I'm-not-on. Ports PRs always went to somewhere that I didn't see. I rather liked this. Gnats does too good a job of sending all the administrivial mail to freebsd-bugs, as shown by Kris recently generating more PR mail than all commits :-). Bruce From owner-freebsd-fs@FreeBSD.ORG Sat Jul 19 10:57:55 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C39637B401; Sat, 19 Jul 2003 10:57:55 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63A7A43F85; Sat, 19 Jul 2003 10:57:54 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6JHvlLv076272; Sat, 19 Jul 2003 10:57:47 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6JHvaMQ076271; Sat, 19 Jul 2003 10:57:36 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Sat, 19 Jul 2003 10:57:36 -0700 From: David Schultz To: Bruce Evans Message-ID: <20030719175735.GA76229@HAL9000.homeunix.com> Mail-Followup-To: Bruce Evans , Tim Robbins , freebsd-fs@FreeBSD.org References: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> <20030719033531.GA79812@dilbert.robbins.dropbear.id.au> <20030719161449.O25754@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030719161449.O25754@gamplex.bde.org> cc: freebsd-fs@FreeBSD.ORG cc: Tim Robbins Subject: Re: PR mail (was: Re: NFS ftruncate patch for review) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2003 17:57:55 -0000 On Sat, Jul 19, 2003, Bruce Evans wrote: > I've got the feeling that the default is sometimes (and more often than it > used to be) freebsd-list-that-I'm-not-on. Ports PRs always went to somewhere > that I didn't see. I rather liked this. I think some categories of bugs get sent to {fs,security,standards,$arch}@. If you want to see the bugs for a particular category, I guess you have to be interested enough to subscribe to the corresponding list. From owner-freebsd-fs@FreeBSD.ORG Sat Jul 19 15:57:58 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A573037B401; Sat, 19 Jul 2003 15:57:58 -0700 (PDT) Received: from obsecurity.dyndns.org (adsl-67-119-53-152.dsl.lsan03.pacbell.net [67.119.53.152]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2E5443F3F; Sat, 19 Jul 2003 15:57:57 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 721E266BE5; Sat, 19 Jul 2003 15:57:57 -0700 (PDT) Received: by rot13.obsecurity.org (Postfix, from userid 1000) id 4EDD0C01; Sat, 19 Jul 2003 15:57:57 -0700 (PDT) Date: Sat, 19 Jul 2003 15:57:57 -0700 From: Kris Kennaway To: Bruce Evans , Tim Robbins , freebsd-fs@FreeBSD.org Message-ID: <20030719225757.GA80468@rot13.obsecurity.org> References: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> <20030719033531.GA79812@dilbert.robbins.dropbear.id.au> <20030719161449.O25754@gamplex.bde.org> <20030719175735.GA76229@HAL9000.homeunix.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline In-Reply-To: <20030719175735.GA76229@HAL9000.homeunix.com> User-Agent: Mutt/1.4.1i Subject: Re: PR mail (was: Re: NFS ftruncate patch for review) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2003 22:57:58 -0000 --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 19, 2003 at 10:57:36AM -0700, David Schultz wrote: > On Sat, Jul 19, 2003, Bruce Evans wrote: > > I've got the feeling that the default is sometimes (and more often than= it > > used to be) freebsd-list-that-I'm-not-on. Ports PRs always went to som= ewhere > > that I didn't see. I rather liked this. >=20 > I think some categories of bugs get sent to > {fs,security,standards,$arch}@. If you want > to see the bugs for a particular category, I > guess you have to be interested enough to > subscribe to the corresponding list. fs and security don't get PRs by default...some PRs are reassigned to the mailing lists because it targets the class of developers who might be interested in investigating the problem. The default PR destination is determined based on the category of the PR. Here is the current configuration (freefall:~gnats/gnats-adm/categories) pending: Misfiled PRs : gnats-admin : freebsd-bugbusters@freebsd.org # # Other categories # advocacy: Advocacy : freebsd-advocacy : alpha: Architecture (alpha) specific : freebsd-alpha : amd64: Architecture (amd64) specific : freebsd-amd64 : bin: All other sources : freebsd-bugs : conf: Configuration files : freebsd-bugs : docs: Documentation : freebsd-doc : gnu: GNU sources : freebsd-bugs : i386: Architecture (i386) specific : freebsd-i386 : ia64: Architecture (ia64) specific : freebsd-ia64 : java: Java support : freebsd-java : junk: Wastebin : gnats-admin : kern: Kernel sources : freebsd-bugs : misc: Miscellaneous : freebsd-bugs : ports: The ports collection : freebsd-ports-bugs : powerpc: Architecture (powerpc) specific : freebsd-ppc : sparc64: Architecture (sparc) specific : freebsd-sparc64 : standards: Standards conformance issues : freebsd-standards : www: FreeBSD website : freebsd-www : --FL5UXtIhxfXey3p5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/Gcz1Wry0BWjoQKURAtg9AJoCwrp0OBmx682VCvp+64SV5o0/RgCgl0WB /kPDG9hPYGa2kYzRKojmJ9c= =DirC -----END PGP SIGNATURE----- --FL5UXtIhxfXey3p5-- From owner-freebsd-fs@FreeBSD.ORG Sat Jul 19 19:22:36 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4ECEC37B401 for ; Sat, 19 Jul 2003 19:22:36 -0700 (PDT) Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id C233643F3F for ; Sat, 19 Jul 2003 19:22:35 -0700 (PDT) (envelope-from tim@robbins.dropbear.id.au) Received: from mail.robbins.dropbear.id.au (210.50.202.126) by smtp01.syd.iprimus.net.au (7.0.018) id 3F146D0A00103494 for freebsd-fs@freebsd.org; Sun, 20 Jul 2003 12:22:34 +1000 Received: by mail.robbins.dropbear.id.au (Postfix, from userid 1000) id 41CCFC91F; Sun, 20 Jul 2003 12:22:30 +1000 (EST) Date: Sun, 20 Jul 2003 12:22:30 +1000 From: Tim Robbins To: freebsd-fs@freebsd.org Message-ID: <20030720022230.GA82881@dilbert.robbins.dropbear.id.au> References: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> User-Agent: Mutt/1.4.1i Subject: Re: NFS ftruncate patch for review X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 02:22:36 -0000 On Fri, Jul 18, 2003 at 04:41:20PM +1000, Tim Robbins wrote: > Any comments on this patch? The referenced PR contains more comments and a > test program. It's not obvious from the diff, but the changes are to > nfs_setattr() in the va_size != VNOVAL && v_type == VREG case. It turns out that it's nfs_loadattrcache() that is changing n_size when called indirectly from nfs_meta_setsize() in the test case. (Re-)setting n_size before returning from nfs_setattr() is still correct, but the comment was wrong. Tim