From owner-freebsd-net@FreeBSD.ORG  Sun Apr  6 06:12:49 2003
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C156737B401; Sun,  6 Apr 2003 06:12:49 -0700 (PDT)
Received: from grosbein.pp.ru (www2.svzserv.kemerovo.su [213.184.65.86])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5544643F85; Sun,  6 Apr 2003 06:12:46 -0700 (PDT)
	(envelope-from eugen@grosbein.pp.ru)
Received: from grosbein.pp.ru (smmsp@localhost [127.0.0.1])
	by grosbein.pp.ru (8.12.7/8.12.7) with ESMTP id h36DCee1086636;
	Sun, 6 Apr 2003 21:12:40 +0800 (KRAST)
	(envelope-from eugen@grosbein.pp.ru)
Received: (from eugen@localhost)
	by grosbein.pp.ru (8.12.7/8.12.7/Submit) id h36DC4pg086609;
	Sun, 6 Apr 2003 21:12:04 +0800 (KRAST)
Date: Sun, 6 Apr 2003 21:12:04 +0800
From: Eugene Grosbein <eugen@grosbein.pp.ru>
To: bug-followup@freebsd.org
Message-ID: <20030406211204.A509@grosbein.pp.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
cc: peter@freebsd.org
cc: net@freebsd.org
Subject: Re: bin/45760: pppd(8) incoreectly handles timeouts after long run
	[PATCH]
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Apr 2003 13:12:50 -0000

Hi!

I've found the source of this behavour.
pppd 2.3.5 violates RFC1548, section 5.8 that states:

      Echo-Request and Echo-Reply packets may only be sent in the LCP
      Opened state.  Echo-Request and Echo-Reply packets received in any
      state other than the LCP Opened state SHOULD be silently
      discarded.

pppd 2.3.5 will schedule one extra LCP Echo for each incident
when it detects via LCP Echos that peer has disconnected.

So my the solution was to patch lcp.c:

--- usr.sbin/pppd/lcp.c.orig	Sun Apr  6 21:05:21 2003
+++ usr.sbin/pppd/lcp.c	Sun Apr  6 21:05:36 2003
@@ -1737,6 +1737,8 @@
     fsm *f;
 {
     LcpSendEchoRequest (f);
+    if (f->state != OPENED)
+	return;
 
     /*
      * Start the timer for the next interval.

I've checked pppd 2.4.1 and found that it contains exactly this code.
Please apply the patch.

Eugene Grosbein