From owner-p4-projects@FreeBSD.ORG  Sun Aug 17 08:33:32 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7A2C837B404; Sun, 17 Aug 2003 08:33:31 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1BF6537B401
	for <perforce@freebsd.org>; Sun, 17 Aug 2003 08:33:31 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 62DFF43FB1
	for <perforce@freebsd.org>; Sun, 17 Aug 2003 08:33:30 -0700 (PDT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.9/8.12.9) with ESMTP id h7HFWrAL013050;
	Sun, 17 Aug 2003 11:32:53 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)h7HFWrUo013047;
	Sun, 17 Aug 2003 11:32:53 -0400 (EDT)
Date: Sun, 17 Aug 2003 11:32:52 -0400 (EDT)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
In-Reply-To: <20030816164300.GS395@garage.freebsd.pl>
Message-ID: <Pine.NEB.3.96L.1030817112953.8748A-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 35655 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Aug 2003 15:33:32 -0000


On Sat, 16 Aug 2003, Pawel Jakub Dawidek wrote:

> On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote:
> +> -    mode ~= cmask;
> +> +    mode = mode &~ cmask;
> 
> IMHO this is a style bug. 
>
> This should be: mode = mode & ~cmask; 
> 
> On time, when I was tired, I've spend few minutes wondering why 'foo'
> after this operation isn't equal to 'foo - bar':) 
>
> 	foo =- bar;

Heh. :-)

Yeah -- all these instances of mode/cmask combination will move into a
centralized function in the next pass, similar to the
acl_posix1e_newfilemode() function (which will also gain a cmask
argument).  In the current pass, I'm trying to hit every place where modes
and masks will be combined at the file system level. 

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories