From owner-cvs-all@FreeBSD.ORG Sun Mar 28 00:10:04 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C54FB16A4CE; Sun, 28 Mar 2004 00:10:04 -0800 (PST) Received: from darkness.comp.waw.pl (unknown [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 139ED43D31; Sun, 28 Mar 2004 00:10:04 -0800 (PST) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id C09FEACBCF; Sun, 28 Mar 2004 10:10:02 +0200 (CEST) Date: Sun, 28 Mar 2004 10:10:02 +0200 From: Pawel Jakub Dawidek To: Robert Watson Message-ID: <20040328081002.GW8930@darkness.comp.waw.pl> References: <4066159C.7030102@elischer.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5t1z8kqiv7KqGNMe" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Julian Elischer cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in_pcb.c in_pcb.h ip_divert.c tcp_syncache.c tcp_usrreq.c udp_usrreq.c src/sys/netinet6 in6_pcb.c in6_pcb.h in6_src.c udp6_output.c udp6_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2004 08:10:04 -0000 --5t1z8kqiv7KqGNMe Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 27, 2004 at 09:52:57PM -0500, Robert Watson wrote: +> The credential is only used during the functions, and the reference is +> owned by the calling thread for the duration of the calls. This change +> basically moves the td->td_ucred dereference to the caller, rather than +> doing them in the function. It should be no less safe than the existing +> code, and since td_ucred is a thread-local reference, it should be safe +> assuming curthread=3D=3Dtd in the caller. The only place I've found, where curthread !=3D td, is NFS code, where thread0 is used instead of curthread, but it should be also safe. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --5t1z8kqiv7KqGNMe Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAZohaForvXbEpPzQRAk7uAJ9Al4JNVmgHJthnZq7jUjEezbETMQCgl+50 2C9uOrEdByAbX5oNd70TH+I= =tvhQ -----END PGP SIGNATURE----- --5t1z8kqiv7KqGNMe--