From owner-cvs-src@FreeBSD.ORG Sun Jun 6 01:12:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DE1616A4CE; Sun, 6 Jun 2004 01:12:35 -0700 (PDT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 2479C43D2F; Sun, 6 Jun 2004 01:12:34 -0700 (PDT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 6 Jun 2004 09:12:22 +0100 (BST) Date: Sun, 6 Jun 2004 09:12:21 +0100 From: David Malone To: David Schultz Message-ID: <20040606081221.GA11314@walton.maths.tcd.ie> References: <200406050313.i553Dd3q070600@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406050313.i553Dd3q070600@repoman.freebsd.org> User-Agent: Mutt/1.5.3i Sender: dwmalone@maths.tcd.ie cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 08:12:35 -0000 On Fri, Jun 04, 2004 at 08:13:39PM -0700, David Schultz wrote: > Modified files: > sys/amd64/amd64 fpu.c > Log: > Initialize the MXCSR to the appropriate default value at startup. This seems to result in a "Fault trap 1: privileged instrustion fault while in the kernel" while executing the ldmscsr instruction. If I comment it out, everything works fine again. > Tested on: tjr This must be a situation where testing on humans is bad ;-) David. From owner-cvs-src@FreeBSD.ORG Sun Jun 6 02:14:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 868AB16A4CE; Sun, 6 Jun 2004 02:14:54 -0700 (PDT) Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7EFE43D3F; Sun, 6 Jun 2004 02:14:53 -0700 (PDT) (envelope-from tim@robbins.dropbear.id.au) Received: from robbins.dropbear.id.au (210.50.80.164) by smtp01.syd.iprimus.net.au (7.0.024) id 40B7A0DA00266C6F; Sun, 6 Jun 2004 19:14:52 +1000 Received: by robbins.dropbear.id.au (Postfix, from userid 1000) id EE95041D2; Sun, 6 Jun 2004 19:16:23 +1000 (EST) Date: Sun, 6 Jun 2004 19:16:23 +1000 From: Tim Robbins To: David Malone Message-ID: <20040606091623.GA33323@cat.robbins.dropbear.id.au> References: <200406050313.i553Dd3q070600@repoman.freebsd.org> <20040606081221.GA11314@walton.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040606081221.GA11314@walton.maths.tcd.ie> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: David Schultz cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 09:14:54 -0000 On Sun, Jun 06, 2004 at 09:12:21AM +0100, David Malone wrote: > On Fri, Jun 04, 2004 at 08:13:39PM -0700, David Schultz wrote: > > Modified files: > > sys/amd64/amd64 fpu.c > > Log: > > Initialize the MXCSR to the appropriate default value at startup. > > This seems to result in a "Fault trap 1: privileged instrustion > fault while in the kernel" while executing the ldmscsr instruction. > If I comment it out, everything works fine again. > > > Tested on: tjr > > This must be a situation where testing on humans is bad ;-) It works fine here. CPU: AMD Athlon(tm) 64 Processor 3000+ (2002.57-MHz K8-class CPU) Origin = "AuthenticAMD" Id = 0xf48 Stepping = 8 Features=0x78bfbff AMD Features=0xe0500800 Tim From owner-cvs-src@FreeBSD.ORG Sun Jun 6 02:16:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2735316A4CE; Sun, 6 Jun 2004 02:16:03 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A42143D2F; Sun, 6 Jun 2004 02:16:03 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i569G2Uo097114; Sun, 6 Jun 2004 09:16:02 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i569G2m2097113; Sun, 6 Jun 2004 09:16:02 GMT (envelope-from das) Message-Id: <200406060916.i569G2m2097113@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 09:16:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 09:16:03 -0000 das 2004-06-06 09:16:02 UTC FreeBSD src repository Modified files: sys/amd64/amd64 fpu.c Log: Back out revision 1.150, since dwmalone reports that it causes a panic upon startup on his machine. Revision Changes Path 1.151 +0 -4 src/sys/amd64/amd64/fpu.c From owner-cvs-src@FreeBSD.ORG Sun Jun 6 02:17:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6238D16A4CE; Sun, 6 Jun 2004 02:17:07 -0700 (PDT) Received: from VARK.homeunix.com (ar59.lsanca2-4.27.98.47.lsanca2.dsl-verizon.net [4.27.98.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id E81CE43D1D; Sun, 6 Jun 2004 02:17:06 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i569H3jE006327; Sun, 6 Jun 2004 02:17:03 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i569H3Bo006326; Sun, 6 Jun 2004 02:17:03 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Sun, 6 Jun 2004 02:17:03 -0700 From: David Schultz To: David Malone Message-ID: <20040606091703.GA6016@VARK.homeunix.com> Mail-Followup-To: David Malone , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406050313.i553Dd3q070600@repoman.freebsd.org> <20040606081221.GA11314@walton.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040606081221.GA11314@walton.maths.tcd.ie> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 09:17:07 -0000 On Sun, Jun 06, 2004, David Malone wrote: > On Fri, Jun 04, 2004 at 08:13:39PM -0700, David Schultz wrote: > > Modified files: > > sys/amd64/amd64 fpu.c > > Log: > > Initialize the MXCSR to the appropriate default value at startup. > > This seems to result in a "Fault trap 1: privileged instrustion > fault while in the kernel" while executing the ldmscsr instruction. > If I comment it out, everything works fine again. Sorry, I just backed it out for the mean time. Can you send me your dmesg|head please? From owner-cvs-src@FreeBSD.ORG Sun Jun 6 02:18:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F15A316A4CE; Sun, 6 Jun 2004 02:18:08 -0700 (PDT) Received: from VARK.homeunix.com (ar59.lsanca2-4.27.98.47.lsanca2.dsl-verizon.net [4.27.98.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D7C843D48; Sun, 6 Jun 2004 02:18:08 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i569HwcE006371; Sun, 6 Jun 2004 02:17:58 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i569Hwar006370; Sun, 6 Jun 2004 02:17:58 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Sun, 6 Jun 2004 02:17:58 -0700 From: David Schultz To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20040606091758.GA6354@VARK.homeunix.com> Mail-Followup-To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406060916.i569G2m2097113@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406060916.i569G2m2097113@repoman.freebsd.org> Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 09:18:09 -0000 On Sun, Jun 06, 2004, David Schultz wrote: > das 2004-06-06 09:16:02 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 fpu.c > Log: > Back out revision 1.150, since dwmalone reports that it causes a panic > upon startup on his machine. It would be great if someone could pick this up and devise the appropriate fix. I want to see this bug fixed, but I don't have the hardware to do amd64 kernel hacking. I'm happy to help anyone who is interested. So far I have one report that the patch I just backed out seems to work, and another that it panics on startup, so this seems to point to a CPU-specific problem. ldmxcsr is supposed to fail if an attempt is made to set unsupported bits in the CSR, but at the same time, the defaults in the AMD64 architecture manual ought to work! If this is indeed the problem, there is a simple way to work around it. From owner-cvs-src@FreeBSD.ORG Sun Jun 6 02:30:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CF9416A4D0; Sun, 6 Jun 2004 02:30:11 -0700 (PDT) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id E364A43D2D; Sun, 6 Jun 2004 02:30:10 -0700 (PDT) (envelope-from kientzle@freebsd.org) Received: from freebsd.org (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id i569Tx90060427; Sun, 6 Jun 2004 02:30:00 -0700 (PDT) (envelope-from kientzle@freebsd.org) Message-ID: <40C2E401.5010400@freebsd.org> Date: Sun, 06 Jun 2004 02:29:37 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bruce Evans References: <20040605053115.45AE416A585@hub.freebsd.org> <20040605000326.B54841@root.org> <40C22518.6060406@kientzle.com> <20040606143616.W2060@gamplex.bde.org> In-Reply-To: <20040606143616.W2060@gamplex.bde.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Tim Kientzle cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Nate Lawson Subject: Re: cvs commit: src/lib/libarchive archive_read_extract.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 09:30:11 -0000 Bruce Evans wrote: > On Sat, 5 Jun 2004, Tim Kientzle wrote: > >>>>+ if (stat(name, &st) == 0 && S_ISDIR(st.st_mode)) > > Perhaps this or a nearby stat() should be lstat(). libarchive doesn't > use a single lstat() (though bsdtar does). No, this should be stat(). Otherwise, you cannot extract through an existing symlink. (E.g., some people need to be able to do the following: ln -s /other/disk /usr/ports bsdtar xf ports.tgz Also, note that---apart from the "extract" function---libarchive doesn't deal with stuff on disk. It just knows how to assemble/disassemble archives. It has very little reason to use either stat() or lstat(). > In fact, this stuff is quite broken. After "cd /tmp; ln -s /tmp foo", > tarring up foo[/.] gives the following misbehaviours with yesterday's > versions of tars: > > tar cf z foo: > only puts foo in the archive (correct) > bsdtar cf z foo: > same, except bsdtar seems to be too smart about padding the output > to a block boundary for regular files, so subsequent piping of the > file might not work The default padding behavior for bsdtar was changed quite a while ago to not pad regular files; are you sure you're up-to-date? > tar cf z foo/: > only puts foo in the archive (broken) > bsdtar cf z foo/: > same Here, bsdtar cf z foo/ does follow the symlink, which I presume you believe to be the correct behavior? > tar cf z foo/.: > puts files named foo/./* in the archive (everything under /tmp except > z). Warns about not attempting to put the archive inside itself. > bsdtar cf z foo/.: > same, except it silently puts a truncated copy of the archive inside > itself. Yes, bsdtar does not yet have a check for visiting the archive itself. I agree that this is broken. Tim From owner-cvs-src@FreeBSD.ORG Sun Jun 6 02:56:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C4CC516A4CE; Sun, 6 Jun 2004 02:56:41 -0700 (PDT) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C8FB43D1D; Sun, 6 Jun 2004 02:56:41 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87])i569ud4u009981; Sun, 6 Jun 2004 19:56:39 +1000 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i569uaLS008398; Sun, 6 Jun 2004 19:56:37 +1000 Date: Sun, 6 Jun 2004 19:56:36 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Tim Kientzle In-Reply-To: <40C2E401.5010400@freebsd.org> Message-ID: <20040606195023.M3004@gamplex.bde.org> References: <20040605053115.45AE416A585@hub.freebsd.org> <20040605000326.B54841@root.org> <20040606143616.W2060@gamplex.bde.org> <40C2E401.5010400@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Tim Kientzle cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Nate Lawson Subject: Re: cvs commit: src/lib/libarchive archive_read_extract.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 09:56:41 -0000 On Sun, 6 Jun 2004, Tim Kientzle wrote: > Bruce Evans wrote: > > On Sat, 5 Jun 2004, Tim Kientzle wrote: > > In fact, this stuff is quite broken. After "cd /tmp; ln -s /tmp foo", > > tarring up foo[/.] gives the following misbehaviours with yesterday's > > versions of tars: > > > > tar cf z foo: > > only puts foo in the archive (correct) > > bsdtar cf z foo: > > same, except bsdtar seems to be too smart about padding the output > > to a block boundary for regular files, so subsequent piping of the > > file might not work > > The default padding behavior for bsdtar was changed quite > a while ago to not pad regular files; are you sure you're up-to-date? Yes; not padding is a bug and the above says that I have it. > > tar cf z foo/: > > only puts foo in the archive (broken) > > bsdtar cf z foo/: > > same > > Here, bsdtar cf z foo/ does follow the symlink, which I > presume you believe to be the correct behavior? Yes. foo/ is not a symlink (the slash forces folling the symlink) in the kernel, so it should do so in utilities too. Tab completion in shells cah cause problems here. You want the symlink and type foo, but tab completion may change it to "foo/". Bruce From owner-cvs-src@FreeBSD.ORG Sun Jun 6 02:58:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52FB616A4CE; Sun, 6 Jun 2004 02:58:56 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D14543D39; Sun, 6 Jun 2004 02:58:56 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i569wuIx005344; Sun, 6 Jun 2004 09:58:56 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i569wuqI005343; Sun, 6 Jun 2004 09:58:56 GMT (envelope-from das) Message-Id: <200406060958.i569wuqI005343@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 09:58:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/alpha fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 09:58:56 -0000 das 2004-06-06 09:58:55 UTC FreeBSD src repository Added files: lib/msun/alpha fenv.c fenv.h Log: Add an fenv.h implementation for the alpha port. All of the standard features appear to work, subject to the caveat that you tell gcc you want standard rather than recklessly fast behavior (-mieee-with-inexact -mfp-rounding-mode=d). The non-standard feature of delivering a SIGFPE when an application raises an unmasked exception does not work, presumably due to a kernel bug. This isn't so bad given that floating-point exceptions on the Alpha architecture are not precise, so making them useful in userland requires a significant amount of wizardry. Reviewed by: standards@ Revision Changes Path 1.1 +131 -0 src/lib/msun/alpha/fenv.c (new) 1.1 +184 -0 src/lib/msun/alpha/fenv.h (new) From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:03:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8300416A4CE; Sun, 6 Jun 2004 03:03:26 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BFB343D58; Sun, 6 Jun 2004 03:03:26 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A3Q5X008242; Sun, 6 Jun 2004 10:03:26 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A3PkE008241; Sun, 6 Jun 2004 10:03:25 GMT (envelope-from das) Message-Id: <200406061003.i56A3PkE008241@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:03:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/amd64 fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:03:26 -0000 das 2004-06-06 10:03:25 UTC FreeBSD src repository Added files: lib/msun/amd64 fenv.c fenv.h Log: Add an fenv.h implementation for the amd64 port. Reviewed by: standards@ Revision Changes Path 1.1 +131 -0 src/lib/msun/amd64/fenv.c (new) 1.1 +202 -0 src/lib/msun/amd64/fenv.h (new) From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:04:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C77216A4CE; Sun, 6 Jun 2004 03:04:00 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A6BC43D45; Sun, 6 Jun 2004 03:04:00 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A40WJ008287; Sun, 6 Jun 2004 10:04:00 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A40F3008286; Sun, 6 Jun 2004 10:04:00 GMT (envelope-from das) Message-Id: <200406061004.i56A40F3008286@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:03:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/arm fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:04:00 -0000 das 2004-06-06 10:03:59 UTC FreeBSD src repository Added files: lib/msun/arm fenv.c fenv.h Log: Add an fenv.h implementation for the arm port. It does not appear to be possible to cross-build arm from i386 at the moment, and I have no ARM hardware anyway. Thus, I'm sure there are bugs. I will gladly fix these when the arm port is more mature. Reviewed by: standards@ Revision Changes Path 1.1 +35 -0 src/lib/msun/arm/fenv.c (new) 1.1 +195 -0 src/lib/msun/arm/fenv.h (new) From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:04:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FB0516A4CF; Sun, 6 Jun 2004 03:04:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3286843D2F; Sun, 6 Jun 2004 03:04:18 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A4IVs008328; Sun, 6 Jun 2004 10:04:18 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A4HpL008327; Sun, 6 Jun 2004 10:04:17 GMT (envelope-from das) Message-Id: <200406061004.i56A4HpL008327@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:04:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/i387 fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:04:18 -0000 das 2004-06-06 10:04:17 UTC FreeBSD src repository Added files: lib/msun/i387 fenv.c fenv.h Log: Add an fenv.h implementation for the i386 port. Reviewed by: standards@ Revision Changes Path 1.1 +39 -0 src/lib/msun/i387/fenv.c (new) 1.1 +224 -0 src/lib/msun/i387/fenv.h (new) From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:04:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 787B816A4D2; Sun, 6 Jun 2004 03:04:44 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ADE843D45; Sun, 6 Jun 2004 03:04:44 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A4imr008365; Sun, 6 Jun 2004 10:04:44 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A4iZk008364; Sun, 6 Jun 2004 10:04:44 GMT (envelope-from das) Message-Id: <200406061004.i56A4iZk008364@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:04:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/ia64 fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:04:44 -0000 das 2004-06-06 10:04:44 UTC FreeBSD src repository Added files: lib/msun/ia64 fenv.c fenv.h Log: Add an fenv.h implementation for the ia64 port. Reviewed by: standards@ Revision Changes Path 1.1 +49 -0 src/lib/msun/ia64/fenv.c (new) 1.1 +231 -0 src/lib/msun/ia64/fenv.h (new) From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:05:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A94216A4D3; Sun, 6 Jun 2004 03:05:11 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D3A443D1F; Sun, 6 Jun 2004 03:05:11 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A5BmY008416; Sun, 6 Jun 2004 10:05:11 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A5B8I008415; Sun, 6 Jun 2004 10:05:11 GMT (envelope-from das) Message-Id: <200406061005.i56A5B8I008415@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:05:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/powerpc fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:05:11 -0000 das 2004-06-06 10:05:10 UTC FreeBSD src repository Added files: lib/msun/powerpc fenv.c fenv.h Log: Add an fenv.h implementation for the powerpc port. Reviewed by: standards@ Revision Changes Path 1.1 +31 -0 src/lib/msun/powerpc/fenv.c (new) 1.1 +251 -0 src/lib/msun/powerpc/fenv.h (new) From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:06:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03E8316A4CE; Sun, 6 Jun 2004 03:06:00 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DAF8443D55; Sun, 6 Jun 2004 03:05:59 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A5vCu008527; Sun, 6 Jun 2004 10:05:57 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A5vx7008526; Sun, 6 Jun 2004 10:05:57 GMT (envelope-from das) Message-Id: <200406061005.i56A5vx7008526@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:05:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/sparc64 fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:06:00 -0000 das 2004-06-06 10:05:57 UTC FreeBSD src repository Added files: lib/msun/sparc64 fenv.c fenv.h Log: Add an fenv.h implementation for the sparc64 port. Reviewed by: standards@ Revision Changes Path 1.1 +36 -0 src/lib/msun/sparc64/fenv.c (new) 1.1 +244 -0 src/lib/msun/sparc64/fenv.h (new) From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:06:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACC1A16A4CE; Sun, 6 Jun 2004 03:06:26 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 900AF43D46; Sun, 6 Jun 2004 03:06:26 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A6Qrl008595; Sun, 6 Jun 2004 10:06:26 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A6QcP008594; Sun, 6 Jun 2004 10:06:26 GMT (envelope-from das) Message-Id: <200406061006.i56A6QcP008594@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:06:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/man feclearexcept.3 fegetenv.3 fegetround.3 fenv.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:06:26 -0000 das 2004-06-06 10:06:26 UTC FreeBSD src repository Added files: lib/msun/man feclearexcept.3 fegetenv.3 fegetround.3 fenv.3 Log: Add documentation for: - fenv(3) - feclearexcept(3), fegetexceptflag(3), feraiseexcept(3), fesetexceptflag(3), fetestexcept(3) - fegetround(3), fesetround(3) - fegetenv(3), feholdexcept(3), fesetenv(3), feupdateenv(3) Reviewed by: standards@ Revision Changes Path 1.1 +137 -0 src/lib/msun/man/feclearexcept.3 (new) 1.1 +113 -0 src/lib/msun/man/fegetenv.3 (new) 1.1 +85 -0 src/lib/msun/man/fegetround.3 (new) 1.1 +266 -0 src/lib/msun/man/fenv.3 (new) From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:07:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 165EE16A4CE; Sun, 6 Jun 2004 03:07:08 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE07143D3F; Sun, 6 Jun 2004 03:07:07 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A6vEK008633; Sun, 6 Jun 2004 10:06:57 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A6v7b008632; Sun, 6 Jun 2004 10:06:57 GMT (envelope-from das) Message-Id: <200406061006.i56A6v7b008632@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:06:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:07:08 -0000 das 2004-06-06 10:06:57 UTC FreeBSD src repository Modified files: lib/msun Makefile Log: Add fenv.h, fenv.c, and the associated documentation to the libm build. To facilitate this, add ${.CURDIR}/${ARCH} to make's search path unconditionally. Reviewed by: standards@ Revision Changes Path 1.41 +12 -5 src/lib/msun/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:07:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D771616A4CE; Sun, 6 Jun 2004 03:07:22 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA3F643D45; Sun, 6 Jun 2004 03:07:22 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56A7EQo008671; Sun, 6 Jun 2004 10:07:14 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56A7Ela008670; Sun, 6 Jun 2004 10:07:14 GMT (envelope-from das) Message-Id: <200406061007.i56A7Ela008670@repoman.freebsd.org> From: David Schultz Date: Sun, 6 Jun 2004 10:07:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man3 fpgetround.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:07:23 -0000 das 2004-06-06 10:07:13 UTC FreeBSD src repository Modified files: share/man/man3 fpgetround.3 Log: Cross-reference fenv(3). Revision Changes Path 1.13 +5 -0 src/share/man/man3/fpgetround.3 From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:08:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D2E016A4CE; Sun, 6 Jun 2004 03:08:27 -0700 (PDT) Received: from VARK.homeunix.com (ar59.lsanca2-4.27.98.47.lsanca2.dsl-verizon.net [4.27.98.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED1E643D2F; Sun, 6 Jun 2004 03:08:26 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i56A8JTU007011; Sun, 6 Jun 2004 03:08:19 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i56A8JRx007010; Sun, 6 Jun 2004 03:08:19 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Sun, 6 Jun 2004 03:08:19 -0700 From: David Schultz To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20040606100819.GA6990@VARK.homeunix.com> Mail-Followup-To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406060958.i569wuqI005343@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406060958.i569wuqI005343@repoman.freebsd.org> Subject: Re: cvs commit: src/lib/msun/alpha fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:08:27 -0000 On Sun, Jun 06, 2004, David Schultz wrote: > das 2004-06-06 09:58:55 UTC > > FreeBSD src repository > > Added files: > lib/msun/alpha fenv.c fenv.h > Log: > Add an fenv.h implementation for the alpha port. All of the standard > features appear to work, subject to the caveat that you tell gcc you > want standard rather than recklessly fast behavior > (-mieee-with-inexact -mfp-rounding-mode=d). > > The non-standard feature of delivering a SIGFPE when an application > raises an unmasked exception does not work, presumably due to a kernel > bug. This isn't so bad given that floating-point exceptions on the > Alpha architecture are not precise, so making them useful in userland > requires a significant amount of wizardry. > > Reviewed by: standards@ Some bugs in the kernel's floating-point emulation routines were fixed on May 6. You should have a more recent kernel if you want to access the floating-point environment. From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:09:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1594D16A4CE; Sun, 6 Jun 2004 03:09:03 -0700 (PDT) Received: from VARK.homeunix.com (ar59.lsanca2-4.27.98.47.lsanca2.dsl-verizon.net [4.27.98.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC17643D3F; Sun, 6 Jun 2004 03:09:02 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i56A8xgH007022; Sun, 6 Jun 2004 03:08:59 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i56A8x8v007021; Sun, 6 Jun 2004 03:08:59 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Sun, 6 Jun 2004 03:08:59 -0700 From: David Schultz To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20040606100859.GB6990@VARK.homeunix.com> Mail-Followup-To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406061003.i56A3PkE008241@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406061003.i56A3PkE008241@repoman.freebsd.org> Subject: Re: cvs commit: src/lib/msun/amd64 fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:09:03 -0000 On Sun, Jun 06, 2004, David Schultz wrote: > das 2004-06-06 10:03:25 UTC > > FreeBSD src repository > > Added files: > lib/msun/amd64 fenv.c fenv.h > Log: > Add an fenv.h implementation for the amd64 port. > > Reviewed by: standards@ As mentioned previously here and on amd64@, applications using fenv.h may notice that the kernel does not set the default environment properly. This has nothing to do with the userland bits, but will hopefully be fixed soon. From owner-cvs-src@FreeBSD.ORG Sun Jun 6 03:10:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC36C16A4CE; Sun, 6 Jun 2004 03:10:03 -0700 (PDT) Received: from VARK.homeunix.com (ar59.lsanca2-4.27.98.47.lsanca2.dsl-verizon.net [4.27.98.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D16643D46; Sun, 6 Jun 2004 03:10:03 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i56AA0T4007046; Sun, 6 Jun 2004 03:10:00 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i56AA0d3007045; Sun, 6 Jun 2004 03:10:00 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Sun, 6 Jun 2004 03:09:50 -0700 From: David Schultz To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20040606100950.GC6990@VARK.homeunix.com> Mail-Followup-To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406061005.i56A5B8I008415@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406061005.i56A5B8I008415@repoman.freebsd.org> Subject: Re: cvs commit: src/lib/msun/powerpc fenv.c fenv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 10:10:03 -0000 On Sun, Jun 06, 2004, David Schultz wrote: > das 2004-06-06 10:05:10 UTC > > FreeBSD src repository > > Added files: > lib/msun/powerpc fenv.c fenv.h > Log: > Add an fenv.h implementation for the powerpc port. There does not appear to be a powerpc machine in the cluster for testing this, but the code appears to work on Darwin. I would be interested in feedback from people with FreeBSD/powerpc boxen. From owner-cvs-src@FreeBSD.ORG Sun Jun 6 04:46:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D493416A4CE; Sun, 6 Jun 2004 04:46:32 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5EB843D41; Sun, 6 Jun 2004 04:46:32 -0700 (PDT) (envelope-from schweikh@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56BkULR030117; Sun, 6 Jun 2004 11:46:30 GMT (envelope-from schweikh@repoman.freebsd.org) Received: (from schweikh@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56BkUQ8030116; Sun, 6 Jun 2004 11:46:30 GMT (envelope-from schweikh) Message-Id: <200406061146.i56BkUQ8030116@repoman.freebsd.org> From: Jens Schweikhardt Date: Sun, 6 Jun 2004 11:46:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc csh.login devd.conf devfs.conf disktab gettytab hosts.allow inetd.conf login.access login.conf network.subr pccard_ether pf.os printcap profile rc.shutdown remote rpc termcap.small src/etc/bluetooth hcsecd.conf ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 11:46:33 -0000 schweikh 2004-06-06 11:46:30 UTC FreeBSD src repository Modified files: etc csh.login devd.conf devfs.conf disktab gettytab hosts.allow inetd.conf login.access login.conf network.subr pccard_ether pf.os printcap profile rc.shutdown remote rpc termcap.small etc/bluetooth hcsecd.conf etc/defaults pccard.conf etc/isdn isdnd.rates.D isdnd.rates.F isdnd.rates.L isdnd.rc.sample unknown_incoming etc/namedb named.conf named.root etc/pam.d README convert.pl etc/rc.d initdiskless Log: Removed whitespace at BOF, EOL & EOF. Revision Changes Path 1.2 +3 -3 src/etc/bluetooth/hcsecd.conf 1.21 +3 -3 src/etc/csh.login 1.269 +21 -21 src/etc/defaults/pccard.conf 1.13 +1 -1 src/etc/devd.conf 1.2 +3 -5 src/etc/devfs.conf 1.25 +2 -2 src/etc/disktab 1.22 +1 -1 src/etc/gettytab 1.17 +4 -4 src/etc/hosts.allow 1.69 +1 -1 src/etc/inetd.conf 1.4 +2 -2 src/etc/isdn/isdnd.rates.D 1.4 +9 -9 src/etc/isdn/isdnd.rates.F 1.2 +1 -1 src/etc/isdn/isdnd.rates.L 1.4 +29 -29 src/etc/isdn/isdnd.rc.sample 1.3 +4 -4 src/etc/isdn/unknown_incoming 1.4 +6 -6 src/etc/login.access 1.49 +1 -1 src/etc/login.conf 1.15 +1 -1 src/etc/namedb/named.conf 1.12 +2 -2 src/etc/namedb/named.root 1.154 +1 -1 src/etc/network.subr 1.5 +4 -4 src/etc/pam.d/README 1.6 +3 -3 src/etc/pam.d/convert.pl 1.41 +1 -1 src/etc/pccard_ether 1.2 +1 -3 src/etc/pf.os 1.14 +1 -1 src/etc/printcap 1.14 +2 -2 src/etc/profile 1.38 +1 -1 src/etc/rc.d/initdiskless 1.26 +1 -1 src/etc/rc.shutdown 1.15 +1 -1 src/etc/remote 1.11 +2 -2 src/etc/rpc 1.28 +2 -2 src/etc/termcap.small From owner-cvs-src@FreeBSD.ORG Sun Jun 6 05:09:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37EAD16A4CE; Sun, 6 Jun 2004 05:09:48 -0700 (PDT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id F164643D45; Sun, 6 Jun 2004 05:09:46 -0700 (PDT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 6 Jun 2004 13:09:26 +0100 (BST) To: David Schultz In-reply-to: Your message of "Sun, 06 Jun 2004 02:17:03 PDT." <20040606091703.GA6016@VARK.homeunix.com> X-Request-Do: Date: Sun, 06 Jun 2004 13:09:26 +0100 From: David Malone Message-ID: <200406061309.aa25052@salmon.maths.tcd.ie> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 12:09:48 -0000 > > This seems to result in a "Fault trap 1: privileged instrustion > > fault while in the kernel" while executing the ldmscsr instruction. > > If I comment it out, everything works fine again. > Sorry, I just backed it out for the mean time. Can you send me > your dmesg|head please? Sure - included below. I tried the same instruction in userland and it caused no problems. David. Copyright (c) 1992-2004 The FreeBSD Project. Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 The Regents of the University of California. All rights reserved. FreeBSD 5.2-CURRENT #3: Sun May 30 22:14:07 GMT 2004 dwmalone@sweetums.eastwall.dwmalone.net:/usr/src/sys/amd64/compile/GENERIC WARNING: WITNESS option enabled, expect reduced performance. Preloaded elf kernel "/boot/kernel.old/kernel" at 0xffffffff8091e000. Timecounter "i8254" frequency 1193182 Hz quality 0 CPU: AMD Opteron(tm) Processor 238 (1804.10-MHz K8-class CPU) Origin = "AuthenticAMD" Id = 0xf58 Stepping = 8 Features=0x78bfbff AMD Features=0xe0500800 real memory = 3756982272 (3582 MB) avail memory = 3623555072 (3455 MB) ACPI APIC Table: FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs cpu0 (BSP): APIC ID: 0 cpu1 (AP): APIC ID: 1 From owner-cvs-src@FreeBSD.ORG Sun Jun 6 05:30:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E966916A4CE; Sun, 6 Jun 2004 05:30:21 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE7EC43D1F; Sun, 6 Jun 2004 05:30:21 -0700 (PDT) (envelope-from schweikh@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56CULOs039280; Sun, 6 Jun 2004 12:30:21 GMT (envelope-from schweikh@repoman.freebsd.org) Received: (from schweikh@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56CULWv039279; Sun, 6 Jun 2004 12:30:21 GMT (envelope-from schweikh) Message-Id: <200406061230.i56CULWv039279@repoman.freebsd.org> From: Jens Schweikhardt Date: Sun, 6 Jun 2004 12:30:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man7 tuning.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 12:30:22 -0000 schweikh 2004-06-06 12:30:21 UTC FreeBSD src repository Modified files: share/man/man7 tuning.7 Log: s/disklabel/bsdlabel/g Removed paragraph about "new experimental feature" the hw.ata.tags which sysctl -a knows nothing about. Fix typos while I'm here. PR: docs/66493 Submitted by: Julien Gabel Revision Changes Path 1.63 +4 -16 src/share/man/man7/tuning.7 From owner-cvs-src@FreeBSD.ORG Sun Jun 6 06:35:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B580816A4CE; Sun, 6 Jun 2004 06:35:41 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9733143D1D; Sun, 6 Jun 2004 06:35:41 -0700 (PDT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56DZcOx060571; Sun, 6 Jun 2004 13:35:38 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56DZc4o060570; Sun, 6 Jun 2004 13:35:38 GMT (envelope-from pjd) Message-Id: <200406061335.i56DZc4o060570@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sun, 6 Jun 2004 13:35:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man9 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 13:35:41 -0000 pjd 2004-06-06 13:35:38 UTC FreeBSD src repository Modified files: share/man/man9 Makefile Log: Add missing link. Revision Changes Path 1.235 +2 -1 src/share/man/man9/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jun 6 08:17:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C8DA16A4CE; Sun, 6 Jun 2004 08:17:45 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8616143D54; Sun, 6 Jun 2004 08:17:45 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56FHj9F082823; Sun, 6 Jun 2004 15:17:45 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56FHj1p082822; Sun, 6 Jun 2004 15:17:45 GMT (envelope-from bde) Message-Id: <200406061517.i56FHj1p082822@repoman.freebsd.org> From: Bruce Evans Date: Sun, 6 Jun 2004 15:17:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 15:17:45 -0000 bde 2004-06-06 15:17:45 UTC FreeBSD src repository Modified files: sys/i386/isa npx.c Log: Fixed misclassification of npx interrupts caused by npx_probe(). Dividing by 0 in order to check for irq13/exception16 delivery apparently always causes an irq13 even if we have configured for exception16 (by setting CR0_NE). This was expected, but the timing of the irq13 was unexpected. Without CR0_NE, the irq13 is delivered synchronously at least on my test machine, but with CR0_NE it is delivered a little later (about 250 nsec) in PIC mode and much later (5000-10000 nsec) in APIC mode. So especially in APIC mode, the irq13 may arrive after it is supposed to be shut down. It should then be masked, but the shutdown is incomplete, so the irq goes to a null handler that just reports it as stray. The fix is to wait a bit after dividing by 0 to give a good chance of the irq13 being handled by its proper handler. Removed the hack that was supposed to recover from the incomplete shutdown of irq13. The shutdown is now even more incomplete, or perhaps just incomplete in a different way, but the hack now has no effect because irq13 is edge triggered and handling of edge triggered interrupts is now optimized by skipping their masking. The hack only worked due to it accidentally not losing races. The incomplete shutdown of irq13 still allows unprivileged users to generate a stray irq13 (except on systems where irq13 is actually used) by unmasking an npx exception and causing one. The exception gets handled properly by the exception 16 handler. A spurious irq13 is delivered asynchronously but is harmless (as in the probe) because it is almost perfectly not handled by the null interrupt handler. Perfectly not handling it involves mainly not resetting the npx busy latch. This prevents further irq13's despite them not being masked in the [A]PIC. Revision Changes Path 1.149 +1 -12 src/sys/i386/isa/npx.c From owner-cvs-src@FreeBSD.ORG Sun Jun 6 09:01:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 01E5616A4CF; Sun, 6 Jun 2004 09:01:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1EB843D45; Sun, 6 Jun 2004 09:01:42 -0700 (PDT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56G1aqC091107; Sun, 6 Jun 2004 16:01:36 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56G1a5k091106; Sun, 6 Jun 2004 16:01:36 GMT (envelope-from cognet) Message-Id: <200406061601.i56G1a5k091106@repoman.freebsd.org> From: Olivier Houchard Date: Sun, 6 Jun 2004 16:01:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/crunch/crunchide exec_elf32.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 16:01:43 -0000 cognet 2004-06-06 16:01:36 UTC FreeBSD src repository Modified files: usr.sbin/crunch/crunchide exec_elf32.c Log: Tell crunchide to deal with arm elf binaries as well. Rescue can now be built for arm. Revision Changes Path 1.14 +4 -0 src/usr.sbin/crunch/crunchide/exec_elf32.c From owner-cvs-src@FreeBSD.ORG Sun Jun 6 10:27:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF02E16A4CE; Sun, 6 Jun 2004 10:27:11 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8F8D43D41; Sun, 6 Jun 2004 10:27:11 -0700 (PDT) (envelope-from gshapiro@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56HRBWh018337; Sun, 6 Jun 2004 17:27:11 GMT (envelope-from gshapiro@repoman.freebsd.org) Received: (from gshapiro@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56HRBuJ018336; Sun, 6 Jun 2004 17:27:11 GMT (envelope-from gshapiro) Message-Id: <200406061727.i56HRBuJ018336@repoman.freebsd.org> From: Gregory Neil Shapiro Date: Sun, 6 Jun 2004 17:27:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/lib/libmilter Makefile src/lib/libsm Makefile src/usr.sbin/sendmail Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 17:27:12 -0000 gshapiro 2004-06-06 17:27:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) lib/libmilter Makefile lib/libsm Makefile usr.sbin/sendmail Makefile Log: MFC: Honor NOINET6 and disable IPv6 support in libmilter and sendmail if it is set. Revision Changes Path 1.4 +5 -1 src/lib/libmilter/Makefile 1.4 +5 -1 src/lib/libsm/Makefile 1.44 +5 -1 src/usr.sbin/sendmail/Makefile Revision Changes Path 1.1.2.3 +5 -1 src/lib/libmilter/Makefile 1.1.2.3 +5 -1 src/lib/libsm/Makefile 1.15.2.14 +5 -1 src/usr.sbin/sendmail/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jun 6 10:28:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAC8916A4CE; Sun, 6 Jun 2004 10:28:35 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDA4C43D2F; Sun, 6 Jun 2004 10:28:35 -0700 (PDT) (envelope-from gshapiro@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56HSW0q018425; Sun, 6 Jun 2004 17:28:32 GMT (envelope-from gshapiro@repoman.freebsd.org) Received: (from gshapiro@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56HSWGp018424; Sun, 6 Jun 2004 17:28:32 GMT (envelope-from gshapiro) Message-Id: <200406061728.i56HSWGp018424@repoman.freebsd.org> From: Gregory Neil Shapiro Date: Sun, 6 Jun 2004 17:28:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/mail Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 17:28:36 -0000 gshapiro 2004-06-06 17:28:32 UTC FreeBSD src repository Modified files: etc/mail Makefile Log: Remove trailing space. Submitted by: jens Revision Changes Path 1.36 +1 -1 src/etc/mail/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jun 6 10:29:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E724616A4CE; Sun, 6 Jun 2004 10:29:48 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB07343D54; Sun, 6 Jun 2004 10:29:48 -0700 (PDT) (envelope-from gshapiro@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56HTm0E018503; Sun, 6 Jun 2004 17:29:48 GMT (envelope-from gshapiro@repoman.freebsd.org) Received: (from gshapiro@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56HTmIU018502; Sun, 6 Jun 2004 17:29:48 GMT (envelope-from gshapiro) Message-Id: <200406061729.i56HTmIU018502@repoman.freebsd.org> From: Gregory Neil Shapiro Date: Sun, 6 Jun 2004 17:29:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/etc/mail Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 17:29:49 -0000 gshapiro 2004-06-06 17:29:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) etc/mail Makefile Log: MFC: Remove trailing space. Revision Changes Path 1.36 +1 -1 src/etc/mail/Makefile Revision Changes Path 1.9.2.26 +1 -1 src/etc/mail/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jun 6 10:49:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B337A16A4CE; Sun, 6 Jun 2004 10:49:57 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97A3343D31; Sun, 6 Jun 2004 10:49:57 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56HnvRw022725; Sun, 6 Jun 2004 17:49:57 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56HnvW6022724; Sun, 6 Jun 2004 17:49:57 GMT (envelope-from ru) Message-Id: <200406061749.i56HnvW6022724@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 6 Jun 2004 17:49:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/acpi/acpidb acpidb.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 17:49:57 -0000 ru 2004-06-06 17:49:57 UTC FreeBSD src repository Modified files: usr.sbin/acpi/acpidb acpidb.8 Log: Tidy up markup. Revision Changes Path 1.2 +24 -19 src/usr.sbin/acpi/acpidb/acpidb.8 From owner-cvs-src@FreeBSD.ORG Sun Jun 6 10:55:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A31E16A4CE; Sun, 6 Jun 2004 10:55:56 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B8EB43D1F; Sun, 6 Jun 2004 10:55:56 -0700 (PDT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56HttAe024731; Sun, 6 Jun 2004 17:55:55 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56HttxO024730; Sun, 6 Jun 2004 17:55:55 GMT (envelope-from mtm) Message-Id: <200406061755.i56HttxO024730@repoman.freebsd.org> From: Mike Makonnen Date: Sun, 6 Jun 2004 17:55:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/adduser adduser.8 adduser.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 17:55:56 -0000 mtm 2004-06-06 17:55:55 UTC FreeBSD src repository Modified files: usr.sbin/adduser adduser.8 adduser.sh Log: Accept full path names in addition to base names for shells. Make explicit in the documentation that valid shells need to be supplied only if the -S option is not given. Revision Changes Path 1.55 +11 -8 src/usr.sbin/adduser/adduser.8 1.23 +5 -3 src/usr.sbin/adduser/adduser.sh From owner-cvs-src@FreeBSD.ORG Sun Jun 6 11:06:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1F9E16A4CE; Sun, 6 Jun 2004 11:06:15 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4C9543D41; Sun, 6 Jun 2004 11:06:15 -0700 (PDT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56I69Gf027800; Sun, 6 Jun 2004 18:06:09 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56I69LO027799; Sun, 6 Jun 2004 18:06:09 GMT (envelope-from mtm) Message-Id: <200406061806.i56I69LO027799@repoman.freebsd.org> From: Mike Makonnen Date: Sun, 6 Jun 2004 18:06:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc rc rc.subr X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 18:06:15 -0000 mtm 2004-06-06 18:06:09 UTC FreeBSD src repository Modified files: etc rc rc.subr Log: Restore pre-rcNG behaviour: SIGINT (Ctrl-c) kills the current script SIGQUIT (Ctrl-\) kills /etc/rc (dropping you into single-user) Prodded by: harti Revision Changes Path 1.332 +2 -2 src/etc/rc 1.27 +2 -3 src/etc/rc.subr From owner-cvs-src@FreeBSD.ORG Sun Jun 6 12:47:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBFCD16A4CE; Sun, 6 Jun 2004 12:47:58 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE7C943D31; Sun, 6 Jun 2004 12:47:58 -0700 (PDT) (envelope-from archie@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56Jlwho049134; Sun, 6 Jun 2004 19:47:58 GMT (envelope-from archie@repoman.freebsd.org) Received: (from archie@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56JlwJS049133; Sun, 6 Jun 2004 19:47:58 GMT (envelope-from archie) Message-Id: <200406061947.i56JlwJS049133@repoman.freebsd.org> From: Archie Cobbs Date: Sun, 6 Jun 2004 19:47:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/netgraph ng_ether.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 19:47:59 -0000 archie 2004-06-06 19:47:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/netgraph ng_ether.c Log: The previous checkin (MFC: Allow "lower" and "orphans" hooks to be connected at the same time) was incomplete and broke things. This patch fixes that. Revision Changes Path 1.2.2.16 +6 -6 src/sys/netgraph/ng_ether.c From owner-cvs-src@FreeBSD.ORG Sun Jun 6 12:59:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 017B616A4CE; Sun, 6 Jun 2004 12:59:11 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D935143D53; Sun, 6 Jun 2004 12:59:10 -0700 (PDT) (envelope-from green@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56Jx6Wp051564; Sun, 6 Jun 2004 19:59:06 GMT (envelope-from green@repoman.freebsd.org) Received: (from green@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56Jx6GF051563; Sun, 6 Jun 2004 19:59:06 GMT (envelope-from green) Message-Id: <200406061959.i56Jx6GF051563@repoman.freebsd.org> From: Brian Feldman Date: Sun, 6 Jun 2004 19:59:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/top machine.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 19:59:11 -0000 green 2004-06-06 19:59:06 UTC FreeBSD src repository Modified files: usr.bin/top machine.c Log: Do not use KERN_PROC_PROC with kvm_getproc(3); instead, if only process (and not thread) scope is to be displayed, use KERN_PROC_ALL and accrue CPU% ourselves, as the kernel makes no attempt to do so. Of course, this doesn't make most stats any less bogus when displaying threaded processes, but at least the CPU time is added up and not just always 0.00%. There are still issues with SCHED_ULE in top(1) that cause other processes to display 0.00% CPU when they in fact have used more. Revision Changes Path 1.51 +17 -4 src/usr.bin/top/machine.c From owner-cvs-src@FreeBSD.ORG Sun Jun 6 14:26:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2084316A4CE; Sun, 6 Jun 2004 14:26:50 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A50F43D2F; Sun, 6 Jun 2004 14:26:50 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i56LQn2a077696; Sun, 6 Jun 2004 21:26:49 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i56LQnYo077695; Sun, 6 Jun 2004 21:26:49 GMT (envelope-from phk) Message-Id: <200406062126.i56LQnYo077695@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 6 Jun 2004 21:26:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha support.s src/sys/arm/arm exception.S in_cksum_arm.S locore.S src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sparc64/include asmacros.h src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 21:26:50 -0000 phk 2004-06-06 21:26:49 UTC FreeBSD src repository Modified files: sys/alpha/alpha support.s sys/arm/arm exception.S in_cksum_arm.S locore.S sys/i386/i386 swtch.s sys/kern kern_shutdown.c sys/sparc64/include asmacros.h sys/sys systm.h Log: Remove filename+line number from panic messages. Revision Changes Path 1.17 +2 -4 src/sys/alpha/alpha/support.s 1.2 +3 -16 src/sys/arm/arm/exception.S 1.2 +1 -5 src/sys/arm/arm/in_cksum_arm.S 1.2 +1 -5 src/sys/arm/arm/locore.S 1.146 +3 -9 src/sys/i386/i386/swtch.s 1.150 +3 -3 src/sys/kern/kern_shutdown.c 1.19 +2 -4 src/sys/sparc64/include/asmacros.h 1.206 +2 -4 src/sys/sys/systm.h From owner-cvs-src@FreeBSD.ORG Mon Jun 7 01:44:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23C3216A4D5; Mon, 7 Jun 2004 01:44:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97DC143F0E; Sun, 6 Jun 2004 18:21:30 -0700 (PDT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i571LUVd035529; Mon, 7 Jun 2004 01:21:30 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i571LUfY035528; Mon, 7 Jun 2004 01:21:30 GMT (envelope-from gad) Message-Id: <200406070121.i571LUfY035528@repoman.freebsd.org> From: Garance A Drosehn Date: Mon, 7 Jun 2004 01:21:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 01:44:15 -0000 gad 2004-06-07 01:21:30 UTC FreeBSD src repository Modified files: usr.sbin/newsyslog newsyslog.c Log: A variety of minor changes. Allow users to set a debugging option via the newsyslog.conf file. Rename one size-related variable, and move another one from the stack into conf_entry. Add a routine to change file-attributes (chown, chmod, chflags), instead of having several places doing the same sequence of system-calls. A few cosmetic/style changes. These should not effect any users. Most of these probably look pointless, but they are the "insignificant parts" of a much larger update that I'll be committing soon. Doing these as a separate update should make that update easier to read. MFC after: 14 days Revision Changes Path 1.89 +120 -67 src/usr.sbin/newsyslog/newsyslog.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 01:44:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9633516A508; Mon, 7 Jun 2004 01:44:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E816D43F29; Sun, 6 Jun 2004 18:23:10 -0700 (PDT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i571MnDR036450; Mon, 7 Jun 2004 01:22:49 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i571MmRG036449; Mon, 7 Jun 2004 01:22:48 GMT (envelope-from wpaul) Message-Id: <200406070122.i571MmRG036449@repoman.freebsd.org> From: Bill Paul Date: Mon, 7 Jun 2004 01:22:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/compat/ndis kern_ndis.c subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 01:44:17 -0000 wpaul 2004-06-07 01:22:48 UTC FreeBSD src repository Modified files: sys/compat/ndis kern_ndis.c subr_ntoskrnl.c Log: Add another 5.2.1 source compatibility tweak: acquire Giant before calling kthread_exit() if FreeBSD_version is old enough. Revision Changes Path 1.56 +3 -0 src/sys/compat/ndis/kern_ndis.c 1.38 +3 -0 src/sys/compat/ndis/subr_ntoskrnl.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 02:10:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 262EB16A4CE; Mon, 7 Jun 2004 02:10:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F80143D48; Sun, 6 Jun 2004 19:10:11 -0700 (PDT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i572AAds045727; Mon, 7 Jun 2004 02:10:10 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i572AAP1045726; Mon, 7 Jun 2004 02:10:10 GMT (envelope-from gad) Message-Id: <200406070210.i572AAP1045726@repoman.freebsd.org> From: Garance A Drosehn Date: Mon, 7 Jun 2004 02:10:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 02:10:11 -0000 gad 2004-06-07 02:10:10 UTC FreeBSD src repository Modified files: usr.sbin/newsyslog newsyslog.c Log: Major re-ordering of the steps that newsyslog will use when processing files to rotate. The new order will first rotate all files that need to be rotated, and then send a single signal to each process which needs to be signaled, and finally it will compress all the files which were rotated. This means daemons will be signaled once per run of newsyslog, instead of once per file rotated. Also, files will be compressed in order of file-size (smallest to largest). Also, it waits for each file to be completely compressed before starting the next one (effectively as if the 'w' flag is specified for all entries in newsyslog.conf). This avoids the situation of having 10 gzip's going at the same time (each with a log.0 and a log.0.gz file active), and it also means that file attributes can be reliably set on files after they are compressed. NOTE: This commit does define NEWORDER (which you could get rid of if you really don't trust this), but it does not flip the "-D neworder" switch. So, at the moment none of these changes happen unless you request them (perhaps by adding ' neworder' in newsyslog.conf). PR: bin/25070 inspired some parts of this Submitted by: parts from bin/25070 done by Helge Oldach MFC after: 14 days Revision Changes Path 1.90 +425 -0 src/usr.sbin/newsyslog/newsyslog.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 02:26:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2AEA16A4CE; Mon, 7 Jun 2004 02:26:09 +0000 (GMT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 44A2743D39; Sun, 6 Jun 2004 19:26:09 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.12.8/8.12.8) with ESMTP id i572PlIX008069; Sun, 6 Jun 2004 22:25:47 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200406070210.i572AAP1045726@repoman.freebsd.org> References: <200406070210.i572AAP1045726@repoman.freebsd.org> Date: Sun, 6 Jun 2004 22:25:46 -0400 To: Garance A Drosehn , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) Subject: Re: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 02:26:09 -0000 At 2:10 AM +0000 6/7/04, Garance A Drosehn wrote: > NOTE: > This commit does define NEWORDER (which you could get rid of if > you really don't trust this), but it does not flip the "-D neworder" > switch. So, at the moment none of these changes happen unless you > request them (perhaps by adding ' neworder' in newsyslog.conf). I have been running with this "neworder" code for a few days, and it seems to be doing all the right things for me. I've also tested various other configurations, so I am "cautiously optimistic" that it should work right for everyone. But it is a pretty major change, so I wanted to ease it into place and provide people an easy way of dropping back to the previous behavior if they suspect something wrong with it. I also have a testing-script which is what I have crontab execute instead of running newsyslog directly, and that goes through a bunch of extra work such that I can compare the results of "oldorder" vs "neworder" for every run of newsyslog on my system. It results in a lot of extra work, of course, but I can make that script available if someone else wants to do extensive comparisons of the "neworder" vs the "oldorder". -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Mon Jun 7 02:57:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EEFC16A4CE; Mon, 7 Jun 2004 02:57:21 +0000 (GMT) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4D0243D55; Sun, 6 Jun 2004 19:57:20 -0700 (PDT) (envelope-from tim@kientzle.com) Received: from kientzle.com (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id i572vJ90064456; Sun, 6 Jun 2004 19:57:20 -0700 (PDT) (envelope-from tim@kientzle.com) Message-ID: <40C3D977.3010900@kientzle.com> Date: Sun, 06 Jun 2004 19:56:55 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bruce Evans References: <20040605053115.45AE416A585@hub.freebsd.org> <20040605000326.B54841@root.org> <40C22518.6060406@kientzle.com> <20040606143616.W2060@gamplex.bde.org> <40C2E401.5010400@freebsd.org> <20040606195023.M3004@gamplex.bde.org> In-Reply-To: <20040606195023.M3004@gamplex.bde.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: Tim Kientzle cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Nate Lawson Subject: Re: cvs commit: src/lib/libarchive archive_read_extract.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 02:57:21 -0000 Bruce Evans wrote: > On Sun, 6 Jun 2004, Tim Kientzle wrote: >>Bruce Evans wrote: >> >>>bsdtar cf z foo: >>> same, except bsdtar seems to be too smart about padding the output >>> to a block boundary for regular files, so subsequent piping of the >>> file might not work >> >>The default padding behavior for bsdtar was changed quite >>a while ago to not pad regular files; are you sure you're up-to-date? > > Yes; not padding is a bug and the above says that I have it. I've discussed padding issues with a number of people, and the following behavior seems acceptable to most. If you have reasons to disagree, please let me know: $ bsdtar cf z foo && ls -l z -rw-r--r-- 1 tim wheel 1536 Jun 6 17:16 z $ bsdtar cfb z 20 foo && ls -l z -rw-r--r-- 1 tim wheel 10240 Jun 6 17:16 z $ bsdtar cf - foo | cat > z && ls -l z -rw-r--r-- 1 tim wheel 10240 Jun 6 17:17 z That is, archives written to regular files are not padded unless you explicitly specify a block size. Archives written to pipes (or block or char devices) are padded. The same behavior applies to archives compressed via 'z', 'j', or 'y' options, as demonstrated here: $ bsdtar czf z foo && ls -l z -rw-r--r-- 1 tim wheel 126 Jun 6 17:25 z $ bsdtar czfb z 20 foo && ls -l z -rw-r--r-- 1 tim wheel 10240 Jun 6 17:25 z $ bsdtar czf - foo | cat > z && ls -l z -rw-r--r-- 1 tim wheel 10240 Jun 6 17:25 z (I just realized that padding when -b is explicitly specified is broken in -CURRENT; I'll commit the fix for that shortly.) >>>bsdtar cf z foo/: >> >>Here, bsdtar cf z foo/ does follow the symlink, which I >>presume you believe to be the correct behavior? > > Yes. foo/ is not a symlink (the slash forces folling the symlink) in the > kernel, so it should do so in utilities too. Good, then you agree that bsdtar does the right thing in this example. Tim From owner-cvs-src@FreeBSD.ORG Mon Jun 7 03:16:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 45CDD16A4CE; Mon, 7 Jun 2004 03:16:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2822F43D39; Sun, 6 Jun 2004 20:16:19 -0700 (PDT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i573GIid060920; Mon, 7 Jun 2004 03:16:18 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i573GIFm060919; Mon, 7 Jun 2004 03:16:18 GMT (envelope-from kientzle) Message-Id: <200406070316.i573GIFm060919@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 03:16:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar read.c write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 03:16:19 -0000 kientzle 2004-06-07 03:16:18 UTC FreeBSD src repository Modified files: usr.bin/tar read.c write.c Log: Per style(9), don't use double spaces in expressions. Pointed out by: njl, des. Revision Changes Path 1.9 +1 -1 src/usr.bin/tar/read.c 1.19 +2 -2 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 03:19:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A0AF16A4CE; Mon, 7 Jun 2004 03:19:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BCB943D49; Sun, 6 Jun 2004 20:19:58 -0700 (PDT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i573Jw7J061012; Mon, 7 Jun 2004 03:19:58 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i573Jwvk061011; Mon, 7 Jun 2004 03:19:58 GMT (envelope-from kientzle) Message-Id: <200406070319.i573Jwvk061011@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 03:19:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h read.c write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 03:19:58 -0000 kientzle 2004-06-07 03:19:58 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar.c bsdtar.h read.c write.c Log: If -b is specified, then force full padding for the last block. Revision Changes Path 1.22 +0 -2 src/usr.bin/tar/bsdtar.c 1.11 +2 -0 src/usr.bin/tar/bsdtar.h 1.10 +3 -1 src/usr.bin/tar/read.c 1.20 +25 -3 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 03:38:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0CA816A4CE; Mon, 7 Jun 2004 03:38:17 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9382143D55; Sun, 6 Jun 2004 20:38:17 -0700 (PDT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i573cH9W065015; Mon, 7 Jun 2004 03:38:17 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i573cHI3065014; Mon, 7 Jun 2004 03:38:17 GMT (envelope-from kientzle) Message-Id: <200406070338.i573cHI3065014@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 03:38:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 03:38:17 -0000 kientzle 2004-06-07 03:38:17 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Ooops! Previous commit added an over-zealous error check. It is, in fact, perfectly legal to not specify a compression when writing an archive. Revision Changes Path 1.21 +2 -0 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 03:49:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D07216A4CE; Mon, 7 Jun 2004 03:49:49 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3DD4143D49; Sun, 6 Jun 2004 20:49:49 -0700 (PDT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i573nnG0067114; Mon, 7 Jun 2004 03:49:49 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i573nmiA067113; Mon, 7 Jun 2004 03:49:48 GMT (envelope-from kientzle) Message-Id: <200406070349.i573nmiA067113@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 03:49:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar bsdtar.1 bsdtar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 03:49:49 -0000 kientzle 2004-06-07 03:49:48 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar.1 bsdtar.c Log: The --include='pattern' option is the natural counterpart to --exclude='pattern'. I should have added this a long time ago, since it's so useful for testing. In particular, it allows me to select a few entries from a troublesome archive so that I can easily focus my debugging efforts: bsdtar -czf new.tgz --include='*foo*' @old.tgz Revision Changes Path 1.9 +18 -0 src/usr.bin/tar/bsdtar.1 1.23 +7 -0 src/usr.bin/tar/bsdtar.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 04:10:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22DD216A4CE; Mon, 7 Jun 2004 04:10:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0515943D48; Sun, 6 Jun 2004 21:10:44 -0700 (PDT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i574Ahus072215; Mon, 7 Jun 2004 04:10:43 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i574Ah23072214; Mon, 7 Jun 2004 04:10:43 GMT (envelope-from kientzle) Message-Id: <200406070410.i574Ah23072214@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 04:10:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar read.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 04:10:44 -0000 kientzle 2004-06-07 04:10:43 UTC FreeBSD src repository Modified files: usr.bin/tar read.c Log: Fix the symlink-detection code. Don't squawk if we're just replacing an existing symlink (as might happen if you extract an archive twice). Also, if we remove the offending link, then we've removed the problem and can safely go forward with the extraction. Pointed out by: print/adobe-cmaps port (whose distfile has duplicate entries for the same symlinks) Thanks to: Kris Kennaway (for using ports as a testbed for bsdtar) Revision Changes Path 1.11 +22 -6 src/usr.bin/tar/read.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 04:32:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB18A16A4E2; Mon, 7 Jun 2004 04:32:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE08943D45; Mon, 7 Jun 2004 04:32:15 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i574WAc5077695; Mon, 7 Jun 2004 04:32:10 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i574WAOR077691; Mon, 7 Jun 2004 04:32:10 GMT (envelope-from kientzle) Message-Id: <200406070432.i574WAOR077691@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 04:32:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_read_support_format_tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 04:32:16 -0000 kientzle 2004-06-07 04:32:10 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_format_tar.c Log: Tar bidder should just return a zero bid ("not me!") if it sees a truncated input the first time it gets called. (In particular, files shorter than 512 bytes cannot be tar archives.) This allows the top-level archive_read_next_header code to generate a proper error message for unrecognized file types. Pointed out by: numerous ports that expect tar to extract non-tar files ;-( Thanks to: Kris Kennaway Revision Changes Path 1.18 +9 -3 src/lib/libarchive/archive_read_support_format_tar.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 05:48:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E35416A4CE; Mon, 7 Jun 2004 05:48:26 +0000 (GMT) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99D0443D5A; Mon, 7 Jun 2004 05:48:25 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87])i575mO4u007927; Mon, 7 Jun 2004 15:48:24 +1000 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i575mLLS031413; Mon, 7 Jun 2004 15:48:22 +1000 Date: Mon, 7 Jun 2004 15:48:20 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Tim Kientzle In-Reply-To: <40C3D977.3010900@kientzle.com> Message-ID: <20040607150924.L11542@gamplex.bde.org> References: <20040605053115.45AE416A585@hub.freebsd.org> <20040605000326.B54841@root.org> <20040606143616.W2060@gamplex.bde.org> <40C2E401.5010400@freebsd.org> <20040606195023.M3004@gamplex.bde.org> <40C3D977.3010900@kientzle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: Tim Kientzle cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Nate Lawson Subject: Re: cvs commit: src/lib/libarchive archive_read_extract.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 05:48:26 -0000 On Sun, 6 Jun 2004, Tim Kientzle wrote: > Bruce Evans wrote: > > On Sun, 6 Jun 2004, Tim Kientzle wrote: > >>The default padding behavior for bsdtar was changed quite > >>a while ago to not pad regular files; are you sure you're up-to-date? > > > > Yes; not padding is a bug and the above says that I have it. > > I've discussed padding issues with a number of people, and > the following behavior seems acceptable to most. If you have > reasons to disagree, please let me know: > ... > That is, archives written to regular files are not > padded unless you explicitly specify a block size. > ... > (I just realized that padding when -b is explicitly > specified is broken in -CURRENT; I'll commit the > fix for that shortly.) I only really care about this case. Different behaviour for regular files in the default case is just surprising. > >>>bsdtar cf z foo/: > >> > >>Here, bsdtar cf z foo/ does follow the symlink, which I > >>presume you believe to be the correct behavior? > > > > Yes. foo/ is not a symlink (the slash forces folling the symlink) in the > > kernel, so it should do so in utilities too. > > Good, then you agree that bsdtar does the right thing > in this example. The behaviour actually seems to be semi-random. When I first tried it yesterday. bsdtar followed the symlink. It stopped following the symlink before I wrote the mail. Today with up to date libachive and tar, it started with not following the symlink, then switched to following it after I tried putting the symlink in a diferent directory (/var/tmp/foo ->/tmp instead of /tmp/foo ->/tmp) and then moved back to it being in /tmp. Of course, I can't get it to fail again. I remember one sign of the problem in truss output: when bsdtar didn't follow the symlink, it exited soon after __acl_mumble() returned ELOOP (it was silent about this error and exited with status 0). The file system doesn't have acls, and all the acl calls return EOPNOTSUPP when bsdtar works correctly. Bruce From owner-cvs-src@FreeBSD.ORG Mon Jun 7 06:00:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFB0416A4D0; Mon, 7 Jun 2004 06:00:24 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3F9843D45; Mon, 7 Jun 2004 06:00:24 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i5760EiQ005761; Sun, 6 Jun 2004 23:00:14 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i5760ENn005760; Sun, 6 Jun 2004 23:00:14 -0700 (PDT) (envelope-from obrien) Date: Sun, 6 Jun 2004 23:00:13 -0700 From: "David O'Brien" To: Poul-Henning Kamp Message-ID: <20040607060013.GA5554@dragon.nuxi.com> References: <200406032236.i53MaOj5046199@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406032236.i53MaOj5046199@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include/pc bios.h src/sys/i386/i386 bios.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 06:00:25 -0000 On Thu, Jun 03, 2004 at 03:36:24PM -0700, Poul-Henning Kamp wrote: > phk 2004/06/03 15:36:24 PDT > > FreeBSD src repository > > Modified files: > sys/i386/include/pc bios.h > sys/i386/i386 bios.c > Log: > Add new bios_string() which will hunt for a string inside a given range > of the BIOS. This can be used for finding arbitrary magic in the BIOS > in order to recognize particular platforms. It seems that this function (and many others in sys/i386/i386/bios.c) should go into a common MI file as they are directly usable on AMD64 also. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Jun 7 06:04:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9D9616A4CE; Mon, 7 Jun 2004 06:04:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC5FE43D5C; Mon, 7 Jun 2004 06:04:27 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5764R86004193; Mon, 7 Jun 2004 06:04:27 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5764RqB004192; Mon, 7 Jun 2004 06:04:27 GMT (envelope-from phk) Message-Id: <200406070604.i5764RqB004192@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 7 Jun 2004 06:04:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pc98/pc98 clock.c mse.c olpt.c pc98gdc.c ppc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 06:04:28 -0000 phk 2004-06-07 06:04:27 UTC FreeBSD src repository Modified files: sys/pc98/pc98 clock.c mse.c olpt.c pc98gdc.c ppc.c Log: Add missing includes. Revision Changes Path 1.138 +1 -0 src/sys/pc98/pc98/clock.c 1.45 +1 -0 src/sys/pc98/pc98/mse.c 1.25 +1 -0 src/sys/pc98/pc98/olpt.c 1.41 +1 -0 src/sys/pc98/pc98/pc98gdc.c 1.17 +1 -0 src/sys/pc98/pc98/ppc.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 06:35:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E1E316A4CE; Mon, 7 Jun 2004 06:35:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 589DA43D31; Mon, 7 Jun 2004 06:35:02 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i576Ypn4010262; Mon, 7 Jun 2004 06:34:51 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i576YpDU010261; Mon, 7 Jun 2004 06:34:51 GMT (envelope-from kientzle) Message-Id: <200406070634.i576YpDU010261@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 06:34:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_read_support_format_tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 06:35:02 -0000 kientzle 2004-06-07 06:34:51 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_format_tar.c Log: History: A few very, very old tar programs used the filename to distinguish files from dirs (trailing '/' indicated a dir). Since POSIX.1-1987, this convention is no longer necessary. However, there are current tar programs that pretend to write POSIX-compliant archives, yet store directories as "regular files", relying on this old filename convention to save them. So, move the check for this old convention so it applies to all tar archives, not just those identified as "old." Pointed out by: Broken distfile for audio/faad port Revision Changes Path 1.19 +10 -12 src/lib/libarchive/archive_read_support_format_tar.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 07:11:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65F7F16A4CE; Mon, 7 Jun 2004 07:11:34 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 391B343D53; Mon, 7 Jun 2004 07:11:34 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i577BXIp008063; Mon, 7 Jun 2004 00:11:33 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i577BXdp008062; Mon, 7 Jun 2004 00:11:33 -0700 (PDT) (envelope-from obrien) Date: Mon, 7 Jun 2004 00:11:33 -0700 From: "David O'Brien" To: Olivier Houchard Message-ID: <20040607071133.GA8013@dragon.nuxi.com> References: <200405092229.i49MT0pN065683@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200405092229.i49MT0pN065683@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/config config.h config.y configvers.h lang.l main.c mkmakefile.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 07:11:34 -0000 On Sun, May 09, 2004 at 03:29:00PM -0700, Olivier Houchard wrote: > cognet 2004/05/09 15:29:00 PDT > > FreeBSD src repository > > Modified files: > usr.sbin/config config.h config.y configvers.h lang.l > main.c mkmakefile.c > Log: > Add a new "files" directive, which allows to include a files.foo file directly > from a kernel config file. > Bump config version to reflect this change. Please document this in config(8). It isn't at all clear to me from the commit log why/what uses this for. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Jun 7 07:19:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C3BB16A4CE; Mon, 7 Jun 2004 07:19:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F98743D45; Mon, 7 Jun 2004 07:19:05 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i577J5Eo019507; Mon, 7 Jun 2004 07:19:05 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i577J4SJ019506; Mon, 7 Jun 2004 07:19:04 GMT (envelope-from kientzle) Message-Id: <200406070719.i577J4SJ019506@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 07:19:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 07:19:05 -0000 kientzle 2004-06-07 07:19:04 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Set program exit value to 1 if there are any of various errors when creating an archive. Pointed out by: Failure to complain when building certain broken packages (Thanks again to Kris Kennaway for finding this!) Revision Changes Path 1.22 +4 -0 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 07:25:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6FAFC16A4CE; Mon, 7 Jun 2004 07:25:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 543F543D31; Mon, 7 Jun 2004 07:25:04 +0000 (GMT) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i577P4rd021416; Mon, 7 Jun 2004 07:25:04 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i577P4oL021415; Mon, 7 Jun 2004 07:25:04 GMT (envelope-from julian) Message-Id: <200406070725.i577P4oL021415@repoman.freebsd.org> From: Julian Elischer Date: Mon, 7 Jun 2004 07:25:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 07:25:04 -0000 julian 2004-06-07 07:25:03 UTC FreeBSD src repository Modified files: sys/kern kern_kse.c Log: Move the KSE ABI specific code here and separate it from code that is generic to any threading system. This commit does not link this file to the build yet, nor does it remove these functions from their current location in kern_thread.c. (that commit coming up after further review) Revision Changes Path 1.179 +19 -977 src/sys/kern/kern_kse.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 07:26:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A99E16A4CE; Mon, 7 Jun 2004 07:26:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D80F43D39; Mon, 7 Jun 2004 07:26:53 +0000 (GMT) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i577Qr06021550; Mon, 7 Jun 2004 07:26:53 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i577QrVW021549; Mon, 7 Jun 2004 07:26:53 GMT (envelope-from julian) Message-Id: <200406070726.i577QrVW021549@repoman.freebsd.org> From: Julian Elischer Date: Mon, 7 Jun 2004 07:26:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 07:26:53 -0000 julian 2004-06-07 07:26:53 UTC FreeBSD src repository Modified files: sys/kern kern_kse.c Log: Forced commit to note that this file was repo duplicated from kern_thread.c in order to keep history availabel for both files. Revision Changes Path 1.180 +0 -0 src/sys/kern/kern_kse.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 08:05:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5D3116A4CE; Mon, 7 Jun 2004 08:05:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B17A643D55; Mon, 7 Jun 2004 08:05:38 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5785avg030805; Mon, 7 Jun 2004 08:05:36 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5785aCV030804; Mon, 7 Jun 2004 08:05:36 GMT (envelope-from das) Message-Id: <200406070805.i5785aCV030804@repoman.freebsd.org> From: David Schultz Date: Mon, 7 Jun 2004 08:05:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun Makefile src/lib/msun/man round.3 src/lib/msun/src math.h s_round.c s_roundf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 08:05:38 -0000 das 2004-06-07 08:05:36 UTC FreeBSD src repository Modified files: lib/msun Makefile lib/msun/src math.h Added files: lib/msun/man round.3 lib/msun/src s_round.c s_roundf.c Log: Add round(3) and roundf(3) and the associated documentation. PR: 59797 Submitted by: "Steven G. Kargl" Reviewed by: bde (earlier version, last year) Revision Changes Path 1.42 +4 -2 src/lib/msun/Makefile 1.1 +71 -0 src/lib/msun/man/round.3 (new) 1.33 +2 -0 src/lib/msun/src/math.h 1.1 +53 -0 src/lib/msun/src/s_round.c (new) 1.1 +53 -0 src/lib/msun/src/s_roundf.c (new) From owner-cvs-src@FreeBSD.ORG Mon Jun 7 08:19:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E4BB616A4CE; Mon, 7 Jun 2004 08:19:12 +0000 (GMT) Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDF7243D1D; Mon, 7 Jun 2004 08:19:09 +0000 (GMT) (envelope-from tim@robbins.dropbear.id.au) Received: from robbins.dropbear.id.au (210.50.217.171) by smtp01.syd.iprimus.net.au (7.0.024) id 40B7A0DA002B2D4C; Mon, 7 Jun 2004 18:18:50 +1000 Received: by robbins.dropbear.id.au (Postfix, from userid 1000) id EF4C641D0; Mon, 7 Jun 2004 18:20:30 +1000 (EST) Date: Mon, 7 Jun 2004 18:20:30 +1000 From: Tim Robbins To: Julian Elischer Message-ID: <20040607082030.GA38464@cat.robbins.dropbear.id.au> References: <200406070725.i577P4oL021415@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406070725.i577P4oL021415@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 08:19:13 -0000 On Mon, Jun 07, 2004 at 07:25:03AM +0000, Julian Elischer wrote: > julian 2004-06-07 07:25:03 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_kse.c > Log: > Move the KSE ABI specific code here and separate it from code that > is generic to any threading system. This commit does not link this > file to the build yet, nor does it remove these functions from their > current location in kern_thread.c. (that commit coming up after further review) I like what you've done here, but please don't go overboard with the abstraction -- the KSE code is already very hard to follow and overly complex, and we would be kidding ourselves if we thought we could support more than one thread system (I would like to see thr gone before 5.3-STABLE.) Tim From owner-cvs-src@FreeBSD.ORG Mon Jun 7 08:54:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82A9416A4CE; Mon, 7 Jun 2004 08:54:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6814943D49; Mon, 7 Jun 2004 08:54:24 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i578sOPj046841; Mon, 7 Jun 2004 08:54:24 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i578sNUc046840; Mon, 7 Jun 2004 08:54:24 GMT (envelope-from ume) Message-Id: <200406070854.i578sNUc046840@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Mon, 7 Jun 2004 08:54:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/netinet6 ip6_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 08:54:24 -0000 ume 2004-06-07 08:54:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/netinet6 ip6_input.c Log: MFC 1.73: do not check super user privilege in ip6_savecontrol. It is meaningless and can even be harmful. Revision Changes Path 1.11.2.16 +6 -19 src/sys/netinet6/ip6_input.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 09:16:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F155216A4D0; Mon, 7 Jun 2004 09:16:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D194543D1D; Mon, 7 Jun 2004 09:16:19 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i579GJAl052074; Mon, 7 Jun 2004 09:16:19 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i579GJLe052073; Mon, 7 Jun 2004 09:16:19 GMT (envelope-from obrien) Message-Id: <200406070916.i579GJLe052073@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 7 Jun 2004 09:16:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d preseedrandom X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 09:16:20 -0000 obrien 2004-06-07 09:16:19 UTC FreeBSD src repository Modified files: etc/rc.d preseedrandom Log: Don't assume everyone's /etc/[default/]rc.conf 'entropy_file' is "/entropy". Revision Changes Path 1.3 +1 -1 src/etc/rc.d/preseedrandom From owner-cvs-src@FreeBSD.ORG Mon Jun 7 09:35:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F381216A4CE; Mon, 7 Jun 2004 09:35:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D873B43D46; Mon, 7 Jun 2004 09:35:13 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i579Z1vn055988; Mon, 7 Jun 2004 09:35:01 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i579Z1P5055987; Mon, 7 Jun 2004 09:35:01 GMT (envelope-from tjr) Message-Id: <200406070935.i579Z1P5055987@repoman.freebsd.org> From: "Tim J. Robbins" Date: Mon, 7 Jun 2004 09:35:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_synch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 09:35:14 -0000 tjr 2004-06-07 09:35:01 UTC FreeBSD src repository Modified files: sys/kern kern_synch.c Log: Remove a stale and misleading comment. Revision Changes Path 1.249 +0 -7 src/sys/kern/kern_synch.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 09:43:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57ECB16A4CE; Mon, 7 Jun 2004 09:43:30 +0000 (GMT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 3E81743D53; Mon, 7 Jun 2004 09:43:29 +0000 (GMT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 7 Jun 2004 10:43:21 +0100 (BST) Date: Mon, 7 Jun 2004 10:43:21 +0100 From: David Malone To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20040607094321.GA32159@walton.maths.tcd.ie> References: <200406060916.i569G2m2097113@repoman.freebsd.org> <20040606091758.GA6354@VARK.homeunix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040606091758.GA6354@VARK.homeunix.com> User-Agent: Mutt/1.5.3i Sender: dwmalone@maths.tcd.ie Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 09:43:30 -0000 On Sun, Jun 06, 2004 at 02:17:58AM -0700, David Schultz wrote: > It would be great if someone could pick this up and devise the > appropriate fix. I want to see this bug fixed, but I don't have the > hardware to do amd64 kernel hacking. I'm happy to help anyone who is > interested. I think I've figured out the problem. On SMP systems, fpuinit() is called before enable_sse() for secondary processors. The ldmxcsr instruction counts as a sse instruction, so you get an illegal instruction fault. The patch below switches the order of fpuinit() and enable_sse() and fixes the problem on my system anyway. David. Index: mp_machdep.c =================================================================== RCS file: /cvs/FreeBSD-CVS/src/sys/amd64/amd64/mp_machdep.c,v retrieving revision 1.237 diff -u -r1.237 mp_machdep.c --- mp_machdep.c 16 May 2004 22:11:50 -0000 1.237 +++ mp_machdep.c 7 Jun 2004 09:36:08 -0000 @@ -429,12 +429,12 @@ /* set up CPU registers and state */ cpu_setregs(); - /* set up FPU state on the AP */ - fpuinit(); - /* set up SSE registers */ enable_sse(); + /* set up FPU state on the AP */ + fpuinit(); + /* A quick check from sanity claus */ if (PCPU_GET(apic_id) != lapic_id()) { printf("SMP: cpuid = %d\n", PCPU_GET(cpuid)); From owner-cvs-src@FreeBSD.ORG Mon Jun 7 09:57:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9FB5016A4CE; Mon, 7 Jun 2004 09:57:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8597B43D48; Mon, 7 Jun 2004 09:57:10 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i579v0t4060148; Mon, 7 Jun 2004 09:57:00 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i579ux51060147; Mon, 7 Jun 2004 09:57:00 GMT (envelope-from ume) Message-Id: <200406070957.i579ux51060147@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Mon, 7 Jun 2004 09:56:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_icmp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 09:57:10 -0000 ume 2004-06-07 09:56:59 UTC FreeBSD src repository Modified files: sys/netinet ip_icmp.c Log: do not send icmp response if the original packet is encrypted. Obtained from: KAME MFC after: 1 week Revision Changes Path 1.93 +3 -0 src/sys/netinet/ip_icmp.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 09:58:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DD3516A4CE; Mon, 7 Jun 2004 09:58:26 +0000 (GMT) Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4616243D48; Mon, 7 Jun 2004 09:58:23 +0000 (GMT) (envelope-from mark@grondar.org) Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1]) i579wH2k043659; Mon, 7 Jun 2004 10:58:18 +0100 (BST) (envelope-from mark@grondar.org) Received: (from Ugrondar@localhost)i579wHp4043658; Mon, 7 Jun 2004 10:58:17 +0100 (BST) (envelope-from mark@grondar.org) X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to mark@grondar.org using -f Received: from grondar.org (localhost [127.0.0.1])i579lbFR032384; Mon, 7 Jun 2004 10:47:37 +0100 (BST) (envelope-from mark@grondar.org) From: Mark Murray Message-Id: <200406070947.i579lbFR032384@grimreaper.grondar.org> To: "David E. O'Brien" In-Reply-To: Your message of "Mon, 07 Jun 2004 09:16:19 -0000." <200406070916.i579GJLe052073@repoman.freebsd.org> Date: Mon, 07 Jun 2004 10:47:36 +0100 Sender: mark@grondar.org cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/etc/rc.d preseedrandom X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 09:58:26 -0000 "David E. O'Brien" writes: > obrien 2004-06-07 09:16:19 UTC > FreeBSD src repository > > Modified files: > etc/rc.d preseedrandom > Log: > Don't assume everyone's /etc/[default/]rc.conf 'entropy_file' is "/entropy" > . This has foot-shooting potential. Preseedrandom is run before filesystems are mounted, so ${entropy_file} MUST be on / . Please document that. M -- Mark Murray iumop ap!sdn w,I idlaH From owner-cvs-src@FreeBSD.ORG Mon Jun 7 09:59:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9460A16A4CE; Mon, 7 Jun 2004 09:59:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AA9343D49; Mon, 7 Jun 2004 09:59:58 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i579xoQs060289; Mon, 7 Jun 2004 09:59:50 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i579xow8060288; Mon, 7 Jun 2004 09:59:50 GMT (envelope-from ume) Message-Id: <200406070959.i579xow8060288@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Mon, 7 Jun 2004 09:59:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 09:59:58 -0000 ume 2004-06-07 09:59:50 UTC FreeBSD src repository Modified files: sys/kern uipc_syscalls.c Log: allow more than MLEN bytes for ancillary data to meet the requirement of Section 20.1 of RFC3542. Obtained from: KAME MFC after: 1 week Revision Changes Path 1.187 +9 -1 src/sys/kern/uipc_syscalls.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 10:08:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8696816A4D0; Mon, 7 Jun 2004 10:08:05 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6417B43D1F; Mon, 7 Jun 2004 10:08:05 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i57A7qkI030519; Mon, 7 Jun 2004 03:07:53 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i57A7qqR030518; Mon, 7 Jun 2004 03:07:52 -0700 (PDT) (envelope-from obrien) Date: Mon, 7 Jun 2004 03:07:52 -0700 From: "David O'Brien" To: Mark Murray Message-ID: <20040607100752.GA30496@dragon.nuxi.com> References: <200406070916.i579GJLe052073@repoman.freebsd.org> <200406070947.i579lbFR032384@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406070947.i579lbFR032384@grimreaper.grondar.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/etc/rc.d preseedrandom X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.ORG List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 10:08:05 -0000 On Mon, Jun 07, 2004 at 10:47:36AM +0100, Mark Murray wrote: > "David E. O'Brien" writes: > > obrien 2004-06-07 09:16:19 UTC > > FreeBSD src repository > > > > Modified files: > > etc/rc.d preseedrandom > > Log: > > Don't assume everyone's /etc/[default/]rc.conf 'entropy_file' is "/entropy" > > . > > This has foot-shooting potential. Preseedrandom is run before > filesystems are mounted, so ${entropy_file} MUST be on / . > > Please document that. Will do that, I'm waiting on feedback from someone. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Jun 7 10:10:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2578C16A4CE; Mon, 7 Jun 2004 10:10:50 +0000 (GMT) Received: from dong.ci0.org (cognet.ci0.org [80.65.224.102]) by mx1.FreeBSD.org (Postfix) with ESMTP id 047BF43D2F; Mon, 7 Jun 2004 10:10:49 +0000 (GMT) (envelope-from doginou@dong.ci0.org) Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1]) by dong.ci0.org (8.12.11/8.12.11) with ESMTP id i57ALDjn082720; Mon, 7 Jun 2004 12:21:13 +0200 (CEST) (envelope-from doginou@dong.ci0.org) Received: (from doginou@localhost) by dong.ci0.org (8.12.11/8.12.11/Submit) id i57ALCuj082719; Mon, 7 Jun 2004 12:21:12 +0200 (CEST) (envelope-from doginou) Date: Mon, 7 Jun 2004 12:21:12 +0200 From: Olivier Houchard To: "David O'Brien" Message-ID: <20040607102112.GA82695@ci0.org> References: <200405092229.i49MT0pN065683@repoman.freebsd.org> <20040607071133.GA8013@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040607071133.GA8013@dragon.nuxi.com> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/config config.h config.y configvers.h lang.l main.c mkmakefile.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 10:10:50 -0000 On Mon, Jun 07, 2004 at 12:11:33AM -0700, David O'Brien wrote: > On Sun, May 09, 2004 at 03:29:00PM -0700, Olivier Houchard wrote: > > cognet 2004/05/09 15:29:00 PDT > > > > FreeBSD src repository > > > > Modified files: > > usr.sbin/config config.h config.y configvers.h lang.l > > main.c mkmakefile.c > > Log: > > Add a new "files" directive, which allows to include a files.foo file directly > > from a kernel config file. > > Bump config version to reflect this change. > > Please document this in config(8). > It isn't at all clear to me from the commit log why/what uses this for. > I documented it in config(5), which looked like the right place. Olivier From owner-cvs-src@FreeBSD.ORG Mon Jun 7 10:31:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E30A16A4CE; Mon, 7 Jun 2004 10:31:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73CC643D48; Mon, 7 Jun 2004 10:31:34 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57AVApJ067387; Mon, 7 Jun 2004 10:31:10 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57AVAYb067386; Mon, 7 Jun 2004 10:31:10 GMT (envelope-from tjr) Message-Id: <200406071031.i57AVAYb067386@repoman.freebsd.org> From: "Tim J. Robbins" Date: Mon, 7 Jun 2004 10:31:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/include wchar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 10:31:34 -0000 tjr 2004-06-07 10:31:10 UTC FreeBSD src repository Modified files: include wchar.h Log: Fix typo in putwc(). Noticed by: stefanf Revision Changes Path 1.41 +1 -1 src/include/wchar.h From owner-cvs-src@FreeBSD.ORG Mon Jun 7 11:01:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90A9C16A4CE; Mon, 7 Jun 2004 11:01:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74C6343D31; Mon, 7 Jun 2004 11:01:40 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57B1eQS074013; Mon, 7 Jun 2004 11:01:40 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57B1ePF073996; Mon, 7 Jun 2004 11:01:40 GMT (envelope-from yar) Message-Id: <200406071101.i57B1ePF073996@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 7 Jun 2004 11:01:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/gen signal.3 src/lib/libc/sys sigaction.2 wait.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 11:01:40 -0000 yar 2004-06-07 11:01:40 UTC FreeBSD src repository Modified files: lib/libc/gen signal.3 lib/libc/sys sigaction.2 wait.2 Log: Finally document the option to avoid zombie creation through ignoring SIGCHLD. Revision Changes Path 1.36 +22 -1 src/lib/libc/gen/signal.3 1.50 +11 -1 src/lib/libc/sys/sigaction.2 1.17 +8 -0 src/lib/libc/sys/wait.2 From owner-cvs-src@FreeBSD.ORG Mon Jun 7 11:48:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8F7116A4D0 for ; Mon, 7 Jun 2004 11:48:22 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D3D843D48 for ; Mon, 7 Jun 2004 11:48:22 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 3509 invoked from network); 7 Jun 2004 11:48:22 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 7 Jun 2004 11:48:21 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i57Bm8Mh002092; Mon, 7 Jun 2004 07:48:08 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: David Schultz Date: Mon, 7 Jun 2004 07:49:02 -0400 User-Agent: KMail/1.6 References: <200406050313.i553Dd3q070600@repoman.freebsd.org> In-Reply-To: <200406050313.i553Dd3q070600@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406070749.03027.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 11:48:23 -0000 On Friday 04 June 2004 11:13 pm, David Schultz wrote: > das 2004/06/04 20:13:39 PDT > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 fpu.c > Log: > Initialize the MXCSR to the appropriate default value at startup. > > Tested on: tjr FreeBSD/tjr? :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Jun 7 11:53:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B75C716A4D1 for ; Mon, 7 Jun 2004 11:53:12 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id A001843D1D for ; Mon, 7 Jun 2004 11:53:12 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 13732 invoked from network); 7 Jun 2004 11:53:09 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 7 Jun 2004 11:53:08 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i57Br0L2002116; Mon, 7 Jun 2004 07:53:01 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Date: Mon, 7 Jun 2004 07:53:55 -0400 User-Agent: KMail/1.6 References: <200406032236.i53MaOj5046199@repoman.freebsd.org> <20040607060013.GA5554@dragon.nuxi.com> In-Reply-To: <20040607060013.GA5554@dragon.nuxi.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406070753.55566.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Poul-Henning Kamp Subject: Re: cvs commit: src/sys/i386/include/pc bios.h src/sys/i386/i386 bios.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 11:53:12 -0000 On Monday 07 June 2004 02:00 am, David O'Brien wrote: > On Thu, Jun 03, 2004 at 03:36:24PM -0700, Poul-Henning Kamp wrote: > > phk 2004/06/03 15:36:24 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/i386/include/pc bios.h > > sys/i386/i386 bios.c > > Log: > > Add new bios_string() which will hunt for a string inside a given range > > of the BIOS. This can be used for finding arbitrary magic in the BIOS > > in order to recognize particular platforms. > > It seems that this function (and many others in sys/i386/i386/bios.c) > should go into a common MI file as they are directly usable on AMD64 > also. Well, I don't think they are MI, but I've been wanting to create a sys/x86 tree ala NetBSD for a while now. Things like the interrupt code could move there. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Jun 7 12:19:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5ADE316A4CE; Mon, 7 Jun 2004 12:19:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42F2E43D46; Mon, 7 Jun 2004 12:19:56 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57CJuGK091754; Mon, 7 Jun 2004 12:19:56 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57CJuh1091753; Mon, 7 Jun 2004 12:19:56 GMT (envelope-from pjd) Message-Id: <200406071219.i57CJuh1091753@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Mon, 7 Jun 2004 12:19:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 12:19:56 -0000 pjd 2004-06-07 12:19:55 UTC FreeBSD src repository Modified files: sys/kern vfs_syscalls.c Log: Remove unused code. Submitted by: Bjoern A. Zeeb Revision Changes Path 1.348 +1 -6 src/sys/kern/vfs_syscalls.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 12:25:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB7B816A4CE; Mon, 7 Jun 2004 12:25:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3DBC43D4C; Mon, 7 Jun 2004 12:25:15 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57CPFhn093638; Mon, 7 Jun 2004 12:25:15 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57CPFxq093637; Mon, 7 Jun 2004 12:25:15 GMT (envelope-from truckman) Message-Id: <200406071225.i57CPFxq093637@repoman.freebsd.org> From: Don Lewis Date: Mon, 7 Jun 2004 12:25:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/sound/pcm sound.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 12:25:15 -0000 truckman 2004-06-07 12:25:15 UTC FreeBSD src repository Modified files: sys/dev/sound/pcm sound.c Log: Nuke a cryptic and useless diagnostic printf(). Revision Changes Path 1.91 +0 -1 src/sys/dev/sound/pcm/sound.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 12:42:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E15E16A4CE; Mon, 7 Jun 2004 12:42:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74BA343D46; Mon, 7 Jun 2004 12:42:38 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57CgceT097646; Mon, 7 Jun 2004 12:42:38 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57CgcEi097645; Mon, 7 Jun 2004 12:42:38 GMT (envelope-from yar) Message-Id: <200406071242.i57CgcEi097645@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 7 Jun 2004 12:42:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/test test.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 12:42:38 -0000 yar 2004-06-07 12:42:38 UTC FreeBSD src repository Modified files: bin/test test.1 Log: Describe how test(1) will evaluate its expressions for a symlink. Inspired by: SUSv3 MFC after: 1 week Revision Changes Path 1.19 +13 -1 src/bin/test/test.1 From owner-cvs-src@FreeBSD.ORG Mon Jun 7 12:42:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C93D616A4CE; Mon, 7 Jun 2004 12:42:56 +0000 (GMT) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D96F43D46; Mon, 7 Jun 2004 12:42:56 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87])i57Cgt5v014815; Mon, 7 Jun 2004 22:42:55 +1000 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i57CgrLS012317; Mon, 7 Jun 2004 22:42:53 +1000 Date: Mon, 7 Jun 2004 22:42:52 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp In-Reply-To: <200406062126.i56LQnYo077695@repoman.freebsd.org> Message-ID: <20040607224243.E13219@gamplex.bde.org> References: <200406062126.i56LQnYo077695@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/arm/arm exception.S in_cksum_arm.S locore.S src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sparc64/include asmacros.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 12:42:57 -0000 On Sun, 6 Jun 2004, Poul-Henning Kamp wrote: > phk 2004-06-06 21:26:49 UTC > > FreeBSD src repository > > Modified files: > sys/alpha/alpha support.s > sys/arm/arm exception.S in_cksum_arm.S locore.S > sys/i386/i386 swtch.s > sys/kern kern_shutdown.c > sys/sparc64/include asmacros.h > sys/sys systm.h > Log: > Remove filename+line number from panic messages. Thanks. Bruce From owner-cvs-src@FreeBSD.ORG Mon Jun 7 12:47:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBE2516A4CE; Mon, 7 Jun 2004 12:47:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D286843D1D; Mon, 7 Jun 2004 12:47:31 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57ClV8g004111; Mon, 7 Jun 2004 12:47:31 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57ClVAT004110; Mon, 7 Jun 2004 12:47:31 GMT (envelope-from yar) Message-Id: <200406071247.i57ClVAT004110@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 7 Jun 2004 12:47:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/test test.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 12:47:32 -0000 yar 2004-06-07 12:47:31 UTC FreeBSD src repository Modified files: bin/test test.1 Log: Remove a duplicated description of the test for the null string. MFC after: 3 days Revision Changes Path 1.20 +0 -5 src/bin/test/test.1 From owner-cvs-src@FreeBSD.ORG Mon Jun 7 13:33:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70B9D16A4CE; Mon, 7 Jun 2004 13:33:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56DC443D45; Mon, 7 Jun 2004 13:33:10 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57DXAIB015115; Mon, 7 Jun 2004 13:33:10 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57DXAwZ015114; Mon, 7 Jun 2004 13:33:10 GMT (envelope-from pjd) Message-Id: <200406071333.i57DXAwZ015114@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Mon, 7 Jun 2004 13:33:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/nop g_nop.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 13:33:10 -0000 pjd 2004-06-07 13:33:10 UTC FreeBSD src repository Modified files: sys/geom/nop g_nop.c Log: Don't allow for duplicated entries creation. Revision Changes Path 1.3 +11 -5 src/sys/geom/nop/g_nop.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 13:35:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 157C616A4CE; Mon, 7 Jun 2004 13:35:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F1EA043D39; Mon, 7 Jun 2004 13:35:02 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57DZ2tS015222; Mon, 7 Jun 2004 13:35:02 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57DZ25h015221; Mon, 7 Jun 2004 13:35:02 GMT (envelope-from davidxu) Message-Id: <200406071335.i57DZ25h015221@repoman.freebsd.org> From: David Xu Date: Mon, 7 Jun 2004 13:35:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 13:35:03 -0000 davidxu 2004-06-07 13:35:02 UTC FreeBSD src repository Modified files: sys/kern kern_sig.c Log: According to SUSv3, sigwait is different with sigwaitinfo, sigwait returns error code in return value, not in errno. Revision Changes Path 1.280 +12 -5 src/sys/kern/kern_sig.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 13:40:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C50D16A4CE; Mon, 7 Jun 2004 13:40:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4467943D55; Mon, 7 Jun 2004 13:40:46 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57DefRq015588; Mon, 7 Jun 2004 13:40:42 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57Defj2015587; Mon, 7 Jun 2004 13:40:41 GMT (envelope-from pjd) Message-Id: <200406071340.i57Defj2015587@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Mon, 7 Jun 2004 13:40:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/nop g_nop.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 13:40:46 -0000 pjd 2004-06-07 13:40:41 UTC FreeBSD src repository Modified files: sys/geom/nop g_nop.c Log: Fix format string. Revision Changes Path 1.4 +2 -2 src/sys/geom/nop/g_nop.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 16:34:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E6CB16A4CE; Mon, 7 Jun 2004 16:34:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61ED343D4C; Mon, 7 Jun 2004 16:34:01 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57GXmmf054881; Mon, 7 Jun 2004 16:33:48 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57GXm5V054880; Mon, 7 Jun 2004 16:33:48 GMT (envelope-from wpaul) Message-Id: <200406071633.i57GXm5V054880@repoman.freebsd.org> From: Bill Paul Date: Mon, 7 Jun 2004 16:33:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/sio sio_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 16:34:01 -0000 wpaul 2004-06-07 16:33:48 UTC FreeBSD src repository Modified files: sys/dev/sio sio_pci.c Log: Add an entry to the PCI ID list to support the serial interface on the Broadcom 802.11g/GPRS CardBus card. Submitted by: Yann Berthier yb at sainte-barbe dot org Revision Changes Path 1.16 +1 -0 src/sys/dev/sio/sio_pci.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 16:42:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DB3516A4CE; Mon, 7 Jun 2004 16:42:20 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6196643D53; Mon, 7 Jun 2004 16:42:20 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i57GgDsE040359; Mon, 7 Jun 2004 09:42:13 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i57GgDDf040358; Mon, 7 Jun 2004 09:42:13 -0700 (PDT) (envelope-from obrien) Date: Mon, 7 Jun 2004 09:42:13 -0700 From: "David O'Brien" To: John Baldwin Message-ID: <20040607164213.GA40215@dragon.nuxi.com> References: <200406032236.i53MaOj5046199@repoman.freebsd.org> <20040607060013.GA5554@dragon.nuxi.com> <200406070753.55566.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406070753.55566.jhb@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include/pc bios.h src/sys/i386/i386 bios.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 16:42:20 -0000 On Mon, Jun 07, 2004 at 07:53:55AM -0400, John Baldwin wrote: > On Monday 07 June 2004 02:00 am, David O'Brien wrote: > > On Thu, Jun 03, 2004 at 03:36:24PM -0700, Poul-Henning Kamp wrote: > > > phk 2004/06/03 15:36:24 PDT > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/i386/include/pc bios.h > > > sys/i386/i386 bios.c > > > Log: > > > Add new bios_string() which will hunt for a string inside a given range > > > of the BIOS. This can be used for finding arbitrary magic in the BIOS > > > in order to recognize particular platforms. > > > > It seems that this function (and many others in sys/i386/i386/bios.c) > > should go into a common MI file as they are directly usable on AMD64 > > also. > > Well, I don't think they are MI, but I've been wanting to create a sys/x86 > tree ala NetBSD for a while now. Things like the interrupt code could move > there. yes please! :-) -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Jun 7 16:46:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 79DDD16A4CE; Mon, 7 Jun 2004 16:46:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E59743D1F; Mon, 7 Jun 2004 16:46:42 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57GkSY7057136; Mon, 7 Jun 2004 16:46:28 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57GkShf057135; Mon, 7 Jun 2004 16:46:28 GMT (envelope-from yar) Message-Id: <200406071646.i57GkShf057135@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 7 Jun 2004 16:46:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man9 ifnet.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 16:46:42 -0000 yar 2004-06-07 16:46:28 UTC FreeBSD src repository Modified files: share/man/man9 ifnet.9 Log: 1. There are interface capabilities to be used by "lower" kernel components as well, i.e., polling. 2. Stress that if_capenable should be modified only from within the interface driver because it solely knows about how to control the capabilities. Revision Changes Path 1.39 +18 -2 src/share/man/man9/ifnet.9 From owner-cvs-src@FreeBSD.ORG Mon Jun 7 17:36:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13E1916A4CE; Mon, 7 Jun 2004 17:36:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECBFD43D2D; Mon, 7 Jun 2004 17:36:22 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57HaMlx074431; Mon, 7 Jun 2004 17:36:22 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57HaMVa074430; Mon, 7 Jun 2004 17:36:22 GMT (envelope-from jhb) Message-Id: <200406071736.i57HaMVa074430@repoman.freebsd.org> From: John Baldwin Date: Mon, 7 Jun 2004 17:36:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_pcib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 17:36:23 -0000 jhb 2004-06-07 17:36:22 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_pcib.c Log: - Use PCI_INVALID_IRQ macro rather than a magic number. - Remove obsolete comment about APIC_IO routing. Revision Changes Path 1.44 +1 -2 src/sys/dev/acpica/acpi_pcib.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 17:42:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A35E16A4CE; Mon, 7 Jun 2004 17:42:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F52443D46; Mon, 7 Jun 2004 17:42:43 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Hgg5k076378; Mon, 7 Jun 2004 17:42:42 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57HggwA076377; Mon, 7 Jun 2004 17:42:42 GMT (envelope-from cperciva) Message-Id: <200406071742.i57HggwA076377@repoman.freebsd.org> From: Colin Percival Date: Mon, 7 Jun 2004 17:42:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4_8 Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/net rtsock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 17:42:43 -0000 cperciva 2004-06-07 17:42:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_4_8) . UPDATING sys/conf newvers.sh sys/net rtsock.c Log: FreeBSD-SA-04:12.jailroute: MFS revision 1.44.2.13 of sys/net/rtsock.c Bump newvers.sh and document in UPDATING. Approved by: so (des) Revision Changes Path 1.73.2.80.2.26 +4 -0 src/UPDATING 1.44.2.29.2.24 +1 -1 src/sys/conf/newvers.sh 1.44.2.11.2.1 +2 -2 src/sys/net/rtsock.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 17:44:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0F0316A4D1; Mon, 7 Jun 2004 17:44:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5DD143D4C; Mon, 7 Jun 2004 17:44:44 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57HiiLI076547; Mon, 7 Jun 2004 17:44:44 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57HiiMQ076546; Mon, 7 Jun 2004 17:44:44 GMT (envelope-from cperciva) Message-Id: <200406071744.i57HiiMQ076546@repoman.freebsd.org> From: Colin Percival Date: Mon, 7 Jun 2004 17:44:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4_9 Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/net rtsock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 17:44:45 -0000 cperciva 2004-06-07 17:44:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_4_9) . UPDATING sys/conf newvers.sh sys/net rtsock.c Log: FreeBSD-SA-04:12.jailroute: MFS revision 1.44.2.13 of sys/net/rtsock.c Bump newvers.sh and document in UPDATING. Approved by: so (des) Revision Changes Path 1.73.2.89.2.11 +4 -0 src/UPDATING 1.44.2.32.2.11 +1 -1 src/sys/conf/newvers.sh 1.44.2.11.4.1 +2 -2 src/sys/net/rtsock.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 18:22:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFD9316A4CE; Mon, 7 Jun 2004 18:22:24 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id A32BC43D1D; Mon, 7 Jun 2004 18:22:24 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.10/8.12.10) with ESMTP id i57IMGRH006873; Mon, 7 Jun 2004 11:22:16 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.10/8.12.3/Submit) id i57IMGCB006872; Mon, 7 Jun 2004 11:22:16 -0700 Date: Mon, 7 Jun 2004 11:22:16 -0700 From: Brooks Davis To: "David E. O'Brien" Message-ID: <20040607182216.GB28779@Odin.AC.HMC.Edu> References: <200406070916.i579GJLe052073@repoman.freebsd.org> <20040607091630.8659116A58E@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aM3YZ0Iwxop3KEKx" Content-Disposition: inline In-Reply-To: <20040607091630.8659116A58E@hub.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: [src] cvs commit: src/etc/rc.d preseedrandom X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 18:22:24 -0000 --aM3YZ0Iwxop3KEKx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2004 at 09:16:30AM +0000, David E. O'Brien wrote: > obrien 2004-06-07 09:16:19 UTC >=20 > FreeBSD src repository >=20 > Modified files: > etc/rc.d preseedrandom=20 > Log: > Don't assume everyone's /etc/[default/]rc.conf 'entropy_file' is "/entr= opy". This was deliberate. The preseedrandom script only exists to get enough entropy into the system to get initdiskless off the ground. Real entropy seeding takes place in initrandom. You must not assume rc.conf exists when preseedrandom is called! The only things you get to assume are a / as populated by installworld and an /etc as populated by make distribute. At that /etc/rc.conf may not exist since it could be created by initdiskless. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --aM3YZ0Iwxop3KEKx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFAxLJXXY6L6fI4GtQRAuSyAJ9a6SjBlXZ1zCX/zltM0/OaiTouMQCgkU/R sVjLlH1rMuPkKVUa5MAyp70= =CkeA -----END PGP SIGNATURE----- --aM3YZ0Iwxop3KEKx-- From owner-cvs-src@FreeBSD.ORG Mon Jun 7 18:42:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4AA5216A4CE; Mon, 7 Jun 2004 18:42:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2EF3E43D4C; Mon, 7 Jun 2004 18:42:51 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57IgpLa089558; Mon, 7 Jun 2004 18:42:51 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57Igobf089557; Mon, 7 Jun 2004 18:42:50 GMT (envelope-from kientzle) Message-Id: <200406071842.i57Igobf089557@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 7 Jun 2004 18:42:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 18:42:51 -0000 kientzle 2004-06-07 18:42:50 UTC FreeBSD src repository Modified files: lib/libarchive archive.h Log: Linux (at least Debian) requires sys/types.h to get off_t. Revision Changes Path 1.12 +1 -0 src/lib/libarchive/archive.h From owner-cvs-src@FreeBSD.ORG Mon Jun 7 18:54:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DA2216A4CE; Mon, 7 Jun 2004 18:54:12 +0000 (GMT) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 803A243D48; Mon, 7 Jun 2004 18:54:11 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc12) with ESMTP id <2004060718541001400i3ug1e>; Mon, 7 Jun 2004 18:54:11 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA27327; Mon, 7 Jun 2004 11:54:09 -0700 (PDT) Date: Mon, 7 Jun 2004 11:54:08 -0700 (PDT) From: Julian Elischer To: Tim Robbins In-Reply-To: <20040607082030.GA38464@cat.robbins.dropbear.id.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Julian Elischer cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 18:54:12 -0000 On Mon, 7 Jun 2004, Tim Robbins wrote: > On Mon, Jun 07, 2004 at 07:25:03AM +0000, Julian Elischer wrote: > > julian 2004-06-07 07:25:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_kse.c > > Log: > > Move the KSE ABI specific code here and separate it from code that > > is generic to any threading system. This commit does not link this > > file to the build yet, nor does it remove these functions from their > > current location in kern_thread.c. (that commit coming up after further review) > > I like what you've done here, but please don't go overboard with the > abstraction -- the KSE code is already very hard to follow and overly > complex, and we would be kidding ourselves if we thought we could support > more than one thread system (I would like to see thr gone before 5.3-STABLE.) > I'm just spliting one file into two to make it more obvious what parts are "Generic thread support" and what parts are "Kse based threading". I regret that I didn't do it this way to start with.. but in this game you can correct some of your mistakes.. When these two are separated there are a few more cleanups, but this change should be almost a NOP as far as running code. > > Tim > From owner-cvs-src@FreeBSD.ORG Mon Jun 7 19:00:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49E0C16A4CE; Mon, 7 Jun 2004 19:00:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2EE5E43D49; Mon, 7 Jun 2004 19:00:58 +0000 (GMT) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57J0vUA091982; Mon, 7 Jun 2004 19:00:57 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57J0vQP091981; Mon, 7 Jun 2004 19:00:57 GMT (envelope-from julian) Message-Id: <200406071900.i57J0vQP091981@repoman.freebsd.org> From: Julian Elischer Date: Mon, 7 Jun 2004 19:00:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf files src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 19:00:58 -0000 julian 2004-06-07 19:00:57 UTC FreeBSD src repository Modified files: sys/conf files sys/kern kern_thread.c Log: Split kern_thread.c into 2 parts. kern_kse.c and kern_thread.c Kern_kse has already been committed. This separates out the KSE threading ABI from generic thread support. Revision Changes Path 1.901 +1 -0 src/sys/conf/files 1.179 +15 -1211 src/sys/kern/kern_thread.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 19:12:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4BAE816A4CE; Mon, 7 Jun 2004 19:12:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3135243D53; Mon, 7 Jun 2004 19:12:45 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57JCiKG096784; Mon, 7 Jun 2004 19:12:44 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57JCiRE096783; Mon, 7 Jun 2004 19:12:44 GMT (envelope-from scottl) Message-Id: <200406071912.i57JCiRE096783@repoman.freebsd.org> From: Scott Long Date: Mon, 7 Jun 2004 19:12:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/cam cam_ccb.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 19:12:45 -0000 scottl 2004-06-07 19:12:44 UTC FreeBSD src repository Modified files: sys/cam cam_ccb.h Log: Reformat the comments for cam_hdr so that they can be read. Revision Changes Path 1.27 +7 -8 src/sys/cam/cam_ccb.h From owner-cvs-src@FreeBSD.ORG Mon Jun 7 19:33:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44AAA16A4CE; Mon, 7 Jun 2004 19:33:17 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29F9F43D5A; Mon, 7 Jun 2004 19:33:17 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57JX5FF001319; Mon, 7 Jun 2004 19:33:05 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57JX5CZ001318; Mon, 7 Jun 2004 19:33:05 GMT (envelope-from netchild) Message-Id: <200406071933.i57JX5CZ001318@repoman.freebsd.org> From: Alexander Leidinger Date: Mon, 7 Jun 2004 19:33:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf NOTES src/sys/vm vm_pageq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 19:33:17 -0000 netchild 2004-06-07 19:33:05 UTC FreeBSD src repository (ports committer) Modified files: sys/conf NOTES sys/vm vm_pageq.c Log: Remove references to L1 in the comments, according to Alan they are historical leftovers. Approved by: alc Revision Changes Path 1.1228 +5 -5 src/sys/conf/NOTES 1.14 +2 -2 src/sys/vm/vm_pageq.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 20:22:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBB3016A4F0; Mon, 7 Jun 2004 20:22:23 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id AEA6F43D49; Mon, 7 Jun 2004 20:22:23 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i57KMMOJ046775; Mon, 7 Jun 2004 13:22:23 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i57KMMBr046774; Mon, 7 Jun 2004 13:22:22 -0700 (PDT) (envelope-from obrien) Date: Mon, 7 Jun 2004 13:22:21 -0700 From: "David O'Brien" To: Brooks Davis Message-ID: <20040607202221.GA46456@dragon.nuxi.com> References: <200406070916.i579GJLe052073@repoman.freebsd.org> <20040607091630.8659116A58E@hub.freebsd.org> <20040607182216.GB28779@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040607182216.GB28779@Odin.AC.HMC.Edu> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: [src] cvs commit: src/etc/rc.d preseedrandom X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.ORG List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 20:22:24 -0000 On Mon, Jun 07, 2004 at 11:22:16AM -0700, Brooks Davis wrote: > On Mon, Jun 07, 2004 at 09:16:30AM +0000, David E. O'Brien wrote: > > obrien 2004-06-07 09:16:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc/rc.d preseedrandom > > Log: > > Don't assume everyone's /etc/[default/]rc.conf 'entropy_file' is "/entropy". > > This was deliberate. The preseedrandom script only exists to get > enough entropy into the system to get initdiskless off the ground. > Real entropy seeding takes place in initrandom. You must not assume > rc.conf exists when preseedrandom is called! The only things you get to > assume are a / as populated by installworld and an /etc as populated by > make distribute. At that /etc/rc.conf may not exist since it could be > created by initdiskless. Our diskless setup has become overly convoluted -- I still use the simple Sun-style. That said /etc/defaults/rc.conf is populated by 'make installworld'. We have a published interface (entropy_file="/entropy" # Set to NO to disable caching entropy through reboots), and 'rc.d/preseedrandom' should be made to properly use it. If some diskless environments are too broken to allow the published interface, why can't hacks for them be added to 'rc.d/initdiskless'? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Jun 7 20:43:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 93D7C16A4CE; Mon, 7 Jun 2004 20:43:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 78C0143D31; Mon, 7 Jun 2004 20:43:55 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Khbr5016585; Mon, 7 Jun 2004 20:43:37 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57KhbCt016584; Mon, 7 Jun 2004 20:43:37 GMT (envelope-from phk) Message-Id: <200406072043.i57KhbCt016584@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 7 Jun 2004 20:43:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if_sl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 20:43:55 -0000 phk 2004-06-07 20:43:37 UTC FreeBSD src repository Modified files: sys/net if_sl.c Log: Use ldisc_[de]register() instead of frobbing linesw[] directly. Revision Changes Path 1.115 +2 -1 src/sys/net/if_sl.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 20:45:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B567616A4D6; Mon, 7 Jun 2004 20:45:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F1C243D1D; Mon, 7 Jun 2004 20:45:46 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Kjjvd016762; Mon, 7 Jun 2004 20:45:45 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57KjjMT016761; Mon, 7 Jun 2004 20:45:45 GMT (envelope-from phk) Message-Id: <200406072045.i57KjjMT016761@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 7 Jun 2004 20:45:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys linedisc.h src/sys/kern tty.c tty_conf.c src/sys/dev/cx if_cx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 20:45:47 -0000 phk 2004-06-07 20:45:45 UTC FreeBSD src repository Modified files: sys/sys linedisc.h sys/kern tty.c tty_conf.c sys/dev/cx if_cx.c Log: Make linesw[] an array of pointers to linedesc instead of an array of linedisc. Revision Changes Path 1.16 +1 -1 src/sys/dev/cx/if_cx.c 1.216 +3 -3 src/sys/kern/tty.c 1.21 +58 -62 src/sys/kern/tty_conf.c 1.190 +9 -9 src/sys/sys/linedisc.h From owner-cvs-src@FreeBSD.ORG Mon Jun 7 20:46:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA95B16A4CE; Mon, 7 Jun 2004 20:46:22 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B4E443D1D; Mon, 7 Jun 2004 20:46:22 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.10/8.12.10) with ESMTP id i57KkMRH021337; Mon, 7 Jun 2004 13:46:22 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.10/8.12.3/Submit) id i57KkL0A021335; Mon, 7 Jun 2004 13:46:21 -0700 Date: Mon, 7 Jun 2004 13:46:21 -0700 From: Brooks Davis To: "David O'Brien" Message-ID: <20040607204621.GA19196@Odin.AC.HMC.Edu> References: <200406070916.i579GJLe052073@repoman.freebsd.org> <20040607091630.8659116A58E@hub.freebsd.org> <20040607182216.GB28779@Odin.AC.HMC.Edu> <20040607202221.GA46456@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <20040607202221.GA46456@dragon.nuxi.com> User-Agent: Mutt/1.5.4i cc: Brooks Davis cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: [src] cvs commit: src/etc/rc.d preseedrandom X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 20:46:22 -0000 --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2004 at 01:22:21PM -0700, David O'Brien wrote: > On Mon, Jun 07, 2004 at 11:22:16AM -0700, Brooks Davis wrote: > > On Mon, Jun 07, 2004 at 09:16:30AM +0000, David E. O'Brien wrote: > > > obrien 2004-06-07 09:16:19 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > etc/rc.d preseedrandom=20 > > > Log: > > > Don't assume everyone's /etc/[default/]rc.conf 'entropy_file' is "/= entropy". > >=20 > > This was deliberate. The preseedrandom script only exists to get > > enough entropy into the system to get initdiskless off the ground. > > Real entropy seeding takes place in initrandom. You must not assume > > rc.conf exists when preseedrandom is called! The only things you get to > > assume are a / as populated by installworld and an /etc as populated by > > make distribute. At that /etc/rc.conf may not exist since it could be > > created by initdiskless. >=20 > Our diskless setup has become overly convoluted -- I still use the simple > Sun-style. That said /etc/defaults/rc.conf is populated by 'make > installworld'. We have a published interface (entropy_file=3D"/entropy" # > Set to NO to disable caching entropy through reboots), and > 'rc.d/preseedrandom' should be made to properly use it. >=20 > If some diskless environments are too broken to allow the published > interface, why can't hacks for them be added to 'rc.d/initdiskless'? The published interface applies to those scripts that can depend (directly or indirectly) on rcconf.sh. Before that point rc.conf=20 is not sourced in the script's environment so entropy_file is not defined. I'm pretty sure this change makes 'feed_dev_random "/entropy"' into 'feed_dev_random ""'. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFAxNO4XY6L6fI4GtQRAo4qAKCyZ76qYK7sAAHtw1s08vOr7M42eQCgqHi2 XoHvgGrxSRuEP9laSEK3d+Q= =iKuM -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X-- From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:09:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E0CC16A4D0; Mon, 7 Jun 2004 21:09:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2151E43D1F; Mon, 7 Jun 2004 21:09:59 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57L9w4s028071; Mon, 7 Jun 2004 21:09:58 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57L9wK4028070; Mon, 7 Jun 2004 21:09:58 GMT (envelope-from gad) Message-Id: <200406072109.i57L9wK4028070@repoman.freebsd.org> From: Garance A Drosehn Date: Mon, 7 Jun 2004 21:09:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:09:59 -0000 gad 2004-06-07 21:09:58 UTC FreeBSD src repository Modified files: usr.sbin/newsyslog newsyslog.c Log: In "neworder" processing, reduce the delay between signals to separate processes, and balance that by adding a 10-second delay after all the processes have been signaled. Also improvement a few messages printed with `-n' or `-v' processing (mostly signal-related messages). MFC after: 13 days Revision Changes Path 1.91 +38 -10 src/usr.sbin/newsyslog/newsyslog.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:18:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3657416A4CE; Mon, 7 Jun 2004 21:18:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1979243D46; Mon, 7 Jun 2004 21:18:10 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57LI9if030213; Mon, 7 Jun 2004 21:18:09 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57LI9rc030212; Mon, 7 Jun 2004 21:18:09 GMT (envelope-from gad) Message-Id: <200406072118.i57LI9rc030212@repoman.freebsd.org> From: Garance A Drosehn Date: Mon, 7 Jun 2004 21:18:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:18:10 -0000 gad 2004-06-07 21:18:09 UTC FreeBSD src repository Modified files: usr.sbin/newsyslog newsyslog.c Log: Add an "oldorder" option, so that when the default changes to "neworder", people have a way to drop back to the previous logic. MFC after: 13 days Revision Changes Path 1.92 +8 -0 src/usr.sbin/newsyslog/newsyslog.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:25:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 797B716A4CE; Mon, 7 Jun 2004 21:25:17 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D7E543D54; Mon, 7 Jun 2004 21:25:17 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57LPH6o032213; Mon, 7 Jun 2004 21:25:17 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57LPHR7032212; Mon, 7 Jun 2004 21:25:17 GMT (envelope-from tjr) Message-Id: <200406072125.i57LPHR7032212@repoman.freebsd.org> From: "Tim J. Robbins" Date: Mon, 7 Jun 2004 21:25:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/arch/amd64/amd64 context.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:25:17 -0000 tjr 2004-06-07 21:25:16 UTC FreeBSD src repository Modified files: lib/libpthread/arch/amd64/amd64 context.S Log: Avoid clobbering the red zone when running on the new context's stack in _amd64_restore_context(). Revision Changes Path 1.6 +5 -0 src/lib/libpthread/arch/amd64/amd64/context.S From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:37:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0463216A4CE; Mon, 7 Jun 2004 21:37:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBDA243D46; Mon, 7 Jun 2004 21:37:41 +0000 (GMT) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Lbfbb034393; Mon, 7 Jun 2004 21:37:41 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57Lbf9W034392; Mon, 7 Jun 2004 21:37:41 GMT (envelope-from julian) Message-Id: <200406072137.i57Lbf9W034392@repoman.freebsd.org> From: Julian Elischer Date: Mon, 7 Jun 2004 21:37:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:37:42 -0000 julian 2004-06-07 21:37:41 UTC FreeBSD src repository Modified files: . UPDATING Log: Note the need to rerun config. Revision Changes Path 1.309 +4 -0 src/UPDATING From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:39:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BB3F16A4CE; Mon, 7 Jun 2004 21:39:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4004143D58; Mon, 7 Jun 2004 21:39:16 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57LdGHu034492; Mon, 7 Jun 2004 21:39:16 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57LdGw2034491; Mon, 7 Jun 2004 21:39:16 GMT (envelope-from njl) Message-Id: <200406072139.i57LdGw2034491@repoman.freebsd.org> From: Nate Lawson Date: Mon, 7 Jun 2004 21:39:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_pci.c acpi_powerres.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:39:16 -0000 njl 2004-06-07 21:39:16 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_pci.c acpi_powerres.c Log: Avoid printing extraneous warning messages when trying to switch a device which doesn't support ACPI power states. Return AE_NOT_FOUND for these cases and don't print the warning message. Also, print the name of the handle instead of device when unable to switch states. The device is often not attached at this point and so its name is NULL, which doesn't help debugging. Revision Changes Path 1.17 +6 -9 src/sys/dev/acpica/acpi_pci.c 1.23 +11 -8 src/sys/dev/acpica/acpi_powerres.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:43:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3945116A4D0; Mon, 7 Jun 2004 21:43:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CF9743D49; Mon, 7 Jun 2004 21:43:15 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57LhEao036381; Mon, 7 Jun 2004 21:43:14 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57LhEwc036380; Mon, 7 Jun 2004 21:43:14 GMT (envelope-from yar) Message-Id: <200406072143.i57LhEwc036380@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 7 Jun 2004 21:43:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/sys sigaction.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:43:15 -0000 yar 2004-06-07 21:43:14 UTC FreeBSD src repository Modified files: lib/libc/sys sigaction.2 Log: Extend and improve the mdoc(7) markup of this page. Reviewed by: ru Revision Changes Path 1.51 +60 -32 src/lib/libc/sys/sigaction.2 From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:44:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B30E16A4CE; Mon, 7 Jun 2004 21:44:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3DA8243D4C; Mon, 7 Jun 2004 21:44:02 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Li1aN036468; Mon, 7 Jun 2004 21:44:01 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57Li1mZ036467; Mon, 7 Jun 2004 21:44:01 GMT (envelope-from njl) Message-Id: <200406072144.i57Li1mZ036467@repoman.freebsd.org> From: Nate Lawson Date: Mon, 7 Jun 2004 21:44:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:44:02 -0000 njl 2004-06-07 21:44:01 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_pci.c Log: Remove accidental change. Revision Changes Path 1.18 +1 -1 src/sys/dev/acpica/acpi_pci.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:44:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD7F016A4CE; Mon, 7 Jun 2004 21:44:37 +0000 (GMT) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.198.39]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74D0B43D58; Mon, 7 Jun 2004 21:44:37 +0000 (GMT) (envelope-from DougB@dougbarton.net) Received: from [192.0.35.106] (unknown[192.0.35.106]) by comcast.net (rwcrmhc13) with ESMTP id <2004060721443401500m0b1qe> (Authid: domain_name_tsar); Mon, 7 Jun 2004 21:44:35 +0000 Message-ID: <40C4E1C4.9080703@dougbarton.net> Date: Mon, 07 Jun 2004 14:44:36 -0700 From: Doug Barton User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040514 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Garance A Drosehn References: <200406072118.i57LI9rc030212@repoman.freebsd.org> In-Reply-To: <200406072118.i57LI9rc030212@repoman.freebsd.org> X-Enigmail-Version: 0.84.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:44:38 -0000 Garance A Drosehn wrote: > gad 2004-06-07 21:18:09 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/newsyslog newsyslog.c > Log: > Add an "oldorder" option, so that when the default changes to "neworder", > people have a way to drop back to the previous logic. > > MFC after: 13 days > > Revision Changes Path > 1.92 +8 -0 src/usr.sbin/newsyslog/newsyslog.c > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/usr.sbin/newsyslog/newsyslog.c.diff?&r1=1.91&r2=1.92&f=h "Old" and "new" here are relative terms, are you sure they'll still be meaningful 6 months from now? Personally I'd prefer different names, but don't care enough about it to pursue the matter beyond this bit of grousing. :) Doug -- If you're never wrong, you're not trying hard enough From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:45:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA7CE16A4CE; Mon, 7 Jun 2004 21:45:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D522143D2D; Mon, 7 Jun 2004 21:45:53 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Ljieq036649; Mon, 7 Jun 2004 21:45:44 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57Lji5D036648; Mon, 7 Jun 2004 21:45:44 GMT (envelope-from rwatson) Message-Id: <200406072145.i57Lji5D036648@repoman.freebsd.org> From: Robert Watson Date: Mon, 7 Jun 2004 21:45:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:45:54 -0000 rwatson 2004-06-07 21:45:44 UTC FreeBSD src repository Modified files: sys/kern uipc_syscalls.c Log: Correct a resource leak introduced in recent accept locking changes: when I reordered events in accept1() to allocate a file descriptor earlier, I didn't properly update use of goto on exit to unwind for cases where the file descriptor is now held, but wasn't previously. The result was that, in the event of accept() on a non-blocking socket, or in the event of a socket error, a file descriptor would be leaked. This ended up being non-fatal in many cases, as the file descriptor would be properly GC'd on process exit, so only showed up for processes that do a lot of non-blocking accept() calls, and also live for a long time (such as qmail). This change updates the use of goto targets to do additional unwinding. Eyes provided by: Brian Feldman Feet, hands provided by: Stefan Ehmann , Dimitry Andric Arjan van Leeuwen Revision Changes Path 1.188 +4 -4 src/sys/kern/uipc_syscalls.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:48:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4669816A4CE; Mon, 7 Jun 2004 21:48:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A17E43D2D; Mon, 7 Jun 2004 21:48:03 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Lm3oU036748; Mon, 7 Jun 2004 21:48:03 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57Lm2oP036747; Mon, 7 Jun 2004 21:48:02 GMT (envelope-from yar) Message-Id: <200406072148.i57Lm2oP036747@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 7 Jun 2004 21:48:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/sys sigaction.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:48:03 -0000 yar 2004-06-07 21:48:02 UTC FreeBSD src repository Modified files: lib/libc/sys sigaction.2 Log: Each sentence should begin on a new line. Revision Changes Path 1.52 +16 -10 src/lib/libc/sys/sigaction.2 From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:52:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D95116A4CE; Mon, 7 Jun 2004 21:52:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5080443D41; Mon, 7 Jun 2004 21:52:21 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57LqLxB038579; Mon, 7 Jun 2004 21:52:21 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57LqKFW038578; Mon, 7 Jun 2004 21:52:20 GMT (envelope-from yar) Message-Id: <200406072152.i57LqKFW038578@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 7 Jun 2004 21:52:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/sys sigaction.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:52:21 -0000 yar 2004-06-07 21:52:20 UTC FreeBSD src repository Modified files: lib/libc/sys sigaction.2 Log: Use ".In" to mark up C include file names. Revision Changes Path 1.53 +4 -2 src/lib/libc/sys/sigaction.2 From owner-cvs-src@FreeBSD.ORG Mon Jun 7 21:53:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 458E616A4CE; Mon, 7 Jun 2004 21:53:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 286F543D1D; Mon, 7 Jun 2004 21:53:28 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57LrShZ038725; Mon, 7 Jun 2004 21:53:28 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57LrRw1038724; Mon, 7 Jun 2004 21:53:27 GMT (envelope-from gad) Message-Id: <200406072153.i57LrRw1038724@repoman.freebsd.org> From: Garance A Drosehn Date: Mon, 7 Jun 2004 21:53:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/newsyslog ptimes.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:53:28 -0000 gad 2004-06-07 21:53:27 UTC FreeBSD src repository Modified files: usr.sbin/newsyslog ptimes.c Log: Drop the include for , it was only needed when this was using __DECONST() for something, and that reference has been removed. Noticed by: Helge Oldach MFC after: 13 days Revision Changes Path 1.5 +0 -1 src/usr.sbin/newsyslog/ptimes.c From owner-cvs-src@FreeBSD.ORG Mon Jun 7 22:03:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4965C16A4CE; Mon, 7 Jun 2004 22:03:55 +0000 (GMT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCF1343D45; Mon, 7 Jun 2004 22:03:54 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.12.8/8.12.8) with ESMTP id i57M3rIX010302; Mon, 7 Jun 2004 18:03:53 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <40C4E1C4.9080703@dougbarton.net> References: <200406072118.i57LI9rc030212@repoman.freebsd.org> <40C4E1C4.9080703@dougbarton.net> Date: Mon, 7 Jun 2004 18:03:52 -0400 To: Doug Barton , Garance A Drosehn From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 22:03:55 -0000 At 2:44 PM -0700 6/7/04, Doug Barton wrote: >Garance A Drosehn wrote: > > > Log: > > Add an "oldorder" option, so that when the default changes > > to "neworder", people have a way to drop back to the previous > > logic. > >"Old" and "new" here are relative terms, are you sure they'll still >be meaningful 6 months from now? Personally I'd prefer different >names, but don't care enough about it to pursue the matter beyond >this bit of grousing. :) These debug options are meant to be short-term, undocumented features. These two are only going to exist for a short time, and are only provided because this is a major enough restructuring of the code that I wanted to make sure people had an immediate way of "backing the change out" if they suspected a problem with it. I only expect to tell people about this if they report a problem when they are using newsyslog. I expect to make "neworder" the default within a week (if I do not hear of any problems from a few people who are testing it for me). I expect to drop both options after 5.3-release, and will remove all the "oldorder" code at the same time. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Mon Jun 7 22:11:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2C9516A4CE; Mon, 7 Jun 2004 22:11:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 96EAF43D53; Mon, 7 Jun 2004 22:11:12 +0000 (GMT) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57MBCqI042566; Mon, 7 Jun 2004 22:11:12 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57MBCju042552; Mon, 7 Jun 2004 22:11:12 GMT (envelope-from julian) Message-Id: <200406072211.i57MBCju042552@repoman.freebsd.org> From: Julian Elischer Date: Mon, 7 Jun 2004 22:11:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph ng_message.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 22:11:12 -0000 julian 2004-06-07 22:11:12 UTC FreeBSD src repository Modified files: sys/netgraph ng_message.h Log: Now that mbufs are allocated using uma, don't check for accidental usage of mbuf 'how' flags as they are the same thing. Revision Changes Path 1.23 +0 -4 src/sys/netgraph/ng_message.h From owner-cvs-src@FreeBSD.ORG Mon Jun 7 22:45:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B307416A4CE; Mon, 7 Jun 2004 22:45:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9605143D1D; Mon, 7 Jun 2004 22:45:59 +0000 (GMT) (envelope-from murray@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57MjxR6050363; Mon, 7 Jun 2004 22:45:59 GMT (envelope-from murray@repoman.freebsd.org) Received: (from murray@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57MjxY2050362; Mon, 7 Jun 2004 22:45:59 GMT (envelope-from murray) Message-Id: <200406072245.i57MjxY2050362@repoman.freebsd.org> From: Murray Stokely Date: Mon, 7 Jun 2004 22:45:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/installation/common trouble.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 22:45:59 -0000 murray 2004-06-07 22:45:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) release/doc/en_US.ISO8859-1/installation/common trouble.sgml Log: Additions to the known hardware problems list should be sent to doc@ rather than jkh@. This section was reorganized in 5.X so the change is not necessary there. Noticed by: "Ted Mittelstaedt" Revision Changes Path 1.1.2.5 +1 -1 src/release/doc/en_US.ISO8859-1/installation/common/trouble.sgml From owner-cvs-src@FreeBSD.ORG Mon Jun 7 22:57:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4179D16A4CE; Mon, 7 Jun 2004 22:57:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2479343D49; Mon, 7 Jun 2004 22:57:14 +0000 (GMT) (envelope-from murray@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Mv5gw052484; Mon, 7 Jun 2004 22:57:05 GMT (envelope-from murray@repoman.freebsd.org) Received: (from murray@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57Mv5Lq052483; Mon, 7 Jun 2004 22:57:05 GMT (envelope-from murray) Message-Id: <200406072257.i57Mv5Lq052483@repoman.freebsd.org> From: Murray Stokely Date: Mon, 7 Jun 2004 22:57:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/doc/en_US.ISO8859-1/installation/common install.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 22:57:14 -0000 murray 2004-06-07 22:57:05 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/installation/common install.sgml Log: Note that FIPS does not work on extended partitions, and that Windows 95/98/ME FAT32 primary partition ARE supported. Submitted by: "Ted Mittelstaedt" MFC After: 1 week Revision Changes Path 1.25 +4 -0 src/release/doc/en_US.ISO8859-1/installation/common/install.sgml From owner-cvs-src@FreeBSD.ORG Mon Jun 7 23:01:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC3E316A4CE; Mon, 7 Jun 2004 23:01:10 +0000 (GMT) Received: from VARK.homeunix.com (ar59.lsanca2-4.27.98.47.lsanca2.dsl-verizon.net [4.27.98.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B0FA43D54; Mon, 7 Jun 2004 23:01:10 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i57N19G4001406; Mon, 7 Jun 2004 16:01:09 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i57N19Zv001405; Mon, 7 Jun 2004 16:01:09 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Mon, 7 Jun 2004 16:01:09 -0700 From: David Schultz To: David Malone Message-ID: <20040607230109.GA1165@VARK.homeunix.com> Mail-Followup-To: David Malone , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406060916.i569G2m2097113@repoman.freebsd.org> <20040606091758.GA6354@VARK.homeunix.com> <20040607094321.GA32159@walton.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040607094321.GA32159@walton.maths.tcd.ie> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 23:01:11 -0000 On Mon, Jun 07, 2004, David Malone wrote: > On Sun, Jun 06, 2004 at 02:17:58AM -0700, David Schultz wrote: > > It would be great if someone could pick this up and devise the > > appropriate fix. I want to see this bug fixed, but I don't have the > > hardware to do amd64 kernel hacking. I'm happy to help anyone who is > > interested. > > I think I've figured out the problem. On SMP systems, fpuinit() is > called before enable_sse() for secondary processors. The ldmxcsr > instruction counts as a sse instruction, so you get an illegal > instruction fault. The patch below switches the order of fpuinit() > and enable_sse() and fixes the problem on my system anyway. Nice catch. That would certainly explain the problem, and both of the machines with reported problems (yours and sledge) are SMP. Care to commit this? From owner-cvs-src@FreeBSD.ORG Mon Jun 7 23:48:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1013616A4CE; Mon, 7 Jun 2004 23:48:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5C9C43D2F; Mon, 7 Jun 2004 23:47:59 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57Nlx0s063595; Mon, 7 Jun 2004 23:47:59 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57NlxAA063594; Mon, 7 Jun 2004 23:47:59 GMT (envelope-from peter) Message-Id: <200406072347.i57NlxAA063594@repoman.freebsd.org> From: Peter Wemm Date: Mon, 7 Jun 2004 23:47:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/include param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 23:48:00 -0000 peter 2004-06-07 23:47:59 UTC FreeBSD src repository Modified files: sys/amd64/include param.h Log: Be a little more consistent in the naming of the PML4 defines. Revision Changes Path 1.11 +3 -3 src/sys/amd64/include/param.h From owner-cvs-src@FreeBSD.ORG Mon Jun 7 23:51:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E2AE16A4CE; Mon, 7 Jun 2004 23:51:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FFB243D39; Mon, 7 Jun 2004 23:51:21 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i57NpLBS064211; Mon, 7 Jun 2004 23:51:21 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i57NpLUS064185; Mon, 7 Jun 2004 23:51:21 GMT (envelope-from peter) Message-Id: <200406072351.i57NpLUS064185@repoman.freebsd.org> From: Peter Wemm Date: Mon, 7 Jun 2004 23:51:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 23:51:21 -0000 peter 2004-06-07 23:51:20 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c Log: Fix a serious problem that manifested during swap, and a few other times. pmap_remove() would be called with a huge range and we'd stride across it in only 2MB chunks. This would manifest as massive cpu time and a largely unresponsive system during hard swap. Instead, check the higher page directories which means we can run pmap_remove() in just a few hundred loop iterations instead of millions since we can process address space in chunks of 512GB and 1GB as well as 2MB. Eternal thanks to: tmm Revision Changes Path 1.462 +60 -18 src/sys/amd64/amd64/pmap.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 00:11:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A67F616A4CE; Tue, 8 Jun 2004 00:11:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FED043D1D; Tue, 8 Jun 2004 00:11:26 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i580BQUI070003; Tue, 8 Jun 2004 00:11:26 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i580BQ1Y069999; Tue, 8 Jun 2004 00:11:26 GMT (envelope-from gad) Message-Id: <200406080011.i580BQ1Y069999@repoman.freebsd.org> From: Garance A Drosehn Date: Tue, 8 Jun 2004 00:11:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/bin/ps ps.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 00:11:26 -0000 gad 2004-06-08 00:11:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) bin/ps ps.c Log: MFC *: Fix the kludge-old-options processing so `ps tpt' will be treated the same as `ps -tpt', instead of being changed into `ps -tpT'. Also adjust it so `ps t p0' is treated like `ps -t p0', instead of making it `ps -T p0'. This includes the rewrite of the kludge-option processing, but it does NOT remove the long-undocumented BACKWARD_COMPATIBILITY compile-time option. If you delete the '#define BACKWARD_COMPATIBILITY' line, you'll get the newer handling for "extra arguments", which is to treat them as requests for processes. Also brings in a number of style(9) improvements. [* = 1.90 & 1.92 -> 1.98 ps.c] PR: bin/52489 (for `ps tpt' and `ps t p0') Submitted by: Jilles Tjoelker ( " ) Revision Changes Path 1.30.2.15 +126 -107 src/bin/ps/ps.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 00:11:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EFCA16A4E8; Tue, 8 Jun 2004 00:11:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E66FC43D53; Tue, 8 Jun 2004 00:11:32 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i580BW6J070120; Tue, 8 Jun 2004 00:11:32 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i580BWjg070119; Tue, 8 Jun 2004 00:11:32 GMT (envelope-from peter) Message-Id: <200406080011.i580BWjg070119@repoman.freebsd.org> From: Peter Wemm Date: Tue, 8 Jun 2004 00:11:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 00:11:33 -0000 peter 2004-06-08 00:11:32 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c Log: Use trunc_page(va) when we mean it rather than anding it with PG_FRAME (which doesn't work all that well when there are bits at the top that are masked by PG_FRAME) Revision Changes Path 1.463 +2 -2 src/sys/amd64/amd64/pmap.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 00:23:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A886816A4CE; Tue, 8 Jun 2004 00:23:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B15043D39; Tue, 8 Jun 2004 00:23:27 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i580NRK3072804; Tue, 8 Jun 2004 00:23:27 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i580NRnF072803; Tue, 8 Jun 2004 00:23:27 GMT (envelope-from kientzle) Message-Id: <200406080023.i580NRnF072803@repoman.freebsd.org> From: Tim Kientzle Date: Tue, 8 Jun 2004 00:23:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_read.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 00:23:27 -0000 kientzle 2004-06-08 00:23:27 UTC FreeBSD src repository Modified files: lib/libarchive archive_read.3 Log: Correct some spelling errors. Revision Changes Path 1.7 +6 -6 src/lib/libarchive/archive_read.3 From owner-cvs-src@FreeBSD.ORG Tue Jun 8 00:29:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B9C916A4CE; Tue, 8 Jun 2004 00:29:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E65443D54; Tue, 8 Jun 2004 00:29:53 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i580TgSB073039; Tue, 8 Jun 2004 00:29:42 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i580Tg7Q073038; Tue, 8 Jun 2004 00:29:42 GMT (envelope-from peter) Message-Id: <200406080029.i580Tg7Q073038@repoman.freebsd.org> From: Peter Wemm Date: Tue, 8 Jun 2004 00:29:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/amd64/include pmap.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 00:29:53 -0000 peter 2004-06-08 00:29:42 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/amd64/include pmap.h Log: Mask pte's with PG_FRAME before passing it to PHYS_TO_VM_PAGE().. PG_NX lives in the top 12 'available' bits. atop() in the PHYS_TO_VM_PAGE() macro only masks off the lower bits (by accident) and the upper bits in the 64 bit ptes turn into "interesting" index values. Revision Changes Path 1.464 +16 -16 src/sys/amd64/amd64/pmap.c 1.116 +1 -1 src/sys/amd64/include/pmap.h From owner-cvs-src@FreeBSD.ORG Tue Jun 8 01:02:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C26116A4CE; Tue, 8 Jun 2004 01:02:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 04BA543D4C; Tue, 8 Jun 2004 01:02:54 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5812rHm087215; Tue, 8 Jun 2004 01:02:53 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5812rek087214; Tue, 8 Jun 2004 01:02:53 GMT (envelope-from peter) Message-Id: <200406080102.i5812rek087214@repoman.freebsd.org> From: Peter Wemm Date: Tue, 8 Jun 2004 01:02:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 identcpu.c initcpu.c machdep.c mp_machdep.c mpboot.S pmap.c src/sys/amd64/include md_var.h pmap.h specialreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 01:02:54 -0000 peter 2004-06-08 01:02:53 UTC FreeBSD src repository Modified files: sys/amd64/amd64 identcpu.c initcpu.c machdep.c mp_machdep.c mpboot.S pmap.c sys/amd64/include md_var.h pmap.h specialreg.h Log: Initial PG_NX support (no-execute page bit) - export the rest of the cpu features (and amd's features). - turn on EFER_NXE, depending on the NX amd feature bit - reorg the identcpu stuff a bit in order to stop treating the amd features as second class features (since it is now a primary feature bit set) and make it easier to export. Revision Changes Path 1.133 +112 -124 src/sys/amd64/amd64/identcpu.c 1.48 +13 -13 src/sys/amd64/amd64/initcpu.c 1.608 +0 -7 src/sys/amd64/amd64/machdep.c 1.238 +2 -2 src/sys/amd64/amd64/mp_machdep.c 1.26 +0 -4 src/sys/amd64/amd64/mpboot.S 1.465 +2 -3 src/sys/amd64/amd64/pmap.c 1.74 +3 -1 src/sys/amd64/include/md_var.h 1.117 +3 -0 src/sys/amd64/include/pmap.h 1.30 +16 -0 src/sys/amd64/include/specialreg.h From owner-cvs-src@FreeBSD.ORG Tue Jun 8 01:07:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C296B16A4CE; Tue, 8 Jun 2004 01:07:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A402343D46; Tue, 8 Jun 2004 01:07:51 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5817pnZ088464; Tue, 8 Jun 2004 01:07:51 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5817pFW088463; Tue, 8 Jun 2004 01:07:51 GMT (envelope-from peter) Message-Id: <200406080107.i5817pFW088463@repoman.freebsd.org> From: Peter Wemm Date: Tue, 8 Jun 2004 01:07:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 01:07:51 -0000 peter 2004-06-08 01:07:51 UTC FreeBSD src repository Modified files: sys/amd64/amd64 mp_machdep.c Log: Set up the fpu *after* enabling SSE mode on AP's Submitted by: (argh, I can't find the email) Revision Changes Path 1.239 +3 -3 src/sys/amd64/amd64/mp_machdep.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 01:14:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBDCD16A4CE; Tue, 8 Jun 2004 01:14:39 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD62743D53; Tue, 8 Jun 2004 01:14:39 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i581EdR9090424; Tue, 8 Jun 2004 01:14:39 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i581EdgT090423; Tue, 8 Jun 2004 01:14:39 GMT (envelope-from peter) Message-Id: <200406080114.i581EdgT090423@repoman.freebsd.org> From: Peter Wemm Date: Tue, 8 Jun 2004 01:14:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 01:14:40 -0000 peter 2004-06-08 01:14:39 UTC FreeBSD src repository Modified files: sys/amd64/amd64 fpu.c Log: Reapply rev 1.151 after enable sse/fpuinit order fixed in mp_machdep.c Obtained from: das Revision Changes Path 1.152 +4 -0 src/sys/amd64/amd64/fpu.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 01:21:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4870016A4CE; Tue, 8 Jun 2004 01:21:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A38343D41; Tue, 8 Jun 2004 01:21:48 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i581KbUB090718; Tue, 8 Jun 2004 01:20:37 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i581KbHE090717; Tue, 8 Jun 2004 01:20:37 GMT (envelope-from peter) Message-Id: <200406080120.i581KbHE090717@repoman.freebsd.org> From: Peter Wemm Date: Tue, 8 Jun 2004 01:20:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 01:21:48 -0000 peter 2004-06-08 01:20:37 UTC FreeBSD src repository Modified files: sys/amd64/amd64 identcpu.c Log: Argh. Remove stray number that slipped into the previous commit. Revision Changes Path 1.134 +0 -1 src/sys/amd64/amd64/identcpu.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 01:35:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 554FC16A4D0; Tue, 8 Jun 2004 01:35:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3663D43D39; Tue, 8 Jun 2004 01:35:51 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i581ZmTb094641; Tue, 8 Jun 2004 01:35:48 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i581Zmaa094640; Tue, 8 Jun 2004 01:35:48 GMT (envelope-from peter) Message-Id: <200406080135.i581Zmaa094640@repoman.freebsd.org> From: Peter Wemm Date: Tue, 8 Jun 2004 01:35:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 01:35:52 -0000 peter 2004-06-08 01:35:48 UTC FreeBSD src repository Modified files: sys/amd64/amd64 fpu.c Log: Fix my silly typo in asm statement in previous commit. Revision Changes Path 1.153 +1 -1 src/sys/amd64/amd64/fpu.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 02:20:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CBAD016A4CE; Tue, 8 Jun 2004 02:20:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ACB9A43D1F; Tue, 8 Jun 2004 02:20:43 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i582KeRb004132; Tue, 8 Jun 2004 02:20:40 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i582KeDa004131; Tue, 8 Jun 2004 02:20:40 GMT (envelope-from peter) Message-Id: <200406080220.i582KeDa004131@repoman.freebsd.org> From: Peter Wemm Date: Tue, 8 Jun 2004 02:20:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 02:20:43 -0000 peter 2004-06-08 02:20:40 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c Log: In pmap_extract_and_hold(), there is no need to mask off PG_FRAME because pmap_extract() already does it. In pmap_enter(), opa has already been masked so don't do it again. Wrap a long line (recent transgression). Use trunc_page() in pmap_mapdev() instead of anding with PG_FRAME, since that is what we really meant. Submitted by: alc (first item) Revision Changes Path 1.466 +5 -4 src/sys/amd64/amd64/pmap.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 02:21:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9951116A4CE; Tue, 8 Jun 2004 02:21:30 +0000 (GMT) Received: from daintree.corp.yahoo.com (daintree.corp.yahoo.com [216.145.52.172]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85CA443D45; Tue, 8 Jun 2004 02:21:30 +0000 (GMT) (envelope-from peter@yahoo-inc.com) Received: by daintree.corp.yahoo.com (Postfix, from userid 2154) id 9A87E8826; Mon, 7 Jun 2004 19:21:23 -0700 (PDT) From: Peter Wemm To: Peter Wemm Date: Mon, 7 Jun 2004 19:21:23 -0700 User-Agent: KMail/1.6.1 References: <200406080107.i5817pFW088463@repoman.freebsd.org> In-Reply-To: <200406080107.i5817pFW088463@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406071921.23316.peter@wemm.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 02:21:30 -0000 On Monday 07 June 2004 06:07 pm, Peter Wemm wrote: > peter 2004-06-08 01:07:51 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 mp_machdep.c > Log: > Set up the fpu *after* enabling SSE mode on AP's > > Submitted by: (argh, I can't find the email) This of course was dwmalone. Sorry. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Tue Jun 8 02:43:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6DDF216A4CE; Tue, 8 Jun 2004 02:43:25 +0000 (GMT) Received: from VARK.homeunix.com (ar59.lsanca2-4.27.98.47.lsanca2.dsl-verizon.net [4.27.98.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18F6C43D55; Tue, 8 Jun 2004 02:43:25 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i582hNAO035638; Mon, 7 Jun 2004 19:43:24 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i582hNEP035637; Mon, 7 Jun 2004 19:43:23 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Mon, 7 Jun 2004 19:43:23 -0700 From: David Schultz To: Peter Wemm Message-ID: <20040608024323.GA35621@VARK.homeunix.com> Mail-Followup-To: Peter Wemm , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406080114.i581EdgT090423@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406080114.i581EdgT090423@repoman.freebsd.org> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 02:43:25 -0000 On Tue, Jun 08, 2004, Peter Wemm wrote: > peter 2004-06-08 01:14:39 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 fpu.c > Log: > Reapply rev 1.151 after enable sse/fpuinit order fixed in mp_machdep.c Thanks! From owner-cvs-src@FreeBSD.ORG Tue Jun 8 05:44:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 156D916A4CE; Tue, 8 Jun 2004 05:44:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6EE643D41; Tue, 8 Jun 2004 05:44:52 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i585iqGk055459; Tue, 8 Jun 2004 05:44:52 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i585iqYY055458; Tue, 8 Jun 2004 05:44:52 GMT (envelope-from das) Message-Id: <200406080544.i585iqYY055458@repoman.freebsd.org> From: David Schultz Date: Tue, 8 Jun 2004 05:44:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/stdio wsetup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 05:44:53 -0000 das 2004-06-08 05:44:52 UTC FreeBSD src repository Modified files: lib/libc/stdio wsetup.c Log: Set errno to EBADF on attempts to write to a stream that is not writable. Affected callers include fwrite(), put?(), and *printf(). The issue of whether this is the right errno for funopened streams is unresolved, but that's an obscure case, and some errno is better than no errno. Discussed with: bde, jkh Revision Changes Path 1.9 +5 -2 src/lib/libc/stdio/wsetup.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 05:45:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2E9716A4CE; Tue, 8 Jun 2004 05:45:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A31B643D31; Tue, 8 Jun 2004 05:45:33 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i585jWbD055598; Tue, 8 Jun 2004 05:45:32 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i585jWVA055597; Tue, 8 Jun 2004 05:45:32 GMT (envelope-from das) Message-Id: <200406080545.i585jWVA055597@repoman.freebsd.org> From: David Schultz Date: Tue, 8 Jun 2004 05:45:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/stdio local.h vfprintf.c vfwprintf.c wbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 05:45:34 -0000 das 2004-06-08 05:45:32 UTC FreeBSD src repository Modified files: lib/libc/stdio local.h vfprintf.c vfwprintf.c wbuf.c Log: Rename cantwrite() to prepwrite(). The latter is less confusing, since the macro isn't really a predicate, and it has side-effects. Revision Changes Path 1.25 +3 -2 src/lib/libc/stdio/local.h 1.66 +1 -1 src/lib/libc/stdio/vfprintf.c 1.21 +1 -1 src/lib/libc/stdio/vfwprintf.c 1.11 +1 -1 src/lib/libc/stdio/wbuf.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 05:45:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 85F1716A4CE; Tue, 8 Jun 2004 05:45:49 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6627743D4C; Tue, 8 Jun 2004 05:45:49 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i585jnME055646; Tue, 8 Jun 2004 05:45:49 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i585jnYc055645; Tue, 8 Jun 2004 05:45:49 GMT (envelope-from das) Message-Id: <200406080545.i585jnYc055645@repoman.freebsd.org> From: David Schultz Date: Tue, 8 Jun 2004 05:45:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/stdio fvwrite.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 05:45:49 -0000 das 2004-06-08 05:45:49 UTC FreeBSD src repository Modified files: lib/libc/stdio fvwrite.c Log: Rename cantwrite() to prepwrite(). The latter is less confusing, since the macro isn't really a predicate, and it has side-effects. Also, don't set errno if prepwrite() fails, since this is done in prepwrite() now. Revision Changes Path 1.17 +1 -4 src/lib/libc/stdio/fvwrite.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 06:23:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A27EB16A4CE; Tue, 8 Jun 2004 06:23:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AFD043D46; Tue, 8 Jun 2004 06:23:23 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i586NN00064832; Tue, 8 Jun 2004 06:23:23 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i586NNU9064831; Tue, 8 Jun 2004 06:23:23 GMT (envelope-from das) Message-Id: <200406080623.i586NNU9064831@repoman.freebsd.org> From: David Schultz Date: Tue, 8 Jun 2004 06:23:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/gen fts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 06:23:23 -0000 das 2004-06-08 06:23:23 UTC FreeBSD src repository Modified files: lib/libc/gen fts.c Log: In fts_build(), if we try to chdir and fail (e.g. due to lack of search permission), try to continue in FTS_DONTCHDIR mode. Of course this won't work for long paths, but we can't descend more than one pathname component beyond the directory anyway if we lack search permission. Here is a transcript demonstrating the change, where oldls is ls(1) linked with the old fts(3): das@VARK:~> mkdir t && touch t/{a,b,c} && chmod u-x t das@VARK:~> oldls t a b c das@VARK:~> oldls -l t das@VARK:~> \ls t a b c das@VARK:~> \ls -l t ls: a: Permission denied ls: b: Permission denied ls: c: Permission denied I had forgotten about this patch until bde reminded me. He reports using it without problems for over a year. PR: 45723 Revision Changes Path 1.27 +0 -2 src/lib/libc/gen/fts.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 08:48:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82C3616A4CE; Tue, 8 Jun 2004 08:48:49 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6614443D49; Tue, 8 Jun 2004 08:48:49 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i588mn9m002165; Tue, 8 Jun 2004 08:48:49 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i588mnRW002164; Tue, 8 Jun 2004 08:48:49 GMT (envelope-from yar) Message-Id: <200406080848.i588mnRW002164@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 8 Jun 2004 08:48:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man9 ifnet.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 08:48:49 -0000 yar 2004-06-08 08:48:49 UTC FreeBSD src repository Modified files: share/man/man9 ifnet.9 Log: Describe how polling(4) applies to network interfaces. Reviewed by: ru Revision Changes Path 1.40 +55 -2 src/share/man/man9/ifnet.9 From owner-cvs-src@FreeBSD.ORG Tue Jun 8 09:01:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B659D16A4CE; Tue, 8 Jun 2004 09:01:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99C4F43D5C; Tue, 8 Jun 2004 09:01:38 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5891c05004516; Tue, 8 Jun 2004 09:01:38 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5891cR1004502; Tue, 8 Jun 2004 09:01:38 GMT (envelope-from yar) Message-Id: <200406080901.i5891cR1004502@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 8 Jun 2004 09:01:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man9 ifnet.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 09:01:38 -0000 yar 2004-06-08 09:01:37 UTC FreeBSD src repository Modified files: share/man/man9 ifnet.9 Log: Make the legend to the table of interface flags compact for the reader's convenience. Suggested by: ru Revision Changes Path 1.41 +10 -8 src/share/man/man9/ifnet.9 From owner-cvs-src@FreeBSD.ORG Tue Jun 8 09:27:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89B4716A4CE; Tue, 8 Jun 2004 09:27:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6EA3B43D5A; Tue, 8 Jun 2004 09:27:43 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i589Rh05011189; Tue, 8 Jun 2004 09:27:43 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i589RhKx011188; Tue, 8 Jun 2004 09:27:43 GMT (envelope-from das) Message-Id: <200406080927.i589RhKx011188@repoman.freebsd.org> From: David Schultz Date: Tue, 8 Jun 2004 09:27:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/ls print.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 09:27:43 -0000 das 2004-06-08 09:27:43 UTC FreeBSD src repository Modified files: bin/ls print.c Log: Remove from the printfns the assumption that dp->list != NULL. Even if there are no entries, these functions may be called to print the total number of blocks (0) for consistency's sake. Revision Changes Path 1.73 +6 -2 src/bin/ls/print.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 09:30:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBDC416A4CE; Tue, 8 Jun 2004 09:30:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF21143D1F; Tue, 8 Jun 2004 09:30:13 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i589UAIH011345; Tue, 8 Jun 2004 09:30:10 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i589UAxB011344; Tue, 8 Jun 2004 09:30:10 GMT (envelope-from das) Message-Id: <200406080930.i589UAxB011344@repoman.freebsd.org> From: David Schultz Date: Tue, 8 Jun 2004 09:30:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/ls ls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 09:30:14 -0000 das 2004-06-08 09:30:10 UTC FreeBSD src repository Modified files: bin/ls ls.c Log: If we are asked to print the total number of blocks, do so even if we have no entries to print (either due to an empty directory or an error). This makes the -l and -s options more consistent, like Solaris and (Debian) Linux. To make this happen, tweak two optimizations on the second call to display(): - Don't skip display() altogether, even if list == NULL. - Don't skip the call to the printfn in display() if we need to print the total. PR: 45723 Revision Changes Path 1.78 +14 -12 src/bin/ls/ls.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 09:46:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CC4F16A4CE; Tue, 8 Jun 2004 09:46:16 +0000 (GMT) Received: from VARK.homeunix.com (ar59.lsanca2-4.27.98.47.lsanca2.dsl-verizon.net [4.27.98.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id F12C743D45; Tue, 8 Jun 2004 09:46:15 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i589kDpV057815; Tue, 8 Jun 2004 02:46:13 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i589kDWG057814; Tue, 8 Jun 2004 02:46:13 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Tue, 8 Jun 2004 02:46:13 -0700 From: David Schultz To: John Baldwin Message-ID: <20040608094613.GA57610@VARK.homeunix.com> Mail-Followup-To: John Baldwin , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406050313.i553Dd3q070600@repoman.freebsd.org> <200406070749.03027.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406070749.03027.jhb@FreeBSD.org> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/amd64/amd64 fpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 09:46:16 -0000 On Mon, Jun 07, 2004, John Baldwin wrote: > On Friday 04 June 2004 11:13 pm, David Schultz wrote: > > das 2004/06/04 20:13:39 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/amd64 fpu.c > > Log: > > Initialize the MXCSR to the appropriate default value at startup. > > > > Tested on: tjr > > FreeBSD/tjr? :) * No actual FreeBSD committers were panicked in the testing of this patch (but one got a little uneasy.) From owner-cvs-src@FreeBSD.ORG Tue Jun 8 09:54:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B916816A4CE; Tue, 8 Jun 2004 09:54:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DFB743D48; Tue, 8 Jun 2004 09:54:53 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i589srDv017429; Tue, 8 Jun 2004 09:54:53 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i589srlL017428; Tue, 8 Jun 2004 09:54:53 GMT (envelope-from yar) Message-Id: <200406080954.i589srlL017428@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 8 Jun 2004 09:54:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man9 ifnet.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 09:54:53 -0000 yar 2004-06-08 09:54:53 UTC FreeBSD src repository Modified files: share/man/man9 ifnet.9 Log: Touch .Dd (date) since new functionality has been documented. Reminded by: ru Revision Changes Path 1.42 +1 -1 src/share/man/man9/ifnet.9 From owner-cvs-src@FreeBSD.ORG Tue Jun 8 10:37:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7925816A4CE; Tue, 8 Jun 2004 10:37:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D11C43D31; Tue, 8 Jun 2004 10:37:35 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58AbVeV026828; Tue, 8 Jun 2004 10:37:31 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58AbUqG026827; Tue, 8 Jun 2004 10:37:30 GMT (envelope-from tjr) Message-Id: <200406081037.i58AbUqG026827@repoman.freebsd.org> From: "Tim J. Robbins" Date: Tue, 8 Jun 2004 10:37:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_exit.c src/sys/sys vmmeter.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 10:37:35 -0000 tjr 2004-06-08 10:37:30 UTC FreeBSD src repository Modified files: sys/kern kern_exit.c sys/sys vmmeter.h Log: Remove remnants of PGINPROF. Revision Changes Path 1.234 +0 -5 src/sys/kern/kern_exit.c 1.26 +0 -38 src/sys/sys/vmmeter.h From owner-cvs-src@FreeBSD.ORG Tue Jun 8 10:38:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E86716A4CE; Tue, 8 Jun 2004 10:38:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7283143D54; Tue, 8 Jun 2004 10:38:28 +0000 (GMT) (envelope-from rik@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58AcKNI026876; Tue, 8 Jun 2004 10:38:20 GMT (envelope-from rik@repoman.freebsd.org) Received: (from rik@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58AcKx2026875; Tue, 8 Jun 2004 10:38:20 GMT (envelope-from rik) Message-Id: <200406081038.i58AcKx2026875@repoman.freebsd.org> From: Roman Kurakin Date: Tue, 8 Jun 2004 10:38:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/cx if_cx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 10:38:28 -0000 rik 2004-06-08 10:38:20 UTC FreeBSD src repository Modified files: sys/dev/cx if_cx.c Log: 1. struct tty => struct tty *tty. Requested by: phk Revision Changes Path 1.17 +110 -95 src/sys/dev/cx/if_cx.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 11:58:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A433716A4CE; Tue, 8 Jun 2004 11:58:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8847543D41; Tue, 8 Jun 2004 11:58:35 +0000 (GMT) (envelope-from joerg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58BwZlX044232; Tue, 8 Jun 2004 11:58:35 GMT (envelope-from joerg@repoman.freebsd.org) Received: (from joerg@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58BwZPH044231; Tue, 8 Jun 2004 11:58:35 GMT (envelope-from joerg) Message-Id: <200406081158.i58BwZPH044231@repoman.freebsd.org> From: Joerg Wunsch Date: Tue, 8 Jun 2004 11:58:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/sab sab.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 11:58:35 -0000 joerg 2004-06-08 11:58:35 UTC FreeBSD src repository Modified files: sys/dev/sab sab.c Log: Implement the BREAK_TO_DEBUGGER option for sab(4). Revision Changes Path 1.29 +11 -0 src/sys/dev/sab/sab.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 12:04:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8057A16A4CE; Tue, 8 Jun 2004 12:04:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63E7743D58; Tue, 8 Jun 2004 12:04:31 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58C3mJp047094; Tue, 8 Jun 2004 12:03:48 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58C3mpB047093; Tue, 8 Jun 2004 12:03:48 GMT (envelope-from stefanf) Message-Id: <200406081203.i58C3mpB047093@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 8 Jun 2004 12:03:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/stdio vfprintf.c vfwprintf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 12:04:31 -0000 stefanf 2004-06-08 12:03:48 UTC FreeBSD src repository Modified files: lib/libc/stdio vfprintf.c vfwprintf.c Log: The third operand of the conditional operator should have type void too. Approved by: das (mentor) Revision Changes Path 1.67 +1 -1 src/lib/libc/stdio/vfprintf.c 1.22 +1 -1 src/lib/libc/stdio/vfwprintf.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 12:11:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B5EA16A4CE; Tue, 8 Jun 2004 12:11:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E439F43D46; Tue, 8 Jun 2004 12:11:27 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58CBJFF047606; Tue, 8 Jun 2004 12:11:19 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58CBJhi047579; Tue, 8 Jun 2004 12:11:19 GMT (envelope-from stefanf) Message-Id: <200406081211.i58CBJhi047579@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 8 Jun 2004 12:11:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/bootparamd/bootparamd main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 12:11:28 -0000 stefanf 2004-06-08 12:11:19 UTC FreeBSD src repository Modified files: usr.sbin/bootparamd/bootparamd main.c Log: - Don't use argv[i] when i is uninitialised. - Cast isdigit's argument to unsigned char. - Remove the now unused variable i. Approved by: das (mentor) Revision Changes Path 1.10 +2 -3 src/usr.sbin/bootparamd/bootparamd/main.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 12:21:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51ACF16A4CE; Tue, 8 Jun 2004 12:21:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34CCA43D60; Tue, 8 Jun 2004 12:21:05 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58CKenu049419; Tue, 8 Jun 2004 12:20:40 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58CKe6v049418; Tue, 8 Jun 2004 12:20:40 GMT (envelope-from stefanf) Message-Id: <200406081220.i58CKe6v049418@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 8 Jun 2004 12:20:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/stdtime localtime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 12:21:05 -0000 stefanf 2004-06-08 12:20:40 UTC FreeBSD src repository Modified files: lib/libc/stdtime localtime.c Log: Remove a couple of casts added for an ancient Sun compiler. Approved by: das (mentor) Revision Changes Path 1.37 +2 -11 src/lib/libc/stdtime/localtime.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 12:24:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FF4F16A4D0; Tue, 8 Jun 2004 12:24:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 243F343D58; Tue, 8 Jun 2004 12:24:48 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58COlNp051196; Tue, 8 Jun 2004 12:24:47 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58COlIH051195; Tue, 8 Jun 2004 12:24:47 GMT (envelope-from stefanf) Message-Id: <200406081224.i58COlIH051195@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 8 Jun 2004 12:24:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libvgl main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 12:24:48 -0000 stefanf 2004-06-08 12:24:47 UTC FreeBSD src repository Modified files: lib/libvgl main.c Log: Signal handlers are supposed to take an int parameter. Approved by: das (mentor) Revision Changes Path 1.15 +2 -2 src/lib/libvgl/main.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 13:08:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4648616A4CE; Tue, 8 Jun 2004 13:08:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A7CD43D41; Tue, 8 Jun 2004 13:08:33 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58D8J4o066748; Tue, 8 Jun 2004 13:08:19 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58D8Jvu066747; Tue, 8 Jun 2004 13:08:19 GMT (envelope-from stefanf) Message-Id: <200406081308.i58D8Jvu066747@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 8 Jun 2004 13:08:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_socket.c src/sys/ufs/ffs ffs_snapshot.c src/usr.sbin/arp arp.c src/lib/libkvm kvm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 13:08:33 -0000 stefanf 2004-06-08 13:08:19 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c sys/ufs/ffs ffs_snapshot.c usr.sbin/arp arp.c lib/libkvm kvm.c Log: Avoid assignments to cast expressions. Reviewed by: md5 Approved by: das (mentor) Revision Changes Path 1.26 +3 -3 src/lib/libkvm/kvm.c 1.175 +2 -2 src/sys/kern/uipc_socket.c 1.80 +2 -2 src/sys/ufs/ffs/ffs_snapshot.c 1.51 +1 -1 src/usr.sbin/arp/arp.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 13:15:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54D4816A4CE; Tue, 8 Jun 2004 13:15:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 397F843D1F; Tue, 8 Jun 2004 13:15:02 +0000 (GMT) (envelope-from hmp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58DF2sp068716; Tue, 8 Jun 2004 13:15:02 GMT (envelope-from hmp@repoman.freebsd.org) Received: (from hmp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58DF1Q3068715; Tue, 8 Jun 2004 13:15:01 GMT (envelope-from hmp) Message-Id: <200406081315.i58DF1Q3068715@repoman.freebsd.org> From: Hiten Pandya Date: Tue, 8 Jun 2004 13:15:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/lib/libc/stdio fclose.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 13:15:02 -0000 hmp 2004-06-08 13:15:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) lib/libc/stdio fclose.c Log: Move the call to FUNLOCKFILE(fp) after modification of the fp's fields. Reviewed by: Daniel Eischen , Robert Watson Revision Changes Path 1.8.2.1 +2 -2 src/lib/libc/stdio/fclose.c From owner-cvs-src@FreeBSD.ORG Tue Jun 8 13:46:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6249616A4CE; Tue, 8 Jun 2004 13:46:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 44EC643D1F; Tue, 8 Jun 2004 13:46:32 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58DkWEV075043; Tue, 8 Jun 2004 13:46:32 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58DkW9u075042; Tue, 8 Jun 2004 13:46:32 GMT (envelope-from stefanf) Message-Id: <200406081346.i58DkW9u075042@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 8 Jun 2004 13:46:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_ioctl.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 13:46:32 -0000 stefanf 2004-06-08 13:46:31 UTC FreeBSD src repository Modified files: sys/netatm atm_ioctl.h Log: Remove an #if section originally written for Sun compilers. Revision Changes Path 1.9 +0 -8 src/sys/netatm/atm_ioctl.h From owner-cvs-src@FreeBSD.ORG Tue Jun 8 14:53:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 115C816A4CE; Tue, 8 Jun 2004 14:53:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E6BC443D49; Tue, 8 Jun 2004 14:53:02 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58EqtIC090426; Tue, 8 Jun 2004 14:52:55 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58EqtFd090425; Tue, 8 Jun 2004 14:52:55 GMT (envelope-from csjp) Message-Id: <200406081452.i58EqtFd090425@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Tue, 8 Jun 2004 14:52:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/adduser rmuser.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 14:53:03 -0000 csjp 2004-06-08 14:52:55 UTC FreeBSD src repository Modified files: usr.sbin/adduser rmuser.8 Log: Add note that rmuser will clean up any IPC mechanisms owned by the user. Approved by: bmilekic (mentor) Revision Changes Path 1.23 +3 -0 src/usr.sbin/adduser/rmuser.8 From owner-cvs-src@FreeBSD.ORG Tue Jun 8 17:36:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 00B5016A4CE; Tue, 8 Jun 2004 17:36:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D64EE43D54; Tue, 8 Jun 2004 17:36:17 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58HaHX1031660; Tue, 8 Jun 2004 17:36:17 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58HaHl7031659; Tue, 8 Jun 2004 17:36:17 GMT (envelope-from brueffer) Message-Id: <200406081736.i58HaHl7031659@repoman.freebsd.org> From: Christian Brueffer Date: Tue, 8 Jun 2004 17:36:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 bge.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 17:36:18 -0000 brueffer 2004-06-08 17:36:17 UTC FreeBSD src repository (doc committer) Modified files: share/man/man4 bge.4 Log: Fix typo Obtained from: DragonFly BSD MFC after: 3 days Revision Changes Path 1.11 +1 -1 src/share/man/man4/bge.4 From owner-cvs-src@FreeBSD.ORG Tue Jun 8 19:53:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4D4C16A4CE; Tue, 8 Jun 2004 19:53:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95FDD43D1F; Tue, 8 Jun 2004 19:53:25 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58JrPp7061598; Tue, 8 Jun 2004 19:53:25 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58JrP00061597; Tue, 8 Jun 2004 19:53:25 GMT (envelope-from obrien) Message-Id: <200406081953.i58JrP00061597@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 8 Jun 2004 19:53:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d preseedrandom X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 19:53:25 -0000 obrien 2004-06-08 19:53:25 UTC FreeBSD src repository Modified files: etc/rc.d preseedrandom Log: Back out rev 1.3. This is one of the few RC scripts that doesn't use rc.subr, and thus doesn't source rc.conf. :-( Revision Changes Path 1.4 +1 -1 src/etc/rc.d/preseedrandom From owner-cvs-src@FreeBSD.ORG Tue Jun 8 20:24:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7116316A4CE; Tue, 8 Jun 2004 20:24:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 524CA43D2D; Tue, 8 Jun 2004 20:24:36 +0000 (GMT) (envelope-from alfred@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58KOack068643; Tue, 8 Jun 2004 20:24:36 GMT (envelope-from alfred@repoman.freebsd.org) Received: (from alfred@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58KOaMl068642; Tue, 8 Jun 2004 20:24:36 GMT (envelope-from alfred) Message-Id: <200406082024.i58KOaMl068642@repoman.freebsd.org> From: Alfred Perlstein Date: Tue, 8 Jun 2004 20:24:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: CVSROOT modules X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 20:24:36 -0000 alfred 2004-06-08 20:24:36 UTC FreeBSD src repository Modified files: . modules Log: idmapd -> sbin/idmapd Revision Changes Path 1.6854 +1 -0 CVSROOT/modules From owner-cvs-src@FreeBSD.ORG Tue Jun 8 21:16:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0FF916A4CE; Tue, 8 Jun 2004 21:16:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB41243D46; Tue, 8 Jun 2004 21:16:42 +0000 (GMT) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58LGg6E086151; Tue, 8 Jun 2004 21:16:42 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58LGg2M086150; Tue, 8 Jun 2004 21:16:42 GMT (envelope-from dwmalone) Message-Id: <200406082116.i58LGg2M086150@repoman.freebsd.org> From: David Malone Date: Tue, 8 Jun 2004 21:16:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/net bpf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 21:16:43 -0000 dwmalone 2004-06-08 21:16:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/net bpf.h Log: MFC: Make the comment for DLT_NULL slightly more accurate. Revision Changes Path 1.21.2.5 +1 -1 src/sys/net/bpf.h From owner-cvs-src@FreeBSD.ORG Tue Jun 8 23:52:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26D8D16A4CE; Tue, 8 Jun 2004 23:52:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09E2F43D53; Tue, 8 Jun 2004 23:52:23 +0000 (GMT) (envelope-from darrenr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i58NqMSP020621; Tue, 8 Jun 2004 23:52:22 GMT (envelope-from darrenr@repoman.freebsd.org) Received: (from darrenr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i58NqM2Q020617; Tue, 8 Jun 2004 23:52:22 GMT (envelope-from darrenr) Message-Id: <200406082352.i58NqM2Q020617@repoman.freebsd.org> From: Darren Reed Date: Tue, 8 Jun 2004 23:52:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/contrib/ipfilter/netinet ip_compat.h src/sys/modules/ipfilter Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 23:52:23 -0000 darrenr 2004-06-08 23:52:22 UTC FreeBSD src repository Modified files: sys/contrib/ipfilter/netinet ip_compat.h sys/modules/ipfilter Makefile Log: Recognise NOINET6 as an indication to not build IPv6 enabled source even if FreeBSD header files, etc, support it. Submitted by: Sergey Mokryshev Revision Changes Path 1.22 +2 -1 src/sys/contrib/ipfilter/netinet/ip_compat.h 1.14 +2 -1 src/sys/modules/ipfilter/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jun 9 00:25:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9371716A4CE; Wed, 9 Jun 2004 00:25:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 741C443D46; Wed, 9 Jun 2004 00:25:45 +0000 (GMT) (envelope-from naddy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i590PjVm027827; Wed, 9 Jun 2004 00:25:45 GMT (envelope-from naddy@repoman.freebsd.org) Received: (from naddy@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i590PjS6027826; Wed, 9 Jun 2004 00:25:45 GMT (envelope-from naddy) Message-Id: <200406090025.i590PjS6027826@repoman.freebsd.org> From: Christian Weisgerber Date: Wed, 9 Jun 2004 00:25:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb if_udav.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 00:25:45 -0000 naddy 2004-06-09 00:25:45 UTC FreeBSD src repository (ports committer) Modified files: sys/dev/usb if_udav.c Log: * Fix multicast reception. * Replace handrolled crc calculation with ether_crc32_le(). Based on: PR: 67544 Submitted by: HASHI Hiroaki Revision Changes Path 1.5 +10 -28 src/sys/dev/usb/if_udav.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 00:30:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3426716A4CE; Wed, 9 Jun 2004 00:30:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 170F943D31; Wed, 9 Jun 2004 00:30:12 +0000 (GMT) (envelope-from naddy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i590UB48028014; Wed, 9 Jun 2004 00:30:11 GMT (envelope-from naddy@repoman.freebsd.org) Received: (from naddy@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i590UB3P028013; Wed, 9 Jun 2004 00:30:11 GMT (envelope-from naddy) Message-Id: <200406090030.i590UB3P028013@repoman.freebsd.org> From: Christian Weisgerber Date: Wed, 9 Jun 2004 00:30:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/xe if_xe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 00:30:12 -0000 naddy 2004-06-09 00:30:11 UTC FreeBSD src repository (ports committer) Modified files: sys/dev/xe if_xe.c Log: Replace convoluted and broken CRC calcuation with ether_crc32_le(). This should fix multicast reception. Revision Changes Path 1.51 +6 -41 src/sys/dev/xe/if_xe.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 02:48:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48D5516A4CE; Wed, 9 Jun 2004 02:48:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4303043D2F; Wed, 9 Jun 2004 02:48:24 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i592mOmx063931; Wed, 9 Jun 2004 02:48:24 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i592mOfX063930; Wed, 9 Jun 2004 02:48:24 GMT (envelope-from rwatson) Message-Id: <200406090248.i592mOfX063930@repoman.freebsd.org> From: Robert Watson Date: Wed, 9 Jun 2004 02:48:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys mbuf.h src/sys/net netisr.h rtsock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 02:48:24 -0000 rwatson 2004-06-09 02:48:23 UTC FreeBSD src repository Modified files: sys/sys mbuf.h sys/net netisr.h rtsock.c Log: Introduce a netisr to deliver kernel-generated routing, avoiding recursive entering of the socket code from the routing code: - Modify rt_dispatch() to bundle up the sockaddr family, if any, associated with a pending mbuf to dispatch to routing sockets, in an m_tag on the mbuf. - Allocate NETISR_ROUTE for use by routing sockets. - Introduce rtsintrq, an ifqueue to be used by the netisr, and introduce rts_input(), a function to unbundle the tagged sockaddr and inject the mbuf and address into raw_input(), which previously occurred in rt_dispatch(). - Introduce rts_init() to initialize rtsintrq, its mutex, and register the netisr. Perform this at the same point in system initialization as setup of the domains. This change introduces asynchrony between the generation of a pending routing socket message and delivery to sockets for use by userspace. It avoids socket->routing->rtsock->socket use and helps to avoid lock order reversals between the routing code and socket code (in particular, raw socket control blocks), as route locks are held over calls to rt_dispatch(). Reviewed by: "George V.Neville-Neil" Conceptual head nod by: sam Revision Changes Path 1.32 +1 -0 src/sys/net/netisr.h 1.111 +52 -4 src/sys/net/rtsock.c 1.149 +1 -0 src/sys/sys/mbuf.h From owner-cvs-src@FreeBSD.ORG Wed Jun 9 06:31:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D9C216A4CE; Wed, 9 Jun 2004 06:31:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 800CA43D49; Wed, 9 Jun 2004 06:31:40 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i596VeDi020715; Wed, 9 Jun 2004 06:31:40 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i596Vene020711; Wed, 9 Jun 2004 06:31:40 GMT (envelope-from imp) Message-Id: <200406090631.i596Vene020711@repoman.freebsd.org> From: Warner Losh Date: Wed, 9 Jun 2004 06:31:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/wi if_wi_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 06:31:40 -0000 imp 2004-06-09 06:31:40 UTC FreeBSD src repository Modified files: sys/dev/wi if_wi_pccard.c Log: Only match cards that claim to be network cards. I've had two different cards that matched vendor/id, but weren't wi cards. This is because the vendor foolishly didn't have unique product ids. Symbol has a serial card that would otherwise match the wi driver, for example... Taken from a patch for xe posted by: Carlos Velasco Revision Changes Path 1.47 +10 -0 src/sys/dev/wi/if_wi_pccard.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 07:56:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 192C216A4CE; Wed, 9 Jun 2004 07:56:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEA2543D49; Wed, 9 Jun 2004 07:56:35 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i597uJbw038975; Wed, 9 Jun 2004 07:56:19 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i597uJka038974; Wed, 9 Jun 2004 07:56:19 GMT (envelope-from das) Message-Id: <200406090756.i597uJka038974@repoman.freebsd.org> From: David Schultz Date: Wed, 9 Jun 2004 07:56:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 07:56:36 -0000 das 2004-06-09 07:56:18 UTC FreeBSD src repository Modified files: . access Log: stefanf is no longer under mentorship in src. He has been a great mentee, and now joins us as a full-fledged mental. (forced commit) Revision Changes Path 1.667 +0 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Wed Jun 9 08:27:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3769116A4CE; Wed, 9 Jun 2004 08:27:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19C3843D2F; Wed, 9 Jun 2004 08:27:41 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i598R6u8046324; Wed, 9 Jun 2004 08:27:06 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i598R6TX046323; Wed, 9 Jun 2004 08:27:06 GMT (envelope-from obrien) Message-Id: <200406090827.i598R6TX046323@repoman.freebsd.org> From: "David E. O'Brien" Date: Wed, 9 Jun 2004 08:27:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules/em Makefile src/sys/modules/ixgb Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 08:27:41 -0000 obrien 2004-06-09 08:27:05 UTC FreeBSD src repository Modified files: sys/modules/em Makefile sys/modules/ixgb Makefile Log: style.Makefile(5) Revision Changes Path 1.4 +6 -4 src/sys/modules/em/Makefile 1.2 +6 -8 src/sys/modules/ixgb/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jun 9 09:09:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94F5316A4CE; Wed, 9 Jun 2004 09:09:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 790DB43D55; Wed, 9 Jun 2004 09:09:54 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5999ss3061653; Wed, 9 Jun 2004 09:09:54 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5999sdl061652; Wed, 9 Jun 2004 09:09:54 GMT (envelope-from phk) Message-Id: <200406090909.i5999sdl061652@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 9 Jun 2004 09:09:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys tty.h src/sys/kern tty_pty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 09:09:54 -0000 phk 2004-06-09 09:09:54 UTC FreeBSD src repository Modified files: sys/sys tty.h sys/kern tty_pty.c Log: Move PTY private defines into PTY private files. Revision Changes Path 1.120 +4 -0 src/sys/kern/tty_pty.c 1.78 +0 -3 src/sys/sys/tty.h From owner-cvs-src@FreeBSD.ORG Wed Jun 9 09:29:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F43516A4CE; Wed, 9 Jun 2004 09:29:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3291743D2F; Wed, 9 Jun 2004 09:29:09 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i599T9rT065945; Wed, 9 Jun 2004 09:29:09 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i599T8h6065944; Wed, 9 Jun 2004 09:29:08 GMT (envelope-from phk) Message-Id: <200406090929.i599T8h6065944@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 9 Jun 2004 09:29:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 09:29:09 -0000 phk 2004-06-09 09:29:08 UTC FreeBSD src repository Modified files: sys/kern kern_proc.c Log: Fix a race in destruction of sessions. Revision Changes Path 1.204 +3 -2 src/sys/kern/kern_proc.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 09:33:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0769A16A4CE; Wed, 9 Jun 2004 09:33:08 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3672C43D1D; Wed, 9 Jun 2004 09:33:07 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i599X5Jq053419; Wed, 9 Jun 2004 11:33:05 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 09:29:08 -0000." <200406090929.i599T8h6065944@repoman.freebsd.org> Date: Wed, 09 Jun 2004 11:33:05 +0200 Message-ID: <53418.1086773585@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 09:33:08 -0000 In message <200406090929.i599T8h6065944@repoman.freebsd.org>, Poul-Henning Kamp writes: > > Modified files: > sys/kern kern_proc.c > Log: > Fix a race in destruction of sessions. Not to pick on anybody, but this is a perfect example of getting locking almost right: BAD: LOCK(foo->lock) foo->refcount--; UNLOCK(foo->lock) if (foo->refcount == 0) destroy(foo); GOOD: LOCK(foo->lock) i = --foo->refcount; UNLOCK(foo->lock) if (i == 0) destroy(foo); -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 09:42:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CC7C16A4CE; Wed, 9 Jun 2004 09:42:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DF3143D60; Wed, 9 Jun 2004 09:42:04 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i599fVXV068888; Wed, 9 Jun 2004 09:41:31 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i599fUbQ068884; Wed, 9 Jun 2004 09:41:30 GMT (envelope-from phk) Message-Id: <200406090941.i599fUbQ068884@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 9 Jun 2004 09:41:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys tty.h src/sys/kern kern_proc.c tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 09:42:04 -0000 phk 2004-06-09 09:41:30 UTC FreeBSD src repository Modified files: sys/sys tty.h sys/kern kern_proc.c tty.c Log: Reference count struct tty. Add two new functions: ttyref() and ttyrel(). ttymalloc() creates a struct tty with a reference count of one. when ttyrel sees the count go to zero, struct tty is freed. Hold references for open ttys and for ttys which are controlling terminal for sessions. Until drivers start using ttyrel(), this commit will make no difference. Revision Changes Path 1.205 +3 -1 src/sys/kern/kern_proc.c 1.217 +93 -21 src/sys/kern/tty.c 1.79 +8 -2 src/sys/sys/tty.h From owner-cvs-src@FreeBSD.ORG Wed Jun 9 10:16:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B104116A4CE; Wed, 9 Jun 2004 10:16:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C78743D53; Wed, 9 Jun 2004 10:16:23 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59AGExR076995; Wed, 9 Jun 2004 10:16:14 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59AGEtf076994; Wed, 9 Jun 2004 10:16:14 GMT (envelope-from phk) Message-Id: <200406091016.i59AGEtf076994@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 9 Jun 2004 10:16:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern tty_pty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 10:16:23 -0000 phk 2004-06-09 10:16:14 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Ditch K&R function style Revision Changes Path 1.121 +15 -63 src/sys/kern/tty_pty.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 10:21:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9375F16A4CE; Wed, 9 Jun 2004 10:21:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 772B243D41; Wed, 9 Jun 2004 10:21:56 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59ALrgm078289; Wed, 9 Jun 2004 10:21:53 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59ALrA7078288; Wed, 9 Jun 2004 10:21:53 GMT (envelope-from phk) Message-Id: <200406091021.i59ALrA7078288@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 9 Jun 2004 10:21:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern tty_pty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 10:21:56 -0000 phk 2004-06-09 10:21:53 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Rename struct pt_ioctl to "ptsc" and pointers to it from "pti" to "pt" Revision Changes Path 1.122 +65 -65 src/sys/kern/tty_pty.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 10:32:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B9D916A4CE; Wed, 9 Jun 2004 10:32:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CE1943D45; Wed, 9 Jun 2004 10:32:13 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59AW5ha080850; Wed, 9 Jun 2004 10:32:05 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59AW5aD080849; Wed, 9 Jun 2004 10:32:05 GMT (envelope-from das) Message-Id: <200406091032.i59AW5aD080849@repoman.freebsd.org> From: David Schultz Date: Wed, 9 Jun 2004 10:32:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/src math.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 10:32:13 -0000 das 2004-06-09 10:32:05 UTC FreeBSD src repository Modified files: lib/msun/src math.h Log: Include earlier to get the various visibility constants. Previously, we were relying on to include it implicitly. Revision Changes Path 1.34 +1 -2 src/lib/msun/src/math.h From owner-cvs-src@FreeBSD.ORG Wed Jun 9 10:56:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 672C016A4CE; Wed, 9 Jun 2004 10:56:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4A19F43D41; Wed, 9 Jun 2004 10:56:33 +0000 (GMT) (envelope-from den@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59AuWmM085249; Wed, 9 Jun 2004 10:56:32 GMT (envelope-from den@repoman.freebsd.org) Received: (from den@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59AuWZ5085248; Wed, 9 Jun 2004 10:56:32 GMT (envelope-from den) Message-Id: <200406091056.i59AuWZ5085248@repoman.freebsd.org> From: Denis Peplin Date: Wed, 9 Jun 2004 10:56:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/doc/en_US.ISO8859-1/installation/common artheader.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 10:56:33 -0000 den 2004-06-09 10:56:32 UTC FreeBSD src repository (doc committer) Modified files: release/doc/en_US.ISO8859-1/installation/common artheader.sgml Log: Update copyright years. Revision Changes Path 1.5 +1 -0 src/release/doc/en_US.ISO8859-1/installation/common/artheader.sgml From owner-cvs-src@FreeBSD.ORG Wed Jun 9 11:24:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1EDE116A4CE; Wed, 9 Jun 2004 11:24:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 023E043D41; Wed, 9 Jun 2004 11:24:01 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59BO0D7092150; Wed, 9 Jun 2004 11:24:00 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59BO06q092149; Wed, 9 Jun 2004 11:24:00 GMT (envelope-from le) Message-Id: <200406091124.i59BO06q092149@repoman.freebsd.org> From: Lukas Ertl Date: Wed, 9 Jun 2004 11:24:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/bin/ls ls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 11:24:01 -0000 le 2004-06-09 11:24:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) bin/ls ls.c Log: MFC 1.77: Plug small memory leak. Revision Changes Path 1.32.2.9 +1 -0 src/bin/ls/ls.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 12:21:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2BD116A4CE; Wed, 9 Jun 2004 12:21:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 840EF43D31; Wed, 9 Jun 2004 12:21:00 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59CKijH003972; Wed, 9 Jun 2004 12:20:44 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59CKidl003971; Wed, 9 Jun 2004 12:20:44 GMT (envelope-from phk) Message-Id: <200406091220.i59CKidl003971@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 9 Jun 2004 12:20:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/pstat pstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 12:21:00 -0000 phk 2004-06-09 12:20:44 UTC FreeBSD src repository Modified files: usr.sbin/pstat pstat.c Log: Update kvm mode to match kernel changes. Revision Changes Path 1.90 +3 -3 src/usr.sbin/pstat/pstat.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 12:46:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99C5316A4CE; Wed, 9 Jun 2004 12:46:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C7C643D1F; Wed, 9 Jun 2004 12:46:08 +0000 (GMT) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59CjpfK010193; Wed, 9 Jun 2004 12:45:51 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59CjpSj010192; Wed, 9 Jun 2004 12:45:51 GMT (envelope-from dwmalone) Message-Id: <200406091245.i59CjpSj010192@repoman.freebsd.org> From: David Malone Date: Wed, 9 Jun 2004 12:45:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/traceroute6 traceroute6.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 12:46:08 -0000 dwmalone 2004-06-09 12:45:51 UTC FreeBSD src repository Modified files: usr.sbin/traceroute6 traceroute6.8 Log: Add some more details about what traceroute6 does. Submitted by: Orla McGann Obtained from: KAME MFC after: 2 weeks Revision Changes Path 1.12 +40 -3 src/usr.sbin/traceroute6/traceroute6.8 From owner-cvs-src@FreeBSD.ORG Wed Jun 9 14:07:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B25716A4CE; Wed, 9 Jun 2004 14:07:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E157B43D2D; Wed, 9 Jun 2004 14:07:08 +0000 (GMT) (envelope-from jmallett@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59E6icP034275; Wed, 9 Jun 2004 14:06:44 GMT (envelope-from jmallett@repoman.freebsd.org) Received: (from jmallett@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59E6iUq034274; Wed, 9 Jun 2004 14:06:44 GMT (envelope-from jmallett) Message-Id: <200406091406.i59E6iUq034274@repoman.freebsd.org> From: Juli Mallett Date: Wed, 9 Jun 2004 14:06:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 14:07:09 -0000 jmallett 2004-06-09 14:06:44 UTC FreeBSD src repository Modified files: sys/kern kern_thread.c Log: Add a comment explaining td_critnest's initial state and its life from that point on, as it happens relatively indirectly, and in a codepath the casual reader may not be acquainted with or find obvious. Glanced at by: jhb Revision Changes Path 1.180 +13 -0 src/sys/kern/kern_thread.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 14:34:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 226BE16A4CE; Wed, 9 Jun 2004 14:34:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03A4A43D31; Wed, 9 Jun 2004 14:34:15 +0000 (GMT) (envelope-from naddy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59EY43V040509; Wed, 9 Jun 2004 14:34:04 GMT (envelope-from naddy@repoman.freebsd.org) Received: (from naddy@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59EY4to040508; Wed, 9 Jun 2004 14:34:04 GMT (envelope-from naddy) Message-Id: <200406091434.i59EY4to040508@repoman.freebsd.org> From: Christian Weisgerber Date: Wed, 9 Jun 2004 14:34:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bge if_bge.c src/sys/dev/ed if_ed.c src/sys/dev/fe if_fe.c src/sys/dev/gem if_gem.c src/sys/dev/hme if_hme.c src/sys/dev/lge if_lge.c src/sys/dev/lnc if_lnc.c src/sys/dev/my if_my.c src/sys/dev/nge if_nge.c src/sys/dev/re ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 14:34:15 -0000 naddy 2004-06-09 14:34:04 UTC FreeBSD src repository (ports committer) Modified files: sys/dev/bge if_bge.c sys/dev/ed if_ed.c sys/dev/fe if_fe.c sys/dev/gem if_gem.c sys/dev/hme if_hme.c sys/dev/lge if_lge.c sys/dev/lnc if_lnc.c sys/dev/my if_my.c sys/dev/nge if_nge.c sys/dev/re if_re.c sys/dev/sn if_sn.c sys/dev/tx if_tx.c sys/dev/usb if_aue.c if_axe.c if_cue.c if_rue.c sys/pci if_dc.c if_de.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_vr.c if_wb.c if_xl.c Log: Replace handrolled CRC calculation with ether_crc32_[lb]e(). Revision Changes Path 1.70 +2 -23 src/sys/dev/bge/if_bge.c 1.232 +2 -28 src/sys/dev/ed/if_ed.c 1.85 +2 -24 src/sys/dev/fe/if_fe.c 1.25 +2 -18 src/sys/dev/gem/if_gem.c 1.25 +2 -18 src/sys/dev/hme/if_hme.c 1.32 +2 -28 src/sys/dev/lge/if_lge.c 1.108 +2 -20 src/sys/dev/lnc/if_lnc.c 1.26 +2 -30 src/sys/dev/my/if_my.c 1.63 +2 -29 src/sys/dev/nge/if_nge.c 1.25 +2 -29 src/sys/dev/re/if_re.c 1.41 +2 -22 src/sys/dev/sn/if_sn.c 1.85 +2 -28 src/sys/dev/tx/if_tx.c 1.84 +2 -21 src/sys/dev/usb/if_aue.c 1.18 +2 -25 src/sys/dev/usb/if_axe.c 1.50 +1 -9 src/sys/dev/usb/if_cue.c 1.14 +2 -29 src/sys/dev/usb/if_rue.c 1.145 +3 -23 src/sys/pci/if_dc.c 1.154 +2 -23 src/sys/pci/if_de.c 1.58 +2 -23 src/sys/pci/if_pcn.c 1.139 +2 -29 src/sys/pci/if_rl.c 1.69 +2 -27 src/sys/pci/if_sf.c 1.101 +2 -13 src/sys/pci/if_sis.c 1.82 +3 -23 src/sys/pci/if_sk.c 1.75 +2 -29 src/sys/pci/if_ste.c 1.85 +2 -29 src/sys/pci/if_vr.c 1.72 +2 -32 src/sys/pci/if_wb.c 1.171 +14 -40 src/sys/pci/if_xl.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 14:53:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 815EA16A502; Wed, 9 Jun 2004 14:53:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E93643D5D; Wed, 9 Jun 2004 14:53:36 +0000 (GMT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59ErZXD044657; Wed, 9 Jun 2004 14:53:35 GMT (envelope-from mux@repoman.freebsd.org) Received: (from mux@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59ErZXZ044656; Wed, 9 Jun 2004 14:53:35 GMT (envelope-from mux) Message-Id: <200406091453.i59ErZXZ044656@repoman.freebsd.org> From: Maxime Henrion Date: Wed, 9 Jun 2004 14:53:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_mbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 14:53:36 -0000 mux 2004-06-09 14:53:35 UTC FreeBSD src repository Modified files: sys/kern uipc_mbuf.c Log: Fix a panic happening when m_getm() is called with len < MCLBYTES. Reported by: ale Tested by: ale Reviewed by: bosko Revision Changes Path 1.131 +1 -1 src/sys/kern/uipc_mbuf.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 15:40:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C87F16A4CE; Wed, 9 Jun 2004 15:40:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F55943D1F; Wed, 9 Jun 2004 15:40:00 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59Fe0tt053866; Wed, 9 Jun 2004 15:40:00 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59Fe0uD053865; Wed, 9 Jun 2004 15:40:00 GMT (envelope-from le) Message-Id: <200406091540.i59Fe0uD053865@repoman.freebsd.org> From: Lukas Ertl Date: Wed, 9 Jun 2004 15:40:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/examples/kld/cdev/module cdev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 15:40:00 -0000 le 2004-06-09 15:40:00 UTC FreeBSD src repository Modified files: share/examples/kld/cdev/module cdev.c Log: Remove duplicate #include. PR: misc/67748 Submitted by: bugghy Revision Changes Path 1.6 +0 -1 src/share/examples/kld/cdev/module/cdev.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:02:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6FCF916A4CE; Wed, 9 Jun 2004 16:02:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52FC543D31; Wed, 9 Jun 2004 16:02:13 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59G20Sh059054; Wed, 9 Jun 2004 16:02:00 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59G20VP059053; Wed, 9 Jun 2004 16:02:00 GMT (envelope-from wpaul) Message-Id: <200406091602.i59G20VP059053@repoman.freebsd.org> From: Bill Paul Date: Wed, 9 Jun 2004 16:02:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:02:13 -0000 wpaul 2004-06-09 16:02:00 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Add some special case code to fix a problem with the BCM5704 in TBI (fiber) mode. The 5704 apparently has some s00p3r s33kr1t registers for setting the advertisement of pause frame ability (i.e flow control) when in autoneg mode. If we don't set these registers correctly, we may not be able to negotiate a proper link with some switches. (Symptom is that the NIC reports the link as up (PCS synched) but no traffic can be exchanged.) PR: kern/67598 Revision Changes Path 1.71 +33 -0 src/sys/dev/bge/if_bge.c 1.28 +38 -0 src/sys/dev/bge/if_bgereg.h From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:05:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C6DA16A4CE; Wed, 9 Jun 2004 16:05:42 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0ADE43D1D; Wed, 9 Jun 2004 16:05:41 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i59G3wlX043876; Wed, 9 Jun 2004 10:03:58 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 09 Jun 2004 10:04:13 -0600 (MDT) Message-Id: <20040609.100413.118633043.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <53418.1086773585@critter.freebsd.dk> References: <200406090929.i599T8h6065944@repoman.freebsd.org> <53418.1086773585@critter.freebsd.dk> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:05:42 -0000 In message: <53418.1086773585@critter.freebsd.dk> "Poul-Henning Kamp" writes: : In message <200406090929.i599T8h6065944@repoman.freebsd.org>, Poul-Henning Kamp : writes: : > : > Modified files: : > sys/kern kern_proc.c : > Log: : > Fix a race in destruction of sessions. : : Not to pick on anybody, but this is a perfect example of getting locking : almost right: : : BAD: : : LOCK(foo->lock) : foo->refcount--; : UNLOCK(foo->lock) : if (foo->refcount == 0) : destroy(foo); : : GOOD: : : LOCK(foo->lock) : i = --foo->refcount; : UNLOCK(foo->lock) : if (i == 0) : destroy(foo); : Can you provide a couple of lines about why BAD is BAD and why GOOD fixes that flaw? That should help others from making this mistake in the future. Warner From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:08:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E083C16A4CE; Wed, 9 Jun 2004 16:08:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA0FE43D4C; Wed, 9 Jun 2004 16:08:48 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59G8KRw061036; Wed, 9 Jun 2004 16:08:20 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59G8K04061035; Wed, 9 Jun 2004 16:08:20 GMT (envelope-from imp) Message-Id: <200406091608.i59G8K04061035@repoman.freebsd.org> From: Warner Losh Date: Wed, 9 Jun 2004 16:08:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf files kmod.mk src/sys/dev/eisa eisaconf.c eisaconf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:08:49 -0000 imp 2004-06-09 16:08:20 UTC FreeBSD src repository Modified files: sys/conf files kmod.mk sys/dev/eisa eisaconf.c eisaconf.h Log: Step 1 in moving EISA devices to kobj/newbus. Use kobj methods for all of the interface between the driver and the bus. This will enable us to stop special casing eisa bus attachments in modules and treat them like we treat all other busses. In the longer run, we need to eliminate much (all?) of these interfaces and switch to using the standard bus_alloc_resource(), but that's not done right now. # I've not updated the modules to include eisa, etc, just yet Tested on: Compaq Proliant 3000/333 purchased for eisa work Revision Changes Path 1.902 +1 -0 src/sys/conf/files 1.160 +1 -1 src/sys/conf/kmod.mk 1.66 +13 -6 src/sys/dev/eisa/eisaconf.c 1.23 +24 -7 src/sys/dev/eisa/eisaconf.h From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:18:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 986CD16A4CE; Wed, 9 Jun 2004 16:18:26 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F16B43D2D; Wed, 9 Jun 2004 16:18:26 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from freefall.freebsd.org (bmilekic@localhost [127.0.0.1]) i59GIIuD025497; Wed, 9 Jun 2004 16:18:18 GMT (envelope-from bmilekic@freefall.freebsd.org) Received: (from bmilekic@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i59GII2V025496; Wed, 9 Jun 2004 16:18:18 GMT (envelope-from bmilekic) Date: Wed, 9 Jun 2004 16:18:18 +0000 From: Bosko Milekic To: "M. Warner Losh" Message-ID: <20040609161818.GA25348@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:18:26 -0000 Warner wrote: >Poul-Henning wrote: >: Not to pick on anybody, but this is a perfect example of getting locking >: almost right: >: >: BAD: >: >: LOCK(foo->lock) >: foo->refcount--; >: UNLOCK(foo->lock) >: if (foo->refcount == 0) >: destroy(foo); >: >: GOOD: >: >: LOCK(foo->lock) >: i = --foo->refcount; >: UNLOCK(foo->lock) >: if (i == 0) >: destroy(foo); >: > >Can you provide a couple of lines about why BAD is BAD and why GOOD >fixes that flaw? That should help others from making this mistake in >the future. > >Warner Frankly, I think it is obvious. In the BAD case, you decrement safely but you compare for the refcount having hit zero without the lock protecting the count being taken, so what happens is that there is a race window between where you drop the lock and check for the zero refcount where another racing thread could drop the refcount finally to zero and go into the check as well. Briefly, this can happen: - refcount of 'foo' is 2. - thread 1 enters BAD code, lowers refcount to 1, releases lock. - thread 2 enters BAD code, lowers refcount to 0, releases lock. - thread 1 checks against refcount being zero, decides it is now, and proceeds to destroy(foo). - thread 2 checks against refcount being zero, decides it is now, and proceeds to destroy(foo) as well. Conclusion: foo is destroyed twice. The GOOD code does not suffer from this problem. Here is a way to handle this sort of race if your reference counter is instead manipulated atomically (as opposed to protected by a mutex): [From Mbuf-related code] MEXT_REM_REF(m); /* Atomic decrement of m->m_ext.ref_cnt */ if (atomic_cmpset_int(m->m_ext.ref_cnt, 0, 1)) { /* Do the free here... */ } return; -Bosko From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:19:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 428A416A4EE for ; Wed, 9 Jun 2004 16:19:26 +0000 (GMT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A86C43D53 for ; Wed, 9 Jun 2004 16:19:26 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 28934 invoked from network); 9 Jun 2004 16:19:19 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 9 Jun 2004 16:19:18 -0000 Received: from 10.50.41.233 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i59GJFTd018952; Wed, 9 Jun 2004 12:19:15 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Warner Losh Date: Wed, 9 Jun 2004 12:20:06 -0400 User-Agent: KMail/1.6 References: <200406091608.i59G8K04061035@repoman.freebsd.org> In-Reply-To: <200406091608.i59G8K04061035@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406091220.06142.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kmod.mk src/sys/dev/eisa eisaconf.c eisaconf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:19:28 -0000 On Wednesday 09 June 2004 12:08 pm, Warner Losh wrote: > imp 2004-06-09 16:08:20 UTC > > FreeBSD src repository > > Modified files: > sys/conf files kmod.mk > sys/dev/eisa eisaconf.c eisaconf.h > Log: > Step 1 in moving EISA devices to kobj/newbus. Use kobj methods for > all of the interface between the driver and the bus. This will enable > us to stop special casing eisa bus attachments in modules and treat them > like we treat all other busses. > > In the longer run, we need to eliminate much (all?) of these interfaces > and switch to using the standard bus_alloc_resource(), but that's not > done right now. > > # I've not updated the modules to include eisa, etc, just yet > > Tested on: Compaq Proliant 3000/333 purchased for eisa work eisa_if.m? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:20:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 845DF16A4CE; Wed, 9 Jun 2004 16:20:09 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id E70BD43D1F; Wed, 9 Jun 2004 16:20:08 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59GK0cw055930; Wed, 9 Jun 2004 18:20:00 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "M. Warner Losh" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 10:04:13 MDT." <20040609.100413.118633043.imp@bsdimp.com> Date: Wed, 09 Jun 2004 18:20:00 +0200 Message-ID: <55929.1086798000@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:20:09 -0000 In message <20040609.100413.118633043.imp@bsdimp.com>, "M. Warner Losh" writes: >Can you provide a couple of lines about why BAD is BAD and why GOOD >fixes that flaw? That should help others from making this mistake in >the future. LOCK(foo->lock) foo->refcount--; UNLOCK(foo->lock) if (foo->refcount == 0) destroy(foo); The problem is that there is the risk that another thread will modify the refcount between our modification and our test: Assume foo->refcount = 2; thread1 (low priority) thread2 (high priority) ---------------------- ----------------------- ... ... LOCK(foo->lock) ... foo->refcount--; ... # refcount now == 1 LOCK(foo->lock) At this point, thread2 sleeps, spins or whatever until it can get the lock it wants. UNLOCK(foo->lock) Now thread2 is runnable and since it has a higher priority it will be run: foo->refcount--; # refcount now == 0 UNLOCK(foo->lock); if(foo->refount == 0) destroy(foo); ... At some point thread1 gets to continue: if (foo->refcount == 0) destroy(foo); But at this time foo may be gone or recycled and a panic is our best hope and random memory corruption is our worst fear. The way to fix this is to make sure that the test for zero-ness is done on the result of our own decrement operation: LOCK(foo->lock) i = --foo->refcount; UNLOCK(foo->lock) if (i == 0) destroy(foo); Assume foo->refcount = 2; thread1 (low priority) thread2 (high priority) ---------------------- ----------------------- ... ... LOCK(foo->lock) ... i = --foo->refcount; LOCK(foo->lock) # i == 1, refcount == 1 UNLOCK(foo->lock) i = --foo->refcount; # i == 0, refcount == 0 UNLOCK(foo->lock) if (i == 0) # true destroy(foo) ... if (i == 0) # false destroy(foo) I'm not very good at explaining this am I ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:25:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 750A116A4CE; Wed, 9 Jun 2004 16:25:05 +0000 (GMT) Received: from mail.qubesoft.com (gate.qubesoft.com [217.169.36.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8714943D45; Wed, 9 Jun 2004 16:25:04 +0000 (GMT) (envelope-from dfr@nlsystems.com) Received: from bluebottle.qubesoft.com (bluebottle.qubesoft.com [192.168.1.2]) by mail.qubesoft.com (8.12.9/8.12.9) with ESMTP id i59GP1kM051313; Wed, 9 Jun 2004 17:25:01 +0100 (BST) (envelope-from dfr@nlsystems.com) Received: from builder02.qubesoft.com (builder02.qubesoft.com [192.168.1.8]) i59GP0ON034344; Wed, 9 Jun 2004 17:25:00 +0100 (BST) (envelope-from dfr@nlsystems.com) From: Doug Rabson To: Poul-Henning Kamp In-Reply-To: <53418.1086773585@critter.freebsd.dk> References: <53418.1086773585@critter.freebsd.dk> Content-Type: text/plain Message-Id: <1086798299.12306.3.camel@builder02.qubesoft.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Wed, 09 Jun 2004 17:25:00 +0100 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 'clamd / ClamAV version 0.65', clamav-milter version '0.60p' cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:25:05 -0000 On Wed, 2004-06-09 at 10:33, Poul-Henning Kamp wrote: > In message <200406090929.i599T8h6065944@repoman.freebsd.org>, Poul-Henning Kamp > writes: > > > > Modified files: > > sys/kern kern_proc.c > > Log: > > Fix a race in destruction of sessions. > > Not to pick on anybody, but this is a perfect example of getting locking > almost right: > > BAD: > > LOCK(foo->lock) > foo->refcount--; > UNLOCK(foo->lock) > if (foo->refcount == 0) > destroy(foo); > > GOOD: > > LOCK(foo->lock) > i = --foo->refcount; > UNLOCK(foo->lock) > if (i == 0) > destroy(foo); Isn't there still a race in the GOOD case here if somone takes a new reference, incrementing refcount after the UNLOCK(foo->lock)? From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:26:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 759F116A4D1 for ; Wed, 9 Jun 2004 16:26:36 +0000 (GMT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 46C3743D48 for ; Wed, 9 Jun 2004 16:26:36 +0000 (GMT) (envelope-from nate@root.org) Received: (qmail 86069 invoked by uid 1000); 9 Jun 2004 16:26:32 -0000 Date: Wed, 9 Jun 2004 09:26:32 -0700 (PDT) From: Nate Lawson To: Poul-Henning Kamp In-Reply-To: <55929.1086798000@critter.freebsd.dk> Message-ID: <20040609092423.N85944@root.org> References: <55929.1086798000@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:26:36 -0000 On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: > In message <20040609.100413.118633043.imp@bsdimp.com>, "M. Warner Losh" writes: > >Can you provide a couple of lines about why BAD is BAD and why GOOD > >fixes that flaw? That should help others from making this mistake in > >the future. > > The way to fix this is to make sure that the test for zero-ness > is done on the result of our own decrement operation: > > LOCK(foo->lock) > i = --foo->refcount; > UNLOCK(foo->lock) > if (i == 0) > destroy(foo); > > Assume foo->refcount = 2; > > thread1 (low priority) thread2 (high priority) > ---------------------- ----------------------- > > ... ... > LOCK(foo->lock) ... > i = --foo->refcount; LOCK(foo->lock) > # i == 1, refcount == 1 > UNLOCK(foo->lock) > i = --foo->refcount; > # i == 0, refcount == 0 > UNLOCK(foo->lock) > if (i == 0) # true > destroy(foo) > ... > > if (i == 0) # false > destroy(foo) > > I'm not very good at explaining this am I ? The only potential remaining problem is if another thread can increment the refcount after the unlock and i == 0 comparison but before "free(foo)". In this case, you'll free an object that is still in use. It's safe to hold locks across free(), that's how I handle this case. -Nate From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:29:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4AAE916A4CE; Wed, 9 Jun 2004 16:29:28 +0000 (GMT) Received: from imap.univie.ac.at (mailbox-lmtp.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4EEC43D48; Wed, 9 Jun 2004 16:29:27 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11]) by imap.univie.ac.at (8.12.10/8.12.10) with ESMTP id i59GStCh1197358; Wed, 9 Jun 2004 18:29:00 +0200 Date: Wed, 9 Jun 2004 18:28:57 +0200 (CEST) From: Lukas Ertl To: Poul-Henning Kamp In-Reply-To: <55929.1086798000@critter.freebsd.dk> Message-ID: <20040609182606.X707@korben.in.tern> References: <55929.1086798000@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-DCC-ZID-Univie-Metrics: mx8 4247; Body=5 Fuz1=5 Fuz2=5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:29:28 -0000 On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: > Assume foo->refcount = 2; > > thread1 (low priority) thread2 (high priority) > ---------------------- ----------------------- > > ... ... > LOCK(foo->lock) ... > i = --foo->refcount; LOCK(foo->lock) > # i == 1, refcount == 1 > UNLOCK(foo->lock) > i = --foo->refcount; > # i == 0, refcount == 0 > UNLOCK(foo->lock) > if (i == 0) # true > destroy(foo) > ... > > if (i == 0) # false > destroy(foo) Is there a possibility that foo->refcount is incremented after both of them left the critical section, so that i is 0, but foo->refcount isn't? cheers, le -- Lukas Ertl http://homepage.univie.ac.at/l.ertl/ le@FreeBSD.org http://people.freebsd.org/~le/ From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:29:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 882E016A4CE; Wed, 9 Jun 2004 16:29:51 +0000 (GMT) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [128.30.28.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F47643D45; Wed, 9 Jun 2004 16:29:51 +0000 (GMT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1]) by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id i59GTnkP052626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK CN=khavrinen.lcs.mit.edu issuer=SSL+20Client+20CA); Wed, 9 Jun 2004 12:29:50 -0400 (EDT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id i59GTnCx052623; Wed, 9 Jun 2004 12:29:49 -0400 (EDT) (envelope-from wollman) Date: Wed, 9 Jun 2004 12:29:49 -0400 (EDT) From: Garrett Wollman Message-Id: <200406091629.i59GTnCx052623@khavrinen.lcs.mit.edu> To: "Poul-Henning Kamp" In-Reply-To: <55929.1086798000@critter.freebsd.dk> References: <20040609.100413.118633043.imp@bsdimp.com> <55929.1086798000@critter.freebsd.dk> X-Spam-Score: -19.8 () IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES X-Scanned-By: MIMEDefang 2.37 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:29:51 -0000 < said: > The way to fix this is to make sure that the test for zero-ness > is done on the result of our own decrement operation: > LOCK(foo->lock) > i = --foo->refcount; > UNLOCK(foo->lock) > if (i == 0) > destroy(foo); I think it's clearer if you write: LOCK(foo->lock); if (--foo->refcount == 0) destroy(foo); /* expects a locked foo */ else UNLOCK(foo); ...and also a bit harder to mess up in maintenance (particularly if destroy() asserts that the lock is held). -GAWollman From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:32:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1666C16A4CE; Wed, 9 Jun 2004 16:32:30 +0000 (GMT) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [128.30.28.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA0EE43D5D; Wed, 9 Jun 2004 16:32:29 +0000 (GMT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1]) by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id i59GWSkP052678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK CN=khavrinen.lcs.mit.edu issuer=SSL+20Client+20CA); Wed, 9 Jun 2004 12:32:28 -0400 (EDT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id i59GWSmF052675; Wed, 9 Jun 2004 12:32:28 -0400 (EDT) (envelope-from wollman) Date: Wed, 9 Jun 2004 12:32:28 -0400 (EDT) From: Garrett Wollman Message-Id: <200406091632.i59GWSmF052675@khavrinen.lcs.mit.edu> To: Lukas Ertl In-Reply-To: <20040609182606.X707@korben.in.tern> References: <55929.1086798000@critter.freebsd.dk> <20040609182606.X707@korben.in.tern> X-Spam-Score: -19.8 () IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES X-Scanned-By: MIMEDefang 2.37 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:32:30 -0000 < said: > Is there a possibility that foo->refcount is incremented after both of > them left the critical section, so that i is 0, but foo->refcount isn't? The only way there can be such a possibility is if you haven't counted all the references. -GAWollman From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:33:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82D1E16A4CE for ; Wed, 9 Jun 2004 16:33:51 +0000 (GMT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 5669D43D39 for ; Wed, 9 Jun 2004 16:33:51 +0000 (GMT) (envelope-from nate@root.org) Received: (qmail 86164 invoked by uid 1000); 9 Jun 2004 16:33:51 -0000 Date: Wed, 9 Jun 2004 09:33:51 -0700 (PDT) From: Nate Lawson To: Bosko Milekic In-Reply-To: <20040609161818.GA25348@freefall.freebsd.org> Message-ID: <20040609092837.H85944@root.org> References: <20040609161818.GA25348@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:33:51 -0000 On Wed, 9 Jun 2004, Bosko Milekic wrote: > >Poul-Henning wrote: > >: GOOD: > >: > >: LOCK(foo->lock) > >: i = --foo->refcount; > >: UNLOCK(foo->lock) > >: if (i == 0) > >: destroy(foo); > >: > > The GOOD code does not suffer from this problem. Here is a way to > handle this sort of race if your reference counter is instead > manipulated atomically (as opposed to protected by a mutex): > [From Mbuf-related code] > > MEXT_REM_REF(m); /* Atomic decrement of m->m_ext.ref_cnt */ > if (atomic_cmpset_int(m->m_ext.ref_cnt, 0, 1)) { > /* Do the free here... */ > } > return; This may have a race unless the refcount increment path is done correctly: 1:atomic_int-- 1:atomic_cmpset_int == 0 (yes, get ready to free it) 2:atomic_cmpset_int == 0 (yes, object was in process of teardown) 2:create new object, refcount = 1 This assumes it's ok to have two objects of the same type in existence at the same time also (one being torn down while the other is created). Code that accesses an object must make sure it's locked separately. -Nate From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:34:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA8EE16A4CE; Wed, 9 Jun 2004 16:34:37 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E06A743D1D; Wed, 9 Jun 2004 16:34:37 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from freefall.freebsd.org (bmilekic@localhost [127.0.0.1]) i59GYbqb026597; Wed, 9 Jun 2004 16:34:37 GMT (envelope-from bmilekic@freefall.freebsd.org) Received: (from bmilekic@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i59GYb8X026596; Wed, 9 Jun 2004 16:34:37 GMT (envelope-from bmilekic) Date: Wed, 9 Jun 2004 16:34:37 +0000 From: Bosko Milekic To: Nate Lawson Message-ID: <20040609163437.GA26282@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:34:38 -0000 Nate Lawson wrote: >The only potential remaining problem is if another thread can increment >the refcount after the unlock and i == 0 comparison but before >"free(foo)". In this case, you'll free an object that is still in use. >It's safe to hold locks across free(), that's how I handle this case. > >-Nate This is not true if the object 'foo' cannot gain a reference unless an existing referrer passes it its own reference, which would make sense. If there is a way for a reference to 'foo' to be acquired without a reference to it already being held, then that code needs to be fixed and wherever the other reference to 'foo' is needs to ensure to properly increment the reference count. In other words, if you see that the count has hit zero in the GOOD code, then you know you're the last guy to have decremented the reference count and the only guy left referring to the object, so in theory, you should be the only thing allowed to GRANT an additional reference to 'foo'. Know what I mean? In other words, the GOOD code should be correct. -Bosko From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:39:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E14E16A4CE; Wed, 9 Jun 2004 16:39:37 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7438543D2D; Wed, 9 Jun 2004 16:39:37 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from freefall.freebsd.org (bmilekic@localhost [127.0.0.1]) i59GdbP6026965; Wed, 9 Jun 2004 16:39:37 GMT (envelope-from bmilekic@freefall.freebsd.org) Received: (from bmilekic@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i59GdbtB026964; Wed, 9 Jun 2004 16:39:37 GMT (envelope-from bmilekic) Date: Wed, 9 Jun 2004 16:39:37 +0000 From: Bosko Milekic To: Nate Lawson Message-ID: <20040609163937.GA26656@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:39:37 -0000 Nate Lawson wrote: >Bosko wrote: >> MEXT_REM_REF(m); /* Atomic decrement of m->m_ext.ref_cnt */ >> if (atomic_cmpset_int(m->m_ext.ref_cnt, 0, 1)) { >> /* Do the free here... */ >> } >> return; > >This may have a race unless the refcount increment path is done correctly: > >1:atomic_int-- >1:atomic_cmpset_int == 0 (yes, get ready to free it) > >2:atomic_cmpset_int == 0 (yes, object was in process of teardown) >2:create new object, refcount = 1 > >This assumes it's ok to have two objects of the same type in existence at >the same time also (one being torn down while the other is created). Code >that accesses an object must make sure it's locked separately. > >-Nate No, that's not true. The scenario you describe cannot occur. The code I posted prevents you from racing on teardown, so that you never have two threads tearing down the same object. This is because the first one to get to the cmpset will see the refcount to be zero and set it up to 1 (atomically), so that the second thread will see it at 1 and not do the destruction/free as well. There is no race on the reference going back up once it's hit zero because that would imply that we (who have sent it to zero) are now somehow magically making it gain a reference. Think about it, there is no race above. -Bosko From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:40:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAE9616A4CE; Wed, 9 Jun 2004 16:40:16 +0000 (GMT) Received: from imap.univie.ac.at (mail.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6082B43D58; Wed, 9 Jun 2004 16:40:16 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11]) by imap.univie.ac.at (8.12.10/8.12.10) with ESMTP id i59Ge6c61253914; Wed, 9 Jun 2004 18:40:08 +0200 Date: Wed, 9 Jun 2004 18:40:07 +0200 (CEST) From: Lukas Ertl To: Garrett Wollman In-Reply-To: <200406091632.i59GWSmF052675@khavrinen.lcs.mit.edu> Message-ID: <20040609183915.F707@korben.in.tern> References: <55929.1086798000@critter.freebsd.dk> <20040609182606.X707@korben.in.tern> <200406091632.i59GWSmF052675@khavrinen.lcs.mit.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-DCC-ZID-Univie-Metrics: mail 4248; Body=4 Fuz1=4 Fuz2=4 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:40:17 -0000 On Wed, 9 Jun 2004, Garrett Wollman wrote: > < said: > >> Is there a possibility that foo->refcount is incremented after both of >> them left the critical section, so that i is 0, but foo->refcount isn't? > > The only way there can be such a possibility is if you haven't counted > all the references. You probably got me wrong, but you and others have already pointed out the race I was thinking of. :-) cheers, le -- Lukas Ertl http://homepage.univie.ac.at/l.ertl/ le@FreeBSD.org http://people.freebsd.org/~le/ From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:40:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 253F216A4CE; Wed, 9 Jun 2004 16:40:44 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 891F343D5A; Wed, 9 Jun 2004 16:40:43 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59GegJ0056222; Wed, 9 Jun 2004 18:40:42 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Doug Rabson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 17:25:00 BST." <1086798299.12306.3.camel@builder02.qubesoft.com> Date: Wed, 09 Jun 2004 18:40:42 +0200 Message-ID: <56221.1086799242@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:40:44 -0000 In message <1086798299.12306.3.camel@builder02.qubesoft.com>, Doug Rabson write s: >> GOOD: >> >> LOCK(foo->lock) >> i = --foo->refcount; >> UNLOCK(foo->lock) >> if (i == 0) >> destroy(foo); > >Isn't there still a race in the GOOD case here if somone takes a new >reference, incrementing refcount after the UNLOCK(foo->lock)? Convetionally, once the refcount==0 it means that nobody will reference it anymore. If you violate this by design (like for instance in the vnode cache), then you need to cope with that problem, and things get ugly fast (like for instance in the vnode cache). -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:44:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F09CF16A4CE; Wed, 9 Jun 2004 16:44:29 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05EB643D58; Wed, 9 Jun 2004 16:44:29 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i59Go0TR026156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 9 Jun 2004 19:50:02 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i59GiFKZ059374; Wed, 9 Jun 2004 19:44:15 +0300 (EEST) (envelope-from ru) Date: Wed, 9 Jun 2004 19:44:15 +0300 From: Ruslan Ermilov To: Garrett Wollman Message-ID: <20040609164415.GA59326@ip.net.ua> References: <55929.1086798000@critter.freebsd.dk> <20040609182606.X707@korben.in.tern> <200406091632.i59GWSmF052675@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99" Content-Disposition: inline In-Reply-To: <200406091632.i59GWSmF052675@khavrinen.lcs.mit.edu> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Lukas Ertl Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:44:30 -0000 --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2004 at 12:32:28PM -0400, Garrett Wollman wrote: > < s= aid: >=20 > > Is there a possibility that foo->refcount is incremented after both of= =20 > > them left the critical section, so that i is 0, but foo->refcount isn't? >=20 > The only way there can be such a possibility is if you haven't counted > all the references. >=20 Are you trying to say that the 0->1 transition isn't possible? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --5vNYLRcllDrimb99 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAxz5fqRfpzJluFF4RAsDaAJ0XuIvjGlo4VoPabEltjxbkm5an+wCfWbDN Dar9IudEo7qd0K2OGIFxVNs= =0Rr8 -----END PGP SIGNATURE----- --5vNYLRcllDrimb99-- From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:45:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 340CA16A4CE; Wed, 9 Jun 2004 16:45:30 +0000 (GMT) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id C722243D1F; Wed, 9 Jun 2004 16:45:29 +0000 (GMT) (envelope-from danfe@regency.nsu.ru) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.30) id 1BY6FY-0007AF-HK; Wed, 09 Jun 2004 23:48:28 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i59GjSVf093573; Wed, 9 Jun 2004 23:45:28 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.12.10/8.12.10/Submit) id i59GjSfu093520; Wed, 9 Jun 2004 23:45:28 +0700 (NOVST) (envelope-from danfe) Date: Wed, 9 Jun 2004 23:45:28 +0700 From: Alexey Dokuchaev To: "M. Warner Losh" Message-ID: <20040609164528.GB90103@regency.nsu.ru> References: <200406090929.i599T8h6065944@repoman.freebsd.org> <53418.1086773585@critter.freebsd.dk> <20040609.100413.118633043.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040609.100413.118633043.imp@bsdimp.com> User-Agent: Mutt/1.4.2.1i cc: cvs-src@freebsd.org cc: phk@phk.freebsd.dk cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:45:30 -0000 On Wed, Jun 09, 2004 at 10:04:13AM -0600, M. Warner Losh wrote: > In message: <53418.1086773585@critter.freebsd.dk> > "Poul-Henning Kamp" writes: > : In message <200406090929.i599T8h6065944@repoman.freebsd.org>, Poul-Henning Kamp > : writes: > : > > : > Modified files: > : > sys/kern kern_proc.c > : > Log: > : > Fix a race in destruction of sessions. > : > : Not to pick on anybody, but this is a perfect example of getting locking > : almost right: > : > : BAD: > : > : LOCK(foo->lock) > : foo->refcount--; > : UNLOCK(foo->lock) > : if (foo->refcount == 0) > : destroy(foo); > : > : GOOD: > : > : LOCK(foo->lock) > : i = --foo->refcount; > : UNLOCK(foo->lock) > : if (i == 0) > : destroy(foo); > : > > Can you provide a couple of lines about why BAD is BAD and why GOOD > fixes that flaw? That should help others from making this mistake in > the future. Probably even document in developer's handbook, or some related manpage. ./danfe From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:45:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 7BD0C16A4CE; Wed, 9 Jun 2004 16:45:40 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i59GjdGF015959; Wed, 9 Jun 2004 12:45:39 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.12.11/8.12.11/Submit) id i59Gjc4e015958; Wed, 9 Jun 2004 12:45:38 -0400 (EDT) (envelope-from green) Date: Wed, 9 Jun 2004 12:45:38 -0400 From: Brian Feldman To: Nate Lawson Message-ID: <20040609164538.GB15285@green.homeunix.org> References: <55929.1086798000@critter.freebsd.dk> <20040609092423.N85944@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040609092423.N85944@root.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:45:40 -0000 On Wed, Jun 09, 2004 at 09:26:32AM -0700, Nate Lawson wrote: > On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: > > In message <20040609.100413.118633043.imp@bsdimp.com>, "M. Warner Losh" writes: > > >Can you provide a couple of lines about why BAD is BAD and why GOOD > > >fixes that flaw? That should help others from making this mistake in > > >the future. > > > > The way to fix this is to make sure that the test for zero-ness > > is done on the result of our own decrement operation: > > > > LOCK(foo->lock) > > i = --foo->refcount; > > UNLOCK(foo->lock) > > if (i == 0) > > destroy(foo); > > > > Assume foo->refcount = 2; > > > > thread1 (low priority) thread2 (high priority) > > ---------------------- ----------------------- > > > > ... ... > > LOCK(foo->lock) ... > > i = --foo->refcount; LOCK(foo->lock) > > # i == 1, refcount == 1 > > UNLOCK(foo->lock) > > i = --foo->refcount; > > # i == 0, refcount == 0 > > UNLOCK(foo->lock) > > if (i == 0) # true > > destroy(foo) > > ... > > > > if (i == 0) # false > > destroy(foo) > > > > I'm not very good at explaining this am I ? > > The only potential remaining problem is if another thread can increment > the refcount after the unlock and i == 0 comparison but before > "free(foo)". In this case, you'll free an object that is still in use. > It's safe to hold locks across free(), that's how I handle this case. That's not a way to handle that case. The way to handle that case in general is to make it impossible to find a reference the object when the refcount hits zero. LOCK(foo_list) > > LOCK(foo->lock) > > i = --foo->refcount; if (i == 0) remove(foo_list, foo); > > UNLOCK(foo->lock) UNLOCK(foo_list) > > if (i == 0) > > destroy(foo); -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ From owner-cvs-src@FreeBSD.ORG Wed Jun 9 16:56:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAAD816A4CE; Wed, 9 Jun 2004 16:56:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD30A43D1D; Wed, 9 Jun 2004 16:56:22 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59GuMrg078918; Wed, 9 Jun 2004 16:56:22 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59GuMHJ078917; Wed, 9 Jun 2004 16:56:22 GMT (envelope-from imp) Message-Id: <200406091656.i59GuMHJ078917@repoman.freebsd.org> From: Warner Losh Date: Wed, 9 Jun 2004 16:56:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/eisa eisa_if.m X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 16:56:23 -0000 imp 2004-06-09 16:56:22 UTC FreeBSD src repository Added files: sys/dev/eisa eisa_if.m Log: When adding files to the repo, it is very important to not forget the cvs add function. Revision Changes Path 1.1 +65 -0 src/sys/dev/eisa/eisa_if.m (new) From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:10:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 315ED16A4CE; Wed, 9 Jun 2004 17:10:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1317643D31; Wed, 9 Jun 2004 17:10:43 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59HAf5S085957; Wed, 9 Jun 2004 17:10:41 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59HAf5Q085956; Wed, 9 Jun 2004 17:10:41 GMT (envelope-from maxim) Message-Id: <200406091710.i59HAf5Q085956@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 9 Jun 2004 17:10:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/examples/kld/cdev/module cdev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:10:43 -0000 maxim 2004-06-09 17:10:41 UTC FreeBSD src repository Modified files: share/examples/kld/cdev/module cdev.c Log: Style. Revision Changes Path 1.7 +4 -5 src/share/examples/kld/cdev/module/cdev.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:43:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CCD516A4CE; Wed, 9 Jun 2004 17:43:49 +0000 (GMT) Received: from sccrmhc12.comcast.net (sccrmhc12.comcast.net [204.127.202.56]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BB4843D1F; Wed, 9 Jun 2004 17:43:48 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (sccrmhc12) with ESMTP id <20040609174235012002gmvae>; Wed, 9 Jun 2004 17:42:36 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id KAA57994; Wed, 9 Jun 2004 10:42:36 -0700 (PDT) Date: Wed, 9 Jun 2004 10:42:35 -0700 (PDT) From: Julian Elischer To: Doug Rabson In-Reply-To: <1086798299.12306.3.camel@builder02.qubesoft.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:43:50 -0000 On Wed, 9 Jun 2004, Doug Rabson wrote: > On Wed, 2004-06-09 at 10:33, Poul-Henning Kamp wrote: > > In message <200406090929.i599T8h6065944@repoman.freebsd.org>, Poul-Henning Kamp > > writes: > > > > > > Modified files: > > > sys/kern kern_proc.c > > > Log: > > > Fix a race in destruction of sessions. > > > > Not to pick on anybody, but this is a perfect example of getting locking > > almost right: > > > > BAD: > > > > LOCK(foo->lock) > > foo->refcount--; > > UNLOCK(foo->lock) > > if (foo->refcount == 0) > > destroy(foo); > > > > GOOD: > > > > LOCK(foo->lock) > > i = --foo->refcount; > > UNLOCK(foo->lock) > > if (i == 0) > > destroy(foo); > > Isn't there still a race in the GOOD case here if somone takes a new > reference, incrementing refcount after the UNLOCK(foo->lock)? if you had the only reference, then how didi the other party get it? > > > From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:45:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92C2F16A4CE; Wed, 9 Jun 2004 17:45:30 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BF6443D1D; Wed, 9 Jun 2004 17:45:30 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 1C2C5ACAE6; Wed, 9 Jun 2004 19:45:03 +0200 (CEST) Date: Wed, 9 Jun 2004 19:45:03 +0200 From: Pawel Jakub Dawidek To: Bosko Milekic Message-ID: <20040609174503.GU12007@darkness.comp.waw.pl> References: <20040609163937.GA26656@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zmbF4WfaG2f6E7cU" Content-Disposition: inline In-Reply-To: <20040609163937.GA26656@freefall.freebsd.org> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: phk@phk.freebsd.dk cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:45:30 -0000 --zmbF4WfaG2f6E7cU Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2004 at 04:39:37PM +0000, Bosko Milekic wrote: +>=20 +> Nate Lawson wrote: +> >Bosko wrote: +> >> MEXT_REM_REF(m); /* Atomic decrement of m->m_ext.ref_cnt */ +> >> if (atomic_cmpset_int(m->m_ext.ref_cnt, 0, 1)) { +> >> /* Do the free here... */ +> >> } +> >> return; +> > +> >This may have a race unless the refcount increment path is done correct= ly: +> > +> >1:atomic_int-- +> >1:atomic_cmpset_int =3D=3D 0 (yes, get ready to free it) +> > +> >2:atomic_cmpset_int =3D=3D 0 (yes, object was in process of teardown) +> >2:create new object, refcount =3D 1 +> > +> >This assumes it's ok to have two objects of the same type in existence = at +> >the same time also (one being torn down while the other is created). C= ode +> >that accesses an object must make sure it's locked separately. +> > +> >-Nate +>=20 +> No, that's not true. The scenario you describe cannot occur. The code +> I posted prevents you from racing on teardown, so that you never have +> two threads tearing down the same object. This is because the first +> one to get to the cmpset will see the refcount to be zero and set it +> up to 1 (atomically), so that the second thread will see it at 1 and +> not do the destruction/free as well. +>=20 +> There is no race on the reference going back up once it's hit zero +> because that would imply that we (who have sent it to zero) are now +> somehow magically making it gain a reference. +>=20 +> Think about it, there is no race above. But isn't you reference counting mechanism limited to only 0 and 1 values? --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --zmbF4WfaG2f6E7cU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAx0yfForvXbEpPzQRAnE0AKC8YGdmef/qdTHQAlLphY6M1fCN3gCgt2Q2 8BoAta7MIqoT+QkJgxV1ROc= =qnJG -----END PGP SIGNATURE----- --zmbF4WfaG2f6E7cU-- From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:50:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD6A916A4CE; Wed, 9 Jun 2004 17:50:49 +0000 (GMT) Received: from sccrmhc11.comcast.net (sccrmhc11.comcast.net [204.127.202.55]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B1D943D1D; Wed, 9 Jun 2004 17:50:49 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (sccrmhc11) with ESMTP id <2004060917502001100ffltte>; Wed, 9 Jun 2004 17:50:21 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id KAA58159; Wed, 9 Jun 2004 10:50:21 -0700 (PDT) Date: Wed, 9 Jun 2004 10:50:20 -0700 (PDT) From: Julian Elischer To: Ruslan Ermilov In-Reply-To: <20040609164415.GA59326@ip.net.ua> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Lukas Ertl cc: Garrett Wollman Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:50:50 -0000 On Wed, 9 Jun 2004, Ruslan Ermilov wrote: > On Wed, Jun 09, 2004 at 12:32:28PM -0400, Garrett Wollman wrote: > > < said: > > > > > Is there a possibility that foo->refcount is incremented after both of > > > them left the critical section, so that i is 0, but foo->refcount isn't? > > > > The only way there can be such a possibility is if you haven't counted > > all the references. > > > Are you trying to say that the 0->1 transition isn't possible? yes, in general.. Only the creator of the object can make the 0->1 transition.. then if you put it on a linked list it has 2 references. (possibly 3 if it's a bidirectionally linked list, (depending on how anal you want to get). When the creator releases its reference then teh linked list still ahs a reference. Then when you look it up, you should increment the count, and when you remove it from teh linked list you should decrement the count. Now it has only one reference... yours.. and no-one else can find it to manipulate it because it is not in the linked list any more.. so when you drop its last refernce and it goes to 0, then you KNOW that no-one else can get it to move it back to 1. > > > Cheers, > -- > Ruslan Ermilov > ru@FreeBSD.org > FreeBSD committer > From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:52:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3591E16A4CE; Wed, 9 Jun 2004 17:52:05 +0000 (GMT) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [128.30.28.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id D516A43D1D; Wed, 9 Jun 2004 17:52:04 +0000 (GMT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1]) by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id i59HpjkP053223 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK CN=khavrinen.lcs.mit.edu issuer=SSL+20Client+20CA); Wed, 9 Jun 2004 13:51:46 -0400 (EDT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id i59HpjSs053220; Wed, 9 Jun 2004 13:51:45 -0400 (EDT) (envelope-from wollman) Date: Wed, 9 Jun 2004 13:51:45 -0400 (EDT) From: Garrett Wollman Message-Id: <200406091751.i59HpjSs053220@khavrinen.lcs.mit.edu> To: Pawel Jakub Dawidek In-Reply-To: <20040609173747.GT12007@darkness.comp.waw.pl> References: <20040609.100413.118633043.imp@bsdimp.com> <55929.1086798000@critter.freebsd.dk> <200406091629.i59GTnCx052623@khavrinen.lcs.mit.edu> <20040609173747.GT12007@darkness.comp.waw.pl> X-Spam-Score: -19.8 () IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES X-Scanned-By: MIMEDefang 2.37 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:52:05 -0000 < said: > No, it is still wrong. The only good way is green's way. > You cannot destroy object even if you held its lock, because another > thread can sleep on this lock and it will be destroyed under it. Another thread cannot sleep on this lock because it does not have a reference to it. Your hypothetical list of elements counts as a reference. -GAWollman From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:54:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FE5516A4CE; Wed, 9 Jun 2004 17:54:02 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4663943D31; Wed, 9 Jun 2004 17:54:02 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from freefall.freebsd.org (bmilekic@localhost [127.0.0.1]) i59HrvMn033018; Wed, 9 Jun 2004 17:53:57 GMT (envelope-from bmilekic@freefall.freebsd.org) Received: (from bmilekic@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i59HrvLh033017; Wed, 9 Jun 2004 17:53:57 GMT (envelope-from bmilekic) Date: Wed, 9 Jun 2004 17:53:57 +0000 From: Bosko Milekic To: Pawel Jakub Dawidek Message-ID: <20040609175357.GA32787@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: phk@phk.freebsd.dk cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:54:02 -0000 Pawel Jakub Dawidek wrote: >But isn't you reference counting mechanism limited to only 0 and 1 >values? Nope. The cmpset does exactly this, atomically: if the refcnt is 0, set it to 1 and return non-zero, otherwise leave it as it and return 0. Therefore, if two threads are freeing at the same time, the refcount will get dropped twice [atomically, so we don't have to worry about a missed decrement], and the threads will race on that atomic cmpset. But since the cmpset is atomic, then only one thread will get to set the refcnt to 1 and free, and the other will see that it is not zero, and so its cmpset will merely return 0 and it will be done (it won't have to be the one cleaning up/freeing the object). The reference count, after hitting zero, cannot go back up because the object is being freed and no other references exist. If they do, then the reference counting model is broken. Note that in the cmpset, if the refcnt is NOT zero, all that has happened is that it was decremented by 1 and the object not freed. Again, the code is correct. -Bosko From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:55:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78B1016A4CE; Wed, 9 Jun 2004 17:55:13 +0000 (GMT) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 591CF43D46; Wed, 9 Jun 2004 17:55:13 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc12) with ESMTP id <2004060917550901400c5depe>; Wed, 9 Jun 2004 17:55:10 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id KAA58221; Wed, 9 Jun 2004 10:55:08 -0700 (PDT) Date: Wed, 9 Jun 2004 10:55:04 -0700 (PDT) From: Julian Elischer To: Pawel Jakub Dawidek In-Reply-To: <20040609174503.GU12007@darkness.comp.waw.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: phk@phk.freebsd.dk cc: Bosko Milekic cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:55:13 -0000 As I've said before and will continue to say.. "We need a more formal model of dealing with reference counts" i.e. we should get a set of reference counting primatives and make it WELL DOCUMENTED as to how they should be used.. Referenc counting is something that you can't do "a bit". It's like being pregnant.. either you ARE reference counting, or you are doing something else. You can't count just "SOME" of the references.. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:58:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CFD116A4CE; Wed, 9 Jun 2004 17:58:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5113D43D45; Wed, 9 Jun 2004 17:58:55 +0000 (GMT) (envelope-from rik@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59HwpXq095997; Wed, 9 Jun 2004 17:58:51 GMT (envelope-from rik@repoman.freebsd.org) Received: (from rik@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59HwpVs095996; Wed, 9 Jun 2004 17:58:51 GMT (envelope-from rik) Message-Id: <200406091758.i59HwpVs095996@repoman.freebsd.org> From: Roman Kurakin Date: Wed, 9 Jun 2004 17:58:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/cx if_cx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:58:55 -0000 rik 2004-06-09 17:58:51 UTC FreeBSD src repository Modified files: sys/dev/cx if_cx.c Log: Check if we control device. Else we will go to panic cause we don't have properly initialized dev_t structure at open. Revision Changes Path 1.18 +1 -1 src/sys/dev/cx/if_cx.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 17:59:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A95516A4CE; Wed, 9 Jun 2004 17:59:07 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E4DA43D39; Wed, 9 Jun 2004 17:59:06 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59Hwoxw056936; Wed, 9 Jun 2004 19:58:52 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Julian Elischer From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 10:55:04 PDT." Date: Wed, 09 Jun 2004 19:58:50 +0200 Message-ID: <56935.1086803930@critter.freebsd.dk> cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Bosko Milekic cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 17:59:07 -0000 In message , Ju lian Elischer writes: >As I've said before and will continue to say.. >"We need a more formal model of dealing with reference counts" > >i.e. > >we should get a set of reference counting primatives and make it WELL >DOCUMENTED as to how they should be used.. And as others have replied: It is seldom worth it from code clarity or performance wise. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:02:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 800EF16A4CE; Wed, 9 Jun 2004 18:02:27 +0000 (GMT) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F23843D2F; Wed, 9 Jun 2004 18:02:27 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc12) with ESMTP id <2004060918014701400c0j8me>; Wed, 9 Jun 2004 18:01:48 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA58405; Wed, 9 Jun 2004 11:01:48 -0700 (PDT) Date: Wed, 9 Jun 2004 11:01:47 -0700 (PDT) From: Julian Elischer To: Poul-Henning Kamp In-Reply-To: <56935.1086803930@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Bosko Milekic cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:02:27 -0000 On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: > In message , Ju > lian Elischer writes: > > >As I've said before and will continue to say.. > >"We need a more formal model of dealing with reference counts" > > > >i.e. > > > >we should get a set of reference counting primatives and make it WELL > >DOCUMENTED as to how they should be used.. > > And as others have replied: It is seldom worth it from code clarity > or performance wise. few have replied in that way.. most have agreed that it is worth persuing.. > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:06:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E8E316A4E9; Wed, 9 Jun 2004 18:06:00 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6982243D2D; Wed, 9 Jun 2004 18:05:59 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59I55fI057020; Wed, 9 Jun 2004 20:05:05 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Julian Elischer From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 11:01:47 PDT." Date: Wed, 09 Jun 2004 20:05:05 +0200 Message-ID: <57019.1086804305@critter.freebsd.dk> cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Bosko Milekic cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:06:00 -0000 In message , Ju lian Elischer writes: > >On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: >> In message , Ju >> lian Elischer writes: >> >> >As I've said before and will continue to say.. >> >"We need a more formal model of dealing with reference counts" >> > >> >i.e. >> > >> >we should get a set of reference counting primatives and make it WELL >> >DOCUMENTED as to how they should be used.. >> >> And as others have replied: It is seldom worth it from code clarity >> or performance wise. > >few have replied in that way.. >most have agreed that it is worth persuing.. Then do so :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:07:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B8A316A4D1; Wed, 9 Jun 2004 18:07:27 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 718A943D41; Wed, 9 Jun 2004 18:07:27 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from freefall.freebsd.org (bmilekic@localhost [127.0.0.1]) i59I6hhP037136; Wed, 9 Jun 2004 18:06:43 GMT (envelope-from bmilekic@freefall.freebsd.org) Received: (from bmilekic@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i59I6h6j037135; Wed, 9 Jun 2004 18:06:43 GMT (envelope-from bmilekic) Date: Wed, 9 Jun 2004 18:06:42 +0000 From: Bosko Milekic To: Julian Elischer Message-ID: <20040609180642.GA33304@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: phk@phk.freebsd.dk cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:07:28 -0000 Julian Elischer wrote: >As I've said before and will continue to say.. >"We need a more formal model of dealing with reference counts" > >i.e. > >we should get a set of reference counting primatives and make it WELL >DOCUMENTED as to how they should be used.. > >Referenc counting is something that you can't do "a bit". It's like >being pregnant.. either you ARE reference counting, or you are doing >something else. You can't count just "SOME" of the references.. While this idea is initially appealing, you should be aware that it is not as straight-forward as it sounds. Namely, it is sometimes more advantageous to protect the manipulation of the reference count within a section of code already protected by an appropriate object mutex, and other times (in the absence of a mutex), it might be more advantageous to use atomic ops (no need for a mutex, slightly less costly per-instance). So defining an API that does one OR the other might not always be appropriate. -Bosko From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:14:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0132016A4CE; Wed, 9 Jun 2004 18:14:36 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id A437043D45; Wed, 9 Jun 2004 18:14:35 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 024E8ACAFB; Wed, 9 Jun 2004 19:37:48 +0200 (CEST) Date: Wed, 9 Jun 2004 19:37:47 +0200 From: Pawel Jakub Dawidek To: Garrett Wollman Message-ID: <20040609173747.GT12007@darkness.comp.waw.pl> References: <20040609.100413.118633043.imp@bsdimp.com> <55929.1086798000@critter.freebsd.dk> <200406091629.i59GTnCx052623@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HC0F8i/BfMshQzR8" Content-Disposition: inline In-Reply-To: <200406091629.i59GTnCx052623@khavrinen.lcs.mit.edu> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.ORG cc: Poul-Henning Kamp cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:14:36 -0000 --HC0F8i/BfMshQzR8 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2004 at 12:29:49PM -0400, Garrett Wollman wrote: +> < said: +>=20 +> > The way to fix this is to make sure that the test for zero-ness +> > is done on the result of our own decrement operation: +>=20 +> > LOCK(foo->lock) +> > i =3D --foo->refcount; +> > UNLOCK(foo->lock) +> > if (i =3D=3D 0) +> > destroy(foo); +>=20 +> I think it's clearer if you write: +>=20 +> LOCK(foo->lock); +> if (--foo->refcount =3D=3D 0) +> destroy(foo); /* expects a locked foo */ +> else +> UNLOCK(foo); +>=20 +> ...and also a bit harder to mess up in maintenance (particularly if +> destroy() asserts that the lock is held). No, it is still wrong. The only good way is green's way. You cannot destroy object even if you held its lock, because another thread can sleep on this lock and it will be destroyed under it. So first of all one have to lock whole list of element before will take one of then and then remove it from the list before list-lock is released. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --HC0F8i/BfMshQzR8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAx0rrForvXbEpPzQRAtc4AKCuzk5gBVW4Oe2MU5h7MwN3ufCWIgCg1Rlt CSu5aw95eahlpqh6lx/B2s0= =3OQZ -----END PGP SIGNATURE----- --HC0F8i/BfMshQzR8-- From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:15:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61C3616A4CE; Wed, 9 Jun 2004 18:15:05 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3E9B43D45; Wed, 9 Jun 2004 18:15:04 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59IEYhA057190; Wed, 9 Jun 2004 20:14:34 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Bosko Milekic From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 18:06:42 -0000." <20040609180642.GA33304@freefall.freebsd.org> Date: Wed, 09 Jun 2004 20:14:34 +0200 Message-ID: <57189.1086804874@critter.freebsd.dk> cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Julian Elischer cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:15:05 -0000 In message <20040609180642.GA33304@freefall.freebsd.org>, Bosko Milekic writes: > While this idea is initially appealing, you should be aware that > it is not as straight-forward as it sounds. > > Namely, it is sometimes more advantageous to protect the manipulation > of the reference count within a section of code already protected by > an appropriate object mutex, and other times (in the absence of a mutex), > it might be more advantageous to use atomic ops (no need for a mutex, > slightly less costly per-instance). So defining an API that does one > OR the other might not always be appropriate. A still hot from the oven example of this is the code I just added in kern/tty.c: ttyrel() needs to do more locking than ttyref() because it might unlink the tty from a TAILQ whereas ttyref() will never touch the TAILQ. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:17:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C4BF16A4CE; Wed, 9 Jun 2004 18:17:23 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id EADCA43D39; Wed, 9 Jun 2004 18:17:22 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59IGpvA057260; Wed, 9 Jun 2004 20:16:51 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Pawel Jakub Dawidek From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 19:37:47 +0200." <20040609173747.GT12007@darkness.comp.waw.pl> Date: Wed, 09 Jun 2004 20:16:51 +0200 Message-ID: <57259.1086805011@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Garrett Wollman Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:17:23 -0000 In message <20040609173747.GT12007@darkness.comp.waw.pl>, Pawel Jakub Dawidek w rites: >No, it is still wrong. The only good way is green's way. >You cannot destroy object even if you held its lock, because another >thread can sleep on this lock and it will be destroyed under it. > >So first of all one have to lock whole list of element before will >take one of then and then remove it from the list before list-lock >is released. Again: see kern/tty.c for fresh example. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:19:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4695C16A4CE; Wed, 9 Jun 2004 18:19:44 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA49943D1F; Wed, 9 Jun 2004 18:19:43 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i59IGPEu045725; Wed, 9 Jun 2004 12:16:25 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 09 Jun 2004 12:16:40 -0600 (MDT) Message-Id: <20040609.121640.104033033.imp@bsdimp.com> To: bmilekic@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20040609161818.GA25348@freefall.freebsd.org> References: <20040609161818.GA25348@freefall.freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:19:44 -0000 In message: <20040609161818.GA25348@freefall.freebsd.org> Bosko Milekic writes: : Frankly, I think it is obvious. If it were obvious, then people wouldn't be making this mistake. : In the BAD case, you decrement safely but you compare for the refcount : having hit zero without the lock protecting the count being taken, : so what happens is that there is a race window between where you drop : the lock and check for the zero refcount where another racing thread : could drop the refcount finally to zero and go into the check as : well. Briefly, this can happen: : : - refcount of 'foo' is 2. : - thread 1 enters BAD code, lowers refcount to 1, releases lock. : - thread 2 enters BAD code, lowers refcount to 0, releases lock. : - thread 1 checks against refcount being zero, decides it is now, : and proceeds to destroy(foo). : - thread 2 checks against refcount being zero, decides it is now, : and proceeds to destroy(foo) as well. : : Conclusion: foo is destroyed twice. Yes. That's correct. I understood that, but only after I sent the message and thought about it for a while. That tends to be my metric for 'needs a comment' or 'needs to be documented.' : The GOOD code does not suffer from this problem. Here is a way to : handle this sort of race if your reference counter is instead : manipulated atomically (as opposed to protected by a mutex): : [From Mbuf-related code] : : MEXT_REM_REF(m); /* Atomic decrement of m->m_ext.ref_cnt */ : if (atomic_cmpset_int(m->m_ext.ref_cnt, 0, 1)) { : /* Do the free here... */ : } : return; Maybe we need a locking section in the handbook that talks about these techniques. The more people that know and understand them, the better the locking that will happen in the rest of the kernel. Warner From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:22:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EA1216A4CE; Wed, 9 Jun 2004 18:22:04 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17A4C43D45; Wed, 9 Jun 2004 18:22:04 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i59IJ2dE045779; Wed, 9 Jun 2004 12:19:02 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 09 Jun 2004 12:19:19 -0600 (MDT) Message-Id: <20040609.121919.18287197.imp@bsdimp.com> To: julian@elischer.org From: "M. Warner Losh" In-Reply-To: References: <56935.1086803930@critter.freebsd.dk> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: src-committers@freebsd.org cc: pjd@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: phk@phk.freebsd.dk cc: bmilekic@freebsd.org cc: nate@root.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:22:04 -0000 In message: Julian Elischer writes: : : : On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: : : > In message , Ju : > lian Elischer writes: : > : > >As I've said before and will continue to say.. : > >"We need a more formal model of dealing with reference counts" : > > : > >i.e. : > > : > >we should get a set of reference counting primatives and make it WELL : > >DOCUMENTED as to how they should be used.. : > : > And as others have replied: It is seldom worth it from code clarity : > or performance wise. : : few have replied in that way.. : most have agreed that it is worth persuing.. We should document how to do refcounting. Either from a atomic point of view (which has issues) or from the mutex point of view (which also has issues). I think that everyone agrees on that. Warner From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:23:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F26416A4CE; Wed, 9 Jun 2004 18:23:22 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F86E43D45; Wed, 9 Jun 2004 18:23:20 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 5AAD6AC96A; Wed, 9 Jun 2004 20:22:52 +0200 (CEST) Date: Wed, 9 Jun 2004 20:22:52 +0200 From: Pawel Jakub Dawidek To: Garrett Wollman Message-ID: <20040609182252.GW12007@darkness.comp.waw.pl> References: <20040609.100413.118633043.imp@bsdimp.com> <55929.1086798000@critter.freebsd.dk> <200406091629.i59GTnCx052623@khavrinen.lcs.mit.edu> <20040609173747.GT12007@darkness.comp.waw.pl> <200406091751.i59HpjSs053220@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+dH9khzwljbvYE07" Content-Disposition: inline In-Reply-To: <200406091751.i59HpjSs053220@khavrinen.lcs.mit.edu> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:23:22 -0000 --+dH9khzwljbvYE07 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2004 at 01:51:45PM -0400, Garrett Wollman wrote: +> < said: +>=20 +> > No, it is still wrong. The only good way is green's way. +> > You cannot destroy object even if you held its lock, because another +> > thread can sleep on this lock and it will be destroyed under it. +>=20 +> Another thread cannot sleep on this lock because it does not have a +> reference to it. Your hypothetical list of elements counts as a +> reference. Correct! I was wrong, sorry for the noise. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --+dH9khzwljbvYE07 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAx1V8ForvXbEpPzQRAoVSAJ42TWzZDskkQMnCEiT20n5+AXbp7ACeKO8h 7ztxXqKsfEXgtAU1+Go++so= =HD/n -----END PGP SIGNATURE----- --+dH9khzwljbvYE07-- From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:26:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DD1116A4ED; Wed, 9 Jun 2004 18:26:48 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1340443D48; Wed, 9 Jun 2004 18:26:48 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59IQTFg057370; Wed, 9 Jun 2004 20:26:29 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Pawel Jakub Dawidek From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 20:20:41 +0200." <20040609182041.GV12007@darkness.comp.waw.pl> Date: Wed, 09 Jun 2004 20:26:29 +0200 Message-ID: <57369.1086805589@critter.freebsd.dk> cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Bosko Milekic cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:26:49 -0000 In message <20040609182041.GV12007@darkness.comp.waw.pl>, Pawel Jakub Dawidek w rites: >BTW. Do we assume that atomic operations are atomic on MP machines? >I read atomic(9), but I still don't know if I should use it or not for >things like those. Ok, let us dispell the first misconception about atomic operations: Atomic operations are not cheap! In fact, there are architectures where they are significantly more expensive than mutexes. Next: Atomic operations are much harder to grasp mentally, and close to impossible to validate automatically. We have no WITNESS which will tell us about problems with atomic operations. Therefore: Do not use atomic operations, use a mutex. If we find a place where atomics will result in a significant performance increase, we will apply them there after careful consideration and considerable benchmarking. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:27:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3D2816A4CE; Wed, 9 Jun 2004 18:27:29 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 309EC43D2D; Wed, 9 Jun 2004 18:27:29 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i59IPrYh045917; Wed, 9 Jun 2004 12:25:53 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 09 Jun 2004 12:26:09 -0600 (MDT) Message-Id: <20040609.122609.76328844.imp@bsdimp.com> To: pjd@freebsd.org From: "M. Warner Losh" In-Reply-To: <20040609182041.GV12007@darkness.comp.waw.pl> References: <20040609175357.GA32787@freefall.freebsd.org> <20040609182041.GV12007@darkness.comp.waw.pl> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: phk@phk.freebsd.dk cc: bmilekic@freebsd.org cc: nate@root.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:27:30 -0000 In message: <20040609182041.GV12007@darkness.comp.waw.pl> Pawel Jakub Dawidek writes: : BTW. Do we assume that atomic operations are atomic on MP machines? : I read atomic(9), but I still don't know if I should use it or not for : things like those. They are. That's one thing that pessimizes them so horribly. They have to be locked instructions on some architecutres that causes all kinds of nasty (time consuming) things to happen. Warner From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:28:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 71F5516A4CE; Wed, 9 Jun 2004 18:28:13 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2FCF43D54; Wed, 9 Jun 2004 18:28:12 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59IRlkH057450; Wed, 9 Jun 2004 20:27:47 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "M. Warner Losh" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 12:19:19 MDT." <20040609.121919.18287197.imp@bsdimp.com> Date: Wed, 09 Jun 2004 20:27:47 +0200 Message-ID: <57449.1086805667@critter.freebsd.dk> cc: src-committers@freebsd.org cc: pjd@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: julian@elischer.org cc: nate@root.org cc: bmilekic@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:28:13 -0000 In message <20040609.121919.18287197.imp@bsdimp.com>, "M. Warner Losh" writes: >We should document how to do refcounting. Either from a atomic point >of view (which has issues) or from the mutex point of view (which also >has issues). > >I think that everyone agrees on that. Better yet: we should find some good CS-101 references for people to read. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:35:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69CFF16A4CE; Wed, 9 Jun 2004 18:35:38 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12F9843D1F; Wed, 9 Jun 2004 18:35:38 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i59IYFJD046056; Wed, 9 Jun 2004 12:34:15 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 09 Jun 2004 12:34:31 -0600 (MDT) Message-Id: <20040609.123431.122061053.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <57449.1086805667@critter.freebsd.dk> References: <20040609.121919.18287197.imp@bsdimp.com> <57449.1086805667@critter.freebsd.dk> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: src-committers@freebsd.org cc: pjd@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: julian@elischer.org cc: nate@root.org cc: bmilekic@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:35:38 -0000 In message: <57449.1086805667@critter.freebsd.dk> "Poul-Henning Kamp" writes: : In message <20040609.121919.18287197.imp@bsdimp.com>, "M. Warner Losh" writes: : : >We should document how to do refcounting. Either from a atomic point : >of view (which has issues) or from the mutex point of view (which also : >has issues). : > : >I think that everyone agrees on that. : : Better yet: we should find some good CS-101 references for people : to read. This isn't a cs-101 question. locking generally doesn't get covered until the second year. However, known bad examples can do nothing but help. Why are you so resistant to documenting for people the right way to do stuff? Warner From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:40:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 463B916A4CE; Wed, 9 Jun 2004 18:40:48 +0000 (GMT) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32AB043D31; Wed, 9 Jun 2004 18:40:48 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc12) with ESMTP id <2004060918404501400c6t6de>; Wed, 9 Jun 2004 18:40:45 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA59354; Wed, 9 Jun 2004 11:40:46 -0700 (PDT) Date: Wed, 9 Jun 2004 11:40:45 -0700 (PDT) From: Julian Elischer To: "M. Warner Losh" In-Reply-To: <20040609.121919.18287197.imp@bsdimp.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: src-committers@freebsd.org cc: pjd@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: phk@phk.freebsd.dk cc: bmilekic@freebsd.org cc: nate@root.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:40:48 -0000 On Wed, 9 Jun 2004, M. Warner Losh wrote: > In message: > Julian Elischer writes: > : > : > : On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: > : > : > In message , Ju > : > lian Elischer writes: > : > > : > >As I've said before and will continue to say.. > : > >"We need a more formal model of dealing with reference counts" > : > > > : > >i.e. > : > > > : > >we should get a set of reference counting primatives and make it WELL > : > >DOCUMENTED as to how they should be used.. > : > > : > And as others have replied: It is seldom worth it from code clarity > : > or performance wise. > : > : few have replied in that way.. > : most have agreed that it is worth persuing.. > > We should document how to do refcounting. Either from a atomic point > of view (which has issues) or from the mutex point of view (which also > has issues). > > I think that everyone agrees on that. > certainly. Documentation of acceptable coding practices is almost as good as having code to do it.. (as long as people can find the document) > Warner > From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:47:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65EB116A4CE; Wed, 9 Jun 2004 18:47:32 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1063143D1F; Wed, 9 Jun 2004 18:47:32 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id E75E4ACBF9; Wed, 9 Jun 2004 20:20:41 +0200 (CEST) Date: Wed, 9 Jun 2004 20:20:41 +0200 From: Pawel Jakub Dawidek To: Bosko Milekic Message-ID: <20040609182041.GV12007@darkness.comp.waw.pl> References: <20040609175357.GA32787@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EDT6MSV0B3GxyNyZ" Content-Disposition: inline In-Reply-To: <20040609175357.GA32787@freefall.freebsd.org> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: phk@phk.freebsd.dk cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:47:32 -0000 --EDT6MSV0B3GxyNyZ Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2004 at 05:53:57PM +0000, Bosko Milekic wrote: +>=20 +> Pawel Jakub Dawidek wrote: +> >But isn't you reference counting mechanism limited to only 0 and 1 +> >values? +>=20 +> Nope. +>=20 +> The cmpset does exactly this, atomically: if the refcnt is 0, set it +> to 1 and return non-zero, otherwise leave it as it and return 0. +>=20 +> Therefore, if two threads are freeing at the same time, the refcount +> will get dropped twice [atomically, so we don't have to worry about +> a missed decrement], and the threads will race on that atomic cmpset. +> But since the cmpset is atomic, then only one thread will get to set +> the refcnt to 1 and free, and the other will see that it is not zero, +> and so its cmpset will merely return 0 and it will be done (it won't +> have to be the one cleaning up/freeing the object). +>=20 +> The reference count, after hitting zero, cannot go back up because the +> object is being freed and no other references exist. If they do, then +> the reference counting model is broken. +>=20 +> Note that in the cmpset, if the refcnt is NOT zero, all that has happe= ned +> is that it was decremented by 1 and the object not freed. +>=20 +> Again, the code is correct. Ok, I get it now. Even if there will be a race between two threads, i.e.: [ref_cnt is 2] thread1 thread2 atomic_substract(obj, 1) [ref_cnt is 1] atomic_substract(obj, 1) [ref_cnt is 0] atomic_cmpset(obj, 0, 1) -> true [do clean up] atomic_cmpset(obj, 0, 1) -> false [skip cleanups] (thread2 sets ref_cnt to 0, but thread1 destroys objects) we free object only once. Cool, I like it:) BTW. Do we assume that atomic operations are atomic on MP machines? I read atomic(9), but I still don't know if I should use it or not for things like those. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --EDT6MSV0B3GxyNyZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAx1T5ForvXbEpPzQRAmHiAKCg1a3t7wW9MW3tkqgXDE4w7oIsNQCgkGdL hMQNxECXIHT3uMfK30IlT/M= =nxVM -----END PGP SIGNATURE----- --EDT6MSV0B3GxyNyZ-- From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:54:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9722116A4CE; Wed, 9 Jun 2004 18:54:40 +0000 (GMT) Received: from sccrmhc11.comcast.net (sccrmhc11.comcast.net [204.127.202.55]) by mx1.FreeBSD.org (Postfix) with ESMTP id 16E5C43D4C; Wed, 9 Jun 2004 18:54:40 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (sccrmhc11) with ESMTP id <2004060918540701100ffv68e>; Wed, 9 Jun 2004 18:54:08 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA59527; Wed, 9 Jun 2004 11:54:08 -0700 (PDT) Date: Wed, 9 Jun 2004 11:54:06 -0700 (PDT) From: Julian Elischer To: Pawel Jakub Dawidek In-Reply-To: <20040609182041.GV12007@darkness.comp.waw.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: phk@phk.freebsd.dk cc: Bosko Milekic cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:54:40 -0000 On Wed, 9 Jun 2004, Pawel Jakub Dawidek wrote: > On Wed, Jun 09, 2004 at 05:53:57PM +0000, Bosko Milekic wrote: > +> > +> Pawel Jakub Dawidek wrote: > +> >But isn't you reference counting mechanism limited to only 0 and 1 > +> >values? > +> > +> Nope. > +> > +> The cmpset does exactly this, atomically: if the refcnt is 0, set it > +> to 1 and return non-zero, otherwise leave it as it and return 0. > +> > +> Therefore, if two threads are freeing at the same time, the refcount > +> will get dropped twice [atomically, so we don't have to worry about > +> a missed decrement], and the threads will race on that atomic cmpset. > +> But since the cmpset is atomic, then only one thread will get to set > +> the refcnt to 1 and free, and the other will see that it is not zero, > +> and so its cmpset will merely return 0 and it will be done (it won't > +> have to be the one cleaning up/freeing the object). > +> > +> The reference count, after hitting zero, cannot go back up because the > +> object is being freed and no other references exist. If they do, then > +> the reference counting model is broken. > +> > +> Note that in the cmpset, if the refcnt is NOT zero, all that has happened > +> is that it was decremented by 1 and the object not freed. > +> > +> Again, the code is correct. > > Ok, I get it now. Even if there will be a race between two threads, i.e.: > > [ref_cnt is 2] > > thread1 thread2 > > atomic_substract(obj, 1) > [ref_cnt is 1] > atomic_substract(obj, 1) > [ref_cnt is 0] > atomic_cmpset(obj, 0, 1) -> true > [do clean up] > atomic_cmpset(obj, 0, 1) -> false > [skip cleanups] > > (thread2 sets ref_cnt to 0, but thread1 destroys objects) we free object > only once. Cool, I like it:) The method shown above has, however the disadvantage of being less than obvious. ALso thread 2 is likely to get a page fault, which is a less than perfect result.. the reference count must never be read or written after the [cleanup] because it may free the page on which teh counter is kept. > > BTW. Do we assume that atomic operations are atomic on MP machines? > I read atomic(9), but I still don't know if I should use it or not for > things like those. > > -- > Pawel Jakub Dawidek http://www.FreeBSD.org > pjd@FreeBSD.org http://garage.freebsd.pl > FreeBSD committer Am I Evil? Yes, I Am! > From owner-cvs-src@FreeBSD.ORG Wed Jun 9 19:03:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 75F3716A4D0; Wed, 9 Jun 2004 19:03:13 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2368A43D55; Wed, 9 Jun 2004 19:03:13 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 9E989AC995; Wed, 9 Jun 2004 21:02:58 +0200 (CEST) Date: Wed, 9 Jun 2004 21:02:58 +0200 From: Pawel Jakub Dawidek To: Julian Elischer Message-ID: <20040609190258.GY12007@darkness.comp.waw.pl> References: <20040609182041.GV12007@darkness.comp.waw.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s8ux8MQukyWAm3r7" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: phk@phk.freebsd.dk cc: Bosko Milekic cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 19:03:13 -0000 --s8ux8MQukyWAm3r7 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2004 at 11:54:06AM -0700, Julian Elischer wrote: +> > Ok, I get it now. Even if there will be a race between two threads, i.= e.: +> >=20 +> > [ref_cnt is 2] +> >=20 +> > thread1 thread2 +> >=20 +> > atomic_substract(obj, 1) +> > [ref_cnt is 1] +> > atomic_substract(obj, 1) +> > [ref_cnt is 0] +> > atomic_cmpset(obj, 0, 1) -> true +> > [do clean up] +> > atomic_cmpset(obj, 0, 1) -> false +> > [skip cleanups] +> >=20 +> > (thread2 sets ref_cnt to 0, but thread1 destroys objects) we free obje= ct +> > only once. Cool, I like it:) +>=20 +> The method shown above has, however the disadvantage of being +> less than obvious. ALso thread 2 is likely to get a page fault, which +> is a less than perfect result.. +>=20 +> the reference count must never be read or written after the [cleanup] +> because it may free the page on which teh counter is kept. Right... Nice catch. So Bosko probebly have to rethink his model. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --s8ux8MQukyWAm3r7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAx17iForvXbEpPzQRAtIfAKDxcQ5dQYTpabZt4Gxqzt6Pls2EDACeM2b1 jIg7lzU2AlEGNXL6MhNk2o0= =99+x -----END PGP SIGNATURE----- --s8ux8MQukyWAm3r7-- From owner-cvs-src@FreeBSD.ORG Wed Jun 9 19:06:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3976F16A4D1 for ; Wed, 9 Jun 2004 19:06:49 +0000 (GMT) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id C19D743D41 for ; Wed, 9 Jun 2004 19:06:48 +0000 (GMT) (envelope-from silby@silby.com) Received: (qmail 43729 invoked from network); 9 Jun 2004 19:06:42 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 9 Jun 2004 19:06:42 -0000 X-pair-Authenticated: 209.68.2.70 Date: Wed, 9 Jun 2004 14:06:40 -0500 (CDT) From: Mike Silbersack To: Pawel Jakub Dawidek In-Reply-To: <20040609190258.GY12007@darkness.comp.waw.pl> Message-ID: <20040609140517.L17265@odysseus.silby.com> References: <20040609182041.GV12007@darkness.comp.waw.pl> <20040609190258.GY12007@darkness.comp.waw.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: panic("boring") was: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 19:06:49 -0000 On Wed, 9 Jun 2004, Pawel Jakub Dawidek wrote: > +> > (thread2 sets ref_cnt to 0, but thread1 destroys objects) we free object > +> > only once. Cool, I like it:) > +> > +> the reference count must never be read or written after the [cleanup] > +> because it may free the page on which teh counter is kept. > > Right... Nice catch. So Bosko probebly have to rethink his model. Due to the length and unimportance of this thread, I officially dub it: "Locking the Bikeshed" Well, at least we're done painting it... Mike "Silby" Silbersack From owner-cvs-src@FreeBSD.ORG Wed Jun 9 19:09:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4F0916A4CE; Wed, 9 Jun 2004 19:09:07 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1870343D2F; Wed, 9 Jun 2004 19:09:07 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59J8mmB057989; Wed, 9 Jun 2004 21:08:49 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Mike Silbersack From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 14:06:40 CDT." <20040609140517.L17265@odysseus.silby.com> Date: Wed, 09 Jun 2004 21:08:48 +0200 Message-ID: <57988.1086808128@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-all@FreeBSD.org Subject: Re: panic("boring") was: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 19:09:08 -0000 In message <20040609140517.L17265@odysseus.silby.com>, Mike Silbersack writes: >Due to the length and unimportance of this thread, I officially dub it: > >"Locking the Bikeshed" > >Well, at least we're done painting it... *KNOCK* *KNOCK* HEY! let me out! *KNOCK* I'm not done yet in here!!! -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 19:11:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F12F316A4CE; Wed, 9 Jun 2004 19:11:01 +0000 (GMT) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1D9843D1D; Wed, 9 Jun 2004 19:11:01 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc12) with ESMTP id <2004060919103201400c2d8fe>; Wed, 9 Jun 2004 19:10:33 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id MAA59868; Wed, 9 Jun 2004 12:10:33 -0700 (PDT) Date: Wed, 9 Jun 2004 12:10:32 -0700 (PDT) From: Julian Elischer To: Poul-Henning Kamp In-Reply-To: <57988.1086808128@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: Mike Silbersack cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-all@FreeBSD.org Subject: Re: panic("boring") was: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 19:11:02 -0000 your bikeshed has a door? On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: > In message <20040609140517.L17265@odysseus.silby.com>, Mike Silbersack writes: > > >Due to the length and unimportance of this thread, I officially dub it: > > > >"Locking the Bikeshed" > > > >Well, at least we're done painting it... > > *KNOCK* *KNOCK* HEY! let me out! *KNOCK* I'm not done yet in here!!! > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > From owner-cvs-src@FreeBSD.ORG Wed Jun 9 19:18:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 570DF16A4CE; Wed, 9 Jun 2004 19:18:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51ED643D1F; Wed, 9 Jun 2004 19:18:51 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59JIpEw014376; Wed, 9 Jun 2004 19:18:51 GMT (envelope-from bmilekic@repoman.freebsd.org) Received: (from bmilekic@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59JIpUe014375; Wed, 9 Jun 2004 19:18:51 GMT (envelope-from bmilekic) Message-Id: <200406091918.i59JIpUe014375@repoman.freebsd.org> From: Bosko Milekic Date: Wed, 9 Jun 2004 19:18:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 19:18:51 -0000 bmilekic 2004-06-09 19:18:51 UTC FreeBSD src repository Modified files: sys/vm uma_core.c Log: Make the slabrefzone, the zone from which we allocated slabs with internal reference counters, UMA_ZONE_NOFREE. This way, those slabs (with their ref counts) will be effectively type-stable, then using a trick like this on the refcount is no longer dangerous: MEXT_REM_REF(m); if (atomic_cmpset_int(m->m_ext.ref_cnt, 0, 1)) { if (m->m_ext.ext_type == EXT_PACKET) { uma_zfree(zone_pack, m); return; } else if (m->m_ext.ext_type == EXT_CLUSTER) { uma_zfree(zone_clust, m->m_ext.ext_buf); m->m_ext.ext_buf = NULL; } else { (*(m->m_ext.ext_free))(m->m_ext.ext_buf, m->m_ext.ext_args); if (m->m_ext.ext_type != EXT_EXTREF) free(m->m_ext.ref_cnt, M_MBUF); } } uma_zfree(zone_mbuf, m); Previously, a second thread hitting the above cmpset might actually read the refcnt AFTER it has already been freed. A very rare occurance. Now we'll know that it won't be freed, though. Spotted by: julian, pjd Revision Changes Path 1.95 +2 -1 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 19:24:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC7DA16A4CE; Wed, 9 Jun 2004 19:24:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA03443D1F; Wed, 9 Jun 2004 19:24:35 +0000 (GMT) (envelope-from hmp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59JOMcU016285; Wed, 9 Jun 2004 19:24:22 GMT (envelope-from hmp@repoman.freebsd.org) Received: (from hmp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59JOM9g016284; Wed, 9 Jun 2004 19:24:22 GMT (envelope-from hmp) Message-Id: <200406091924.i59JOM9g016284@repoman.freebsd.org> From: Hiten Pandya Date: Wed, 9 Jun 2004 19:24:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/lib/libc/stdio fclose.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 19:24:36 -0000 hmp 2004-06-09 19:24:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) lib/libc/stdio fclose.c Log: Revert previous commit regarding FUNLOCKFILE(fp), it has ill effects. Revision Changes Path 1.8.2.2 +1 -1 src/lib/libc/stdio/fclose.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 19:29:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8799016A4CE; Wed, 9 Jun 2004 19:29:18 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82AA143D46; Wed, 9 Jun 2004 19:29:18 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from freefall.freebsd.org (bmilekic@localhost [127.0.0.1]) i59JTInK044796; Wed, 9 Jun 2004 19:29:18 GMT (envelope-from bmilekic@freefall.freebsd.org) Received: (from bmilekic@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i59JTI0h044795; Wed, 9 Jun 2004 19:29:18 GMT (envelope-from bmilekic) Date: Wed, 9 Jun 2004 19:29:18 +0000 From: Bosko Milekic To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20040609192918.GA44607@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 19:29:18 -0000 Please note: this only fixes the cluster case and not other types of ext bufs which do MEXTADD. Basically the refcounting method works well as long as the refcounts are type-stable. This could be made a requirement for all ext_bufs without problem, and for those who do not provide ref cnts, I will replace the malloc() of the refcnt with a uma zone allocation of the refcnt from a special UMA_ZONE_NOFREE refcnt zone. We need to use atomics here because there is no place where to put a mutex, so I can't fix this by just protecting the refcnt with a mutex. -Bosko bmilekic 2004-06-09 19:18:51 UTC FreeBSD src repository Modified files: sys/vm uma_core.c Log: Make the slabrefzone, the zone from which we allocated slabs with internal reference counters, UMA_ZONE_NOFREE. This way, those slabs (with their ref counts) will be effectively type-stable, then using a trick like this on the refcount is no longer dangerous: ... From owner-cvs-src@FreeBSD.ORG Wed Jun 9 19:44:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6C4B16A4CE; Wed, 9 Jun 2004 19:44:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9EFF43D2F; Wed, 9 Jun 2004 19:44:55 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59JiiQo020397; Wed, 9 Jun 2004 19:44:44 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59JiiZL020396; Wed, 9 Jun 2004 19:44:44 GMT (envelope-from phk) Message-Id: <200406091944.i59JiiZL020396@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 9 Jun 2004 19:44:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_io.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 19:44:55 -0000 phk 2004-06-09 19:44:44 UTC FreeBSD src repository Modified files: sys/geom geom_io.c Log: Make the sysctl kern.geom.collectstats more granular. Bit 0 controls statistics collection on GEOM providers. Bit 1 controls statistics collection on GEOM consumers. Default value is 1. Prodded by: scottl Revision Changes Path 1.55 +8 -8 src/sys/geom/geom_io.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 20:05:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 18B5A16A4CE; Wed, 9 Jun 2004 20:05:26 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5692343D41; Wed, 9 Jun 2004 20:05:25 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i59K562I058591; Wed, 9 Jun 2004 22:05:06 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "M. Warner Losh" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Jun 2004 12:34:31 MDT." <20040609.123431.122061053.imp@bsdimp.com> Date: Wed, 09 Jun 2004 22:05:06 +0200 Message-ID: <58590.1086811506@critter.freebsd.dk> cc: src-committers@freebsd.org cc: pjd@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: julian@elischer.org cc: nate@root.org cc: bmilekic@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 20:05:26 -0000 In message <20040609.123431.122061053.imp@bsdimp.com>, "M. Warner Losh" writes: >However, known bad examples can do nothing but help. Why are you so >resistant to documenting for people the right way to do stuff? I'm not resisting, it's on my "future blue-prints article" list already. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jun 9 20:10:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D89C16A4CE; Wed, 9 Jun 2004 20:10:39 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2067C43D41; Wed, 9 Jun 2004 20:10:39 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59KAcdn025700; Wed, 9 Jun 2004 20:10:38 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59KAcXH025699; Wed, 9 Jun 2004 20:10:38 GMT (envelope-from ru) Message-Id: <200406092010.i59KAcXH025699@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 9 Jun 2004 20:10:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 20:10:39 -0000 ru 2004-06-09 20:10:38 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw.8 ipfw2.c sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c Log: Introduce a new feature to IPFW2: lookup tables. These are useful for handling large sparse address sets. Initial implementation by Vsevolod Lobko , refined by me. MFC after: 1 week Revision Changes Path 1.145 +61 -2 src/sbin/ipfw/ipfw.8 1.51 +108 -2 src/sbin/ipfw/ipfw2.c 1.84 +6 -0 src/sys/netinet/in.h 1.85 +19 -0 src/sys/netinet/ip_fw.h 1.60 +324 -1 src/sys/netinet/ip_fw2.c 1.134 +5 -0 src/sys/netinet/raw_ip.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 20:14:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C05616A4D1; Wed, 9 Jun 2004 20:14:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2033643D4C; Wed, 9 Jun 2004 20:14:54 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59KEr7V027580; Wed, 9 Jun 2004 20:14:53 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59KErff027579; Wed, 9 Jun 2004 20:14:53 GMT (envelope-from des) Message-Id: <200406092014.i59KErff027579@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Wed, 9 Jun 2004 20:14:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/cvs FREEBSD-Xlist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 20:14:54 -0000 des 2004-06-09 20:14:53 UTC FreeBSD src repository Added files: contrib/cvs FREEBSD-Xlist Log: List of files and directories to delete before importing a new release. Revision Changes Path 1.1 +21 -0 src/contrib/cvs/FREEBSD-Xlist (new) From owner-cvs-src@FreeBSD.ORG Wed Jun 9 20:50:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF21616A4D0; Wed, 9 Jun 2004 20:50:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D186143D58; Wed, 9 Jun 2004 20:50:20 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59Ko8YT040057; Wed, 9 Jun 2004 20:50:08 GMT (envelope-from bmilekic@repoman.freebsd.org) Received: (from bmilekic@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59Ko8nl040056; Wed, 9 Jun 2004 20:50:08 GMT (envelope-from bmilekic) Message-Id: <200406092050.i59Ko8nl040056@repoman.freebsd.org> From: Bosko Milekic Date: Wed, 9 Jun 2004 20:50:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 20:50:21 -0000 bmilekic 2004-06-09 20:50:08 UTC FreeBSD src repository Modified files: sys/vm uma_core.c Log: Backout previous change, I think Julian has a better solution which does not require type-stable refcnts here. Revision Changes Path 1.96 +1 -1 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 20:51:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7491416A4CE; Wed, 9 Jun 2004 20:51:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 588CE43D31; Wed, 9 Jun 2004 20:51:52 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59KpR8L040959; Wed, 9 Jun 2004 20:51:27 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59KpRcn040958; Wed, 9 Jun 2004 20:51:27 GMT (envelope-from des) Message-Id: <200406092051.i59KpRcn040958@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Wed, 9 Jun 2004 20:51:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/cvs FREEBSD-upgrade X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 20:51:52 -0000 des 2004-06-09 20:51:26 UTC FreeBSD src repository Modified files: contrib/cvs FREEBSD-upgrade Log: The list of files / directories to remove has moved to FREEBSD-Xlist. Revision Changes Path 1.11 +4 -24 src/contrib/cvs/FREEBSD-upgrade From owner-cvs-src@FreeBSD.ORG Wed Jun 9 21:25:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4268816A4CE; Wed, 9 Jun 2004 21:25:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B3A943D1F; Wed, 9 Jun 2004 21:25:04 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59LOqGd049230; Wed, 9 Jun 2004 21:24:52 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59LOqsL049229; Wed, 9 Jun 2004 21:24:52 GMT (envelope-from das) Message-Id: <200406092124.i59LOqsL049229@repoman.freebsd.org> From: David Schultz Date: Wed, 9 Jun 2004 21:24:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/src s_rintf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 21:25:05 -0000 das 2004-06-09 21:24:52 UTC FreeBSD src repository Modified files: lib/msun/src s_rintf.c Log: Fix a bug where rintf() rounded the wrong way in round-to-nearest mode on all inputs of the form x.75, where x is an even integer and log2(x) = 21. A similar problem occurred when rounding upward. The bug involves the following snippet copied from rint(): i>>=1; if((i0&i)!=0) i0 = (i0&(~i))|((0x100000)>>j0); The constant 0x100000 should be 0x200000. Apparently this case was never tested. It turns out that the bit manipulation is completely superfluous anyway, so remove it. (It tries to simulate 90% of the rounding process that the FPU does anyway.) Also, the special case of +-0 is handled twice (in different ways), so remove the second instance. Throw in some related simplifications from bde: - Work around a bug where gcc fails to clip to float precision by declaring two float variables as volatile. Previously, we tricked gcc into generating correct code by declaring some float constants as doubles. - Remove additional superfluous bit manipulation. - Minor reorganization. - Include explicitly. Note that some of the equivalent lines in rint() also appear to be unnecessary, but I'll defer to the numerical analysts who wrote it, since I can't test all 2^64 cases. Discussed with: bde Revision Changes Path 1.9 +7 -26 src/lib/msun/src/s_rintf.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 21:28:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D331216A4D3 for ; Wed, 9 Jun 2004 21:28:50 +0000 (GMT) Received: from mailtoaster1.pipeline.ch (mailtoaster1.pipeline.ch [62.48.0.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EF3243D2D for ; Wed, 9 Jun 2004 21:28:50 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 40373 invoked from network); 9 Jun 2004 21:28:37 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.54]) (envelope-sender ) by mailtoaster1.pipeline.ch (qmail-ldap-1.03) with SMTP for ; 9 Jun 2004 21:28:37 -0000 Message-ID: <40C78104.F12A8948@freebsd.org> Date: Wed, 09 Jun 2004 23:28:36 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Hiten Pandya References: <200406091924.i59JOM9g016284@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdio fclose.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 21:28:51 -0000 Hiten Pandya wrote: > > hmp 2004-06-09 19:24:22 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_4) > lib/libc/stdio fclose.c > Log: > Revert previous commit regarding FUNLOCKFILE(fp), it has ill effects. What ill effects does it have? I've "make world" a couple of server with this in. Do I have to remake them again or is it unlikely that I run across the probems? -- Andre From owner-cvs-src@FreeBSD.ORG Wed Jun 9 21:51:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A8C416A4CE; Wed, 9 Jun 2004 21:51:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B22643D31; Wed, 9 Jun 2004 21:51:20 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59Lp3dQ053698; Wed, 9 Jun 2004 21:51:03 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59Lp22I053697; Wed, 9 Jun 2004 21:51:02 GMT (envelope-from imp) Message-Id: <200406092151.i59Lp22I053697@repoman.freebsd.org> From: Warner Losh Date: Wed, 9 Jun 2004 21:51:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules/aic7xxx/ahc/ahc_eisa Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 21:51:20 -0000 imp 2004-06-09 21:51:02 UTC FreeBSD src repository Modified files: sys/modules/aic7xxx/ahc/ahc_eisa Makefile Log: Add eisa_if.h to the list of things to build for new eisa_if.m for the case where we build modules with world. Revision Changes Path 1.2 +1 -1 src/sys/modules/aic7xxx/ahc/ahc_eisa/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jun 9 21:52:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7651A16A4D4; Wed, 9 Jun 2004 21:52:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5805B43D31; Wed, 9 Jun 2004 21:52:28 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i59LqDdl055181; Wed, 9 Jun 2004 21:52:13 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i59LqDBV055177; Wed, 9 Jun 2004 21:52:13 GMT (envelope-from imp) Message-Id: <200406092152.i59LqDBV055177@repoman.freebsd.org> From: Warner Losh Date: Wed, 9 Jun 2004 21:52:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules/vx Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 21:52:28 -0000 imp 2004-06-09 21:52:13 UTC FreeBSD src repository Modified files: sys/modules/vx Makefile Log: Add eisa_if.h Revision Changes Path 1.3 +2 -2 src/sys/modules/vx/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jun 9 22:53:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90A9016A4CE; Wed, 9 Jun 2004 22:53:44 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32CBD43D48; Wed, 9 Jun 2004 22:53:44 +0000 (GMT) (envelope-from hmp@freebsd.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i59Mqffv017955; Wed, 9 Jun 2004 18:52:41 -0400 (EDT) (envelope-from hmp@freebsd.org) Received: from localhost (hmp@localhost)i59Mqf10017952; Wed, 9 Jun 2004 18:52:41 -0400 (EDT) (envelope-from hmp@freebsd.org) X-Authentication-Warning: fledge.watson.org: hmp owned process doing -bs Date: Wed, 9 Jun 2004 18:52:41 -0400 (EDT) From: Hiten Pandya X-X-Sender: hmp@fledge.watson.org To: Andre Oppermann In-Reply-To: <40C78104.F12A8948@freebsd.org> Message-ID: <20040609184556.N14244@fledge.watson.org> References: <200406091924.i59JOM9g016284@repoman.freebsd.org> <40C78104.F12A8948@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdio fclose.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 22:53:44 -0000 On Wed, 9 Jun 2004, Andre Oppermann wrote: :Hiten Pandya wrote: :> :> hmp 2004-06-09 19:24:22 UTC :> :> FreeBSD src repository :> :> Modified files: (Branch: RELENG_4) :> lib/libc/stdio fclose.c :> Log: :> Revert previous commit regarding FUNLOCKFILE(fp), it has ill effects. : :What ill effects does it have? I've "make world" a couple of server :with this in. Do I have to remake them again or is it unlikely that :I run across the probems? Well, the ill effects that I came across was that people reported Mozilla and net/freeradius hanging with this change As to why it was happening; that's because of inappropriate logic employed in lib/libc_r/uthread/uthread_file.c, i.e., in the implementation of the funlockfile() function; it checks wether FILE->_file >= 0. By moving the call to FUNLOCKFILE below modification of file flags, it got confused because fclose(3) was setting FILE->_file to -1, thus leading to a confused FUNLOCKFILE. With regard to the problems, you can just recompile your libc and it should go away. Regards, Hiten Pandya hmp at freebsd.org From owner-cvs-src@FreeBSD.ORG Thu Jun 10 00:04:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9418116A4CE; Thu, 10 Jun 2004 00:04:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7430043D2D; Thu, 10 Jun 2004 00:04:23 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A04GQR084777; Thu, 10 Jun 2004 00:04:16 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A04G3n084776; Thu, 10 Jun 2004 00:04:16 GMT (envelope-from marius) Message-Id: <200406100004.i5A04G3n084776@repoman.freebsd.org> From: Marius Strobl Date: Thu, 10 Jun 2004 00:04:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/gem if_gem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 00:04:23 -0000 marius 2004-06-10 00:04:16 UTC FreeBSD src repository Modified files: sys/dev/gem if_gem.c Log: - Remove a variable no longer used after the conversion to ether_crc32_le(). - While here, save on another one no longer really necessary after the conversion. Revision Changes Path 1.26 +2 -4 src/sys/dev/gem/if_gem.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 00:04:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BC1F16A4CE; Thu, 10 Jun 2004 00:04:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 83F6043D1D; Thu, 10 Jun 2004 00:04:35 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A04RBV084806; Thu, 10 Jun 2004 00:04:27 GMT (envelope-from bmilekic@repoman.freebsd.org) Received: (from bmilekic@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A04RSt084805; Thu, 10 Jun 2004 00:04:27 GMT (envelope-from bmilekic) Message-Id: <200406100004.i5A04RSt084805@repoman.freebsd.org> From: Bosko Milekic Date: Thu, 10 Jun 2004 00:04:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_mbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 00:04:35 -0000 bmilekic 2004-06-10 00:04:27 UTC FreeBSD src repository Modified files: sys/kern uipc_mbuf.c Log: Plug a race where upon free this scenario could occur: (time grows downward) thread 1 thread 2 ------------|------------ dec ref_cnt | | dec ref_cnt <-- ref_cnt now zero cmpset | free all | return | | alloc again,| reuse prev | ref_cnt | | cmpset, read | already freed | ref_cnt ------------|------------ This should fix that by performing only a single atomic test-and-set that will serve to decrement the ref_cnt, only if it hasn't changed since the earlier read, otherwise it'll loop and re-read. This forces ordering of decrements so that truly the thread which did the LAST decrement is the one that frees. This is how atomic-instruction-based refcnting should probably be handled. Submitted by: Julian Elischer Revision Changes Path 1.132 +30 -15 src/sys/kern/uipc_mbuf.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 00:06:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5189016A4CE; Thu, 10 Jun 2004 00:06:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 334E943D55; Thu, 10 Jun 2004 00:06:05 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A064Ai084938; Thu, 10 Jun 2004 00:06:05 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A064ID084937; Thu, 10 Jun 2004 00:06:04 GMT (envelope-from marius) Message-Id: <200406100006.i5A064ID084937@repoman.freebsd.org> From: Marius Strobl Date: Thu, 10 Jun 2004 00:06:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/hme if_hme.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 00:06:05 -0000 marius 2004-06-10 00:06:04 UTC FreeBSD src repository Modified files: sys/dev/hme if_hme.c Log: - Add a LLADDR() forgotten in the conversion to ether_crc32_le(). - Remove a variable no longer used after the conversion. - While here, save on another one no longer really necessary after the conversion. Revision Changes Path 1.26 +2 -4 src/sys/dev/hme/if_hme.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 01:13:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B62F16A4CE; Thu, 10 Jun 2004 01:13:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D6DE43D39; Thu, 10 Jun 2004 01:13:30 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A1DRXg006039; Thu, 10 Jun 2004 01:13:27 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A1DRvB006038; Thu, 10 Jun 2004 01:13:27 GMT (envelope-from iedowse) Message-Id: <200406100113.i5A1DRvB006038@repoman.freebsd.org> From: Ian Dowse Date: Thu, 10 Jun 2004 01:13:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb uhub.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 01:13:30 -0000 iedowse 2004-06-10 01:13:27 UTC FreeBSD src repository Modified files: sys/dev/usb uhub.c Log: Initialise `restartcnt' in the newly malloc'd usbd_port structure, as otherwise the junk it contains may cause uhub_explore to give up without ever trying to restart the port. This fixes the following errors I was seeing with a VIA UHCI controller: uhub0: port error, restarting port 1 uhub0: port error, giving up port 1 Revision Changes Path 1.55 +1 -0 src/sys/dev/usb/uhub.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 02:41:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 680) id B870916A4D0; Thu, 10 Jun 2004 02:41:41 +0000 (GMT) Date: Thu, 10 Jun 2004 02:41:41 +0000 From: Darren Reed To: Brian Feldman Message-ID: <20040610024141.GA59816@hub.freebsd.org> References: <55929.1086798000@critter.freebsd.dk> <20040609092423.N85944@root.org> <20040609164538.GB15285@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040609164538.GB15285@green.homeunix.org> User-Agent: Mutt/1.4.1i cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Poul-Henning Kamp cc: Nate Lawson cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 02:41:41 -0000 On Wed, Jun 09, 2004 at 12:45:38PM -0400, Brian Feldman wrote: > > That's not a way to handle that case. The way to handle that case > in general is to make it impossible to find a reference the object > when the refcount hits zero. > > LOCK(foo_list) > > > LOCK(foo->lock) > > > i = --foo->refcount; > if (i == 0) > remove(foo_list, foo); > > > UNLOCK(foo->lock) > UNLOCK(foo_list) > > > if (i == 0) > > > destroy(foo); Just to add my $0.02 on this thread, the above code is correct. you could put the destroy in the critical section but those parts of the code are meant to be small and tight. In my experience, the way to do this for performance is to use read-write locks for locking on the list. So, for example, you would have: new() { create and initialise new foo foo->refcount = 2 WRITE_LOCK(list) add_to_list(foo) UNLOCK(list) return foo } search() { READ_LOCK(list) find foo if (foo is found) LOCK(foo->lock) foo->refcount++; UNLOCK(foo->lock) UNLOCK(list) return foo; } deref(foo) { LOCK(foo->lock) foo->refcount-- if (foo->refcount == 0) foo->refcount++ UNLOCK(foo->lock) delete(foo) else UNLOCK(foo->lock) } delete(foo) { WRITE_LOCK(list) if (foo_on_list) remove_from_list(foo) LOCK(foo->lock) foo->refcount-- if (foo->refcount == 0) destroy(foo) else UNLOCK(foo->lock) UNLOCK(list) } Why use read/write locks? It allows concurrent searching and use of the object foo with little penalty - it does, however, make new/delete operations slower but what occurs more - search or new/delete ? Why is there a "refcount++" after checking "refcount == 0" ? Because you need to give up foo->lock and in this code, you don't have a lock on the list to stop another finding it and thereby doing a refcount++. This is a more complex code model because the locking is more detached from the operations. It also distinguishes between deref() and delete(), although delete() can be used without calling deref(). It allows the object "foo" to be used safely without a lock on list or foo. The race between search() incrementing the refcount and the delete() free'ing the object is eliminated by the list lock. Technically you shouldn't need to have foo->lock for remove_from_list because the list modifications should all be exclusive anyway (in this case, the write lock provides it.) You should only ever have code entering both deref() and delete() simultaneously if refcount == 2. Why does new() set refcount to 2 ? Because it returns a pointer to the object for the calling code to use and there's a reference to it on the list. When the calling code finishes using it, it must call deref(). If you need to destroy the mutex in a special way then this is done with destroy(). Questions/comments ? Darren From owner-cvs-src@FreeBSD.ORG Thu Jun 10 02:45:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B11DD16A4CE; Thu, 10 Jun 2004 02:45:09 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 78D4443D55; Thu, 10 Jun 2004 02:45:09 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.208] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BYFYh-0008Df-00; Thu, 10 Jun 2004 04:44:51 +0200 Received: from [84.128.139.222] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1BYFYg-0008J3-00; Thu, 10 Jun 2004 04:44:51 +0200 From: Max Laier To: Ruslan Ermilov Date: Thu, 10 Jun 2004 04:45:37 +0200 User-Agent: KMail/1.6.2 References: <200406092010.i59KAcXH025699@repoman.freebsd.org> In-Reply-To: <200406092010.i59KAcXH025699@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_Yt8xAm5sA16WKPL"; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406100445.44763.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:e28873fbe4dbe612ce62ab869898ff08 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 02:45:09 -0000 --Boundary-02=_Yt8xAm5sA16WKPL Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 09 June 2004 22:10, Ruslan Ermilov wrote: > ru 2004-06-09 20:10:38 UTC > > FreeBSD src repository > > Modified files: > sbin/ipfw ipfw.8 ipfw2.c > sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c > Log: > Introduce a new feature to IPFW2: lookup tables. These are useful > for handling large sparse address sets. Initial implementation by > Vsevolod Lobko , refined by me. Idea from: pf ;) Nice! > MFC after: 1 week > > Revision Changes Path > 1.145 +61 -2 src/sbin/ipfw/ipfw.8 > 1.51 +108 -2 src/sbin/ipfw/ipfw2.c > 1.84 +6 -0 src/sys/netinet/in.h > 1.85 +19 -0 src/sys/netinet/ip_fw.h > 1.60 +324 -1 src/sys/netinet/ip_fw2.c > 1.134 +5 -0 src/sys/netinet/raw_ip.c =2D-=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet --Boundary-02=_Yt8xAm5sA16WKPL Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAx8tYXyyEoT62BG0RAoI5AJ9yBOGMz/Bh39IzDkqoZtAoQQYnoACdGOyN f5VAAfnYiv3dIDCPafXX9xI= =QPXz -----END PGP SIGNATURE----- --Boundary-02=_Yt8xAm5sA16WKPL-- From owner-cvs-src@FreeBSD.ORG Thu Jun 10 03:27:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 680) id 0F21016A4D0; Thu, 10 Jun 2004 03:27:01 +0000 (GMT) Date: Thu, 10 Jun 2004 03:27:01 +0000 From: Darren Reed To: Max Laier Message-ID: <20040610032701.GA47549@hub.freebsd.org> References: <200406092010.i59KAcXH025699@repoman.freebsd.org> <200406100445.44763.max@love2party.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406100445.44763.max@love2party.net> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Ruslan Ermilov cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 03:27:01 -0000 On Thu, Jun 10, 2004 at 04:45:37AM +0200, Max Laier wrote: > On Wednesday 09 June 2004 22:10, Ruslan Ermilov wrote: > > ru 2004-06-09 20:10:38 UTC > > > > FreeBSD src repository > > > > Modified files: > > sbin/ipfw ipfw.8 ipfw2.c > > sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c > > Log: > > Introduce a new feature to IPFW2: lookup tables. These are useful > > for handling large sparse address sets. Initial implementation by > > Vsevolod Lobko , refined by me. > > Idea from: pf ;) > Nice! Both ipfilter & iptables supported this kind of address matching before pf did. From owner-cvs-src@FreeBSD.ORG Thu Jun 10 04:31:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B26E16A4CE; Thu, 10 Jun 2004 04:31:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C6D043D45; Thu, 10 Jun 2004 04:31:00 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A4UxB3048441; Thu, 10 Jun 2004 04:30:59 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A4UxCP048437; Thu, 10 Jun 2004 04:30:59 GMT (envelope-from alc) Message-Id: <200406100430.i5A4UxCP048437@repoman.freebsd.org> From: Alan Cox Date: Thu, 10 Jun 2004 04:30:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 04:31:00 -0000 alc 2004-06-10 04:30:59 UTC FreeBSD src repository Modified files: sys/alpha/alpha pmap.c Log: MFamd64 Significantly reduce the number of preallocated pv entries in pmap_init(). Tested by: kensmith@ Revision Changes Path 1.147 +1 -5 src/sys/alpha/alpha/pmap.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 05:11:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 43D2416A4CE; Thu, 10 Jun 2004 05:11:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CEDB43D39; Thu, 10 Jun 2004 05:11:50 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A5Beon063882; Thu, 10 Jun 2004 05:11:40 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A5Beog063878; Thu, 10 Jun 2004 05:11:40 GMT (envelope-from scottl) Message-Id: <200406100511.i5A5Beog063878@repoman.freebsd.org> From: Scott Long Date: Thu, 10 Jun 2004 05:11:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h lsi64854var.h ncr53c9x.c ncr53c9xreg.h ncr53c9xvar.h src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 05:11:50 -0000 scottl 2004-06-10 05:11:40 UTC FreeBSD src repository Added files: sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h lsi64854var.h ncr53c9x.c ncr53c9xreg.h ncr53c9xvar.h sys/modules/esp Makefile Log: Port the NetBSD esp(4) driver. This only includes the sbus front-end, so its primary use is for the FEPS/FAS366 SCSI found in Sun Ultra 1e and 2 machines. Once the pci front-end is ported, this driver can replace the amd(4) driver. The code as-is is fairly stable. I've disabled tagged-queueing until I can figure out a corruption bug related to it. I'm importing it now so that people with these machines can (finally) stop netbooting and report bugs before 5.3. Revision Changes Path 1.1 +581 -0 src/sys/dev/esp/esp_sbus.c (new) 1.1 +722 -0 src/sys/dev/esp/lsi64854.c (new) 1.1 +205 -0 src/sys/dev/esp/lsi64854reg.h (new) 1.1 +114 -0 src/sys/dev/esp/lsi64854var.h (new) 1.1 +2938 -0 src/sys/dev/esp/ncr53c9x.c (new) 1.1 +290 -0 src/sys/dev/esp/ncr53c9xreg.h (new) 1.1 +457 -0 src/sys/dev/esp/ncr53c9xvar.h (new) 1.1 +15 -0 src/sys/modules/esp/Makefile (new) From owner-cvs-src@FreeBSD.ORG Thu Jun 10 05:21:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D767B16A4CE; Thu, 10 Jun 2004 05:21:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B974A43D31; Thu, 10 Jun 2004 05:21:44 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A5LiWb066030; Thu, 10 Jun 2004 05:21:44 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A5LiCB066029; Thu, 10 Jun 2004 05:21:44 GMT (envelope-from scottl) Message-Id: <200406100521.i5A5LiCB066029@repoman.freebsd.org> From: Scott Long Date: Thu, 10 Jun 2004 05:21:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf files files.sparc64 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 05:21:45 -0000 scottl 2004-06-10 05:21:44 UTC FreeBSD src repository Modified files: sys/conf files files.sparc64 Log: Add the esp(4) files. Two of them are sbus-specific and therefore only apply to sparc64. Revision Changes Path 1.903 +1 -0 src/sys/conf/files 1.54 +2 -0 src/sys/conf/files.sparc64 From owner-cvs-src@FreeBSD.ORG Thu Jun 10 05:21:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D380A16A4CE; Thu, 10 Jun 2004 05:21:53 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D72B43D53; Thu, 10 Jun 2004 05:21:53 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 9738465400; Thu, 10 Jun 2004 06:21:51 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 06306-03-2; Thu, 10 Jun 2004 06:21:51 +0100 (BST) Received: from empiric.dek.spc.org (82-147-17-88.dsl.uk.rapidplay.com [82.147.17.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id C3645653FF; Thu, 10 Jun 2004 06:21:50 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 660D3610F; Thu, 10 Jun 2004 06:21:47 +0100 (BST) Date: Thu, 10 Jun 2004 06:21:47 +0100 From: Bruce M Simpson To: Scott Long Message-ID: <20040610052147.GJ4623@empiric.dek.spc.org> Mail-Followup-To: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200406100511.i5A5Beog063878@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406100511.i5A5Beog063878@repoman.freebsd.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h lsi64854var.h ncr53c9x.c ncr53c9xreg.h ncr53c9xvar.h src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 05:21:54 -0000 On Thu, Jun 10, 2004 at 05:11:40AM +0000, Scott Long wrote: > Log: > Port the NetBSD esp(4) driver. This only includes the sbus front-end, so > its primary use is for the FEPS/FAS366 SCSI found in Sun Ultra 1e and 2 > machines. Once the pci front-end is ported, this driver can replace the > amd(4) driver. Impressive. Excellent. Frags. BMS From owner-cvs-src@FreeBSD.ORG Thu Jun 10 05:24:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3929616A4D0; Thu, 10 Jun 2004 05:24:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 192CE43D54; Thu, 10 Jun 2004 05:24:53 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A5OZKT066811; Thu, 10 Jun 2004 05:24:35 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A5OYgC066810; Thu, 10 Jun 2004 05:24:34 GMT (envelope-from scottl) Message-Id: <200406100524.i5A5OYgC066810@repoman.freebsd.org> From: Scott Long Date: Thu, 10 Jun 2004 05:24:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sparc64/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 05:24:53 -0000 scottl 2004-06-10 05:24:34 UTC FreeBSD src repository Modified files: sys/sparc64/conf GENERIC Log: Add esp to the sparc64 GENERIC Revision Changes Path 1.73 +1 -0 src/sys/sparc64/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Thu Jun 10 05:43:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2238916A4CE; Thu, 10 Jun 2004 05:43:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 04C4E43D31; Thu, 10 Jun 2004 05:43:40 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A5hade070977; Thu, 10 Jun 2004 05:43:36 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A5haeU070976; Thu, 10 Jun 2004 05:43:36 GMT (envelope-from scottl) Message-Id: <200406100543.i5A5haeU070976@repoman.freebsd.org> From: Scott Long Date: Thu, 10 Jun 2004 05:43:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 05:43:40 -0000 scottl 2004-06-10 05:43:36 UTC FreeBSD src repository Modified files: sys/conf NOTES Log: Add esp(4) to NOTES. Revision Changes Path 1.1229 +2 -0 src/sys/conf/NOTES From owner-cvs-src@FreeBSD.ORG Thu Jun 10 05:49:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 460A916A4CE; Thu, 10 Jun 2004 05:49:54 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBA1243D2D; Thu, 10 Jun 2004 05:49:53 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from freebsd.org (junior-wifi.samsco.home [192.168.0.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i5A5qFHP005730; Wed, 9 Jun 2004 23:52:16 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <40C7F65D.9050209@freebsd.org> Date: Wed, 09 Jun 2004 23:49:17 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Scott Long References: <200406100511.i5A5Beog063878@repoman.freebsd.org> In-Reply-To: <200406100511.i5A5Beog063878@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=1.0 required=3.8 tests=SUBJ_HAS_SPACES autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 05:49:54 -0000 Scott Long wrote: > scottl 2004-06-10 05:11:40 UTC > > FreeBSD src repository > > Added files: > sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h > lsi64854var.h ncr53c9x.c ncr53c9xreg.h > ncr53c9xvar.h > sys/modules/esp Makefile > Log: > Port the NetBSD esp(4) driver. This only includes the sbus front-end, so > its primary use is for the FEPS/FAS366 SCSI found in Sun Ultra 1e and 2 > machines. Once the pci front-end is ported, this driver can replace the > amd(4) driver. > I'm embarrassed to say this, but I've lost track of exactly who sent me the ultra2 machine in late 2002 to do this work. If that kind soul would step forward I'll gladly add attritbutions to him and buy beer. Scott From owner-cvs-src@FreeBSD.ORG Thu Jun 10 06:49:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 36EA016A4CE; Thu, 10 Jun 2004 06:49:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1920043D31; Thu, 10 Jun 2004 06:49:22 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A6nARE084352; Thu, 10 Jun 2004 06:49:10 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A6nAEf084351; Thu, 10 Jun 2004 06:49:10 GMT (envelope-from des) Message-Id: <200406100649.i5A6nAEf084351@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Thu, 10 Jun 2004 06:49:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/lib/libusbhid libusbhid.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 06:49:22 -0000 des 2004-06-10 06:49:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) lib/libusbhid libusbhid.h Log: MFC (usbhid.h 1.11): add __BEGIN_DECLS / __END_DECLS. Revision Changes Path 1.7.2.2 +4 -0 src/lib/libusbhid/libusbhid.h From owner-cvs-src@FreeBSD.ORG Thu Jun 10 06:55:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE9DB16A4CE; Thu, 10 Jun 2004 06:55:14 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EDD543D45; Thu, 10 Jun 2004 06:53:51 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i5A6xOwC079414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Jun 2004 09:59:25 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i5A6rZxn013841; Thu, 10 Jun 2004 09:53:35 +0300 (EEST) (envelope-from ru) Date: Thu, 10 Jun 2004 09:53:35 +0300 From: Ruslan Ermilov To: Darren Reed Message-ID: <20040610065335.GB13728@ip.net.ua> References: <200406092010.i59KAcXH025699@repoman.freebsd.org> <200406100445.44763.max@love2party.net> <20040610032701.GA47549@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DBIVS5p969aUjpLe" Content-Disposition: inline In-Reply-To: <20040610032701.GA47549@hub.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 06:55:15 -0000 --DBIVS5p969aUjpLe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 10, 2004 at 03:27:01AM +0000, Darren Reed wrote: > On Thu, Jun 10, 2004 at 04:45:37AM +0200, Max Laier wrote: > > On Wednesday 09 June 2004 22:10, Ruslan Ermilov wrote: > > > ru 2004-06-09 20:10:38 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sbin/ipfw ipfw.8 ipfw2.c > > > sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c > > > Log: > > > Introduce a new feature to IPFW2: lookup tables. These are useful > > > for handling large sparse address sets. Initial implementation by > > > Vsevolod Lobko , refined by me. > >=20 > > Idea from: pf ;) > > Nice! >=20 > Both ipfilter & iptables supported this kind of address matching before > pf did. >=20 How is it possible with IPFilter, can you enlighten me? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --DBIVS5p969aUjpLe Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAyAVvqRfpzJluFF4RAiw7AJ4gDtA/GAknCgVKnjs/NQ3t7T2KmQCfayWB tidOoY7ThD//Gf91Qd7u8No= =uK7D -----END PGP SIGNATURE----- --DBIVS5p969aUjpLe-- From owner-cvs-src@FreeBSD.ORG Thu Jun 10 07:12:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 680) id 75DE616A4D0; Thu, 10 Jun 2004 07:12:29 +0000 (GMT) Date: Thu, 10 Jun 2004 07:12:29 +0000 From: Darren Reed To: Ruslan Ermilov Message-ID: <20040610071229.GC47549@hub.freebsd.org> References: <200406092010.i59KAcXH025699@repoman.freebsd.org> <200406100445.44763.max@love2party.net> <20040610032701.GA47549@hub.freebsd.org> <20040610065335.GB13728@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040610065335.GB13728@ip.net.ua> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 07:12:29 -0000 On Thu, Jun 10, 2004 at 09:53:35AM +0300, Ruslan Ermilov wrote: > On Thu, Jun 10, 2004 at 03:27:01AM +0000, Darren Reed wrote: > > On Thu, Jun 10, 2004 at 04:45:37AM +0200, Max Laier wrote: > > > On Wednesday 09 June 2004 22:10, Ruslan Ermilov wrote: > > > > ru 2004-06-09 20:10:38 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sbin/ipfw ipfw.8 ipfw2.c > > > > sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c > > > > Log: > > > > Introduce a new feature to IPFW2: lookup tables. These are useful > > > > for handling large sparse address sets. Initial implementation by > > > > Vsevolod Lobko , refined by me. > > > > > > Idea from: pf ;) > > > Nice! > > > > Both ipfilter & iptables supported this kind of address matching before > > pf did. > > > How is it possible with IPFilter, can you enlighten me? In IPFilter4, there's a program called ippool that manages "it" and subsequent support within the rest of the code. http://coombs.anu.edu.au/~avalon/ip-filter.html Darren From owner-cvs-src@FreeBSD.ORG Thu Jun 10 07:30:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0FF216A4D0; Thu, 10 Jun 2004 07:30:07 +0000 (GMT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A49843D46; Thu, 10 Jun 2004 07:30:07 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.11/8.12.11) with ESMTP id i5A7ToNJ018644; Thu, 10 Jun 2004 00:29:54 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200406100729.i5A7ToNJ018644@gw.catspoiler.org> Date: Thu, 10 Jun 2004 00:29:50 -0700 (PDT) From: Don Lewis To: iedowse@FreeBSD.org In-Reply-To: <200406100113.i5A1DRvB006038@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb uhub.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 07:30:07 -0000 On 10 Jun, Ian Dowse wrote: > iedowse 2004-06-10 01:13:27 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb uhub.c > Log: > Initialise `restartcnt' in the newly malloc'd usbd_port structure, > as otherwise the junk it contains may cause uhub_explore to give > up without ever trying to restart the port. This fixes the following > errors I was seeing with a VIA UHCI controller: > > uhub0: port error, restarting port 1 > uhub0: port error, giving up port 1 > > Revision Changes Path > 1.55 +1 -0 src/sys/dev/usb/uhub.c Thanks! I was wondering why FreeBSD was unhappy with the USB ports on my Athlon machine. From owner-cvs-src@FreeBSD.ORG Thu Jun 10 07:51:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAD5F16A4CE; Thu, 10 Jun 2004 07:51:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB9F043D31; Thu, 10 Jun 2004 07:51:50 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5A7pEBj097828; Thu, 10 Jun 2004 07:51:14 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5A7pDrE097827; Thu, 10 Jun 2004 07:51:13 GMT (envelope-from ru) Message-Id: <200406100751.i5A7pDrE097827@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 10 Jun 2004 07:51:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 07:51:51 -0000 ru 2004-06-10 07:51:12 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw2.c Log: Fixed a bug spotted by compiling with -Wall. Revision Changes Path 1.52 +1 -1 src/sbin/ipfw/ipfw2.c From owner-cvs-src@FreeBSD.ORG Wed Jun 9 18:24:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC65916A4CE; Wed, 9 Jun 2004 18:24:19 +0000 (GMT) Received: from sccrmhc11.comcast.net (sccrmhc11.comcast.net [204.127.202.55]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5926243D2D; Wed, 9 Jun 2004 18:24:19 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (sccrmhc11) with ESMTP id <2004060918234901100fn8dle>; Wed, 9 Jun 2004 18:23:51 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA58947; Wed, 9 Jun 2004 11:23:50 -0700 (PDT) Date: Wed, 9 Jun 2004 11:23:48 -0700 (PDT) From: Julian Elischer To: Poul-Henning Kamp In-Reply-To: <57019.1086804305@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Mailman-Approved-At: Thu, 10 Jun 2004 11:37:53 +0000 cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_proc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 18:24:20 -0000 On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: > In message , Ju > lian Elischer writes: > > > >On Wed, 9 Jun 2004, Poul-Henning Kamp wrote: > >> In message , Ju > >> lian Elischer writes: > >> > >> >As I've said before and will continue to say.. > >> >"We need a more formal model of dealing with reference counts" > >> > > >> >i.e. > >> > > >> >we should get a set of reference counting primatives and make it WELL > >> >DOCUMENTED as to how they should be used.. > >> > >> And as others have replied: It is seldom worth it from code clarity > >> or performance wise. > > > >few have replied in that way.. > >most have agreed that it is worth persuing.. > > Then do so :-) I do actually agree that a general purpose reference counting API is very difficult to use in every situation and that there are situations where you just HAVE to roll your own.. The question is whether there are enough "simpler" cases around to make it worth spending resources on making an API to use.. several possible points that need to be kept in mind that have complicated my previous attempts to do so are: If you reference count EVERYWHERE, then you need to be able to add and subtract references very cheaply because you might end up doing it a lot. You also need to consider than in the kernel, the last referenc to somethign could easily occur in an interrupt routine, so the 'free' actions need to either be runnable at that time, or a mechanism needs to be developed to defer teh actual freeing to another time. Anyhow if anyone is interested I'll take this to -arch.. From owner-cvs-src@FreeBSD.ORG Thu Jun 10 13:02:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F67116A4CE; Thu, 10 Jun 2004 13:02:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2ED1D43D1D; Thu, 10 Jun 2004 13:02:35 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AD2U56078706; Thu, 10 Jun 2004 13:02:30 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AD2TXW078702; Thu, 10 Jun 2004 13:02:29 GMT (envelope-from marius) Message-Id: <200406101302.i5AD2TXW078702@repoman.freebsd.org> From: Marius Strobl Date: Thu, 10 Jun 2004 13:02:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 13:02:35 -0000 marius 2004-06-10 13:02:29 UTC FreeBSD src repository Modified files: sys/modules/esp Makefile Log: Fix typo that prevents esp_sbus.c and lsi64854.c from being built on sparc64. Revision Changes Path 1.2 +1 -1 src/sys/modules/esp/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jun 10 13:07:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC9B416A4CE; Thu, 10 Jun 2004 13:07:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE13D43D5D; Thu, 10 Jun 2004 13:07:55 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AD7r00080169; Thu, 10 Jun 2004 13:07:53 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AD7rYM080168; Thu, 10 Jun 2004 13:07:53 GMT (envelope-from ru) Message-Id: <200406101307.i5AD7rYM080168@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 10 Jun 2004 13:07:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.bin/make suff.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 13:07:56 -0000 ru 2004-06-10 13:07:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) usr.bin/make suff.c Log: MFC: 1.29: Avoid a null pointer dereference if the .DEFAULT target has no commands. Revision Changes Path 1.12.2.2 +7 -2 src/usr.bin/make/suff.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 13:50:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A840C16A4D0; Thu, 10 Jun 2004 13:50:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 891B943D2D; Thu, 10 Jun 2004 13:50:46 +0000 (GMT) (envelope-from rik@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5ADoSwA088209; Thu, 10 Jun 2004 13:50:28 GMT (envelope-from rik@repoman.freebsd.org) Received: (from rik@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5ADoShE088208; Thu, 10 Jun 2004 13:50:28 GMT (envelope-from rik) Message-Id: <200406101350.i5ADoShE088208@repoman.freebsd.org> From: Roman Kurakin Date: Thu, 10 Jun 2004 13:50:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/cx if_cx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 13:50:46 -0000 rik 2004-06-10 13:50:28 UTC FreeBSD src repository Modified files: sys/dev/cx if_cx.c Log: Free tty at detach(). Tested by: `pstat -t` Requested by: phk Revision Changes Path 1.19 +15 -1 src/sys/dev/cx/if_cx.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 18:47:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94C2E16A4D0; Thu, 10 Jun 2004 18:47:54 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82E3C43D46; Thu, 10 Jun 2004 18:47:54 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 55A5A5C824; Thu, 10 Jun 2004 11:47:46 -0700 (PDT) Date: Thu, 10 Jun 2004 11:47:46 -0700 From: Alfred Perlstein To: Scott Long Message-ID: <20040610184746.GF78955@elvis.mu.org> References: <200406100511.i5A5Beog063878@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406100511.i5A5Beog063878@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h lsi64854var.h ncr53c9x.c ncr53c9xreg.h ncr53c9xvar.h src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 18:47:55 -0000 * Scott Long [040609 22:11] wrote: > scottl 2004-06-10 05:11:40 UTC > > FreeBSD src repository > > Added files: > sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h > lsi64854var.h ncr53c9x.c ncr53c9xreg.h > ncr53c9xvar.h > sys/modules/esp Makefile > Log: > Port the NetBSD esp(4) driver. This only includes the sbus front-end, so > its primary use is for the FEPS/FAS366 SCSI found in Sun Ultra 1e and 2 > machines. Once the pci front-end is ported, this driver can replace the > amd(4) driver. omfg... excellent. Do we have hme support yet? -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Thu Jun 10 18:51:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65F0616A4D0; Thu, 10 Jun 2004 18:51:34 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18AD343D49; Thu, 10 Jun 2004 18:51:34 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from freebsd.org (junior-wifi.samsco.home [192.168.0.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i5AIrqaK007818; Thu, 10 Jun 2004 12:53:52 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <40C8AD8A.2040309@freebsd.org> Date: Thu, 10 Jun 2004 12:50:50 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alfred Perlstein References: <200406100511.i5A5Beog063878@repoman.freebsd.org> <20040610184746.GF78955@elvis.mu.org> In-Reply-To: <20040610184746.GF78955@elvis.mu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h lsi64854var.h ncr53c9x.c ncr53c9xreg.h ncr53c9xvar.h src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 18:51:34 -0000 Alfred Perlstein wrote: > * Scott Long [040609 22:11] wrote: > >>scottl 2004-06-10 05:11:40 UTC >> >> FreeBSD src repository >> >> Added files: >> sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h >> lsi64854var.h ncr53c9x.c ncr53c9xreg.h >> ncr53c9xvar.h >> sys/modules/esp Makefile >> Log: >> Port the NetBSD esp(4) driver. This only includes the sbus front-end, so >> its primary use is for the FEPS/FAS366 SCSI found in Sun Ultra 1e and 2 >> machines. Once the pci front-end is ported, this driver can replace the >> amd(4) driver. > > > omfg... excellent. Do we have hme support yet? > We've had HME for a long time. I had my ultra2 netbooted on it while I was doing this driver. Scott From owner-cvs-src@FreeBSD.ORG Thu Jun 10 18:57:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0596116A4CE; Thu, 10 Jun 2004 18:57:35 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id F140D43D5A; Thu, 10 Jun 2004 18:57:34 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 745D75C817; Thu, 10 Jun 2004 11:57:30 -0700 (PDT) Date: Thu, 10 Jun 2004 11:57:30 -0700 From: Alfred Perlstein To: Scott Long Message-ID: <20040610185730.GG78955@elvis.mu.org> References: <200406100511.i5A5Beog063878@repoman.freebsd.org> <20040610184746.GF78955@elvis.mu.org> <40C8AD8A.2040309@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40C8AD8A.2040309@freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h lsi64854var.h ncr53c9x.c ncr53c9xreg.h ncr53c9xvar.h src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 18:57:35 -0000 * Scott Long [040610 11:51] wrote: > Alfred Perlstein wrote: > >* Scott Long [040609 22:11] wrote: > > > >>scottl 2004-06-10 05:11:40 UTC > >> > >> FreeBSD src repository > >> > >> Added files: > >> sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h > >> lsi64854var.h ncr53c9x.c ncr53c9xreg.h > >> ncr53c9xvar.h > >> sys/modules/esp Makefile > >> Log: > >> Port the NetBSD esp(4) driver. This only includes the sbus front-end, so > >> its primary use is for the FEPS/FAS366 SCSI found in Sun Ultra 1e and 2 > >> machines. Once the pci front-end is ported, this driver can replace the > >> amd(4) driver. > > > > > >omfg... excellent. Do we have hme support yet? > > > > We've had HME for a long time. I had my ultra2 netbooted on it while I > was doing this driver. k, i forgot if it was just fas that wasn't supported, or if it was hme as well. woo, now i can run freebsd on my 167mhz u1e... wait, is creator gfx supported? :( -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Thu Jun 10 19:02:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4371316A4CE; Thu, 10 Jun 2004 19:02:29 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id E84B343D46; Thu, 10 Jun 2004 19:02:28 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from freebsd.org (junior-wifi.samsco.home [192.168.0.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i5AJ4nkJ007893; Thu, 10 Jun 2004 13:04:50 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <40C8B01B.3010203@freebsd.org> Date: Thu, 10 Jun 2004 13:01:47 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alfred Perlstein References: <200406100511.i5A5Beog063878@repoman.freebsd.org> <20040610184746.GF78955@elvis.mu.org> <40C8AD8A.2040309@freebsd.org> <20040610185730.GG78955@elvis.mu.org> In-Reply-To: <20040610185730.GG78955@elvis.mu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h lsi64854var.h ncr53c9x.c ncr53c9xreg.h ncr53c9xvar.h src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 19:02:29 -0000 Alfred Perlstein wrote: > * Scott Long [040610 11:51] wrote: > >>Alfred Perlstein wrote: >> >>>* Scott Long [040609 22:11] wrote: >>> >>> >>>>scottl 2004-06-10 05:11:40 UTC >>>> >>>>FreeBSD src repository >>>> >>>>Added files: >>>> sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h >>>> lsi64854var.h ncr53c9x.c ncr53c9xreg.h >>>> ncr53c9xvar.h >>>> sys/modules/esp Makefile >>>>Log: >>>>Port the NetBSD esp(4) driver. This only includes the sbus front-end, so >>>>its primary use is for the FEPS/FAS366 SCSI found in Sun Ultra 1e and 2 >>>>machines. Once the pci front-end is ported, this driver can replace the >>>>amd(4) driver. >>> >>> >>>omfg... excellent. Do we have hme support yet? >>> >> >>We've had HME for a long time. I had my ultra2 netbooted on it while I >>was doing this driver. > > > k, i forgot if it was just fas that wasn't supported, or if it was > hme as well. > > woo, now i can run freebsd on my 167mhz u1e... > > wait, is creator gfx supported? :( > Yes, Jake shoeshorned syscons onto sparc last year. I'm having troubles getting it to work, though, as it locks the system up solid a few seconds after going to multiuser. Scott From owner-cvs-src@FreeBSD.ORG Thu Jun 10 19:02:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7006216A4D0; Thu, 10 Jun 2004 19:02:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DDEC43D53; Thu, 10 Jun 2004 19:02:46 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AJ2gqV063381; Thu, 10 Jun 2004 19:02:42 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AJ2g8O063377; Thu, 10 Jun 2004 19:02:42 GMT (envelope-from peter) Message-Id: <200406101902.i5AJ2g8O063377@repoman.freebsd.org> From: Peter Wemm Date: Thu, 10 Jun 2004 19:02:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/usr.bin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 19:02:46 -0000 peter 2004-06-10 19:02:42 UTC FreeBSD src repository Modified files: gnu/usr.bin Makefile Log: Turn off cvs while import/merging. Revision Changes Path 1.79 +1 -1 src/gnu/usr.bin/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jun 10 19:05:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E62F16A4CE; Thu, 10 Jun 2004 19:05:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9ABC043D2D; Thu, 10 Jun 2004 19:05:48 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AJ5lss064699; Thu, 10 Jun 2004 19:05:47 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AJ5l3s064698; Thu, 10 Jun 2004 19:05:47 GMT (envelope-from peter) Message-Id: <200406101905.i5AJ5l3s064698@repoman.freebsd.org> From: Peter Wemm Date: Thu, 10 Jun 2004 19:05:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: CVSHOME Subject: cvs commit: src/contrib/cvs - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 19:05:48 -0000 peter 2004-06-10 19:05:47 UTC FreeBSD src repository src/contrib/cvs - Imported sources Update of /home/ncvs/src/contrib/cvs In directory repoman.freebsd.org:/tmp/cvs-serv64659 Log Message: Import cvs-1.11.17 onto vendor branch. Status: Vendor Tag: CVSHOME Release Tags: v1_11_17 U src/contrib/cvs/README U src/contrib/cvs/Makefile.in U src/contrib/cvs/configure U src/contrib/cvs/AUTHORS U src/contrib/cvs/COPYING U src/contrib/cvs/COPYING.LIB U src/contrib/cvs/ChangeLog U src/contrib/cvs/INSTALL U src/contrib/cvs/Makefile.am U src/contrib/cvs/NEWS U src/contrib/cvs/TODO U src/contrib/cvs/acinclude.m4 U src/contrib/cvs/aclocal.m4 U src/contrib/cvs/compile U src/contrib/cvs/config.h.in U src/contrib/cvs/configure.in U src/contrib/cvs/depcomp U src/contrib/cvs/install-sh U src/contrib/cvs/mdate-sh U src/contrib/cvs/FAQ U src/contrib/cvs/missing U src/contrib/cvs/mkinstalldirs U src/contrib/cvs/BUGS U src/contrib/cvs/ChangeLog.zoo U src/contrib/cvs/DEVEL-CVS U src/contrib/cvs/HACKING U src/contrib/cvs/MINOR-BUGS U src/contrib/cvs/PROJECTS U src/contrib/cvs/TESTS U src/contrib/cvs/cvs-format.el U src/contrib/cvs/mktemp.sh U src/contrib/cvs/contrib/README U src/contrib/cvs/contrib/Makefile.in U src/contrib/cvs/contrib/ChangeLog U src/contrib/cvs/contrib/Makefile.am U src/contrib/cvs/contrib/check_cvs.in U src/contrib/cvs/contrib/clmerge.in U src/contrib/cvs/contrib/cln_hist.in U src/contrib/cvs/contrib/commit_prep.in U src/contrib/cvs/contrib/cvs_acls.in U src/contrib/cvs/contrib/log.in U src/contrib/cvs/contrib/log_accum.in U src/contrib/cvs/contrib/mfpipe.in U src/contrib/cvs/contrib/pvcs2rcs.in U src/contrib/cvs/contrib/rcs2log.sh U src/contrib/cvs/contrib/rcslock.in U src/contrib/cvs/contrib/sccs2rcs.in U src/contrib/cvs/contrib/intro.doc U src/contrib/cvs/contrib/cvscheck.man U src/contrib/cvs/contrib/cvs2vendor.sh U src/contrib/cvs/contrib/cvscheck.sh U src/contrib/cvs/contrib/cvshelp.man U src/contrib/cvs/contrib/debug_check_log.sh U src/contrib/cvs/contrib/descend.sh U src/contrib/cvs/contrib/descend.man U src/contrib/cvs/contrib/dirfns.shar U src/contrib/cvs/contrib/rcs-to-cvs.sh U src/contrib/cvs/contrib/rcs2sccs.sh U src/contrib/cvs/doc/Makefile.in U src/contrib/cvs/doc/ChangeLog U src/contrib/cvs/doc/Makefile.am U src/contrib/cvs/doc/mdate-sh N src/contrib/cvs/doc/mkman.in U src/contrib/cvs/doc/stamp-1 U src/contrib/cvs/doc/stamp-vti U src/contrib/cvs/doc/version-client.texi U src/contrib/cvs/doc/version.texi U src/contrib/cvs/doc/cvs.texinfo U src/contrib/cvs/doc/cvsclient.texi U src/contrib/cvs/doc/ChangeLog.fsf U src/contrib/cvs/doc/RCSFILES N src/contrib/cvs/doc/cvs.1 U src/contrib/cvs/doc/cvs-paper.ms N src/contrib/cvs/doc/cvs.man.header N src/contrib/cvs/doc/cvs.man.footer U src/contrib/cvs/src/Makefile.in U src/contrib/cvs/src/ChangeLog U src/contrib/cvs/src/Makefile.am U src/contrib/cvs/src/cvsbug.in U src/contrib/cvs/src/add.c U src/contrib/cvs/src/admin.c U src/contrib/cvs/src/annotate.c U src/contrib/cvs/src/buffer.c U src/contrib/cvs/src/checkin.c U src/contrib/cvs/src/checkout.c U src/contrib/cvs/src/classify.c C src/contrib/cvs/src/client.c C src/contrib/cvs/src/commit.c U src/contrib/cvs/src/create_adm.c U src/contrib/cvs/src/cvsrc.c U src/contrib/cvs/src/diff.c U src/contrib/cvs/src/edit.c U src/contrib/cvs/src/entries.c U src/contrib/cvs/src/error.c U src/contrib/cvs/src/expand_path.c U src/contrib/cvs/src/fileattr.c C src/contrib/cvs/src/filesubr.c U src/contrib/cvs/src/find_names.c U src/contrib/cvs/src/hardlink.c U src/contrib/cvs/src/hash.c U src/contrib/cvs/src/history.c U src/contrib/cvs/src/ignore.c U src/contrib/cvs/src/import.c U src/contrib/cvs/src/lock.c U src/contrib/cvs/src/log.c U src/contrib/cvs/src/login.c U src/contrib/cvs/src/logmsg.c U src/contrib/cvs/src/main.c U src/contrib/cvs/src/mkmodules.c U src/contrib/cvs/src/modules.c U src/contrib/cvs/src/myndbm.c U src/contrib/cvs/src/no_diff.c U src/contrib/cvs/src/parseinfo.c U src/contrib/cvs/src/patch.c U src/contrib/cvs/src/rcs.c U src/contrib/cvs/src/rcscmds.c U src/contrib/cvs/src/recurse.c U src/contrib/cvs/src/release.c U src/contrib/cvs/src/remove.c U src/contrib/cvs/src/repos.c U src/contrib/cvs/src/root.c U src/contrib/cvs/src/run.c U src/contrib/cvs/src/scramble.c C src/contrib/cvs/src/server.c U src/contrib/cvs/src/stack.c U src/contrib/cvs/src/status.c U src/contrib/cvs/src/subr.c U src/contrib/cvs/src/tag.c C src/contrib/cvs/src/update.c U src/contrib/cvs/src/version.c U src/contrib/cvs/src/vers_ts.c U src/contrib/cvs/src/watch.c U src/contrib/cvs/src/wrapper.c U src/contrib/cvs/src/zlib.c U src/contrib/cvs/src/buffer.h U src/contrib/cvs/src/client.h C src/contrib/cvs/src/cvs.h U src/contrib/cvs/src/edit.h U src/contrib/cvs/src/error.h U src/contrib/cvs/src/fileattr.h U src/contrib/cvs/src/hardlink.h U src/contrib/cvs/src/hash.h U src/contrib/cvs/src/history.h U src/contrib/cvs/src/myndbm.h U src/contrib/cvs/src/rcs.h U src/contrib/cvs/src/root.h U src/contrib/cvs/src/server.h U src/contrib/cvs/src/stack.h U src/contrib/cvs/src/update.h U src/contrib/cvs/src/watch.h U src/contrib/cvs/src/ChangeLog-9194 U src/contrib/cvs/src/ChangeLog-9395 U src/contrib/cvs/src/ChangeLog-96 U src/contrib/cvs/src/sanity.sh U src/contrib/cvs/src/ChangeLog-97 U src/contrib/cvs/lib/Makefile.in U src/contrib/cvs/lib/ChangeLog U src/contrib/cvs/lib/Makefile.am U src/contrib/cvs/lib/dup2.c U src/contrib/cvs/lib/fncase.c U src/contrib/cvs/lib/fnmatch.c U src/contrib/cvs/lib/fnmatch.h.in U src/contrib/cvs/lib/ftruncate.c U src/contrib/cvs/lib/gethostname.c U src/contrib/cvs/lib/memmove.c U src/contrib/cvs/lib/mkdir.c U src/contrib/cvs/lib/rename.c U src/contrib/cvs/lib/strerror.c U src/contrib/cvs/lib/strstr.c U src/contrib/cvs/lib/strtoul.c U src/contrib/cvs/lib/valloc.c U src/contrib/cvs/lib/waitpid.c U src/contrib/cvs/lib/argmatch.c U src/contrib/cvs/lib/getdate.y U src/contrib/cvs/lib/getline.c U src/contrib/cvs/lib/getopt.c U src/contrib/cvs/lib/getopt1.c U src/contrib/cvs/lib/getpass.c U src/contrib/cvs/lib/md5.c U src/contrib/cvs/lib/regex.c U src/contrib/cvs/lib/savecwd.c U src/contrib/cvs/lib/sighandle.c U src/contrib/cvs/lib/stripslash.c U src/contrib/cvs/lib/xgetwd.c U src/contrib/cvs/lib/yesno.c U src/contrib/cvs/lib/getline.h U src/contrib/cvs/lib/getopt.h U src/contrib/cvs/lib/getpagesize.h U src/contrib/cvs/lib/md5.h U src/contrib/cvs/lib/regex.h U src/contrib/cvs/lib/savecwd.h U src/contrib/cvs/lib/system.h U src/contrib/cvs/lib/wait.h U src/contrib/cvs/lib/xselect.h U src/contrib/cvs/lib/xtime.h N src/contrib/cvs/lib/xsize.h U src/contrib/cvs/lib/ChangeLog.fsf U src/contrib/cvs/lib/xgssapi.h U src/contrib/cvs/diff/Makefile.in U src/contrib/cvs/diff/ChangeLog U src/contrib/cvs/diff/Makefile.am U src/contrib/cvs/diff/diff.c U src/contrib/cvs/diff/diff3.c U src/contrib/cvs/diff/analyze.c U src/contrib/cvs/diff/cmpbuf.c U src/contrib/cvs/diff/cmpbuf.h U src/contrib/cvs/diff/io.c U src/contrib/cvs/diff/context.c U src/contrib/cvs/diff/ed.c U src/contrib/cvs/diff/normal.c U src/contrib/cvs/diff/ifdef.c U src/contrib/cvs/diff/util.c U src/contrib/cvs/diff/dir.c U src/contrib/cvs/diff/version.c U src/contrib/cvs/diff/diff.h U src/contrib/cvs/diff/side.c U src/contrib/cvs/diff/system.h U src/contrib/cvs/diff/diffrun.h U src/contrib/cvs/diff/diagmeet.note U src/contrib/cvs/man/Makefile.in U src/contrib/cvs/man/ChangeLog U src/contrib/cvs/man/Makefile.am U src/contrib/cvs/man/cvs.5 U src/contrib/cvs/man/cvsbug.8 U src/contrib/cvs/tools/README U src/contrib/cvs/tools/Makefile.in U src/contrib/cvs/tools/ChangeLog U src/contrib/cvs/tools/Makefile.am 6 conflicts created by this import. Use the following command to help the merge: cvs checkout -jCVSHOME:yesterday -jCVSHOME src/contrib/cvs From owner-cvs-src@FreeBSD.ORG Thu Jun 10 19:13:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68A4D16A4CE; Thu, 10 Jun 2004 19:13:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DFC443D46; Thu, 10 Jun 2004 19:13:12 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AJCpnc066738; Thu, 10 Jun 2004 19:12:51 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AJCpV5066737; Thu, 10 Jun 2004 19:12:51 GMT (envelope-from peter) Message-Id: <200406101912.i5AJCpV5066737@repoman.freebsd.org> From: Peter Wemm Date: Thu, 10 Jun 2004 19:12:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/cvs/src client.c commit.c cvs.h filesubr.c server.c update.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 19:13:12 -0000 peter 2004-06-10 19:12:51 UTC FreeBSD src repository Modified files: contrib/cvs/src client.c commit.c cvs.h filesubr.c server.c update.c Log: Merge 1.11.15+ -> 1.11.17 changes onto mainline. I've left cvs.1 alone for now. Revision Changes Path 1.12 +1 -1 src/contrib/cvs/src/client.c 1.15 +83 -42 src/contrib/cvs/src/commit.c 1.20 +4 -1 src/contrib/cvs/src/cvs.h 1.12 +7 -1 src/contrib/cvs/src/filesubr.c 1.24 +66 -10 src/contrib/cvs/src/server.c 1.14 +33 -17 src/contrib/cvs/src/update.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 19:17:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9561516A4CE; Thu, 10 Jun 2004 19:17:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B7BF43D54; Thu, 10 Jun 2004 19:17:53 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AJHKjq066974; Thu, 10 Jun 2004 19:17:21 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AJHKLu066973; Thu, 10 Jun 2004 19:17:20 GMT (envelope-from peter) Message-Id: <200406101917.i5AJHKLu066973@repoman.freebsd.org> From: Peter Wemm Date: Thu, 10 Jun 2004 19:17:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/usr.bin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 19:17:53 -0000 peter 2004-06-10 19:17:20 UTC FreeBSD src repository Modified files: gnu/usr.bin Makefile Log: Turn cvs back on after import; that was less painful than I expected. Revision Changes Path 1.80 +1 -1 src/gnu/usr.bin/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jun 10 19:30:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 360D816A4CE; Thu, 10 Jun 2004 19:30:00 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B5ED43D49; Thu, 10 Jun 2004 19:29:59 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 97087530A; Thu, 10 Jun 2004 21:29:28 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 47E975309; Thu, 10 Jun 2004 21:29:21 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id E060E33C71; Thu, 10 Jun 2004 21:29:20 +0200 (CEST) To: Peter Wemm References: <200406101912.i5AJCpV5066737@repoman.freebsd.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Thu, 10 Jun 2004 21:29:20 +0200 In-Reply-To: <200406101912.i5AJCpV5066737@repoman.freebsd.org> (Peter Wemm's message of "Thu, 10 Jun 2004 19:12:51 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/cvs/src client.c commit.c cvs.h filesubr.c server.c update.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 19:30:00 -0000 Peter Wemm writes: > Log: > Merge 1.11.15+ -> 1.11.17 changes onto mainline. I've left cvs.1 alone > for now. Thanks! DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Thu Jun 10 19:33:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BB9716A4D3; Thu, 10 Jun 2004 19:33:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8333243D5A; Thu, 10 Jun 2004 19:33:40 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AJXQXs070828; Thu, 10 Jun 2004 19:33:26 GMT (envelope-from brian@repoman.freebsd.org) Received: (from brian@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AJXQPh070827; Thu, 10 Jun 2004 19:33:26 GMT (envelope-from brian) Message-Id: <200406101933.i5AJXQPh070827@repoman.freebsd.org> From: Brian Somers Date: Thu, 10 Jun 2004 19:33:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 19:33:40 -0000 brian 2004-06-10 19:33:26 UTC FreeBSD src repository Modified files: release Makefile Log: Die if make buildworld fails -- don't wait 'till installworld can't find what it needs. Revision Changes Path 1.845 +1 -1 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jun 10 19:56:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FF4616A4CE; Thu, 10 Jun 2004 19:56:17 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 986C443D48; Thu, 10 Jun 2004 19:56:16 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i5AK1rLe060716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Jun 2004 23:01:55 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i5AJtwfb002515; Thu, 10 Jun 2004 22:55:58 +0300 (EEST) (envelope-from ru) Date: Thu, 10 Jun 2004 22:55:58 +0300 From: Ruslan Ermilov To: Brian Somers Message-ID: <20040610195558.GA2491@ip.net.ua> References: <200406101933.i5AJXQPh070827@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <200406101933.i5AJXQPh070827@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 19:56:17 -0000 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 10, 2004 at 07:33:26PM +0000, Brian Somers wrote: > brian 2004-06-10 19:33:26 UTC >=20 > FreeBSD src repository >=20 > Modified files: > release Makefile=20 > Log: > Die if make buildworld fails -- don't wait 'till installworld can't find > what it needs. > =20 > Revision Changes Path > 1.845 +1 -1 src/release/Makefile >=20 Good catch! Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --17pEHd4RhPHOinZp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAyLzNqRfpzJluFF4RAgZyAKCHqLnEJ7eN8i4XKh1f7aBpIrppEACfbmbg Kcs8KSwRUocE1R25/SBdk9E= =Agv7 -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp-- From owner-cvs-src@FreeBSD.ORG Thu Jun 10 20:03:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4FA716A4CE; Thu, 10 Jun 2004 20:03:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BAB443D2F; Thu, 10 Jun 2004 20:03:58 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AK3kKA078067; Thu, 10 Jun 2004 20:03:46 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AK3kYY078066; Thu, 10 Jun 2004 20:03:46 GMT (envelope-from jhb) Message-Id: <200406102003.i5AK3kYY078066@repoman.freebsd.org> From: John Baldwin Date: Thu, 10 Jun 2004 20:03:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/acpica madt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 20:03:58 -0000 jhb 2004-06-10 20:03:46 UTC FreeBSD src repository Modified files: sys/i386/acpica madt.c Log: Completely ignore disabled CPU entries as their APIC IDs tend to be invalid. Revision Changes Path 1.17 +8 -13 src/sys/i386/acpica/madt.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 20:20:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91C0C16A4CE; Thu, 10 Jun 2004 20:20:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 77EFA43D49; Thu, 10 Jun 2004 20:20:47 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AKKbci080427; Thu, 10 Jun 2004 20:20:37 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AKKbPF080426; Thu, 10 Jun 2004 20:20:37 GMT (envelope-from ru) Message-Id: <200406102020.i5AKKbPF080426@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 10 Jun 2004 20:20:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 20:20:47 -0000 ru 2004-06-10 20:20:37 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c Log: init_tables() must be run after sys/net/route.c:route_init(). Revision Changes Path 1.61 +4 -1 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 20:31:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2A1916A4CE; Thu, 10 Jun 2004 20:31:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FD2E43D39; Thu, 10 Jun 2004 20:31:05 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AKV0lu082813; Thu, 10 Jun 2004 20:31:00 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AKV0WV082812; Thu, 10 Jun 2004 20:31:00 GMT (envelope-from jhb) Message-Id: <200406102031.i5AKV0WV082812@repoman.freebsd.org> From: John Baldwin Date: Thu, 10 Jun 2004 20:31:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/include/pc bios.h src/sys/amd64/amd64 machdep.c src/sys/amd64/include md_var.h src/sys/dev/fb vga.c src/sys/dev/kbd atkbd.c src/sys/i386/bios mca_machdep.c smapi.c smbios.c vpd.c src/sys/i386/i386 machdep.c symbols.raw ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 20:31:05 -0000 jhb 2004-06-10 20:31:00 UTC FreeBSD src repository Modified files: sys/alpha/include/pc bios.h sys/amd64/amd64 machdep.c sys/amd64/include md_var.h sys/dev/fb vga.c sys/dev/kbd atkbd.c sys/i386/bios mca_machdep.c smapi.c smbios.c vpd.c sys/i386/i386 machdep.c symbols.raw sys/i386/include md_var.h sys/i386/include/pc bios.h sys/i386/isa vesa.c sys/i386/pci pci_pir.c sys/isa syscons_isa.c sys/pc98/i386 machdep.c Log: Remove atdevbase and replace it's remaining uses with direct references to KERNBASE instead. Revision Changes Path 1.6 +0 -5 src/sys/alpha/include/pc/bios.h 1.609 +0 -3 src/sys/amd64/amd64/machdep.c 1.75 +0 -1 src/sys/amd64/include/md_var.h 1.30 +1 -1 src/sys/dev/fb/vga.c 1.43 +1 -0 src/sys/dev/kbd/atkbd.c 1.8 +1 -0 src/sys/i386/bios/mca_machdep.c 1.12 +1 -0 src/sys/i386/bios/smapi.c 1.4 +1 -0 src/sys/i386/bios/smbios.c 1.4 +1 -0 src/sys/i386/bios/vpd.c 1.589 +1 -2 src/sys/i386/i386/machdep.c 1.16 +0 -1 src/sys/i386/i386/symbols.raw 1.69 +0 -1 src/sys/i386/include/md_var.h 1.16 +2 -2 src/sys/i386/include/pc/bios.h 1.45 +1 -0 src/sys/i386/isa/vesa.c 1.113 +1 -0 src/sys/i386/pci/pci_pir.c 1.25 +1 -0 src/sys/isa/syscons_isa.c 1.335 +1 -2 src/sys/pc98/i386/machdep.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 20:43:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB04C16A4CE; Thu, 10 Jun 2004 20:43:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C170743D46; Thu, 10 Jun 2004 20:43:20 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AKh4eQ086699; Thu, 10 Jun 2004 20:43:04 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AKh4dA086698; Thu, 10 Jun 2004 20:43:04 GMT (envelope-from jhb) Message-Id: <200406102043.i5AKh4dA086698@repoman.freebsd.org> From: John Baldwin Date: Thu, 10 Jun 2004 20:43:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/acpica acpi_machdep.c src/sys/i386/i386 bios.c src/sys/i386/include/pc bios.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 20:43:21 -0000 jhb 2004-06-10 20:43:04 UTC FreeBSD src repository Modified files: sys/i386/acpica acpi_machdep.c sys/i386/i386 bios.c sys/i386/include/pc bios.h Log: - Use the correct devclass name ("acpi" vs "ACPI") to detect if acpi0 is present and thus that the PnPBIOS probe should be skipped instead of having ACPI zero out the PnPBIOStable pointer. - Make the PnPBIOStable pointer static to i386/i386/bios.c now that that is the only place it is used. Revision Changes Path 1.21 +0 -6 src/sys/i386/acpica/acpi_machdep.c 1.67 +3 -2 src/sys/i386/i386/bios.c 1.17 +0 -1 src/sys/i386/include/pc/bios.h From owner-cvs-src@FreeBSD.ORG Thu Jun 10 21:03:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D2CA16A4CE; Thu, 10 Jun 2004 21:03:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12F9643D46; Thu, 10 Jun 2004 21:03:35 +0000 (GMT) (envelope-from schweikh@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AL3YTL098272; Thu, 10 Jun 2004 21:03:34 GMT (envelope-from schweikh@repoman.freebsd.org) Received: (from schweikh@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AL3Yfv098271; Thu, 10 Jun 2004 21:03:34 GMT (envelope-from schweikh) Message-Id: <200406102103.i5AL3Yfv098271@repoman.freebsd.org> From: Jens Schweikhardt Date: Thu, 10 Jun 2004 21:03:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/games/fortune/datfiles fortunes2-o X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 21:03:35 -0000 schweikh 2004-06-10 21:03:34 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes2-o Log: Correct assorted typos and grammos. Revision Changes Path 1.27 +3 -3 src/games/fortune/datfiles/fortunes2-o From owner-cvs-src@FreeBSD.ORG Thu Jun 10 21:30:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5626816A4CE; Thu, 10 Jun 2004 21:30:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3AF7343D55; Thu, 10 Jun 2004 21:30:12 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5ALU9eD002844; Thu, 10 Jun 2004 21:30:09 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5ALU8E7002843; Thu, 10 Jun 2004 21:30:08 GMT (envelope-from peter) Message-Id: <200406102130.i5ALU8E7002843@repoman.freebsd.org> From: Peter Wemm Date: Thu, 10 Jun 2004 21:30:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/acpica madt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 21:30:12 -0000 peter 2004-06-10 21:30:08 UTC FreeBSD src repository Modified files: sys/amd64/acpica madt.c Log: Insta-MFi386: ignore disabled cpu apic id's entirely Revision Changes Path 1.14 +8 -13 src/sys/amd64/acpica/madt.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 21:34:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBBEE16A4CE; Thu, 10 Jun 2004 21:34:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D6DDD43D48; Thu, 10 Jun 2004 21:34:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5ALYc2A004705; Thu, 10 Jun 2004 21:34:38 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5ALYcNr004704; Thu, 10 Jun 2004 21:34:38 GMT (envelope-from rwatson) Message-Id: <200406102134.i5ALYcNr004704@repoman.freebsd.org> From: Robert Watson Date: Thu, 10 Jun 2004 21:34:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 21:34:58 -0000 rwatson 2004-06-10 21:34:38 UTC FreeBSD src repository Modified files: sys/kern uipc_usrreq.c Log: Introduce a subsystem lock around UNIX domain sockets in order to protect global and allocated variables. This strategy is derived from work originally developed by BSDi for BSD/OS, and applied to FreeBSD by Sam Leffler: - Add unp_mtx, a global mutex which will protect all UNIX domain socket related variables, structures, etc. - Add UNP_LOCK(), UNP_UNLOCK(), UNP_LOCK_ASSERT() macros. - Acquire unp_mtx on entering most UNIX domain socket code, drop/re-acquire around calls into VFS, and release it on return. - Avoid performing sodupsockaddr() while holding the mutex, so in general move to allocating storage before acquiring the mutex to copy the data. - Make a stack copy of the xucred rather than copying out while holding unp_mtx. Copy the peer credential out after releasing the mutex. - Add additional assertions of vnode locks following VOP_CREATE(). A few notes: - Use of an sx lock for the file list mutex may cause problems with regard to unp_mtx when garbage collection passed file descriptors. - The locking in unp_pcblist() for sysctl monitoring is correct subject to the unpcb zone not returning memory for reuse by other subsystems (consistent with similar existing concerns). - Sam's version of this change, as with the BSD/OS version, made use of both a global lock and per-unpcb locks. However, in practice, the global lock covered all accesses, so I have simplified out the unpcb locks in the interest of getting this merged faster (reducing the overhead but not sacrificing granularity in most cases). We will want to explore possibilities for improving lock granularity in this code in the future. Submitted by: sam Sponsored by: FreeBSD Foundatiuon Obtained from: BSD/OS 5 snapshot provided by BSDi Revision Changes Path 1.122 +193 -58 src/sys/kern/uipc_usrreq.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 21:41:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E8C916A4CE; Thu, 10 Jun 2004 21:41:28 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9556443D2D; Thu, 10 Jun 2004 21:41:27 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i5ALktLI070118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Jun 2004 00:46:57 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i5ALex8a003317; Fri, 11 Jun 2004 00:40:59 +0300 (EEST) (envelope-from ru) Date: Fri, 11 Jun 2004 00:40:59 +0300 From: Ruslan Ermilov To: Max Laier Message-ID: <20040610214059.GA3228@ip.net.ua> References: <200406092010.i59KAcXH025699@repoman.freebsd.org> <200406100445.44763.max@love2party.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: <200406100445.44763.max@love2party.net> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 21:41:28 -0000 --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 10, 2004 at 04:45:37AM +0200, Max Laier wrote: > On Wednesday 09 June 2004 22:10, Ruslan Ermilov wrote: > > ru 2004-06-09 20:10:38 UTC > > > > FreeBSD src repository > > > > Modified files: > > sbin/ipfw ipfw.8 ipfw2.c > > sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c > > Log: > > Introduce a new feature to IPFW2: lookup tables. These are useful > > for handling large sparse address sets. Initial implementation by > > Vsevolod Lobko , refined by me. >=20 > Idea from: pf ;) > Nice! >=20 I've asked Vsevolod, and yes, the original idea attributes to PF. Do PF tables allow addr/mask entries as IPFW tables do (I could not intuit it from reading the pfctl(8) manpage)? One nice difference (and I don't believe PF or IPFilter can do this) is this optional 32-bit tag value with no special meaning. For example, we have several thousands of client IPs, and each client is allowed (through a Web form) to limit bandwidth to some discrete values (0, 64, 128, 256, 512, and "unlimited") in Kbps to/from Ukrainian and foreign networks. We have this all implemented using less than ten IPFW tables: - table 0 lists Ukrainian networks; - table 1 lists all clients and their setting for incoming Ukrainian traffic; - table 2 lists all clients and their setting for outgoing Ukrainian traffic; and so forth. And we have a small set of rules of the form: deny ip from table(1,0) to table(0) // bw=3D0 pipe 1 ip from table(1,128) to table(0) // bw=3D128Kbps pipe 2 ip from table(1,256) to table(0) // bw=3D256Kbps =2E.. where pipes 1 and 2 are configured for a bandwidth of 128 and 256 Kbps, respectively. Tables are continuously updated while rulesets stay the same. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAyNVrqRfpzJluFF4RArt8AJ94ix+IS2vRIiAyjHKKuBb2CI57TwCfePZi zz7PPPVSIx6QfwcSOt3YKmc= =peii -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx-- From owner-cvs-src@FreeBSD.ORG Thu Jun 10 21:49:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA80516A4CE; Thu, 10 Jun 2004 21:49:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E9FC43D31; Thu, 10 Jun 2004 21:49:11 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5ALmpU4006928; Thu, 10 Jun 2004 21:48:51 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5ALmpwI006927; Thu, 10 Jun 2004 21:48:51 GMT (envelope-from marius) Message-Id: <200406102148.i5ALmpwI006927@repoman.freebsd.org> From: Marius Strobl Date: Thu, 10 Jun 2004 21:48:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/pcf pcf_isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 21:49:11 -0000 marius 2004-06-10 21:48:51 UTC FreeBSD src repository Modified files: sys/dev/pcf pcf_isa.c Log: - #define\tFOO\tBAR - Remove two tabs from an otherwise empty line. OK'ed by: nsouch Revision Changes Path 1.3 +2 -2 src/sys/dev/pcf/pcf_isa.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 21:52:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1925516A4CE; Thu, 10 Jun 2004 21:52:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F034A43D1F; Thu, 10 Jun 2004 21:52:06 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5ALpdrP008074; Thu, 10 Jun 2004 21:51:39 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5ALpdJt008070; Thu, 10 Jun 2004 21:51:39 GMT (envelope-from marius) Message-Id: <200406102151.i5ALpdJt008070@repoman.freebsd.org> From: Marius Strobl Date: Thu, 10 Jun 2004 21:51:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/pcf pcf_isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 21:52:07 -0000 marius 2004-06-10 21:51:39 UTC FreeBSD src repository Modified files: sys/dev/pcf pcf_isa.c Log: - Add missing . - s,pcf_,pcf_isa, to better reflect the purpose of this front-end and to avoid conflicts. - Don't use this front-end for attaching to EBus, declaring it as an EBus driver was a cut&paste accident according to joerg. OK'ed by: joerg, nsouch Revision Changes Path 1.4 +20 -20 src/sys/dev/pcf/pcf_isa.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 21:53:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC9EE16A4CE; Thu, 10 Jun 2004 21:53:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF5B843D2F; Thu, 10 Jun 2004 21:53:04 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5ALr4e7008888; Thu, 10 Jun 2004 21:53:04 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5ALr4Wd008887; Thu, 10 Jun 2004 21:53:04 GMT (envelope-from marius) Message-Id: <200406102153.i5ALr4Wd008887@repoman.freebsd.org> From: Marius Strobl Date: Thu, 10 Jun 2004 21:53:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/pcf envctrl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 21:53:04 -0000 marius 2004-06-10 21:53:04 UTC FreeBSD src repository Modified files: sys/dev/pcf envctrl.c Log: - Add missing . - Use "envctrl" as the name when registering this module rather than "pcf"; we can't have "pcf" as the name for all pcf(4) front-ends or we would get conflicts. OK'ed by: joerg Revision Changes Path 1.2 +4 -3 src/sys/dev/pcf/envctrl.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 21:57:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CD2B16A50B; Thu, 10 Jun 2004 21:57:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 23CC243D46; Thu, 10 Jun 2004 21:57:15 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5ALurYH009114; Thu, 10 Jun 2004 21:56:53 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5ALurm1009113; Thu, 10 Jun 2004 21:56:53 GMT (envelope-from marius) Message-Id: <200406102156.i5ALurm1009113@repoman.freebsd.org> From: Marius Strobl Date: Thu, 10 Jun 2004 21:56:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/pcf pcf_ebus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 21:57:16 -0000 marius 2004-06-10 21:56:53 UTC FreeBSD src repository Added files: sys/dev/pcf pcf_ebus.c Log: Add a first version of a pcf(4) front-end for the Sun i2c devices ("i2c" is the actual name here) on EBus and which are PCF8584 (on systems having a boot-bus controller the i2c are said to not be a PCF8584). Similar to the SUNW,envctrl devices, onboard slaves for monitoring fans, temperatures and such hang off of these i2c devices. But there's also stuff like EEPROMs housing the hostid of the system and the boards usally have a connector to add custom slave devices (on CP1500 there's actually a second PCF8584 with its own I2C bus for these). This driver already works fine but I'm not yet sure if access to the slave devices on CP1400/CP1500 marked as "reserved for factory use" in the docs should be blocked (most likely these are the voltage controllers wich aren't meant to be controller by software and even not by the firmware). Once the issues with polled mode are fixed in the common pcf(4) part in pcf.c, this front-end should probably honour the poll-mode property of the i2c devices. Tested on Ultra AXe and CP1500 (Netra t1 100). OK'ed by: joerg, nsouch Revision Changes Path 1.1 +261 -0 src/sys/dev/pcf/pcf_ebus.c (new) From owner-cvs-src@FreeBSD.ORG Thu Jun 10 22:01:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F419616A4CE; Thu, 10 Jun 2004 22:01:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D694243D1D; Thu, 10 Jun 2004 22:01:10 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AM0wmF009321; Thu, 10 Jun 2004 22:00:58 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AM0w6L009320; Thu, 10 Jun 2004 22:00:58 GMT (envelope-from peter) Message-Id: <200406102200.i5AM0w6L009320@repoman.freebsd.org> From: Peter Wemm Date: Thu, 10 Jun 2004 22:00:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/include profile.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 22:01:11 -0000 peter 2004-06-10 22:00:58 UTC FreeBSD src repository Modified files: sys/amd64/include profile.h Log: Make profiling work for varargs functions.. %al is an additional argument which indicates the number of xmm registers used in the varargs. This stops the explosion that happened when profiling printf() etc. Revision Changes Path 1.40 +2 -0 src/sys/amd64/include/profile.h From owner-cvs-src@FreeBSD.ORG Thu Jun 10 22:02:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB97416A4CE; Thu, 10 Jun 2004 22:02:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D83943D1F; Thu, 10 Jun 2004 22:02:38 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AM2QQQ010803; Thu, 10 Jun 2004 22:02:26 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AM2QIK010799; Thu, 10 Jun 2004 22:02:26 GMT (envelope-from peter) Message-Id: <200406102202.i5AM2QIK010799@repoman.freebsd.org> From: Peter Wemm Date: Thu, 10 Jun 2004 22:02:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/include asm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 22:02:38 -0000 peter 2004-06-10 22:02:26 UTC FreeBSD src repository Modified files: sys/amd64/include asm.h Log: Argh. Add the mini-stack-frame back in for mcount's benefit for syscall stubs. Revision Changes Path 1.16 +4 -0 src/sys/amd64/include/asm.h From owner-cvs-src@FreeBSD.ORG Thu Jun 10 22:16:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A245516A4CE; Thu, 10 Jun 2004 22:16:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 849D543D39; Thu, 10 Jun 2004 22:16:09 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AMFqvD014331; Thu, 10 Jun 2004 22:15:52 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AMFqUK014330; Thu, 10 Jun 2004 22:15:52 GMT (envelope-from marius) Message-Id: <200406102215.i5AMFqUK014330@repoman.freebsd.org> From: Marius Strobl Date: Thu, 10 Jun 2004 22:15:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ofw ofw_console.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 22:16:09 -0000 marius 2004-06-10 22:15:52 UTC FreeBSD src repository Modified files: sys/dev/ofw ofw_console.c Log: Remove second and __FBSDID. Revision Changes Path 1.23 +0 -3 src/sys/dev/ofw/ofw_console.c From owner-cvs-src@FreeBSD.ORG Thu Jun 10 22:18:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FE6416A4D0; Thu, 10 Jun 2004 22:18:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3895843D39; Thu, 10 Jun 2004 22:18:51 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5AMIX1M014397; Thu, 10 Jun 2004 22:18:33 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5AMIXoZ014396; Thu, 10 Jun 2004 22:18:33 GMT (envelope-from peter) Message-Id: <200406102218.i5AMIXoZ014396@repoman.freebsd.org> From: Peter Wemm Date: Thu, 10 Jun 2004 22:18:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/usr.bin/cc/cc_tools Makefile freebsd64-fix.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 22:18:51 -0000 peter 2004-06-10 22:18:33 UTC FreeBSD src repository Modified files: gnu/usr.bin/cc/cc_tools Makefile Added files: gnu/usr.bin/cc/cc_tools freebsd64-fix.h Log: The gcc/config/i386/freebsd64.h file neglects to override the default (bogus, application name space) mcount function name on amd64. Override it here instead. I've done it this way to avoid touching gcc source while 3.4 is in progress, and this is the smallest, lowest impact I could come up with. Adding a patch touches about 10-14 lines of Makefile, this touches only 1. This will likely go away with the 3.4 import. I spoke with Alexander about this a few days ago, but waited until after sorting out some of the other bugs in the userland profiling. Revision Changes Path 1.76 +1 -0 src/gnu/usr.bin/cc/cc_tools/Makefile 1.1 +9 -0 src/gnu/usr.bin/cc/cc_tools/freebsd64-fix.h (new) From owner-cvs-src@FreeBSD.ORG Fri Jun 11 00:35:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A033616A4CE; Fri, 11 Jun 2004 00:35:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 81E0B43D2D; Fri, 11 Jun 2004 00:35:37 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B0ZUWn044695; Fri, 11 Jun 2004 00:35:30 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B0ZUZj044694; Fri, 11 Jun 2004 00:35:30 GMT (envelope-from peter) Message-Id: <200406110035.i5B0ZUZj044694@repoman.freebsd.org> From: Peter Wemm Date: Fri, 11 Jun 2004 00:35:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/usr.bin/cc/cc_tools Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 00:35:37 -0000 peter 2004-06-11 00:35:29 UTC FreeBSD src repository Modified files: gnu/usr.bin/cc/cc_tools Makefile Log: Revise previous commit - I managed to mess up a 1-line change and broke amd64 world. The csu code evalues this Makefile with a different origin. Revision Changes Path 1.77 +1 -1 src/gnu/usr.bin/cc/cc_tools/Makefile From owner-cvs-src@FreeBSD.ORG Fri Jun 11 01:25:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 98A5A16A4CE; Fri, 11 Jun 2004 01:25:37 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BE5043D31; Fri, 11 Jun 2004 01:25:37 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 368565C81A; Thu, 10 Jun 2004 18:25:13 -0700 (PDT) Date: Thu, 10 Jun 2004 18:25:13 -0700 From: Alfred Perlstein To: Robert Watson Message-ID: <20040611012513.GI78955@elvis.mu.org> References: <200406102134.i5ALYcNr004704@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406102134.i5ALYcNr004704@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 01:25:37 -0000 * Robert Watson [040610 14:34] wrote: > rwatson 2004-06-10 21:34:38 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_usrreq.c > Log: > Introduce a subsystem lock around UNIX domain sockets in order to protect > global and allocated variables. This strategy is derived from work > originally developed by BSDi for BSD/OS, and applied to FreeBSD by Sam > Leffler: > > - Use of an sx lock for the file list mutex may cause problems with regard > to unp_mtx when garbage collection passed file descriptors. That is true, but I don't think there is a reason to hold the UNP lock inside of unp_gc except to protect the unp_gcing variable and when calling into unp_scan. You might be able to gloss over all of it by just using an sx lock instead of a mutex for the UNP lock. > - The locking in unp_pcblist() for sysctl monitoring is correct subject to > the unpcb zone not returning memory for reuse by other subsystems > (consistent with similar existing concerns). > > - Sam's version of this change, as with the BSD/OS version, made use of > both a global lock and per-unpcb locks. However, in practice, the > global lock covered all accesses, so I have simplified out the unpcb > locks in the interest of getting this merged faster (reducing the > overhead but not sacrificing granularity in most cases). We will want > to explore possibilities for improving lock granularity in this code in > the future. I noticed this in the BSD/os version, it was sort of like... "the global lock covers everything, what's the point of the underlying locks..?" Anyhow, good work, but the unp_gc stuff is surely going to bite us and needs to be fixed. -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Fri Jun 11 01:26:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 63A2316A4CE; Fri, 11 Jun 2004 01:26:21 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1F6F43D4C; Fri, 11 Jun 2004 01:26:20 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i5B1OpM7047626; Thu, 10 Jun 2004 21:24:51 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i5B1Op0l047622; Thu, 10 Jun 2004 21:24:51 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 10 Jun 2004 21:24:51 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200406102134.i5ALYcNr004704@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 01:26:21 -0000 On Thu, 10 Jun 2004, Robert Watson wrote: > Submitted by: sam Forgot to mention: Reviewed by: "George V.Neville-Neil" Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Fri Jun 11 01:30:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2AE716A4CE; Fri, 11 Jun 2004 01:30:35 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id A580C43D58; Fri, 11 Jun 2004 01:30:35 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id AA72B5C82D; Thu, 10 Jun 2004 18:30:23 -0700 (PDT) Date: Thu, 10 Jun 2004 18:30:23 -0700 From: Alfred Perlstein To: Robert Watson Message-ID: <20040611013023.GJ78955@elvis.mu.org> References: <200406102134.i5ALYcNr004704@repoman.freebsd.org> <20040611012513.GI78955@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040611012513.GI78955@elvis.mu.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 01:30:35 -0000 * Alfred Perlstein [040610 18:26] wrote: > * Robert Watson [040610 14:34] wrote: > > rwatson 2004-06-10 21:34:38 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern uipc_usrreq.c > > Log: > > Introduce a subsystem lock around UNIX domain sockets in order to protect > > global and allocated variables. This strategy is derived from work > > originally developed by BSDi for BSD/OS, and applied to FreeBSD by Sam > > Leffler: There's also a bug here in the locking I added for files/filedescs. On line 1525 nfiles is accessed without the filelist_lock held, so its value is inconsistant. A fix would be to peek at nfiles, do the allocation, then lock the filelist lock, then check the value to see if it changed if it changed to something lower, then free and re-malloc more memory. -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Fri Jun 11 01:36:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D441016A4CE; Fri, 11 Jun 2004 01:36:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B462A43D2D; Fri, 11 Jun 2004 01:36:06 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B1ZuwO063938; Fri, 11 Jun 2004 01:35:56 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B1ZuxC063937; Fri, 11 Jun 2004 01:35:56 GMT (envelope-from kientzle) Message-Id: <200406110135.i5B1ZuxC063937@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 11 Jun 2004 01:35:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar bsdtar.1 bsdtar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 01:36:07 -0000 kientzle 2004-06-11 01:35:56 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar.1 bsdtar.c Log: Oops: gtar's --dereference should be a synonym for bsdtar's -L, not -H. Pointed out by: devel/nspr port Thanks to: Kris Kennaway Revision Changes Path 1.10 +2 -2 src/usr.bin/tar/bsdtar.1 1.24 +1 -1 src/usr.bin/tar/bsdtar.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 01:54:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1979316A4CE; Fri, 11 Jun 2004 01:54:56 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A59643D5E; Fri, 11 Jun 2004 01:54:55 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.11/8.12.11) with ESMTP id i5B1srCI017645; Fri, 11 Jun 2004 05:54:53 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.11/8.12.11/Submit) id i5B1srjA017644; Fri, 11 Jun 2004 05:54:53 +0400 (MSD) (envelope-from ache) Date: Fri, 11 Jun 2004 05:54:53 +0400 From: Andrey Chernov To: Robert Watson Message-ID: <20040611015453.GA17618@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Robert Watson , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200406102134.i5ALYcNr004704@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406102134.i5ALYcNr004704@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.25.0.62; VDF 6.25.0.90 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 01:54:56 -0000 On Thu, Jun 10, 2004 at 09:34:38PM +0000, Robert Watson wrote: > Introduce a subsystem lock around UNIX domain sockets in order to protect > global and allocated variables. This strategy is derived from work > originally developed by BSDi for BSD/OS, and applied to FreeBSD by Sam > Leffler: Is it could fix recent -current panics in sosend() I report? -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Fri Jun 11 02:18:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F22A716A4CE; Fri, 11 Jun 2004 02:18:07 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 840D243D55; Fri, 11 Jun 2004 02:18:07 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i5B2Gp7H048543; Thu, 10 Jun 2004 22:16:51 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i5B2GpIl048540; Thu, 10 Jun 2004 22:16:51 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 10 Jun 2004 22:16:51 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <20040611012513.GI78955@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:18:08 -0000 On Thu, 10 Jun 2004, Alfred Perlstein wrote: > > - Use of an sx lock for the file list mutex may cause problems with regard > > to unp_mtx when garbage collection passed file descriptors. > > That is true, but I don't think there is a reason to hold the UNP lock > inside of unp_gc except to protect the unp_gcing variable and when > calling into unp_scan. > > You might be able to gloss over all of it by just using an sx lock > instead of a mutex for the UNP lock. Yeah. Most of it is pretty reasonable, but the unp_gc() bit is both one of the more sensitive bits of our kernel code, and one of the harder bits to handle lockingwise as it tends to reach across a lot of layers. George suggested using an sx lock for unp_gcing, actually, which I think is a good idea. I'm going to have my hands off the UNIX domain socket code except for merging socket buffer locking, so if this is something you're interested in looking at, that would be wonderful. My current plan is to merge the basic first pass of the locking code, then revisit a lot of the details. > > - The locking in unp_pcblist() for sysctl monitoring is correct subject to > > the unpcb zone not returning memory for reuse by other subsystems > > (consistent with similar existing concerns). > > > > - Sam's version of this change, as with the BSD/OS version, made use of > > both a global lock and per-unpcb locks. However, in practice, the > > global lock covered all accesses, so I have simplified out the unpcb > > locks in the interest of getting this merged faster (reducing the > > overhead but not sacrificing granularity in most cases). We will want > > to explore possibilities for improving lock granularity in this code in > > the future. > > I noticed this in the BSD/os version, it was sort of like... "the > global lock covers everything, what's the point of the underlying > locks..?" Well, I think the goal here was similar to that in the inpcbinfo code: use a global lock as a pseudo-refcount/holder to prevent GC'ing of the objects during use. In the TCP/UDP code, the macros offer a reader/writer model, but in practice it's implemented with a mutex. Presumably their intent was to get the basic bits done, then do a lot of profiling to decide whether the added cost of reader/writer was worth it, whether to move more towards true reference counting, per-cpu, etc. However, I ended up removing that before merging to CVS because there didn't appear to be any resolution of the lock order concern between two unpcb mutexes. > Anyhow, good work, but the unp_gc stuff is surely going to bite us and > needs to be fixed. Agreed. If the caller doesn't mind us dropping the unp_mtx, the first logical thing to try is to replace unp_gcing with an sx lock (or the like), and only acquire unp_mtx when calling into code that needs it. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Fri Jun 11 02:19:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE98916A4D0; Fri, 11 Jun 2004 02:19:20 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D96C43D46; Fri, 11 Jun 2004 02:19:20 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i5B2I6Sx048564; Thu, 10 Jun 2004 22:18:06 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i5B2I69A048561; Thu, 10 Jun 2004 22:18:06 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 10 Jun 2004 22:18:06 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Andrey Chernov In-Reply-To: <20040611015453.GA17618@nagual.pp.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:19:21 -0000 On Fri, 11 Jun 2004, Andrey Chernov wrote: > On Thu, Jun 10, 2004 at 09:34:38PM +0000, Robert Watson wrote: > > Introduce a subsystem lock around UNIX domain sockets in order to protect > > global and allocated variables. This strategy is derived from work > > originally developed by BSDi for BSD/OS, and applied to FreeBSD by Sam > > Leffler: > > Is it could fix recent -current panics in sosend() I report? No, because Giant is held over all of this code still, this should neither introduce nor correct any race conditions or corruption issues (ideally). However, I'm not sure I've seen your sosend() report -- is there a PR I can look at? Have you tried running with the socket buffer debugging option turned on? Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Fri Jun 11 02:20:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D5C1016A4CE; Fri, 11 Jun 2004 02:20:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B761B43D46; Fri, 11 Jun 2004 02:20:37 +0000 (GMT) (envelope-from green@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B2KbSC073052; Fri, 11 Jun 2004 02:20:37 GMT (envelope-from green@repoman.freebsd.org) Received: (from green@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B2KboB073051; Fri, 11 Jun 2004 02:20:37 GMT (envelope-from green) Message-Id: <200406110220.i5B2KboB073051@repoman.freebsd.org> From: Brian Feldman Date: Fri, 11 Jun 2004 02:20:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_sysctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:20:38 -0000 green 2004-06-11 02:20:37 UTC FreeBSD src repository Modified files: sys/kern kern_sysctl.c Log: Make sysctl_wire_old_buffer() respect ENOMEM from vslock() by marking the valid length as 0. This prevents vsunlock() from removing a system wire from memory that was not successfully wired (by us). Submitted by: tegge Revision Changes Path 1.157 +5 -2 src/sys/kern/kern_sysctl.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 02:22:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 680) id C074116A4D0; Fri, 11 Jun 2004 02:22:47 +0000 (GMT) Date: Fri, 11 Jun 2004 02:22:47 +0000 From: Darren Reed To: Ruslan Ermilov Message-ID: <20040611022247.GA40799@hub.freebsd.org> References: <200406092010.i59KAcXH025699@repoman.freebsd.org> <200406100445.44763.max@love2party.net> <20040610214059.GA3228@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040610214059.GA3228@ip.net.ua> User-Agent: Mutt/1.4.1i cc: Max Laier cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:22:47 -0000 On Fri, Jun 11, 2004 at 12:40:59AM +0300, Ruslan Ermilov wrote: > One nice difference (and I don't believe PF or IPFilter can do > this) is this optional 32-bit tag value with no special meaning. > For example, we have several thousands of client IPs, and each > client is allowed (through a Web form) to limit bandwidth to > some discrete values (0, 64, 128, 256, 512, and "unlimited") in > Kbps to/from Ukrainian and foreign networks. We have this all > implemented using less than ten IPFW tables: I suppose I could shoe-horn that into 1 rule if I was using ipf and it had pipes. But ipf doesn't have pipe rules although it does have groups and you can use a pool for mapping ip#'s into groups. I see the logical extension of that meaning you should be able to put the bw param into each node of the table, no ? And extend the syntax of the tables to define an arbitrary arg...it's really a question of how well a particular parameter for a given rule matches being distinguishable for any given ip#/mask. > and so forth. And we have a small set of rules of the form: > > deny ip from table(1,0) to table(0) // bw=0 > pipe 1 ip from table(1,128) to table(0) // bw=128Kbps And what if I do: deny 1 ip from table(1,128) to table(0) or is that not allowed ? Darren From owner-cvs-src@FreeBSD.ORG Fri Jun 11 02:35:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 291EF16A4CE; Fri, 11 Jun 2004 02:35:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09EFD43D55; Fri, 11 Jun 2004 02:35:35 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B2ZJOp076921; Fri, 11 Jun 2004 02:35:19 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B2ZJa3076920; Fri, 11 Jun 2004 02:35:19 GMT (envelope-from das) Message-Id: <200406110235.i5B2ZJa3076920@repoman.freebsd.org> From: David Schultz Date: Fri, 11 Jun 2004 02:35:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/amd64 fenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:35:35 -0000 das 2004-06-11 02:35:19 UTC FreeBSD src repository Modified files: lib/msun/amd64 fenv.c Log: Insert a missing '~' in feholdexcept(), so that it correctly clears the exception flags in the mxcsr as well as the x87 FPU. Revision Changes Path 1.2 +1 -1 src/lib/msun/amd64/fenv.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 02:35:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4E2B16A4CE; Fri, 11 Jun 2004 02:35:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B551F43D31; Fri, 11 Jun 2004 02:35:46 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B2ZUGM076974; Fri, 11 Jun 2004 02:35:30 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B2ZUZ6076973; Fri, 11 Jun 2004 02:35:30 GMT (envelope-from das) Message-Id: <200406110235.i5B2ZUZ6076973@repoman.freebsd.org> From: David Schultz Date: Fri, 11 Jun 2004 02:35:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/ia64 fenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:35:47 -0000 das 2004-06-11 02:35:30 UTC FreeBSD src repository Modified files: lib/msun/ia64 fenv.c Log: Shift the FPSR contents by the correct amount so feupdateenv() raises the correct exceptions from the old environment. Revision Changes Path 1.2 +1 -1 src/lib/msun/ia64/fenv.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 02:48:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D8EB16A4CE; Fri, 11 Jun 2004 02:48:17 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6611A43D1D; Fri, 11 Jun 2004 02:48:17 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 5A8A05C824; Thu, 10 Jun 2004 19:48:17 -0700 (PDT) Date: Thu, 10 Jun 2004 19:48:17 -0700 From: Alfred Perlstein To: Robert Watson Message-ID: <20040611024817.GK78955@elvis.mu.org> References: <20040611012513.GI78955@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:48:17 -0000 * Robert Watson [040610 19:18] wrote: > > Agreed. If the caller doesn't mind us dropping the unp_mtx, the first > logical thing to try is to replace unp_gcing with an sx lock (or the > like), and only acquire unp_mtx when calling into code that needs it. That's not really needed. The idea is just to avoid initiating another gc scan while one is in progress. I'll look at it if I find the time/motivation. -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Fri Jun 11 02:55:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EBA216A4CE; Fri, 11 Jun 2004 02:55:03 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 041F543D1F; Fri, 11 Jun 2004 02:55:01 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i5B2rsN6049246; Thu, 10 Jun 2004 22:53:54 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i5B2rrQc049243; Thu, 10 Jun 2004 22:53:53 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 10 Jun 2004 22:53:53 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <20040611024817.GK78955@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:55:03 -0000 On Thu, 10 Jun 2004, Alfred Perlstein wrote: > * Robert Watson [040610 19:18] wrote: > > > > Agreed. If the caller doesn't mind us dropping the unp_mtx, the first > > logical thing to try is to replace unp_gcing with an sx lock (or the > > like), and only acquire unp_mtx when calling into code that needs it. > > That's not really needed. The idea is just to avoid initiating another > gc scan while one is in progress. It would almost be tempting to do that cleanup in a separate worker (perhaps a callout), and just launch the cleanup using a cv when necessary. That would get all the work out of a context that probably includes socket activity, etc. > I'll look at it if I find the time/motivation. Sounds good to me :-). I'll move ahead with merging other stack locking bits in the mean time. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:23:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44E2C16A4CE; Fri, 11 Jun 2004 03:23:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 264FB43D48; Fri, 11 Jun 2004 03:23:18 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B3MYmB088315; Fri, 11 Jun 2004 03:22:34 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B3MY8D088314; Fri, 11 Jun 2004 03:22:34 GMT (envelope-from das) Message-Id: <200406110322.i5B3MY8D088314@repoman.freebsd.org> From: David Schultz Date: Fri, 11 Jun 2004 03:22:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/regression/lib/msun Makefile test-fenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:23:18 -0000 das 2004-06-11 03:22:34 UTC FreeBSD src repository Added files: tools/regression/lib/msun Makefile test-fenv.c Log: Add some fenv.h regression tests. Revision Changes Path 1.1 +16 -0 src/tools/regression/lib/msun/Makefile (new) 1.1 +519 -0 src/tools/regression/lib/msun/test-fenv.c (new) From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:27:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 06A4316A4CE; Fri, 11 Jun 2004 03:27:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3F4D43D31; Fri, 11 Jun 2004 03:27:29 +0000 (GMT) (envelope-from anholt@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B3R0mp088531; Fri, 11 Jun 2004 03:27:00 GMT (envelope-from anholt@repoman.freebsd.org) Received: (from anholt@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B3R0nc088530; Fri, 11 Jun 2004 03:27:00 GMT (envelope-from anholt) Message-Id: <200406110327.i5B3R0nc088530@repoman.freebsd.org> From: Eric Anholt Date: Fri, 11 Jun 2004 03:27:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/drm drm.h drmP.h drm_drv.h drm_linux_list.h drm_os_freebsd.h drm_pciids.h drm_sarea.h mga.h mga_drm.h r128.h r128_drm.h r128_state.c radeon.h radeon_drm.h... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:27:30 -0000 anholt 2004-06-11 03:27:00 UTC FreeBSD src repository Modified files: sys/dev/drm drm.h drmP.h drm_drv.h drm_os_freebsd.h drm_sarea.h mga.h mga_drm.h r128.h r128_drm.h r128_state.c radeon.h radeon_drm.h radeon_drv.h radeon_mem.c radeon_state.c sis.h sis_drv.c sis_mm.c tdfx.h Added files: sys/dev/drm drm_linux_list.h drm_pciids.h Log: Merge from DRI CVS as of 2004-05-26. Most of the meat is new PCI IDs and a new packet for Radeon. Revision Changes Path 1.7 +12 -0 src/sys/dev/drm/drm.h 1.10 +0 -5 src/sys/dev/drm/drmP.h 1.24 +16 -7 src/sys/dev/drm/drm_drv.h 1.1 +71 -0 src/sys/dev/drm/drm_linux_list.h (new) 1.19 +7 -0 src/sys/dev/drm/drm_os_freebsd.h 1.1 +204 -0 src/sys/dev/drm/drm_pciids.h (new) 1.3 +15 -1 src/sys/dev/drm/drm_sarea.h 1.5 +1 -7 src/sys/dev/drm/mga.h 1.4 +24 -11 src/sys/dev/drm/mga_drm.h 1.6 +1 -41 src/sys/dev/drm/r128.h 1.5 +42 -19 src/sys/dev/drm/r128_drm.h 1.10 +8 -13 src/sys/dev/drm/r128_state.c 1.9 +4 -63 src/sys/dev/drm/radeon.h 1.8 +62 -28 src/sys/dev/drm/radeon_drm.h 1.10 +1 -0 src/sys/dev/drm/radeon_drv.h 1.5 +2 -2 src/sys/dev/drm/radeon_mem.c 1.11 +134 -32 src/sys/dev/drm/radeon_state.c 1.3 +0 -11 src/sys/dev/drm/sis.h 1.3 +1 -1 src/sys/dev/drm/sis_drv.c 1.4 +4 -0 src/sys/dev/drm/sis_mm.c 1.4 +0 -8 src/sys/dev/drm/tdfx.h From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:34:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BACF516A4CE; Fri, 11 Jun 2004 03:34:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D88243D55; Fri, 11 Jun 2004 03:34:16 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B3Y2Vc090582; Fri, 11 Jun 2004 03:34:02 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B3Y2xH090581; Fri, 11 Jun 2004 03:34:02 GMT (envelope-from kensmith) Message-Id: <200406110334.i5B3Y2xH090581@repoman.freebsd.org> From: Ken Smith Date: Fri, 11 Jun 2004 03:34:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/stdtime localtime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:34:16 -0000 kensmith 2004-06-11 03:34:02 UTC FreeBSD src repository Modified files: lib/libc/stdtime localtime.c Log: Change defualt time zone from GMT to UTC. This will not be MFC-ed, and was done before 5-STABLE on purpose... Revision Changes Path 1.38 +6 -1 src/lib/libc/stdtime/localtime.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:40:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 627A916A4D0; Fri, 11 Jun 2004 03:40:49 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id D0F9043D1D; Fri, 11 Jun 2004 03:40:48 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) i5B3em2n009934; Thu, 10 Jun 2004 23:40:48 -0400 (EDT) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id i5B3emZZ009933; Thu, 10 Jun 2004 23:40:48 -0400 (EDT) Date: Thu, 10 Jun 2004 23:40:48 -0400 From: Ken Smith To: Ken Smith Message-ID: <20040611034048.GE8579@electra.cse.Buffalo.EDU> References: <200406110334.i5B3Y2xH090581@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406110334.i5B3Y2xH090581@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:40:49 -0000 On Fri, Jun 11, 2004 at 03:34:02AM +0000, Ken Smith wrote: > kensmith 2004-06-11 03:34:02 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdtime localtime.c > Log: > Change defualt time zone from GMT to UTC. This will not be MFC-ed, and > was done before 5-STABLE on purpose... > > Revision Changes Path > 1.38 +6 -1 src/lib/libc/stdtime/localtime.c In my warning message sent to current@ saying this was in the works I had asked for thoughts on whether or not to "clean up" the code, more or less doing "s/gmt/utc/g". Those who sent in thoughts were divided roughly half in favor, half against. I couldn't decide if the cleanliness was worth the size of the diff so I did my usual thing when confused about cleanliness and/or style issues - I asked bde@. :-) Bruce pointed out several things but the kicker was that this code originally came from an import from a vendor branch. We import the time zone data from that source fairly frequently. We import the time zone code far less frequently. But a gratuitous sweep through changing lots of variable/function names would make future code imports unnecessarily harder. So I'll leave it as-is. Thanks again Bruce. :-) -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:42:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9B4216A4CE; Fri, 11 Jun 2004 03:42:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD3B543D49; Fri, 11 Jun 2004 03:42:37 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B3gbVa092594; Fri, 11 Jun 2004 03:42:37 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B3gbWp092593; Fri, 11 Jun 2004 03:42:37 GMT (envelope-from rwatson) Message-Id: <200406110342.i5B3gbWp092593@repoman.freebsd.org> From: Robert Watson Date: Fri, 11 Jun 2004 03:42:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet igmp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:42:37 -0000 rwatson 2004-06-11 03:42:37 UTC FreeBSD src repository Modified files: sys/netinet igmp.c Log: Lock down parallel router_info list for tracking multicast IGMP versions of various routers seen: - Introduce igmp_mtx. - Protect global variable 'router_info_head' and list fields in struct router_info with this mutex, as well as igmp_timers_are_running. - find_rti() asserts that the caller acquires igmp_mtx. - Annotate a failure to check the return value of MALLOC(..., M_NOWAIT). Revision Changes Path 1.46 +27 -1 src/sys/netinet/igmp.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:45:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC5FE16A4CE; Fri, 11 Jun 2004 03:45:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F47A43D49; Fri, 11 Jun 2004 03:45:43 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B3jhdv092794; Fri, 11 Jun 2004 03:45:43 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B3jgj9092793; Fri, 11 Jun 2004 03:45:43 GMT (envelope-from rwatson) Message-Id: <200406110345.i5B3jgj9092793@repoman.freebsd.org> From: Robert Watson Date: Fri, 11 Jun 2004 03:45:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:45:43 -0000 rwatson 2004-06-11 03:45:42 UTC FreeBSD src repository Modified files: sys/net bpf.c Log: Un-staticize 'dst' sockaddr in the stack of bpfwrite() to prevent the need to synchronize access to the structure. I believe this should fit into the stack under the necessary circumstances, but if not we can either add synchronization or use a thread-local malloc for the duration. Revision Changes Path 1.126 +2 -1 src/sys/net/bpf.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:47:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8A8A16A4CE; Fri, 11 Jun 2004 03:47:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BD9A43D1D; Fri, 11 Jun 2004 03:47:35 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B3lL3V092846; Fri, 11 Jun 2004 03:47:21 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B3lLCl092845; Fri, 11 Jun 2004 03:47:21 GMT (envelope-from rwatson) Message-Id: <200406110347.i5B3lLCl092845@repoman.freebsd.org> From: Robert Watson Date: Fri, 11 Jun 2004 03:47:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:47:35 -0000 rwatson 2004-06-11 03:47:21 UTC FreeBSD src repository Modified files: sys/net bpf.c Log: Switch to conditionally acquiring and dropping Giant around calls into ifp->if_output() basedd on debug.mpsafenet. That way once bpfwrite() can be called without Giant, it will acquire Giant (if desired) before entering the network stack. Revision Changes Path 1.127 +2 -2 src/sys/net/bpf.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:53:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE0C716A4CE; Fri, 11 Jun 2004 03:53:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C09E943D45; Fri, 11 Jun 2004 03:53:23 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B3qvX3094778; Fri, 11 Jun 2004 03:52:57 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B3qudD094777; Fri, 11 Jun 2004 03:52:57 GMT (envelope-from rwatson) Message-Id: <200406110352.i5B3qudD094777@repoman.freebsd.org> From: Robert Watson Date: Fri, 11 Jun 2004 03:52:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net raw_cb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:53:24 -0000 rwatson 2004-06-11 03:52:56 UTC FreeBSD src repository Modified files: sys/net raw_cb.c Log: Constify raw_sendspace and raw_recvspace, as they're not mutable. Revision Changes Path 1.27 +2 -2 src/sys/net/raw_cb.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 03:53:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC15116A4CE; Fri, 11 Jun 2004 03:53:51 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BB1D43D5A; Fri, 11 Jun 2004 03:53:51 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) i5B3rV2n010187; Thu, 10 Jun 2004 23:53:31 -0400 (EDT) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id i5B3rV1o010186; Thu, 10 Jun 2004 23:53:31 -0400 (EDT) Date: Thu, 10 Jun 2004 23:53:31 -0400 From: Ken Smith To: Scott Long Message-ID: <20040611035331.GF8579@electra.cse.Buffalo.EDU> References: <200406100511.i5A5Beog063878@repoman.freebsd.org> <20040610184746.GF78955@elvis.mu.org> <40C8AD8A.2040309@freebsd.org> <20040610185730.GG78955@elvis.mu.org> <40C8B01B.3010203@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40C8B01B.3010203@freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: Alfred Perlstein cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c lsi64854.c lsi64854reg.h lsi64854var.h ncr53c9x.c ncr53c9xreg.h ncr53c9xvar.h src/sys/modules/esp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:53:52 -0000 On Thu, Jun 10, 2004 at 01:01:47PM -0600, Scott Long wrote: > Yes, Jake shoeshorned syscons onto sparc last year. I'm having troubles > getting it to work, though, as it locks the system up solid a few > seconds after going to multiuser. The only platform I've been able to get Creator-3D to work on so far has been an Ultra-60. I haven't tried the Ultra-2's at all yet because I have had enough machines around here that were able to talk directly to their disks and didn't have the interest in netbooting something this old. But Scott just changed that so ... :-) The other platforms I'm aware of that have Creator-3D are Ultra-10 and Ultra-30. My Ultra-10 locks up solid immediately after booting up the kernel and starting to probe for devices (I'd be willing to assume it's the point it first tries to touch the Creator that it stops). Kris has an Ultra-30 and its display seems OK but we're (still - sorry Kris) trying to figure out some keyboard problems on that machine. -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | From owner-cvs-src@FreeBSD.ORG Fri Jun 11 04:06:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C4C0316A4CE; Fri, 11 Jun 2004 04:06:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A743B43D55; Fri, 11 Jun 2004 04:06:51 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B46piU097966; Fri, 11 Jun 2004 04:06:51 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B46pRl097965; Fri, 11 Jun 2004 04:06:51 GMT (envelope-from rwatson) Message-Id: <200406110406.i5B46pRl097965@repoman.freebsd.org> From: Robert Watson Date: Fri, 11 Jun 2004 04:06:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 04:06:51 -0000 rwatson 2004-06-11 04:06:51 UTC FreeBSD src repository Modified files: sys/netinet ip_divert.c Log: Remove unneeded Giant acquisition in divert_packet(), which is left over from debug.mpsafenet affecting only the forwarding plane. Giant is now acquired in the ithread/netisr or in the system call code. Revision Changes Path 1.89 +0 -15 src/sys/netinet/ip_divert.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 04:24:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFA8316A4CE; Fri, 11 Jun 2004 04:24:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A326C43D1F; Fri, 11 Jun 2004 04:24:51 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B4OaPK002043; Fri, 11 Jun 2004 04:24:36 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B4OZiU002042; Fri, 11 Jun 2004 04:24:35 GMT (envelope-from alc) Message-Id: <200406110424.i5B4OZiU002042@repoman.freebsd.org> From: Alan Cox Date: Fri, 11 Jun 2004 04:24:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/ia64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 04:24:51 -0000 alc 2004-06-11 04:24:35 UTC FreeBSD src repository Modified files: sys/ia64/ia64 pmap.c Log: Reduce the number of preallocated pv entries and lpte entries in pmap_init(). Tested by: marcel@ Revision Changes Path 1.133 +2 -9 src/sys/ia64/ia64/pmap.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 05:11:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 009CD16A4CE; Fri, 11 Jun 2004 05:11:10 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31B4B43D46; Fri, 11 Jun 2004 05:11:09 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.11/8.12.11) with ESMTP id i5B5B5Qv020998; Fri, 11 Jun 2004 09:11:05 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.11/8.12.11/Submit) id i5B5B4d4020997; Fri, 11 Jun 2004 09:11:04 +0400 (MSD) (envelope-from ache) Date: Fri, 11 Jun 2004 09:11:04 +0400 From: Andrey Chernov To: Robert Watson Message-ID: <20040611051104.GA20869@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Robert Watson , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20040611015453.GA17618@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.25.0.62; VDF 6.25.0.90 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 05:11:10 -0000 On Thu, Jun 10, 2004 at 10:18:06PM -0400, Robert Watson wrote: > However, I'm not sure I've seen your sosend() report -- is there a PR I > can look at? Have you tried running with the socket buffer debugging > option turned on? No PR, just two quick notes to -current list, I'll resend them to you. About debugging, I can't try to experiment much in this particular case, it is very remote server running recent current for some reason. -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Fri Jun 11 06:07:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 06BE516A4CE; Fri, 11 Jun 2004 06:07:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE99043D2F; Fri, 11 Jun 2004 06:07:39 +0000 (GMT) (envelope-from roam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B67FxJ030969; Fri, 11 Jun 2004 06:07:15 GMT (envelope-from roam@repoman.freebsd.org) Received: (from roam@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B67FPv030968; Fri, 11 Jun 2004 06:07:15 GMT (envelope-from roam) Message-Id: <200406110607.i5B67FPv030968@repoman.freebsd.org> From: Peter Pentchev Date: Fri, 11 Jun 2004 06:07:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/share/man/man4 screen.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 06:07:40 -0000 roam 2004-06-11 06:07:14 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_4) share/man/man4 screen.4 Log: MFC rev. 1.27 - fix a grammatical mistake: the PC3 character sequences *are* also supported. Revision Changes Path 1.14.2.10 +2 -2 src/share/man/man4/screen.4 From owner-cvs-src@FreeBSD.ORG Fri Jun 11 07:06:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EE9216A4CE; Fri, 11 Jun 2004 07:06:28 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 16A3943D53; Fri, 11 Jun 2004 07:06:27 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i5B7Bx3m095953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Jun 2004 10:12:01 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i5B761YJ055673; Fri, 11 Jun 2004 10:06:01 +0300 (EEST) (envelope-from ru) Date: Fri, 11 Jun 2004 10:06:01 +0300 From: Ruslan Ermilov To: Darren Reed Message-ID: <20040611070601.GA55472@ip.net.ua> References: <200406092010.i59KAcXH025699@repoman.freebsd.org> <200406100445.44763.max@love2party.net> <20040610214059.GA3228@ip.net.ua> <20040611022247.GA40799@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: <20040611022247.GA40799@hub.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: Max Laier cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 07:06:28 -0000 --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 11, 2004 at 02:22:47AM +0000, Darren Reed wrote: > On Fri, Jun 11, 2004 at 12:40:59AM +0300, Ruslan Ermilov wrote: [...] > > and so forth. And we have a small set of rules of the form: > >=20 > > deny ip from table(1,0) to table(0) // bw=3D0 > > pipe 1 ip from table(1,128) to table(0) // bw=3D128Kbps >=20 > And what if I do: > deny 1 ip from table(1,128) to table(0) ^ wrong syntax > or is that not allowed ? >=20 "table(t[,v])" just causes the match if there's an entry for a given src/dst IP in table "t". If optional "v" was also specified, the match will be considered only if the entry has this value too (otherwise, the value is ignored). So yes, the command above is allowed, whatever real meaning you put into it. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAyVnZqRfpzJluFF4RAju4AKCDZJT6n73UgHRofZO6meh6Tmh3zACdHFAZ U8DEYZZOIOY/Qhr+ye2Zk44= =S+zU -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn-- From owner-cvs-src@FreeBSD.ORG Fri Jun 11 07:39:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E941416A4CE; Fri, 11 Jun 2004 07:39:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE8E543D2D; Fri, 11 Jun 2004 07:39:16 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B7dGEt050127; Fri, 11 Jun 2004 07:39:16 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B7dFqt050126; Fri, 11 Jun 2004 07:39:15 GMT (envelope-from sos) Message-Id: <200406110739.i5B7dFqt050126@repoman.freebsd.org> From: Søren Schmidt Date: Fri, 11 Jun 2004 07:39:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-lowlevel.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 07:39:17 -0000 sos 2004-06-11 07:39:15 UTC FreeBSD src repository Modified files: sys/dev/ata ata-lowlevel.c Log: Back out the last change as that broke some SATA devices. Now we are cleaing up remove a few lines of unused code. Revision Changes Path 1.38 +4 -9 src/sys/dev/ata/ata-lowlevel.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 09:07:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47FA116A4CE; Fri, 11 Jun 2004 09:07:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D01643D46; Fri, 11 Jun 2004 09:07:15 +0000 (GMT) (envelope-from eik@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B96Sko069322; Fri, 11 Jun 2004 09:06:28 GMT (envelope-from eik@repoman.freebsd.org) Received: (from eik@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B96SKk069321; Fri, 11 Jun 2004 09:06:28 GMT (envelope-from eik) Message-Id: <200406110906.i5B96SKk069321@repoman.freebsd.org> From: Oliver Eikemeier Date: Fri, 11 Jun 2004 09:06:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/libexec/rtld-elf rtld.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 09:07:15 -0000 eik 2004-06-11 09:06:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) libexec/rtld-elf rtld.c Log: MFC of revision 1.96: give out a little more information in case of a missing dependency Revision Changes Path 1.43.2.18 +6 -1 src/libexec/rtld-elf/rtld.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 09:40:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 108F216A4CE; Fri, 11 Jun 2004 09:40:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9A5D43D5D; Fri, 11 Jun 2004 09:40:21 +0000 (GMT) (envelope-from eik@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B9eIjR075337; Fri, 11 Jun 2004 09:40:18 GMT (envelope-from eik@repoman.freebsd.org) Received: (from eik@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B9eIJK075336; Fri, 11 Jun 2004 09:40:18 GMT (envelope-from eik) Message-Id: <200406110940.i5B9eIJK075336@repoman.freebsd.org> From: Oliver Eikemeier Date: Fri, 11 Jun 2004 09:40:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.bin/find extern.h find.1 find.c find.h function.c option.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 09:40:22 -0000 eik 2004-06-11 09:40:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) usr.bin/find extern.h find.1 find.c find.h function.c option.c Log: MFC of the `-depth n' primary and the -maxdepth fix. Revision Changes Path 1.9.2.5 +2 -1 src/usr.bin/find/extern.h 1.23.2.24 +36 -12 src/usr.bin/find/find.1 1.7.6.4 +6 -7 src/usr.bin/find/find.c 1.6.2.8 +3 -0 src/usr.bin/find/find.h 1.22.2.12 +49 -7 src/usr.bin/find/function.c 1.9.2.7 +1 -1 src/usr.bin/find/option.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 09:45:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73BFB16A4D1; Fri, 11 Jun 2004 09:45:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57DE443D4C; Fri, 11 Jun 2004 09:45:45 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5B9jIA2077271; Fri, 11 Jun 2004 09:45:18 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5B9jI0I077270; Fri, 11 Jun 2004 09:45:18 GMT (envelope-from phk) Message-Id: <200406110945.i5B9jI0I077270@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 11 Jun 2004 09:45:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/boot/i386/boot0 boot0.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 09:45:45 -0000 phk 2004-06-11 09:45:18 UTC FreeBSD src repository Modified files: sys/boot/i386/boot0 boot0.S Log: Merge boot0 and boot0sio so they behave the same. Revision Changes Path 1.9 +17 -42 src/sys/boot/i386/boot0/boot0.S From owner-cvs-src@FreeBSD.ORG Fri Jun 11 11:16:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7108816A4D0; Fri, 11 Jun 2004 11:16:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 546C843D41; Fri, 11 Jun 2004 11:16:53 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BBGRKT098173; Fri, 11 Jun 2004 11:16:27 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BBGRVA098172; Fri, 11 Jun 2004 11:16:27 GMT (envelope-from phk) Message-Id: <200406111116.i5BBGRVA098172@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 11 Jun 2004 11:16:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha machdep.c src/sys/amd64/amd64 machdep.c src/sys/compat/linux linux_misc.c linux_uid16.c src/sys/conf NOTES options src/sys/dev/cy cy.c src/sys/dev/digi digi.c src/sys/dev/rp rp.c src/sys/dev/si si.c src/sys/dev/sio ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 11:16:53 -0000 phk 2004-06-11 11:16:27 UTC FreeBSD src repository Modified files: sys/alpha/alpha machdep.c sys/amd64/amd64 machdep.c sys/compat/linux linux_misc.c linux_uid16.c sys/conf NOTES options sys/dev/cy cy.c sys/dev/digi digi.c sys/dev/rp rp.c sys/dev/si si.c sys/dev/sio sio.c sys/dev/sx sx.c sys/dev/usb ucom.c sys/i386/i386 machdep.c sys/ia64/ia64 machdep.c sys/kern kern_descrip.c kern_prot.c kern_resource.c kern_sig.c kern_xxx.c tty.c tty_compat.c tty_pty.c uipc_syscalls.c vfs_syscalls.c sys/pc98/i386 machdep.c sys/pc98/pc98 sio.c sys/sys ioctl.h signal.h sys/vm vm_mmap.c Log: Deorbit COMPAT_SUNOS. We inherited this from the sparc32 port of BSD4.4-Lite1. We have neither a sparc32 port nor a SunOS4.x compatibility desire these days. Revision Changes Path 1.220 +6 -6 src/sys/alpha/alpha/machdep.c 1.610 +2 -2 src/sys/amd64/amd64/machdep.c 1.154 +1 -1 src/sys/compat/linux/linux_misc.c 1.13 +1 -1 src/sys/compat/linux/linux_uid16.c 1.1230 +0 -6 src/sys/conf/NOTES 1.452 +0 -1 src/sys/conf/options 1.151 +2 -2 src/sys/dev/cy/cy.c 1.46 +2 -2 src/sys/dev/digi/digi.c 1.59 +2 -2 src/sys/dev/rp/rp.c 1.126 +1 -1 src/sys/dev/si/si.c 1.437 +2 -2 src/sys/dev/sio/sio.c 1.7 +1 -1 src/sys/dev/sx/sx.c 1.47 +2 -2 src/sys/dev/usb/ucom.c 1.590 +6 -6 src/sys/i386/i386/machdep.c 1.178 +2 -2 src/sys/ia64/ia64/machdep.c 1.232 +2 -2 src/sys/kern/kern_descrip.c 1.182 +3 -3 src/sys/kern/kern_prot.c 1.138 +2 -2 src/sys/kern/kern_resource.c 1.281 +7 -19 src/sys/kern/kern_sig.c 1.41 +2 -2 src/sys/kern/kern_xxx.c 1.218 +3 -3 src/sys/kern/tty.c 1.35 +2 -2 src/sys/kern/tty_compat.c 1.123 +2 -2 src/sys/kern/tty_pty.c 1.189 +1 -1 src/sys/kern/uipc_syscalls.c 1.349 +5 -5 src/sys/kern/vfs_syscalls.c 1.336 +6 -6 src/sys/pc98/i386/machdep.c 1.215 +2 -2 src/sys/pc98/pc98/sio.c 1.13 +2 -2 src/sys/sys/ioctl.h 1.44 +0 -3 src/sys/sys/signal.h 1.190 +2 -2 src/sys/vm/vm_mmap.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 11:41:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B62A16A4CE; Fri, 11 Jun 2004 11:41:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2EB543D41; Fri, 11 Jun 2004 11:41:42 +0000 (GMT) (envelope-from joerg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BBfYB5003393; Fri, 11 Jun 2004 11:41:34 GMT (envelope-from joerg@repoman.freebsd.org) Received: (from joerg@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BBfYxL003387; Fri, 11 Jun 2004 11:41:34 GMT (envelope-from joerg) Message-Id: <200406111141.i5BBfYxL003387@repoman.freebsd.org> From: Joerg Wunsch Date: Fri, 11 Jun 2004 11:41:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/sunlabel sunlabel.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 11:41:43 -0000 joerg 2004-06-11 11:41:34 UTC FreeBSD src repository Modified files: sbin/sunlabel sunlabel.c Log: Cast the arguments to make_h_number() to uintmax_t before multiplying them... Otherwise the result will be truncated anyway. Revision Changes Path 1.10 +2 -2 src/sbin/sunlabel/sunlabel.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 11:44:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D5D116A4CE; Fri, 11 Jun 2004 11:44:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5C0B43D48; Fri, 11 Jun 2004 11:44:08 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BBhk8i004301; Fri, 11 Jun 2004 11:43:46 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BBhkwX004300; Fri, 11 Jun 2004 11:43:46 GMT (envelope-from phk) Message-Id: <200406111143.i5BBhkwX004300@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 11 Jun 2004 11:43:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys signal.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 11:44:09 -0000 phk 2004-06-11 11:43:46 UTC FreeBSD src repository Modified files: sys/sys signal.h Log: Make this look less dubious :-) Spotted by: ru Revision Changes Path 1.45 +0 -3 src/sys/sys/signal.h From owner-cvs-src@FreeBSD.ORG Thu Jun 10 23:50:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC3EC16A4D0; Thu, 10 Jun 2004 23:50:23 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.183]) by mx1.FreeBSD.org (Postfix) with ESMTP id 418AA43D2D; Thu, 10 Jun 2004 23:50:23 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.209] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BYZJO-00074P-00; Fri, 11 Jun 2004 01:50:22 +0200 Received: from [84.128.139.222] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1BYZJN-0006Fa-00; Fri, 11 Jun 2004 01:50:22 +0200 From: Max Laier To: Ruslan Ermilov Date: Fri, 11 Jun 2004 01:51:10 +0200 User-Agent: KMail/1.6.2 References: <200406092010.i59KAcXH025699@repoman.freebsd.org> <200406100445.44763.max@love2party.net> <20040610214059.GA3228@ip.net.ua> In-Reply-To: <20040610214059.GA3228@ip.net.ua> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_1PPyANDVJzK3/2W"; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406110151.17372.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:e28873fbe4dbe612ce62ab869898ff08 X-Mailman-Approved-At: Fri, 11 Jun 2004 11:44:23 +0000 cc: ipfw@freebsd.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2004 23:50:24 -0000 --Boundary-02=_1PPyANDVJzK3/2W Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 10 June 2004 23:40, Ruslan Ermilov wrote: > On Thu, Jun 10, 2004 at 04:45:37AM +0200, Max Laier wrote: > > On Wednesday 09 June 2004 22:10, Ruslan Ermilov wrote: > > > ru 2004-06-09 20:10:38 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sbin/ipfw ipfw.8 ipfw2.c > > > sys/netinet in.h ip_fw.h ip_fw2.c raw_ip.c > > > Log: > > > Introduce a new feature to IPFW2: lookup tables. These are > > > useful for handling large sparse address sets. Initial > > > implementation by Vsevolod Lobko , refined by me. > > > > Idea from: pf ;) > > Nice! > > I've asked Vsevolod, and yes, the original idea attributes to PF. I have seen the original thread in ipfw@ and posted some comments, hence=20 the mail in the first place. > Do PF tables allow addr/mask entries as IPFW tables do (I could > not intuit it from reading the pfctl(8) manpage)? You might rather want to look at pf.conf(5). Yes, pf tables allow=20 addr/mask and IPv6 addresses. pf allows an additional "not" qualifier to=20 allow to do something like: { 10/8, !10.10/16, 10.10.10/24 } > One nice difference (and I don't believe PF or IPFilter can do > this) is this optional 32-bit tag value with no special meaning. > For example, we have several thousands of client IPs, and each > client is allowed (through a Web form) to limit bandwidth to > some discrete values (0, 64, 128, 256, 512, and "unlimited") in > Kbps to/from Ukrainian and foreign networks. We have this all > implemented using less than ten IPFW tables: hmmm ... I don't really see the benefit in packing the information into=20 one table. You could as well have different tables for that (with pf only=20 memory limits the number of tables allowed). But it's cool that we=20 inspire eachother and still diverge a bit to find the best solutions for=20 our respective users. Btw, I find it very helpful that pf refers to a table by a name and not a=20 number. Why did you choose to use numbers? [ We might want to transfer this thread to ipfw@ ] =2D-=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet --Boundary-02=_1PPyANDVJzK3/2W Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAyPP1XyyEoT62BG0RAt7dAJ9DCEFUexCjc9DrkBOFfjB8VRUwoQCaA7mr DtOgTNLYLkwgZsHPWLCmAjI= =lHWm -----END PGP SIGNATURE----- --Boundary-02=_1PPyANDVJzK3/2W-- From owner-cvs-src@FreeBSD.ORG Fri Jun 11 11:58:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1234316A4D0; Fri, 11 Jun 2004 11:58:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E964743D1D; Fri, 11 Jun 2004 11:58:20 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BBw7Hk006493; Fri, 11 Jun 2004 11:58:07 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BBw7hI006492; Fri, 11 Jun 2004 11:58:07 GMT (envelope-from phk) Message-Id: <200406111158.i5BBw7hI006492@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 11 Jun 2004 11:58:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/truss syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 11:58:21 -0000 phk 2004-06-11 11:58:07 UTC FreeBSD src repository Modified files: usr.bin/truss syscalls.c Log: COMPAT_SUNOS is gone. Revision Changes Path 1.39 +3 -5 src/usr.bin/truss/syscalls.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 14:07:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72A8916A4D1; Fri, 11 Jun 2004 14:07:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 566C143D2F; Fri, 11 Jun 2004 14:07:50 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BE7efN042000; Fri, 11 Jun 2004 14:07:40 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BE7ebb041999; Fri, 11 Jun 2004 14:07:40 GMT (envelope-from brueffer) Message-Id: <200406111407.i5BE7ebb041999@repoman.freebsd.org> From: Christian Brueffer Date: Fri, 11 Jun 2004 14:07:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/share/man/man4 bge.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 14:07:50 -0000 brueffer 2004-06-11 14:07:40 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_4) share/man/man4 bge.4 Log: MFC: rev. 1.11 Fix typo Revision Changes Path 1.1.2.6 +1 -1 src/share/man/man4/bge.4 From owner-cvs-src@FreeBSD.ORG Fri Jun 11 14:48:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F041D16A4CE; Fri, 11 Jun 2004 14:48:26 +0000 (GMT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DBA943D2F; Fri, 11 Jun 2004 14:48:26 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.12.8/8.12.8) with ESMTP id i5BEmAVu032389; Fri, 11 Jun 2004 10:48:10 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20040611034048.GE8579@electra.cse.Buffalo.EDU> References: <200406110334.i5B3Y2xH090581@repoman.freebsd.org> <20040611034048.GE8579@electra.cse.Buffalo.EDU> Date: Fri, 11 Jun 2004 10:48:09 -0400 To: Ken Smith From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 14:48:27 -0000 At 11:40 PM -0400 6/10/04, Ken Smith wrote: > >Bruce pointed out several things but the kicker was that this code >originally came from an import from a vendor branch. We import the >time zone data from that source fairly frequently. We import the >time zone code far less frequently. But a gratuitous sweep through >changing lots of variable/function names would make future code >imports unnecessarily harder. So I'll leave it as-is. > >Thanks again Bruce. :-) Might it be a good idea to make a forced-commit just to include that observation as a comment in the CVS history? -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Fri Jun 11 15:33:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 58B8716A4CE; Fri, 11 Jun 2004 15:33:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33E0843D41; Fri, 11 Jun 2004 15:33:35 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BFXLhb061260; Fri, 11 Jun 2004 15:33:21 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BFXK0X061259; Fri, 11 Jun 2004 15:33:20 GMT (envelope-from scottl) Message-Id: <200406111533.i5BFXK0X061259@repoman.freebsd.org> From: Scott Long Date: Fri, 11 Jun 2004 15:33:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/esp esp_sbus.c ncr53c9x.c ncr53c9xvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 15:33:35 -0000 scottl 2004-06-11 15:33:20 UTC FreeBSD src repository Modified files: sys/dev/esp esp_sbus.c ncr53c9x.c ncr53c9xvar.h Log: Make the XPT_CALC_GEOMETRY op dependent on the sc_extended_geometry flag that is set in the bus front-end. Revision Changes Path 1.2 +2 -0 src/sys/dev/esp/esp_sbus.c 1.2 +1 -1 src/sys/dev/esp/ncr53c9x.c 1.2 +1 -0 src/sys/dev/esp/ncr53c9xvar.h From owner-cvs-src@FreeBSD.ORG Fri Jun 11 15:38:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CD3716A4CE; Fri, 11 Jun 2004 15:38:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DADD43D1F; Fri, 11 Jun 2004 15:38:26 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BFbo1F061439; Fri, 11 Jun 2004 15:37:50 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BFbokd061438; Fri, 11 Jun 2004 15:37:50 GMT (envelope-from cognet) Message-Id: <200406111537.i5BFbokd061438@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 11 Jun 2004 15:37:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/etc.arm ttys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 15:38:26 -0000 cognet 2004-06-11 15:37:50 UTC FreeBSD src repository Added files: etc/etc.arm ttys Log: Import the ttys file for arm. make TARGET_ARCH=arm world now works (but still with external patches for the toolchain bits). Revision Changes Path 1.1 +309 -0 src/etc/etc.arm/ttys (new) From owner-cvs-src@FreeBSD.ORG Fri Jun 11 16:07:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6824516A4D0; Fri, 11 Jun 2004 16:07:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1031743D45; Fri, 11 Jun 2004 16:07:30 +0000 (GMT) (envelope-from eik@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BG72NQ068698; Fri, 11 Jun 2004 16:07:02 GMT (envelope-from eik@repoman.freebsd.org) Received: (from eik@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BG72iv068697; Fri, 11 Jun 2004 16:07:02 GMT (envelope-from eik) Message-Id: <200406111607.i5BG72iv068697@repoman.freebsd.org> From: Oliver Eikemeier Date: Fri, 11 Jun 2004 16:07:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/md5 Makefile md5.1 md5.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 16:07:30 -0000 eik 2004-06-11 16:07:02 UTC FreeBSD src repository Modified files: sbin/md5 Makefile md5.1 md5.c Log: Add sha1 and rmd160 checksum tools. Since the algorithms are already supported in libmd, the size increase is small when a dynamic root is used. Approved by: joerg, ru MFC after: 2 weeks Revision Changes Path 1.9 +10 -1 src/sbin/md5/Makefile 1.21 +62 -19 src/sbin/md5/md5.1 1.32 +134 -47 src/sbin/md5/md5.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 16:09:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C10F616A4CE; Fri, 11 Jun 2004 16:09:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA30C43D54; Fri, 11 Jun 2004 16:09:45 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BG9dVb068842; Fri, 11 Jun 2004 16:09:39 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BG9d2A068841; Fri, 11 Jun 2004 16:09:39 GMT (envelope-from obrien) Message-Id: <200406111609.i5BG9d2A068841@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 11 Jun 2004 16:09:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/usr.bin/binutils/gdb Makefile kvm-fbsd-alpha.h kvm-fbsd-i386.h kvm-fbsd-sparc64.h kvm-fbsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 16:09:45 -0000 obrien 2004-06-11 16:09:39 UTC FreeBSD src repository Modified files: gnu/usr.bin/binutils/gdb Makefile kvm-fbsd.c Added files: gnu/usr.bin/binutils/gdb kvm-fbsd-alpha.h kvm-fbsd-i386.h kvm-fbsd-sparc64.h Log: Sperate out the MD parts of kvm-fbsd to get rid of the #ifdef maze. Also quiet some warnings by tweaking the included headers. Revision Changes Path 1.80 +5 -2 src/gnu/usr.bin/binutils/gdb/Makefile 1.1 +77 -0 src/gnu/usr.bin/binutils/gdb/kvm-fbsd-alpha.h (new) 1.1 +131 -0 src/gnu/usr.bin/binutils/gdb/kvm-fbsd-i386.h (new) 1.1 +96 -0 src/gnu/usr.bin/binutils/gdb/kvm-fbsd-sparc64.h (new) 1.49 +8 -273 src/gnu/usr.bin/binutils/gdb/kvm-fbsd.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 17:25:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92EF516A4CE; Fri, 11 Jun 2004 17:25:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74BF843D5E; Fri, 11 Jun 2004 17:25:42 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BHPci4091992; Fri, 11 Jun 2004 17:25:38 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BHPce6091991; Fri, 11 Jun 2004 17:25:38 GMT (envelope-from marcel) Message-Id: <200406111725.i5BHPce6091991@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 11 Jun 2004 17:25:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/xinstall install.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 17:25:42 -0000 marcel 2004-06-11 17:25:38 UTC FreeBSD src repository Modified files: usr.bin/xinstall install.1 Log: Document the STRIPBIN environment variable. This includes adding a forward reference from where strip(1) is being mention (-s option). PR: bin/28620 Revision Changes Path 1.28 +12 -0 src/usr.bin/xinstall/install.1 From owner-cvs-src@FreeBSD.ORG Fri Jun 11 17:48:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C688016A4CE; Fri, 11 Jun 2004 17:48:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A923243D31; Fri, 11 Jun 2004 17:48:56 +0000 (GMT) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BHmKXS096249; Fri, 11 Jun 2004 17:48:20 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BHmKcw096248; Fri, 11 Jun 2004 17:48:20 GMT (envelope-from julian) Message-Id: <200406111748.i5BHmKcw096248@repoman.freebsd.org> From: Julian Elischer Date: Fri, 11 Jun 2004 17:48:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_kse.c kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 17:48:56 -0000 julian 2004-06-11 17:48:20 UTC FreeBSD src repository Modified files: sys/kern kern_kse.c kern_thread.c Log: Shuffle some code around. Revision Changes Path 1.181 +25 -42 src/sys/kern/kern_kse.c 1.181 +42 -1 src/sys/kern/kern_thread.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 17:51:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82ED516A4CE; Fri, 11 Jun 2004 17:51:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64CD243D54; Fri, 11 Jun 2004 17:51:41 +0000 (GMT) (envelope-from schweikh@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BHpbx0097387; Fri, 11 Jun 2004 17:51:37 GMT (envelope-from schweikh@repoman.freebsd.org) Received: (from schweikh@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BHpb4W097386; Fri, 11 Jun 2004 17:51:37 GMT (envelope-from schweikh) Message-Id: <200406111751.i5BHpb4W097386@repoman.freebsd.org> From: Jens Schweikhardt Date: Fri, 11 Jun 2004 17:51:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bktr bktr_mem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 17:51:41 -0000 schweikh 2004-06-11 17:51:37 UTC FreeBSD src repository Modified files: sys/dev/bktr bktr_mem.c Log: * Fix typo in comment. * remove extraneous semicolon between function definitions. * vm_offset_t is not a pointer, so return 0, not NULL. This fixes two warnings. Revision Changes Path 1.9 +4 -6 src/sys/dev/bktr/bktr_mem.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 17:52:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C71316A4CE; Fri, 11 Jun 2004 17:52:25 +0000 (GMT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D26043D39; Fri, 11 Jun 2004 17:52:25 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.12.8/8.12.8) with ESMTP id i5BHqNVu016512; Fri, 11 Jun 2004 13:52:23 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200406111607.i5BG72iv068697@repoman.freebsd.org> References: <200406111607.i5BG72iv068697@repoman.freebsd.org> Date: Fri, 11 Jun 2004 13:52:22 -0400 To: Oliver Eikemeier , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) Subject: Re: cvs commit: src/sbin/md5 Makefile md5.1 md5.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 17:52:25 -0000 At 4:07 PM +0000 6/11/04, Oliver Eikemeier wrote: >eik 2004-06-11 16:07:02 UTC > > FreeBSD src repository > > Modified files: > sbin/md5 Makefile md5.1 md5.c > Log: > Add sha1 and rmd160 checksum tools. > > Since the algorithms are already supported in libmd, > the size increase is small when a dynamic root is used. > > Approved by: joerg, ru > MFC after: 2 weeks For 4.x-stable, root is still statically-linked, right? Do we want to MFC it for that? Or will it cause too much of a size increase? -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Fri Jun 11 18:10:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA4C516A4CE; Fri, 11 Jun 2004 18:10:16 +0000 (GMT) Received: from fillmore.dyndns.org (port-212-202-50-15.dynamic.qsc.de [212.202.50.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87FC143D49; Fri, 11 Jun 2004 18:10:16 +0000 (GMT) (envelope-from eikemeier@fillmore-labs.com) Received: from [172.16.0.12] (helo=localhost) by fillmore.dyndns.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34 (FreeBSD)) id 1BYqTd-000Bt9-Cx; Fri, 11 Jun 2004 20:10:08 +0200 Date: Fri, 11 Jun 2004 20:10:04 +0200 Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v482) To: Garance A Drosihn From: Oliver Eikemeier In-Reply-To: Message-Id: <90828145-BBD2-11D8-B633-00039312D914@fillmore-labs.com> Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Oliver Eikemeier Subject: Re: cvs commit: src/sbin/md5 Makefile md5.1 md5.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 18:10:17 -0000 Garance A Drosihn wrote: > At 4:07 PM +0000 6/11/04, Oliver Eikemeier wrote: >> [...] >> Add sha1 and rmd160 checksum tools. >> >> Since the algorithms are already supported in libmd, >> the size increase is small when a dynamic root is used. >> >> Approved by: joerg, ru >> MFC after: 2 weeks > > For 4.x-stable, root is still statically-linked, right? Do > we want to MFC it for that? Or will it cause too much of a > size increase? It will have more impact on 4.x, but not so much that it will cause problems until 4.x goes away. The design decision came from the consideration whether it is worth to write another tool or probably move md5 from /sbin to /usr/bin. Since this is a good solution for -CURRENT, it would only matter for -STABLE when md5 where part of the installation tools, which afaik it is not. -Oliver From owner-cvs-src@FreeBSD.ORG Fri Jun 11 18:17:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 427CC16A4CE; Fri, 11 Jun 2004 18:17:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2459443D4C; Fri, 11 Jun 2004 18:17:26 +0000 (GMT) (envelope-from bmilekic@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BIHPPH003701; Fri, 11 Jun 2004 18:17:25 GMT (envelope-from bmilekic@repoman.freebsd.org) Received: (from bmilekic@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BIHPGX003700; Fri, 11 Jun 2004 18:17:25 GMT (envelope-from bmilekic) Message-Id: <200406111817.i5BIHPGX003700@repoman.freebsd.org> From: Bosko Milekic Date: Fri, 11 Jun 2004 18:17:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_mbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 18:17:26 -0000 bmilekic 2004-06-11 18:17:25 UTC FreeBSD src repository Modified files: sys/kern uipc_mbuf.c Log: Gah! Plug a mbuf leak I introduced in the last commit. I don the pointy-hat. Problem reported by: Peter Holm Revision Changes Path 1.133 +3 -2 src/sys/kern/uipc_mbuf.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 18:42:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3C4E16A4CE; Fri, 11 Jun 2004 18:42:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B726843D49; Fri, 11 Jun 2004 18:42:46 +0000 (GMT) (envelope-from vkashyap@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BIgiJ2009994; Fri, 11 Jun 2004 18:42:44 GMT (envelope-from vkashyap@repoman.freebsd.org) Received: (from vkashyap@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BIgip5009993; Fri, 11 Jun 2004 18:42:44 GMT (envelope-from vkashyap) Message-Id: <200406111842.i5BIgip5009993@repoman.freebsd.org> From: Vinod Kashyap Date: Fri, 11 Jun 2004 18:42:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/twe twe.c twe_freebsd.c twevar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 18:42:47 -0000 vkashyap 2004-06-11 18:42:44 UTC FreeBSD src repository Modified files: sys/dev/twe twe.c twe_freebsd.c twevar.h Log: Fix for a problem seen only on 6xxx series controllers, where-in the driver tries to submit the same request repeatedly, on finding the controller cmd queue to be full. Submitted by:ps, vkashyap Reviewed by:re Approved by:re Revision Changes Path 1.22 +7 -3 src/sys/dev/twe/twe.c 1.38 +7 -3 src/sys/dev/twe/twe_freebsd.c 1.13 +3 -2 src/sys/dev/twe/twevar.h From owner-cvs-src@FreeBSD.ORG Fri Jun 11 18:48:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A85716A4CE; Fri, 11 Jun 2004 18:48:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DA1543D1F; Fri, 11 Jun 2004 18:48:01 +0000 (GMT) (envelope-from schweikh@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BIlji8010296; Fri, 11 Jun 2004 18:47:45 GMT (envelope-from schweikh@repoman.freebsd.org) Received: (from schweikh@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BIljAA010295; Fri, 11 Jun 2004 18:47:45 GMT (envelope-from schweikh) Message-Id: <200406111847.i5BIljAA010295@repoman.freebsd.org> From: Jens Schweikhardt Date: Fri, 11 Jun 2004 18:47:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bktr bktr_mem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 18:48:01 -0000 schweikh 2004-06-11 18:47:45 UTC FreeBSD src repository Modified files: sys/dev/bktr bktr_mem.c Log: Style cleanup. Revision Changes Path 1.10 +81 -64 src/sys/dev/bktr/bktr_mem.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 18:57:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C0EB16A4CE; Fri, 11 Jun 2004 18:57:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9610743D5A; Fri, 11 Jun 2004 18:57:32 +0000 (GMT) (envelope-from vkashyap@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BIvWXD012559; Fri, 11 Jun 2004 18:57:32 GMT (envelope-from vkashyap@repoman.freebsd.org) Received: (from vkashyap@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BIvWCd012558; Fri, 11 Jun 2004 18:57:32 GMT (envelope-from vkashyap) Message-Id: <200406111857.i5BIvWCd012558@repoman.freebsd.org> From: Vinod Kashyap Date: Fri, 11 Jun 2004 18:57:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/twe twe.c twe_freebsd.c twevar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 18:57:32 -0000 vkashyap 2004-06-11 18:57:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/twe twe.c twe_freebsd.c twevar.h Log: Fix for a problem seen only on 6xxx series controllers, where-in the driver tries to submit the same request repeatedly, on finding the controller cmd queue to be full. This is an MFC from -CURRENT, and is being done a bit fast because it addresses a 4.10 errata item, and has already been tested for a week on a heavily used -STABLE machine that was previously showing symptoms of the problem. Submitted by:ps, vkashyap Reviewed by:re Approved by:re Revision Changes Path 1.1.2.10 +8 -3 src/sys/dev/twe/twe.c 1.2.2.9 +7 -3 src/sys/dev/twe/twe_freebsd.c 1.1.2.8 +3 -2 src/sys/dev/twe/twevar.h From owner-cvs-src@FreeBSD.ORG Fri Jun 11 19:31:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDB1A16A4D0; Fri, 11 Jun 2004 19:31:08 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 395C943D2D; Fri, 11 Jun 2004 19:31:08 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 1B337530A; Fri, 11 Jun 2004 21:31:05 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 98B3B5309; Fri, 11 Jun 2004 21:30:58 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 3ECB133C71; Fri, 11 Jun 2004 21:30:58 +0200 (CEST) To: Vinod Kashyap References: <200406111842.i5BIgip5009993@repoman.freebsd.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Fri, 11 Jun 2004 21:30:58 +0200 In-Reply-To: <200406111842.i5BIgip5009993@repoman.freebsd.org> (Vinod Kashyap's message of "Fri, 11 Jun 2004 18:42:44 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/twe twe.c twe_freebsd.c twevar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 19:31:09 -0000 Vinod Kashyap writes: > Submitted by:ps, vkashyap > Reviewed by:re > Approved by:re You don't need re's approval to commit to HEAD. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Fri Jun 11 19:55:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 06A6116A4CE; Fri, 11 Jun 2004 19:55:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD27843D53; Fri, 11 Jun 2004 19:55:57 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BJtvCI025896; Fri, 11 Jun 2004 19:55:57 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BJtvvr025894; Fri, 11 Jun 2004 19:55:57 GMT (envelope-from alc) Message-Id: <200406111955.i5BJtvvr025894@repoman.freebsd.org> From: Alan Cox Date: Fri, 11 Jun 2004 19:55:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha pmap.c uma_machdep.c src/sys/conf files.alpha X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 19:55:58 -0000 alc 2004-06-11 19:55:57 UTC FreeBSD src repository Modified files: sys/alpha/alpha pmap.c sys/conf files.alpha Added files: sys/alpha/alpha uma_machdep.c Log: Move uma_small_alloc() and uma_small_free() out of the pmap and into their own machine-dependent file. This makes alpha consistent with amd64, ia64, and powerpc. Revision Changes Path 1.148 +0 -46 src/sys/alpha/alpha/pmap.c 1.1 +82 -0 src/sys/alpha/alpha/uma_machdep.c (new) 1.111 +1 -0 src/sys/conf/files.alpha From owner-cvs-src@FreeBSD.ORG Fri Jun 11 20:11:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15CE516A4CE; Fri, 11 Jun 2004 20:11:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B460543D1F; Fri, 11 Jun 2004 20:11:51 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BKBfZm030301; Fri, 11 Jun 2004 20:11:41 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BKBfZY030300; Fri, 11 Jun 2004 20:11:41 GMT (envelope-from alc) Message-Id: <200406112011.i5BKBfZY030300@repoman.freebsd.org> From: Alan Cox Date: Fri, 11 Jun 2004 20:11:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/ia64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 20:11:52 -0000 alc 2004-06-11 20:11:41 UTC FreeBSD src repository Modified files: sys/ia64/ia64 pmap.c Log: Neither pmap_enter() nor pmap_enter_quick() should create pv entries for unmanaged pages. Tested by: marcel@ Revision Changes Path 1.134 +10 -4 src/sys/ia64/ia64/pmap.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 22:17:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D33DC16A4CE; Fri, 11 Jun 2004 22:17:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCDC743D1D; Fri, 11 Jun 2004 22:17:33 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BMHFIS064237; Fri, 11 Jun 2004 22:17:15 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BMHFfM064236; Fri, 11 Jun 2004 22:17:15 GMT (envelope-from csjp) Message-Id: <200406112217.i5BMHFfM064236@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Fri, 11 Jun 2004 22:17:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 22:17:34 -0000 csjp 2004-06-11 22:17:15 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c Log: Modify ip fw so that whenever UID or GID constraints exist in a ruleset, the pcb is looked up once per ipfw_chk() activation. This is done by extracting the required information out of the PCB and caching it to the ipfw_chk() stack. This should greatly reduce PCB looking contention and speed up the processing of UID/GID based firewall rules (especially with large UID/GID rulesets). Some very basic benchmarks were taken which compares the number of in_pcblookup_hash(9) activations to the number of firewall rules containing UID/GID based contraints before and after this patch. The results can be viewed here: o http://people.freebsd.org/~csjp/ip_fw_pcb.png Reviewed by: andre, luigi, rwatson Approved by: bmilekic (mentor) Revision Changes Path 1.62 +77 -30 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Fri Jun 11 22:40:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6206316A4CE; Fri, 11 Jun 2004 22:40:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4424743D45; Fri, 11 Jun 2004 22:40:01 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5BMdhVJ068376; Fri, 11 Jun 2004 22:39:43 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5BMdhjM068375; Fri, 11 Jun 2004 22:39:43 GMT (envelope-from rwatson) Message-Id: <200406112239.i5BMdhjM068375@repoman.freebsd.org> From: Robert Watson Date: Fri, 11 Jun 2004 22:39:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 22:40:01 -0000 rwatson 2004-06-11 22:39:43 UTC FreeBSD src repository Modified files: sys/sys socketvar.h Log: Use tabs instead of spaces between #define and macro name; a merge mistake as they are in rwatson_netperf. Revision Changes Path 1.116 +2 -2 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Sat Jun 12 00:10:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0563B16A4DC; Sat, 12 Jun 2004 00:10:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2A5643D2F; Sat, 12 Jun 2004 00:10:54 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C0AMAf088561; Sat, 12 Jun 2004 00:10:22 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C0AMcc088560; Sat, 12 Jun 2004 00:10:22 GMT (envelope-from mlaier) Message-Id: <200406120010.i5C0AMcc088560@repoman.freebsd.org> From: Max Laier Date: Sat, 12 Jun 2004 00:10:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: KAME Subject: cvs commit: src/sys/contrib - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 00:10:55 -0000 mlaier 2004-06-12 00:10:21 UTC FreeBSD src repository src/sys/contrib - Imported sources Update of /home/ncvs/src/sys/contrib In directory repoman.freebsd.org:/tmp/cvs-serv88498 Log Message: Import parts of the ALTQ framework from latest KAME snapshot (which is up to HEAD at this point). This will not exactly live in a vendor branch, but have the vendor backing to make it easier to exchange diffs. This will be followed by a diff which takes most of the .c files off the vendor branch in order to: - add locking - disable ALTQ3_COMPAT code (which is outdated and "un-lockable") There is work in progress to refine the configuration API. Import this "as is" now to have more exposure time before 5-STABLE. This is only the import, it will be some more days until you will actually be able to compile ALTQ support into your kernel so don't hold your breath. HEADUPs will be posted on current@ and net@ before this is actually enabled. No-objection: re(scottl), core(rwatson) Status: Vendor Tag: KAME Release Tags: freebsd4_snap_20040607 N src/sys/contrib/altq/altq/altqconf.h N src/sys/contrib/altq/altq/altq_var.h N src/sys/contrib/altq/altq/altq_subr.c N src/sys/contrib/altq/altq/altq_rmclass_debug.h N src/sys/contrib/altq/altq/altq_rmclass.h N src/sys/contrib/altq/altq/altq_rmclass.c N src/sys/contrib/altq/altq/altq_rio.h N src/sys/contrib/altq/altq/altq_rio.c N src/sys/contrib/altq/altq/altq_red.h N src/sys/contrib/altq/altq/altq_red.c N src/sys/contrib/altq/altq/altq_priq.h N src/sys/contrib/altq/altq/altq_priq.c N src/sys/contrib/altq/altq/if_altq.h N src/sys/contrib/altq/altq/altq_hfsc.c N src/sys/contrib/altq/altq/altq_classq.h N src/sys/contrib/altq/altq/altq_cdnr.h N src/sys/contrib/altq/altq/altq_cdnr.c N src/sys/contrib/altq/altq/altq_cbq.h N src/sys/contrib/altq/altq/altq_cbq.c N src/sys/contrib/altq/altq/altq.h N src/sys/contrib/altq/altq/altq_hfsc.h No conflicts created by this import From owner-cvs-src@FreeBSD.ORG Sat Jun 12 00:57:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1076716A4CE; Sat, 12 Jun 2004 00:57:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A02943D48; Sat, 12 Jun 2004 00:57:21 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C0vKfx004900; Sat, 12 Jun 2004 00:57:20 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C0vK62004899; Sat, 12 Jun 2004 00:57:20 GMT (envelope-from mlaier) Message-Id: <200406120057.i5C0vK62004899@repoman.freebsd.org> From: Max Laier Date: Sat, 12 Jun 2004 00:57:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/contrib/altq/altq altq.h altq_cbq.c altq_cdnr.c altq_hfsc.c altq_priq.c altq_red.c altq_rio.c altq_rmclass.c altq_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 00:57:21 -0000 mlaier 2004-06-12 00:57:20 UTC FreeBSD src repository Modified files: sys/contrib/altq/altq altq.h altq_cbq.c altq_cdnr.c altq_hfsc.c altq_priq.c altq_red.c altq_rio.c altq_rmclass.c altq_subr.c Log: FreeBSD-ify ALTQ: - add locking - disable ALTQ3_COMPAT by default (do not remove the code to keep the diff towards KAME small) - put some more code under ALTQ3 conditional compilation as it should be - account for if_xname - some more minor compile fixes As people started wondering: The strange path layout "altq/altq" is there to avoid "-Isys/contrib" and make it "-Isys/contrib/altq" instead, as we will need at least and for kernel compilation. The "freebsd4_..." in the privious commit is just the best tag name in the KAME tree I could find to classify this in order to track its history. It does *not* mean that this will go to 4-STABLE or anything of that kind. Revision Changes Path 1.2 +2 -1 src/sys/contrib/altq/altq/altq.h 1.2 +17 -3 src/sys/contrib/altq/altq/altq_cbq.c 1.2 +3 -0 src/sys/contrib/altq/altq/altq_cdnr.c 1.2 +18 -1 src/sys/contrib/altq/altq/altq_hfsc.c 1.2 +15 -1 src/sys/contrib/altq/altq/altq_priq.c 1.2 +11 -0 src/sys/contrib/altq/altq/altq_red.c 1.2 +7 -0 src/sys/contrib/altq/altq/altq_rio.c 1.2 +9 -0 src/sys/contrib/altq/altq/altq_rmclass.c 1.2 +82 -15 src/sys/contrib/altq/altq/altq_subr.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 01:20:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 04B3316A4CE; Sat, 12 Jun 2004 01:20:41 +0000 (GMT) Received: from ozlabs.org (ozlabs.org [203.10.76.45]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85D2043D31; Sat, 12 Jun 2004 01:20:40 +0000 (GMT) (envelope-from grog@lemis.com) Received: from blackwater.lemis.com (blackwater.lemis.com [192.109.197.80]) by ozlabs.org (Postfix) with ESMTP id EDCA32BD43; Sat, 12 Jun 2004 11:20:03 +1000 (EST) Received: by blackwater.lemis.com (Postfix, from userid 1004) id 07B0C51737; Sat, 12 Jun 2004 10:50:02 +0930 (CST) Date: Sat, 12 Jun 2004 10:50:01 +0930 From: Greg 'groggy' Lehey To: Ken Smith Message-ID: <20040612012001.GD93033@wantadilla.lemis.com> References: <200406050702.i5572IYw001549@repoman.freebsd.org> <20040605071611.GC22772@electra.cse.Buffalo.EDU> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fXStkuK2IQBfcDe+" Content-Disposition: inline In-Reply-To: <20040605071611.GC22772@electra.cse.Buffalo.EDU> User-Agent: Mutt/1.4.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: Nate Lawson cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Repo time zone (was: cvs commit: src/sys/dev/acpica acpi_cpu.c src/share/man/man4 acpi.4) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 01:20:41 -0000 --fXStkuK2IQBfcDe+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Saturday, 5 June 2004 at 3:16:11 -0400, Ken Smith wrote: > On Sat, Jun 05, 2004 at 07:02:18AM +0000, Nate Lawson wrote: > >> njl 2004/06/05 07:02:18 GMT > > As threatened... The CVS repository machine is now running on GMT > so commit timestamps will be GMT instead of PST from now on. Why GMT (British standard) rather than UTC (international standard)? Greg -- Note: I discard all HTML mail unseen. Finger grog@FreeBSD.org for PGP public key. See complete headers for address and phone numbers. --fXStkuK2IQBfcDe+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQFAylpBIubykFB6QiMRAsJ9AJ4goO3naCHomuChq9aTY971FbHHCACgmCmV hyWPGszTpnRDFa1kGRbOMaw= =MAQ3 -----END PGP SIGNATURE----- --fXStkuK2IQBfcDe+-- From owner-cvs-src@FreeBSD.ORG Sat Jun 12 01:27:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A52D816A4CE; Sat, 12 Jun 2004 01:27:20 +0000 (GMT) Received: from ozlabs.org (ozlabs.org [203.10.76.45]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7191443D49; Sat, 12 Jun 2004 01:27:20 +0000 (GMT) (envelope-from grog@lemis.com) Received: from blackwater.lemis.com (blackwater.lemis.com [192.109.197.80]) by ozlabs.org (Postfix) with ESMTP id DAA292BD43; Sat, 12 Jun 2004 11:26:26 +1000 (EST) Received: by blackwater.lemis.com (Postfix, from userid 1004) id D923C51737; Sat, 12 Jun 2004 10:56:24 +0930 (CST) Date: Sat, 12 Jun 2004 10:56:24 +0930 From: Greg 'groggy' Lehey To: Ken Smith Message-ID: <20040612012624.GE93033@wantadilla.lemis.com> References: <200406050702.i5572IYw001549@repoman.freebsd.org> <20040605071611.GC22772@electra.cse.Buffalo.EDU> <20040612012001.GD93033@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Oiv9uiLrevHtW1RS" Content-Disposition: inline In-Reply-To: <20040612012001.GD93033@wantadilla.lemis.com> User-Agent: Mutt/1.4.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: Nate Lawson cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: Repo time zone (was: cvs commit: src/sys/dev/acpica acpi_cpu.c src/share/man/man4 acpi.4) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 01:27:20 -0000 --Oiv9uiLrevHtW1RS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Saturday, 12 June 2004 at 10:50:01 +0930, Greg 'groggy' Lehey wrote: > On Saturday, 5 June 2004 at 3:16:11 -0400, Ken Smith wrote: >> On Sat, Jun 05, 2004 at 07:02:18AM +0000, Nate Lawson wrote: >> >>> njl 2004/06/05 07:02:18 GMT >> >> As threatened... The CVS repository machine is now running on GMT >> so commit timestamps will be GMT instead of PST from now on. > > Why GMT (British standard) rather than UTC (international standard)? Never mind. That's what comes from batching reading commit messages. Greg -- Note: I discard all HTML mail unseen. Finger grog@FreeBSD.org for PGP public key. See complete headers for address and phone numbers. --Oiv9uiLrevHtW1RS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQFAylvAIubykFB6QiMRAqxVAKCjkjdMKbKrjsIm4w+2Qx85X96z/gCgqse1 +W1vgCGyu+yLK5lbsl8/Lho= =YR/M -----END PGP SIGNATURE----- --Oiv9uiLrevHtW1RS-- From owner-cvs-src@FreeBSD.ORG Sat Jun 12 02:23:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C90E416A4CE; Sat, 12 Jun 2004 02:23:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAEBF43D48; Sat, 12 Jun 2004 02:23:24 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C2N7q8024995; Sat, 12 Jun 2004 02:23:07 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C2N76H024994; Sat, 12 Jun 2004 02:23:07 GMT (envelope-from marius) Message-Id: <200406120223.i5C2N76H024994@repoman.freebsd.org> From: Marius Strobl Date: Sat, 12 Jun 2004 02:23:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/hme if_hme.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 02:23:25 -0000 marius 2004-06-12 02:23:07 UTC FreeBSD src repository Modified files: sys/dev/hme if_hme.c Log: Back out 1.23 until I figure out why it causes Netra t1 100 to no longer pass any traffic. Unfortunately this means no full-duplex link with auto- negotiation on hme(4) using DP83840A PHYs again. I really thought I had tested this also on a Netra t1 100... Revision Changes Path 1.27 +1 -1 src/sys/dev/hme/if_hme.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 03:23:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47EB616A4CE; Sat, 12 Jun 2004 03:23:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2639243D2F; Sat, 12 Jun 2004 03:23:53 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C3NbMN038391; Sat, 12 Jun 2004 03:23:37 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C3Nbk4038390; Sat, 12 Jun 2004 03:23:37 GMT (envelope-from scottl) Message-Id: <200406120323.i5C3Nbk4038390@repoman.freebsd.org> From: Scott Long Date: Sat, 12 Jun 2004 03:23:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/esp esp_sbus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 03:23:53 -0000 scottl 2004-06-12 03:23:37 UTC FreeBSD src repository Modified files: sys/dev/esp esp_sbus.c Log: Correct typo from previous commit. Revision Changes Path 1.3 +1 -1 src/sys/dev/esp/esp_sbus.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 04:41:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B91EC16A4CE; Sat, 12 Jun 2004 04:41:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8590443D46; Sat, 12 Jun 2004 04:41:25 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C4elmI053923; Sat, 12 Jun 2004 04:40:47 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C4elsY053922; Sat, 12 Jun 2004 04:40:47 GMT (envelope-from das) Message-Id: <200406120440.i5C4elsY053922@repoman.freebsd.org> From: David Schultz Date: Sat, 12 Jun 2004 04:40:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun/man ieee_test.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 04:41:25 -0000 das 2004-06-12 04:40:47 UTC FreeBSD src repository Modified files: lib/msun/man ieee_test.3 Log: The references to scalbn and scalbnf should be scalb and scalbf. (The former are actually useful, and ieee_test(3) only documents functions that aren't.) Add a sentence describing the domain of scalb() and scalbf(). Revision Changes Path 1.11 +5 -2 src/lib/msun/man/ieee_test.3 From owner-cvs-src@FreeBSD.ORG Sat Jun 12 05:20:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B911016A4CE; Sat, 12 Jun 2004 05:20:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B1EF43D1D; Sat, 12 Jun 2004 05:20:07 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C5JHwb069059; Sat, 12 Jun 2004 05:19:17 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C5JHf3069058; Sat, 12 Jun 2004 05:19:17 GMT (envelope-from scottl) Message-Id: <200406120519.i5C5JHf3069058@repoman.freebsd.org> From: Scott Long Date: Sat, 12 Jun 2004 05:19:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/esp ncr53c9x.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 05:20:07 -0000 scottl 2004-06-12 05:19:17 UTC FreeBSD src repository Modified files: sys/dev/esp ncr53c9x.c Log: When autosense is retrieved, tell CAM about it instead of juust pretending that the command succeeded. Sheesh! This makes CDROMs no longer cause an instant panic at boot. Thanks to Jake Burkholder for providing a remote test setup. Also make device resets work, thanks to another typo. Revision Changes Path 1.3 +2 -1 src/sys/dev/esp/ncr53c9x.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 06:04:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADC0C16A4CE; Sat, 12 Jun 2004 06:04:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9199743D2D; Sat, 12 Jun 2004 06:04:07 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C63RYU079987; Sat, 12 Jun 2004 06:03:27 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C63RRL079986; Sat, 12 Jun 2004 06:03:27 GMT (envelope-from alc) Message-Id: <200406120603.i5C63RRL079986@repoman.freebsd.org> From: Alan Cox Date: Sat, 12 Jun 2004 06:03:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 06:04:07 -0000 alc 2004-06-12 06:03:27 UTC FreeBSD src repository Modified files: sys/alpha/alpha pmap.c Log: Remove an unused #include. Revision Changes Path 1.149 +0 -1 src/sys/alpha/alpha/pmap.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 06:32:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8218816A4CE for ; Sat, 12 Jun 2004 06:32:37 +0000 (GMT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 5A23543D46 for ; Sat, 12 Jun 2004 06:32:37 +0000 (GMT) (envelope-from nate@root.org) Received: (qmail 3316 invoked by uid 1000); 12 Jun 2004 06:32:19 -0000 Date: Fri, 11 Jun 2004 23:32:19 -0700 (PDT) From: Nate Lawson To: Alfred Perlstein In-Reply-To: <20040611012513.GI78955@elvis.mu.org> Message-ID: <20040611232939.F3249@root.org> References: <200406102134.i5ALYcNr004704@repoman.freebsd.org> <20040611012513.GI78955@elvis.mu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Robert Watson cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 06:32:37 -0000 On Thu, 10 Jun 2004, Alfred Perlstein wrote: > * Robert Watson [040610 14:34] wrote: > > - Sam's version of this change, as with the BSD/OS version, made use of > > both a global lock and per-unpcb locks. However, in practice, the > > global lock covered all accesses, so I have simplified out the unpcb > > locks in the interest of getting this merged faster (reducing the > > overhead but not sacrificing granularity in most cases). We will want > > to explore possibilities for improving lock granularity in this code in > > the future. > > I noticed this in the BSD/os version, it was sort of like... > "the global lock covers everything, what's the point of the > underlying locks..?" In my conversation with the BSD/OS guys, there were often cases where they went with a more global lock within a subsystem versus untangling re-entrant paths, which would be needed for finer-grained locking. This was true for the CAM approach they used where a single mutex per device instance and a middle layer lock protected queue handling. -Nate From owner-cvs-src@FreeBSD.ORG Sat Jun 12 06:42:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6352F16A4CE; Sat, 12 Jun 2004 06:42:04 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F25043D48; Sat, 12 Jun 2004 06:42:04 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from freebsd.org (junior-wifi.samsco.home [192.168.0.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i5C6iD0i013950; Sat, 12 Jun 2004 00:44:14 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <40CAA578.2060808@freebsd.org> Date: Sat, 12 Jun 2004 00:40:56 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <200406102134.i5ALYcNr004704@repoman.freebsd.org> <20040611012513.GI78955@elvis.mu.org> <20040611232939.F3249@root.org> In-Reply-To: <20040611232939.F3249@root.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: Alfred Perlstein cc: Robert Watson cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 06:42:04 -0000 Nate Lawson wrote: > On Thu, 10 Jun 2004, Alfred Perlstein wrote: > >>* Robert Watson [040610 14:34] wrote: >> >>> - Sam's version of this change, as with the BSD/OS version, made use of >>> both a global lock and per-unpcb locks. However, in practice, the >>> global lock covered all accesses, so I have simplified out the unpcb >>> locks in the interest of getting this merged faster (reducing the >>> overhead but not sacrificing granularity in most cases). We will want >>> to explore possibilities for improving lock granularity in this code in >>> the future. >> >>I noticed this in the BSD/os version, it was sort of like... >>"the global lock covers everything, what's the point of the >>underlying locks..?" > > > In my conversation with the BSD/OS guys, there were often cases where they > went with a more global lock within a subsystem versus untangling > re-entrant paths, which would be needed for finer-grained locking. This > was true for the CAM approach they used where a single mutex per device > instance and a middle layer lock protected queue handling. > > -Nate Yes, but as this approach was described to me, I'm not terribly sure that it would work in an environment with multiple SIMs. I appreciate their approach of 'medium-grain locking' a lot, but I question whether their approach to CAM and to network locking was really sufficient. Scott From owner-cvs-src@FreeBSD.ORG Sat Jun 12 07:40:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69AF316A4CE; Sat, 12 Jun 2004 07:40:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6454A43D2F; Sat, 12 Jun 2004 07:40:04 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C7e29w099400; Sat, 12 Jun 2004 07:40:02 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C7e288099399; Sat, 12 Jun 2004 07:40:02 GMT (envelope-from davidxu) Message-Id: <200406120740.i5C7e288099399@repoman.freebsd.org> From: David Xu Date: Sat, 12 Jun 2004 07:40:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/thread thr_create.c thr_private.h thr_sig.c thr_sigsuspend.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 07:40:04 -0000 davidxu 2004-06-12 07:40:01 UTC FreeBSD src repository Modified files: lib/libpthread/thread thr_create.c thr_private.h thr_sig.c thr_sigsuspend.c Log: Check pending signals, if there is signal will be unblocked by sigsuspend, thread shouldn't wait, in old code, it may be ignored. When a signal handler is invoked in sigsuspend, thread gets two different signal masks, one is in thread structure, sigprocmask() can retrieve it, another is in ucontext which is a third parameter of signal handler, the former is the result of sigsuspend mask ORed with sigaction's sa_mask and current signal, the later is the mask in thread structure before sigsuspend is called. After signal handler is called, the mask in ucontext should be copied into thread structure, and becomes CURRENT signal mask, then sigsuspend returns to user code. Reviewed by: deischen Tested by: Sean McNeil Revision Changes Path 1.54 +1 -0 src/lib/libpthread/thread/thr_create.c 1.114 +1 -0 src/lib/libpthread/thread/thr_private.h 1.78 +5 -1 src/lib/libpthread/thread/thr_sig.c 1.24 +18 -21 src/lib/libpthread/thread/thr_sigsuspend.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 10:12:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A0A116A4CE; Sat, 12 Jun 2004 10:12:07 +0000 (GMT) Received: from watery.cc.kogakuin.ac.jp (watery.cc.kogakuin.ac.jp [133.80.152.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8309543D53; Sat, 12 Jun 2004 10:12:06 +0000 (GMT) (envelope-from nyan@jp.FreeBSD.org) Received: from localhost (localhost [IPv6:::1])i5CABr4O051028; Sat, 12 Jun 2004 19:11:53 +0900 (JST) (envelope-from nyan@jp.FreeBSD.org) Date: Sat, 12 Jun 2004 19:11:39 +0900 (JST) Message-Id: <20040612.191139.74706881.nyan@jp.FreeBSD.org> To: jhb@FreeBSD.org From: Takahashi Yoshihiro In-Reply-To: <200406102031.i5AKV0WV082812@repoman.freebsd.org> References: <200406102031.i5AKV0WV082812@repoman.freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 =?iso-2022-jp?B?KBskQjgtTFobKEIp?= Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/include/pc bios.h src/sys/amd64/amd64 machdep.c src/sys/amd64/include md_var.h src/sys/dev/fb vga.c src/sys/dev/kbd atkbd.c src/sys/i386/bios mca_machdep.c smapi.c smbios.c vpd.c src/sys/i386/i386 machdep.c symbols.raw ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 10:12:07 -0000 In article <200406102031.i5AKV0WV082812@repoman.freebsd.org> John Baldwin writes: > jhb 2004-06-10 20:31:00 UTC > > Remove atdevbase and replace it's remaining uses with direct references to > KERNBASE instead. This broke pc98 kernel. > cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror /usr/src/sys/pc98/pc98/pc98gdc.c > /usr/src/sys/pc98/pc98/pc98gdc.c: In function `probe_adapters': > /usr/src/sys/pc98/pc98/pc98gdc.c:638: error: `KERNBASE' undeclared (first use in this function) > /usr/src/sys/pc98/pc98/pc98gdc.c:638: error: (Each undeclared identifier is reported only once > /usr/src/sys/pc98/pc98/pc98gdc.c:638: error: for each function it appears in.) > /usr/src/sys/pc98/pc98/pc98gdc.c: In function `gdc_set_origin': > /usr/src/sys/pc98/pc98/pc98gdc.c:939: error: `KERNBASE' undeclared (first use in this function) > /usr/src/sys/pc98/pc98/pc98gdc.c: In function `gdc_set_mode': > /usr/src/sys/pc98/pc98/pc98gdc.c:1099: error: `KERNBASE' undeclared (first use in this function) > *** Error code 1 --- TAKAHASHI Yoshihiro From owner-cvs-src@FreeBSD.ORG Sat Jun 12 11:22:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 648AE16A4CE; Sat, 12 Jun 2004 11:22:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4204F43D53; Sat, 12 Jun 2004 11:22:30 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CBMLt7055438; Sat, 12 Jun 2004 11:22:21 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CBMLBA055437; Sat, 12 Jun 2004 11:22:21 GMT (envelope-from des) Message-Id: <200406121122.i5CBMLBA055437@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Sat, 12 Jun 2004 11:22:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox tbmaster.pl X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 11:22:30 -0000 des 2004-06-12 11:22:21 UTC FreeBSD src repository Modified files: tools/tools/tinderbox tbmaster.pl Log: Include the config name in the log file name. Revision Changes Path 1.48 +8 -1 src/tools/tools/tinderbox/tbmaster.pl From owner-cvs-src@FreeBSD.ORG Sat Jun 12 11:23:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D9B916A4CE; Sat, 12 Jun 2004 11:23:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20C0D43D31; Sat, 12 Jun 2004 11:23:25 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CBN5r8055566; Sat, 12 Jun 2004 11:23:05 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CBN5HH055565; Sat, 12 Jun 2004 11:23:05 GMT (envelope-from des) Message-Id: <200406121123.i5CBN5HH055565@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Sat, 12 Jun 2004 11:23:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox/www index.cgi X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 11:23:25 -0000 des 2004-06-12 11:23:05 UTC FreeBSD src repository Modified files: tools/tools/tinderbox/www index.cgi Log: Group tinderbox results by config name. Skip configs whose names start with "update_". Revision Changes Path 1.23 +54 -42 src/tools/tools/tinderbox/www/index.cgi From owner-cvs-src@FreeBSD.ORG Sat Jun 12 12:32:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8AAF716A4CE; Sat, 12 Jun 2004 12:32:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E23643D39; Sat, 12 Jun 2004 12:32:27 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CCVgiF070003; Sat, 12 Jun 2004 12:31:42 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CCVg4a070002; Sat, 12 Jun 2004 12:31:42 GMT (envelope-from phk) Message-Id: <200406121231.i5CCVg4a070002@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 12 Jun 2004 12:31:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern tty_conf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 12:32:27 -0000 phk 2004-06-12 12:31:42 UTC FreeBSD src repository Modified files: sys/kern tty_conf.c Log: Fix registration of loadable line disciplines. This should make watch(8)/snp(4) work again. Revision Changes Path 1.22 +2 -1 src/sys/kern/tty_conf.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 15:44:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1006316A4CE; Sat, 12 Jun 2004 15:44:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E698743D48; Sat, 12 Jun 2004 15:44:13 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CFh1Eg018446; Sat, 12 Jun 2004 15:43:01 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CFh1kE018445; Sat, 12 Jun 2004 15:43:01 GMT (envelope-from gad) Message-Id: <200406121543.i5CFh1kE018445@repoman.freebsd.org> From: Garance A Drosehn Date: Sat, 12 Jun 2004 15:43:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 15:44:14 -0000 gad 2004-06-12 15:43:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/newsyslog newsyslog.c Log: MFC 1.84: When rotating some "blah.log" file, make sure that a chmod and (if requested) a chown is done on the "blah.log.0" file. PR: bin/67137 Submitted by: jeh Revision Changes Path 1.25.2.28 +14 -13 src/usr.sbin/newsyslog/newsyslog.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 15:45:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27D9A16A4CE; Sat, 12 Jun 2004 15:45:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0AE8A43D1D; Sat, 12 Jun 2004 15:45:32 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CFjHnT018602; Sat, 12 Jun 2004 15:45:17 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CFjHGq018601; Sat, 12 Jun 2004 15:45:17 GMT (envelope-from gad) Message-Id: <200406121545.i5CFjHGq018601@repoman.freebsd.org> From: Garance A Drosehn Date: Sat, 12 Jun 2004 15:45:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 15:45:32 -0000 gad 2004-06-12 15:45:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/newsyslog newsyslog.c Log: MFC 1.85: Improved versions of the is*ch() and tolowerch() macros. Revision Changes Path 1.25.2.29 +7 -7 src/usr.sbin/newsyslog/newsyslog.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 16:09:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6D5016A4CE; Sat, 12 Jun 2004 16:09:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B075F43D2D; Sat, 12 Jun 2004 16:09:16 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CG8fBY023765; Sat, 12 Jun 2004 16:08:41 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CG8fef023764; Sat, 12 Jun 2004 16:08:41 GMT (envelope-from rwatson) Message-Id: <200406121608.i5CG8fef023764@repoman.freebsd.org> From: Robert Watson Date: Sat, 12 Jun 2004 16:08:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys socketvar.h src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 16:09:16 -0000 rwatson 2004-06-12 16:08:41 UTC FreeBSD src repository Modified files: sys/sys socketvar.h sys/kern uipc_socket.c Log: Introduce a mutex into struct sockbuf, sb_mtx, which will be used to protect fields in the socket buffer. Add accessor macros to use the mutex (SOCKBUF_*()). Initialize the mutex in soalloc(), and destroy it in sodealloc(). Add addition, add SOCK_*() access macros which will protect most remaining fields in the socket; for the time being, use the receive socket buffer mutex to implement socket level locking to reduce memory overhead. Submitted by: sam Sponosored by: FreeBSD Foundation Obtained from: BSD/OS Revision Changes Path 1.176 +4 -0 src/sys/kern/uipc_socket.c 1.117 +27 -0 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Sat Jun 12 17:55:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5739A16A4CE; Sat, 12 Jun 2004 17:55:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3999143D2F; Sat, 12 Jun 2004 17:55:47 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CHrnSo052708; Sat, 12 Jun 2004 17:53:49 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CHrnH8052707; Sat, 12 Jun 2004 17:53:49 GMT (envelope-from gad) Message-Id: <200406121753.i5CHrnH8052707@repoman.freebsd.org> From: Garance A Drosehn Date: Sat, 12 Jun 2004 17:53:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/bin/ps ps.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 17:55:47 -0000 gad 2004-06-12 17:53:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) bin/ps ps.c Log: Make it so users can select the new (5.x) behavior for processing extra parameters by compiling `ps' with -DPS_BACKWARD_COMPATIBILITY=0, instead of requiring them to patch ps.c. The default behavior has not changed. Revision Changes Path 1.30.2.16 +7 -3 src/bin/ps/ps.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 17:58:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B079916A4CE; Sat, 12 Jun 2004 17:58:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 933DA43D1F; Sat, 12 Jun 2004 17:58:45 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CHv8TJ052874; Sat, 12 Jun 2004 17:57:08 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CHv8fO052873; Sat, 12 Jun 2004 17:57:08 GMT (envelope-from gad) Message-Id: <200406121757.i5CHv8fO052873@repoman.freebsd.org> From: Garance A Drosehn Date: Sat, 12 Jun 2004 17:57:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/newsyslog ptimes.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 17:58:45 -0000 gad 2004-06-12 17:57:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/newsyslog ptimes.c Log: MFC 1.5: Remove reference to , even if it's just a comment in 4.x. Revision Changes Path 1.4.2.2 +0 -1 src/usr.sbin/newsyslog/ptimes.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 18:37:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DDC016A4CE; Sat, 12 Jun 2004 18:37:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 011F243D46; Sat, 12 Jun 2004 18:37:42 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CIbTKW063988; Sat, 12 Jun 2004 18:37:29 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CIbTOg063987; Sat, 12 Jun 2004 18:37:29 GMT (envelope-from rwatson) Message-Id: <200406121837.i5CIbTOg063987@repoman.freebsd.org> From: Robert Watson Date: Sat, 12 Jun 2004 18:37:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 18:37:42 -0000 rwatson 2004-06-12 18:37:29 UTC FreeBSD src repository Modified files: sys/sys socketvar.h Log: Whitespace-only restyling of socket reference count macros. Revision Changes Path 1.118 +21 -21 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Sat Jun 12 18:48:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D16116A520; Sat, 12 Jun 2004 18:48:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5516443D2D; Sat, 12 Jun 2004 18:48:00 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CIlPWV066138; Sat, 12 Jun 2004 18:47:25 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CIlPVt066137; Sat, 12 Jun 2004 18:47:25 GMT (envelope-from mlaier) Message-Id: <200406121847.i5CIlPVt066137@repoman.freebsd.org> From: Max Laier Date: Sat, 12 Jun 2004 18:47:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/contrib/altq/altq if_altq.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 18:48:02 -0000 mlaier 2004-06-12 18:47:25 UTC FreeBSD src repository Modified files: sys/contrib/altq/altq if_altq.h Log: Add an additional queue which will be "owned by the driver". This allows to rig a PREPEND macro for ALTQ as the POLL/DEQUEUE semantic is very bad in terms of locking. We make this a full functional queue to allow "bulk dequeue" which will further reduce the locking overhead (for non-altq enabled devices). Drivers will access this via the following macros, which will show up in once we expose ALTQ to the build: IFQ_DRV_DEQUEUE(ifq, m) - takes a mbuf off the queue (driver queue first) IFQ_DRV_PREPEND(ifq, m) - pushes a mbuf back to the driver queue IFQ_DRV_PURGE(ifq) - drops all packets in both queues IFQ_DRV_IS_EMPTY(ifq) - checks for pending mbufs in either queue One has to make sure that the first three are protected by a driver mutex. At the moment most network drivers still require Giant, so this is not an issue. Even those that have thier own mutex usually hold it in if_start and the like, so this requirement is almost always satisfied. This evolved from a discussion with Andrew Gallatin. Revision Changes Path 1.2 +7 -0 src/sys/contrib/altq/altq/if_altq.h From owner-cvs-src@FreeBSD.ORG Sat Jun 12 19:54:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A45C916A4D1; Sat, 12 Jun 2004 19:54:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86A8743D2F; Sat, 12 Jun 2004 19:54:33 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CJr9ew081119; Sat, 12 Jun 2004 19:53:09 GMT (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CJr8h8081118; Sat, 12 Jun 2004 19:53:08 GMT (envelope-from gad) Message-Id: <200406121953.i5CJr8h8081118@repoman.freebsd.org> From: Garance A Drosehn Date: Sat, 12 Jun 2004 19:53:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 19:54:33 -0000 gad 2004-06-12 19:53:08 UTC FreeBSD src repository Modified files: usr.sbin/newsyslog newsyslog.c Log: Switch to using the "neworder" for rotating log files, by default. The main advantage of this is that daemon's are only signalled once per run, instead of once for each file that is rotated. MFC after: 2 weeks Revision Changes Path 1.93 +9 -1 src/usr.sbin/newsyslog/newsyslog.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 20:02:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE44416A4CE; Sat, 12 Jun 2004 20:02:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A130143D39; Sat, 12 Jun 2004 20:02:36 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CK1mCM082276; Sat, 12 Jun 2004 20:01:48 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CK1mn3082272; Sat, 12 Jun 2004 20:01:48 GMT (envelope-from alc) Message-Id: <200406122001.i5CK1mn3082272@repoman.freebsd.org> From: Alan Cox Date: Sat, 12 Jun 2004 20:01:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 20:02:36 -0000 alc 2004-06-12 20:01:48 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: In a multiprocessor, the PG_W bit in the pte must be changed atomically. Otherwise, the setting of the PG_M bit by one processor could be lost if another processor is simultaneously changing the PG_W bit. Reviewed by: tegge@ Revision Changes Path 1.467 +2 -2 src/sys/amd64/amd64/pmap.c 1.468 +2 -1 src/sys/i386/i386/pmap.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 20:47:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5181D16A4CE; Sat, 12 Jun 2004 20:47:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 337BA43D55; Sat, 12 Jun 2004 20:47:50 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CKlW1S099014; Sat, 12 Jun 2004 20:47:32 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CKlWin099013; Sat, 12 Jun 2004 20:47:32 GMT (envelope-from rwatson) Message-Id: <200406122047.i5CKlWin099013@repoman.freebsd.org> From: Robert Watson Date: Sat, 12 Jun 2004 20:47:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_descrip.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c src/sys/netatm atm_socket.c src/sys/netatalk ddp_pcb.c... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 20:47:50 -0000 rwatson 2004-06-12 20:47:32 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c sys/net raw_cb.c raw_usrreq.c sys/netatm atm_socket.c sys/netatalk ddp_pcb.c sys/netgraph ng_ksocket.c sys/netgraph/bluetooth/socket ng_btsocket_hci_raw.c ng_btsocket_l2cap.c ng_btsocket_l2cap_raw.c ng_btsocket_rfcomm.c sys/netinet in_pcb.c tcp_subr.c sys/netipx ipx_pcb.c ipx_usrreq.c sys/netnatm natm.c sys/sys socketvar.h Log: Extend coverage of SOCK_LOCK(so) to include so_count, the socket reference count: - Assert SOCK_LOCK(so) macros that directly manipulate so_count: soref(), sorele(). - Assert SOCK_LOCK(so) in macros/functions that rely on the state of so_count: sofree(), sotryfree(). - Acquire SOCK_LOCK(so) before calling these functions or macros in various contexts in the stack, both at the socket and protocol layers. - In some cases, perform soisdisconnected() before sotryfree(), as this could result in frobbing of a non-present socket if sotryfree() actually frees the socket. - Note that sofree()/sotryfree() will release the socket lock even if they don't free the socket. Submitted by: sam Sponsored by: FreeBSD Foundation Obtained from: BSD/OS Revision Changes Path 1.233 +3 -0 src/sys/kern/kern_descrip.c 1.177 +10 -1 src/sys/kern/uipc_socket.c 1.190 +7 -0 src/sys/kern/uipc_syscalls.c 1.123 +1 -0 src/sys/kern/uipc_usrreq.c 1.28 +3 -0 src/sys/net/raw_cb.c 1.33 +3 -1 src/sys/net/raw_usrreq.c 1.43 +1 -0 src/sys/netatalk/ddp_pcb.c 1.20 +1 -0 src/sys/netatm/atm_socket.c 1.15 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c 1.13 +2 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c 1.12 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap_raw.c 1.9 +3 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c 1.43 +2 -0 src/sys/netgraph/ng_ksocket.c 1.148 +1 -0 src/sys/netinet/in_pcb.c 1.190 +3 -2 src/sys/netinet/tcp_subr.c 1.28 +1 -0 src/sys/netipx/ipx_pcb.c 1.40 +2 -1 src/sys/netipx/ipx_usrreq.c 1.33 +2 -0 src/sys/netnatm/natm.c 1.119 +8 -1 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Sat Jun 12 21:00:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C47DC16A4CE; Sat, 12 Jun 2004 21:00:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE85043D45; Sat, 12 Jun 2004 21:00:30 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CKxnDg001540; Sat, 12 Jun 2004 20:59:49 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CKxmX0001539; Sat, 12 Jun 2004 20:59:48 GMT (envelope-from rwatson) Message-Id: <200406122059.i5CKxmX0001539@repoman.freebsd.org> From: Robert Watson Date: Sat, 12 Jun 2004 20:59:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet6 in6_pcb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 21:00:30 -0000 rwatson 2004-06-12 20:59:48 UTC FreeBSD src repository Modified files: sys/netinet6 in6_pcb.c Log: Missed directory in previous commit; need to hold SOCK_LOCK(so) before calling sotryfree(). -- Body of earlier bulk commit this belonged with -- Log: Extend coverage of SOCK_LOCK(so) to include so_count, the socket reference count: - Assert SOCK_LOCK(so) macros that directly manipulate so_count: soref(), sorele(). - Assert SOCK_LOCK(so) in macros/functions that rely on the state of so_count: sofree(), sotryfree(). - Acquire SOCK_LOCK(so) before calling these functions or macros in various contexts in the stack, both at the socket and protocol layers. - In some cases, perform soisdisconnected() before sotryfree(), as this could result in frobbing of a non-present socket if sotryfree() actually frees the socket. - Note that sofree()/sotryfree() will release the socket lock even if they don't free the socket. Submitted by: sam Sponsored by: FreeBSD Foundation Obtained from: BSD/OS Revision Changes Path 1.52 +1 -0 src/sys/netinet6/in6_pcb.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 21:02:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 342EF16A4CE; Sat, 12 Jun 2004 21:02:20 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE52443D1F; Sat, 12 Jun 2004 21:02:19 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i5CL0nEh096401; Sat, 12 Jun 2004 17:00:49 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i5CL0n63096398; Sat, 12 Jun 2004 17:00:49 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sat, 12 Jun 2004 17:00:48 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200406122047.i5CKlWin099013@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: cvs commit: src/sys/kern kern_descrip.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c src/sys/netatm atm_socket.c src/sys/netatalk ddp_pcb.c src/sys/netgraph ng_ksocket.c src/sys/netgraph/bluetooth/socket ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 21:02:20 -0000 On Sat, 12 Jun 2004, Robert Watson wrote: > - Note that sofree()/sotryfree() will release the socket lock even if > they don't free the socket. Colin and Bosko have pointed out that this note should also mention sorele(), which has similar properties. If the socket is still allocated when the macro returns, sorele() will release the lock on that socket. I'm not entirely happy with the assymetric locking here, but since these calls release references to the object, I think it makes some amount of sense. Right now, I opt to have the caller manage locking so that the impact of acquiring the socket lock is visible in the caller to discourage improper calling of these APIs. We might eventually want to push locking down into these APIs, but I don't think we want to do that yet. The assertions in the functions will occasionally force slightly stronger locking than needed -- for example, it forces locks to be held in soalloc() and sodealloc() that may not actually be needed. I'll revisit this once I've got the basic locking merged. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Sat Jun 12 21:17:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F72316A4CE; Sat, 12 Jun 2004 21:17:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7920D43D31; Sat, 12 Jun 2004 21:17:45 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CLGAlR006616; Sat, 12 Jun 2004 21:16:10 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CLGACG006615; Sat, 12 Jun 2004 21:16:10 GMT (envelope-from le) Message-Id: <200406122116.i5CLGACG006615@repoman.freebsd.org> From: Lukas Ertl Date: Sat, 12 Jun 2004 21:16:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/vinum geom_vinum.c geom_vinum.h geom_vinum_drive.c geom_vinum_init.c geom_vinum_list.c geom_vinum_plex.c geom_vinum_raid5.c geom_vinum_raid5.h geom_vinum_rm.c geom_vinum_share.c geom_vinum_share.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 21:17:45 -0000 le 2004-06-12 21:16:10 UTC FreeBSD src repository Added files: sys/geom/vinum geom_vinum.c geom_vinum.h geom_vinum_drive.c geom_vinum_init.c geom_vinum_list.c geom_vinum_plex.c geom_vinum_raid5.c geom_vinum_raid5.h geom_vinum_rm.c geom_vinum_share.c geom_vinum_share.h geom_vinum_state.c geom_vinum_subr.c geom_vinum_var.h geom_vinum_volume.c Log: Add a first version of a GEOMified vinum. Revision Changes Path 1.1 +569 -0 src/sys/geom/vinum/geom_vinum.c (new) 1.1 +79 -0 src/sys/geom/vinum/geom_vinum.h (new) 1.1 +476 -0 src/sys/geom/vinum/geom_vinum_drive.c (new) 1.1 +405 -0 src/sys/geom/vinum/geom_vinum_init.c (new) 1.1 +466 -0 src/sys/geom/vinum/geom_vinum_list.c (new) 1.1 +456 -0 src/sys/geom/vinum/geom_vinum_plex.c (new) 1.1 +616 -0 src/sys/geom/vinum/geom_vinum_raid5.c (new) 1.1 +93 -0 src/sys/geom/vinum/geom_vinum_raid5.h (new) 1.1 +346 -0 src/sys/geom/vinum/geom_vinum_rm.c (new) 1.1 +651 -0 src/sys/geom/vinum/geom_vinum_share.c (new) 1.1 +62 -0 src/sys/geom/vinum/geom_vinum_share.h (new) 1.1 +289 -0 src/sys/geom/vinum/geom_vinum_state.c (new) 1.1 +804 -0 src/sys/geom/vinum/geom_vinum_subr.c (new) 1.1 +279 -0 src/sys/geom/vinum/geom_vinum_var.h (new) 1.1 +260 -0 src/sys/geom/vinum/geom_vinum_volume.c (new) From owner-cvs-src@FreeBSD.ORG Sat Jun 12 21:19:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A5EE16A4CE; Sat, 12 Jun 2004 21:19:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BC7C43D45; Sat, 12 Jun 2004 21:19:30 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CLIeiF006701; Sat, 12 Jun 2004 21:18:40 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CLIe5X006700; Sat, 12 Jun 2004 21:18:40 GMT (envelope-from le) Message-Id: <200406122118.i5CLIe5X006700@repoman.freebsd.org> From: Lukas Ertl Date: Sat, 12 Jun 2004 21:18:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules/geom/geom_vinum Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 21:19:30 -0000 le 2004-06-12 21:18:40 UTC FreeBSD src repository Added files: sys/modules/geom/geom_vinum Makefile Log: Add a module directory for geom_vinum. Revision Changes Path 1.1 +11 -0 src/sys/modules/geom/geom_vinum/Makefile (new) From owner-cvs-src@FreeBSD.ORG Sat Jun 12 21:23:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0783B16A4CE; Sat, 12 Jun 2004 21:23:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF88B43D53; Sat, 12 Jun 2004 21:23:41 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CLMldY008625; Sat, 12 Jun 2004 21:22:47 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CLMlLC008624; Sat, 12 Jun 2004 21:22:47 GMT (envelope-from le) Message-Id: <200406122122.i5CLMlLC008624@repoman.freebsd.org> From: Lukas Ertl Date: Sat, 12 Jun 2004 21:22:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/gvinum Makefile gvinum.c gvinum.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 21:23:42 -0000 le 2004-06-12 21:22:47 UTC FreeBSD src repository Added files: sbin/gvinum Makefile gvinum.c gvinum.h Log: Add gvinum, the geom_vinum userland tool. Revision Changes Path 1.1 +14 -0 src/sbin/gvinum/Makefile (new) 1.1 +758 -0 src/sbin/gvinum/gvinum.c (new) 1.1 +39 -0 src/sbin/gvinum/gvinum.h (new) From owner-cvs-src@FreeBSD.ORG Sat Jun 12 21:43:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 565F516A4CE; Sat, 12 Jun 2004 21:43:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3898E43D31; Sat, 12 Jun 2004 21:43:27 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CLffJ7012181; Sat, 12 Jun 2004 21:41:41 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CLffKk012180; Sat, 12 Jun 2004 21:41:41 GMT (envelope-from cperciva) Message-Id: <200406122141.i5CLffKk012180@repoman.freebsd.org> From: Colin Percival Date: Sat, 12 Jun 2004 21:41:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 bge.4 cue.4 dc.4 gx.4 kue.4 lge.4 nge.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 21:43:27 -0000 cperciva 2004-06-12 21:41:41 UTC FreeBSD src repository Modified files: share/man/man4 bge.4 cue.4 dc.4 gx.4 kue.4 lge.4 nge.4 Log: s/mbps/Mbps/ We don't support any 10 millibit-per-second network cards. PR: docs/67719 Submitted by: Linh Pham MFC after: 1 week Revision Changes Path 1.12 +1 -1 src/share/man/man4/bge.4 1.18 +1 -1 src/share/man/man4/cue.4 1.26 +1 -1 src/share/man/man4/dc.4 1.6 +2 -2 src/share/man/man4/gx.4 1.18 +1 -1 src/share/man/man4/kue.4 1.7 +1 -1 src/share/man/man4/lge.4 1.13 +2 -2 src/share/man/man4/nge.4 From owner-cvs-src@FreeBSD.ORG Sat Jun 12 22:10:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD51316A4CE; Sat, 12 Jun 2004 22:10:29 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A096643D39; Sat, 12 Jun 2004 22:10:29 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CM9ZIA018483; Sat, 12 Jun 2004 22:09:35 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CM9ZmV018482; Sat, 12 Jun 2004 22:09:35 GMT (envelope-from rwatson) Message-Id: <200406122209.i5CM9ZmV018482@repoman.freebsd.org> From: Robert Watson Date: Sat, 12 Jun 2004 22:09:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 22:10:29 -0000 rwatson 2004-06-12 22:09:35 UTC FreeBSD src repository Modified files: sys/sys socketvar.h Log: Move #ifdef _KERNEL higher in socketvar.h to cover various socket buffer related macros. Revision Changes Path 1.120 +2 -2 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Sat Jun 12 22:49:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D144D16A4CE; Sat, 12 Jun 2004 22:49:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3C9C43D2D; Sat, 12 Jun 2004 22:49:33 +0000 (GMT) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CMn7pQ027000; Sat, 12 Jun 2004 22:49:07 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CMn7r8026999; Sat, 12 Jun 2004 22:49:07 GMT (envelope-from dwmalone) Message-Id: <200406122249.i5CMn7r8026999@repoman.freebsd.org> From: David Malone Date: Sat, 12 Jun 2004 22:49:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin Makefile src/usr.bin/truss amd64-fbsd.c extern.h main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 22:49:34 -0000 dwmalone 2004-06-12 22:49:07 UTC FreeBSD src repository Modified files: usr.bin Makefile usr.bin/truss extern.h main.c Added files: usr.bin/truss amd64-fbsd.c Log: A first stab at truss support for amd64, basically cogged from i386. It seems to work in my limited tests. Revision Changes Path 1.265 +1 -1 src/usr.bin/Makefile 1.1 +345 -0 src/usr.bin/truss/amd64-fbsd.c (new) 1.8 +4 -0 src/usr.bin/truss/extern.h 1.37 +3 -0 src/usr.bin/truss/main.c From owner-cvs-src@FreeBSD.ORG Sat Jun 12 23:37:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6DD4E16A4CE; Sat, 12 Jun 2004 23:37:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 511BF43D1F; Sat, 12 Jun 2004 23:37:08 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5CNax9s038160; Sat, 12 Jun 2004 23:36:59 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5CNaxAj038159; Sat, 12 Jun 2004 23:36:59 GMT (envelope-from rwatson) Message-Id: <200406122336.i5CNaxAj038159@repoman.freebsd.org> From: Robert Watson Date: Sat, 12 Jun 2004 23:36:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 23:37:08 -0000 rwatson 2004-06-12 23:36:59 UTC FreeBSD src repository Modified files: sys/kern uipc_syscalls.c Log: Correct whitespace errors in merge from rwatson_netperf: tabs instead of spaces, no trailing tab at the end of line. Pointed out by: csjp Revision Changes Path 1.191 +5 -5 src/sys/kern/uipc_syscalls.c