From owner-freebsd-bugbusters@FreeBSD.ORG  Wed Sep 29 21:07:42 2004
Return-Path: <owner-freebsd-bugbusters@FreeBSD.ORG>
Delivered-To: freebsd-bugbusters@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 69E6816A4CE
	for <bugbusters@freebsd.org>; Wed, 29 Sep 2004 21:07:42 +0000 (GMT)
Received: from imo-d02.mx.aol.com (imo-d02.mx.aol.com [205.188.157.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 02B5643D54
	for <bugbusters@freebsd.org>; Wed, 29 Sep 2004 21:07:42 +0000 (GMT)
	(envelope-from mgooderum@netscape.net)
Received: from mgooderum@netscape.net
	by imo-d02.mx.aol.com (mail_out_v37_r3.7.) id n.1c.ebcb9a8 (16238)
	 for <bugbusters@freebsd.org>; Wed, 29 Sep 2004 17:07:39 -0400 (EDT)
Received: from  netscape.net (rrcs-67-52-60-146.west.biz.rr.com
	[67.52.60.146]) by air-in03.mx.aol.com (v101_r1.4) with ESMTP id
	MAILININ32-3f6e415b241a123; Wed, 29 Sep 2004 17:07:39 -0400
Message-ID: <415B241A.4030509@netscape.net>
Date: Wed, 29 Sep 2004 16:07:38 -0500
From: Mark Gooderum <mgooderum@netscape.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i386; en-US;
	rv:1.4) Gecko/20030624 Netscape/7.1
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: bugbusters@FreeBSD.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-AOL-IP: 67.52.60.146
X-Mailer: Unknown (No Version)
Subject: FreeBSD PR
X-BeenThere: freebsd-bugbusters@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Coordination of the Problem Report handling effort.
	<freebsd-bugbusters.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugbusters>,
	<mailto:freebsd-bugbusters-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugbusters>
List-Post: <mailto:freebsd-bugbusters@freebsd.org>
List-Help: <mailto:freebsd-bugbusters-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugbusters>,
	<mailto:freebsd-bugbusters-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Sep 2004 21:07:42 -0000

Just filed a PR with the subject:

    "em driver em_poll doesn't start send if pending packets"

the subject should be:

    "em driver em_intr doesn't start send if pending packets"

I believe this may be the problem (and fix) to the if_em problems noted 
in the 5.3 TODO list.  The following patch to em_intr() has fixed the 
problem for us.  We basically would see an em interface hang after 5-10 
minutes of throughput testing GigE-GigE with an Ixia.
-=-
Mark

--- /tmp/tmp.44554.0    Wed Sep 29 15:52:32 2004
+++ 
/data/work/mark/5.3B4A1.i386/usr/build/ambit2/freebsd5/sys/dev/em/if_em.c   
Wed Sep 29 15:51:31 2004
@@ -986,11 +986,11 @@
                         em_clean_transmit_interrupts(adapter);
                 }
                 loop_cnt--;
         }

-        if (ifp->if_flags & IFF_RUNNING && IFQ_DRV_IS_EMPTY(&ifp->if_snd))
+        if (ifp->if_flags & IFF_RUNNING && !IFQ_DRV_IS_EMPTY(&ifp->if_snd))
                 em_start_locked(ifp);

        EM_UNLOCK(adapter);
         return;
 }