From owner-freebsd-cvsweb@FreeBSD.ORG Sun Jan 4 19:43:12 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2020016A4CE; Sun, 4 Jan 2004 19:43:12 -0800 (PST) Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE07343D48; Sun, 4 Jan 2004 19:43:05 -0800 (PST) (envelope-from bryce1@obviously.com) Received: from obviously.com (h0010a4e2603c.ne.client2.attbi.com[24.61.43.4]) by comcast.net (sccrmhc13) with SMTP id <20040105034302016008up6ke>; Mon, 5 Jan 2004 03:43:02 +0000 Message-ID: <3FF8DD46.5090501@obviously.com> Date: Sun, 04 Jan 2004 22:43:02 -0500 From: "Bryce Nesbitt (mailing list account)" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en-us, es, en, de, he MIME-Version: 1.0 To: =?ISO-8859-1?Q?Ville_Skytt=E4?= , freebsd-cvsweb@freebsd.org References: <3FB23C1F.6040502@obviously.com> <1068661352.4763.72.camel@bobcat.mine.nu> <3FB28082.6070707@obviously.com> <1068671035.4763.136.camel@bobcat.mine.nu> <3FBCEA3F.4050106@obviously.com> <1069350659.2439.274.camel@bobcat.mine.nu> <3FD3547A.5010400@obviously.com> <1070867585.11239.52.camel@bobcat.mine.nu> <3FDF6F74.4070307@obviously.com> <1071618494.6993.81.camel@bobcat.mine.nu> <3FEB7626.2030606@obviously.com> <1072528568.7528.127.camel@bobcat.mine.nu> <3FEF5E93.8020600@obviously.com> <1073247519.9121.183.camel@bobcat.mine.nu> In-Reply-To: <1073247519.9121.183.camel@bobcat.mine.nu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: Patch to cvsweb? X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2004 03:43:12 -0000 I agree that using CVS's "b" (binary) flag is a good hint. But why hard code the response? For each combination of binary flag and mime type, I might want select allowable diff and download types independently: Diff as: text colored side-by-side shape_diff.exe (external) exell_diff.exe (external) Download as: Native mime type (e.g. "application/msword") As text The default could be to enable everything except the external diff utilities. -Bryce Ville Skyttä wrote: >All true. Currently I'm thinking about using CVS's keyword expansion >mode to "detect" whether a file is a text file in the first place (if >possible everywhere, haven't checked yet). If a file is checked in >using the "b" (binary) mode, we treat it as binary and will not offer >HTMLized view of it, or a regular diff. On the other hand, if it does >not have the "b" flag set, we'll show the "(download as text)" link if >the resolved MIME type is not "text/*", ditto show many diff >links/options including a "regular diff" link if the file has dedicated >diff tool(s) but is a text file etc etc, lots of work to do. > >>Bryce wrote: >>The issue is complex. For an XML file I might want the choice to diff >>it as a text file, OR >>use a generic XML diff utility, OR using a specilized utility that >>understands the content. >>As a system administrator I might want to prohibit diffing some files >>as text, because I know >>the results will be nonsense. >> >> > >