From owner-freebsd-geom@FreeBSD.ORG Mon Feb 9 14:04:11 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0027016A4CE for ; Mon, 9 Feb 2004 14:04:10 -0800 (PST) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 388DB43D1D for ; Mon, 9 Feb 2004 14:04:10 -0800 (PST) (envelope-from sebastian.ssmoller@gmx.net) Received: (qmail 26379 invoked by uid 65534); 9 Feb 2004 22:04:09 -0000 Received: from pD9E83432.dip.t-dialin.net (HELO tyrael.linnet) (217.232.52.50) by mail.gmx.net (mp014) with SMTP; 09 Feb 2004 23:04:09 +0100 X-Authenticated: #15005775 Date: Mon, 9 Feb 2004 23:05:07 +0100 From: sebastian ssmoller To: geom@freebsd.org Message-Id: <20040209230507.72db93c8.sebastian.ssmoller@gmx.net> Organization: X-Mailer: Sylpheed version 0.9.8a-gtk2-20040109 (GTK+ 2.2.4; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: stripe and mirror on the same disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2004 22:04:11 -0000 hi, currently i use vinum (on 5.2R) for my stripe/mirror setup. i have two 40gb disks. my /usr /home /var and /tmp partitions are "striped" and my backup/cvs partition (/mnt/mirror) is "mirrored". i have only read some doc about geom and i wonder if this setup would be possible with it ? geom_stripe, geom_concat (and possible geom_mirror) are based on disks (not slices) as far as i understand ? if so, how could i use both geom classes / tools for the same physical disks ? how does geom_vinum fit into this situation ? i have not found much doc about the whole stuff - is there any ? Any hints would be appreciated ... regards, seb -- Microsoft: Where do you want to go today? Linux: Where do you want to go tomorrow? FreeBSD: Are you guys coming or what? OpenBSD: Hey guys you left some holes out there! From owner-freebsd-geom@FreeBSD.ORG Mon Feb 9 14:31:28 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7890716A4CE for ; Mon, 9 Feb 2004 14:31:28 -0800 (PST) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id E6D0943D1D for ; Mon, 9 Feb 2004 14:31:27 -0800 (PST) (envelope-from l.ertl@univie.ac.at) Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11]) i19MVLF51243170; Mon, 9 Feb 2004 23:31:22 +0100 Date: Mon, 9 Feb 2004 23:31:16 +0100 (CET) From: Lukas Ertl To: sebastian ssmoller In-Reply-To: <20040209230507.72db93c8.sebastian.ssmoller@gmx.net> Message-ID: <20040209232840.J644@korben.in.tern> References: <20040209230507.72db93c8.sebastian.ssmoller@gmx.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: mailbox 4251; Body=2 Fuz1=2 Fuz2=2 cc: geom@freebsd.org Subject: Re: stripe and mirror on the same disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2004 22:31:28 -0000 On Mon, 9 Feb 2004, sebastian ssmoller wrote: > i have only read some doc about geom and i wonder if this setup would be > possible with it ? > geom_stripe, geom_concat (and possible geom_mirror) are based on disks > (not slices) as far as i understand ? if so, how could i use both > geom classes / tools for the same physical disks ? If your are using GEOM you can stack the modules as you like. geom_mirror doesn't care if the provider below is an MBR slice or a BSD partition. So, you can partition the disk and then mirror the results, or you mirror the disks and then partition as you like it. > how does geom_vinum fit into this situation ? I plan to have geom_vinum as a true drop-in replacement, so any combination of current vinum volumes should be supported, too. regards, le -- Lukas Ertl eMail: l.ertl@univie.ac.at UNIX Systemadministrator Tel.: (+43 1) 4277-14073 Vienna University Computer Center Fax.: (+43 1) 4277-9140 University of Vienna http://mailbox.univie.ac.at/~le/ From owner-freebsd-geom@FreeBSD.ORG Mon Feb 9 16:19:04 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0619B16A4CE for ; Mon, 9 Feb 2004 16:19:04 -0800 (PST) Received: from praetor.linc-it.com (adsl-068-157-070-217.sip.jan.bellsouth.net [68.157.70.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id D419943D1D for ; Mon, 9 Feb 2004 16:19:03 -0800 (PST) (envelope-from fullermd@over-yonder.net) Received: from mortis.over-yonder.net (adsl-81-244-89.jan.bellsouth.net [65.81.244.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by praetor.linc-it.com (Postfix) with ESMTP id A6B00155E0; Mon, 9 Feb 2004 18:19:02 -0600 (CST) Received: by mortis.over-yonder.net (Postfix, from userid 100) id E27CA20F95; Mon, 9 Feb 2004 18:19:00 -0600 (CST) Date: Mon, 9 Feb 2004 18:19:00 -0600 From: "Matthew D. Fuller" To: Lukas Ertl Message-ID: <20040210001900.GF89781@over-yonder.net> References: <20040209230507.72db93c8.sebastian.ssmoller@gmx.net> <20040209232840.J644@korben.in.tern> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040209232840.J644@korben.in.tern> User-Agent: Mutt/1.4.1i-fullermd.1 X-Editor: vi X-OS: FreeBSD cc: geom@freebsd.org cc: sebastian ssmoller Subject: Re: stripe and mirror on the same disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2004 00:19:04 -0000 On Mon, Feb 09, 2004 at 11:31:16PM +0100 I heard the voice of Lukas Ertl, and lo! it spake thus: > On Mon, 9 Feb 2004, sebastian ssmoller wrote: > > > how does geom_vinum fit into this situation ? > > I plan to have geom_vinum as a true drop-in replacement, so any > combination of current vinum volumes should be supported, too. OK, this has been on my mind for a bit here; how drop-in is drop-in? If I setup a box with Vinum now, will those filesystems be able to just slide into being geom_vinum'd later on, or will it have to be moved off elsewhere and the filesystem remade? -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ "The only reason I'm burning my candle at both ends, is because I haven't figured out how to light the middle yet" From owner-freebsd-geom@FreeBSD.ORG Mon Feb 9 16:26:03 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D52016A4CE for ; Mon, 9 Feb 2004 16:26:03 -0800 (PST) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE16443D1D for ; Mon, 9 Feb 2004 16:26:02 -0800 (PST) (envelope-from l.ertl@univie.ac.at) Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11]) i1A0PsOx1237184; Tue, 10 Feb 2004 01:25:56 +0100 Date: Tue, 10 Feb 2004 01:25:49 +0100 (CET) From: Lukas Ertl To: "Matthew D. Fuller" In-Reply-To: <20040210001900.GF89781@over-yonder.net> Message-ID: <20040210012240.L619@korben.in.tern> References: <20040209230507.72db93c8.sebastian.ssmoller@gmx.net> <20040209232840.J644@korben.in.tern> <20040210001900.GF89781@over-yonder.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: mailbox 4243; Body=0 Fuz1=0 Fuz2=0 cc: geom@freebsd.org cc: sebastian ssmoller Subject: Re: stripe and mirror on the same disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2004 00:26:03 -0000 On Mon, 9 Feb 2004, Matthew D. Fuller wrote: > On Mon, Feb 09, 2004 at 11:31:16PM +0100 I heard the voice of > Lukas Ertl, and lo! it spake thus: > > On Mon, 9 Feb 2004, sebastian ssmoller wrote: > > > > > how does geom_vinum fit into this situation ? > > > > I plan to have geom_vinum as a true drop-in replacement, so any > > combination of current vinum volumes should be supported, too. > > OK, this has been on my mind for a bit here; how drop-in is drop-in? > If I setup a box with Vinum now, will those filesystems be able to > just slide into being geom_vinum'd later on, or will it have to be > moved off elsewhere and the filesystem remade? I'd like to be able to just load geom_vinum and have the old vinum config available. Of course I can't promise yet that this will actually happen, but IMHO that's the only way to make this transition properly. regards, le -- Lukas Ertl eMail: l.ertl@univie.ac.at UNIX Systemadministrator Tel.: (+43 1) 4277-14073 Vienna University Computer Center Fax.: (+43 1) 4277-9140 University of Vienna http://mailbox.univie.ac.at/~le/ From owner-freebsd-geom@FreeBSD.ORG Tue Feb 10 07:49:51 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F69C16A4CE for ; Tue, 10 Feb 2004 07:49:51 -0800 (PST) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B68943D2F for ; Tue, 10 Feb 2004 07:49:51 -0800 (PST) (envelope-from l.ertl@univie.ac.at) Received: from pcle2.cc.univie.ac.at (pcle2.cc.univie.ac.at [131.130.2.177]) i1AFncdr1229352; Tue, 10 Feb 2004 16:49:40 +0100 Date: Tue, 10 Feb 2004 16:49:38 +0100 (CET) From: Lukas Ertl To: Paul Mather In-Reply-To: <20040210152729.GA83171@gromit.dlib.vt.edu> Message-ID: <20040210164827.O40769@pcle2.cc.univie.ac.at> References: <20040209230507.72db93c8.sebastian.ssmoller@gmx.net> <20040210001900.GF89781@over-yonder.net> <20040210152729.GA83171@gromit.dlib.vt.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: imap 4244; Body=0 Fuz1=0 Fuz2=0 cc: geom@freebsd.org cc: "Matthew D. Fuller" cc: sebastian ssmoller Subject: Re: stripe and mirror on the same disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2004 15:49:51 -0000 On Tue, 10 Feb 2004, Paul Mather wrote: > Does "drop-in" extend to having swap on Vinum working again? Yes. > Is geom_vinum strictly a -CURRENT thing, or is there a chance of it > appearing in a 5.x-RELEASE any time soon? Well, right now it isn't even a -CURRENT thing :-) I can't promise that it really makes it into 5.3-RELEASE, but I hope I find enough time until then. regards, le -- Lukas Ertl eMail: l.ertl@univie.ac.at UNIX Systemadministrator Tel.: (+43 1) 4277-14073 Vienna University Computer Center Fax.: (+43 1) 4277-9140 University of Vienna http://mailbox.univie.ac.at/~le/ From owner-freebsd-geom@FreeBSD.ORG Wed Feb 11 14:55:00 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDDBC16A4CE for ; Wed, 11 Feb 2004 14:55:00 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2CB6C43D1D for ; Wed, 11 Feb 2004 14:55:00 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id i1BMswMW019508 for ; Wed, 11 Feb 2004 23:54:58 +0100 (CET) (envelope-from phk@phk.freebsd.dk) To: geom@freebsd.org From: Poul-Henning Kamp Date: Wed, 11 Feb 2004 23:54:58 +0100 Message-ID: <19507.1076540098@critter.freebsd.dk> Subject: Project idea: disk-activity visualization X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2004 22:55:00 -0000 If somebody here is looking for a project I would like to add something like this to GEOM: http://www.itworld.com/Comp/3380/UIR990101perf/ It would be a flag you set on the consumer(s) or provider(s) you were interested in monitoring, and then a number of pages of RAM would be mapped from kernel to userland with an array of counters which increment on access. The kernel bit is rather trivial, the tough part is presenting and visualizing this in a sane way. Any takers ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-freebsd-geom@FreeBSD.ORG Thu Feb 12 00:38:23 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C5BC016A4CE for ; Thu, 12 Feb 2004 00:38:23 -0800 (PST) Received: from milla.ask33.net (milla.ask33.net [217.197.166.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 701E543D31 for ; Thu, 12 Feb 2004 00:38:23 -0800 (PST) (envelope-from nick@milla.ask33.net) Received: by milla.ask33.net (Postfix, from userid 1001) id 654613ABB80; Thu, 12 Feb 2004 09:41:04 +0100 (CET) Date: Thu, 12 Feb 2004 09:41:04 +0100 From: Pawel Jakub Dawidek To: Poul-Henning Kamp Message-ID: <20040212084104.GP14639@garage.freebsd.pl> References: <19507.1076540098@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SKuKPt3hQSBflurX" Content-Disposition: inline In-Reply-To: <19507.1076540098@critter.freebsd.dk> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 4.8-RELEASE-p13 i386 X-URL: http://garage.freebsd.pl User-Agent: Mutt/1.5.1i cc: geom@freebsd.org Subject: Re: Project idea: disk-activity visualization X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2004 08:38:23 -0000 --SKuKPt3hQSBflurX Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 11, 2004 at 11:54:58PM +0100, Poul-Henning Kamp wrote: +> If somebody here is looking for a project I would like to add something +> like this to GEOM: +>=20 +> http://www.itworld.com/Comp/3380/UIR990101perf/ +>=20 +> It would be a flag you set on the consumer(s) or provider(s) you +> were interested in monitoring, and then a number of pages of RAM +> would be mapped from kernel to userland with an array of counters +> which increment on access. +>=20 +> The kernel bit is rather trivial, the tough part is presenting and +> visualizing this in a sane way. I'm not sure if extending infrastructure in this direction is a good idea. This will be very easy to implement with insert/delete stuff (and so many other neat things). If you have this ready, plase give me for tests, if not, I can start its implementation. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --SKuKPt3hQSBflurX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQFAKzwfForvXbEpPzQRAjMUAKDGp8XqOmzKnV28eKrWhmSGWPpesQCeJR5r 1RF3j5j3IeuFUHyO9wkfKg0= =JVif -----END PGP SIGNATURE----- --SKuKPt3hQSBflurX-- From owner-freebsd-geom@FreeBSD.ORG Thu Feb 12 01:15:53 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1621E16A4CE; Thu, 12 Feb 2004 01:15:53 -0800 (PST) Received: from pasmtp.tele.dk (pasmtp.tele.dk [193.162.159.95]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD44343D1D; Thu, 12 Feb 2004 01:15:52 -0800 (PST) (envelope-from xride@x12.dk) Received: from x12.dk (xforce.dk [80.164.11.218]) by pasmtp.tele.dk (Postfix) with ESMTP id 392211EC3F0; Thu, 12 Feb 2004 10:15:51 +0100 (CET) Received: by x12.dk (Postfix, from userid 666) id DEAF267; Thu, 12 Feb 2004 10:15:50 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by x12.dk (Postfix) with ESMTP id CDF3763; Thu, 12 Feb 2004 10:15:50 +0100 (CET) Date: Thu, 12 Feb 2004 10:15:50 +0100 (CET) From: Soeren Straarup To: Pawel Jakub Dawidek In-Reply-To: <20040212084104.GP14639@garage.freebsd.pl> Message-ID: <20040212101223.X90753-100000@x12.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE cc: geom@freebsd.org cc: Poul-Henning Kamp Subject: Re: Project idea: disk-activity visualization X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2004 09:15:53 -0000 On Thu, 12 Feb 2004, Pawel Jakub Dawidek wrote: > On Wed, Feb 11, 2004 at 11:54:58PM +0100, Poul-Henning Kamp wrote: > +> If somebody here is looking for a project I would like to add somethin= g > +> like this to GEOM: > +> > +> =09http://www.itworld.com/Comp/3380/UIR990101perf/ > +> > +> It would be a flag you set on the consumer(s) or provider(s) you > +> were interested in monitoring, and then a number of pages of RAM > +> would be mapped from kernel to userland with an array of counters > +> which increment on access. > +> > +> The kernel bit is rather trivial, the tough part is presenting and > +> visualizing this in a sane way. > > I'm not sure if extending infrastructure in this direction is a good idea= =2E > This will be very easy to implement with insert/delete stuff (and so many > other neat things). > > If you have this ready, plase give me for tests, if not, I can start its > implementation. > > -- > Pawel Jakub Dawidek http://www.FreeBSD.org > pjd@FreeBSD.org http://garage.freebsd.pl > FreeBSD committer Am I Evil? Yes, I Am! > I have begun in the small to implement a userland GUI for geom So far it can only display the sysctl output of confdot, but the idea is that it should be able to display what something like this: sysctl -b kern.geom.confdot | dot -Tps - && gv - Just in realtime or close to. In version 42 it should be able to configure geom to, by entering data in the gui. Best regards S=F8ren Soeren Straarup | aka OZ2DAK aka Xride FreeBSD wannabe | FreeBSD since 2.2.6-R If you see the light at the end of the tunnel, then make sure it is not a train.. From owner-freebsd-geom@FreeBSD.ORG Thu Feb 12 01:48:27 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E8EE16A4CE; Thu, 12 Feb 2004 01:48:27 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73CA243D39; Thu, 12 Feb 2004 01:48:26 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id i1C9mOMW023013; Thu, 12 Feb 2004 10:48:24 +0100 (CET) (envelope-from phk@phk.freebsd.dk) To: Pawel Jakub Dawidek From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 12 Feb 2004 09:41:04 +0100." <20040212084104.GP14639@garage.freebsd.pl> Date: Thu, 12 Feb 2004 10:48:24 +0100 Message-ID: <23012.1076579304@critter.freebsd.dk> cc: geom@FreeBSD.org Subject: Re: Project idea: disk-activity visualization X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2004 09:48:27 -0000 In message <20040212084104.GP14639@garage.freebsd.pl>, Pawel Jakub Dawidek writ es: >I'm not sure if extending infrastructure in this direction is a good idea. >This will be very easy to implement with insert/delete stuff (and so many >other neat things). This would be an extension of the already existing devicestat stuff. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-freebsd-geom@FreeBSD.ORG Thu Feb 12 14:52:53 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9500916A4CE for ; Thu, 12 Feb 2004 14:52:53 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id E73E543D1D for ; Thu, 12 Feb 2004 14:52:52 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id i1CMqoMW029863 for ; Thu, 12 Feb 2004 23:52:50 +0100 (CET) (envelope-from phk@phk.freebsd.dk) To: geom@freebsd.org From: Poul-Henning Kamp Date: Thu, 12 Feb 2004 23:52:50 +0100 Message-ID: <29862.1076626370@critter.freebsd.dk> Subject: PATCH: never fail close requests X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2004 22:52:53 -0000 This patch adds a KASSERT in geom_subr.c which explodes if an access method returns an error to a request which have no positive access counts. In other words: it is _always_ legal to close and there is no need to check the error return for a g_access() call which has no positive counts for read, write or exclusive. I'll commit this in a couple of days, but wanted to give you guys a heads-up first so we can see if anything explodes on this. Thanks to Pawel for finding a few places where this was a problem. Poul-Henning Index: geom/geom_bsd.c =================================================================== RCS file: /home/ncvs/src/sys/geom/geom_bsd.c,v retrieving revision 1.67 diff -u -r1.67 geom_bsd.c --- geom/geom_bsd.c 12 Feb 2004 22:42:11 -0000 1.67 +++ geom/geom_bsd.c 12 Feb 2004 22:46:40 -0000 @@ -569,7 +569,7 @@ } while (0); /* Success or failure, we can close our provider now. */ - error = g_access(cp, -1, 0, 0); + g_access(cp, -1, 0, 0); /* If we have configured any providers, return the new geom. */ if (gsp->nprovider > 0) { Index: geom/geom_fox.c =================================================================== RCS file: /home/ncvs/src/sys/geom/geom_fox.c,v retrieving revision 1.5 diff -u -r1.5 geom_fox.c --- geom/geom_fox.c 12 Feb 2004 22:42:11 -0000 1.5 +++ geom/geom_fox.c 12 Feb 2004 22:47:54 -0000 @@ -90,8 +90,7 @@ cp1 = LIST_NEXT(sc->opath, consumer); - error = g_access(sc->opath, -sc->cr, -sc->cw, -(sc->ce + 1)); - KASSERT(error == 0, ("Failed close of old path %d", error)); + g_access(sc->opath, -sc->cr, -sc->cw, -(sc->ce + 1)); /* * The attempt to reopen it with a exclusive count Index: geom/geom_subr.c =================================================================== RCS file: /home/ncvs/src/sys/geom/geom_subr.c,v retrieving revision 1.70 diff -u -r1.70 geom_subr.c --- geom/geom_subr.c 12 Feb 2004 22:42:11 -0000 1.70 +++ geom/geom_subr.c 12 Feb 2004 22:49:41 -0000 @@ -627,6 +627,9 @@ /* Ok then... */ error = pp->geom->access(pp, dcr, dcw, dce); + KASSERT(dcr > 0 || dcw > 0 || dce > 0 || error == 0, + ("Geom provider %s::%s failed closeing ->access()", + pp->geom->class->name, pp->name)); if (!error) { /* * If we open first write, spoil any partner consumers. Index: geom/bde/g_bde.c =================================================================== RCS file: /home/ncvs/src/sys/geom/bde/g_bde.c,v retrieving revision 1.25 diff -u -r1.25 g_bde.c --- geom/bde/g_bde.c 12 Feb 2004 22:42:11 -0000 1.25 +++ geom/bde/g_bde.c 12 Feb 2004 22:49:15 -0000 @@ -226,7 +226,6 @@ { struct g_consumer *cp; struct g_provider *pp; - int error; struct g_bde_softc *sc; g_trace(G_T_TOPOLOGY, "g_bde_destroy_geom(%s, %s)", mp->name, gp->name); @@ -244,8 +243,7 @@ KASSERT(cp != NULL, ("NULL consumer")); sc->dead = 1; wakeup(sc); - error = g_access(cp, -1, -1, -1); - KASSERT(error == 0, ("error on close")); + g_access(cp, -1, -1, -1); g_detach(cp); g_destroy_consumer(cp); while (sc->dead != 2 && !LIST_EMPTY(&pp->consumers)) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.