From owner-freebsd-geom@FreeBSD.ORG Sun Sep 12 00:11:25 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D59A16A4CE; Sun, 12 Sep 2004 00:11:25 +0000 (GMT) Received: from kestrel.alerce.com (kestrel.alerce.com [209.182.219.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB18343D2D; Sun, 12 Sep 2004 00:11:24 +0000 (GMT) (envelope-from hartzell@kestrel.alerce.com) Received: from rosebud.alerce.com (w092.z064001164.sjc-ca.dsl.cnc.net [64.1.164.92]) (authenticated bits=128) by kestrel.alerce.com (8.12.10/8.12.10) with ESMTP id i8C0BNkk055034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 11 Sep 2004 17:11:24 -0700 (PDT) (envelope-from hartzell@kestrel.alerce.com) Received: from rosebud.alerce.com (localhost [127.0.0.1]) by rosebud.alerce.com (8.12.9p2/8.12.9) with ESMTP id i8C2C3pj000354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 11 Sep 2004 19:12:03 -0700 (PDT) (envelope-from hartzell@rosebud.alerce.com) Received: (from hartzell@localhost) by rosebud.alerce.com (8.12.9p2/8.12.9/Submit) id i8C2C2Vs000350; Sat, 11 Sep 2004 19:12:02 -0700 (PDT) (envelope-from hartzell) From: George Hartzell MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16707.45170.383349.686634@rosebud.alerce.com> Date: Sat, 11 Sep 2004 19:12:02 -0700 To: Paul Mather In-Reply-To: <1094946816.59283.75.camel@zappa.Chelsea-Ct.Org> References: <16706.33472.228042.851882@rosebud.alerce.com> <20040911074556.GI30151@darkness.comp.waw.pl> <16707.25008.865268.555842@rosebud.alerce.com> <16707.28763.7201.383177@rosebud.alerce.com> <1094946816.59283.75.camel@zappa.Chelsea-Ct.Org> X-Mailer: VM 7.14 under 21.4 (patch 14) "Reasonable Discussion" XEmacs Lucid X-Virus-Scanned: ClamAV version 'clamd / ClamAV version 0.65', clamav-milter version '0.60p' cc: Pawel Jakub Dawidek cc: freebsd-geom@freebsd.org Subject: Re: Mounting root... X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: hartzell@kestrel.alerce.com List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 00:11:25 -0000 Paul Mather writes: > [...] > This leaves the start_cmd the same, rather than using the swap1_start > function, because swap1_start checks a "no_swap" setting that doesn't > seem to be present on FreeBSD but is on NetBSD. (I don't know if a > missing setting defaults to "NO," making this moot.) Changing stop_cmd > to use the swap1_stop function makes turning off swap conditional on the > "swapoff" setting, instead of unconditional, in the case of setting > "stop_cmd='swapoff -a'". So, I think the above patch preserves the > current behaviour, unless you set 'swapoff="YES"' in /etc/rc.conf, in > which case all swap partitions will be unmounted during shutdown. I'm currently doing a buildworld w/ Pawel's patch, which unconditionally unmounts swap on shutdown and also adds some functionality to /etc/rc.d/addswap so that it also unmounts swap on shutdown. I am not in the flow of things enough to voice an opinion about whether it's "better" to preserve the existing behaviour or be straightforward. I suppose it might depend on whether this change is going to try to get into 5.3 or not.... With Paul's patch, you should also add a default value for swapoff in /etc/defaults/rc.conf, or one of the functions in /etc/rc.subr will whine about improper usage of the variable for all of the folks that aren't using it. g.