From owner-freebsd-i386@FreeBSD.ORG Sun Oct 17 19:40:31 2004 Return-Path: Delivered-To: freebsd-i386@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EA2816A4CE for ; Sun, 17 Oct 2004 19:40:31 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F81F43D49 for ; Sun, 17 Oct 2004 19:40:31 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HJeUpC023362 for ; Sun, 17 Oct 2004 19:40:31 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9HJeUJI023361; Sun, 17 Oct 2004 19:40:30 GMT (envelope-from gnats) Resent-Date: Sun, 17 Oct 2004 19:40:30 GMT Resent-Message-Id: <200410171940.i9HJeUJI023361@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-i386@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Frank Mayhar Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6F2D16A4CE for ; Sun, 17 Oct 2004 19:34:12 +0000 (GMT) Received: from tinker.exit.com (tinker.exit.com [206.223.0.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8A0343D46 for ; Sun, 17 Oct 2004 19:34:12 +0000 (GMT) (envelope-from frank@tinker.exit.com) Received: from tinker.exit.com (localhost [127.0.0.1]) by tinker.exit.com (8.13.1/8.12.9) with ESMTP id i9HJaZVR066596 for ; Sun, 17 Oct 2004 12:36:35 -0700 (PDT) (envelope-from frank@tinker.exit.com) Received: (from frank@localhost) by tinker.exit.com (8.13.1/8.13.1/Submit) id i9HJaU43066595; Sun, 17 Oct 2004 12:36:30 -0700 (PDT) (envelope-from frank) Message-Id: <200410171936.i9HJaU43066595@tinker.exit.com> Date: Sun, 17 Oct 2004 12:36:30 -0700 (PDT) From: Frank Mayhar To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: i386/72795: LOR between NDIS lock and route lock. X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Frank Mayhar List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 19:40:31 -0000 >Number: 72795 >Category: i386 >Synopsis: LOR between NDIS lock and route lock. >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-i386 >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 17 19:40:28 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Frank Mayhar >Release: FreeBSD 5.3-BETA7 i386 >Organization: Exit Consulting >Environment: System: FreeBSD lap 5.3-STABLE FreeBSD 5.3-STABLE #3: Sun Oct 17 12:02:39 PDT 2004 frank@lap:/home/obj/usr/src/sys/AUTON i386 This is the latest and greatest 5.3 on my Inspiron 5160. >Description: I'm using ndis to employ a Dell 1450 dual-band wireless card. Using the single-band card that came with the laptop this didn't happen, but when I began using the new one I started seeing near-constant panics. >How-To-Repeat: Load the system lightly, then do network stuff (a flood ping works perfectly). >Fix: It turns out that the first thing I checked appears to be the problem. ndis_start() has a single path that fails to drop the NDIS lock before it returns. I fixed that and the system has survived a flood ping for several minutes now. The diff is appended. NOTE: This should almost certainly get into 5.3-stable. It's a nasty. Index: if_ndis.c =================================================================== RCS file: /cvs/repos/src/sys/dev/if_ndis/if_ndis.c,v retrieving revision 1.69.2.1 diff -u -r1.69.2.1 if_ndis.c --- if_ndis.c 9 Oct 2004 15:20:18 -0000 1.69.2.1 +++ if_ndis.c 17 Oct 2004 18:58:52 -0000 @@ -1291,8 +1291,10 @@ break; } - if (pcnt == 0) + if (pcnt == 0) { + NDIS_UNLOCK(sc); return; + } if (sc->ndis_txpending == 0) ifp->if_flags |= IFF_OACTIVE; >Release-Note: >Audit-Trail: >Unformatted: