From owner-freebsd-qa@FreeBSD.ORG  Sun Mar  7 02:32:39 2004
Return-Path: <owner-freebsd-qa@FreeBSD.ORG>
Delivered-To: freebsd-qa@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ECC3D16A4CE; Sun,  7 Mar 2004 02:32:39 -0800 (PST)
Received: from huva.hittite.isp.9tel.net (huva.hittite.isp.9tel.net
	[62.62.156.28])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 318A143D31; Sun,  7 Mar 2004 02:32:38 -0800 (PST)
	(envelope-from cyrille.lefevre@laposte.net)
Received: from pc2k (unknown [81.185.192.104])
	by huva.hittite.isp.9tel.net (Postfix) with SMTP
	id A44CF9BB57; Sun,  7 Mar 2004 11:33:04 +0100 (CET)
Message-ID: <001f01c4042f$7feda030$7890a8c0@dyndns.org>
From: "Cyrille Lefevre" <cyrille.lefevre@laposte.net>
To: "Peter Pentchev" <roam@ringlet.net>
References: <20040304152809.GA66105@gits.dyndns.org>
	<20040304154621.GA747@straylight.m.ringlet.net>
Date: Sat, 6 Mar 2004 02:29:47 +0100
Organization: ACME
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1251"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1158
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
cc: bug-followup@FreeBSD.org
cc: freebsd-qa@FreeBSD.org
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation
	time
X-BeenThere: freebsd-qa@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD Quality Assurance <freebsd-qa.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-qa>
List-Post: <mailto:freebsd-qa@freebsd.org>
List-Help: <mailto:freebsd-qa-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Mar 2004 10:32:40 -0000

> On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
> > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET
2004)
> > anyone to commit this PR ?
> > thanks in advance.
> >
> [snip]
> >      /* Begin user dialog at outer menu */
> >      dialog_clear();
> > +    if (getpid() == 1)
> > +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max,
FALSE);
> >      while (1) {
>
> Just a minor comment: shouldn't RunningAsInit be used here instead of
> a getpid() invocation? :)

maybe, don't know in fact ?

Cyrille Lefevre.
-- 
home: mailto:cyrille.lefevre@laposte.net