From owner-freebsd-sparc64@FreeBSD.ORG Sun Sep 12 00:43:56 2004 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D23316A4CE for ; Sun, 12 Sep 2004 00:43:56 +0000 (GMT) Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id C617343D48 for ; Sun, 12 Sep 2004 00:43:55 +0000 (GMT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (localhost [127.0.0.1]) i8C0hr1a001287; Sun, 12 Sep 2004 02:43:53 +0200 (CEST) (envelope-from marius@newtrinity.zeist.de) Received: (from marius@localhost) by newtrinity.zeist.de (8.12.10/8.12.10/Submit) id i8C0hb3I001286; Sun, 12 Sep 2004 02:43:37 +0200 (CEST) (envelope-from marius) Date: Sun, 12 Sep 2004 02:43:37 +0200 From: Marius Strobl To: Dejan Lesjak Message-ID: <20040912024337.S69188@newtrinity.zeist.de> References: <200409101227.51303.dejan.lesjak@ijs.si> <20040911200059.R69188@newtrinity.zeist.de> <200409112116.44859.dejan.lesjak@ijs.si> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200409112116.44859.dejan.lesjak@ijs.si>; from dejan.lesjak@ijs.si on Sat, Sep 11, 2004 at 09:16:44PM +0200 X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.27.0.6; VDF 6.27.0.54 (host: newtrinity.zeist.de) cc: eta@lclark.edu cc: freebsd-sparc64@freebsd.org Subject: Re: xorg-server anyone? X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 00:43:56 -0000 On Sat, Sep 11, 2004 at 09:16:44PM +0200, Dejan Lesjak wrote: > On Saturday 11 of September 2004 20:00, Marius Strobl wrote: > > On Fri, Sep 10, 2004 at 12:27:51PM +0200, Dejan Lesjak wrote: > > > Does switching between those two result in any difference? > > > > No. With an unchanged xorg-server-6.7.0_7 Sun keyboards work with > > neither of the two keyboard drivers under FreeBSD. With my patch for > > f86Events.c the old one works but the new one still doesn't (sort of > > expected from the code). Ok, I now completely don't understand why > > the old driver did work in XFree, i.e. why the old patch for > > f86Events.c was sufficient. > > Ah, I see now. The check for __linux__ was added to checks for __sparc__ in > between xfree 4.3 and xfree 4.4/xorg 6.7. See > http://cvsweb.xfree86.org/cvsweb/xc/programs/Xserver/hw/xfree86/common/xf86Events.c.diff?r1=3.146%3Axf-4_3_0&tr1=1.1&r2=3.160%3Axf-4_4_0&tr2=3.163&diff_format=h > (apologies for the long line). > Yes, but this alone doesn't explain why 4.3 worked. What totally confused me was the piece of code that the old patch for f86Events.c put under a #ifndef __sparc64__ (revision 3.156 in XFree). I now see what I missed, in revision 3.147 this was moved inside the code that's skipped if the keyboard is a Sun keyboard (and in case the code that's now under the #if defined(__sparc__) && defined(__linux__) is compiled in). So my patch was right and additionally the #ifndef __sparc64__ added in 3.156 can be removed again. Thanks for your help! Marius