From owner-freebsd-threads@FreeBSD.ORG Sun Oct 31 04:23:26 2004 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B52316A4CF; Sun, 31 Oct 2004 04:23:26 +0000 (GMT) Received: from pimout3-ext.prodigy.net (pimout3-ext.prodigy.net [207.115.63.102]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A6D543D53; Sun, 31 Oct 2004 04:23:25 +0000 (GMT) (envelope-from julian@elischer.org) Received: from [192.168.1.102] (adsl-68-123-122-146.dsl.snfc21.pacbell.net [68.123.122.146])i9V4NJ5g410412; Sun, 31 Oct 2004 00:23:20 -0400 Message-ID: <418468B7.9060803@elischer.org> Date: Sat, 30 Oct 2004 21:23:19 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8a3) Gecko/20041017 X-Accept-Language: en, hu MIME-Version: 1.0 To: Scott Long References: <41817EE4.9080302@elischer.org> <41840FB3.2020305@freebsd.org> In-Reply-To: <41840FB3.2020305@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: Daniel Eischen cc: threads@freebsd.org cc: re@freebsd.org cc: David Xu cc: John Baldwin Subject: Re: MFC req for 5.x/5.3 X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 04:23:26 -0000 Scott Long wrote: > Julian Elischer wrote: > >> >> >> Daniel Eischen wrote: >> >>> On Thu, 28 Oct 2004, Julian Elischer wrote: >>> >>> >>> >>>> David Xu wrote: >>>> >>>> >>>> >>>>> Here is the cvs log: >>>>> >>>>> Revision Changes Path >>>>> 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c >>>>> 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c >>>>> 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c >>>>> 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h >>>>> 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c >>>>> >>>> >>>> >>>> commit message was: >>>> 1. Move thread list flags into new separate member, and atomically >>>> put DEAD thread on GC list, this closes a race between pthread_join >>>> and thr_cleanup. >>>> 2. Introduce a mutex to protect tcb initialization, tls allocation and >>>> deallocation code in rtld seems no lock protection or it is broken, >>>> under stress testing, memory is corrupted. >>>> >>>> >>>> translates to: >>>> >> >> [diff removed] >> >>>> >>> >>> >>> >>> Yes, these look right. >>> >>> >>> >> > > Julian and all, > > I know that re@ approved these a few days ago, but we haven't seen any > acticity and we need to get RC2 out so that SACK can get validated and > we can turn to -RELEASE. I know it's very short notice, but I'm going > to retract this MFC approval and instead ask that you only commit it to > RELENG_5. > > Scott I only ever had permission to go to RELENG_5.. Only got to do it today as Real Life(TM) got in the way.