From owner-freebsd-x11@FreeBSD.ORG Sun Jun 13 09:45:44 2004 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3DFCD16A4CE for ; Sun, 13 Jun 2004 09:45:44 +0000 (GMT) Received: from 21322530218.direct.eti.at (21322530218.direct.eti.at [213.225.30.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A2E843D2F for ; Sun, 13 Jun 2004 09:45:41 +0000 (GMT) (envelope-from tilman@arved.at) Received: from huckfinn-wi0.arved.de (localhost [127.0.0.1]) i5D9jKcH060360; Sun, 13 Jun 2004 11:45:20 +0200 (CEST) (envelope-from tilman@arved.at) Received: (from tilman@localhost) by huckfinn-wi0.arved.de (8.12.11/8.12.6/Submit) id i5D9jJPX060359; Sun, 13 Jun 2004 11:45:19 +0200 (CEST) X-Authentication-Warning: huckfinn-wi0.arved.de: tilman set sender to tilman@arved.at using -f Date: Sun, 13 Jun 2004 11:45:19 +0200 From: Tilman Linneweh To: Dejan Lesjak Message-ID: <20040613094519.GP65887@arved.at> References: <20040612090440.GN65887@arved.at> <200406130219.22820.dejan.lesjak@ijs.si> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406130219.22820.dejan.lesjak@ijs.si> User-Agent: Mutt/1.4.2.1i cc: x11@freebsd.org Subject: Re: [kris@obsecurity.org: Re: XFree86 4.4 update -- can somebody take care of it?] X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jun 2004 09:45:44 -0000 [ Added x11@ as this affects both ] * Dejan Lesjak [2004-06-13 02:50]: > > One likely problem is that XFree86-clients doesn't seem to build out > > of the box on 4.x - it has the same problem as the x.org server: > > > > LD_LIBRARY_PATH=/tmp/a/ports/x11/xorg-clients/work/xc/exports/lib > > XLOCALEDIR=/tmp/a/ports/x11/xorg-clients/work/xc/exports/lib/locale cc -O > > -pipe -ansi -pedantic -Dasm=__asm -Wall -Wpointer-arith -Wundef > > -I/tmp/a/ports/x11/xorg-clients/work/xc > > -I/tmp/a/ports/x11/xorg-clients/work/xc/exports/include > > -I/usr/X11R6/include -DCSRG_BASED -DFUNCPROTO=15 -DNARROWPROTO > > -DBINDIR=\"/usr/X11R6/bin\" -DXDMDIR=\"/usr/X11R6/lib/X11/xdm\" > > -DHASXDMAUTH -DSECURE_RPC -DUSE_PAM -DTCPCONN > > -DUNIXCONN -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN -DIPv6 > > -DGREET_USER_STATIC -DFRAGILE_DEV_MEM -DOSMAJORVERSION=4 > > -DOSMINORVERSION=10 -DHAS_SETUSERCONTEXT > > -DXPM -DUSE_XINERAMA -DHAS_SETPROCTITLE -DHAS_GETIFADDRS > > -UIPv6 -DHAS_MKSTEMP -DXVENDORNAME='"The X.Org Foundation"' > > -DXVENDORNAMESHORT='"X.Org"' -c session.c In file included from > > /usr/include/sys/types.h:45, > > from > > /tmp/a/ports/x11/xorg-clients/work/xc/exports/include/X11/Xos.h:60, from > > dm.h:44, > > from session.c:39: > > /usr/include/sys/cdefs.h:273: warning: `_POSIX_C_SOURCE' is not defined > > /usr/include/sys/cdefs.h:279: warning: `_POSIX_C_SOURCE' is not defined > > session.c:58: conflicting types for `key_setnet' > > /usr/include/rpc/auth.h:239: previous declaration of `key_setnet' > > session.c: In function `StartClient': > > session.c:536: warning: unused variable `pam_error' > > *** Error code 1 > > Thank you for the notice. No, unfortunately we didn't fix this. What follows > could be entirely wrong, but here goes: > Sun's rpc sources have changed in -current, notably rev. 1.16 of > src/include/rpc/auth.h and rev. 1.2 of src/usr.bin/keylogin/keylogin.c. The > part of xdm that fails here (xc/programs/xdm/session.c) is judging by the > comment (line 641) based on keylogin. According to that, occurances of > key_netstarg in session.c should be changed to netstarg, but only for freebsd > before the rpc change on Mon Mar 19 12:49:46 2001. The closest later > __FreeBSD_version bump would be 500019 on Sat Jun 9 09:09:45 2001 UTC, while > closest bump before (500018) is on Sat Feb 24 10:44:03 2001 UTC. > While this change makes XFree86-4-clients compile on 4.10-RELEASE, it could be > entirely wrong and I would need someone to confirm this. > The patch to updated XFree86-4-clients port is here: > http://www.ijs.si/software/stuff/freebsd/xfree/XFree86-4-clients_rpc.patch > the entire patch patch to 4.3 port is here: > http://www.ijs.si/software/stuff/freebsd/xfree/XFree86-4-clients_2.diff > If this makes sense, I'll post a follow-up to PR ports/67510. Please do so. I only glanced over your patch. IIRC you can't name EXTRA_PATCHES patch- something, because patches named patch- are automagically applied. I don't know anything about RPC :-(, so i can't comment on this. regards tilman