From owner-p4-projects@FreeBSD.ORG  Sun Oct 17 10:52:39 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3AA3816A4D1; Sun, 17 Oct 2004 10:52:39 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BE59A16A4CF
	for <perforce@freebsd.org>; Sun, 17 Oct 2004 10:52:38 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B2EE743D2F
	for <perforce@freebsd.org>; Sun, 17 Oct 2004 10:52:38 +0000 (GMT)
	(envelope-from peter@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HAqcxm085082
	for <perforce@freebsd.org>; Sun, 17 Oct 2004 10:52:38 GMT
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HAqbhF085079
	for perforce@freebsd.org; Sun, 17 Oct 2004 10:52:37 GMT
	(envelope-from peter@freebsd.org)
Date: Sun, 17 Oct 2004 10:52:37 GMT
Message-Id: <200410171052.i9HAqbhF085079@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 63279 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Oct 2004 10:52:39 -0000

http://perforce.freebsd.org/chv.cgi?CH=63279

Change 63279 by peter@peter_daintree on 2004/10/17 10:51:44

	argh. increase disk command timeout from 5 to 30 seconds.
	On my dying maxtor "sata" drive, it takes 10-20 seconds to
	read some sectors.  Meanwhile, the read and subsequent identify
	commands timeout and the kernel decides the drive is gone. (!).
	It wasn't gone, just slow.  Increasing the timeout means that we
	do successfully read.

Affected files ...

.. //depot/projects/hammer/sys/dev/ata/ata-disk.c#26 edit

Differences ...

==== //depot/projects/hammer/sys/dev/ata/ata-disk.c#26 (text+ko) ====

@@ -252,7 +252,7 @@
     request->device = atadev;
     request->bio = bp;
     request->callback = ad_done;
-    request->timeout = 5;
+    request->timeout = 30;
     request->retries = 2;
     request->data = bp->bio_data;
     request->bytecount = bp->bio_bcount;