From owner-cvs-src@FreeBSD.ORG Sun Jun 26 00:41:14 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F225D16A41C; Sun, 26 Jun 2005 00:41:13 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.village.org (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA1C943D48; Sun, 26 Jun 2005 00:41:13 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1]) by harmony.village.org (8.13.3/8.13.3) with ESMTP id j5Q0eXmF004608; Sat, 25 Jun 2005 18:40:33 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 25 Jun 2005 18:42:08 -0600 (MDT) Message-Id: <20050625.184208.118628146.imp@bsdimp.com> To: cperciva@freebsd.org From: "M. Warner Losh" In-Reply-To: <42BDB8B9.8020400@freebsd.org> References: <200506251958.j5PJwIhq054393@grunt.grondar.org> <42BDB8B9.8020400@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, mark@grondar.org Subject: Re: cvs commit: src/lib/libmd Makefile sha256.3 sha256.h sha256c.c shadriver.c src/sbin/md5 Makefile md5.c src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2005 00:41:14 -0000 In message: <42BDB8B9.8020400@freebsd.org> Colin Percival writes: : Mark Murray wrote: : > Colin Percival writes: : >> MFC the addition of sha256 to libmd and md5(1). : > : > I still object to the use of "manufactured" 64-bit quantities : > instead of using uint64_t, and less strongly to the re-engineering : > of endianness code when we already have functional library routines : > to do the job. : : Changing that is on my TODO list, but several people were asking me to : MFC sha256, so I decided to do the MFC now and then MFC other changes : later. BTW, I'd like to bring in the OpenBSD md5.c driver program. Any objections to doing that if I make sure it connects the sha256 stuff you've added that I'm not sure is in the OpenBSD one.... This is primarily to clear up any confusion that surrounds the md5.c file... Warner