From owner-cvs-src@FreeBSD.ORG Sun Sep 25 00:37:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F05CB16A41F; Sun, 25 Sep 2005 00:37:16 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42ABB43D48; Sun, 25 Sep 2005 00:37:16 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8P0aJ3v007013; Sat, 24 Sep 2005 18:36:21 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 24 Sep 2005 18:36:49 -0600 (MDT) Message-Id: <20050924.183649.76052067.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <4335D760.9080007@root.org> References: <20050924193119.F1A8A16A448@hub.freebsd.org> <4335D760.9080007@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sat, 24 Sep 2005 18:36:21 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, phk@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bus.h rman.h types.h src/sys/kern subr_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Sep 2005 00:37:17 -0000 In message: <4335D760.9080007@root.org> Nate Lawson writes: : Poul-Henning Kamp wrote: : > --- src/sys/sys/bus.h:1.71 Sun Sep 18 01:32:09 2005 : > +++ src/sys/sys/bus.h Sat Sep 24 19:31:10 2005 : > @@ -85,11 +85,6 @@ : > const char *__type, const char *__data); : > void devctl_queue_data(char *__data); : > : > -/* : > - * Forward declarations : > - */ : > -typedef struct device *device_t; : > - : > /** : > * @brief A device driver (included mainly for compatibility with : > * FreeBSD 4.x). : : > diff -u src/sys/sys/types.h:1.92 src/sys/sys/types.h:1.93 : > --- src/sys/sys/types.h:1.92 Tue May 31 15:18:17 2005 : > +++ src/sys/sys/types.h Sat Sep 24 19:31:10 2005 : > @@ -285,6 +285,7 @@ : > typedef __uintfptr_t uintfptr_t; : > typedef __uint64_t uoff_t; : > typedef struct vm_page *vm_page_t; : > +typedef struct device *device_t; : > : > #define offsetof(type, field) __offsetof(type, field) : : I don't think our device_t definition belongs in sys/types.h. It is : opaque for a reason. It is still opaque. Warner