From owner-cvs-src@FreeBSD.ORG Sun Oct 16 01:55:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD31216A41F; Sun, 16 Oct 2005 01:55:36 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B306243D53; Sun, 16 Oct 2005 01:55:35 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G1tZ6F010995; Sun, 16 Oct 2005 01:55:35 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G1tZRA010994; Sun, 16 Oct 2005 01:55:35 GMT (envelope-from sobomax) Message-Id: <200510160155.j9G1tZRA010994@repoman.freebsd.org> From: Maxim Sobolev Date: Sun, 16 Oct 2005 01:55:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/reboot boot_i386.8 src/sys/boot/i386/boot2 boot2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 01:55:37 -0000 sobomax 2005-10-16 01:55:35 UTC FreeBSD src repository Modified files: sbin/reboot boot_i386.8 sys/boot/i386/boot2 boot2.c Log: Add new option `q', which makes second stage loader quiet unless autoboot is disabled or fails. MFC after: 1 week Revision Changes Path 1.57 +10 -1 src/sbin/reboot/boot_i386.8 1.76 +32 -24 src/sys/boot/i386/boot2/boot2.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 03:58:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61EE416A420; Sun, 16 Oct 2005 03:58:07 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A66543D48; Sun, 16 Oct 2005 03:58:07 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G3w6Tf017676; Sun, 16 Oct 2005 03:58:06 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G3w6eT017675; Sun, 16 Oct 2005 03:58:06 GMT (envelope-from imp) Message-Id: <200510160358.j9G3w6eT017675@repoman.freebsd.org> From: Warner Losh Date: Sun, 16 Oct 2005 03:58:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccard pccardvarp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 03:58:09 -0000 imp 2005-10-16 03:58:06 UTC FreeBSD src repository Modified files: sys/dev/pccard pccardvarp.h Log: Mempage should be 1024 not 4096. This fixes the multiple 16-bit cards failing to work in, eg, Soekris boxes. This is a critcal fix for 6.0. MFC After: ASAP Revision Changes Path 1.2 +1 -1 src/sys/dev/pccard/pccardvarp.h From owner-cvs-src@FreeBSD.ORG Sun Oct 16 03:58:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 460B916A421; Sun, 16 Oct 2005 03:58:11 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 063C643D48; Sun, 16 Oct 2005 03:58:11 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G3wA2D017708; Sun, 16 Oct 2005 03:58:10 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G3wAN1017707; Sun, 16 Oct 2005 03:58:10 GMT (envelope-from kris) Message-Id: <200510160358.j9G3wAN1017707@repoman.freebsd.org> From: Kris Kennaway Date: Sun, 16 Oct 2005 03:58:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 03:58:11 -0000 kris 2005-10-16 03:58:10 UTC FreeBSD src repository Modified files: sys/kern subr_param.c Log: Forced commit to note that the previous commit referred to r1.67, not r1.66 Pointed out by: bde Revision Changes Path 1.73 +0 -0 src/sys/kern/subr_param.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 05:29:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5952A16A41F; Sun, 16 Oct 2005 05:29:15 +0000 (GMT) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19F0543D46; Sun, 16 Oct 2005 05:29:15 +0000 (GMT) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G5TEQq028662; Sun, 16 Oct 2005 05:29:14 GMT (envelope-from grehan@repoman.freebsd.org) Received: (from grehan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G5TEVV028661; Sun, 16 Oct 2005 05:29:14 GMT (envelope-from grehan) Message-Id: <200510160529.j9G5TEVV028661@repoman.freebsd.org> From: Peter Grehan Date: Sun, 16 Oct 2005 05:29:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mii brgphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 05:29:15 -0000 grehan 2005-10-16 05:29:14 UTC FreeBSD src repository Modified files: sys/dev/mii brgphy.c Log: The BCM5401 dspcode load on media changes also applies to the 100/1000 BCM5400 phy. This fixes the problem with the GEM port not syncing up on Sawtooth G4's. Obtained from: NetBSD Reported by: Ben Rosengart Revision Changes Path 1.36 +2 -0 src/sys/dev/mii/brgphy.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 07:32:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC08516A41F; Sun, 16 Oct 2005 07:32:00 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A88E143D48; Sun, 16 Oct 2005 07:32:00 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G7W03O035115; Sun, 16 Oct 2005 07:32:00 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G7W0wL035114; Sun, 16 Oct 2005 07:32:00 GMT (envelope-from delphij) Message-Id: <200510160732.j9G7W0wL035114@repoman.freebsd.org> From: Xin LI Date: Sun, 16 Oct 2005 07:32:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/zh_CN.GB2312/readme article.sgml src/release/doc/zh_CN.GB2312/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 07:32:01 -0000 delphij 2005-10-16 07:32:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/zh_CN.GB2312/readme article.sgml release/doc/zh_CN.GB2312/relnotes/common new.sgml Log: MFC Release Notes Language Improvements Approved by: re (hrs) Revision Changes Path 1.1.6.2 +2 -2 src/release/doc/zh_CN.GB2312/readme/article.sgml 1.5.2.2 +47 -46 src/release/doc/zh_CN.GB2312/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Sun Oct 16 07:35:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0ED0016A41F; Sun, 16 Oct 2005 07:35:42 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F9D143D49; Sun, 16 Oct 2005 07:35:41 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G7Zftt035305; Sun, 16 Oct 2005 07:35:41 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G7ZeDx035304; Sun, 16 Oct 2005 07:35:40 GMT (envelope-from delphij) Message-Id: <200510160735.j9G7ZeDx035304@repoman.freebsd.org> From: Xin LI Date: Sun, 16 Oct 2005 07:35:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/release/doc/zh_CN.GB2312/readme article.sgml src/release/doc/zh_CN.GB2312/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 07:35:42 -0000 delphij 2005-10-16 07:35:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) release/doc/zh_CN.GB2312/readme article.sgml release/doc/zh_CN.GB2312/relnotes/common new.sgml Log: MFR6 Release Notes Language Improvements Approved by: re (hrs) Revision Changes Path 1.1.8.2 +2 -2 src/release/doc/zh_CN.GB2312/readme/article.sgml 1.5.4.2 +47 -46 src/release/doc/zh_CN.GB2312/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Sun Oct 16 08:15:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 961C816A41F; Sun, 16 Oct 2005 08:15:31 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5675543D46; Sun, 16 Oct 2005 08:15:31 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G8FVv8036752; Sun, 16 Oct 2005 08:15:31 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G8FUVJ036751; Sun, 16 Oct 2005 08:15:30 GMT (envelope-from hrs) Message-Id: <200510160815.j9G8FUVJ036751@repoman.freebsd.org> From: Hiroki Sato Date: Sun, 16 Oct 2005 08:15:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/share/examples/cvsup standard-supfile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 08:15:31 -0000 hrs 2005-10-16 08:15:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) share/examples/cvsup standard-supfile Log: Use RELENG_6_0 for standard-supfile. Approved by: re (implicitly) Revision Changes Path 1.23.4.1.2.1 +1 -1 src/share/examples/cvsup/standard-supfile From owner-cvs-src@FreeBSD.ORG Sun Oct 16 08:28:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3AE616A41F; Sun, 16 Oct 2005 08:28:11 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CDFA43D46; Sun, 16 Oct 2005 08:28:11 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G8SBRF037331; Sun, 16 Oct 2005 08:28:11 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G8SBnX037330; Sun, 16 Oct 2005 08:28:11 GMT (envelope-from hrs) Message-Id: <200510160828.j9G8SBnX037330@repoman.freebsd.org> From: Hiroki Sato Date: Sun, 16 Oct 2005 08:28:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/share/sgml release.dsl src/release/doc/share/examples Makefile.relnotesng src/release/doc/share/sgml release.ent X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 08:28:12 -0000 hrs 2005-10-16 08:28:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) release/doc/en_US.ISO8859-1/share/sgml release.dsl release/doc/share/examples Makefile.relnotesng release/doc/share/sgml release.ent Log: Update various version numbers and entities for upcoming 6.0-RELEASE. Approved by: re (implicitly) Revision Changes Path 1.8.6.1 +0 -11 src/release/doc/en_US.ISO8859-1/share/sgml/release.dsl 1.11.2.1.2.1 +1 -1 src/release/doc/share/examples/Makefile.relnotesng 1.24.2.1.2.1 +7 -7 src/release/doc/share/sgml/release.ent From owner-cvs-src@FreeBSD.ORG Sun Oct 16 08:58:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E3C916A41F; Sun, 16 Oct 2005 08:58:28 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2907943D46; Sun, 16 Oct 2005 08:58:28 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9G8wR3l045671; Sun, 16 Oct 2005 08:58:28 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9G8wR9v045670; Sun, 16 Oct 2005 08:58:27 GMT (envelope-from obrien) Message-Id: <200510160858.j9G8wR9v045670@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 16 Oct 2005 08:58:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 08:58:28 -0000 obrien 2005-10-16 08:58:27 UTC FreeBSD src repository Modified files: sys/amd64/amd64 identcpu.c sys/i386/i386 identcpu.c Log: For AMD processors, nullify CPUID.HTT. FreeBSD has no need for the information it conveys, and it is only confusing people. This fixes incorrect output in the previous commit. Revision Changes Path 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c 1.147 +9 -0 src/sys/i386/i386/identcpu.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 09:58:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12A6416A41F; Sun, 16 Oct 2005 09:58:47 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id B898E43D48; Sun, 16 Oct 2005 09:58:46 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9G9wjdC064498; Sun, 16 Oct 2005 02:58:45 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9G9wj9h064497; Sun, 16 Oct 2005 02:58:45 -0700 (PDT) (envelope-from obrien) Date: Sun, 16 Oct 2005 02:58:45 -0700 From: "David O'Brien" To: Maxim Sobolev Message-ID: <20051016095845.GA64476@dragon.NUXI.org> References: <200510160155.j9G1tZRA010994@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510160155.j9G1tZRA010994@repoman.freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/reboot boot_i386.8 src/sys/boot/i386/boot2 boot2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 09:58:47 -0000 On Sun, Oct 16, 2005 at 01:55:35AM +0000, Maxim Sobolev wrote: > sobomax 2005-10-16 01:55:35 UTC > > FreeBSD src repository > > Modified files: > sbin/reboot boot_i386.8 > sys/boot/i386/boot2 boot2.c > Log: > Add new option `q', which makes second stage loader quiet unless autoboot > is disabled or fails. > > MFC after: 1 week Before or after you fix the world build on AMD64? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Oct 16 12:33:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A50C216A41F; Sun, 16 Oct 2005 12:33:15 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6439A43D46; Sun, 16 Oct 2005 12:33:15 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GCXFPx053504; Sun, 16 Oct 2005 12:33:15 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GCXFRo053503; Sun, 16 Oct 2005 12:33:15 GMT (envelope-from nyan) Message-Id: <200510161233.j9GCXFRo053503@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Sun, 16 Oct 2005 12:33:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pc98/pc98 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 12:33:15 -0000 nyan 2005-10-16 12:33:15 UTC FreeBSD src repository Modified files: sys/pc98/pc98 machdep.c Log: Reduce diffs from i386/i386/machdep.c Revision Changes Path 1.368 +5 -9 src/sys/pc98/pc98/machdep.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 13:06:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A6C316A41F; Sun, 16 Oct 2005 13:06:54 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3840543D53; Sun, 16 Oct 2005 13:06:54 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GD6sFv061908; Sun, 16 Oct 2005 13:06:54 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GD6r6Q061907; Sun, 16 Oct 2005 13:06:53 GMT (envelope-from netchild) Message-Id: <200510161306.j9GD6r6Q061907@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 16 Oct 2005 13:06:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 13:06:54 -0000 netchild 2005-10-16 13:06:53 UTC FreeBSD src repository Modified files: . access Log: Ariff Abdullah (ariff@) got a commit bit to further improve our sound system (and maybe other parts). I'm his mentor. Approved by: core Revision Changes Path 1.725 +1 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Sun Oct 16 13:48:36 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02A4C16A41F for ; Sun, 16 Oct 2005 13:48:36 +0000 (GMT) (envelope-from pawel.worach@gmail.com) Received: from qproxy.gmail.com (qproxy.gmail.com [72.14.204.197]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D92A43D58 for ; Sun, 16 Oct 2005 13:48:34 +0000 (GMT) (envelope-from pawel.worach@gmail.com) Received: by qproxy.gmail.com with SMTP id q12so620507qbq for ; Sun, 16 Oct 2005 06:48:33 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=NAyPktaOh9x991Q0hSd5qjphrV6GW9TAfkeNm6R3xkLo2Q+88bEP5jniXkYx9s4kpX93ujCwSb5SWeOyKUegUGQdiUA/cG9xJZCZD4yeUZvYyIVGJ3M7xXFePJwTBLL0X2RA0ftEW7Z8y4d1EfisnzbKdBB8RVqC+21mrrjk7jU= Received: by 10.64.156.14 with SMTP id d14mr1172318qbe; Sun, 16 Oct 2005 06:48:33 -0700 (PDT) Received: from ?192.168.0.143? ( [80.217.193.226]) by mx.gmail.com with ESMTP id f17sm4703756qba.2005.10.16.06.48.32; Sun, 16 Oct 2005 06:48:33 -0700 (PDT) Message-ID: <43525A2D.7040304@gmail.com> Date: Sun, 16 Oct 2005 15:48:29 +0200 From: Pawel Worach User-Agent: Thunderbird 1.4.1 (X11/20051015) MIME-Version: 1.0 To: Hiroki Sato References: <200510160815.j9G8FUVJ036751@repoman.freebsd.org> In-Reply-To: <200510160815.j9G8FUVJ036751@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples/cvsup standard-supfile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 13:48:36 -0000 Hiroki Sato wrote: > hrs 2005-10-16 08:15:29 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6_0) > share/examples/cvsup standard-supfile > Log: > Use RELENG_6_0 for standard-supfile. > Can this go in as well so that 'make update' works? Index: Makefile.inc1 =================================================================== RCS file: /export/ctm/cvs/src/Makefile.inc1,v retrieving revision 1.499.2.3 diff -u -r1.499.2.3 Makefile.inc1 --- Makefile.inc1 30 Jul 2005 07:56:25 -0000 1.499.2.3 +++ Makefile.inc1 16 Oct 2005 13:45:45 -0000 @@ -87,7 +87,7 @@ .endif CVS?= cvs -CVSFLAGS?= -r RELENG_6 -P -d -I! +CVSFLAGS?= -r RELENG_6_0 -P -d -I! SUP?= /usr/local/bin/cvsup SUPFLAGS?= -g -L 2 -P - .if defined(SUPHOST) -- Pawel From owner-cvs-src@FreeBSD.ORG Sun Oct 16 14:07:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2FFD16A41F; Sun, 16 Oct 2005 14:07:44 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 713C743D46; Sun, 16 Oct 2005 14:07:44 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GE7i7H064442; Sun, 16 Oct 2005 14:07:44 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GE7iOj064441; Sun, 16 Oct 2005 14:07:44 GMT (envelope-from hrs) Message-Id: <200510161407.j9GE7iOj064441@repoman.freebsd.org> From: Hiroki Sato Date: Sun, 16 Oct 2005 14:07:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src Makefile.inc1 src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 14:07:44 -0000 hrs 2005-10-16 14:07:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) . Makefile.inc1 release Makefile Log: Update version numbers for upcoming 6.0-RELEASE. Approved by: re (implicitly) Revision Changes Path 1.499.2.3.2.1 +1 -1 src/Makefile.inc1 1.887.2.2.2.1 +3 -3 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Sun Oct 16 14:40:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2B4816A41F; Sun, 16 Oct 2005 14:40:24 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EE0A43D46; Sun, 16 Oct 2005 14:40:24 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GEeOsU065744; Sun, 16 Oct 2005 14:40:24 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GEeO7X065738; Sun, 16 Oct 2005 14:40:24 GMT (envelope-from netchild) Message-Id: <200510161440.j9GEeO7X065738@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 16 Oct 2005 14:40:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src ObsoleteFiles.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 14:40:24 -0000 netchild 2005-10-16 14:40:24 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Add some files which kris found on an old server. Revision Changes Path 1.20 +1862 -0 src/ObsoleteFiles.inc From owner-cvs-src@FreeBSD.ORG Sun Oct 16 16:52:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 517F716A41F; Sun, 16 Oct 2005 16:52:15 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D2C443D48; Sun, 16 Oct 2005 16:52:15 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GGqE6W079070; Sun, 16 Oct 2005 16:52:14 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GGqEC7079069; Sun, 16 Oct 2005 16:52:14 GMT (envelope-from rwatson) Message-Id: <200510161652.j9GGqEC7079069@repoman.freebsd.org> From: Robert Watson Date: Sun, 16 Oct 2005 16:52:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/ufs/ufs ufs_extattr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 16:52:15 -0000 rwatson 2005-10-16 16:52:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/ufs/ufs ufs_extattr.c Log: Merge ufs_extattr.c:1.82 from RELENG_6 to RELENG_6_0: When performing a VOP_LOOKUP() as part of UFS1 extended attribute auto-start, set cnp.cn_lkflags to LK_EXCLUSIVE. This flag must now be set so that lockmgr knows what kind of lock to acquire, and it will panic if not specified. This resulted in a panic when using extended attributes on UFS1 as of locking work present in the 6.x branch. Reported by: lofi Approved by: re (kensmith) Revision Changes Path 1.81.4.1 +1 -0 src/sys/ufs/ufs/ufs_extattr.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 17:12:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8CF7916A420; Sun, 16 Oct 2005 17:12:18 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B15B43D46; Sun, 16 Oct 2005 17:12:18 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GHCIlW079963; Sun, 16 Oct 2005 17:12:18 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GHCI4O079962; Sun, 16 Oct 2005 17:12:18 GMT (envelope-from rwatson) Message-Id: <200510161712.j9GHCI4O079962@repoman.freebsd.org> From: Robert Watson Date: Sun, 16 Oct 2005 17:12:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/netinet in.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 17:12:18 -0000 rwatson 2005-10-16 17:12:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/netinet in.c Log: Merge in.c:1.89,1.90 from HEAD to RELENG_6_0: Acquire Giant conditionally in in_addmulti() and in_delmulti() based on whether the interface being accessed is IFF_NEEDSGIANT or not. This avoids lock order reversals when calling into the interface ioctl handler, which could potentially lead to deadlock. The long term solution is to eliminate non-MPSAFE network drivers. Discussed with: jhb Unlock Giant symmetrically with respect to lock acquire order as that's generally nicer. Spotted by: johan Approved by: re (kensmith) Revision Changes Path 1.85.2.3.2.1 +9 -0 src/sys/netinet/in.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 19:49:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73F0616A41F; Sun, 16 Oct 2005 19:49:45 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B134843D4C; Sun, 16 Oct 2005 19:49:44 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GJnifs086423; Sun, 16 Oct 2005 19:49:44 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GJni6P086422; Sun, 16 Oct 2005 19:49:44 GMT (envelope-from sobomax) Message-Id: <200510161949.j9GJni6P086422@repoman.freebsd.org> From: Maxim Sobolev Date: Sun, 16 Oct 2005 19:49:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/i386/boot2 boot2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 19:49:45 -0000 sobomax 2005-10-16 19:49:44 UTC FreeBSD src repository Modified files: sys/boot/i386/boot2 boot2.c Log: Backout previous commit - for some reason it overflows space constrains on amd64. Better version will follow. Revision Changes Path 1.77 +24 -32 src/sys/boot/i386/boot2/boot2.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 20:22:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6F1916A41F; Sun, 16 Oct 2005 20:22:36 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AA8743D4C; Sun, 16 Oct 2005 20:22:36 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GKMaFq087984; Sun, 16 Oct 2005 20:22:36 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GKMa7N087983; Sun, 16 Oct 2005 20:22:36 GMT (envelope-from sobomax) Message-Id: <200510162022.j9GKMa7N087983@repoman.freebsd.org> From: Maxim Sobolev Date: Sun, 16 Oct 2005 20:22:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/i386/boot2 boot2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 20:22:37 -0000 sobomax 2005-10-16 20:22:36 UTC FreeBSD src repository Modified files: sys/boot/i386/boot2 boot2.c Log: Re-implement rev.1.76 with respect to the code size. Revision Changes Path 1.78 +22 -15 src/sys/boot/i386/boot2/boot2.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 20:22:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A61916A41F; Sun, 16 Oct 2005 20:22:57 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E33B843D46; Sun, 16 Oct 2005 20:22:56 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GKMuYM088283; Sun, 16 Oct 2005 20:22:56 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GKMu6V088282; Sun, 16 Oct 2005 20:22:56 GMT (envelope-from phk) Message-Id: <200510162022.j9GKMu6V088282@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 16 Oct 2005 20:22:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/cx if_cx.c src/sys/dev/cy cy.c src/sys/dev/digi digi.c src/sys/dev/rc rc.c src/sys/dev/rp rp.c src/sys/dev/sab sab.c src/sys/dev/si si.c src/sys/dev/sio sio.c src/sys/dev/uart uart_tty.c src/sys/dev/usb ubser.c ucom.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 20:22:57 -0000 phk 2005-10-16 20:22:56 UTC FreeBSD src repository Modified files: sys/dev/cx if_cx.c sys/dev/cy cy.c sys/dev/digi digi.c sys/dev/rc rc.c sys/dev/rp rp.c sys/dev/sab sab.c sys/dev/si si.c sys/dev/sio sio.c sys/dev/uart uart_tty.c sys/dev/usb ubser.c ucom.c ucycom.c sys/kern tty.c sys/pc98/cbus sio.c sys/sys tty.h Log: Eliminate two unused arguments to ttycreate(). Revision Changes Path 1.49 +1 -2 src/sys/dev/cx/if_cx.c 1.161 +1 -1 src/sys/dev/cy/cy.c 1.60 +1 -1 src/sys/dev/digi/digi.c 1.100 +1 -1 src/sys/dev/rc/rc.c 1.68 +1 -1 src/sys/dev/rp/rp.c 1.40 +1 -1 src/sys/dev/sab/sab.c 1.136 +1 -1 src/sys/dev/si/si.c 1.461 +1 -1 src/sys/dev/sio/sio.c 1.23 +1 -1 src/sys/dev/uart/uart_tty.c 1.17 +1 -1 src/sys/dev/usb/ubser.c 1.58 +1 -1 src/sys/dev/usb/ucom.c 1.4 +1 -1 src/sys/dev/usb/ucycom.c 1.251 +4 -2 src/sys/kern/tty.c 1.237 +1 -1 src/sys/pc98/cbus/sio.c 1.98 +2 -1 src/sys/sys/tty.h From owner-cvs-src@FreeBSD.ORG Sun Oct 16 20:35:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CD0516A421; Sun, 16 Oct 2005 20:35:06 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED01043D5A; Sun, 16 Oct 2005 20:35:05 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GKZ51K088844; Sun, 16 Oct 2005 20:35:05 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GKZ5R6088843; Sun, 16 Oct 2005 20:35:05 GMT (envelope-from phk) Message-Id: <200510162035.j9GKZ5R6088843@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 16 Oct 2005 20:35:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/rp rp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 20:35:06 -0000 phk 2005-10-16 20:35:05 UTC FreeBSD src repository Modified files: sys/dev/rp rp.c Log: we know it is called rpclose() so call it directly. Revision Changes Path 1.69 +1 -1 src/sys/dev/rp/rp.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 20:39:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 914DA16A420; Sun, 16 Oct 2005 20:39:04 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4EB8C43D49; Sun, 16 Oct 2005 20:39:04 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GKd4Bj089077; Sun, 16 Oct 2005 20:39:04 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GKd4Pb089076; Sun, 16 Oct 2005 20:39:04 GMT (envelope-from phk) Message-Id: <200510162039.j9GKd4Pb089076@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 16 Oct 2005 20:39:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys tty.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 20:39:04 -0000 phk 2005-10-16 20:39:04 UTC FreeBSD src repository Modified files: sys/sys tty.h Log: Add a bunch of inline functions to call the drivers tty implementing methods. Revision Changes Path 1.99 +76 -0 src/sys/sys/tty.h From owner-cvs-src@FreeBSD.ORG Sun Oct 16 20:40:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC4DD16A41F; Sun, 16 Oct 2005 20:40:40 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 867E043D48; Sun, 16 Oct 2005 20:40:40 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GKeeI5089240; Sun, 16 Oct 2005 20:40:40 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GKeesq089239; Sun, 16 Oct 2005 20:40:40 GMT (envelope-from phk) Message-Id: <200510162040.j9GKeesq089239@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 16 Oct 2005 20:40:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys tty.h src/sys/kern tty_compat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 20:40:41 -0000 phk 2005-10-16 20:40:40 UTC FreeBSD src repository Modified files: sys/sys tty.h sys/kern tty_compat.c Log: Make ttsetcompat() static Revision Changes Path 1.38 +1 -1 src/sys/kern/tty_compat.c 1.100 +0 -2 src/sys/sys/tty.h From owner-cvs-src@FreeBSD.ORG Sun Oct 16 20:44:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3E4616A41F; Sun, 16 Oct 2005 20:44:18 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88D3543D48; Sun, 16 Oct 2005 20:44:18 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GKiITg089455; Sun, 16 Oct 2005 20:44:18 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GKiIF8089454; Sun, 16 Oct 2005 20:44:18 GMT (envelope-from phk) Message-Id: <200510162044.j9GKiIF8089454@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 16 Oct 2005 20:44:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_sl.c ppp_tty.c src/sys/netgraph ng_tty.c src/sys/netgraph/bluetooth/drivers/h4 ng_h4.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 20:44:19 -0000 phk 2005-10-16 20:44:18 UTC FreeBSD src repository Modified files: sys/net if_sl.c ppp_tty.c sys/netgraph ng_tty.c sys/netgraph/bluetooth/drivers/h4 ng_h4.c Log: Use new (inline) functions for calls into driver. Revision Changes Path 1.131 +2 -2 src/sys/net/if_sl.c 1.69 +3 -5 src/sys/net/ppp_tty.c 1.14 +1 -2 src/sys/netgraph/bluetooth/drivers/h4/ng_h4.c 1.36 +1 -2 src/sys/netgraph/ng_tty.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 20:58:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B81A16A41F; Sun, 16 Oct 2005 20:58:23 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1596143D46; Sun, 16 Oct 2005 20:58:23 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GKwM4m097361; Sun, 16 Oct 2005 20:58:22 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GKwM7o097360; Sun, 16 Oct 2005 20:58:22 GMT (envelope-from phk) Message-Id: <200510162058.j9GKwM7o097360@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 16 Oct 2005 20:58:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/alpha/alpha promcons.c src/sys/alpha/tlsb zs_tlsb.c src/sys/dev/dcons dcons_os.c src/sys/dev/ofw ofw_console.c src/sys/dev/zs zs.c src/sys/ia64/ia64 ssc.c src/sys/kern tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 20:58:23 -0000 phk 2005-10-16 20:58:22 UTC FreeBSD src repository Modified files: sys/alpha/alpha promcons.c sys/alpha/tlsb zs_tlsb.c sys/dev/dcons dcons_os.c sys/dev/ofw ofw_console.c sys/dev/zs zs.c sys/ia64/ia64 ssc.c sys/kern tty.c Log: Make ttyconsolemode() call ttsetwater() so that drivers don't have to. Revision Changes Path 1.45 +0 -1 src/sys/alpha/alpha/promcons.c 1.50 +0 -1 src/sys/alpha/tlsb/zs_tlsb.c 1.7 +0 -1 src/sys/dev/dcons/dcons_os.c 1.32 +0 -1 src/sys/dev/ofw/ofw_console.c 1.31 +0 -1 src/sys/dev/zs/zs.c 1.25 +0 -1 src/sys/ia64/ia64/ssc.c 1.252 +1 -0 src/sys/kern/tty.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 21:07:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29E1816A41F; Sun, 16 Oct 2005 21:07:32 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B977B43D48; Sun, 16 Oct 2005 21:07:31 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GL7Vg0097838; Sun, 16 Oct 2005 21:07:31 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GL7V1l097837; Sun, 16 Oct 2005 21:07:31 GMT (envelope-from phk) Message-Id: <200510162107.j9GL7V1l097837@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 16 Oct 2005 21:07:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 21:07:32 -0000 phk 2005-10-16 21:07:31 UTC FreeBSD src repository Modified files: sys/kern tty.c Log: Use new functions to call into drivers methods. Revision Changes Path 1.253 +27 -39 src/sys/kern/tty.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 21:31:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4321A16A41F; Sun, 16 Oct 2005 21:31:47 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 000FE43D46; Sun, 16 Oct 2005 21:31:46 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GLVkqG098844; Sun, 16 Oct 2005 21:31:46 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GLVk0p098843; Sun, 16 Oct 2005 21:31:46 GMT (envelope-from truckman) Message-Id: <200510162131.j9GLVk0p098843@repoman.freebsd.org> From: Don Lewis Date: Sun, 16 Oct 2005 21:31:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ufs ufs_lookup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 21:31:47 -0000 truckman 2005-10-16 21:31:46 UTC FreeBSD src repository Modified files: sys/ufs/ufs ufs_lookup.c Log: Correct the type of the temporary variable used by ufs_lookup.c:1.78 to fix the race condition in the ufs_lookup() ISDOTDOT code. Noticed by: bde MFC after: 12 days Revision Changes Path 1.79 +1 -1 src/sys/ufs/ufs/ufs_lookup.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 21:39:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9386C16A41F; Sun, 16 Oct 2005 21:39:29 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5075943D48; Sun, 16 Oct 2005 21:39:29 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GLdTJd099096; Sun, 16 Oct 2005 21:39:29 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GLdTtN099095; Sun, 16 Oct 2005 21:39:29 GMT (envelope-from truckman) Message-Id: <200510162139.j9GLdTtN099095@repoman.freebsd.org> From: Don Lewis Date: Sun, 16 Oct 2005 21:39:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/gnu/fs/ext2fs ext2_lookup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 21:39:29 -0000 truckman 2005-10-16 21:39:29 UTC FreeBSD src repository Modified files: sys/gnu/fs/ext2fs ext2_lookup.c Log: Apply the same fix to a potential race in the ISDOTDOT code in ext2_lookup() that was used to fix an actual race in ufs_lookup.c:1.78. This is not currently a hazard, but the bug would be activated by marking ext2fs as MPSAFE. Requested by: bde MFC after: 2 weeks Revision Changes Path 1.51 +3 -1 src/sys/gnu/fs/ext2fs/ext2_lookup.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 21:41:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B9F816A41F; Sun, 16 Oct 2005 21:41:57 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30BF043D62; Sun, 16 Oct 2005 21:41:55 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GLftuI099263; Sun, 16 Oct 2005 21:41:55 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GLftOq099262; Sun, 16 Oct 2005 21:41:55 GMT (envelope-from truckman) Message-Id: <200510162141.j9GLftOq099262@repoman.freebsd.org> From: Don Lewis Date: Sun, 16 Oct 2005 21:41:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/isofs/cd9660 cd9660_lookup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 21:41:57 -0000 truckman 2005-10-16 21:41:55 UTC FreeBSD src repository Modified files: sys/isofs/cd9660 cd9660_lookup.c Log: Apply the same fix to a potential race in the ISDOTDOT code in cd9660_lookup() that was used to fix an actual race in ufs_lookup.c:1.78. This is not currently a hazard, but the bug would be activated by marking cd9660 as MPSAFE. Requested by: bde Revision Changes Path 1.42 +4 -3 src/sys/isofs/cd9660/cd9660_lookup.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 21:45:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DED0F16A420; Sun, 16 Oct 2005 21:45:31 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55D9F43D76; Sun, 16 Oct 2005 21:45:25 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GLjPtd099515; Sun, 16 Oct 2005 21:45:25 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GLjPcA099514; Sun, 16 Oct 2005 21:45:25 GMT (envelope-from kris) Message-Id: <200510162145.j9GLjPcA099514@repoman.freebsd.org> From: Kris Kennaway Date: Sun, 16 Oct 2005 21:45:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/nullfs null_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 21:45:32 -0000 kris 2005-10-16 21:45:25 UTC FreeBSD src repository Modified files: sys/fs/nullfs null_vfsops.c Log: Reflect mpsafety of the underlying filesystem in the nullfs image. I benchmarked this by simultaneously extracting 4 large tarballs (basically world images) on a 4-processor AMD64 system, in a malloc-backed md. With this patch, system time was reduced by 43%, and wall clock time by 33%. Submitted by: jeff MFC after: 1 week Revision Changes Path 1.73 +1 -0 src/sys/fs/nullfs/null_vfsops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 21:54:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DADB16A41F; Sun, 16 Oct 2005 21:54:36 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E083643D46; Sun, 16 Oct 2005 21:54:35 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GLsZ3L099937; Sun, 16 Oct 2005 21:54:35 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GLsZGJ099936; Sun, 16 Oct 2005 21:54:35 GMT (envelope-from truckman) Message-Id: <200510162154.j9GLsZGJ099936@repoman.freebsd.org> From: Don Lewis Date: Sun, 16 Oct 2005 21:54:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/nwfs nwfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 21:54:36 -0000 truckman 2005-10-16 21:54:35 UTC FreeBSD src repository Modified files: sys/fs/nwfs nwfs_vnops.c Log: Update nwfs_lookup() to match the current cache_lookup() API. cache_lookup() has returned a ref'ed and locked vnode since vfs_cache.c:1.96, dated Tue Mar 29 12:59:06 2005 UTC. This change is similar to the change made to smbfs_lookup() in smbfs_vnops.c:1.58. Tested by: "Antony Mawer" ant AT mawer.org MFC after: 2 weeks Revision Changes Path 1.42 +11 -26 src/sys/fs/nwfs/nwfs_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 16 22:23:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54F7916A41F; Sun, 16 Oct 2005 22:23:04 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13D2443D49; Sun, 16 Oct 2005 22:23:04 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9GMN3J5001381; Sun, 16 Oct 2005 22:23:03 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9GMN3nG001380; Sun, 16 Oct 2005 22:23:03 GMT (envelope-from davidxu) Message-Id: <200510162223.j9GMN3nG001380@repoman.freebsd.org> From: David Xu Date: Sun, 16 Oct 2005 22:23:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include signal.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2005 22:23:04 -0000 davidxu 2005-10-16 22:23:03 UTC FreeBSD src repository Modified files: include signal.h Log: Use __pid_t instead of pid_t for sigqueue as other functions. Revision Changes Path 1.26 +1 -1 src/include/signal.h From owner-cvs-src@FreeBSD.ORG Mon Oct 17 00:04:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70ACB16A41F; Mon, 17 Oct 2005 00:04:36 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EA0C43D76; Mon, 17 Oct 2005 00:04:35 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H04ZlI004977; Mon, 17 Oct 2005 00:04:35 GMT (envelope-from flz@repoman.freebsd.org) Received: (from flz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H04Z48004976; Mon, 17 Oct 2005 00:04:35 GMT (envelope-from flz) Message-Id: <200510170004.j9H04Z48004976@repoman.freebsd.org> From: Florent Thoumie Date: Mon, 17 Oct 2005 00:04:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 00:04:36 -0000 flz 2005-10-17 00:04:35 UTC FreeBSD src repository (ports committer) Modified files: sys/fs/unionfs union_vnops.c Log: - Fix typo. Approved by: ssouhlal MFC after: 1 week Revision Changes Path 1.133 +1 -1 src/sys/fs/unionfs/union_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 00:16:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2543F16A41F; Mon, 17 Oct 2005 00:16:55 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D705543D46; Mon, 17 Oct 2005 00:16:54 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H0GsES005685; Mon, 17 Oct 2005 00:16:54 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H0GsFd005684; Mon, 17 Oct 2005 00:16:54 GMT (envelope-from kris) Message-Id: <200510170016.j9H0GsFd005684@repoman.freebsd.org> From: Kris Kennaway Date: Mon, 17 Oct 2005 00:16:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 00:16:55 -0000 kris 2005-10-17 00:16:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern subr_param.c Log: MFC r1.72: Partially revert r1.67 which changed maxbcache and maxswzone from int to long without updating the version. This broke the corresponding tunables on sparc. Approved by: re (kensmith) Revision Changes Path 1.71.2.1 +4 -4 src/sys/kern/subr_param.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 00:17:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2FA716A41F; Mon, 17 Oct 2005 00:17:22 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B226D43D48; Mon, 17 Oct 2005 00:17:22 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H0HMMG005733; Mon, 17 Oct 2005 00:17:22 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H0HMiD005732; Mon, 17 Oct 2005 00:17:22 GMT (envelope-from kris) Message-Id: <200510170017.j9H0HMiD005732@repoman.freebsd.org> From: Kris Kennaway Date: Mon, 17 Oct 2005 00:17:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 00:17:23 -0000 kris 2005-10-17 00:17:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/kern subr_param.c Log: MFC r1.72: Partially revert r1.67 which changed maxbcache and maxswzone from int to long without updating the version. This broke the corresponding tunables on sparc. Approved by: re (kensmith) Revision Changes Path 1.71.4.1 +4 -4 src/sys/kern/subr_param.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 00:19:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1478D16A41F; Mon, 17 Oct 2005 00:19:01 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C80CD43D46; Mon, 17 Oct 2005 00:19:00 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H0J0e3005787; Mon, 17 Oct 2005 00:19:00 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H0J0sa005786; Mon, 17 Oct 2005 00:19:00 GMT (envelope-from kris) Message-Id: <200510170019.j9H0J0sa005786@repoman.freebsd.org> From: Kris Kennaway Date: Mon, 17 Oct 2005 00:19:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/sparc64/include param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 00:19:01 -0000 kris 2005-10-17 00:19:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sparc64/include param.h Log: MFC r1.20: Add a default value for VM_BCACHE_SIZE_MAX of 400MB. This is copied from amd64, and is a factor of 3 less than the value previously auto-sized on a 12GB machine, which would cause an overflow in calculations involving the maxbcache int, causing bufinit() to loop forever at boot. Approved by: re (kensmith) Revision Changes Path 1.19.2.1 +8 -0 src/sys/sparc64/include/param.h From owner-cvs-src@FreeBSD.ORG Mon Oct 17 00:19:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38A5816A41F; Mon, 17 Oct 2005 00:19:31 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA4BA43D46; Mon, 17 Oct 2005 00:19:30 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H0JUY7005830; Mon, 17 Oct 2005 00:19:30 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H0JUxn005829; Mon, 17 Oct 2005 00:19:30 GMT (envelope-from kris) Message-Id: <200510170019.j9H0JUxn005829@repoman.freebsd.org> From: Kris Kennaway Date: Mon, 17 Oct 2005 00:19:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/sparc64/include param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 00:19:31 -0000 kris 2005-10-17 00:19:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/sparc64/include param.h Log: MFC r1.20: Add a default value for VM_BCACHE_SIZE_MAX of 400MB. This is copied from amd64, and is a factor of 3 less than the value previously auto-sized on a 12GB machine, which would cause an overflow in calculations involving the maxbcache int, causing bufinit() to loop forever at boot. Approved by: re (kensmith) Revision Changes Path 1.19.4.1 +8 -0 src/sys/sparc64/include/param.h From owner-cvs-src@FreeBSD.ORG Mon Oct 17 00:20:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2CF516A41F; Mon, 17 Oct 2005 00:20:47 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F67643D49; Mon, 17 Oct 2005 00:20:47 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H0KlhX005984; Mon, 17 Oct 2005 00:20:47 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H0Klc2005983; Mon, 17 Oct 2005 00:20:47 GMT (envelope-from kris) Message-Id: <200510170020.j9H0Klc2005983@repoman.freebsd.org> From: Kris Kennaway Date: Mon, 17 Oct 2005 00:20:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/sparc64/include param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 00:20:48 -0000 kris 2005-10-17 00:20:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/sparc64/include param.h Log: MFC r1.20: Add a default value for VM_BCACHE_SIZE_MAX of 400MB. This is copied from amd64, and is a factor of 3 less than the value previously auto-sized on a 12GB machine, which would cause an overflow in calculations involving the maxbcache int, causing bufinit() to loop forever at boot. Revision Changes Path 1.18.4.2 +8 -0 src/sys/sparc64/include/param.h From owner-cvs-src@FreeBSD.ORG Mon Oct 17 02:17:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8634716A41F; Mon, 17 Oct 2005 02:17:49 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55BA243D46; Mon, 17 Oct 2005 02:17:49 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H2HnOl017432; Mon, 17 Oct 2005 02:17:49 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H2Hnjp017431; Mon, 17 Oct 2005 02:17:49 GMT (envelope-from imp) Message-Id: <200510170217.j9H2Hnjp017431@repoman.freebsd.org> From: Warner Losh Date: Mon, 17 Oct 2005 02:17:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/ed if_ed_pci.c if_ed_rtl80x9.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 02:17:49 -0000 imp 2005-10-17 02:17:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/ed if_ed_pci.c if_ed_rtl80x9.c Log: MFC: Fixes for RTL8029 and qemu. > imp 2005-10-13 22:06:02 UTC > Modified files: > sys/dev/ed if_ed_rtl80x9.c > Log: > o Fix probing of rtl80x9 parts. We shouldn't be calling > ed_probe_generic8390 where we're calling it. It will be done as part > of ed_probe_Novel_generic after things are setup in a way that > ed_probe_generic8390 will grok. > o Fix operator precedence botch that causes a panic when setting the media > type for 10baseT connections. > o Save the type of device so that it prints with the rest of the probe. > > # this should make it work with qemu again, but only if it has my patches > # to actually implement the RTL8029 specific registers. > Revision Changes Path > 1.2 +6 -5 src/sys/dev/ed/if_ed_rtl80x9.c > > Modified files: > sys/dev/ed if_ed_pci.c > Log: > If we can't probe the RTL80x9 for some reason, fall back to probing it > as a Novell NE-2000. This is necessary for unpatched qemu working > correctly. qemu claims to be a RTL8029, but doesn't implement the > RTL8029 specific registers at this time. I've created patches for > that, but there's no reason we can't use qemu's emulation w/o these > patches. This should make life easier for those folks that boot > FreeBSD via qemu. > Revision Changes Path > 1.48 +9 -2 src/sys/dev/ed/if_ed_pci.c Approved by: re@ (kensmith) Revision Changes Path 1.43.2.3 +9 -2 src/sys/dev/ed/if_ed_pci.c 1.1.2.2 +6 -5 src/sys/dev/ed/if_ed_rtl80x9.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 02:25:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7343F16A41F; Mon, 17 Oct 2005 02:25:27 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30C2F43D46; Mon, 17 Oct 2005 02:25:27 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H2PR7b017745; Mon, 17 Oct 2005 02:25:27 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H2PR14017744; Mon, 17 Oct 2005 02:25:27 GMT (envelope-from imp) Message-Id: <200510170225.j9H2PR14017744@repoman.freebsd.org> From: Warner Losh Date: Mon, 17 Oct 2005 02:25:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/dev/ed if_ed_pci.c if_ed_rtl80x9.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 02:25:27 -0000 imp 2005-10-17 02:25:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/dev/ed if_ed_pci.c if_ed_rtl80x9.c Log: MF-RELENG_6: rtl8029 and qemu fixes. > 1.2 +6 -5 src/sys/dev/ed/if_ed_rtl80x9.c > 1.48 +9 -2 src/sys/dev/ed/if_ed_pci.c Approved by: re@ (kensmith) Revision Changes Path 1.43.2.2.2.1 +9 -2 src/sys/dev/ed/if_ed_pci.c 1.1.2.1.2.1 +6 -5 src/sys/dev/ed/if_ed_rtl80x9.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 02:32:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54D6616A41F; Mon, 17 Oct 2005 02:32:24 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF85543D53; Mon, 17 Oct 2005 02:32:23 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H2WNkJ018025; Mon, 17 Oct 2005 02:32:23 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H2WNLm018024; Mon, 17 Oct 2005 02:32:23 GMT (envelope-from imp) Message-Id: <200510170232.j9H2WNLm018024@repoman.freebsd.org> From: Warner Losh Date: Mon, 17 Oct 2005 02:32:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed_isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 02:32:24 -0000 imp 2005-10-17 02:32:23 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_isa.c Log: Check against 8019 rather than 8029 for reading in the MAC addr since the former is the ISA part, not the latter. MFC After 6.0 is unfrozen (this bug doesn't exist in 6.0 because I didn't MFC the rtl80x9 changes for ISA due to an error on my part) Revision Changes Path 1.26 +1 -1 src/sys/dev/ed/if_ed_isa.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 03:07:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 651EE16A41F; Mon, 17 Oct 2005 03:07:37 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21A0943D49; Mon, 17 Oct 2005 03:07:37 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H37aU0019386; Mon, 17 Oct 2005 03:07:37 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H37a3E019385; Mon, 17 Oct 2005 03:07:36 GMT (envelope-from rodrigc) Message-Id: <200510170307.j9H37a3E019385@repoman.freebsd.org> From: Craig Rodrigues Date: Mon, 17 Oct 2005 03:07:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/udf udf_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 03:07:37 -0000 rodrigc 2005-10-17 03:07:36 UTC FreeBSD src repository Modified files: sys/fs/udf udf_vfsops.c Log: Unconditionally mount a UDF filesystem as read-only, instead of returning an EROFS if we forget to mount it as read-only. Revision Changes Path 1.38 +4 -2 src/sys/fs/udf/udf_vfsops.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 03:27:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0639216A41F; Mon, 17 Oct 2005 03:27:40 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0FD943D5A; Mon, 17 Oct 2005 03:27:35 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H3RZdd020270; Mon, 17 Oct 2005 03:27:35 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H3RZeB020269; Mon, 17 Oct 2005 03:27:35 GMT (envelope-from rodrigc) Message-Id: <200510170327.j9H3RZeB020269@repoman.freebsd.org> From: Craig Rodrigues Date: Mon, 17 Oct 2005 03:27:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/isofs/cd9660 cd9660_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 03:27:40 -0000 rodrigc 2005-10-17 03:27:35 UTC FreeBSD src repository Modified files: sys/isofs/cd9660 cd9660_vfsops.c Log: Use the actual sector size of the media instead of hard-coding it to 2048. This eliminates KASSERTs in GEOM if we accidentally mount an audio CD as a cd9660 filesystem. Revision Changes Path 1.142 +12 -3 src/sys/isofs/cd9660/cd9660_vfsops.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 03:29:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E26D16A41F; Mon, 17 Oct 2005 03:29:54 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF55C43D46; Mon, 17 Oct 2005 03:29:53 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H3Trg7020396; Mon, 17 Oct 2005 03:29:53 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H3Trr9020395; Mon, 17 Oct 2005 03:29:53 GMT (envelope-from rodrigc) Message-Id: <200510170329.j9H3Trr9020395@repoman.freebsd.org> From: Craig Rodrigues Date: Mon, 17 Oct 2005 03:29:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/isofs/cd9660 cd9660_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 03:29:54 -0000 rodrigc 2005-10-17 03:29:53 UTC FreeBSD src repository Modified files: sys/isofs/cd9660 cd9660_vfsops.c Log: Unconditionally mount a CD9660 filesystem as read-only, instead of returning EROFS if we forget to mount it as read-only. Revision Changes Path 1.143 +4 -2 src/sys/isofs/cd9660/cd9660_vfsops.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 06:09:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A051C16A41F; Mon, 17 Oct 2005 06:09:56 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C91F43D48; Mon, 17 Oct 2005 06:09:56 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H69uwo033246; Mon, 17 Oct 2005 06:09:56 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H69ukL033245; Mon, 17 Oct 2005 06:09:56 GMT (envelope-from ache) Message-Id: <200510170609.j9H69ukL033245@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 17 Oct 2005 06:09:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/termcap termcap.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 06:09:56 -0000 ache 2005-10-17 06:09:56 UTC FreeBSD src repository Modified files: share/termcap termcap.src Log: xterm-basic: 1) use standard vt100 as/ae instead of ^N/^O which not works in real xterm 2) Remove ^O from me, it not belongs there Revision Changes Path 1.145 +2 -2 src/share/termcap/termcap.src From owner-cvs-src@FreeBSD.ORG Mon Oct 17 06:44:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 013D716A41F; Mon, 17 Oct 2005 06:44:51 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35C9343D49; Mon, 17 Oct 2005 06:44:49 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j9H6imDA053027 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 17 Oct 2005 10:44:48 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j9H6ilPj053026; Mon, 17 Oct 2005 10:44:47 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 17 Oct 2005 10:44:47 +0400 From: Gleb Smirnoff To: Craig Rodrigues Message-ID: <20051017064447.GN14542@cell.sick.ru> References: <200510170327.j9H3RZeB020269@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200510170327.j9H3RZeB020269@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 06:44:51 -0000 On Mon, Oct 17, 2005 at 03:27:35AM +0000, Craig Rodrigues wrote: C> rodrigc 2005-10-17 03:27:35 UTC C> C> FreeBSD src repository C> C> Modified files: C> sys/isofs/cd9660 cd9660_vfsops.c C> Log: C> Use the actual sector size of the media instead of hard-coding it to 2048. C> This eliminates KASSERTs in GEOM if we accidentally mount an audio CD C> as a cd9660 filesystem. Thanks for fixing this! I think it deserves to be merged to 6.0-RELEASE. The operating system that panics on attempt to mount an audio CD looks funny. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Mon Oct 17 07:58:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC9EB16A41F; Mon, 17 Oct 2005 07:58:06 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7973D43D46; Mon, 17 Oct 2005 07:58:06 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H7w6mH037871; Mon, 17 Oct 2005 07:58:06 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H7w6aH037870; Mon, 17 Oct 2005 07:58:06 GMT (envelope-from phk) Message-Id: <200510170758.j9H7w6aH037870@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 17 Oct 2005 07:58:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/tools/tools/nanobsd nanobsd.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 07:58:07 -0000 phk 2005-10-17 07:58:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) tools/tools/nanobsd nanobsd.sh Log: MF6: nanobsd.sh fixes Approved by: re@ (scottl) Revision Changes Path 1.7.2.3.2.1 +12 -4 src/tools/tools/nanobsd/nanobsd.sh From owner-cvs-src@FreeBSD.ORG Mon Oct 17 08:20:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CF5C16A420; Mon, 17 Oct 2005 08:20:45 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A54C43D4C; Mon, 17 Oct 2005 08:20:45 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9H8KiM7038815; Mon, 17 Oct 2005 08:20:45 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9H8KiHA038814; Mon, 17 Oct 2005 08:20:44 GMT (envelope-from imp) Message-Id: <200510170820.j9H8KiHA038814@repoman.freebsd.org> From: Warner Losh Date: Mon, 17 Oct 2005 08:20:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/exca exca.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 08:20:45 -0000 imp 2005-10-17 08:20:44 UTC FreeBSD src repository Modified files: sys/dev/exca exca.c Log: Minor commentary correction Revision Changes Path 1.22 +3 -3 src/sys/dev/exca/exca.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 11:31:12 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D7BD616A41F; Mon, 17 Oct 2005 11:31:12 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc12.comcast.net (rwcrmhc14.comcast.net [216.148.227.89]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0930143D49; Mon, 17 Oct 2005 11:31:11 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-135.hsd1.ma.comcast.net ([24.147.19.135]) by comcast.net (rwcrmhc14) with ESMTP id <2005101711311001400kkt0re>; Mon, 17 Oct 2005 11:31:11 +0000 Received: from c-24-147-19-135.hsd1.ma.comcast.net (localhost.127.in-addr.arpa [127.0.0.1]) by c-24-147-19-135.hsd1.ma.comcast.net (8.13.4/8.13.1) with ESMTP id j9HBVAbr003008; Mon, 17 Oct 2005 07:31:10 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-135.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-135.hsd1.ma.comcast.net (8.13.4/8.13.1/Submit) id j9HBVARY003007; Mon, 17 Oct 2005 07:31:10 -0400 (EDT) (envelope-from rodrigc) Date: Mon, 17 Oct 2005 07:31:09 -0400 From: Craig Rodrigues To: Gleb Smirnoff Message-ID: <20051017113109.GA2986@crodrigues.org> References: <200510170327.j9H3RZeB020269@repoman.freebsd.org> <20051017064447.GN14542@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051017064447.GN14542@cell.sick.ru> User-Agent: Mutt/1.4.2.1i Cc: Craig Rodrigues , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 11:31:13 -0000 On Mon, Oct 17, 2005 at 10:44:47AM +0400, Gleb Smirnoff wrote: > C> This eliminates KASSERTs in GEOM if we accidentally mount an audio CD > C> as a cd9660 filesystem. > > Thanks for fixing this! I think it deserves to be merged to 6.0-RELEASE. > The operating system that panics on attempt to mount an audio CD looks funny. I think it is too late for merging this to 6.0-RELEASE and don't want this to hold up the release. It can be merged to RELENG_6 after the release. KASSERT() is only defined if you have INVARIANTS set, so it is not going to cause panics for the default kernel config for 6.0-RELEASE . -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Mon Oct 17 12:20:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 858B716A41F; Mon, 17 Oct 2005 12:20:06 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B17943D46; Mon, 17 Oct 2005 12:20:06 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HCK6DR055669; Mon, 17 Oct 2005 12:20:06 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HCK5QB055668; Mon, 17 Oct 2005 12:20:05 GMT (envelope-from tjr) Message-Id: <200510171220.j9HCK5QB055668@repoman.freebsd.org> From: "Tim J. Robbins" Date: Mon, 17 Oct 2005 12:20:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/cpio/lib argp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 12:20:06 -0000 tjr 2005-10-17 12:20:05 UTC FreeBSD src repository Modified files: contrib/cpio/lib argp.h Log: In __option_is_short(), avoid calling isprint() on key characters outside the range allowed by that function, resulting in undefined behaviour. Our undefined behaviour in multibyte locales happened to differ from glibc's, resulting in errors parsing option strings. Obtained from: Corinna Vinschen (Red Hat) Revision Changes Path 1.2 +3 -1 src/contrib/cpio/lib/argp.h From owner-cvs-src@FreeBSD.ORG Mon Oct 17 13:25:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19E2616A41F; Mon, 17 Oct 2005 13:25:47 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5696843D49; Mon, 17 Oct 2005 13:25:46 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.4/8.13.4) with ESMTP id j9HDPj2q018056; Mon, 17 Oct 2005 17:25:45 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.4/8.13.4/Submit) id j9HDPjjp018055; Mon, 17 Oct 2005 17:25:45 +0400 (MSD) (envelope-from ache) Date: Mon, 17 Oct 2005 17:25:45 +0400 From: Andrey Chernov To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20051017132544.GC17920@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200510170609.j9H69ukL033245@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510170609.j9H69ukL033245@repoman.freebsd.org> User-Agent: Mutt/1.5.11 Cc: Subject: Re: cvs commit: src/share/termcap termcap.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 13:25:47 -0000 On Mon, Oct 17, 2005 at 06:09:56AM +0000, Andrey A. Chernov wrote: > xterm-basic: > 1) use standard vt100 as/ae instead of ^N/^O which not works in real xterm Explanation from xterm author arrives: > It is luit that has a problem with ^N/^O, not "real xterm". Anyway xterm+luit is only working variant now for non-UTF-8 locale. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Oct 17 13:47:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0E1916A41F; Mon, 17 Oct 2005 13:47:31 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9000043D48; Mon, 17 Oct 2005 13:47:31 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HDlVv5066710; Mon, 17 Oct 2005 13:47:31 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HDlVvc066709; Mon, 17 Oct 2005 13:47:31 GMT (envelope-from suz) Message-Id: <200510171347.j9HDlVvc066709@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Mon, 17 Oct 2005 13:47:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 ip6_mroute.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 13:47:32 -0000 suz 2005-10-17 13:47:31 UTC FreeBSD src repository Modified files: sys/netinet6 ip6_mroute.c Log: fixed a kernel crash when IPv6 PIM-SM routing is enabled and a PIM register message is received Obtained from: KAME MFC After: 3 days Revision Changes Path 1.34 +17 -9 src/sys/netinet6/ip6_mroute.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 14:27:41 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C09B16A41F; Mon, 17 Oct 2005 14:27:41 +0000 (GMT) (envelope-from philip@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1023A43D73; Mon, 17 Oct 2005 14:27:38 +0000 (GMT) (envelope-from philip@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HERbci070811; Mon, 17 Oct 2005 14:27:37 GMT (envelope-from philip@repoman.freebsd.org) Received: (from philip@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HERbfP070810; Mon, 17 Oct 2005 14:27:37 GMT (envelope-from philip) Message-Id: <200510171427.j9HERbfP070810@repoman.freebsd.org> From: Philip Paeps Date: Mon, 17 Oct 2005 14:27:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 14:27:41 -0000 philip 2005-10-17 14:27:37 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: Add a valuable piece of Usenet advice about storing passwords. :-) Obtained from: jpd on comp.unix.bsd.freebsd.misc Revision Changes Path 1.193 +4 -0 src/games/fortune/datfiles/fortunes From owner-cvs-src@FreeBSD.ORG Mon Oct 17 14:51:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5594716A420; Mon, 17 Oct 2005 14:51:05 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 91AFC43D5C; Mon, 17 Oct 2005 14:51:01 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HEp1Rl071900; Mon, 17 Oct 2005 14:51:01 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HEp1xE071899; Mon, 17 Oct 2005 14:51:01 GMT (envelope-from cognet) Message-Id: <200510171451.j9HEp1xE071899@repoman.freebsd.org> From: Olivier Houchard Date: Mon, 17 Oct 2005 14:51:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/xscale/i80321 i80321_timer.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 14:51:05 -0000 cognet 2005-10-17 14:51:01 UTC FreeBSD src repository Modified files: sys/arm/xscale/i80321 i80321_timer.c Log: Use the clock count register as a timecounter, as it's more accurate. Revision Changes Path 1.7 +13 -16 src/sys/arm/xscale/i80321/i80321_timer.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 15:28:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A66316A41F; Mon, 17 Oct 2005 15:28:28 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC51F43D4C; Mon, 17 Oct 2005 15:28:27 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HFSREJ073240; Mon, 17 Oct 2005 15:28:27 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HFSRbX073239; Mon, 17 Oct 2005 15:28:27 GMT (envelope-from ru) Message-Id: <200510171528.j9HFSRbX073239@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 17 Oct 2005 15:28:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pccard Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 15:28:28 -0000 ru 2005-10-17 15:28:26 UTC FreeBSD src repository Modified files: usr.sbin/pccard Makefile.inc Log: Remove now redundant NO_SHARED. Reviewed by: imp Revision Changes Path 1.10 +0 -2 src/usr.sbin/pccard/Makefile.inc From owner-cvs-src@FreeBSD.ORG Mon Oct 17 15:37:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E939816A41F; Mon, 17 Oct 2005 15:37:22 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A72D843D49; Mon, 17 Oct 2005 15:37:22 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HFbMLg073714; Mon, 17 Oct 2005 15:37:22 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HFbMdW073713; Mon, 17 Oct 2005 15:37:22 GMT (envelope-from andre) Message-Id: <200510171537.j9HFbMdW073713@repoman.freebsd.org> From: Andre Oppermann Date: Mon, 17 Oct 2005 15:37:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 15:37:23 -0000 andre 2005-10-17 15:37:22 UTC FreeBSD src repository Modified files: usr.bin/vmstat vmstat.c usr.bin/w w.c Log: Obtain true uptime through clock_gettime(CLOCK_MONOTONIC, struct *timespec) instead of subtracting 'bootime' from 'now'. Sponsored by: TCP/IP Optimization Fundraise 2005 Revision Changes Path 1.91 +4 -16 src/usr.bin/vmstat/vmstat.c 1.59 +3 -9 src/usr.bin/w/w.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 15:51:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1FF316A41F; Mon, 17 Oct 2005 15:51:28 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6014F43D48; Mon, 17 Oct 2005 15:51:28 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HFpSUl074365; Mon, 17 Oct 2005 15:51:28 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HFpSRY074364; Mon, 17 Oct 2005 15:51:28 GMT (envelope-from jkim) Message-Id: <200510171551.j9HFpSRY074364@repoman.freebsd.org> From: Jung-uk Kim Date: Mon, 17 Oct 2005 15:51:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 15:51:28 -0000 jkim 2005-10-17 15:51:28 UTC FreeBSD src repository Modified files: sys/amd64/amd64 identcpu.c sys/i386/i386 identcpu.c Log: Split displaying number of physical and logical cores. Revision Changes Path 1.139 +3 -2 src/sys/amd64/amd64/identcpu.c 1.148 +3 -2 src/sys/i386/i386/identcpu.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 15:56:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2FBE16A41F; Mon, 17 Oct 2005 15:56:26 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B009943D46; Mon, 17 Oct 2005 15:56:26 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HFuQ18074665; Mon, 17 Oct 2005 15:56:26 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HFuQJv074664; Mon, 17 Oct 2005 15:56:26 GMT (envelope-from ru) Message-Id: <200510171556.j9HFuQJv074664@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 17 Oct 2005 15:56:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/make parse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 15:56:27 -0000 ru 2005-10-17 15:56:26 UTC FreeBSD src repository Modified files: usr.bin/make parse.c Log: Make sure that files included using ".include " are really looked for in the system make file directory or in the specified -m paths instead of always looking in the other -I and .PATH specified paths. (Commit log shamelessly stolen from NetBSD.) Reviewed by: yar Revision Changes Path 1.110 +16 -17 src/usr.bin/make/parse.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 16:01:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CFBA16A41F; Mon, 17 Oct 2005 16:01:03 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5B1543D48; Mon, 17 Oct 2005 16:01:02 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9HG8nd3075345; Mon, 17 Oct 2005 12:08:49 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: "David E. O'Brien" Date: Mon, 17 Oct 2005 12:00:47 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> In-Reply-To: <200510160858.j9G8wR9v045670@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510171200.49522.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1139/Sun Oct 16 20:30:04 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 16:01:03 -0000 On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > obrien 2005-10-16 08:58:27 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 identcpu.c > sys/i386/i386 identcpu.c > Log: > For AMD processors, nullify CPUID.HTT. FreeBSD has no need for > the information it conveys, and it is only confusing people. This > fixes incorrect output in the previous commit. > > Revision Changes Path > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > 1.147 +9 -0 src/sys/i386/i386/identcpu.c Have you verified you are not breaking `logical_cpus' in mp_machdep.c by doing this? Show me the 'incorrect' output or please back it out. Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Mon Oct 17 16:51:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF28716A41F; Mon, 17 Oct 2005 16:51:06 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE4F843D48; Mon, 17 Oct 2005 16:51:06 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HGp6ql084713; Mon, 17 Oct 2005 16:51:06 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HGp6sS084712; Mon, 17 Oct 2005 16:51:06 GMT (envelope-from imp) Message-Id: <200510171651.j9HGp6sS084712@repoman.freebsd.org> From: Warner Losh Date: Mon, 17 Oct 2005 16:51:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/syslogd syslogd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 16:51:07 -0000 imp 2005-10-17 16:51:06 UTC FreeBSD src repository Modified files: usr.sbin/syslogd syslogd.c Log: style(9) nitlet: foo() { } to foo() { } Revision Changes Path 1.148 +2 -1 src/usr.sbin/syslogd/syslogd.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 17:01:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 991D916A421; Mon, 17 Oct 2005 17:01:55 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D187643D5D; Mon, 17 Oct 2005 17:01:54 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HH1sjp085250; Mon, 17 Oct 2005 17:01:54 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HH1sq6085249; Mon, 17 Oct 2005 17:01:54 GMT (envelope-from bz) Message-Id: <200510171701.j9HH1sq6085249@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Mon, 17 Oct 2005 17:01:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/examples/etc make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 17:01:55 -0000 bz 2005-10-17 17:01:54 UTC FreeBSD src repository Modified files: share/examples/etc make.conf Log: Document that changes to nsswitch.conf might be needed when compiling with NO_NIS. [ also see make.conf(5) and nsswitch.conf(5) ] Reviewed by: ru Requested by: dougb (and bin/87221) MFC: 22 days Revision Changes Path 1.267 +3 -1 src/share/examples/etc/make.conf From owner-cvs-src@FreeBSD.ORG Mon Oct 17 17:28:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 30A0516A41F; Mon, 17 Oct 2005 17:28:33 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E96243D46; Mon, 17 Oct 2005 17:28:29 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9HHSSBa097429; Mon, 17 Oct 2005 10:28:28 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9HHSSEh097428; Mon, 17 Oct 2005 10:28:28 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 10:28:28 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051017172828.GB97278@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171200.49522.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 17:28:33 -0000 On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > obrien 2005-10-16 08:58:27 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/amd64 identcpu.c > > sys/i386/i386 identcpu.c > > Log: > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need for > > the information it conveys, and it is only confusing people. This > > fixes incorrect output in the previous commit. > > > > Revision Changes Path > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > Have you verified you are not breaking `logical_cpus' in mp_machdep.c > by doing this? > > Show me the 'incorrect' output or please back it out. CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz K8-class CPU) .. Physical/Logical cores: 2/2 .. FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs cpu0 (BSP): APIC ID: 0 cpu1 (AP): APIC ID: 1 cpu2 (AP): APIC ID: 2 cpu3 (AP): APIC ID: 3 I sure as hell have 4 physical cores and no logical cores. I do not think you fully understand what AMD dual-core CPU's. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 17 17:53:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3DE516A421; Mon, 17 Oct 2005 17:53:18 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F6B343D4C; Mon, 17 Oct 2005 17:53:18 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HHrIl3092342; Mon, 17 Oct 2005 17:53:18 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HHrIFG092341; Mon, 17 Oct 2005 17:53:18 GMT (envelope-from jhb) Message-Id: <200510171753.j9HHrIFG092341@repoman.freebsd.org> From: John Baldwin Date: Mon, 17 Oct 2005 17:53:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man3 queue.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 17:53:18 -0000 jhb 2005-10-17 17:53:17 UTC FreeBSD src repository Modified files: share/man/man3 queue.3 Log: Remove a spurious newline. The TAILQ_INIT() is part of the 'faster tailq deletion' example. MFC after: 1 week Revision Changes Path 1.36 +0 -1 src/share/man/man3/queue.3 From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:17:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1700B16A41F; Mon, 17 Oct 2005 18:17:53 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 92C7643D45; Mon, 17 Oct 2005 18:17:52 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9HIPcVm079850; Mon, 17 Oct 2005 14:25:38 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: obrien@FreeBSD.org Date: Mon, 17 Oct 2005 14:17:33 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> In-Reply-To: <20051017172828.GB97278@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510171417.38095.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1139/Sun Oct 16 20:30:04 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:17:53 -0000 On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > obrien 2005-10-16 08:58:27 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/amd64/amd64 identcpu.c > > > sys/i386/i386 identcpu.c > > > Log: > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > for the information it conveys, and it is only confusing > > > people. This fixes incorrect output in the previous commit. > > > > > > Revision Changes Path > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > Have you verified you are not breaking `logical_cpus' in > > mp_machdep.c by doing this? > > > > Show me the 'incorrect' output or please back it out. > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > K8-class CPU) .. > Physical/Logical cores: 2/2 > .. > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > cpu0 (BSP): APIC ID: 0 > cpu1 (AP): APIC ID: 1 > cpu2 (AP): APIC ID: 2 > cpu3 (AP): APIC ID: 3 > > I sure as hell have 4 physical cores and no logical cores. The information is per-CPU. You have two CPUs with dual cores, which means the given information is correct. Please back it out. > I do not think you fully understand what AMD dual-core CPU's. Oh, please... Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:31:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1730A16A41F; Mon, 17 Oct 2005 18:31:00 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5AA1343D45; Mon, 17 Oct 2005 18:30:59 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9HIckac080265; Mon, 17 Oct 2005 14:38:46 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: obrien@FreeBSD.org Date: Mon, 17 Oct 2005 14:30:40 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> In-Reply-To: <20051017172828.GB97278@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510171430.46431.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1139/Sun Oct 16 20:30:04 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:31:00 -0000 On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > obrien 2005-10-16 08:58:27 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/amd64/amd64 identcpu.c > > > sys/i386/i386 identcpu.c > > > Log: > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > for the information it conveys, and it is only confusing > > > people. This fixes incorrect output in the previous commit. > > > > > > Revision Changes Path > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > Have you verified you are not breaking `logical_cpus' in > > mp_machdep.c by doing this? You still owe us this information. > > Show me the 'incorrect' output or please back it out. > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > K8-class CPU) .. > Physical/Logical cores: 2/2 Just for the people who still don't understand: Physical/Logical cores: 1/2 -> single core with HTT Physical/Logical cores: 2/2 -> dual core without HTT Physical/Logical cores: 2/4 -> dual core with HTT BTW, I just committed the following because this commit broke it: http://docs.freebsd.org/cgi/mid.cgi?200510171551.j9HFpSRY074364 Now the per-CPU information is like this: Logical cores: 2 -> single core with HTT Physical cores: 2 -> dual core without HTT Physical cores: 2 -> dual core with HTT (two lines) Logical cores: 4 > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > cpu0 (BSP): APIC ID: 0 > cpu1 (AP): APIC ID: 1 > cpu2 (AP): APIC ID: 2 > cpu3 (AP): APIC ID: 3 This is NOT per-CPU info. Jung-uk Kim > I sure as hell have 4 physical cores and no logical cores. I do > not think you fully understand what AMD dual-core CPU's. From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:31:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB03116A41F; Mon, 17 Oct 2005 18:31:37 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 91EF343D46; Mon, 17 Oct 2005 18:31:37 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HIVb3i095228; Mon, 17 Oct 2005 18:31:37 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HIVbDR095227; Mon, 17 Oct 2005 18:31:37 GMT (envelope-from cognet) Message-Id: <200510171831.j9HIVbDR095227@repoman.freebsd.org> From: Olivier Houchard Date: Mon, 17 Oct 2005 18:31:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf Makefile.arm X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:31:38 -0000 cognet 2005-10-17 18:31:37 UTC FreeBSD src repository Modified files: sys/conf Makefile.arm Log: Strip the $a, $t and $d symbols if we're using DDB. There are useless and confusing in a backtrace. Revision Changes Path 1.13 +3 -0 src/sys/conf/Makefile.arm From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:31:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A06816A420; Mon, 17 Oct 2005 18:31:44 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71A4743D49; Mon, 17 Oct 2005 18:31:43 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9HIVhO2000653; Mon, 17 Oct 2005 11:31:43 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9HIVhFO000651; Mon, 17 Oct 2005 11:31:43 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 11:31:39 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051017183139.GA97488@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171417.38095.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:31:44 -0000 On Mon, Oct 17, 2005 at 02:17:33PM -0400, Jung-uk Kim wrote: > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > > obrien 2005-10-16 08:58:27 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/amd64/amd64 identcpu.c > > > > sys/i386/i386 identcpu.c > > > > Log: > > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > > for the information it conveys, and it is only confusing > > > > people. This fixes incorrect output in the previous commit. > > > > > > > > Revision Changes Path > > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > > > Have you verified you are not breaking `logical_cpus' in > > > mp_machdep.c by doing this? > > > > > > Show me the 'incorrect' output or please back it out. > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > K8-class CPU) .. > > Physical/Logical cores: 2/2 > > .. > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > cpu0 (BSP): APIC ID: 0 > > cpu1 (AP): APIC ID: 1 > > cpu2 (AP): APIC ID: 2 > > cpu3 (AP): APIC ID: 3 > > > > I sure as hell have 4 physical cores and no logical cores. > > The information is per-CPU. You have two CPUs with dual cores, which > means the given information is correct. Please back it out. No, this given information is wrong. AMD does not have HyperThreading. You are treating it as if it does. The rest of the kernel also should not be trying to treat AMD dual-core as HyperThreading. The only thing that should care in the freebsd kernel right now about AMD dual-core is PowerNow! support. It probably needs to know what cores match physical cores so it can proper work in a multi-socket system. Please point to what part of `logical_cpus' in mp_machdep.c you feel is broken by this change. > > I do not think you fully understand what AMD dual-core CPU's. > > Oh, please... The code you committed suggest this... -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:35:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 261EB16A41F; Mon, 17 Oct 2005 18:35:58 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D06AC43D46; Mon, 17 Oct 2005 18:35:57 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HIZvQ9095422; Mon, 17 Oct 2005 18:35:57 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HIZvng095421; Mon, 17 Oct 2005 18:35:57 GMT (envelope-from jhb) Message-Id: <200510171835.j9HIZvng095421@repoman.freebsd.org> From: John Baldwin Date: Mon, 17 Oct 2005 18:35:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:35:58 -0000 jhb 2005-10-17 18:35:57 UTC FreeBSD src repository Modified files: sys/amd64/conf NOTES Log: Another bit of sx(4) removal. Revision Changes Path 1.45 +0 -3 src/sys/amd64/conf/NOTES From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:38:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 776FC16A41F for ; Mon, 17 Oct 2005 18:38:03 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [204.14.90.61]) by mx1.FreeBSD.org (Postfix) with SMTP id 2311D43D58 for ; Mon, 17 Oct 2005 18:37:57 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 37374 invoked by uid 399); 17 Oct 2005 18:37:56 -0000 Received: from localhost (HELO ?192.168.1.102?) (dougb@dougbarton.net@127.0.0.1) by localhost with SMTP; 17 Oct 2005 18:37:56 -0000 Message-ID: <4353EF7D.6070600@FreeBSD.org> Date: Mon, 17 Oct 2005 11:37:49 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.7 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <200510171701.j9HH1sq6085249@repoman.freebsd.org> In-Reply-To: <200510171701.j9HH1sq6085249@repoman.freebsd.org> X-Enigmail-Version: 0.93.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples/etc make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:38:03 -0000 Bjoern A. Zeeb wrote: > bz 2005-10-17 17:01:54 UTC > > FreeBSD src repository > > Modified files: > share/examples/etc make.conf > Log: > Document that changes to nsswitch.conf might be needed when > compiling with NO_NIS. > [ also see make.conf(5) and nsswitch.conf(5) ] > > Reviewed by: ru > Requested by: dougb (and bin/87221) > MFC: 22 days > > Revision Changes Path > 1.267 +3 -1 src/share/examples/etc/make.conf > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/share/examples/etc/make.conf.diff?&r1=1.266&r2=1.267&f=h > I thank you, and my log files (which are no longer swelling) thank you. :) Doug -- This .signature sanitized for your protection From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:38:14 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD5F116A42D for ; Mon, 17 Oct 2005 18:38:14 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [204.14.90.61]) by mx1.FreeBSD.org (Postfix) with SMTP id 4BD7643D5F for ; Mon, 17 Oct 2005 18:38:07 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 37374 invoked by uid 399); 17 Oct 2005 18:37:56 -0000 Received: from localhost (HELO ?192.168.1.102?) (dougb@dougbarton.net@127.0.0.1) by localhost with SMTP; 17 Oct 2005 18:37:56 -0000 Message-ID: <4353EF7D.6070600@FreeBSD.org> Date: Mon, 17 Oct 2005 11:37:49 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.7 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <200510171701.j9HH1sq6085249@repoman.freebsd.org> In-Reply-To: <200510171701.j9HH1sq6085249@repoman.freebsd.org> X-Enigmail-Version: 0.93.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples/etc make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:38:16 -0000 Bjoern A. Zeeb wrote: > bz 2005-10-17 17:01:54 UTC > > FreeBSD src repository > > Modified files: > share/examples/etc make.conf > Log: > Document that changes to nsswitch.conf might be needed when > compiling with NO_NIS. > [ also see make.conf(5) and nsswitch.conf(5) ] > > Reviewed by: ru > Requested by: dougb (and bin/87221) > MFC: 22 days > > Revision Changes Path > 1.267 +3 -1 src/share/examples/etc/make.conf > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/share/examples/etc/make.conf.diff?&r1=1.266&r2=1.267&f=h > I thank you, and my log files (which are no longer swelling) thank you. :) Doug -- This .signature sanitized for your protection From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:50:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0BB1816A423; Mon, 17 Oct 2005 18:50:26 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EA8243D53; Mon, 17 Oct 2005 18:50:25 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9HIoOWU001149; Mon, 17 Oct 2005 11:50:24 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9HIoOjq001148; Mon, 17 Oct 2005 11:50:24 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 11:50:24 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051017185024.GB97488@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171430.46431.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171430.46431.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:50:26 -0000 On Mon, Oct 17, 2005 at 02:30:40PM -0400, Jung-uk Kim wrote: > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > > obrien 2005-10-16 08:58:27 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/amd64/amd64 identcpu.c > > > > sys/i386/i386 identcpu.c > > > > Log: > > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > > for the information it conveys, and it is only confusing > > > > people. This fixes incorrect output in the previous commit. > > > > > > > > Revision Changes Path > > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > > > Have you verified you are not breaking `logical_cpus' in > > > mp_machdep.c by doing this? > > You still owe us this information. > > > > Show me the 'incorrect' output or please back it out. > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > K8-class CPU) .. > > Physical/Logical cores: 2/2 > > Just for the people who still don't understand: > > Physical/Logical cores: 1/2 -> single core with HTT > Physical/Logical cores: 2/2 -> dual core without HTT > Physical/Logical cores: 2/4 -> dual core with HTT > > BTW, I just committed the following because this commit broke it: > http://docs.freebsd.org/cgi/mid.cgi?200510171551.j9HFpSRY074364 > > Now the per-CPU information is like this: > > Logical cores: 2 -> single core with HTT > Physical cores: 2 -> dual core without HTT This is the AMD case - this is what I [tried to] fixed. The correct output for my system is "Physical cores: 4". This is also given by: FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs so what additional information is being given to the user? A 1P/2C Athlon64 X2 system is identical to a 2P/1C Athlon-MP system. It is purely SMP and there is no preference to scheduling on either core. And one gets full performance by scheduling on both cores at the same time. > Physical cores: 2 -> dual core with HTT (two lines) > Logical cores: 4 This is the Intel case - my commit does not touch this. > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > cpu0 (BSP): APIC ID: 0 > > cpu1 (AP): APIC ID: 1 > > cpu2 (AP): APIC ID: 2 > > cpu3 (AP): APIC ID: 3 > > This is NOT per-CPU info. Please explain what you are trying to achive. AMD sets CPUID.HTT solely for the benfit of licensing issues of Microsoft products and Red Hat. The FreeBSD license does not restrict the number of CPU's one can use. The FreeBSD kernel should pretend CPUID.HTT isn't set. In fact some Opteron BIOS's cause CPUID.HTT to not be set when using dual-core CPU's. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:51:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B186416A41F; Mon, 17 Oct 2005 18:51:47 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id E74F043D53; Mon, 17 Oct 2005 18:51:46 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9HIxY34081089; Mon, 17 Oct 2005 14:59:34 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: obrien@FreeBSD.org Date: Mon, 17 Oct 2005 14:51:31 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> In-Reply-To: <20051017183139.GA97488@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510171451.34478.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1139/Sun Oct 16 20:30:04 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:51:48 -0000 On Monday 17 October 2005 02:31 pm, David O'Brien wrote: > On Mon, Oct 17, 2005 at 02:17:33PM -0400, Jung-uk Kim wrote: > > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > > > obrien 2005-10-16 08:58:27 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/amd64/amd64 identcpu.c > > > > > sys/i386/i386 identcpu.c > > > > > Log: > > > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no > > > > > need for the information it conveys, and it is only > > > > > confusing people. This fixes incorrect output in the > > > > > previous commit. > > > > > > > > > > Revision Changes Path > > > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > > > > > Have you verified you are not breaking `logical_cpus' in > > > > mp_machdep.c by doing this? > > > > > > > > Show me the 'incorrect' output or please back it out. > > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > > K8-class CPU) .. > > > Physical/Logical cores: 2/2 > > > .. > > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > > cpu0 (BSP): APIC ID: 0 > > > cpu1 (AP): APIC ID: 1 > > > cpu2 (AP): APIC ID: 2 > > > cpu3 (AP): APIC ID: 3 > > > > > > I sure as hell have 4 physical cores and no logical cores. > > > > The information is per-CPU. You have two CPUs with dual cores, > > which means the given information is correct. Please back it > > out. > > No, this given information is wrong. AMD does not have > HyperThreading. You are treating it as if it does. ??? Did I ever mention Hyper-Threading here? I actually replaced misleading 'Hyperthreading' with 'Physical/Logical cores.' > The rest of the kernel also should not be trying to treat AMD > dual-core as HyperThreading. Sigh... Sure it should not. That's why there is `hyperthreading_cpus' for. > The only thing that should care in the freebsd kernel right now > about AMD dual-core is PowerNow! support. It probably needs to > know what cores match physical cores so it can proper work in a > multi-socket system. > > Please point to what part of `logical_cpus' in mp_machdep.c you > feel is broken by this change. > > > > I do not think you fully understand what AMD dual-core CPU's. > > > > Oh, please... > > The code you committed suggest this... I will just shut up and code if you 'feel' that I am not capable. Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Mon Oct 17 18:52:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8758116A41F; Mon, 17 Oct 2005 18:52:51 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C88243D55; Mon, 17 Oct 2005 18:52:51 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HIqpmK096051; Mon, 17 Oct 2005 18:52:51 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HIqpgk096050; Mon, 17 Oct 2005 18:52:51 GMT (envelope-from jhb) Message-Id: <200510171852.j9HIqpgk096050@repoman.freebsd.org> From: John Baldwin Date: Mon, 17 Oct 2005 18:52:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/share/man/man9 Makefile critical_enter.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:52:51 -0000 jhb 2005-10-17 18:52:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) share/man/man9 Makefile critical_enter.9 Log: MF6: Update critical(9) with recently reality. Approved by: re (kensmith) Revision Changes Path 1.260.2.3.2.1 +2 -4 src/share/man/man9/Makefile 1.7.16.1 +8 -46 src/share/man/man9/critical_enter.9 From owner-cvs-src@FreeBSD.ORG Mon Oct 17 19:01:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60F9816A41F; Mon, 17 Oct 2005 19:01:54 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13ED243D46; Mon, 17 Oct 2005 19:01:54 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HJ1r80096427; Mon, 17 Oct 2005 19:01:53 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HJ1rVI096426; Mon, 17 Oct 2005 19:01:53 GMT (envelope-from jhb) Message-Id: <200510171901.j9HJ1rVI096426@repoman.freebsd.org> From: John Baldwin Date: Mon, 17 Oct 2005 19:01:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc rc.subr X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 19:01:54 -0000 jhb 2005-10-17 19:01:53 UTC FreeBSD src repository Modified files: etc rc.subr Log: Allow the process name to be in square brackets ([]) in _find_processes(). PR: conf/82430 Submitted by: Pavel Volkov pol at iib dot ru MFC after: 1 week Revision Changes Path 1.39 +1 -1 src/etc/rc.subr From owner-cvs-src@FreeBSD.ORG Mon Oct 17 19:08:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03CE716A422; Mon, 17 Oct 2005 19:08:53 +0000 (GMT) (envelope-from eta@lclark.edu) Received: from leguin.anholt.net (69-30-77-85.dq1sn.easystreet.com [69.30.77.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E32B43D46; Mon, 17 Oct 2005 19:08:52 +0000 (GMT) (envelope-from eta@lclark.edu) Received: from leguin.anholt.net (localhost [127.0.0.1]) by leguin.anholt.net (8.13.4/8.13.1) with ESMTP id j9HJ8pMb056788; Mon, 17 Oct 2005 12:08:51 -0700 (PDT) (envelope-from eta@lclark.edu) Received: (from anholt@localhost) by leguin.anholt.net (8.13.4/8.13.1/Submit) id j9HJ8ofd056787; Mon, 17 Oct 2005 12:08:50 -0700 (PDT) (envelope-from eta@lclark.edu) X-Authentication-Warning: leguin.anholt.net: anholt set sender to eta@lclark.edu using -f From: Eric Anholt To: obrien@FreeBSD.org In-Reply-To: <20051017183139.GA97488@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-9SYBbLnfPFnByFVdHVVc" Date: Mon, 17 Oct 2005 12:08:50 -0700 Message-Id: <1129576130.1152.30.camel@leguin> Mime-Version: 1.0 X-Mailer: Evolution 2.3.8 FreeBSD GNOME Team Port Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 19:08:53 -0000 --=-9SYBbLnfPFnByFVdHVVc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2005-10-17 at 11:31 -0700, David O'Brien wrote: > On Mon, Oct 17, 2005 at 02:17:33PM -0400, Jung-uk Kim wrote: > > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > > > obrien 2005-10-16 08:58:27 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/amd64/amd64 identcpu.c > > > > > sys/i386/i386 identcpu.c > > > > > Log: > > > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > > > for the information it conveys, and it is only confusing > > > > > people. This fixes incorrect output in the previous commit. > > > > > > > > > > Revision Changes Path > > > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > > > > > Have you verified you are not breaking `logical_cpus' in > > > > mp_machdep.c by doing this? > > > > > > > > Show me the 'incorrect' output or please back it out. > > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > > K8-class CPU) .. > > > Physical/Logical cores: 2/2 > > > .. > > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > > cpu0 (BSP): APIC ID: 0 > > > cpu1 (AP): APIC ID: 1 > > > cpu2 (AP): APIC ID: 2 > > > cpu3 (AP): APIC ID: 3 > > > > > > I sure as hell have 4 physical cores and no logical cores. > >=20 > > The information is per-CPU. You have two CPUs with dual cores, which=20 > > means the given information is correct. Please back it out. >=20 > No, this given information is wrong. AMD does not have HyperThreading. > You are treating it as if it does. The rest of the kernel also should > not be trying to treat AMD dual-core as HyperThreading. >=20 > The only thing that should care in the freebsd kernel right now about AMD > dual-core is PowerNow! support. It probably needs to know what cores > match physical cores so it can proper work in a multi-socket system. >=20 > Please point to what part of `logical_cpus' in mp_machdep.c you feel is > broken by this change. >=20 > > > I do not think you fully understand what AMD dual-core CPU's. > >=20 > > Oh, please... >=20 > The code you committed suggest this... Apparently David interpeted the "Physical/Logical cores: 2/2" as two physical cores plus two additional logical cores. I didn't, but I could see how (since this per-cpu information printed isn't actually printed per cpu) it could be interpreted this way on a dual-cpu system. I think that this would be useful information to be printing in general (not just on really-HTT systems), since it would clarify what seeing "cpu[0-3]: APIC ID..." printed out actually means when you're just taking a look at some system and wondering how many cores it has. How hard would it be to do the cpuid per-cpu? Would it be sane to assume that the cpuid output of the other CPUs will be the same (pretty sure that's not the case), or at least that the multicore and HTT info will be the same? And would there be a better wording to prevent confusion? --=20 Eric Anholt eta@lclark.edu http://people.freebsd.org/~anholt/ anholt@FreeBSD.org --=-9SYBbLnfPFnByFVdHVVc Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBDU/bCHUdvYGzw6vcRAgNLAKCH6+eP95MFdBsPg+majRxifvUymgCfRYtX U5TZyXKviG6NotRSJD7e0WQ= =OgWd -----END PGP SIGNATURE----- --=-9SYBbLnfPFnByFVdHVVc-- From owner-cvs-src@FreeBSD.ORG Mon Oct 17 19:14:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84D0516A420; Mon, 17 Oct 2005 19:14:27 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2CFAE43D45; Mon, 17 Oct 2005 19:14:27 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9HJEQUE014943; Mon, 17 Oct 2005 12:14:26 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9HJEQFA014942; Mon, 17 Oct 2005 12:14:26 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 12:14:26 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051017191426.GC97488@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <200510171451.34478.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171451.34478.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 19:14:27 -0000 On Mon, Oct 17, 2005 at 02:51:31PM -0400, Jung-uk Kim wrote: > On Monday 17 October 2005 02:31 pm, David O'Brien wrote: > > On Mon, Oct 17, 2005 at 02:17:33PM -0400, Jung-uk Kim wrote: > > > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > > > K8-class CPU) .. > > > > Physical/Logical cores: 2/2 > > > > .. > > > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs .. > > > The information is per-CPU. You have two CPUs with dual cores, > > > which means the given information is correct. Please back it > > > out. > > > > No, this given information is wrong. AMD does not have > > HyperThreading. You are treating it as if it does. > > ??? Did I ever mention Hyper-Threading here? I actually replaced > misleading 'Hyperthreading' with 'Physical/Logical cores.' What else is x86/x86-64 "Physical/Logical cores" other than HyperThreading? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 17 19:14:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3650016A421; Mon, 17 Oct 2005 19:14:54 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F7FC43D48; Mon, 17 Oct 2005 19:14:53 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9HJMeXF081827; Mon, 17 Oct 2005 15:22:40 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: obrien@FreeBSD.org Date: Mon, 17 Oct 2005 15:14:37 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171430.46431.jkim@FreeBSD.org> <20051017185024.GB97488@dragon.NUXI.org> In-Reply-To: <20051017185024.GB97488@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510171514.39881.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1139/Sun Oct 16 20:30:04 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 19:14:54 -0000 On Monday 17 October 2005 02:50 pm, David O'Brien wrote: > On Mon, Oct 17, 2005 at 02:30:40PM -0400, Jung-uk Kim wrote: > > Just for the people who still don't understand: > > > > Physical/Logical cores: 1/2 -> single core with HTT > > Physical/Logical cores: 2/2 -> dual core without HTT > > Physical/Logical cores: 2/4 -> dual core with HTT > > > > BTW, I just committed the following because this commit broke it: > > http://docs.freebsd.org/cgi/mid.cgi?200510171551.j9HFpSRY074364 > > > > Now the per-CPU information is like this: > > > > Logical cores: 2 -> single core with HTT > > Physical cores: 2 -> dual core without HTT > > This is the AMD case - this is what I [tried to] fixed. > The correct output for my system is "Physical cores: 4". Wrong. That's not per-CPU information. > This is also given by: > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > so what additional information is being given to the user? Because users want to know whether they are using two dual-core CPUs or four CPUs. It is NOT redundant information. > A 1P/2C Athlon64 X2 system is identical to a 2P/1C Athlon-MP > system. It is purely SMP and there is no preference to scheduling > on either core. And one gets full performance by scheduling on both > cores at the same time. Sigh... No, they are NOT the same. 2P/1C can be configured as ccNUMA. 1P/2C cannot, i.e., they share the memory controller. > > Physical cores: 2 -> dual core with HTT (two lines) > > Logical cores: 4 > > This is the Intel case - my commit does not touch this. > > > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > > cpu0 (BSP): APIC ID: 0 > > > cpu1 (AP): APIC ID: 1 > > > cpu2 (AP): APIC ID: 2 > > > cpu3 (AP): APIC ID: 3 > > > > This is NOT per-CPU info. > > Please explain what you are trying to achive. AMD sets CPUID.HTT > solely for the benfit of licensing issues of Microsoft products and > Red Hat. The FreeBSD license does not restrict the number of CPU's > one can use. The FreeBSD kernel should pretend CPUID.HTT isn't set. What I am trying to achive is simple: I want to know how many physical and/or logical cores I have in one CPU package. It has nothing to do with Hyper-Threading in fact. > In fact some Opteron BIOS's cause CPUID.HTT to not be set when > using dual-core CPU's. That's broken BIOS by the spec. AMD64 Architecture Programmer's Manual Volume 3: General-Purpose and System Instructions: http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/24594.pdf Logical Processor Count, Page 122: 'If the value of the CMP legacy bit is 1, then the value of the HTT bit indicates the presence of multiple cores per package and the value of the logical processor count field indicates the number of cores per package.' Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Mon Oct 17 19:20:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDED916A422; Mon, 17 Oct 2005 19:20:19 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1A9A43D5C; Mon, 17 Oct 2005 19:20:18 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9HJKIha015093; Mon, 17 Oct 2005 12:20:18 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9HJKI3H015092; Mon, 17 Oct 2005 12:20:18 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 12:20:18 -0700 From: "David O'Brien" To: Eric Anholt Message-ID: <20051017192018.GD97488@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1129576130.1152.30.camel@leguin> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 19:20:20 -0000 On Mon, Oct 17, 2005 at 12:08:50PM -0700, Eric Anholt wrote: > > > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > > > K8-class CPU) .. > > > > Physical/Logical cores: 2/2 > > > > .. > > > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > > > cpu0 (BSP): APIC ID: 0 > > > > cpu1 (AP): APIC ID: 1 > > > > cpu2 (AP): APIC ID: 2 > > > > cpu3 (AP): APIC ID: 3 > > Apparently David interpeted the "Physical/Logical cores: 2/2" as two > physical cores plus two additional logical cores. I didn't, but I could > see how (since this per-cpu information printed isn't actually printed > per cpu) it could be interpreted this way on a dual-cpu system. > > I think that this would be useful information to be printing in general > (not just on really-HTT systems), since it would clarify what seeing > "cpu[0-3]: APIC ID..." printed out actually means when you're just > taking a look at some system and wondering how many cores it has. I guess I just don't see why for non-Intel non-HTT systems what this information provides that already isn't printed out. The dmesg I posted shows four APIC ID's. Other than my electric company no one (people or FreeBSD SW) should care that I have dual-core CPU's. If this information doesn't provide any additional information to the viewer, we shouldn't clutter up dmesg further. On Intel HTT systems, the output could in fact be useful. Not having access to a dual-core HTT Intel system right now, I'm not qualified to say. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 17 19:45:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F07916A422; Mon, 17 Oct 2005 19:45:25 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABCAB43D46; Mon, 17 Oct 2005 19:45:24 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9HJjOSa015509; Mon, 17 Oct 2005 12:45:24 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9HJjOnl015508; Mon, 17 Oct 2005 12:45:24 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 12:45:24 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051017194523.GE97488@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171430.46431.jkim@FreeBSD.org> <20051017185024.GB97488@dragon.NUXI.org> <200510171514.39881.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171514.39881.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 19:45:25 -0000 On Mon, Oct 17, 2005 at 03:14:37PM -0400, Jung-uk Kim wrote: > On Monday 17 October 2005 02:50 pm, David O'Brien wrote: > > This is also given by: > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > > > so what additional information is being given to the user? > > Because users want to know whether they are using two dual-core CPUs > or four CPUs. It is NOT redundant information. What part of this don't they get from: "CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU)" The Athlon64 X2 version is: "AMD Athlon(tm) 64 X2 Dual Core Processor 4800+" > > A 1P/2C Athlon64 X2 system is identical to a 2P/1C Athlon-MP > > system. It is purely SMP and there is no preference to scheduling > > on either core. And one gets full performance by scheduling on both > > cores at the same time. > > Sigh... No, they are NOT the same. Yes they are - Athlon-MP is a northbridge-based system and thus both cores share the same memory controller and have the same memory latency. > 2P/1C can be configured as > ccNUMA. 1P/2C cannot, i.e., they share the memory controller. So what?? What you are no doubt referring to is the "memory node interleave" BIOS setting. Note that K8 errata 101 has an affect that pretty much nullifies the BIOS "memory node interleave" if you have ECC DRAM scrubbing enabled. I think most want ECC scrubbing enabled for reliability. K8 errata 101 doesn't affect all Opterons, but all BIOS's I've seen are stupid and apply the errata 101 work around to all Opteron's not just those revisions affected. > > Please explain what you are trying to achive. AMD sets CPUID.HTT > > solely for the benfit of licensing issues of Microsoft products and > > Red Hat. The FreeBSD license does not restrict the number of CPU's > > one can use. The FreeBSD kernel should pretend CPUID.HTT isn't set. > > What I am trying to achive is simple: I want to know how many physical > and/or logical cores I have in one CPU package. It has nothing to do > with Hyper-Threading in fact. If the words "Dual Core" above aren't clear enough, then for AMD print out "N processors with X cores per processor". BTW, what we mean by "CPU" is vague. In AMD speak, one uses "processor" or "socket", and "cores". > > In fact some Opteron BIOS's cause CPUID.HTT to not be set when > > using dual-core CPU's. > > That's broken BIOS by the spec. Where is there a BIOS spec? We truly need one in the x86 world, but we don't have one today. BTW, some revisions of the AMD BKDG implied it was fine to have a knob in the BIOS controlling CPUID.HTT. I've seen BIOS's from Tyan and Iwill that had this knob. The explanation for the nob was to handling MS-Windows licensing. > AMD64 Architecture Programmer's Manual Volume 3: General-Purpose and > System Instructions: > http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/24594.pdf I am well aware of this document, what it says, and its purpose. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 17 19:53:20 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B19616A41F; Mon, 17 Oct 2005 19:53:20 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2525D43D86; Mon, 17 Oct 2005 19:53:16 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 17 Oct 2005 16:09:45 -0400 From: John Baldwin To: obrien@freebsd.org Date: Mon, 17 Oct 2005 15:48:55 -0400 User-Agent: KMail/1.8.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171451.34478.jkim@FreeBSD.org> <20051017191426.GC97488@dragon.NUXI.org> In-Reply-To: <20051017191426.GC97488@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510171548.57353.jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 19:53:21 -0000 On Monday 17 October 2005 03:14 pm, David O'Brien wrote: > On Mon, Oct 17, 2005 at 02:51:31PM -0400, Jung-uk Kim wrote: > > On Monday 17 October 2005 02:31 pm, David O'Brien wrote: > > > On Mon, Oct 17, 2005 at 02:17:33PM -0400, Jung-uk Kim wrote: > > > > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > > > > K8-class CPU) .. > > > > > Physical/Logical cores: 2/2 > > > > > .. > > > > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > .. > > > > > The information is per-CPU. You have two CPUs with dual cores, > > > > which means the given information is correct. Please back it > > > > out. > > > > > > No, this given information is wrong. AMD does not have > > > HyperThreading. You are treating it as if it does. > > > > ??? Did I ever mention Hyper-Threading here? I actually replaced > > misleading 'Hyperthreading' with 'Physical/Logical cores.' > > What else is x86/x86-64 "Physical/Logical cores" other than > HyperThreading? A physical core? Looks like 2 physical cores with 2 logical cpus which means each core has 1 logical CPU, which is true, because your cores lack HTT support. On a dual core chip with 2 HTT's per core it would probably be 2/4, yes? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Oct 17 19:53:45 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C9B416A420; Mon, 17 Oct 2005 19:53:45 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7633C43D64; Mon, 17 Oct 2005 19:53:37 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 17 Oct 2005 16:09:45 -0400 From: John Baldwin To: Eric Anholt Date: Mon, 17 Oct 2005 15:54:44 -0400 User-Agent: KMail/1.8.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> In-Reply-To: <1129576130.1152.30.camel@leguin> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510171554.46682.jhb@freebsd.org> Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, Jung-uk Kim , obrien@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 19:53:45 -0000 On Monday 17 October 2005 03:08 pm, Eric Anholt wrote: > On Mon, 2005-10-17 at 11:31 -0700, David O'Brien wrote: > > On Mon, Oct 17, 2005 at 02:17:33PM -0400, Jung-uk Kim wrote: > > > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > > > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > > > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > > > > obrien 2005-10-16 08:58:27 UTC > > > > > > > > > > > > FreeBSD src repository > > > > > > > > > > > > Modified files: > > > > > > sys/amd64/amd64 identcpu.c > > > > > > sys/i386/i386 identcpu.c > > > > > > Log: > > > > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > > > > for the information it conveys, and it is only confusing > > > > > > people. This fixes incorrect output in the previous commit. > > > > > > > > > > > > Revision Changes Path > > > > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > > > > > > > Have you verified you are not breaking `logical_cpus' in > > > > > mp_machdep.c by doing this? > > > > > > > > > > Show me the 'incorrect' output or please back it out. > > > > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > > > K8-class CPU) .. > > > > Physical/Logical cores: 2/2 > > > > .. > > > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > > > cpu0 (BSP): APIC ID: 0 > > > > cpu1 (AP): APIC ID: 1 > > > > cpu2 (AP): APIC ID: 2 > > > > cpu3 (AP): APIC ID: 3 > > > > > > > > I sure as hell have 4 physical cores and no logical cores. > > > > > > The information is per-CPU. You have two CPUs with dual cores, which > > > means the given information is correct. Please back it out. > > > > No, this given information is wrong. AMD does not have HyperThreading. > > You are treating it as if it does. The rest of the kernel also should > > not be trying to treat AMD dual-core as HyperThreading. > > > > The only thing that should care in the freebsd kernel right now about AMD > > dual-core is PowerNow! support. It probably needs to know what cores > > match physical cores so it can proper work in a multi-socket system. > > > > Please point to what part of `logical_cpus' in mp_machdep.c you feel is > > broken by this change. > > > > > > I do not think you fully understand what AMD dual-core CPU's. > > > > > > Oh, please... > > > > The code you committed suggest this... > > Apparently David interpeted the "Physical/Logical cores: 2/2" as two > physical cores plus two additional logical cores. I didn't, but I could > see how (since this per-cpu information printed isn't actually printed > per cpu) it could be interpreted this way on a dual-cpu system. > > I think that this would be useful information to be printing in general > (not just on really-HTT systems), since it would clarify what seeing > "cpu[0-3]: APIC ID..." printed out actually means when you're just > taking a look at some system and wondering how many cores it has. > > How hard would it be to do the cpuid per-cpu? Would it be sane to > assume that the cpuid output of the other CPUs will be the same (pretty > sure that's not the case), or at least that the multicore and HTT info > will be the same? And would there be a better wording to prevent > confusion? Doing it for each CPU would really bloat the output, and in practice I don't think would buy us anything. Note that the code assumes the package topology is uniform as well, not just the printfs. :) Probably the messages could be made less ambiguous by splitting it into two lines that say something like: Cores per package: 2 Logical CPUs per core: 1 Except that each line would only print if it's value was greater than 1. Thus, on David's box you would get: Cores per package: 2 On a PIV with HTT would get: Logical CPUs per core: 2 And on the super-spiffy Zueeglecorp CPU, you would get: Cores per package: 4 Logical CPUs per core: 4 -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Oct 17 20:27:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7A2B16A420; Mon, 17 Oct 2005 20:27:15 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 688E643D46; Mon, 17 Oct 2005 20:27:15 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HKRFdn099719; Mon, 17 Oct 2005 20:27:15 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HKRFw1099718; Mon, 17 Oct 2005 20:27:15 GMT (envelope-from phk) Message-Id: <200510172027.j9HKRFw1099718@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 17 Oct 2005 20:27:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/ipfwpcap Makefile ipfwpcap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 20:27:15 -0000 phk 2005-10-17 20:27:15 UTC FreeBSD src repository Added files: usr.sbin/ipfwpcap Makefile ipfwpcap.c Log: Add a small tool which captures packets on a DIVERT socket and writes them as pcap (tcpdump) format data to a file or pipe. Volunters wanted for: manpage Contributed by: P Kern Revision Changes Path 1.1 +19 -0 src/usr.sbin/ipfwpcap/Makefile (new) 1.1 +301 -0 src/usr.sbin/ipfwpcap/ipfwpcap.c (new) From owner-cvs-src@FreeBSD.ORG Mon Oct 17 20:31:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7BCF16A41F; Mon, 17 Oct 2005 20:31:58 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6865C43D46; Mon, 17 Oct 2005 20:31:58 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from freefall.freebsd.org (csjp@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9HKVwdn013940; Mon, 17 Oct 2005 20:31:58 GMT (envelope-from csjp@freefall.freebsd.org) Received: (from csjp@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9HKVwNr013939; Mon, 17 Oct 2005 20:31:58 GMT (envelope-from csjp) Date: Mon, 17 Oct 2005 20:31:58 +0000 From: "Christian S.J. Peron" To: Poul-Henning Kamp Message-ID: <20051017203158.GA11748@freefall.freebsd.org> References: <200510172027.j9HKRFw1099718@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510172027.j9HKRFw1099718@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/ipfwpcap Makefile ipfwpcap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 20:31:58 -0000 On Mon, Oct 17, 2005 at 08:27:15PM +0000, Poul-Henning Kamp wrote: > phk 2005-10-17 20:27:15 UTC > > FreeBSD src repository > > Added files: > usr.sbin/ipfwpcap Makefile ipfwpcap.c > Log: > Add a small tool which captures packets on a DIVERT socket and writes > them as pcap (tcpdump) format data to a file or pipe. > Very cool! -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team From owner-cvs-src@FreeBSD.ORG Mon Oct 17 20:32:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8404616A420; Mon, 17 Oct 2005 20:32:53 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr1.xs4all.nl (smtp-vbr1.xs4all.nl [194.109.24.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8CAD43D46; Mon, 17 Oct 2005 20:32:52 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr1.xs4all.nl (8.13.3/8.13.3) with ESMTP id j9HKWoJa029600; Mon, 17 Oct 2005 22:32:50 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.3/8.13.3) with ESMTP id j9HKWo2G022921; Mon, 17 Oct 2005 22:32:50 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.3/8.13.1/Submit) id j9HKWoaU022920; Mon, 17 Oct 2005 22:32:50 +0200 (CEST) (envelope-from wb) Date: Mon, 17 Oct 2005 22:32:50 +0200 From: Wilko Bulte To: John Baldwin Message-ID: <20051017203250.GA22904@freebie.xs4all.nl> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <200510171554.46682.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171554.46682.jhb@freebsd.org> X-OS: FreeBSD 5.4-STABLE User-Agent: Mutt/1.5.9i X-Virus-Scanned: by XS4ALL Virus Scanner Cc: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, Eric Anholt , obrien@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 20:32:53 -0000 On Mon, Oct 17, 2005 at 03:54:44PM -0400, John Baldwin wrote.. > On Monday 17 October 2005 03:08 pm, Eric Anholt wrote: > > On Mon, 2005-10-17 at 11:31 -0700, David O'Brien wrote: > > > On Mon, Oct 17, 2005 at 02:17:33PM -0400, Jung-uk Kim wrote: > > > > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > > > > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > > > > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > > > > > obrien 2005-10-16 08:58:27 UTC > > > > > > > > > > > > > > FreeBSD src repository > > > > > > > > > > > > > > Modified files: > > > > > > > sys/amd64/amd64 identcpu.c > > > > > > > sys/i386/i386 identcpu.c > > > > > > > Log: > > > > > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > > > > > for the information it conveys, and it is only confusing > > > > > > > people. This fixes incorrect output in the previous commit. > > > > > > > > > > > > > > Revision Changes Path > > > > > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > > > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > > > > > > > > > Have you verified you are not breaking `logical_cpus' in > > > > > > mp_machdep.c by doing this? > > > > > > > > > > > > Show me the 'incorrect' output or please back it out. > > > > > > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > > > > K8-class CPU) .. > > > > > Physical/Logical cores: 2/2 > > > > > .. > > > > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > > > > cpu0 (BSP): APIC ID: 0 > > > > > cpu1 (AP): APIC ID: 1 > > > > > cpu2 (AP): APIC ID: 2 > > > > > cpu3 (AP): APIC ID: 3 > > > > > > > > > > I sure as hell have 4 physical cores and no logical cores. > > > > > > > > The information is per-CPU. You have two CPUs with dual cores, which > > > > means the given information is correct. Please back it out. > > > > > > No, this given information is wrong. AMD does not have HyperThreading. > > > You are treating it as if it does. The rest of the kernel also should > > > not be trying to treat AMD dual-core as HyperThreading. > > > > > > The only thing that should care in the freebsd kernel right now about AMD > > > dual-core is PowerNow! support. It probably needs to know what cores > > > match physical cores so it can proper work in a multi-socket system. > > > > > > Please point to what part of `logical_cpus' in mp_machdep.c you feel is > > > broken by this change. > > > > > > > > I do not think you fully understand what AMD dual-core CPU's. > > > > > > > > Oh, please... > > > > > > The code you committed suggest this... > > > > Apparently David interpeted the "Physical/Logical cores: 2/2" as two > > physical cores plus two additional logical cores. I didn't, but I could > > see how (since this per-cpu information printed isn't actually printed > > per cpu) it could be interpreted this way on a dual-cpu system. > > > > I think that this would be useful information to be printing in general > > (not just on really-HTT systems), since it would clarify what seeing > > "cpu[0-3]: APIC ID..." printed out actually means when you're just > > taking a look at some system and wondering how many cores it has. > > > > How hard would it be to do the cpuid per-cpu? Would it be sane to > > assume that the cpuid output of the other CPUs will be the same (pretty > > sure that's not the case), or at least that the multicore and HTT info > > will be the same? And would there be a better wording to prevent > > confusion? > > Doing it for each CPU would really bloat the output, and in practice I don't > think would buy us anything. Note that the code assumes the package topology > is uniform as well, not just the printfs. :) 'psrinfo' anyone? -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Oct 17 20:42:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C030316A41F; Mon, 17 Oct 2005 20:42:40 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 27DDE43D46; Mon, 17 Oct 2005 20:42:39 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9HKoR0m084743; Mon, 17 Oct 2005 16:50:27 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: John Baldwin Date: Mon, 17 Oct 2005 16:42:24 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <1129576130.1152.30.camel@leguin> <200510171554.46682.jhb@freebsd.org> In-Reply-To: <200510171554.46682.jhb@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: Multipart/Mixed; boundary="Boundary-00=_yyAVDEJ8WWt8p2+" Message-Id: <200510171642.26719.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1140/Mon Oct 17 15:02:41 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, obrien@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 20:42:40 -0000 --Boundary-00=_yyAVDEJ8WWt8p2+ Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Monday 17 October 2005 03:54 pm, John Baldwin wrote: > Doing it for each CPU would really bloat the output, and in > practice I don't think would buy us anything. Note that the code > assumes the package topology is uniform as well, not just the > printfs. :) :-) > Probably the messages could be made less ambiguous by splitting it > into two lines that say something like: > Cores per package: 2 > Logical CPUs per core: 1 > > Except that each line would only print if it's value was greater > than 1. Thus, on David's box you would get: > Cores per package: 2 > > On a PIV with HTT would get: > Logical CPUs per core: 2 > > And on the super-spiffy Zueeglecorp CPU, you would get: > Cores per package: 4 > Logical CPUs per core: 4 The patch is attached. Please review. Thanks for the suggestions and no thanks for bikeshed, Jung-uk Kim --Boundary-00=_yyAVDEJ8WWt8p2+ Content-Type: text/x-diff; charset="euc-kr"; name="identcpu.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="identcpu.diff" Index: sys/amd64/amd64/identcpu.c =================================================================== RCS file: /home/ncvs/src/sys/amd64/amd64/identcpu.c,v retrieving revision 1.139 diff -u -r1.139 identcpu.c --- sys/amd64/amd64/identcpu.c 17 Oct 2005 15:51:27 -0000 1.139 +++ sys/amd64/amd64/identcpu.c 17 Oct 2005 20:37:01 -0000 @@ -358,9 +358,10 @@ cmp = ((regs[0] & 0xfc000000) >> 26) + 1; } if (cmp > 1) - printf("\n Physical cores: %d", cmp); - if (htt > 1) - printf("\n Logical cores: %d", htt); + printf("\n Cores per package: %d", cmp); + if ((htt / cmp) > 1) + printf("\n Logical CPUs per core: %d", + htt / cmp); } } /* Avoid ugly blank lines: only print newline when we have to. */ Index: sys/i386/i386/identcpu.c =================================================================== RCS file: /home/ncvs/src/sys/i386/i386/identcpu.c,v retrieving revision 1.148 diff -u -r1.148 identcpu.c --- sys/i386/i386/identcpu.c 17 Oct 2005 15:51:28 -0000 1.148 +++ sys/i386/i386/identcpu.c 17 Oct 2005 20:37:01 -0000 @@ -848,9 +848,10 @@ cmp = ((regs[0] & 0xfc000000) >> 26) + 1; } if (cmp > 1) - printf("\n Physical cores: %d", cmp); - if (htt > 1) - printf("\n Logical cores: %d", htt); + printf("\n Cores per package: %d", cmp); + if ((htt / cmp) > 1) + printf("\n Logical CPUs per core: %d", + htt / cmp); } } else if (strcmp(cpu_vendor, "CyrixInstead") == 0) { printf(" DIR=0x%04x", cyrix_did); --Boundary-00=_yyAVDEJ8WWt8p2+-- From owner-cvs-src@FreeBSD.ORG Mon Oct 17 20:47:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BBDB16A41F; Mon, 17 Oct 2005 20:47:45 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02E9943D5C; Mon, 17 Oct 2005 20:47:45 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HKliLq007854; Mon, 17 Oct 2005 20:47:44 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HKlin4007853; Mon, 17 Oct 2005 20:47:44 GMT (envelope-from phk) Message-Id: <200510172047.j9HKlin4007853@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 17 Oct 2005 20:47:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 20:47:45 -0000 phk 2005-10-17 20:47:44 UTC FreeBSD src repository Modified files: usr.sbin Makefile Log: Hook ipfwpcap into the build tree. Revision Changes Path 1.340 +1 -0 src/usr.sbin/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 17 21:36:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A04416A41F; Mon, 17 Oct 2005 21:36:39 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 985E743D4C; Mon, 17 Oct 2005 21:36:38 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j9HLaZmf063800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2005 01:36:36 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j9HLaZV2063799; Tue, 18 Oct 2005 01:36:35 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 18 Oct 2005 01:36:35 +0400 From: Gleb Smirnoff To: "David O'Brien" Message-ID: <20051017213635.GC59364@cell.sick.ru> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20051017192018.GD97488@dragon.NUXI.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, Jung-uk Kim , src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 21:36:39 -0000 David, On Mon, Oct 17, 2005 at 12:20:18PM -0700, David O'Brien wrote: D> Other than my electric company no one (people or D> FreeBSD SW) should care that I have dual-core CPU's. I don't agree. The dmesg output should describe the physical layout of the hardware, too. When maintaining hundreds of systems in server room, people usually forget what lives inside the computer cases. And when one needs to tell what is the motherboard and how many sockets and fans it has, he should be capable to do this without opening the case. I like John's suggestion about how physical/logical layouts can be printed. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Mon Oct 17 22:00:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E11D16A41F; Mon, 17 Oct 2005 22:00:06 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3574D43D45; Mon, 17 Oct 2005 22:00:06 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j9HM048g025685; Mon, 17 Oct 2005 15:00:04 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j9HM04kW025684; Mon, 17 Oct 2005 15:00:04 -0700 Date: Mon, 17 Oct 2005 15:00:04 -0700 From: Brooks Davis To: Gleb Smirnoff Message-ID: <20051017220004.GI15097@odin.ac.hmc.edu> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051017213635.GC59364@cell.sick.ru> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, David O'Brien , Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 22:00:07 -0000 On Tue, Oct 18, 2005 at 01:36:35AM +0400, Gleb Smirnoff wrote: > David, > > On Mon, Oct 17, 2005 at 12:20:18PM -0700, David O'Brien wrote: > D> Other than my electric company no one (people or > D> FreeBSD SW) should care that I have dual-core CPU's. > > I don't agree. The dmesg output should describe the physical layout > of the hardware, too. When maintaining hundreds of systems in server > room, people usually forget what lives inside the computer cases. And > when one needs to tell what is the motherboard and how many sockets > and fans it has, he should be capable to do this without opening > the case. I'm not sure that I care what dmesg says, but I do want an accurate view of our topology presented by the system, not some arbitrary and frankly meaningless CPU count. If nothing else I care because the two cores share one memory controller. That may not be all that noticable now for normal application, but I expect it will be once we start seeing 4+ core CPUs. Telling the user the (somewhat complicated) truth about their hardware is part of "doing it right". -- Brooks From owner-cvs-src@FreeBSD.ORG Mon Oct 17 22:51:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3C9116A434; Mon, 17 Oct 2005 22:51:22 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id A737043D95; Mon, 17 Oct 2005 22:51:02 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9HMwfli088456; Mon, 17 Oct 2005 18:58:49 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Brooks Davis Date: Mon, 17 Oct 2005 18:50:38 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <20051017213635.GC59364@cell.sick.ru> <20051017220004.GI15097@odin.ac.hmc.edu> In-Reply-To: <20051017220004.GI15097@odin.ac.hmc.edu> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510171850.39961.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1141/Mon Oct 17 17:38:45 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, Gleb Smirnoff , David O'Brien Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 22:51:25 -0000 On Monday 17 October 2005 06:00 pm, Brooks Davis wrote: > On Tue, Oct 18, 2005 at 01:36:35AM +0400, Gleb Smirnoff wrote: > > David, > > > > On Mon, Oct 17, 2005 at 12:20:18PM -0700, David O'Brien wrote: > > D> Other than my electric company no one (people or > > D> FreeBSD SW) should care that I have dual-core CPU's. > > > > I don't agree. The dmesg output should describe the physical > > layout of the hardware, too. When maintaining hundreds of systems > > in server room, people usually forget what lives inside the > > computer cases. And when one needs to tell what is the > > motherboard and how many sockets and fans it has, he should be > > capable to do this without opening the case. > > I'm not sure that I care what dmesg says, but I do want an accurate > view of our topology presented by the system, not some arbitrary > and frankly meaningless CPU count. If nothing else I care because > the two cores share one memory controller. That may not be all > that noticable now for normal application, but I expect it will be > once we start seeing 4+ core CPUs. Telling the user the (somewhat > complicated) truth about their hardware is part of "doing it > right". I believe we have to implement ACPI SRAT (Static Resource Affinity Table) and SLIT (System Locality Information Table) to achieve this. Linux already does this for i386, amd64, and i64: http://lxr.linux.no/source/arch/i386/kernel/srat.c http://lxr.linux.no/source/arch/x86_64/mm/srat.c http://lxr.linux.no/source/arch/ia64/kernel/acpi.c Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Mon Oct 17 23:10:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B24B16A41F; Mon, 17 Oct 2005 23:10:32 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E993143D46; Mon, 17 Oct 2005 23:10:31 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HNAV6n013058; Mon, 17 Oct 2005 23:10:31 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HNAVPL013057; Mon, 17 Oct 2005 23:10:31 GMT (envelope-from davidxu) Message-Id: <200510172310.j9HNAVPL013057@repoman.freebsd.org> From: David Xu Date: Mon, 17 Oct 2005 23:10:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 23:10:32 -0000 davidxu 2005-10-17 23:10:31 UTC FreeBSD src repository Modified files: sys/amd64/amd64 cpu_switch.S machdep.c Log: Micro optimization for context switch. Eliminate code for saving gs.base and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase when user wants to set them, in context switch routine, we only need to write them into registers, we never have to read them out from registers when thread is switched away. Since rdmsr is a serialization instruction, micro benchmark shows it is worthy to do. Reviewed by: peter, jhb Revision Changes Path 1.154 +0 -15 src/sys/amd64/amd64/cpu_switch.S 1.642 +2 -0 src/sys/amd64/amd64/machdep.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 23:21:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 05CC216A41F; Mon, 17 Oct 2005 23:21:56 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD1CD43D46; Mon, 17 Oct 2005 23:21:55 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HNLtZO013651; Mon, 17 Oct 2005 23:21:55 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HNLtNJ013650; Mon, 17 Oct 2005 23:21:55 GMT (envelope-from peter) Message-Id: <200510172321.j9HNLtNJ013650@repoman.freebsd.org> From: Peter Wemm Date: Mon, 17 Oct 2005 23:21:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern link_elf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 23:21:56 -0000 peter 2005-10-17 23:21:55 UTC FreeBSD src repository Modified files: sys/kern link_elf.c Log: Add support for kernel modules with a single PT_LOAD section. While here, support up to four sections because it was trivial to do and cheap. (One pointer per section). For amd64 with "-fpic -shared" format .ko files, using a single PT_LOAD section is important to avoid wasting about 1MB of KVM and physical ram for the 'gap' between the two PT_LOAD sections. amd64 normally uses .o format kld files and isn't affected normally. But -fpic -shared modules are actually possible to produce and load... (And with a bugfix to binutils, we can build and use plain -shared .ko files without -fpic) i386 only wastes 4K per .ko file, so that isn't such a big deal there. Revision Changes Path 1.85 +9 -6 src/sys/kern/link_elf.c From owner-cvs-src@FreeBSD.ORG Mon Oct 17 23:23:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66F4816A41F; Mon, 17 Oct 2005 23:23:21 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2252043D46; Mon, 17 Oct 2005 23:23:21 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9HNNLm8013730; Mon, 17 Oct 2005 23:23:21 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9HNNLOM013729; Mon, 17 Oct 2005 23:23:21 GMT (envelope-from jkim) Message-Id: <200510172323.j9HNNLOM013729@repoman.freebsd.org> From: Jung-uk Kim Date: Mon, 17 Oct 2005 23:23:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 23:23:21 -0000 jkim 2005-10-17 23:23:20 UTC FreeBSD src repository Modified files: sys/amd64/amd64 identcpu.c sys/i386/i386 identcpu.c Log: Redo physical/logical CPU count. Suggested by: jhb Revision Changes Path 1.140 +4 -3 src/sys/amd64/amd64/identcpu.c 1.149 +4 -3 src/sys/i386/i386/identcpu.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 00:42:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52CC916A41F; Tue, 18 Oct 2005 00:42:11 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2644A43D45; Tue, 18 Oct 2005 00:42:11 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I0gB8v016943; Tue, 18 Oct 2005 00:42:11 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I0gBCr016942; Tue, 18 Oct 2005 00:42:11 GMT (envelope-from cognet) Message-Id: <200510180042.j9I0gBCr016942@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 18 Oct 2005 00:42:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 00:42:11 -0000 cognet 2005-10-18 00:42:10 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: - Use BUS_DMASYNC_PREWRITE in em_get_buf(), as the adapter is about to read the descriptors set. - In em_process_receive_interrupts(), call bus_dmamap_sync() for the descriptors set each time we modify one descriptor, instead of doing it only at the function exit, to make sure the adapters know he can re-use the descriptor. This helps on arm with write-back data cache (and possibly on other arches with bounce pages, I don't know) under heavy network load. Without this, if we attempt to process more than num_rx_desc descriptors, the adapter would just stop processing rx interrupts. Revision Changes Path 1.78 +4 -3 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 01:11:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC43716A41F; Tue, 18 Oct 2005 01:11:15 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A24243D45; Tue, 18 Oct 2005 01:11:15 +0000 (GMT) (envelope-from nate@root.org) Received: from [192.168.253.24] (206-135-69-234.lax-e100.cust.gw.epoch.net [206.135.69.234]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j9I1BAxq007822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 17 Oct 2005 18:11:11 -0700 Message-ID: <43544BA7.6050906@root.org> Date: Mon, 17 Oct 2005 18:11:03 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jung-uk Kim References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <20051017213635.GC59364@cell.sick.ru> <20051017220004.GI15097@odin.ac.hmc.edu> <200510171850.39961.jkim@FreeBSD.org> In-Reply-To: <200510171850.39961.jkim@FreeBSD.org> Content-Type: text/plain; charset=EUC-KR Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, Brooks Davis , cvs-src@FreeBSD.org, Eric Anholt , David O'Brien , Gleb Smirnoff , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 01:11:16 -0000 Jung-uk Kim wrote: > On Monday 17 October 2005 06:00 pm, Brooks Davis wrote: >>I'm not sure that I care what dmesg says, but I do want an accurate >>view of our topology presented by the system, not some arbitrary >>and frankly meaningless CPU count. If nothing else I care because >>the two cores share one memory controller. That may not be all >>that noticable now for normal application, but I expect it will be >>once we start seeing 4+ core CPUs. Telling the user the (somewhat >>complicated) truth about their hardware is part of "doing it >>right". > > > I believe we have to implement ACPI SRAT (Static Resource Affinity > Table) and SLIT (System Locality Information Table) to achieve this. > Linux already does this for i386, amd64, and i64: > > http://lxr.linux.no/source/arch/i386/kernel/srat.c > http://lxr.linux.no/source/arch/x86_64/mm/srat.c > http://lxr.linux.no/source/arch/ia64/kernel/acpi.c I'm happy to review any patches to implement this. -- Nate From owner-cvs-src@FreeBSD.ORG Tue Oct 18 01:37:18 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C48716A420; Tue, 18 Oct 2005 01:37:18 +0000 (GMT) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8155843D45; Tue, 18 Oct 2005 01:37:17 +0000 (GMT) (envelope-from max@love2party.net) Received: from p54A3E6EC.dip.t-dialin.net [84.163.230.236] (helo=donor.laier.local) by mrelayeu.kundenserver.de with ESMTP (Nemesis), id 0ML29c-1ERgPj44eU-00058o; Tue, 18 Oct 2005 03:37:15 +0200 From: Max Laier To: Poul-Henning Kamp Date: Tue, 18 Oct 2005 03:36:56 +0200 User-Agent: KMail/1.8.2 References: <200510172027.j9HKRFw1099718@repoman.freebsd.org> In-Reply-To: <200510172027.j9HKRFw1099718@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2742888.hZlPlYooB2"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200510180337.13923.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/ipfwpcap Makefile ipfwpcap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 01:37:18 -0000 --nextPart2742888.hZlPlYooB2 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 17 October 2005 22:27, Poul-Henning Kamp wrote: > phk 2005-10-17 20:27:15 UTC > > FreeBSD src repository > > Added files: > usr.sbin/ipfwpcap Makefile ipfwpcap.c > Log: > Add a small tool which captures packets on a DIVERT socket and writes > them as pcap (tcpdump) format data to a file or pipe. > > Volunters wanted for: manpage > Contributed by: P Kern Could we raname this to divcap which is much more to the point? Yes, I am= =20 thinking about divert sockets in PF. > Revision Changes Path > 1.1 +19 -0 src/usr.sbin/ipfwpcap/Makefile (new) > 1.1 +301 -0 src/usr.sbin/ipfwpcap/ipfwpcap.c (new) =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2742888.hZlPlYooB2 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDVFHJXyyEoT62BG0RAibdAJ4yxNcVWigHfGMDGzrcHqDWbrFeCACeJhk8 Xn6/yRtSfe13iK+nYsF2PNc= =2X5/ -----END PGP SIGNATURE----- --nextPart2742888.hZlPlYooB2-- From owner-cvs-src@FreeBSD.ORG Tue Oct 18 03:59:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA58F16A41F; Tue, 18 Oct 2005 03:59:03 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 749BD43D45; Tue, 18 Oct 2005 03:59:03 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9I3x2qm022895; Mon, 17 Oct 2005 20:59:02 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9I3x2c0022894; Mon, 17 Oct 2005 20:59:02 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 20:59:02 -0700 From: "David O'Brien" To: Gleb Smirnoff Message-ID: <20051018035902.GH53525@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051017213635.GC59364@cell.sick.ru> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, Jung-uk Kim , src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 03:59:04 -0000 On Tue, Oct 18, 2005 at 01:36:35AM +0400, Gleb Smirnoff wrote: > David, > > On Mon, Oct 17, 2005 at 12:20:18PM -0700, David O'Brien wrote: > D> Other than my electric company no one (people or > D> FreeBSD SW) should care that I have dual-core CPU's. > > I don't agree. The dmesg output should describe the physical layout > of the hardware, too. Why is this not clear? CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) They are 200 series Opteron - you can have only 2 (or 1) in a system. They are dual-core. FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs cpu0 (BSP): APIC ID: 0 cpu1 (AP): APIC ID: 1 cpu2 (AP): APIC ID: 2 cpu3 (AP): APIC ID: 3 proper outout given the above 'CPU' ident string. > When maintaining hundreds of systems in server > room, people usually forget what lives inside the computer cases. And > when one needs to tell what is the motherboard and how many sockets > and fans it has, he should be capable to do this without opening > the case. The above dmesg doesn't tell this to you? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 04:00:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D74316A444; Tue, 18 Oct 2005 04:00:26 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D40C43D45; Tue, 18 Oct 2005 04:00:22 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9I40L82022939; Mon, 17 Oct 2005 21:00:21 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9I40LiZ022938; Mon, 17 Oct 2005 21:00:21 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 21:00:21 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051018040021.GI53525@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <20051017213635.GC59364@cell.sick.ru> <20051017220004.GI15097@odin.ac.hmc.edu> <200510171850.39961.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171850.39961.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: src-committers@FreeBSD.org, Brooks Davis , cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, Gleb Smirnoff Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 04:00:44 -0000 On Mon, Oct 17, 2005 at 06:50:38PM -0400, Jung-uk Kim wrote: > On Monday 17 October 2005 06:00 pm, Brooks Davis wrote: > > I'm not sure that I care what dmesg says, but I do want an accurate > > view of our topology presented by the system, not some arbitrary > > and frankly meaningless CPU count. If nothing else I care because > > the two cores share one memory controller. That may not be all > > that noticable now for normal application, but I expect it will be > > once we start seeing 4+ core CPUs. Telling the user the (somewhat > > complicated) truth about their hardware is part of "doing it > > right". > > I believe we have to implement ACPI SRAT (Static Resource Affinity > Table) and SLIT (System Locality Information Table) to achieve this. No kidding - I've said this many times and that this is an area I'm working in. I've mentioned this to you before. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 04:02:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5368016A41F; Tue, 18 Oct 2005 04:02:30 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd2mo3so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF92C43D45; Tue, 18 Oct 2005 04:02:29 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd4mr3so.prod.shaw.ca (pd4mr3so-qfe3.prod.shaw.ca [10.0.141.214]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IOJ00H60F852OA0@l-daemon>; Mon, 17 Oct 2005 22:02:29 -0600 (MDT) Received: from pn2ml7so.prod.shaw.ca ([10.0.121.151]) by pd4mr3so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IOJ00ERTF85ZNJ0@pd4mr3so.prod.shaw.ca>; Mon, 17 Oct 2005 22:02:29 -0600 (MDT) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) with ESMTP id <0IOJ0025EF84GV@l-daemon>; Mon, 17 Oct 2005 22:02:28 -0600 (MDT) Date: Mon, 17 Oct 2005 21:02:27 -0700 From: Colin Percival In-reply-to: <20051018035902.GH53525@dragon.NUXI.org> To: obrien@FreeBSD.org Message-id: <435473D3.8080209@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Accept-Language: en-us, en X-Enigmail-Version: 0.92.1.0 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> <20051018035902.GH53525@dragon.NUXI.org> User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051001) Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, Gleb Smirnoff , Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 04:02:30 -0000 David O'Brien wrote: > Why is this not clear? > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) > > They are 200 series Opteron - you can have only 2 (or 1) in a system. > They are dual-core. This may be clear to *you*, but five years from now I'm sure that *I* won't be able to remember what the AMD Opteron 280 is. If in doubt, present the same information several times in different ways. Colin Percival From owner-cvs-src@FreeBSD.ORG Tue Oct 18 04:08:12 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9E4416A41F; Tue, 18 Oct 2005 04:08:12 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CB5243D46; Tue, 18 Oct 2005 04:08:12 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9I488ou023133; Mon, 17 Oct 2005 21:08:08 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9I4883X023132; Mon, 17 Oct 2005 21:08:08 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 21:08:08 -0700 From: "David O'Brien" To: Colin Percival Message-ID: <20051018040808.GB23014@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> <20051018035902.GH53525@dragon.NUXI.org> <435473D3.8080209@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <435473D3.8080209@freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Eric Anholt , cvs-all@freebsd.org, Gleb Smirnoff , Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 04:08:12 -0000 On Mon, Oct 17, 2005 at 09:02:27PM -0700, Colin Percival wrote: > David O'Brien wrote: > > Why is this not clear? > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) > > > > They are 200 series Opteron - you can have only 2 (or 1) in a system. > > They are dual-core. > > This may be clear to *you*, but five years from now I'm sure that *I* won't > be able to remember what the AMD Opteron 280 is. > > If in doubt, present the same information several times in different ways. Should I add code on Opteron sytems to print the number of DIMM's attached to each CPU? Or the amount of memory on each CPU? Or maybe the color of the CPU fans? How far do we take it to avoid having to remove the case to know what the HW inside is? Why is it we don't print out the cache configuration unless it is a verbose boot? I would find that information quite useful also so I wouldn't have to look up CPU model names, etc.. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 04:40:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F91B16A420; Tue, 18 Oct 2005 04:40:12 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15B6543D45; Tue, 18 Oct 2005 04:40:12 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I4eBfA033783; Tue, 18 Oct 2005 04:40:11 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I4eBhP033782; Tue, 18 Oct 2005 04:40:11 GMT (envelope-from jkoshy) Message-Id: <200510180440.j9I4eBhP033782@repoman.freebsd.org> From: Joseph Koshy Date: Tue, 18 Oct 2005 04:40:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pmcstat pmcstat.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 04:40:12 -0000 jkoshy 2005-10-18 04:40:11 UTC FreeBSD src repository Modified files: usr.sbin/pmcstat pmcstat.8 Log: Document pmcstat's inability to handle 32 bit executables on the AMD64 while I work on a fix. Noticed by: ps Revision Changes Path 1.7 +4 -0 src/usr.sbin/pmcstat/pmcstat.8 From owner-cvs-src@FreeBSD.ORG Tue Oct 18 04:50:32 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16C2C16A41F; Tue, 18 Oct 2005 04:50:32 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98DF343D4C; Tue, 18 Oct 2005 04:50:31 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.ntplx.net (8.13.5/8.13.5/NETPLEX) with ESMTP id j9I4oUm8007000; Tue, 18 Oct 2005 00:50:30 -0400 (EDT) Date: Tue, 18 Oct 2005 00:50:30 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Colin Percival In-Reply-To: <435473D3.8080209@freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 04:50:32 -0000 On Mon, 17 Oct 2005, Colin Percival wrote: > David O'Brien wrote: > > Why is this not clear? > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) ^^^^ > > > > They are 200 series Opteron - you can have only 2 (or 1) in a system. > > They are dual-core. > > This may be clear to *you*, but five years from now I'm sure that *I* won't > be able to remember what the AMD Opteron 280 is. Am I missing something? Would it still say "Dual" if it were not a dual core? -- DE From owner-cvs-src@FreeBSD.ORG Tue Oct 18 05:04:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CF7116A41F; Tue, 18 Oct 2005 05:04:57 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5A8843D46; Tue, 18 Oct 2005 05:04:56 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9I54tOb014186; Tue, 18 Oct 2005 15:04:55 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9I54qQ7024637; Tue, 18 Oct 2005 15:04:53 +1000 Date: Tue, 18 Oct 2005 15:04:54 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Andre Oppermann In-Reply-To: <200510171537.j9HFbMdW073713@repoman.freebsd.org> Message-ID: <20051018135821.L93164@delplex.bde.org> References: <200510171537.j9HFbMdW073713@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 05:04:57 -0000 On Mon, 17 Oct 2005, Andre Oppermann wrote: > andre 2005-10-17 15:37:22 UTC > > FreeBSD src repository > > Modified files: > usr.bin/vmstat vmstat.c > usr.bin/w w.c > Log: > Obtain true uptime through clock_gettime(CLOCK_MONOTONIC, struct *timespec) > instead of subtracting 'bootime' from 'now'. This is bogus, and it breaks vmstat some more in the dead kernel case. In the live kernel case, clock_gettime() returns the time since an unspecified point in the past. It is still necessary to subtract the boottime, one measured by the same clock, especially under systems like FreeBSD where the "unspecified point in the past" is undocumented. In the dead kernel case, clock_gettime() cannot be used, and using it gives a wrong uptime (that of the running system, not that of the dead kernel). The old code is wrong too. It subtracts the boot time from the current time, where the current time is for the live kernel and the boot time is for the live or dead kernel. This gives an even wronger uptime for the dead kernel case, since a live kernel may be run longer after the boot time of a dead kernel than after its own boot time. I don't know of any good way to determine the uptime of a dead kernel now. I only know of a wrong way: kern_shutdown.c has a low quality function print_uptime() which does user-interface things that don't belong in the kernel. It prints the uptime to the console. To ensure its low quality, it does this after the dump has completed, so that its output doesn't get printed in the dump via the message buffer. Thus its output can only be seen if you are watching the shutdown in some way, and is soon forgotten unless your watcher has logging features. The death time for a dead kernel should be saved in a variable near its boottime variable so that utilities like vmstat can determine it easily. For live kernels, subtracting the boot time from the current _real_ time using difftime() is the correct method. Both times are relative to the same clock, so their difference gives the elasped time unless there are bugs in this clock. The clock should be the real time clock and not the monotonic clock, since uptimes are in real time. In practice there should only be a difference of a leap second or two and no one would be able to see it. However, there are bugs. For the real time clock, the boot time at least used to be bogusly adjusted to compensate for adjustements to the real time by settime(), mainly so that subtracting the boot time from the current time gives a value near the uptime. This is correct if the adjustment is to compensate for an initial error in the real time as is normal if the system clock is on local time (here local time is 36000 seconds in advance of UTC, so both the real time and the boot time start up 36000 too high; then the settime() in adjkerntz sets them both back 36000; if the boottime were not adjusted then the uptime shown by vmstat would be off by 36000 seconds). This is wrong if the adjustment is to compensate for clock drift. Then the uptime really should change to adjust for the error in the real time, but instead the boot time is messed up to keep the uptime the same. Using the monotonic clock for the uptime gives essentially the same bug -- in general, the real time clock and the monotonic clock will drift at different rates, and since only the real time clock can be synced with an external clock, the inaccuracy can only be bounded for the real time clock. There are also some style bugs in vmstat.c in the changes and old ones nearby: % Index: vmstat.c % =================================================================== % RCS file: /home/ncvs/src/usr.bin/vmstat/vmstat.c,v % retrieving revision 1.90 % retrieving revision 1.91 % diff -u -2 -r1.90 -r1.91 % --- vmstat.c 6 Aug 2005 13:56:21 -0000 1.90 % +++ vmstat.c 17 Oct 2005 15:37:22 -0000 1.91 % @@ -397,24 +397,12 @@ % getuptime(void) % { % - static struct timeval boottime; % - static time_t now; % + struct timespec sp; % time_t uptime; % % - if (boottime.tv_sec == 0) { % - if (kd != NULL) { % - kread(X_BOOTTIME, &boottime, sizeof(boottime)); These leaves dead code in the nlist. % - } else { % - size_t size; % - % - size = sizeof(boottime); % - mysysctl("kern.boottime", &boottime, &size, NULL, 0); % - if (size != sizeof(boottime)) % - errx(1, "kern.boottime size mismatch"); There was error checking for the sysctl. % - } % - } % - (void)time(&now); % - uptime = now - boottime.tv_sec; % + (void)clock_gettime(CLOCK_MONOTONIC, &sp); There was/is no error checking for the time calls. % + uptime = sp.tv_sec; % if (uptime <= 0 || uptime > 60*60*24*365*10) % errx(1, "time makes no sense; namelist must be wrong"); This check is now bogus. Dead kernels are no longer used to determine the uptime; in particular the namelist is not used. The only possibility of an error is clock_gettime() but errors from it were voided. % + Extra blank line. % return(uptime); No space before return expression. % } Bruce From owner-cvs-src@FreeBSD.ORG Tue Oct 18 05:13:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5515016A41F; Tue, 18 Oct 2005 05:13:28 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE7A543D49; Tue, 18 Oct 2005 05:13:27 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I5DRM6042263; Tue, 18 Oct 2005 05:13:27 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I5DR68042262; Tue, 18 Oct 2005 05:13:27 GMT (envelope-from jkoshy) Message-Id: <200510180513.j9I5DR68042262@repoman.freebsd.org> From: Joseph Koshy Date: Tue, 18 Oct 2005 05:13:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pmcstat pmcstat_log.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 05:13:28 -0000 jkoshy 2005-10-18 05:13:27 UTC FreeBSD src repository Modified files: usr.sbin/pmcstat pmcstat_log.c Log: Handle 32 bit executables better on AMD64 platforms. Revision Changes Path 1.6 +69 -30 src/usr.sbin/pmcstat/pmcstat_log.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 06:09:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDB2616A41F; Tue, 18 Oct 2005 06:09:42 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A1AC43D4C; Tue, 18 Oct 2005 06:09:42 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I69gCs044467; Tue, 18 Oct 2005 06:09:42 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I69gWR044466; Tue, 18 Oct 2005 06:09:42 GMT (envelope-from imp) Message-Id: <200510180609.j9I69gWR044466@repoman.freebsd.org> From: Warner Losh Date: Tue, 18 Oct 2005 06:09:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/dc dcphy.c if_dc.c pnphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 06:09:43 -0000 imp 2005-10-18 06:09:42 UTC FreeBSD src repository Modified files: sys/dev/dc dcphy.c if_dc.c pnphy.c Log: Make dc compile after repo-copy. Revision Changes Path 1.30 +1 -1 src/sys/dev/dc/dcphy.c 1.171 +4 -3 src/sys/dev/dc/if_dc.c 1.20 +1 -1 src/sys/dev/dc/pnphy.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 06:10:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A7C816A421; Tue, 18 Oct 2005 06:10:04 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEB7E43D48; Tue, 18 Oct 2005 06:10:03 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I6A3ED044519; Tue, 18 Oct 2005 06:10:03 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I6A3jl044518; Tue, 18 Oct 2005 06:10:03 GMT (envelope-from imp) Message-Id: <200510180610.j9I6A3jl044518@repoman.freebsd.org> From: Warner Losh Date: Tue, 18 Oct 2005 06:10:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci if_dc.c if_dcreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 06:10:22 -0000 imp 2005-10-18 06:10:03 UTC FreeBSD src repository Removed files: sys/pci if_dc.c if_dcreg.h Log: Remove dc after repo copy. Revision Changes Path 1.172 +0 -3863 src/sys/pci/if_dc.c (dead) 1.46 +0 -1225 src/sys/pci/if_dcreg.h (dead) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 06:10:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E9EF16A427; Tue, 18 Oct 2005 06:10:47 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2969343D49; Tue, 18 Oct 2005 06:10:47 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I6Algc044658; Tue, 18 Oct 2005 06:10:47 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I6AlNk044657; Tue, 18 Oct 2005 06:10:47 GMT (envelope-from imp) Message-Id: <200510180610.j9I6AlNk044657@repoman.freebsd.org> From: Warner Losh Date: Tue, 18 Oct 2005 06:10:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mii dcphy.c pnphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 06:10:47 -0000 imp 2005-10-18 06:10:47 UTC FreeBSD src repository Removed files: sys/dev/mii dcphy.c pnphy.c Log: Remove dc-only pseudo phy devices after repo copy to dev/dc Revision Changes Path 1.30 +0 -451 src/sys/dev/mii/dcphy.c (dead) 1.20 +0 -268 src/sys/dev/mii/pnphy.c (dead) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 06:11:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8316B16A454; Tue, 18 Oct 2005 06:11:09 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDDDB43D4C; Tue, 18 Oct 2005 06:11:08 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I6B8KA044709; Tue, 18 Oct 2005 06:11:08 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I6B8EA044708; Tue, 18 Oct 2005 06:11:08 GMT (envelope-from imp) Message-Id: <200510180611.j9I6B8EA044708@repoman.freebsd.org> From: Warner Losh Date: Tue, 18 Oct 2005 06:11:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules/dc Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 06:11:09 -0000 imp 2005-10-18 06:11:08 UTC FreeBSD src repository Modified files: sys/modules/dc Makefile Log: Move dc sources from pci to dev/dc. Revision Changes Path 1.8 +3 -3 src/sys/modules/dc/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 18 06:12:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9020716A41F; Tue, 18 Oct 2005 06:12:00 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E82B43D48; Tue, 18 Oct 2005 06:12:00 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I6C0F6044772; Tue, 18 Oct 2005 06:12:00 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I6C0T8044771; Tue, 18 Oct 2005 06:12:00 GMT (envelope-from imp) Message-Id: <200510180612.j9I6C0T8044771@repoman.freebsd.org> From: Warner Losh Date: Tue, 18 Oct 2005 06:12:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 06:12:00 -0000 imp 2005-10-18 06:12:00 UTC FreeBSD src repository Modified files: sys/conf files Log: Move dc sources from pci and dev/mii into dev/dc. Revision Changes Path 1.1058 +3 -3 src/sys/conf/files From owner-cvs-src@FreeBSD.ORG Tue Oct 18 06:38:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6AA9616A41F; Tue, 18 Oct 2005 06:38:15 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2885543D46; Tue, 18 Oct 2005 06:38:15 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I6cFqu045827; Tue, 18 Oct 2005 06:38:15 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I6cFeG045826; Tue, 18 Oct 2005 06:38:15 GMT (envelope-from yar) Message-Id: <200510180638.j9I6cFeG045826@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 18 Oct 2005 06:38:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/kbdmux kbdmux.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 06:38:15 -0000 yar 2005-10-18 06:38:14 UTC FreeBSD src repository Modified files: sys/dev/kbdmux kbdmux.c Log: Spotted a call to a cdev-related function not wrapped in "#ifdef KBD_INSTALL_CDEV". Noticed by: glebius Uncovered by: recent change to modules' Makefiles Revision Changes Path 1.3 +2 -0 src/sys/dev/kbdmux/kbdmux.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 06:39:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8E8F16A41F; Tue, 18 Oct 2005 06:39:30 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 682BB43D46; Tue, 18 Oct 2005 06:39:30 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I6dUFA045896; Tue, 18 Oct 2005 06:39:30 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I6dUSa045895; Tue, 18 Oct 2005 06:39:30 GMT (envelope-from imp) Message-Id: <200510180639.j9I6dUSa045895@repoman.freebsd.org> From: Warner Losh Date: Tue, 18 Oct 2005 06:39:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules/mii Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 06:39:30 -0000 imp 2005-10-18 06:39:30 UTC FreeBSD src repository Modified files: sys/modules/mii Makefile Log: Don't build dc-only pseudo phy devices with mii.ko anymore Revision Changes Path 1.28 +1 -1 src/sys/modules/mii/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 18 06:57:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2336216A420; Tue, 18 Oct 2005 06:57:03 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F11343D46; Tue, 18 Oct 2005 06:57:02 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j9I6uxLu068868 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2005 10:57:00 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j9I6uxRG068867; Tue, 18 Oct 2005 10:56:59 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 18 Oct 2005 10:56:59 +0400 From: Gleb Smirnoff To: "David O'Brien" Message-ID: <20051018065659.GD59364@cell.sick.ru> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> <20051018035902.GH53525@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20051018035902.GH53525@dragon.NUXI.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, Jung-uk Kim , src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 06:57:03 -0000 On Mon, Oct 17, 2005 at 08:59:02PM -0700, David O'Brien wrote: D> > On Mon, Oct 17, 2005 at 12:20:18PM -0700, David O'Brien wrote: D> > D> Other than my electric company no one (people or D> > D> FreeBSD SW) should care that I have dual-core CPU's. D> > D> > I don't agree. The dmesg output should describe the physical layout D> > of the hardware, too. D> D> Why is this not clear? D> D> CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) D> D> They are 200 series Opteron - you can have only 2 (or 1) in a system. D> They are dual-core. D> D> FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs D> cpu0 (BSP): APIC ID: 0 D> cpu1 (AP): APIC ID: 1 D> cpu2 (AP): APIC ID: 2 D> cpu3 (AP): APIC ID: 3 D> D> proper outout given the above 'CPU' ident string. D> D> D> > When maintaining hundreds of systems in server D> > room, people usually forget what lives inside the computer cases. And D> > when one needs to tell what is the motherboard and how many sockets D> > and fans it has, he should be capable to do this without opening D> > the case. D> D> The above dmesg doesn't tell this to you? Only after you have explained it. If I am a new FreeBSD user, I won't understand that I have two sockets with two dual core CPUs. And I agree with both Colin's and Daniel's points of view. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Tue Oct 18 07:20:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD68A16A41F; Tue, 18 Oct 2005 07:20:15 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 750BB43D46; Tue, 18 Oct 2005 07:20:15 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I7KFaI047506; Tue, 18 Oct 2005 07:20:15 GMT (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I7KFCJ047499; Tue, 18 Oct 2005 07:20:15 GMT (envelope-from harti) Message-Id: <200510180720.j9I7KFCJ047499@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 18 Oct 2005 07:20:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/usr.bin/make/syntax/enl Makefile expected.status.2 expected.status.3 expected.status.4 expected.status.5 expected.stderr.2 expected.stderr.3 expected.stderr.4 expected.stderr.5 expected.stdout.2 expected.stdout.3 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 07:20:16 -0000 harti 2005-10-18 07:20:15 UTC FreeBSD src repository Modified files: tools/regression/usr.bin/make/syntax/enl Makefile expected.status.2 expected.stderr.2 expected.stdout.2 test.t Added files: tools/regression/usr.bin/make/syntax/enl expected.status.3 expected.status.4 expected.status.5 expected.stderr.3 expected.stderr.4 expected.stderr.5 expected.stdout.3 expected.stdout.4 expected.stdout.5 Log: Add more tests for escaped newline handling and fix a test that currently should fail because of a bug in the parser (test 2). Revision Changes Path 1.2 +38 -4 src/tools/regression/usr.bin/make/syntax/enl/Makefile 1.2 +1 -1 src/tools/regression/usr.bin/make/syntax/enl/expected.status.2 1.1 +1 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.status.3 (new) 1.1 +1 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.status.4 (new) 1.1 +1 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.status.5 (new) 1.2 +0 -2 src/tools/regression/usr.bin/make/syntax/enl/expected.stderr.2 1.1 +0 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.stderr.3 (new) 1.1 +0 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.stderr.4 (new) 1.1 +0 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.stderr.5 (new) 1.2 +1 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.stdout.2 1.1 +2 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.stdout.3 (new) 1.1 +1 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.stdout.4 (new) 1.1 +1 -0 src/tools/regression/usr.bin/make/syntax/enl/expected.stdout.5 (new) 1.2 +1 -1 src/tools/regression/usr.bin/make/syntax/enl/test.t From owner-cvs-src@FreeBSD.ORG Tue Oct 18 07:28:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 996FE16A41F; Tue, 18 Oct 2005 07:28:10 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31B0E43D4C; Tue, 18 Oct 2005 07:28:10 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I7S92V047929; Tue, 18 Oct 2005 07:28:09 GMT (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I7S9j0047928; Tue, 18 Oct 2005 07:28:09 GMT (envelope-from harti) Message-Id: <200510180728.j9I7S9j0047928@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 18 Oct 2005 07:28:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/usr.bin/make/syntax/semi Makefile expected.status.1 expected.status.2 expected.stderr.1 expected.stderr.2 expected.stdout.1 expected.stdout.2 test.t X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 07:28:10 -0000 harti 2005-10-18 07:28:09 UTC FreeBSD src repository Added files: tools/regression/usr.bin/make/syntax/semi Makefile expected.status.1 expected.status.2 expected.stderr.1 expected.stderr.2 expected.stdout.1 expected.stdout.2 test.t Log: Add first tests for semicolon handling. The first test fails. This is probably a bug in the parser. Revision Changes Path 1.1 +26 -0 src/tools/regression/usr.bin/make/syntax/semi/Makefile (new) 1.1 +1 -0 src/tools/regression/usr.bin/make/syntax/semi/expected.status.1 (new) 1.1 +1 -0 src/tools/regression/usr.bin/make/syntax/semi/expected.status.2 (new) 1.1 +0 -0 src/tools/regression/usr.bin/make/syntax/semi/expected.stderr.1 (new) 1.1 +0 -0 src/tools/regression/usr.bin/make/syntax/semi/expected.stderr.2 (new) 1.1 +2 -0 src/tools/regression/usr.bin/make/syntax/semi/expected.stdout.1 (new) 1.1 +2 -0 src/tools/regression/usr.bin/make/syntax/semi/expected.stdout.2 (new) 1.1 +15 -0 src/tools/regression/usr.bin/make/syntax/semi/test.t (new) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 07:30:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2147216A41F; Tue, 18 Oct 2005 07:30:02 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68E8A43D48; Tue, 18 Oct 2005 07:30:01 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id B3526BC84; Tue, 18 Oct 2005 07:29:58 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 18 Oct 2005 15:04:54 +1000." <20051018135821.L93164@delplex.bde.org> Date: Tue, 18 Oct 2005 09:29:57 +0200 Message-ID: <67214.1129620597@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 07:30:02 -0000 In message <20051018135821.L93164@delplex.bde.org>, Bruce Evans writes: >This is bogus, and it breaks vmstat some more in the dead kernel case. > >In the live kernel case, clock_gettime() returns the time since an >unspecified point in the past. It is still necessary to subtract the >boottime, one measured by the same clock, especially under systems >like FreeBSD where the "unspecified point in the past" is undocumented. The unspecified point in the past is actually the exact time the kernel booted and therefore clock_gettime(CLOCK_MONOTONIC) does the right thing for a running kernel. >I don't know of any good way to determine the uptime of a dead kernel >now. It is available in an internal variable in the timecounter code. If desired it can be exported to a visible variable once per second. >The death time for a dead kernel should be saved in a variable near its >boottime variable so that utilities like vmstat can determine it easily. That's another option. Let me know which is preferable. >For live kernels, subtracting the boot time from the current _real_ >time using difftime() is the correct method. Actually it isn't, but it comes close. CLOCK_MONOTONIC is the true elapsed time since boot, whereas boottime is our retrospective UTC estimate of that moment. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Oct 18 07:54:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ADF616A41F; Tue, 18 Oct 2005 07:54:03 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 10DA043D46; Tue, 18 Oct 2005 07:54:03 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9I7s2Ue048912; Tue, 18 Oct 2005 07:54:02 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9I7s2SU048911; Tue, 18 Oct 2005 07:54:02 GMT (envelope-from yar) Message-Id: <200510180754.j9I7s2SU048911@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 18 Oct 2005 07:54:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules/if_gif Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 07:54:03 -0000 yar 2005-10-18 07:54:02 UTC FreeBSD src repository Modified files: sys/modules/if_gif Makefile Log: In this case, disable wrapping of fake opt_*.h targets in "if defined(KERNBUILDDIR)" for now since the new way of building modules with the kernel can't handle dynamic SRCS depending on build options yet. Revision Changes Path 1.8 +4 -2 src/sys/modules/if_gif/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 18 08:26:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E6C316A420; Tue, 18 Oct 2005 08:26:30 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id F278B43D48; Tue, 18 Oct 2005 08:26:26 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9I8QM0E095528; Tue, 18 Oct 2005 12:26:22 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9I8QMXH095527; Tue, 18 Oct 2005 12:26:22 +0400 (MSD) (envelope-from yar) Date: Tue, 18 Oct 2005 12:26:21 +0400 From: Yar Tikhiy To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20051018082621.GA95042@comp.chem.msu.su> References: <200510180754.j9I7s2SU048911@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510180754.j9I7s2SU048911@repoman.freebsd.org> User-Agent: Mutt/1.5.9i Cc: Subject: Re: cvs commit: src/sys/modules/if_gif Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 08:26:30 -0000 On Tue, Oct 18, 2005 at 07:54:02AM +0000, Yar Tikhiy wrote: > yar 2005-10-18 07:54:02 UTC > > FreeBSD src repository > > Modified files: > sys/modules/if_gif Makefile > Log: > In this case, disable wrapping of fake opt_*.h targets in > "if defined(KERNBUILDDIR)" for now since the new way of > building modules with the kernel can't handle dynamic SRCS > depending on build options yet. > > Revision Changes Path > 1.8 +4 -2 src/sys/modules/if_gif/Makefile This will remedy broken builds if there is no INET6 in the kernel config and return us to the previous state of matters when the default if_gif module is just useless in that case as it can't be loaded into an IPv6-disabled kernel. -- Yar From owner-cvs-src@FreeBSD.ORG Tue Oct 18 08:39:38 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CA6916A41F; Tue, 18 Oct 2005 08:39:38 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from mail09.syd.optusnet.com.au (mail09.syd.optusnet.com.au [211.29.132.190]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E04143D48; Tue, 18 Oct 2005 08:39:36 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail09.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id j9I8dTpf015040 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 18 Oct 2005 18:39:30 +1000 Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1]) by cirb503493.alcatel.com.au (8.12.10/8.12.10) with ESMTP id j9I8dTHh018169; Tue, 18 Oct 2005 18:39:29 +1000 (EST) (envelope-from pjeremy@cirb503493.alcatel.com.au) Received: (from pjeremy@localhost) by cirb503493.alcatel.com.au (8.12.10/8.12.9/Submit) id j9I8dT2s018168; Tue, 18 Oct 2005 18:39:29 +1000 (EST) (envelope-from pjeremy) Date: Tue, 18 Oct 2005 18:39:29 +1000 From: Peter Jeremy To: "David O'Brien" Message-ID: <20051018083929.GI7346@cirb503493.alcatel.com.au> References: <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> <20051018035902.GH53525@dragon.NUXI.org> <435473D3.8080209@freebsd.org> <20051018040808.GB23014@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051018040808.GB23014@dragon.NUXI.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 08:39:38 -0000 On Mon, 2005-Oct-17 21:08:08 -0700, David O'Brien wrote: >Should I add code on Opteron sytems to print the number of DIMM's >attached to each CPU? Or the amount of memory on each CPU? Hidden behind bootverbose and/or in the sysctl MIB, this could be useful. And something like prtconf or psrinfo would also be useful. > Or maybe the color of the CPU fans? I have about a dozen AlphaServer 4100's at work. Some of them (we don't know which) have CPU fans from a dodgy batch. It would be very useful to be able to identify the type of CPU fan without having to shutdown each system, pull the drawer out and open it up. >How far do we take it to avoid having to remove the case to know what the >HW inside is? Any hardware description information that can be extracted from the system should be accessible without having to physically open the case. Consider a system being managed remotely - it would be very handy to be able to identify what is inside the system without having to travel to a remote site (potentially in another country). You can also check that the vendor has supplied what you ordered/expected or that the trained monkey has put the correct bits into the correct slots. -- Peter Jeremy From owner-cvs-src@FreeBSD.ORG Tue Oct 18 09:43:18 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C161616A41F; Tue, 18 Oct 2005 09:43:18 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6471B43D48; Tue, 18 Oct 2005 09:43:18 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id D28D0BC84; Tue, 18 Oct 2005 09:43:15 +0000 (UTC) To: Peter Jeremy From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 18 Oct 2005 18:39:29 +1000." <20051018083929.GI7346@cirb503493.alcatel.com.au> Date: Tue, 18 Oct 2005 11:43:15 +0200 Message-ID: <67919.1129628595@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, David O'Brien Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 09:43:18 -0000 In message <20051018083929.GI7346@cirb503493.alcatel.com.au>, Peter Jeremy writ es: >Any hardware description information that can be extracted from the >system should be accessible without having to physically open the >case. I agree, but the code to do so should be located in userland programs rather than the kernel to the full extent possible. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Oct 18 11:46:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F0EA616A41F; Tue, 18 Oct 2005 11:46:24 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD16B43D45; Tue, 18 Oct 2005 11:46:24 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IBkOEs065633; Tue, 18 Oct 2005 11:46:24 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IBkOqs065632; Tue, 18 Oct 2005 11:46:24 GMT (envelope-from stefanf) Message-Id: <200510181146.j9IBkOqs065632@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 18 Oct 2005 11:46:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern syscalls.master uipc_sem.c src/sys/posix4 _semaphore.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 11:46:25 -0000 stefanf 2005-10-18 11:46:24 UTC FreeBSD src repository Modified files: sys/kern syscalls.master uipc_sem.c sys/posix4 _semaphore.h Log: Const-qualify ksem_timedwait's parameter abstime as it's only passed in. Revision Changes Path 1.201 +1 -1 src/sys/kern/syscalls.master 1.21 +1 -1 src/sys/kern/uipc_sem.c 1.5 +1 -1 src/sys/posix4/_semaphore.h From owner-cvs-src@FreeBSD.ORG Tue Oct 18 11:49:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28F8116A41F; Tue, 18 Oct 2005 11:49:15 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC09C43D49; Tue, 18 Oct 2005 11:49:14 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IBnE6e065804; Tue, 18 Oct 2005 11:49:14 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IBnEsQ065803; Tue, 18 Oct 2005 11:49:14 GMT (envelope-from stefanf) Message-Id: <200510181149.j9IBnEsQ065803@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 18 Oct 2005 11:49:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys sysproto.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 11:49:15 -0000 stefanf 2005-10-18 11:49:14 UTC FreeBSD src repository Modified files: sys/sys sysproto.h Log: Regenerate. Revision Changes Path 1.180 +2 -2 src/sys/sys/sysproto.h From owner-cvs-src@FreeBSD.ORG Tue Oct 18 13:35:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1514316A420; Tue, 18 Oct 2005 13:35:09 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF56C43D48; Tue, 18 Oct 2005 13:35:08 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IDZ8Gb077040; Tue, 18 Oct 2005 13:35:08 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IDZ8iW077039; Tue, 18 Oct 2005 13:35:08 GMT (envelope-from des) Message-Id: <200510181335.j9IDZ8iW077039@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Tue, 18 Oct 2005 13:35:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/isofs/cd9660 iso.h src/lib/libstand cd9660.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 13:35:09 -0000 des 2005-10-18 13:35:08 UTC FreeBSD src repository Modified files: sys/isofs/cd9660 iso.h lib/libstand cd9660.c Log: Implement the full range of ISO9660 number conversion routines in iso.h. MFC after: 2 weeks Revision Changes Path 1.12 +0 -15 src/lib/libstand/cd9660.c 1.31 +35 -49 src/sys/isofs/cd9660/iso.h From owner-cvs-src@FreeBSD.ORG Tue Oct 18 13:44:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EA1C16A41F; Tue, 18 Oct 2005 13:44:11 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id E284C43D45; Tue, 18 Oct 2005 13:44:08 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.13.4/8.13.4) with ESMTP id j9IDi7bF004865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2005 09:44:07 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id j9IDi2rC029214; Tue, 18 Oct 2005 09:44:02 -0400 (EDT) (envelope-from gallatin) Date: Tue, 18 Oct 2005 09:44:02 -0400 From: Andrew Gallatin To: David Xu Message-ID: <20051018094402.A29138@grasshopper.cs.duke.edu> References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200510172310.j9HNAVPL013057@repoman.freebsd.org>; from davidxu@FreeBSD.org on Mon, Oct 17, 2005 at 11:10:31PM +0000 X-Operating-System: FreeBSD 4.9-RELEASE-p1 on an i386 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 13:44:11 -0000 David Xu [davidxu@FreeBSD.org] wrote: > davidxu 2005-10-17 23:10:31 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 cpu_switch.S machdep.c > Log: > Micro optimization for context switch. Eliminate code for saving gs.base > and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase > when user wants to set them, in context switch routine, we only need to > write them into registers, we never have to read them out from registers > when thread is switched away. Since rdmsr is a serialization instruction, > micro benchmark shows it is worthy to do. Nice. This reduces lmbench context switch latency by about 0.4us (7.2 -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> 35.2) on my dual core 3800+ It is a shame we can't find a way to use the TSC as a timecounter on SMP systems. It seems that about 40% of the context switch time is spent just waiting for the PIO read of the ACPI-fast or i8254 to return. Drew From owner-cvs-src@FreeBSD.ORG Tue Oct 18 13:47:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9D2416A41F; Tue, 18 Oct 2005 13:47:39 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A0AB43D46; Tue, 18 Oct 2005 13:47:39 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 90716BC84; Tue, 18 Oct 2005 13:47:37 +0000 (UTC) To: Andrew Gallatin From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 18 Oct 2005 09:44:02 EDT." <20051018094402.A29138@grasshopper.cs.duke.edu> Date: Tue, 18 Oct 2005 15:47:36 +0200 Message-ID: <68671.1129643256@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Xu , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 13:47:40 -0000 In message <20051018094402.A29138@grasshopper.cs.duke.edu>, Andrew Gallatin wri tes: >It is a shame we can't find a way to use the TSC as a timecounter on >SMP systems. It seems that about 40% of the context switch time is >spent just waiting for the PIO read of the ACPI-fast or i8254 to >return. No, the shame is that the scheduler tries to partition time rather than cpu cycles because that approximation got goldplated in some random standard years back. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Oct 18 14:05:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4AE516A41F; Tue, 18 Oct 2005 14:05:24 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3377F43D45; Tue, 18 Oct 2005 14:05:24 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.13.4/8.13.4) with ESMTP id j9IE5NVU008917 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2005 10:05:23 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id j9IE5IbW029245; Tue, 18 Oct 2005 10:05:18 -0400 (EDT) (envelope-from gallatin) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17237.286.236279.883806@grasshopper.cs.duke.edu> Date: Tue, 18 Oct 2005 10:05:18 -0400 (EDT) To: "Poul-Henning Kamp" In-Reply-To: <68671.1129643256@critter.freebsd.dk> References: <20051018094402.A29138@grasshopper.cs.duke.edu> <68671.1129643256@critter.freebsd.dk> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 14:05:24 -0000 Poul-Henning Kamp writes: > In message <20051018094402.A29138@grasshopper.cs.duke.edu>, Andrew Gallatin wri > tes: > > >It is a shame we can't find a way to use the TSC as a timecounter on > >SMP systems. It seems that about 40% of the context switch time is > >spent just waiting for the PIO read of the ACPI-fast or i8254 to > >return. > > No, the shame is that the scheduler tries to partition time rather > than cpu cycles because that approximation got goldplated in some > random standard years back. Sorry if I mi-spoke. I guess the shame twofold. First we insist on not trying keep the TSC in sync and so we don't use it for SMP timekeeping like other OSes do, which means that getting a micro-second granularity timestamp is orders of magnitude more expensive for us. To compound the problem, we insist on using the expensive non-TSC binuptime() to get a runtime measurement on each context switch, rather than being able to use something cheap like ticks, or a per-cpu cycle counter. If anybody is looking for low-hanging fruit in the SMP context switch path, figuring some acceptable way to avoid reading the ACPI or i8254 timecounter is it. Drew From owner-cvs-src@FreeBSD.ORG Tue Oct 18 14:08:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA18616A41F; Tue, 18 Oct 2005 14:08:11 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED76543D4C; Tue, 18 Oct 2005 14:08:08 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.1.102] (69-161-144-40.miamfl.adelphia.net [69.161.144.40]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id j9IE7x4i051577; Tue, 18 Oct 2005 08:07:59 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <435501B9.4070401@samsco.org> Date: Tue, 18 Oct 2005 08:07:53 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Gallatin References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> In-Reply-To: <20051018094402.A29138@grasshopper.cs.duke.edu> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.0 required=3.8 tests=RCVD_IN_SORBS_DUL autolearn=no version=3.1.0 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Xu , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 14:08:11 -0000 Andrew Gallatin wrote: > David Xu [davidxu@FreeBSD.org] wrote: > >>davidxu 2005-10-17 23:10:31 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/amd64/amd64 cpu_switch.S machdep.c >> Log: >> Micro optimization for context switch. Eliminate code for saving gs.base >> and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase >> when user wants to set them, in context switch routine, we only need to >> write them into registers, we never have to read them out from registers >> when thread is switched away. Since rdmsr is a serialization instruction, >> micro benchmark shows it is worthy to do. > > > Nice. This reduces lmbench context switch latency by about 0.4us (7.2 > -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> > 35.2) on my dual core 3800+ > > It is a shame we can't find a way to use the TSC as a timecounter on > SMP systems. It seems that about 40% of the context switch time is > spent just waiting for the PIO read of the ACPI-fast or i8254 to > return. > > > Drew > > > The TSC represents the clock rate of the CPU, and thus can vary wildly when thermal and power management controls kick in, and there is no way to know when it changes. Because of this, I think that it's practically useless on Pentium-Mobile and Pentium-M chips, among many others. There is also the issue of multiple CPUs having to keep their TSC's somewhat in sync in order to get consistent counting in the system. The best that you can do is to periodically read a stable counter and try to recalibrate, but then you'll likely start getting wild operational variances. It's a shame that a PIO read is still so expensive. I'd hate to see just how bad your benchmark becomes when ACPI-slow is used instead of ACPI-fast. I wonder if moving to HZ=1000 on amd64 and i386 was really all that good of an idea. Having preemption in the kernel means that ithreads can run right away instead of having to wait for a tick, and various fixes to 4BSD in the past year have eliminated bugs that would make the CPU wait for up to a tick to schedule a thread. So all we're getting now is a 10x increase in scheduler overhead, including reading the timecounters. Scott From owner-cvs-src@FreeBSD.ORG Tue Oct 18 14:25:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BE7416A420; Tue, 18 Oct 2005 14:25:21 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CD9C43D46; Tue, 18 Oct 2005 14:25:20 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.13.4/8.13.4) with ESMTP id j9IEPJEo013225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2005 10:25:19 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id j9IEPESc029264; Tue, 18 Oct 2005 10:25:14 -0400 (EDT) (envelope-from gallatin) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17237.1482.52148.283282@grasshopper.cs.duke.edu> Date: Tue, 18 Oct 2005 10:25:14 -0400 (EDT) To: Scott Long In-Reply-To: <435501B9.4070401@samsco.org> References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <435501B9.4070401@samsco.org> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Xu , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 14:25:21 -0000 Scott Long writes: > Andrew Gallatin wrote: > > David Xu [davidxu@FreeBSD.org] wrote: > > > >>davidxu 2005-10-17 23:10:31 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/amd64/amd64 cpu_switch.S machdep.c > >> Log: > >> Micro optimization for context switch. Eliminate code for saving gs.base > >> and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase > >> when user wants to set them, in context switch routine, we only need to > >> write them into registers, we never have to read them out from registers > >> when thread is switched away. Since rdmsr is a serialization instruction, > >> micro benchmark shows it is worthy to do. > > > > > > Nice. This reduces lmbench context switch latency by about 0.4us (7.2 > > -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> > > 35.2) on my dual core 3800+ > > > > It is a shame we can't find a way to use the TSC as a timecounter on > > SMP systems. It seems that about 40% of the context switch time is > > spent just waiting for the PIO read of the ACPI-fast or i8254 to > > return. > > > > > > Drew > > > > > > > > The TSC represents the clock rate of the CPU, and thus can vary wildly > when thermal and power management controls kick in, and there is no way > to know when it changes. Because of this, I think that it's > practically useless on Pentium-Mobile and Pentium-M chips, among many > others. There is also the issue of multiple CPUs having to keep their > TSC's somewhat in sync in order to get consistent counting in the > system. The best that you can do is to periodically read a stable > counter and try to recalibrate, but then you'll likely start getting > wild operational variances. As I pointed out in another thread, both linux and solaris do it. Solaris seems to have a nice algorithm for keeping things in sync, and accounting for the TSC getting cleared after suspend/resume etc. At my level of understanding, this argument is nothing more than "but Mom, all the other kids are doing it". I was just hoping that somebody with real understanding could pick up on it. > It's a shame that a PIO read is still so > expensive. I'd hate to see just how bad your benchmark becomes when > ACPI-slow is used instead of ACPI-fast. It seems like reading ACPI-fast is "only" 3us or so, but when the ctx switch is otherwise 4us, it adds up. i8254 is much worse on this system (6.5us). > I wonder if moving to HZ=1000 on amd64 and i386 was really all that good > of an idea. Having preemption in the kernel means that ithreads can run > right away instead of having to wait for a tick, and various fixes to > 4BSD in the past year have eliminated bugs that would make the CPU wait > for up to a tick to schedule a thread. So all we're getting now is a > 10x increase in scheduler overhead, including reading the timecounters. Yeah. I moved my back to hz=1000 when I noticed 4000 interrupts/sec on an idle system. Drew From owner-cvs-src@FreeBSD.ORG Tue Oct 18 14:35:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 236B116A420; Tue, 18 Oct 2005 14:35:08 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9028343D45; Tue, 18 Oct 2005 14:35:07 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.1.102] (69-161-144-40.miamfl.adelphia.net [69.161.144.40]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id j9IEZ3ke055368; Tue, 18 Oct 2005 08:35:03 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4355080C.302@samsco.org> Date: Tue, 18 Oct 2005 08:34:52 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Gallatin References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <435501B9.4070401@samsco.org> <17237.1482.52148.283282@grasshopper.cs.duke.edu> In-Reply-To: <17237.1482.52148.283282@grasshopper.cs.duke.edu> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.0 required=3.8 tests=RCVD_IN_SORBS_DUL autolearn=no version=3.1.0 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Xu , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 14:35:08 -0000 Andrew Gallatin wrote: > Scott Long writes: > > Andrew Gallatin wrote: > > > David Xu [davidxu@FreeBSD.org] wrote: > > > > > >>davidxu 2005-10-17 23:10:31 UTC > > >> > > >> FreeBSD src repository > > >> > > >> Modified files: > > >> sys/amd64/amd64 cpu_switch.S machdep.c > > >> Log: > > >> Micro optimization for context switch. Eliminate code for saving gs.base > > >> and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase > > >> when user wants to set them, in context switch routine, we only need to > > >> write them into registers, we never have to read them out from registers > > >> when thread is switched away. Since rdmsr is a serialization instruction, > > >> micro benchmark shows it is worthy to do. > > > > > > > > > Nice. This reduces lmbench context switch latency by about 0.4us (7.2 > > > -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> > > > 35.2) on my dual core 3800+ > > > > > > It is a shame we can't find a way to use the TSC as a timecounter on > > > SMP systems. It seems that about 40% of the context switch time is > > > spent just waiting for the PIO read of the ACPI-fast or i8254 to > > > return. > > > > > > > > > Drew > > > > > > > > > > > > > The TSC represents the clock rate of the CPU, and thus can vary wildly > > when thermal and power management controls kick in, and there is no way > > to know when it changes. Because of this, I think that it's > > practically useless on Pentium-Mobile and Pentium-M chips, among many > > others. There is also the issue of multiple CPUs having to keep their > > TSC's somewhat in sync in order to get consistent counting in the > > system. The best that you can do is to periodically read a stable > > counter and try to recalibrate, but then you'll likely start getting > > wild operational variances. > > As I pointed out in another thread, both linux and solaris do it. > Solaris seems to have a nice algorithm for keeping things in sync, and > accounting for the TSC getting cleared after suspend/resume etc. At > my level of understanding, this argument is nothing more than "but > Mom, all the other kids are doing it". I was just hoping that > somebody with real understanding could pick up on it. Steering mutliple TSC's together isn't that hard and there are plenty of examples, as you point out. Accounting for the changes due to thermal and power management (note that this isn't the same problem as suspend and resume) is what worries me. > > > It's a shame that a PIO read is still so > > expensive. I'd hate to see just how bad your benchmark becomes when > > ACPI-slow is used instead of ACPI-fast. > > It seems like reading ACPI-fast is "only" 3us or so, but when the ctx > switch is otherwise 4us, it adds up. i8254 is much worse on this > system (6.5us). > > > I wonder if moving to HZ=1000 on amd64 and i386 was really all that good > > of an idea. Having preemption in the kernel means that ithreads can run > > right away instead of having to wait for a tick, and various fixes to > > 4BSD in the past year have eliminated bugs that would make the CPU wait > > for up to a tick to schedule a thread. So all we're getting now is a > > 10x increase in scheduler overhead, including reading the timecounters. > > Yeah. I moved my back to hz=1000 when I noticed 4000 interrupts/sec > on an idle system. > > Drew Do you mean 1000 or 100 here? Anyways, the high clock interrupt rate is so that we can use the local apic clock to get the various system ticks that we have instead of continuing to fight motherboards that no longer hook up the 8259 in a sane way. This is why 5.x doesn't work well on a number of new motherboards (nvidia ones especially) but 6.x works just fine. Scott From owner-cvs-src@FreeBSD.ORG Tue Oct 18 14:41:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3AB816A41F; Tue, 18 Oct 2005 14:41:07 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E31E43D4C; Tue, 18 Oct 2005 14:41:07 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9IEexZI085144; Tue, 18 Oct 2005 07:40:59 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9IEewwv085143; Tue, 18 Oct 2005 07:40:58 -0700 (PDT) (envelope-from obrien) Date: Tue, 18 Oct 2005 07:40:58 -0700 From: "David O'Brien" To: Andrew Gallatin Message-ID: <20051018144058.GA84920@dragon.NUXI.org> References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051018094402.A29138@grasshopper.cs.duke.edu> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Xu , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 14:41:07 -0000 On Tue, Oct 18, 2005 at 09:44:02AM -0400, Andrew Gallatin wrote: > It is a shame we can't find a way to use the TSC as a timecounter on > SMP systems. It seems that about 40% of the context switch time is > spent just waiting for the PIO read of the ACPI-fast or i8254 to > return. Revision F Opterion's will have the RDTSCP (read serialized TSC pair) instruction that helps some. Slide 13 of http://www.amd.com/us-en/assets/content_type/DownloadableAssets/dwamd_kernel_summit_08_RB.pdf Future Opteron's (or what ever AMD will call it then) will have a P-state invarient TSC in 2007. http://lwn.net/Articles/144098/ -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 14:48:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A704916A41F; Tue, 18 Oct 2005 14:48:21 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr6.xs4all.nl (smtp-vbr6.xs4all.nl [194.109.24.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED26643D45; Tue, 18 Oct 2005 14:48:20 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr6.xs4all.nl (8.13.3/8.13.3) with ESMTP id j9IEmGGR022364; Tue, 18 Oct 2005 16:48:16 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.3/8.13.3) with ESMTP id j9IEmFFQ002381; Tue, 18 Oct 2005 16:48:15 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.3/8.13.1/Submit) id j9IEmFIt002380; Tue, 18 Oct 2005 16:48:15 +0200 (CEST) (envelope-from wb) Date: Tue, 18 Oct 2005 16:48:15 +0200 From: Wilko Bulte To: "David O'Brien" Message-ID: <20051018144815.GA2345@freebie.xs4all.nl> References: <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> <20051018035902.GH53525@dragon.NUXI.org> <435473D3.8080209@freebsd.org> <20051018040808.GB23014@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051018040808.GB23014@dragon.NUXI.org> X-OS: FreeBSD 5.4-STABLE User-Agent: Mutt/1.5.9i X-Virus-Scanned: by XS4ALL Virus Scanner Cc: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, Eric Anholt , cvs-all@FreeBSD.ORG, Gleb Smirnoff , Colin Percival , Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 14:48:21 -0000 On Mon, Oct 17, 2005 at 09:08:08PM -0700, David O'Brien wrote.. > On Mon, Oct 17, 2005 at 09:02:27PM -0700, Colin Percival wrote: > > David O'Brien wrote: > > > Why is this not clear? > > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) > > > > > > They are 200 series Opteron - you can have only 2 (or 1) in a system. > > > They are dual-core. > > > > This may be clear to *you*, but five years from now I'm sure that *I* won't > > be able to remember what the AMD Opteron 280 is. > > > > If in doubt, present the same information several times in different ways. > > Should I add code on Opteron sytems to print the number of DIMM's > attached to each CPU? Or the amount of memory on each CPU? Or maybe the For a NUMA machine, sure, the DIMM config could mean something ;) > Why is it we don't print out the cache configuration unless it is a > verbose boot? I would find that information quite useful also so I > wouldn't have to look up CPU model names, etc.. Interesting question.. -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Oct 18 14:48:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B384816A41F; Tue, 18 Oct 2005 14:48:53 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 093B443D46; Tue, 18 Oct 2005 14:48:52 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.13.4/8.13.4) with ESMTP id j9IEmoQW018765 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2005 10:48:50 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id j9IEmjtg029282; Tue, 18 Oct 2005 10:48:45 -0400 (EDT) (envelope-from gallatin) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17237.2893.263419.610951@grasshopper.cs.duke.edu> Date: Tue, 18 Oct 2005 10:48:45 -0400 (EDT) To: Scott Long In-Reply-To: <4355080C.302@samsco.org> References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <435501B9.4070401@samsco.org> <17237.1482.52148.283282@grasshopper.cs.duke.edu> <4355080C.302@samsco.org> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Xu , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 14:48:53 -0000 Scott Long writes: > Andrew Gallatin wrote: > > As I pointed out in another thread, both linux and solaris do it. > > Solaris seems to have a nice algorithm for keeping things in sync, and > > accounting for the TSC getting cleared after suspend/resume etc. At > > my level of understanding, this argument is nothing more than "but > > Mom, all the other kids are doing it". I was just hoping that > > somebody with real understanding could pick up on it. > > Steering mutliple TSC's together isn't that hard and there are plenty of > examples, as you point out. Accounting for the changes due to thermal > and power management (note that this isn't the same problem as suspend > and resume) is what worries me. Yes, I have no answer for this :( > > Yeah. I moved my back to hz=1000 when I noticed 4000 interrupts/sec > > on an idle system. > > > > Drew > > Do you mean 1000 or 100 here? Anyways, the high clock interrupt rate is Sorry.. That was a typo. I meant hz=100. Drew From owner-cvs-src@FreeBSD.ORG Tue Oct 18 14:49:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F50016A420; Tue, 18 Oct 2005 14:49:38 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr5.xs4all.nl (smtp-vbr5.xs4all.nl [194.109.24.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C6FC43D49; Tue, 18 Oct 2005 14:49:36 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr5.xs4all.nl (8.13.3/8.13.3) with ESMTP id j9IEnZNa012343; Tue, 18 Oct 2005 16:49:35 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.3/8.13.3) with ESMTP id j9IEnYxB002392; Tue, 18 Oct 2005 16:49:34 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.3/8.13.1/Submit) id j9IEnYcT002391; Tue, 18 Oct 2005 16:49:34 +0200 (CEST) (envelope-from wb) Date: Tue, 18 Oct 2005 16:49:34 +0200 From: Wilko Bulte To: Poul-Henning Kamp Message-ID: <20051018144934.GB2345@freebie.xs4all.nl> References: <20051018083929.GI7346@cirb503493.alcatel.com.au> <67919.1129628595@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67919.1129628595@critter.freebsd.dk> X-OS: FreeBSD 5.4-STABLE User-Agent: Mutt/1.5.9i X-Virus-Scanned: by XS4ALL Virus Scanner Cc: Peter Jeremy , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, David O'Brien , cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 14:49:38 -0000 On Tue, Oct 18, 2005 at 11:43:15AM +0200, Poul-Henning Kamp wrote.. > In message <20051018083929.GI7346@cirb503493.alcatel.com.au>, Peter Jeremy writ > es: > > >Any hardware description information that can be extracted from the > >system should be accessible without having to physically open the > >case. > > I agree, but the code to do so should be located in userland programs > rather than the kernel to the full extent possible. But still the kernel needs to gather that information somehow. -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:20:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A99E16A41F; Tue, 18 Oct 2005 15:20:45 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 963CD43D48; Tue, 18 Oct 2005 15:20:44 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9IFKhNR091761; Tue, 18 Oct 2005 08:20:43 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9IFKh4E091760; Tue, 18 Oct 2005 08:20:43 -0700 (PDT) (envelope-from obrien) Date: Tue, 18 Oct 2005 08:20:43 -0700 From: "David O'Brien" To: Gleb Smirnoff Message-ID: <20051018152043.GC84920@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> <20051018035902.GH53525@dragon.NUXI.org> <20051018065659.GD59364@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051018065659.GD59364@cell.sick.ru> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, Jung-uk Kim , src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:20:45 -0000 On Tue, Oct 18, 2005 at 10:56:59AM +0400, Gleb Smirnoff wrote: > On Mon, Oct 17, 2005 at 08:59:02PM -0700, David O'Brien wrote: > D> Why is this not clear? > D> > D> CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) ... > D> > When maintaining hundreds of systems in server > D> > room, people usually forget what lives inside the computer cases. And > D> > when one needs to tell what is the motherboard and how many sockets > D> > and fans it has, he should be capable to do this without opening > D> > the case. > D> > D> The above dmesg doesn't tell this to you? > > Only after you have explained it. If I am a new FreeBSD user, I won't > understand that I have two sockets with two dual core CPUs. You will understand you have dual-core CPU's - I don't see how you could misunderstand: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) What is missing is the information of how many sockets you have in the machine. Jkim's patch doesn't fix that. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:22:02 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C91E16A41F; Tue, 18 Oct 2005 15:22:02 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9607C43D53; Tue, 18 Oct 2005 15:22:01 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9IFM1Up091786; Tue, 18 Oct 2005 08:22:01 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9IFM0Vg091785; Tue, 18 Oct 2005 08:22:00 -0700 (PDT) (envelope-from obrien) Date: Tue, 18 Oct 2005 08:22:00 -0700 From: "David O'Brien" To: Daniel Eischen Message-ID: <20051018152200.GD84920@dragon.NUXI.org> References: <435473D3.8080209@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Colin Percival Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:22:02 -0000 On Tue, Oct 18, 2005 at 12:50:30AM -0400, Daniel Eischen wrote: > On Mon, 17 Oct 2005, Colin Percival wrote: > > David O'Brien wrote: > > > Why is this not clear? > > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) > ^^^^ ... > > This may be clear to *you*, but five years from now I'm sure that *I* won't > > be able to remember what the AMD Opteron 280 is. > > Am I missing something? Would it still say "Dual" if it were not a > dual core? No it would not. I'm not sure what this added: CPU: Dual Core AMD Opteron(tm) Processor 280 (2394.81-MHz K8-class .. Cores per package: 2 -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:27:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8377416A41F; Tue, 18 Oct 2005 15:27:08 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 148AB43D46; Tue, 18 Oct 2005 15:27:05 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9IFYuxr003794; Tue, 18 Oct 2005 11:34:56 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: obrien@FreeBSD.org Date: Tue, 18 Oct 2005 11:26:49 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <20051018065659.GD59364@cell.sick.ru> <20051018152043.GC84920@dragon.NUXI.org> In-Reply-To: <20051018152043.GC84920@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510181126.52097.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1142/Tue Oct 18 03:21:37 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, Gleb Smirnoff , Eric Anholt , src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:27:08 -0000 On Tuesday 18 October 2005 11:20 am, David O'Brien wrote: > On Tue, Oct 18, 2005 at 10:56:59AM +0400, Gleb Smirnoff wrote: > > On Mon, Oct 17, 2005 at 08:59:02PM -0700, David O'Brien wrote: > > D> Why is this not clear? > > D> > > D> CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz > > K8-class CPU) > > ... > > > D> > When maintaining hundreds of systems in server > > D> > room, people usually forget what lives inside the computer > > cases. And D> > when one needs to tell what is the motherboard > > and how many sockets D> > and fans it has, he should be capable > > to do this without opening D> > the case. > > D> > > D> The above dmesg doesn't tell this to you? > > > > Only after you have explained it. If I am a new FreeBSD user, I > > won't understand that I have two sockets with two dual core CPUs. > > You will understand you have dual-core CPU's - I don't see how you > could misunderstand: > Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class > CPU) > > What is missing is the information of how many sockets you have in > the machine. Jkim's patch doesn't fix that. That's not I wanted to 'fix.' I wanted to give more information. That's all. OTOH, you can get the number of existing sockets and populated sockets via SMBIOS. I have done that before and it is quite easy to implement in src/sys/boot/i386/libi386/smbios.c. Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:31:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 236BC16A41F; Tue, 18 Oct 2005 15:31:39 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 961F143D45; Tue, 18 Oct 2005 15:31:38 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id D8B4EBC84; Tue, 18 Oct 2005 15:31:31 +0000 (UTC) To: Scott Long From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 18 Oct 2005 08:34:52 MDT." <4355080C.302@samsco.org> Date: Tue, 18 Oct 2005 17:31:31 +0200 Message-ID: <69026.1129649491@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:31:39 -0000 In message <4355080C.302@samsco.org>, Scott Long writes: [At the risk of repeating myself once more...] >Steering mutliple TSC's together isn't that hard and there are plenty of >examples, as you point out. Accounting for the changes due to thermal >and power management (note that this isn't the same problem as suspend >and resume) is what worries me. It all depends what you mean by "hard" and what benefit you expect to arrive at. One of the things you have to realize is that once you go down this road you need a lot of code for all the conditionals. For instance you need to make sure that every new timestamp you hand out not prior to another one, no matter what is happening to the clocks. Imagine one CPU throttling because of heat, that CPU will be handing out timestamps in the past until the TSC slowdown has been corrected, meanwhile the other CPU in the system churns on at full speed. To solve this, you need to pessimize every timestamp with an intercpu lock to compare against the previous timestamp and if less you have to do the Lamport-trick and return the "previous timestamp + epsilon". Then there is the question of how you adapt, a stepwise adaptation is hard to get right without overshoot, and stability is far from a given. Dave Mills implemented a scheme on Alpha to have a per-cpu PLL which where clocked by a common interrupt from the RTC. The results were interesting, but hardly revolutionary, and performance wise it sucked. So, yes, it may not be "hard" in the "write an OS from scratch" sense of "hard", but it is certainly far from trivial, comes with a heavy penalty in complexity and a notable shortage of successful prior art. One of the things we pride ourselves off in FreeBSD is stability, and the current code (finally!) provides that: It has been a long time since we last hard timecounter issues with broken hardware. But if people are certain their TSC's are good and sound, they can override the default safe selection of ACPI with a sysctl, and in doing so, they can take a calculated risk. That, IMO, is the correct "FreeBSD way" to handle this: "Safe out of the box. Informed tweaking may be profitable." I would hate to have to go to the other side where some fraction of users which happen to use hardware with problems in this space will have to disable something to get stable operation or to avoid unexplained undesirable transient phenomena. >> It seems like reading ACPI-fast is "only" 3us or so, but when the ctx >> switch is otherwise 4us, it adds up. i8254 is much worse on this >> system (6.5us). i8254 is always bad, and about as bad as it can. Mostly because of the need to disable interrupts (Actually, that's a critical section today, isn't it ?) and also hobbled by the three 8 bit ISA-bus(-like) accesses needed. >> > I wonder if moving to HZ=1000 on amd64 and i386 was really all that good >> > of an idea. The main benefit was getting more precise timeouts, something we have at various times thought about implementing with deadline counters on platforms that have it. Nobody has done it though. So, instead of looking for "quick fixes", lets look at this with a designers or architects view: On a busy system the scheduler works hundred thousand times per second, but on most systems nobody ever looks at the times(2) data. The smart solution is therefore to postpone the heavy stuff into times(2) and make the scheduler work as fast as it can. So the scheduler should read the TSC and schedule in TSC-ticks. times(2) will then have to convert this to clock_t compatible numbers. According the The Open Group, clock_t is in microseconds by means of historical standards mistakes. However, I can see nowhere that would collide with an interpretation that said "clock_t is microseconds PROVIDED the cpu had run at full speed", so a simple one second routine to latch the highest number of TSC-tics we've seen in a second would be sufficient to generate the conversion factor. And in many ways this would be a much more useful metric to offer (in top(1)) than the current rubber-band-cpu-seconds. Poul-Henning [1] A problem with this plan of course is that some CPU's don't have TSCs, but a fallback mechanism to use whatever timecounter is active as TSC. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:37:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A012B16A41F; Tue, 18 Oct 2005 15:37:16 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 44EF543D45; Tue, 18 Oct 2005 15:37:16 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9IFbFvP092005; Tue, 18 Oct 2005 08:37:15 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9IFbFLK092004; Tue, 18 Oct 2005 08:37:15 -0700 (PDT) (envelope-from obrien) Date: Tue, 18 Oct 2005 08:37:15 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051018153715.GE84920@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <1129576130.1152.30.camel@leguin> <200510171554.46682.jhb@freebsd.org> <200510171642.26719.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171642.26719.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:37:16 -0000 On Mon, Oct 17, 2005 at 04:42:24PM -0400, Jung-uk Kim wrote: > The patch is attached. Please review. It would be nice if you'd wait more than a few hours before committing something when you've asked for a review of it... especially when the discussion is still on-going. The patch you committed added nothing. Unless you think the user does not understand the meaning of the word "dual". What is missing is the number of _packages_ (populated sockets) in the system. CPU: Dual Core AMD Opteron(tm) Processor 280 (2394.49-MHz K8-class CPU) .. Found 2 sockets with 2 cores per package seems a more informative output for the user. Quick prototype: Index: sys/amd64/amd64/identcpu.c =================================================================== RCS file: /home/ncvs/src/sys/amd64/amd64/identcpu.c,v retrieving revision 1.140 diff -u -u -1 -r1.140 identcpu.c --- sys/amd64/amd64/identcpu.c 17 Oct 2005 23:23:20 -0000 1.140 +++ sys/amd64/amd64/identcpu.c 18 Oct 2005 15:30:16 -0000 @@ -51,2 +51,3 @@ #include +#include @@ -360,3 +361,4 @@ if (cmp > 1) - printf("\n Cores per package: %d", cmp); + printf("\n Found %d sockets with %d cores per package", + mp_ncpus / cmp, cmp); if ((htt / cmp) > 1) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:41:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B025616A41F; Tue, 18 Oct 2005 15:41:52 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A63843D48; Tue, 18 Oct 2005 15:41:52 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9IFnbsd004252; Tue, 18 Oct 2005 11:49:37 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: obrien@FreeBSD.org Date: Tue, 18 Oct 2005 11:41:31 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171850.39961.jkim@FreeBSD.org> <20051018040021.GI53525@dragon.NUXI.org> In-Reply-To: <20051018040021.GI53525@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510181141.33541.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1142/Tue Oct 18 03:21:37 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: src-committers@FreeBSD.org, Brooks Davis , cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, Gleb Smirnoff Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:41:52 -0000 On Tuesday 18 October 2005 12:00 am, David O'Brien wrote: > On Mon, Oct 17, 2005 at 06:50:38PM -0400, Jung-uk Kim wrote: > > On Monday 17 October 2005 06:00 pm, Brooks Davis wrote: > > > I'm not sure that I care what dmesg says, but I do want an > > > accurate view of our topology presented by the system, not some > > > arbitrary and frankly meaningless CPU count. If nothing else I > > > care because the two cores share one memory controller. That > > > may not be all that noticable now for normal application, but I > > > expect it will be once we start seeing 4+ core CPUs. Telling > > > the user the (somewhat complicated) truth about their hardware > > > is part of "doing it right". > > > > I believe we have to implement ACPI SRAT (Static Resource > > Affinity Table) and SLIT (System Locality Information Table) to > > achieve this. > > No kidding - I've said this many times and that this is an area I'm > working in. I am sorry if I missed it. > I've mentioned this to you before. No, you haven't. http://lists.freebsd.org/pipermail/freebsd-amd64/2005-July/005473.html I searched every mailbox that I have archived from 2001 but got nothing. Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:50:47 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AD4B16A41F; Tue, 18 Oct 2005 15:50:47 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EA3A43D46; Tue, 18 Oct 2005 15:50:46 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Tue, 18 Oct 2005 12:07:16 -0400 From: John Baldwin To: Andrew Gallatin Date: Tue, 18 Oct 2005 11:01:02 -0400 User-Agent: KMail/1.8.2 References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> In-Reply-To: <20051018094402.A29138@grasshopper.cs.duke.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510181101.03956.jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, David Xu , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:50:47 -0000 On Tuesday 18 October 2005 09:44 am, Andrew Gallatin wrote: > David Xu [davidxu@FreeBSD.org] wrote: > > davidxu 2005-10-17 23:10:31 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/amd64 cpu_switch.S machdep.c > > Log: > > Micro optimization for context switch. Eliminate code for saving > > gs.base and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase > > when user wants to set them, in context switch routine, we only need to > > write them into registers, we never have to read them out from registers > > when thread is switched away. Since rdmsr is a serialization instruction, > > micro benchmark shows it is worthy to do. > > Nice. This reduces lmbench context switch latency by about 0.4us (7.2 > -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> > 35.2) on my dual core 3800+ > > It is a shame we can't find a way to use the TSC as a timecounter on > SMP systems. It seems that about 40% of the context switch time is > spent just waiting for the PIO read of the ACPI-fast or i8254 to > return. You can try it by just setting the kern.timecounter.smp_tsc=1 tunable on boot. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:50:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8614816A439; Tue, 18 Oct 2005 15:50:49 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0760543D45; Tue, 18 Oct 2005 15:50:48 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j9IFweQV004634; Tue, 18 Oct 2005 11:58:40 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: obrien@FreeBSD.org Date: Tue, 18 Oct 2005 11:50:31 -0400 User-Agent: KMail/1.6.2 References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171642.26719.jkim@FreeBSD.org> <20051018153715.GE84920@dragon.NUXI.org> In-Reply-To: <20051018153715.GE84920@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200510181150.36257.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV devel-20050919/1142/Tue Oct 18 03:21:37 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:50:49 -0000 On Tuesday 18 October 2005 11:37 am, David O'Brien wrote: > @@ -360,3 +361,4 @@ > if (cmp > 1) > - printf("\n Cores per package: %d", cmp); > + printf("\n Found %d sockets with %d cores per package", > + mp_ncpus / cmp, cmp); > if ((htt / cmp) > 1) You are always assuming there's nothing but SMP kernel. Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Tue Oct 18 15:54:43 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFC5516A41F; Tue, 18 Oct 2005 15:54:43 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E1EE43D45; Tue, 18 Oct 2005 15:54:43 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.13.4/8.13.4) with ESMTP id j9IFsgQ7003688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2005 11:54:42 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id j9IFsbtQ030042; Tue, 18 Oct 2005 11:54:37 -0400 (EDT) (envelope-from gallatin) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17237.6845.390864.858367@grasshopper.cs.duke.edu> Date: Tue, 18 Oct 2005 11:54:37 -0400 (EDT) To: John Baldwin In-Reply-To: <200510181101.03956.jhb@freebsd.org> References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <200510181101.03956.jhb@freebsd.org> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Cc: cvs-src@freebsd.org, src-committers@freebsd.org, David Xu , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 15:54:44 -0000 John Baldwin writes: > On Tuesday 18 October 2005 09:44 am, Andrew Gallatin wrote: > > David Xu [davidxu@FreeBSD.org] wrote: > > > davidxu 2005-10-17 23:10:31 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/amd64/amd64 cpu_switch.S machdep.c > > > Log: > > > Micro optimization for context switch. Eliminate code for saving > > > gs.base and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase > > > when user wants to set them, in context switch routine, we only need to > > > write them into registers, we never have to read them out from registers > > > when thread is switched away. Since rdmsr is a serialization instruction, > > > micro benchmark shows it is worthy to do. > > > > Nice. This reduces lmbench context switch latency by about 0.4us (7.2 > > -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> > > 35.2) on my dual core 3800+ > > > > It is a shame we can't find a way to use the TSC as a timecounter on > > SMP systems. It seems that about 40% of the context switch time is > > spent just waiting for the PIO read of the ACPI-fast or i8254 to > > return. > > You can try it by just setting the kern.timecounter.smp_tsc=1 tunable on boot. Yes, that's how I get my figure of 3us for PIO read, and 3.8us for the rest of the context switch. But its not currently practical on most machines, since we don't sync the TSC between cpus, or do anything to account for drift. Drew From owner-cvs-src@FreeBSD.ORG Tue Oct 18 16:11:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C98EE16A41F; Tue, 18 Oct 2005 16:11:49 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 748C843D55; Tue, 18 Oct 2005 16:11:49 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IGBnop083760; Tue, 18 Oct 2005 16:11:49 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IGBnH2083758; Tue, 18 Oct 2005 16:11:49 GMT (envelope-from ache) Message-Id: <200510181611.j9IGBnH2083758@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Tue, 18 Oct 2005 16:11:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/termcap termcap.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 16:11:50 -0000 ache 2005-10-18 16:11:49 UTC FreeBSD src repository Modified files: share/termcap termcap.src Log: xterm-basic: add AX flag (the same in xterm-supplied termcap) Revision Changes Path 1.146 +1 -1 src/share/termcap/termcap.src From owner-cvs-src@FreeBSD.ORG Tue Oct 18 16:40:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C476816A420; Tue, 18 Oct 2005 16:40:06 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id A902743D4C; Tue, 18 Oct 2005 16:40:05 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9IGe5HR093516; Tue, 18 Oct 2005 09:40:05 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9IGe58M093507; Tue, 18 Oct 2005 09:40:05 -0700 (PDT) (envelope-from obrien) Date: Tue, 18 Oct 2005 09:40:01 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051018164001.GA92638@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171642.26719.jkim@FreeBSD.org> <20051018153715.GE84920@dragon.NUXI.org> <200510181150.36257.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510181150.36257.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 16:40:07 -0000 On Tue, Oct 18, 2005 at 11:50:31AM -0400, Jung-uk Kim wrote: > On Tuesday 18 October 2005 11:37 am, David O'Brien wrote: > > @@ -360,3 +361,4 @@ > > if (cmp > 1) > > - printf("\n Cores per package: %d", cmp); > > + printf("\n Found %d sockets with %d cores per package", > > + mp_ncpus / cmp, cmp); > > if ((htt / cmp) > 1) > > You are always assuming there's nothing but SMP kernel. To start with, I said this was a quick prototype - to discuss the DESIRED OUTPUT until we get a better situation than now. So yeah, its got assumptions. That said, one needs to be running an SMP kernel to get any benefit on a multi-core system. If you're running a UP kernel, then printing out "Found 1 socket(s) with 1 core per package" is accurate from the kernel's POV. If we want a purely HW POV, we should add a userland app that uses your SMBIOS code. Or maybe this should be made generic and pushed to sys/kern/ as CMP and SMT isn't x86-only. It exists also in the Sparc and MIPS worlds. -- -- David (obrien@FreeBSD.org) Tweaked for UP kernels: Index: sys/amd64/amd64/identcpu.c =================================================================== RCS file: /home/ncvs/src/sys/amd64/amd64/identcpu.c,v retrieving revision 1.140 diff -u -u -1 -r1.140 identcpu.c --- sys/amd64/amd64/identcpu.c 17 Oct 2005 23:23:20 -0000 1.140 +++ sys/amd64/amd64/identcpu.c 18 Oct 2005 16:34:02 -0000 @@ -51,2 +51,3 @@ #include +#include @@ -360,3 +361,4 @@ if (cmp > 1) - printf("\n Cores per package: %d", cmp); + printf("\n Found %d socket(s) with %d cores per package", + mp_ncpus > 1 ? mp_ncpus / cmp : mp_ncpus, cmp); if ((htt / cmp) > 1) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 16:42:24 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C1FB16A41F; Tue, 18 Oct 2005 16:42:24 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3F3F43D48; Tue, 18 Oct 2005 16:42:23 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Tue, 18 Oct 2005 12:58:54 -0400 From: John Baldwin To: obrien@freebsd.org Date: Tue, 18 Oct 2005 12:43:52 -0400 User-Agent: KMail/1.8.2 References: <435473D3.8080209@freebsd.org> <20051018152200.GD84920@dragon.NUXI.org> In-Reply-To: <20051018152200.GD84920@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510181243.54588.jhb@freebsd.org> Cc: Daniel Eischen , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Colin Percival Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 16:42:24 -0000 On Tuesday 18 October 2005 11:22 am, David O'Brien wrote: > On Tue, Oct 18, 2005 at 12:50:30AM -0400, Daniel Eischen wrote: > > On Mon, 17 Oct 2005, Colin Percival wrote: > > > David O'Brien wrote: > > > > Why is this not clear? > > > > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class > > > > CPU) > > > > ^^^^ > > ... > > > > This may be clear to *you*, but five years from now I'm sure that *I* > > > won't be able to remember what the AMD Opteron 280 is. > > > > Am I missing something? Would it still say "Dual" if it were not a > > dual core? > > No it would not. I'm not sure what this added: > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2394.81-MHz K8-class > .. > Cores per package: 2 Just because your employer formats brand info strings that way doesn't mean other chip manufacturers will. FreeBSD as a project does not just run on your employer's products, so we can't really make assumptions about the layout of description strings that are free-form and vary from vendor to vendor. By obtaining the actual values from registers and outputting them in a vendor-neutral way, FreeBSD as a project can provide this info to our users across architectures (i386 and amd64) and across vendors (AMD and Intel) in a uniform way. This is much more user friendly. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Oct 18 16:51:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3473316A420; Tue, 18 Oct 2005 16:51:52 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CF3843D48; Tue, 18 Oct 2005 16:51:51 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.120.198.17] ([209.101.72.251]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j9IGpdxq015479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 18 Oct 2005 09:51:40 -0700 Message-ID: <435527DD.3040007@root.org> Date: Tue, 18 Oct 2005 09:50:37 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Gallatin References: <20051018094402.A29138@grasshopper.cs.duke.edu> <68671.1129643256@critter.freebsd.dk> <17237.286.236279.883806@grasshopper.cs.duke.edu> In-Reply-To: <17237.286.236279.883806@grasshopper.cs.duke.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 16:51:52 -0000 Andrew Gallatin wrote: > Poul-Henning Kamp writes: > > In message <20051018094402.A29138@grasshopper.cs.duke.edu>, Andrew Gallatin wri > > tes: > > > > >It is a shame we can't find a way to use the TSC as a timecounter on > > >SMP systems. It seems that about 40% of the context switch time is > > >spent just waiting for the PIO read of the ACPI-fast or i8254 to > > >return. > > > > No, the shame is that the scheduler tries to partition time rather > > than cpu cycles because that approximation got goldplated in some > > random standard years back. > > Sorry if I mi-spoke. I guess the shame twofold. > > First we insist on not trying keep the TSC in sync and so we don't use > it for SMP timekeeping like other OSes do, which means that getting a > micro-second granularity timestamp is orders of magnitude more > expensive for us. To compound the problem, we insist on using the > expensive non-TSC binuptime() to get a runtime measurement on each > context switch, rather than being able to use something cheap like > ticks, or a per-cpu cycle counter. I have good information that in the near future, most designs will have guaranteed synchronized TSC across all CPUs. > If anybody is looking for low-hanging fruit in the SMP context switch > path, figuring some acceptable way to avoid reading the ACPI or i8254 > timecounter is it. The ACPI timecounter involves a 32 bit read from IO space. The actual timecounter is 24 or 32 bits. Since it's maintained in the chipset and has strict requirements for being reliable in many modes of system operation (i.e. C3), this read takes a while. Using it at task switch time is overkill. As you suggest, it's better to use TSC and calibrate via the ACPI timer. More info on this in my next email. -- Nate From owner-cvs-src@FreeBSD.ORG Tue Oct 18 17:10:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AAFF16A41F; Tue, 18 Oct 2005 17:10:40 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9A6043D45; Tue, 18 Oct 2005 17:10:39 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.120.198.17] ([209.101.72.251]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j9IHAaxq015714 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 18 Oct 2005 10:10:37 -0700 Message-ID: <43552C4D.7060802@root.org> Date: Tue, 18 Oct 2005 10:09:33 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <20051018094402.A29138@grasshopper.cs.duke.edu> <68671.1129643256@critter.freebsd.dk> <17237.286.236279.883806@grasshopper.cs.duke.edu> <435527DD.3040007@root.org> In-Reply-To: <435527DD.3040007@root.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Poul-Henning Kamp , src-committers@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 17:10:40 -0000 Nate Lawson wrote: > Andrew Gallatin wrote: > >> Poul-Henning Kamp writes: >> > In message <20051018094402.A29138@grasshopper.cs.duke.edu>, Andrew >> Gallatin wri >> > tes: >> > > >It is a shame we can't find a way to use the TSC as a >> timecounter on >> > >SMP systems. It seems that about 40% of the context switch time is >> > >spent just waiting for the PIO read of the ACPI-fast or i8254 to >> > >return. >> > > No, the shame is that the scheduler tries to partition time rather >> > than cpu cycles because that approximation got goldplated in some >> > random standard years back. >> >> Sorry if I mi-spoke. I guess the shame twofold. >> First we insist on not trying keep the TSC in sync and so we don't use >> it for SMP timekeeping like other OSes do, which means that getting a >> micro-second granularity timestamp is orders of magnitude more >> expensive for us. To compound the problem, we insist on using the >> expensive non-TSC binuptime() to get a runtime measurement on each >> context switch, rather than being able to use something cheap like >> ticks, or a per-cpu cycle counter. > > > I have good information that in the near future, most designs will have > guaranteed synchronized TSC across all CPUs. Oops, I not only meant "synchronized" but also "the same value". -- Nate From owner-cvs-src@FreeBSD.ORG Tue Oct 18 17:11:37 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B17D16A41F; Tue, 18 Oct 2005 17:11:37 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8835043D45; Tue, 18 Oct 2005 17:11:36 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9IHBalU094466; Tue, 18 Oct 2005 10:11:36 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9IHBabZ094465; Tue, 18 Oct 2005 10:11:36 -0700 (PDT) (envelope-from obrien) Date: Tue, 18 Oct 2005 10:11:35 -0700 From: "David O'Brien" To: John Baldwin Message-ID: <20051018171135.GA94386@dragon.NUXI.org> References: <435473D3.8080209@freebsd.org> <20051018152200.GD84920@dragon.NUXI.org> <200510181243.54588.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510181243.54588.jhb@freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: Daniel Eischen , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Colin Percival Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 17:11:37 -0000 On Tue, Oct 18, 2005 at 12:43:52PM -0400, John Baldwin wrote: > On Tuesday 18 October 2005 11:22 am, David O'Brien wrote: > > On Tue, Oct 18, 2005 at 12:50:30AM -0400, Daniel Eischen wrote: > > > On Mon, 17 Oct 2005, Colin Percival wrote: > > > > David O'Brien wrote: > > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class > > > ^^^^ > > ... > > > > This may be clear to *you*, but five years from now I'm sure that *I* > > > > won't be able to remember what the AMD Opteron 280 is. > > > > > > Am I missing something? Would it still say "Dual" if it were not a > > > dual core? > > > > No it would not. I'm not sure what this added: > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2394.81-MHz K8-class > > .. > > Cores per package: 2 > > Just because your employer formats brand info strings that way doesn't mean > other chip manufacturers will. FreeBSD as a project does not just run on > your employer's products, so we can't really make assumptions about the > layout of description strings that are free-form and vary from vendor to > vendor. By obtaining the actual values from registers and outputting them in > a vendor-neutral way, FreeBSD as a project can provide this info to our users > across architectures (i386 and amd64) and across vendors (AMD and Intel) in a > uniform way. This is much more user friendly. *sigh* This has become useless. Please put it under verboseboot or turn it into something truly useful. Right now it is simply a waste of dmesg space. As written it does not tell you the kernel's POV. As written it doesn't accurately document the physical HW. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Oct 18 17:24:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33DEA16A41F; Tue, 18 Oct 2005 17:24:04 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E570943D48; Tue, 18 Oct 2005 17:24:03 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IHO3jU094420; Tue, 18 Oct 2005 17:24:03 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IHO3kp094419; Tue, 18 Oct 2005 17:24:03 GMT (envelope-from stefanf) Message-Id: <200510181724.j9IHO3kp094419@repoman.freebsd.org> From: Stefan Farfeleder Date: Tue, 18 Oct 2005 17:24:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen sem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 17:24:04 -0000 stefanf 2005-10-18 17:24:03 UTC FreeBSD src repository Modified files: lib/libc/gen sem.c Log: Make __sem_timedwait() consistent with the sem_timedwait() prototype. Revision Changes Path 1.15 +1 -1 src/lib/libc/gen/sem.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 17:32:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C64116A41F; Tue, 18 Oct 2005 17:32:24 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCB8B43D45; Tue, 18 Oct 2005 17:32:23 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.120.198.17] ([209.101.72.251]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j9IHWHxq015877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 18 Oct 2005 10:32:20 -0700 Message-ID: <43553162.5040802@root.org> Date: Tue, 18 Oct 2005 10:31:14 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Scott Long References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <435501B9.4070401@samsco.org> In-Reply-To: <435501B9.4070401@samsco.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 17:32:24 -0000 Scott Long wrote: > Andrew Gallatin wrote: >> Nice. This reduces lmbench context switch latency by about 0.4us (7.2 >> -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> >> 35.2) on my dual core 3800+ >> >> It is a shame we can't find a way to use the TSC as a timecounter on >> SMP systems. It seems that about 40% of the context switch time is >> spent just waiting for the PIO read of the ACPI-fast or i8254 to >> return. > > The TSC represents the clock rate of the CPU, and thus can vary wildly > when thermal and power management controls kick in, and there is no way > to know when it changes. Because of this, I think that it's > practically useless on Pentium-Mobile and Pentium-M chips, among many > others. This is a myth. It is not so dismal as you portray and cpufreq(4) gives both the kernel and userland a way of getting the necessary info in an MI way (including notification of clock rate changes) and control it when possible. There are a number of mechanisms actually in the world today: * SMM-based clock switching: most laptops have SMM code (i.e. BIOS) that checks the power line status on boot and sets the base clock rate. They use the standard platform mechanism (i.e. enh speedstep, speedstep-ich) to set the frequency and cpufreq(4) allows the user or kernel to freely override it at runtime. All that is left to do is for timecounters to export a "re-calibrate" option that works at runtime and for cpufreq(4) to call it when the frequency is changed by the kernel/usermode. bde@ supplied some code I hope to import soon once I have it well tested that implements such a runtime calibration, although it is just used internally by cpufreq(4), not hooked into timecounters at the moment. Note that no BIOS I know of actually changes the value after boot, so TSC is reliable unless we change it ourselves. * p4tcc: thermal control circuit. Version 1 does x/8 throttling of the CPU by an internal stop clock cycle, where "x" is an integer. Version 2 also can step the clock rate via enh speedstep. There are two parts to this, the platform (BIOS) setting and "on demand" (kernel) setting. The OS can use the on demand setting via cpufreq(4) to save power or for passive cooling. We initiate this ourselves, so once the timecounter interface can accept an updated calibration, there is no issue here. The platform setting is worse in that we don't know when it kicks in. However, it is intended as an emergency measure like if a fan dies. All known BIOSen set this value just below the thermal shutdown circuit (i.e. the processor stops operation completely). As such, this is an edge case that we do not have to handle particularly efficiently. It suffices to periodically check the calibration of TSC (perhaps every 10 seconds?) via the ACPI timer and update our settings if it has changed. Since cpufreq(4) knows all the possible settings, it suffices to just measure the clock rate and compare it to a table of valid settings. There is no ambiguity (yet) since every CPU control mechanism has discrete settings. > There is also the issue of multiple CPUs having to keep their > TSC's somewhat in sync in order to get consistent counting in the > system. The best that you can do is to periodically read a stable > counter and try to recalibrate, but then you'll likely start getting > wild operational variances. > It's a shame that a PIO read is still so > expensive. I'd hate to see just how bad your benchmark becomes when > ACPI-slow is used instead of ACPI-fast. ACPI-slow should not be used at all. If the acpi timer is unreliable, use a different one. Also, I think most systems that had unreliable acpi timers were older and not likely to have variable CPU clocks. So I'd prefer TSC on such systems anyway. > I wonder if moving to HZ=1000 on amd64 and i386 was really all that good > of an idea. Having preemption in the kernel means that ithreads can run > right away instead of having to wait for a tick, and various fixes to > 4BSD in the past year have eliminated bugs that would make the CPU wait > for up to a tick to schedule a thread. So all we're getting now is a > 10x increase in scheduler overhead, including reading the timecounters. I use hz=100 on my systems due to the 1 khz noise from C3 sleep. Windows has the same problem. -- Nate From owner-cvs-src@FreeBSD.ORG Tue Oct 18 17:41:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7810516A41F; Tue, 18 Oct 2005 17:41:37 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from viefep17-int.chello.at (viefep17-int.chello.at [213.46.255.23]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C05943D5C; Tue, 18 Oct 2005 17:41:33 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep17-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20051018174132.QQFO27295.viefep17-int.chello.at@wombat.fafoe.narf.at>; Tue, 18 Oct 2005 19:41:32 +0200 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id E5B45185; Tue, 18 Oct 2005 19:41:30 +0200 (CEST) Date: Tue, 18 Oct 2005 19:41:30 +0200 From: Stefan Farfeleder To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20051018174123.GX67914@wombat.fafoe.narf.at> References: <200510181724.j9IHO3kp094419@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510181724.j9IHO3kp094419@repoman.freebsd.org> User-Agent: Mutt/1.5.11 Cc: Subject: Re: cvs commit: src/lib/libc/gen sem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 17:41:37 -0000 On Tue, Oct 18, 2005 at 05:24:03PM +0000, Stefan Farfeleder wrote: > stefanf 2005-10-18 17:24:03 UTC > > FreeBSD src repository > > Modified files: > lib/libc/gen sem.c > Log: > Make __sem_timedwait() consistent with the sem_timedwait() prototype. We have a quite few cases where we declare foo() in the header and define _foo() or __foo() in the .c file. Should such functions be added to namespace.h? From owner-cvs-src@FreeBSD.ORG Tue Oct 18 17:48:29 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E33DE16A420; Tue, 18 Oct 2005 17:48:29 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D26B43D48; Tue, 18 Oct 2005 17:48:29 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.ntplx.net (8.13.5/8.13.5/NETPLEX) with ESMTP id j9IHmSit008896; Tue, 18 Oct 2005 13:48:28 -0400 (EDT) Date: Tue, 18 Oct 2005 13:48:28 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Stefan Farfeleder In-Reply-To: <20051018174123.GX67914@wombat.fafoe.narf.at> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen sem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 17:48:30 -0000 On Tue, 18 Oct 2005, Stefan Farfeleder wrote: > On Tue, Oct 18, 2005 at 05:24:03PM +0000, Stefan Farfeleder wrote: > > stefanf 2005-10-18 17:24:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libc/gen sem.c > > Log: > > Make __sem_timedwait() consistent with the sem_timedwait() prototype. > > We have a quite few cases where we declare foo() in the header and > define _foo() or __foo() in the .c file. Should such functions be added > to namespace.h? If you do, please don't put them in the thread sections. -- DE From owner-cvs-src@FreeBSD.ORG Tue Oct 18 17:57:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D05116A41F; Tue, 18 Oct 2005 17:57:31 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id E567643D49; Tue, 18 Oct 2005 17:57:30 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 96617BC84; Tue, 18 Oct 2005 17:57:28 +0000 (UTC) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 18 Oct 2005 09:50:37 PDT." <435527DD.3040007@root.org> Date: Tue, 18 Oct 2005 19:57:28 +0200 Message-ID: <69576.1129658248@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 17:57:31 -0000 In message <435527DD.3040007@root.org>, Nate Lawson writes: >I have good information that in the near future, most designs will have >guaranteed synchronized TSC across all CPUs. ...and when those chips arrive, we can hopefully identify them by some bit in some MSR and then we can use the TSC on them. This is a good move and it is only too bad that it's taken the chip manufacturers 10 years to figure this out. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Oct 18 18:05:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A58E16A420; Tue, 18 Oct 2005 18:05:35 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 940DC43D45; Tue, 18 Oct 2005 18:05:34 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id F32E7BC84; Tue, 18 Oct 2005 18:05:27 +0000 (UTC) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 18 Oct 2005 10:31:14 PDT." <43553162.5040802@root.org> Date: Tue, 18 Oct 2005 20:05:27 +0200 Message-ID: <69633.1129658727@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Scott Long , src-committers@FreeBSD.org, Andrew Gallatin , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 18:05:35 -0000 In message <43553162.5040802@root.org>, Nate Lawson writes: >> The TSC represents the clock rate of the CPU, and thus can vary wildly >> when thermal and power management controls kick in, and there is no way >> to know when it changes. Because of this, I think that it's >> practically useless on Pentium-Mobile and Pentium-M chips, among many >> others. > >This is a myth. It isn't a myth. As recent as this year chips have been sent on the market which will throttle their cpu-clock and TSC on certain chip stress conditions without giving any timely indication to any part of the BIOS or OS. One major BIOS supplier still mucks up SMP TSC synchronization on certain SMM bios actions. And remember: not everybody runs intel or AMD chips. We need to work on sparc64 and alpha chips as well. Alpha is particularly nasty as some of the older chips have a SAW generated CPU clock which is not synchronized to the bus clock. >> There is also the issue of multiple CPUs having to keep their >> TSC's somewhat in sync in order to get consistent counting in the >> system. For "somewhat" read: "exact" Unless we want to do the Lamport-trick and pay the overhead of intra-cpu locks when we calculate timestamps they have to be in _exact_ synchronization _and_ syntonization. The solution to the context switch problem is _not_ to botch the timekeeping, the solution is to not _need_ the timekeeping. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Oct 18 18:27:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 932DE16A41F; Tue, 18 Oct 2005 18:27:44 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D85B43D45; Tue, 18 Oct 2005 18:27:44 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IIRi9k097373; Tue, 18 Oct 2005 18:27:44 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IIRiuN097372; Tue, 18 Oct 2005 18:27:44 GMT (envelope-from jhb) Message-Id: <200510181827.j9IIRiuN097372@repoman.freebsd.org> From: John Baldwin Date: Tue, 18 Oct 2005 18:27:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_conf.c kern_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 18:27:44 -0000 jhb 2005-10-18 18:27:44 UTC FreeBSD src repository Modified files: sys/kern kern_conf.c kern_mutex.c Log: Move the initialization of the devmtx into the mutex_init() function called during early init before cninit(). Tested on: i386, alpha, sparc64 Reviewed by: phk, imp Reported by: Divacky Roman xdivac02 at stud dot fit dot vutbr dot cz MFC after: 1 week Revision Changes Path 1.195 +1 -2 src/sys/kern/kern_conf.c 1.158 +3 -0 src/sys/kern/kern_mutex.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 18:49:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C742916A41F for ; Tue, 18 Oct 2005 18:49:04 +0000 (GMT) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C5D643D55 for ; Tue, 18 Oct 2005 18:49:03 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 79032 invoked from network); 18 Oct 2005 18:18:00 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 18 Oct 2005 18:18:00 -0000 Message-ID: <435543AD.283EC0D@freebsd.org> Date: Tue, 18 Oct 2005 20:49:17 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Poul-Henning Kamp References: <69576.1129658248@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org, Nate Lawson Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 18:49:04 -0000 Poul-Henning Kamp wrote: > > In message <435527DD.3040007@root.org>, Nate Lawson writes: > > >I have good information that in the near future, most designs will have > >guaranteed synchronized TSC across all CPUs. > > ...and when those chips arrive, we can hopefully identify them by some > bit in some MSR and then we can use the TSC on them. > > This is a good move and it is only too bad that it's taken the chip > manufacturers 10 years to figure this out. Considering that Nate knows about it and that it took cpu manufacturers so I suspect they did it to make some DRM schemes work. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 18 19:47:38 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B37616A41F; Tue, 18 Oct 2005 19:47:38 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 282CF43D45; Tue, 18 Oct 2005 19:47:38 +0000 (GMT) (envelope-from nate@root.org) Received: from [192.168.253.24] (206-135-69-234.lax-e100.cust.gw.epoch.net [206.135.69.234]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j9IJlUxq017454 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 18 Oct 2005 12:47:31 -0700 Message-ID: <4355514A.5000703@root.org> Date: Tue, 18 Oct 2005 12:47:22 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andre Oppermann References: <69576.1129658248@critter.freebsd.dk> <435543AD.283EC0D@freebsd.org> In-Reply-To: <435543AD.283EC0D@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Poul-Henning Kamp , src-committers@freebsd.org, Andrew Gallatin , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 19:47:38 -0000 Andre Oppermann wrote: > Poul-Henning Kamp wrote: > >>In message <435527DD.3040007@root.org>, Nate Lawson writes: >> >> >>>I have good information that in the near future, most designs will have >>>guaranteed synchronized TSC across all CPUs. >> >>...and when those chips arrive, we can hopefully identify them by some >>bit in some MSR and then we can use the TSC on them. >> >>This is a good move and it is only too bad that it's taken the chip >>manufacturers 10 years to figure this out. > > > Considering that Nate knows about it and that it took cpu manufacturers > so I suspect they did it to make some DRM schemes work. Nah, ACPI tables on new machines tend to give info about what major OS vendors will soon support. -- Nate From owner-cvs-src@FreeBSD.ORG Tue Oct 18 19:52:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9624B16A41F; Tue, 18 Oct 2005 19:52:16 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1486B43D48; Tue, 18 Oct 2005 19:52:16 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IJqFHS001754; Tue, 18 Oct 2005 19:52:15 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IJqFmC001753; Tue, 18 Oct 2005 19:52:15 GMT (envelope-from wpaul) Message-Id: <200510181952.j9IJqFmC001753@repoman.freebsd.org> From: Bill Paul Date: Tue, 18 Oct 2005 19:52:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/ndis kern_ndis.c ndis_var.h ntoskrnl_var.h subr_ndis.c subr_ntoskrnl.c src/sys/dev/if_ndis if_ndis.c if_ndisvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 19:52:16 -0000 wpaul 2005-10-18 19:52:15 UTC FreeBSD src repository Modified files: sys/compat/ndis kern_ndis.c ndis_var.h ntoskrnl_var.h subr_ndis.c subr_ntoskrnl.c sys/dev/if_ndis if_ndis.c if_ndisvar.h Log: Another round of cleanups and fixes: - Change ndis_return() from a DPC to a workitem so that it doesn't run at DISPATCH_LEVEL (with the dispatcher lock held). - In if_ndis.c, submit packets to the stack via (*ifp->if_input)() in a workitem instead of doing it directly in ndis_rxeof(), because ndis_rxeof() runs in a DPC, and hence at DISPATCH_LEVEL. This implies that the 'dispatch level' mutex for the current CPU is being held, and we don't want to call if_input while holding any locks. - Reimplement IoConnectInterrupt()/IoDisconnectInterrupt(). The original approach I used to track down the interrupt resource (by scanning the device tree starting at the nexus) is prone to problems when two devices share an interrupt. (E.g removing ndis1 might disable interrupts for ndis0.) The new approach is to multiplex all the NDIS interrupts through a common internal dispatcher (ntoskrnl_intr()) and allow IoConnectInterrupt()/IoDisconnectInterrupt() to add or remove interrupts from the dispatch list. - Implement KeAcquireInterruptSpinLock() and KeReleaseInterruptSpinLock(). - Change the DPC and workitem threads to use the KeXXXSpinLock API instead of mtx_lock_spin()/mtx_unlock_spin(). - Simplify the NdisXXXPacket routines by creating an actual packet pool structure and using the InterlockedSList routines to manage the packet queue. - Only honor the value returned by OID_GEN_MAXIMUM_SEND_PACKETS for serialized drivers. For deserialized drivers, we now create a packet array of 64 entries. (The Microsoft DDK documentation says that for deserialized miniports, OID_GEN_MAXIMUM_SEND_PACKETS is ignored, and the driver for the Marvell 8335 chip, which is a deserialized miniport, returns 1 when queried.) - Clean up timer handling in subr_ntoskrnl. - Add the following conditional debugging code: NTOSKRNL_DEBUG_TIMERS - add debugging and stats for timers NDIS_DEBUG_PACKETS - add extra sanity checking for NdisXXXPacket API NTOSKRNL_DEBUG_SPINLOCKS - add test for spinning too long - In kern_ndis.c, always start the HAL first and shut it down last, since Windows spinlocks depend on it. Ntoskrnl should similarly be started second and shut down next to last. Revision Changes Path 1.88 +93 -25 src/sys/compat/ndis/kern_ndis.c 1.44 +19 -3 src/sys/compat/ndis/ndis_var.h 1.39 +12 -0 src/sys/compat/ndis/ntoskrnl_var.h 1.96 +93 -92 src/sys/compat/ndis/subr_ndis.c 1.74 +328 -273 src/sys/compat/ndis/subr_ntoskrnl.c 1.108 +98 -12 src/sys/dev/if_ndis/if_ndis.c 1.25 +5 -4 src/sys/dev/if_ndis/if_ndisvar.h From owner-cvs-src@FreeBSD.ORG Tue Oct 18 20:03:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38D5016A41F; Tue, 18 Oct 2005 20:03:32 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E640943D48; Tue, 18 Oct 2005 20:03:31 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IK3Vd4002247; Tue, 18 Oct 2005 20:03:31 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IK3Vej002246; Tue, 18 Oct 2005 20:03:31 GMT (envelope-from jkim) Message-Id: <200510182003.j9IK3Vej002246@repoman.freebsd.org> From: Jung-uk Kim Date: Tue, 18 Oct 2005 20:03:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/i386/libi386 smbios.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 20:03:32 -0000 jkim 2005-10-18 20:03:31 UTC FreeBSD src repository Modified files: sys/boot/i386/libi386 smbios.c Log: Export processor socket information. New environment variables are: smbios.socket.enabled: number of enabled sockets smbios.socket.populated: number of populated sockets Revision Changes Path 1.3 +32 -0 src/sys/boot/i386/libi386/smbios.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 20:21:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6DFE16A41F; Tue, 18 Oct 2005 20:21:25 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8179343D53; Tue, 18 Oct 2005 20:21:25 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IKLPPB003854; Tue, 18 Oct 2005 20:21:25 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IKLPGT003853; Tue, 18 Oct 2005 20:21:25 GMT (envelope-from phk) Message-Id: <200510182021.j9IKLPGT003853@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 18 Oct 2005 20:21:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 20:21:25 -0000 phk 2005-10-18 20:21:25 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_vnops.c Log: Use correct cirteria for determining which directory entries we can purge right away and which we merely can hide. Beaten into my skull by: kris Revision Changes Path 1.127 +1 -1 src/sys/fs/devfs/devfs_vnops.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 20:37:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B973016A41F; Tue, 18 Oct 2005 20:37:45 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7578043D46; Tue, 18 Oct 2005 20:37:45 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9IKbj7w004661; Tue, 18 Oct 2005 20:37:45 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9IKbjYh004660; Tue, 18 Oct 2005 20:37:45 GMT (envelope-from phk) Message-Id: <200510182037.j9IKbjYh004660@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 18 Oct 2005 20:37:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 20:37:45 -0000 phk 2005-10-18 20:37:45 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: Bruce Schneier is underrepresented in the fortune file. Revision Changes Path 1.194 +4 -0 src/games/fortune/datfiles/fortunes From owner-cvs-src@FreeBSD.ORG Tue Oct 18 21:18:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A16E16A41F; Tue, 18 Oct 2005 21:18:47 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 44C2543D46; Tue, 18 Oct 2005 21:18:47 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9ILIlYJ013348; Tue, 18 Oct 2005 21:18:47 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9ILIlJl013347; Tue, 18 Oct 2005 21:18:47 GMT (envelope-from ariff) Message-Id: <200510182118.j9ILIlJl013347@repoman.freebsd.org> From: Ariff Abdullah Date: Tue, 18 Oct 2005 21:18:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pcm feeder_rate.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 21:18:47 -0000 ariff 2005-10-18 21:18:47 UTC FreeBSD src repository Modified files: sys/dev/sound/pcm feeder_rate.c Log: Added missing comma. This fixes compilation if we need to enable RATE_ASSERT debug macro. Approved by: netchild (mentor) Revision Changes Path 1.13 +1 -1 src/sys/dev/sound/pcm/feeder_rate.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 21:33:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1596116A41F; Tue, 18 Oct 2005 21:33:52 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7C8743D45; Tue, 18 Oct 2005 21:33:51 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9ILXpeq014103; Tue, 18 Oct 2005 21:33:51 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9ILXpje014102; Tue, 18 Oct 2005 21:33:51 GMT (envelope-from ariff) Message-Id: <200510182133.j9ILXpje014102@repoman.freebsd.org> From: Ariff Abdullah Date: Tue, 18 Oct 2005 21:33:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pcm vchan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 21:33:52 -0000 ariff 2005-10-18 21:33:51 UTC FreeBSD src repository Modified files: sys/dev/sound/pcm vchan.c Log: Fix vchan speed for hardware with discrete (non-continuous) sampling rate: - Improve vchan chn_setspeed() strategy. Try to avoid FEEDER_RATE on parent channel if the requested value is not supported by the hardware. - Fix vchan default speed calculation. In any case, vchan should rely on parent bufsoft speed instead of bufhard since it is possible that the entire feeder chain might involve FEEDER_RATE. This is possible under extreme, rare condition if the above chn_setspeed() strategy failed. Approved by: netchild (mentor) Revision Changes Path 1.20 +24 -6 src/sys/dev/sound/pcm/vchan.c From owner-cvs-src@FreeBSD.ORG Tue Oct 18 21:38:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7F0016A41F; Tue, 18 Oct 2005 21:38:44 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D36243D45; Tue, 18 Oct 2005 21:38:44 +0000 (GMT) (envelope-from nate@root.org) Received: from [192.168.253.24] (206-135-69-234.lax-e100.cust.gw.epoch.net [206.135.69.234]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j9ILcaxq018830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 18 Oct 2005 14:38:37 -0700 Message-ID: <43556B55.9020401@root.org> Date: Tue, 18 Oct 2005 14:38:29 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Poul-Henning Kamp References: <69633.1129658727@critter.freebsd.dk> In-Reply-To: <69633.1129658727@critter.freebsd.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Scott Long , src-committers@FreeBSD.org, Andrew Gallatin , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 21:38:44 -0000 Poul-Henning Kamp wrote: > In message <43553162.5040802@root.org>, Nate Lawson writes: > > >>>The TSC represents the clock rate of the CPU, and thus can vary wildly >>>when thermal and power management controls kick in, and there is no way >>>to know when it changes. Because of this, I think that it's >>>practically useless on Pentium-Mobile and Pentium-M chips, among many >>>others. >> >>This is a myth. > > It isn't a myth. > > As recent as this year chips have been sent on the market which > will throttle their cpu-clock and TSC on certain chip stress > conditions without giving any timely indication to any part of > the BIOS or OS. Does this refer to the p4tcc platform limit that I described or is it soemthing different? In my analysis, the limit is set very high and should not be hit unless a fan fails. This info seems to match my observations: "Thermal Monitor controls the processor temperature by modulating (starting and stopping) the processor core clocks. Automatic and On-Demand modes are used to activate the thermal control circuit (TCC). When automatic mode is enabled, the TCC will activate only when the interanl die temperature is very near the temperature limits of the processor." http://www.intel.com/cd/channel/reseller/asmo-na/eng/products/box_processors/mobile/celeron_m/technical_reference/97374.htm For Prescott, the temp for automatic cut-in is around 72C. We may be able to detect this on SMP systems via IPIs (I don't know which ones). http://softwareforums.intel.com/ids/board/message?board.id=49&message.id=456 That doesn't mean we can ignore it, just that we don't have to optimize for that case. When your CPU is about to melt down, having slower scheduling for a few seconds doesn't seem unreasonable. > The solution to the context switch problem is _not_ to botch > the timekeeping, the solution is to not _need_ the timekeeping. Yes, I agree. We need to fix context switching to not be binuptime()-based and separately improve TSC support so it can be used more often as a timecounter. -- Nate From owner-cvs-src@FreeBSD.ORG Wed Oct 19 00:18:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B6BA16A41F; Wed, 19 Oct 2005 00:18:12 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4690F43D46; Wed, 19 Oct 2005 00:18:12 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9J0ICJG019994; Wed, 19 Oct 2005 00:18:12 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9J0ICLJ019993; Wed, 19 Oct 2005 00:18:12 GMT (envelope-from imp) Message-Id: <200510190018.j9J0ICLJ019993@repoman.freebsd.org> From: Warner Losh Date: Wed, 19 Oct 2005 00:18:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb_isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 00:18:12 -0000 imp 2005-10-19 00:18:11 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb_isa.c Log: Make sure we set bst and bsh in the softc. This gets us probing, but not attaching to, ISA cards. More work needed since the ISA attach routine is return ENXIO right now :-) Revision Changes Path 1.6 +2 -0 src/sys/dev/pccbb/pccbb_isa.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 00:25:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E4E916A41F; Wed, 19 Oct 2005 00:25:39 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4A70E43D46; Wed, 19 Oct 2005 00:25:39 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9J0Pd7E020318; Wed, 19 Oct 2005 00:25:39 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9J0PdWS020317; Wed, 19 Oct 2005 00:25:39 GMT (envelope-from imp) Message-Id: <200510190025.j9J0PdWS020317@repoman.freebsd.org> From: Warner Losh Date: Wed, 19 Oct 2005 00:25:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/exca exca.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 00:25:39 -0000 imp 2005-10-19 00:25:39 UTC FreeBSD src repository Modified files: sys/dev/exca exca.c Log: Set the name of the chipset found Revision Changes Path 1.23 +3 -3 src/sys/dev/exca/exca.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 01:21:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D23916A41F; Wed, 19 Oct 2005 01:21:50 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1AD0743D45; Wed, 19 Oct 2005 01:21:50 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9J1LnaL029435; Wed, 19 Oct 2005 01:21:49 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9J1Lnrd029434; Wed, 19 Oct 2005 01:21:49 GMT (envelope-from suz) Message-Id: <200510190121.j9J1Lnrd029434@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 01:21:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 raw_ip6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 01:21:50 -0000 suz 2005-10-19 01:21:49 UTC FreeBSD src repository Modified files: sys/netinet6 raw_ip6.c Log: Raw IPv6 checksum must use the protocol number of the last header, instead of the first next-header value. Obtained from: KAME MFC after: 1 day Revision Changes Path 1.57 +1 -1 src/sys/netinet6/raw_ip6.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 03:14:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6539D16A41F; Wed, 19 Oct 2005 03:14:12 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 23F0D43D4C; Wed, 19 Oct 2005 03:14:12 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9J3ECE2034059; Wed, 19 Oct 2005 03:14:12 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9J3EBUK034058; Wed, 19 Oct 2005 03:14:11 GMT (envelope-from wpaul) Message-Id: <200510190314.j9J3EBUK034058@repoman.freebsd.org> From: Bill Paul Date: Wed, 19 Oct 2005 03:14:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 03:14:12 -0000 wpaul 2005-10-19 03:14:11 UTC FreeBSD src repository Modified files: sys/dev/if_ndis if_ndis.c Log: Correct the size used to allocate ndis_txarray. It should be NDIS_TXPKTS now, not ndis_maxpkts. Revision Changes Path 1.109 +1 -1 src/sys/dev/if_ndis/if_ndis.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 04:48:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD00D16A420; Wed, 19 Oct 2005 04:48:44 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 809E943D45; Wed, 19 Oct 2005 04:48:44 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9J4mi6f044473; Wed, 19 Oct 2005 04:48:44 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9J4miSB044472; Wed, 19 Oct 2005 04:48:44 GMT (envelope-from njl) Message-Id: <200510190448.j9J4miSB044472@repoman.freebsd.org> From: Nate Lawson Date: Wed, 19 Oct 2005 04:48:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/powerd Makefile powerd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 04:48:44 -0000 njl 2005-10-19 04:48:44 UTC FreeBSD src repository Modified files: usr.sbin/powerd Makefile powerd.c Log: Use a pipe for reading devd events as another method of getting the AC line status. Add a thread that waits for events on the named pipe instead of polling the line status via apm or the ACPI sysctl. Additionally, use robust error handling in case devd goes away or we temporarily can't set a frequency (i.e., passive cooling has preempted our setting). Later, this should be improved so that if adaptive control is not being used, we will block while waiting for AC line events, saving a little CPU. Submitted by: Frederik Lindberg Revision Changes Path 1.4 +1 -0 src/usr.sbin/powerd/Makefile 1.13 +178 -28 src/usr.sbin/powerd/powerd.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 06:37:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2659616A41F; Wed, 19 Oct 2005 06:37:40 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D9B6043D49; Wed, 19 Oct 2005 06:37:39 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9J6bdt4048497; Wed, 19 Oct 2005 06:37:39 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9J6bdFS048496; Wed, 19 Oct 2005 06:37:39 GMT (envelope-from phk) Message-Id: <200510190637.j9J6bdFS048496@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 19 Oct 2005 06:37:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 06:37:40 -0000 phk 2005-10-19 06:37:39 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: Fix typo Revision Changes Path 1.195 +1 -1 src/games/fortune/datfiles/fortunes From owner-cvs-src@FreeBSD.ORG Wed Oct 19 09:33:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9CD416A41F; Wed, 19 Oct 2005 09:33:16 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 739A943D49; Wed, 19 Oct 2005 09:33:16 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9J9XGtC065215; Wed, 19 Oct 2005 09:33:16 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9J9XGiX065214; Wed, 19 Oct 2005 09:33:16 GMT (envelope-from davidxu) Message-Id: <200510190933.j9J9XGiX065214@repoman.freebsd.org> From: David Xu Date: Wed, 19 Oct 2005 09:33:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/svr4 svr4_misc.c svr4_siginfo.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 09:33:17 -0000 davidxu 2005-10-19 09:33:15 UTC FreeBSD src repository Modified files: sys/compat/svr4 svr4_misc.c svr4_siginfo.h Log: Fix compiling problem by adding prefix name svr4 to si_xxx macro, the si_xxx macro should not be used in compat headers, as these are standard member names or only can be used in our native header file signal.h. Revision Changes Path 1.83 +16 -15 src/sys/compat/svr4/svr4_misc.c 1.5 +9 -9 src/sys/compat/svr4/svr4_siginfo.h From owner-cvs-src@FreeBSD.ORG Wed Oct 19 09:37:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1CAB16A41F; Wed, 19 Oct 2005 09:37:52 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 955DF43D46; Wed, 19 Oct 2005 09:37:52 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9J9bqJC065584; Wed, 19 Oct 2005 09:37:52 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9J9bqDm065583; Wed, 19 Oct 2005 09:37:52 GMT (envelope-from rwatson) Message-Id: <200510190937.j9J9bqDm065583@repoman.freebsd.org> From: Robert Watson Date: Wed, 19 Oct 2005 09:37:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 09:37:53 -0000 rwatson 2005-10-19 09:37:52 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Convert if (tp->t_state == TCPS_LISTEN) panic() into a KASSERT. MFC after: 2 weeks Revision Changes Path 1.284 +2 -4 src/sys/netinet/tcp_input.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 10:09:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6165016A41F; Wed, 19 Oct 2005 10:09:20 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32F3B43D45; Wed, 19 Oct 2005 10:09:20 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JA9KaC067337; Wed, 19 Oct 2005 10:09:20 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JA9KYv067336; Wed, 19 Oct 2005 10:09:20 GMT (envelope-from suz) Message-Id: <200510191009.j9JA9KYv067336@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 10:09:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 icmp6.c in6.c in6_ifattach.c nd6.c nd6_nbr.c nd6_rtr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 10:09:20 -0000 suz 2005-10-19 10:09:19 UTC FreeBSD src repository Modified files: sys/netinet6 icmp6.c in6.c in6_ifattach.c nd6.c nd6_nbr.c nd6_rtr.c Log: sync with KAME in the following points: - fixed typos - improved some comment descriptions - use NULL, instead of 0, to denote a NULL pointer - avoid embedding a magic number in the code - use nd6log() instead of log() to record NDP-specific logs - nuked an unnecessay white space Obtained from: KAME MFC after: 1 day Revision Changes Path 1.67 +3 -1 src/sys/netinet6/icmp6.c 1.55 +19 -24 src/sys/netinet6/in6.c 1.29 +10 -10 src/sys/netinet6/in6_ifattach.c 1.56 +45 -44 src/sys/netinet6/nd6.c 1.35 +13 -13 src/sys/netinet6/nd6_nbr.c 1.29 +4 -4 src/sys/netinet6/nd6_rtr.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 12:07:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8DCD16A41F; Wed, 19 Oct 2005 12:07:57 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 225BA43D45; Wed, 19 Oct 2005 12:07:56 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id D64102084; Wed, 19 Oct 2005 14:07:51 +0200 (CEST) X-Spam-Tests: ALL_TRUSTED,AWL,BAYES_00,DATE_IN_PAST_24_48 X-Spam-Learn: ham X-Spam-Score: -4.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on tim.des.no Received: from xps.des.no (des.no [80.203.228.37]) by tim.des.no (Postfix) with ESMTP id C45032082; Wed, 19 Oct 2005 14:07:51 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id 3068333C3E; Tue, 18 Oct 2005 10:01:24 +0200 (CEST) To: Gleb Smirnoff References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> <20051017183139.GA97488@dragon.NUXI.org> <1129576130.1152.30.camel@leguin> <20051017192018.GD97488@dragon.NUXI.org> <20051017213635.GC59364@cell.sick.ru> <20051018035902.GH53525@dragon.NUXI.org> <20051018065659.GD59364@cell.sick.ru> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Tue, 18 Oct 2005 10:01:24 +0200 In-Reply-To: <20051018065659.GD59364@cell.sick.ru> (Gleb Smirnoff's message of "Tue, 18 Oct 2005 10:56:59 +0400") Message-ID: <86k6gbgsob.fsf@xps.des.no> User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Eric Anholt , cvs-all@FreeBSD.org, David O'Brien , Jung-uk Kim Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 12:07:57 -0000 Gleb Smirnoff writes: > On Mon, Oct 17, 2005 at 08:59:02PM -0700, David O'Brien wrote: > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.92-MHz K8-class CPU) > > [...] > > The above dmesg doesn't tell this to you? > Only after you have explained it. If I am a new FreeBSD user, I won't > understand that I have two sockets with two dual core CPUs. Even new FreeBSD users should understand that "CPU: Dual Core AMD Opteron" means they have dual core CPUs. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Wed Oct 19 13:34:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 07F6616A41F; Wed, 19 Oct 2005 13:34:49 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAB1A43D46; Wed, 19 Oct 2005 13:34:48 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JDYmdM088816; Wed, 19 Oct 2005 13:34:48 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JDYm02088815; Wed, 19 Oct 2005 13:34:48 GMT (envelope-from glebius) Message-Id: <200510191334.j9JDYm02088815@repoman.freebsd.org> From: Gleb Smirnoff Date: Wed, 19 Oct 2005 13:34:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 13:34:49 -0000 glebius 2005-10-19 13:34:48 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: In the em_process_receive_interrupts() cycle check the IFF_DRV_RUNNING flag. This fixes panic, when 'ifconfig em0 down' was called and it calls em_stop() while the em_process_receive_interrupts() has temporarily dropped the lock. Revision Changes Path 1.79 +3 -1 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 14:59:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC7A416A41F; Wed, 19 Oct 2005 14:59:54 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 78B4743D46; Wed, 19 Oct 2005 14:59:54 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JExs4K092199; Wed, 19 Oct 2005 14:59:54 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JExs8d092198; Wed, 19 Oct 2005 14:59:54 GMT (envelope-from rwatson) Message-Id: <200510191459.j9JExs8d092198@repoman.freebsd.org> From: Robert Watson Date: Wed, 19 Oct 2005 14:59:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/svr4 svr4_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 14:59:55 -0000 rwatson 2005-10-19 14:59:54 UTC FreeBSD src repository Modified files: sys/i386/svr4 svr4_machdep.c Log: Use svr4_si_{addr,code,errno,signo,trap} in preference to si_{...}. Fix a debugging printf to printf after a variable is first assigned, not before. These are purely build fixes, and need inspection to make sure they were what the original author of the previous changes intended. Revision Changes Path 1.38 +36 -36 src/sys/i386/svr4/svr4_machdep.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 15:05:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0752F16A41F; Wed, 19 Oct 2005 15:05:43 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9F5143D46; Wed, 19 Oct 2005 15:05:42 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JF5gm4092701; Wed, 19 Oct 2005 15:05:42 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JF5gfI092700; Wed, 19 Oct 2005 15:05:42 GMT (envelope-from suz) Message-Id: <200510191505.j9JF5gfI092700@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 15:05:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/rtadvd config.c src/sys/netinet6 in6.c in6_var.h nd6.c src/usr.sbin/ndp ndp.8 ndp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 15:05:43 -0000 suz 2005-10-19 15:05:42 UTC FreeBSD src repository Modified files: usr.sbin/rtadvd config.c sys/netinet6 in6.c in6_var.h nd6.c usr.sbin/ndp ndp.8 ndp.c Log: added an ioctl option in kernel so that ndp/rtadvd can change some NDP-related kernel variables based on their configurations (RFC2461 p.43 6.2.1 mandates this for IPv6 routers) Obtained from: KAME Reviewd by: ume, gnn MFC after: 2 weeks Revision Changes Path 1.56 +1 -0 src/sys/netinet6/in6.c 1.26 +1 -0 src/sys/netinet6/in6_var.h 1.57 +28 -0 src/sys/netinet6/nd6.c 1.17 +21 -8 src/usr.sbin/ndp/ndp.8 1.17 +31 -2 src/usr.sbin/ndp/ndp.c 1.25 +30 -0 src/usr.sbin/rtadvd/config.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 15:14:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32A6A16A41F; Wed, 19 Oct 2005 15:14:30 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4C0743D46; Wed, 19 Oct 2005 15:14:29 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JFETUT093069; Wed, 19 Oct 2005 15:14:29 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JFET44093068; Wed, 19 Oct 2005 15:14:29 GMT (envelope-from suz) Message-Id: <200510191514.j9JFET44093068@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 15:14:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/rtadvd rtadvd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 15:14:30 -0000 suz 2005-10-19 15:14:28 UTC FreeBSD src repository Modified files: usr.sbin/rtadvd rtadvd.c Log: source link-layer address option should be marked to be checked later, because rs_input() need this option. Obtained from: KAME Reviewed by: ume, gnn MFC after: 2 weeks Revision Changes Path 1.24 +1 -1 src/usr.sbin/rtadvd/rtadvd.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 15:19:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D1DF16A420; Wed, 19 Oct 2005 15:19:07 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 364F343D4C; Wed, 19 Oct 2005 15:19:07 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JFJ7qh093351; Wed, 19 Oct 2005 15:19:07 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JFJ7rS093350; Wed, 19 Oct 2005 15:19:07 GMT (envelope-from suz) Message-Id: <200510191519.j9JFJ7rS093350@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 15:19:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/rtadvd rtadvd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 15:19:07 -0000 suz 2005-10-19 15:19:06 UTC FreeBSD src repository Modified files: usr.sbin/rtadvd rtadvd.c Log: changed syslog level to more appropriate ones Obtained from: KAME Reviewd by: ume, gnn MFC after: 2 weeks Revision Changes Path 1.25 +3 -3 src/usr.sbin/rtadvd/rtadvd.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 15:37:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14B8116A41F; Wed, 19 Oct 2005 15:37:45 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB4F743D67; Wed, 19 Oct 2005 15:37:43 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JFbhRp094246; Wed, 19 Oct 2005 15:37:43 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JFbhxE094245; Wed, 19 Oct 2005 15:37:43 GMT (envelope-from stefanf) Message-Id: <200510191537.j9JFbhxE094245@repoman.freebsd.org> From: Stefan Farfeleder Date: Wed, 19 Oct 2005 15:37:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/sh histedit.c src/usr.bin/tftp main.c src/sbin/fsdb fsdb.c src/usr.sbin/cdcontrol cdcontrol.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 15:37:45 -0000 stefanf 2005-10-19 15:37:43 UTC FreeBSD src repository Modified files: bin/sh histedit.c usr.bin/tftp main.c sbin/fsdb fsdb.c usr.sbin/cdcontrol cdcontrol.c Log: Use the new name H_SETSIZE instead of the old H_EVENT to set the history size. PR: 86355 Revision Changes Path 1.28 +1 -1 src/bin/sh/histedit.c 1.31 +1 -1 src/sbin/fsdb/fsdb.c 1.22 +1 -1 src/usr.bin/tftp/main.c 1.49 +1 -1 src/usr.sbin/cdcontrol/cdcontrol.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 15:52:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D01D516A420; Wed, 19 Oct 2005 15:52:01 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C7D943D46; Wed, 19 Oct 2005 15:52:01 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JFq1j9094895; Wed, 19 Oct 2005 15:52:01 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JFq1no094894; Wed, 19 Oct 2005 15:52:01 GMT (envelope-from suz) Message-Id: <200510191552.j9JFq1no094894@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 15:52:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/ndp ndp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 15:52:02 -0000 suz 2005-10-19 15:52:01 UTC FreeBSD src repository Modified files: usr.sbin/ndp ndp.c Log: sync with KAME in the following points: - removed compilation warnings - suppress a redundant error message when a default-router-list is empty Obtained from: KAME Reviewd by: ume, gnn MFC after: 2 weeks Revision Changes Path 1.18 +4 -1 src/usr.sbin/ndp/ndp.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 15:58:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8499C16A41F; Wed, 19 Oct 2005 15:58:25 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E884C43D48; Wed, 19 Oct 2005 15:58:24 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JFwOMP095131; Wed, 19 Oct 2005 15:58:24 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JFwOAO095130; Wed, 19 Oct 2005 15:58:24 GMT (envelope-from suz) Message-Id: <200510191558.j9JFwOAO095130@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 15:58:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/ndp ndp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 15:58:25 -0000 suz 2005-10-19 15:58:23 UTC FreeBSD src repository Modified files: usr.sbin/ndp ndp.c Log: sync with KAME in the following point: - fixed a bug that "ndp ... proxy" command does not work Obtained from: KAME Reviewd by: ume, gnn MFC after: 2 weeks Revision Changes Path 1.19 +5 -1 src/usr.sbin/ndp/ndp.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 16:20:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B94D16A41F; Wed, 19 Oct 2005 16:20:19 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53E8F43D6B; Wed, 19 Oct 2005 16:20:19 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JGKJQx096051; Wed, 19 Oct 2005 16:20:19 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JGKJ27096050; Wed, 19 Oct 2005 16:20:19 GMT (envelope-from suz) Message-Id: <200510191620.j9JGKJ27096050@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 16:20:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/ndp ndp.8 ndp.c src/sys/netinet6 ip6_input.c nd6.c nd6.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 16:20:19 -0000 suz 2005-10-19 16:20:18 UTC FreeBSD src repository Modified files: usr.sbin/ndp ndp.8 ndp.c sys/netinet6 ip6_input.c nd6.c nd6.h Log: supported an ndp command suboption to disable IPv6 in the given interface Obtained from: KAME Reviewd by: ume, gnn MFC after: 2 week Revision Changes Path 1.84 +6 -0 src/sys/netinet6/ip6_input.c 1.58 +6 -0 src/sys/netinet6/nd6.c 1.20 +4 -0 src/sys/netinet6/nd6.h 1.18 +13 -0 src/usr.sbin/ndp/ndp.8 1.20 +5 -0 src/usr.sbin/ndp/ndp.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 16:27:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D883416A420; Wed, 19 Oct 2005 16:27:33 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D74243D5C; Wed, 19 Oct 2005 16:27:33 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JGRXqW096469; Wed, 19 Oct 2005 16:27:33 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JGRXBV096468; Wed, 19 Oct 2005 16:27:33 GMT (envelope-from suz) Message-Id: <200510191627.j9JGRXBV096468@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 16:27:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 icmp6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 16:27:34 -0000 suz 2005-10-19 16:27:33 UTC FreeBSD src repository Modified files: sys/netinet6 icmp6.c Log: sync with KAME (don't respond to NI_QTYPE_IPV4ADDR) Obtained from: KAME Reviewed by: ume, gnn Revision Changes Path 1.68 +5 -0 src/sys/netinet6/icmp6.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 16:37:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E035B16A420; Wed, 19 Oct 2005 16:37:52 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73C0C43D49; Wed, 19 Oct 2005 16:37:52 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JGbqZC096895; Wed, 19 Oct 2005 16:37:52 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JGbqdc096894; Wed, 19 Oct 2005 16:37:52 GMT (envelope-from stefanf) Message-Id: <200510191637.j9JGbqdc096894@repoman.freebsd.org> From: Stefan Farfeleder Date: Wed, 19 Oct 2005 16:37:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/lpr/lpc lpc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 16:37:53 -0000 stefanf 2005-10-19 16:37:52 UTC FreeBSD src repository Modified files: usr.sbin/lpr/lpc lpc.c Log: Use the new name H_SETSIZE instead of the old H_EVENT to set the history size. PR: 86355 Approved by: gad Revision Changes Path 1.31 +1 -1 src/usr.sbin/lpr/lpc/lpc.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 16:43:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E66F716A41F; Wed, 19 Oct 2005 16:43:57 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D60C43D49; Wed, 19 Oct 2005 16:43:57 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JGhvjZ097211; Wed, 19 Oct 2005 16:43:57 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JGhvT2097210; Wed, 19 Oct 2005 16:43:57 GMT (envelope-from suz) Message-Id: <200510191643.j9JGhvT2097210@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 16:43:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 in6_ifattach.c in6_ifattach.h nd6_nbr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 16:43:58 -0000 suz 2005-10-19 16:43:57 UTC FreeBSD src repository Modified files: sys/netinet6 in6_ifattach.c in6_ifattach.h nd6_nbr.c Log: sync with KAME regarding the following clarification in RFC3542: - disable IPv6 operation if DAD fails for some EUI-64 link-local addresses. - export get_hw_ifid() (and rename it) as a subroutine for this process. Obtained from: KAME Reviewd by: ume, gnn MFC after: 2 week Revision Changes Path 1.30 +5 -6 src/sys/netinet6/in6_ifattach.c 1.6 +1 -0 src/sys/netinet6/in6_ifattach.h 1.36 +39 -2 src/sys/netinet6/nd6_nbr.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 16:53:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C86CC16A41F; Wed, 19 Oct 2005 16:53:26 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE1F043D53; Wed, 19 Oct 2005 16:53:25 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JGrPnt004987; Wed, 19 Oct 2005 16:53:25 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JGrPXT004986; Wed, 19 Oct 2005 16:53:25 GMT (envelope-from suz) Message-Id: <200510191653.j9JGrPXT004986@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 16:53:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 in6.h in6_src.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 16:53:27 -0000 suz 2005-10-19 16:53:25 UTC FreeBSD src repository Modified files: sys/netinet6 in6.h in6_src.c Log: sync with KAME (removed a unnecesary non-standard macro) Obtained from: KAME Reviewd by: ume, gnn Revision Changes Path 1.41 +0 -8 src/sys/netinet6/in6.h 1.36 +10 -8 src/sys/netinet6/in6_src.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 17:18:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E30D116A41F; Wed, 19 Oct 2005 17:18:49 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EC5943D45; Wed, 19 Oct 2005 17:18:49 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JHInC7006143; Wed, 19 Oct 2005 17:18:49 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JHInVW006142; Wed, 19 Oct 2005 17:18:49 GMT (envelope-from suz) Message-Id: <200510191718.j9JHInVW006142@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Wed, 19 Oct 2005 17:18:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 nd6.c nd6_nbr.c nd6_rtr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 17:18:50 -0000 suz 2005-10-19 17:18:49 UTC FreeBSD src repository Modified files: sys/netinet6 nd6.c nd6_nbr.c nd6_rtr.c Log: sync with KAME (nuked unused code, use NULL to denote a NULL pointer) Obtained from: KAME Reviewed by: ume, gnn Revision Changes Path 1.59 +0 -15 src/sys/netinet6/nd6.c 1.37 +1 -13 src/sys/netinet6/nd6_nbr.c 1.30 +6 -37 src/sys/netinet6/nd6_rtr.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 18:10:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E98A16A41F; Wed, 19 Oct 2005 18:10:35 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B693343D62; Wed, 19 Oct 2005 18:10:34 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JIAYO4011426; Wed, 19 Oct 2005 18:10:34 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JIAYC0011425; Wed, 19 Oct 2005 18:10:34 GMT (envelope-from imp) Message-Id: <200510191810.j9JIAYC0011425@repoman.freebsd.org> From: Warner Losh Date: Wed, 19 Oct 2005 18:10:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/devd devd.cc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 18:10:35 -0000 imp 2005-10-19 18:10:34 UTC FreeBSD src repository Modified files: sbin/devd devd.cc Log: As pointed out on current@, we don't want to declare a variable in a scope that just uses the variable and throws it away. This should fix the subsystem keyword wrt media-type. MFC After: 2 days Revision Changes Path 1.26 +1 -1 src/sbin/devd/devd.cc From owner-cvs-src@FreeBSD.ORG Wed Oct 19 18:19:05 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9494816A41F; Wed, 19 Oct 2005 18:19:05 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31BD343D66; Wed, 19 Oct 2005 18:19:05 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j9JIGPAU069789; Wed, 19 Oct 2005 12:16:26 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 19 Oct 2005 12:17:44 -0600 (MDT) Message-Id: <20051019.121744.41010899.imp@bsdimp.com> To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org From: "M. Warner Losh" In-Reply-To: <200510191810.j9JIAYC0011425@repoman.freebsd.org> References: <200510191810.j9JIAYC0011425@repoman.freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 19 Oct 2005 12:16:26 -0600 (MDT) Cc: Subject: Re: cvs commit: src/sbin/devd devd.cc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 18:19:05 -0000 Oops. forgot the submitted by. In message: <200510191810.j9JIAYC0011425@repoman.freebsd.org> Warner Losh writes: : imp 2005-10-19 18:10:34 UTC : : FreeBSD src repository : : Modified files: : sbin/devd devd.cc : Log: : As pointed out on current@, we don't want to declare a variable in a scope : that just uses the variable and throws it away. : : This should fix the subsystem keyword wrt media-type. : : MFC After: 2 days Submited by: Niki Denev Warner From owner-cvs-src@FreeBSD.ORG Wed Oct 19 20:18:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3E1216A422; Wed, 19 Oct 2005 20:18:45 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 840F943D66; Wed, 19 Oct 2005 20:18:45 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JKIjoH016507; Wed, 19 Oct 2005 20:18:45 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JKIj46016506; Wed, 19 Oct 2005 20:18:45 GMT (envelope-from truckman) Message-Id: <200510192018.j9JKIj46016506@repoman.freebsd.org> From: Don Lewis Date: Wed, 19 Oct 2005 20:18:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/nwfs nwfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 20:18:45 -0000 truckman 2005-10-19 20:18:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/nwfs nwfs_vnops.c Log: MFC nwfs_vnops.c 1.42 Original commit message: Modified files: sys/fs/nwfs nwfs_vnops.c Log: Update nwfs_lookup() to match the current cache_lookup() API. cache_lookup() has returned a ref'ed and locked vnode since vfs_cache.c:1.96, dated Tue Mar 29 12:59:06 2005 UTC. This change is similar to the change made to smbfs_lookup() in smbfs_vnops.c:1.58. Tested by: "Antony Mawer" ant AT mawer.org MFC after: 2 weeks Revision Changes Path 1.42 +11 -26 src/sys/fs/nwfs/nwfs_vnops.c Approved by: re (scottl) Revision Changes Path 1.41.2.1 +11 -26 src/sys/fs/nwfs/nwfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 20:20:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7380E16A41F; Wed, 19 Oct 2005 20:20:42 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CAD743D5A; Wed, 19 Oct 2005 20:20:42 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JKKgdI016648; Wed, 19 Oct 2005 20:20:42 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JKKgVN016647; Wed, 19 Oct 2005 20:20:42 GMT (envelope-from truckman) Message-Id: <200510192020.j9JKKgVN016647@repoman.freebsd.org> From: Don Lewis Date: Wed, 19 Oct 2005 20:20:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/fs/nwfs nwfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 20:20:42 -0000 truckman 2005-10-19 20:20:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/fs/nwfs nwfs_vnops.c Log: MFC nwfs_lookup.c 1.42 Original commit message: Modified files: sys/fs/nwfs nwfs_vnops.c Log: Update nwfs_lookup() to match the current cache_lookup() API. cache_lookup() has returned a ref'ed and locked vnode since vfs_cache.c:1.96, dated Tue Mar 29 12:59:06 2005 UTC. This change is similar to the change made to smbfs_lookup() in smbfs_vnops.c:1.58. Tested by: "Antony Mawer" ant AT mawer.org MFC after: 2 weeks Revision Changes Path 1.42 +11 -26 src/sys/fs/nwfs/nwfs_vnops.c Approved by: re (scottl) Revision Changes Path 1.41.4.1 +11 -26 src/sys/fs/nwfs/nwfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 20:29:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6AC0B16A41F; Wed, 19 Oct 2005 20:29:10 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4295F43D70; Wed, 19 Oct 2005 20:29:08 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JKT8np017100; Wed, 19 Oct 2005 20:29:08 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JKT886017099; Wed, 19 Oct 2005 20:29:08 GMT (envelope-from truckman) Message-Id: <200510192029.j9JKT886017099@repoman.freebsd.org> From: Don Lewis Date: Wed, 19 Oct 2005 20:29:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/ufs/ufs ufs_lookup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 20:29:10 -0000 truckman 2005-10-19 20:29:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/ufs/ufs ufs_lookup.c Log: MFC ufs_lookup.c 1.78 and 1.79. Original commit messages: Modified files: sys/ufs/ufs ufs_lookup.c Log: Close a race in the ufs_lookup() code that handles the ISDOTDOT case by saving the value of dp->i_ino before unlocking the vnode for the current directory and passing the saved value to VFS_VGET(). Without this change, another thread can overwrite dp->i_ino after the current directory is unlocked, causing ufs_lookup() to lock and return the wrong vnode in place of the vnode for its parent directory. A deadlock can occur if dp->i_ino was changed to a subdirectory of the current directory because the root to leaf vnode lock ordering will be violated. A vnode lock can be leaked if dp->i_ino was changed to point to the current directory, which causes the current vnode lock for the current directory to be recursed, which confuses lookup() into calling vrele() when it should be calling vput(). The probability of this bug being triggered seems to be quite low unless the sysctl variable debug.vfscache is set to 0. Reviewed by: jhb MFC after: 2 weeks Revision Changes Path 1.78 +3 -1 src/sys/ufs/ufs/ufs_lookup.c Modified files: sys/ufs/ufs ufs_lookup.c Log: Correct the type of the temporary variable used by ufs_lookup.c:1.78 to fix the race condition in the ufs_lookup() ISDOTDOT code. Noticed by: bde MFC after: 12 days Revision Changes Path 1.79 +1 -1 src/sys/ufs/ufs/ufs_lookup.c Approved by: re (scottl) Revision Changes Path 1.77.2.1 +3 -1 src/sys/ufs/ufs/ufs_lookup.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 20:31:46 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 860E116A420; Wed, 19 Oct 2005 20:31:46 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 43EBF43D64; Wed, 19 Oct 2005 20:31:46 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JKVkW4017263; Wed, 19 Oct 2005 20:31:46 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JKVkvv017262; Wed, 19 Oct 2005 20:31:46 GMT (envelope-from truckman) Message-Id: <200510192031.j9JKVkvv017262@repoman.freebsd.org> From: Don Lewis Date: Wed, 19 Oct 2005 20:31:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/ufs/ufs ufs_lookup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 20:31:46 -0000 truckman 2005-10-19 20:31:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/ufs/ufs ufs_lookup.c Log: MFC ufs_lookup.c 1.78 and 1.79. Original commit messages: Modified files: sys/ufs/ufs ufs_lookup.c Log: Close a race in the ufs_lookup() code that handles the ISDOTDOT case by saving the value of dp->i_ino before unlocking the vnode for the current directory and passing the saved value to VFS_VGET(). Without this change, another thread can overwrite dp->i_ino after the current directory is unlocked, causing ufs_lookup() to lock and return the wrong vnode in place of the vnode for its parent directory. A deadlock can occur if dp->i_ino was changed to a subdirectory of the current directory because the root to leaf vnode lock ordering will be violated. A vnode lock can be leaked if dp->i_ino was changed to point to the current directory, which causes the current vnode lock for the current directory to be recursed, which confuses lookup() into calling vrele() when it should be calling vput(). The probability of this bug being triggered seems to be quite low unless the sysctl variable debug.vfscache is set to 0. Reviewed by: jhb MFC after: 2 weeks Revision Changes Path 1.78 +3 -1 src/sys/ufs/ufs/ufs_lookup.c Modified files: sys/ufs/ufs ufs_lookup.c Log: Correct the type of the temporary variable used by ufs_lookup.c:1.78 to fix the race condition in the ufs_lookup() ISDOTDOT code. Noticed by: bde MFC after: 12 days Revision Changes Path 1.79 +1 -1 src/sys/ufs/ufs/ufs_lookup.c Approved by: re (scottl) Revision Changes Path 1.77.4.1 +3 -1 src/sys/ufs/ufs/ufs_lookup.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 20:40:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31AE916A41F; Wed, 19 Oct 2005 20:40:31 +0000 (GMT) (envelope-from jdp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE47043D68; Wed, 19 Oct 2005 20:40:30 +0000 (GMT) (envelope-from jdp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JKeUJa017574; Wed, 19 Oct 2005 20:40:30 GMT (envelope-from jdp@repoman.freebsd.org) Received: (from jdp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JKeUs5017573; Wed, 19 Oct 2005 20:40:30 GMT (envelope-from jdp) Message-Id: <200510192040.j9JKeUs5017573@repoman.freebsd.org> From: John Polstra Date: Wed, 19 Oct 2005 20:40:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_linker.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 20:40:31 -0000 jdp 2005-10-19 20:40:30 UTC FreeBSD src repository Modified files: sys/kern kern_linker.c Log: Fix a bug in the kernel module runtime linker that made it impossible to unload the usb.ko module after boot if it was originally preloaded from "/boot/loader.conf". When processing preloaded modules, the linker erroneously added self-dependencies the each module's reference count. That prevented usb.ko's reference count from ever going to 0, so it could not be unloaded. Sponsored by Isilon Systems. Reviewed by: pjd, peter MFC after: 1 week Revision Changes Path 1.118 +3 -0 src/sys/kern/kern_linker.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 20:44:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D52516A41F; Wed, 19 Oct 2005 20:44:55 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 053FD43D62; Wed, 19 Oct 2005 20:44:55 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JKisLn017740; Wed, 19 Oct 2005 20:44:54 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JKisgT017739; Wed, 19 Oct 2005 20:44:54 GMT (envelope-from thompsa) Message-Id: <200510192044.j9JKisgT017739@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 19 Oct 2005 20:44:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/net if_bridge.c if_ethersubr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 20:44:55 -0000 thompsa 2005-10-19 20:44:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net if_bridge.c if_ethersubr.c Log: MFC: if_bridge.c r1.26, if_ethersubr.c r1.205 > Use bridge_ifdetach() to notify the bridge that a member has been detached. > The bridge can then remove it from its interface list and not try to send > out via a dead pointer. Approved by: re (scottl) Revision Changes Path 1.11.2.13 +5 -1 src/sys/net/if_bridge.c 1.193.2.5 +8 -0 src/sys/net/if_ethersubr.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 20:46:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84FBA16A41F; Wed, 19 Oct 2005 20:46:16 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B42943D5A; Wed, 19 Oct 2005 20:46:16 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JKkGVB017877; Wed, 19 Oct 2005 20:46:16 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JKkGxd017876; Wed, 19 Oct 2005 20:46:16 GMT (envelope-from thompsa) Message-Id: <200510192046.j9JKkGxd017876@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 19 Oct 2005 20:46:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/net if_bridge.c if_ethersubr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 20:46:16 -0000 thompsa 2005-10-19 20:46:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/net if_bridge.c if_ethersubr.c Log: MFC: if_bridge.c r1.26, if_ethersubr.c r1.205 > Use bridge_ifdetach() to notify the bridge that a member has been detached. > The bridge can then remove it from its interface list and not try to send > out via a dead pointer. Approved by: re (scottl) Revision Changes Path 1.11.2.12.2.1 +5 -1 src/sys/net/if_bridge.c 1.193.2.4.2.1 +8 -0 src/sys/net/if_ethersubr.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 21:21:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 555C516A41F; Wed, 19 Oct 2005 21:21:23 +0000 (GMT) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1038343D62; Wed, 19 Oct 2005 21:21:23 +0000 (GMT) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JLLMQE026281; Wed, 19 Oct 2005 21:21:22 GMT (envelope-from brooks@repoman.freebsd.org) Received: (from brooks@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JLLM9U026280; Wed, 19 Oct 2005 21:21:22 GMT (envelope-from brooks) Message-Id: <200510192121.j9JLLM9U026280@repoman.freebsd.org> From: Brooks Davis Date: Wed, 19 Oct 2005 21:21:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/devd Makefile devd.cc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 21:21:23 -0000 brooks 2005-10-19 21:21:22 UTC FreeBSD src repository Modified files: sbin/devd Makefile devd.cc Log: Make devd WARNS=4 clean and bump WARNS accordingly. This will insure that future variable shadowing bugs don't compile. Reviewed by: imp Compiled on: alpha i386 sparc64 Revision Changes Path 1.7 +1 -1 src/sbin/devd/Makefile 1.27 +2 -2 src/sbin/devd/devd.cc From owner-cvs-src@FreeBSD.ORG Wed Oct 19 21:25:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 40EAE16A41F; Wed, 19 Oct 2005 21:25:32 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0C6C43D62; Wed, 19 Oct 2005 21:25:31 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JLPVBI026441; Wed, 19 Oct 2005 21:25:31 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JLPVBg026440; Wed, 19 Oct 2005 21:25:31 GMT (envelope-from phk) Message-Id: <200510192125.j9JLPVBg026440@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 19 Oct 2005 21:25:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 21:25:32 -0000 phk 2005-10-19 21:25:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/devfs devfs_vnops.c Log: MFC: Use correct criteria to determine if dirent can be removed right away. Approved by: re@ (scottl) Revision Changes Path 1.114.2.6 +1 -1 src/sys/fs/devfs/devfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 21:26:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3682716A41F; Wed, 19 Oct 2005 21:26:03 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5C6643D64; Wed, 19 Oct 2005 21:26:02 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JLQ2tF026480; Wed, 19 Oct 2005 21:26:02 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JLQ2BE026479; Wed, 19 Oct 2005 21:26:02 GMT (envelope-from phk) Message-Id: <200510192126.j9JLQ2BE026479@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 19 Oct 2005 21:26:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 21:26:03 -0000 phk 2005-10-19 21:26:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/fs/devfs devfs_vnops.c Log: MFC: Use correct criteria to determine if dirent can be removed right away. Approved by: re@ (scottl) Revision Changes Path 1.114.2.5.2.1 +1 -1 src/sys/fs/devfs/devfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed Oct 19 22:26:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EA7716A420; Wed, 19 Oct 2005 22:26:49 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 570BB43D7B; Wed, 19 Oct 2005 22:26:48 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9JMQlhC028663; Wed, 19 Oct 2005 22:26:47 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9JMQle7028662; Wed, 19 Oct 2005 22:26:47 GMT (envelope-from jkim) Message-Id: <200510192226.j9JMQle7028662@repoman.freebsd.org> From: Jung-uk Kim Date: Wed, 19 Oct 2005 22:26:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d wpa_supplicant X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2005 22:26:49 -0000 jkim 2005-10-19 22:26:47 UTC FreeBSD src repository Modified files: etc/rc.d wpa_supplicant Log: wpa_supplicant(8) requires -D option for ndis(4) now. Revision Changes Path 1.2 +10 -1 src/etc/rc.d/wpa_supplicant From owner-cvs-src@FreeBSD.ORG Thu Oct 20 01:02:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FFCD16A41F; Thu, 20 Oct 2005 01:02:10 +0000 (GMT) (envelope-from ups@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D69043D5A; Thu, 20 Oct 2005 01:02:10 +0000 (GMT) (envelope-from ups@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9K12AJA042971; Thu, 20 Oct 2005 01:02:10 GMT (envelope-from ups@repoman.freebsd.org) Received: (from ups@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9K12AWZ042970; Thu, 20 Oct 2005 01:02:10 GMT (envelope-from ups) Message-Id: <200510200102.j9K12AWZ042970@repoman.freebsd.org> From: Stephan Uphoff Date: Thu, 20 Oct 2005 01:02:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/i386/i386 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 01:02:10 -0000 ups 2005-10-20 01:02:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/i386 vm_machdep.c Log: MFC vm_machdep.c 1.261-1.263 Rev: 1.261 Ensure that a thread stays on same CPU when calculating per CPU TLB shootdown requirements. Otherwise a CPU may not get the needed TLB invalidation. The PTE valid and access flags can not be used here to avoid TLB shootdowns unless sf->cpumask == all_cpus. ( Otherwise some CPUs may still hold an even older entry in the TLB) Since sf_buf_alloc mappings are normally always used this is also not really useful and presetting accessed and modified allows the CPU to speculatively load the entry into the TLB. Both bugs can cause random data corruption. Rev: 1.262 Restore optimizations to reduce TLB shootdowns. Alan Cox pointed out that they are really useful for sendfile(). Rev: 1.263 Restore the UP optimization to reduce the number of TLB invalidations. The previous revision only restored the MP optimization. Describe the optimization strategy for TLB invalidations in a comment. Approved by: re@ (scottl) Revision Changes Path 1.259.2.1 +37 -31 src/sys/i386/i386/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 01:03:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14D1316A41F; Thu, 20 Oct 2005 01:03:24 +0000 (GMT) (envelope-from ups@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D76AA43D5A; Thu, 20 Oct 2005 01:03:23 +0000 (GMT) (envelope-from ups@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9K13NFl043194; Thu, 20 Oct 2005 01:03:23 GMT (envelope-from ups@repoman.freebsd.org) Received: (from ups@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9K13NoS043193; Thu, 20 Oct 2005 01:03:23 GMT (envelope-from ups) Message-Id: <200510200103.j9K13NoS043193@repoman.freebsd.org> From: Stephan Uphoff Date: Thu, 20 Oct 2005 01:03:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/i386/i386 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 01:03:24 -0000 ups 2005-10-20 01:03:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/i386/i386 vm_machdep.c Log: MFC vm_machdep.c 1.261-1.263 Rev: 1.261 Ensure that a thread stays on same CPU when calculating per CPU TLB shootdown requirements. Otherwise a CPU may not get the needed TLB invalidation. The PTE valid and access flags can not be used here to avoid TLB shootdowns unless sf->cpumask == all_cpus. ( Otherwise some CPUs may still hold an even older entry in the TLB) Since sf_buf_alloc mappings are normally always used this is also not really useful and presetting accessed and modified allows the CPU to speculatively load the entry into the TLB. Both bugs can cause random data corruption. Rev: 1.262 Restore optimizations to reduce TLB shootdowns. Alan Cox pointed out that they are really useful for sendfile(). Rev: 1.263 Restore the UP optimization to reduce the number of TLB invalidations. The previous revision only restored the MP optimization. Describe the optimization strategy for TLB invalidations in a comment. Approved by: re@ (scottl) Revision Changes Path 1.259.4.1 +37 -31 src/sys/i386/i386/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 04:02:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 87F2F16A41F; Thu, 20 Oct 2005 04:02:02 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D739343D5A; Thu, 20 Oct 2005 04:02:01 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9K41xpP010053; Thu, 20 Oct 2005 14:01:59 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9K41v16001909; Thu, 20 Oct 2005 14:01:58 +1000 Date: Thu, 20 Oct 2005 14:01:57 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <67214.1129620597@critter.freebsd.dk> Message-ID: <20051020131450.T99502@delplex.bde.org> References: <67214.1129620597@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 04:02:02 -0000 On Tue, 18 Oct 2005, Poul-Henning Kamp wrote: > In message <20051018135821.L93164@delplex.bde.org>, Bruce Evans writes: > >> This is bogus, and it breaks vmstat some more in the dead kernel case. >> >> In the live kernel case, clock_gettime() returns the time since an >> unspecified point in the past. It is still necessary to subtract the >> boottime, one measured by the same clock, especially under systems >> like FreeBSD where the "unspecified point in the past" is undocumented. > > The unspecified point in the past is actually the exact time the kernel > booted and therefore clock_gettime(CLOCK_MONOTONIC) does the right thing > for a running kernel. This is an undocumented implementation detail. clock_gettime(CLOCK_MONOTONIC) does a wrong thing partly because it depends on this detail. >> For live kernels, subtracting the boot time from the current _real_ >> time using difftime() is the correct method. > > Actually it isn't, but it comes close. CLOCK_MONOTONIC is the true > elapsed time since boot, whereas boottime is our retrospective UTC > estimate of that moment. Actually, both are wrong methods, although both could work: Using difftime() doesn't because difftime() doesn't understand leap seconds. It needs to understand leap seconds, at least under POSIX where time_t is specified to be broken, but it just does a naive subtraction of time_t's. Thus (mis)using difftime() on the time_t's returned by clock_gettime(CLOCK_MONOTONIC, ...) works because difftime() is broken, but using difftime() on the time_t's returned by clock_gettime(CLOCK_REALTIME) doesn't work. vmstat wants the difference in seconds, but w converts to a "human readable" time using a naive method that doesn't understand leap seconds, so it actually wants the wrong difference provided by not having leap seconds in real times and not adjusting for them in difftime(). Using CLOCK_MONOTONIC doesn't work because it it gives the system's idea of the time and doesn't try hard to keep in sync with the real time. In particular, it doesn't jump when the real time is stepped by settimeofday(2) or clock_settime(2). Sometimes such a step is to fix up the real time after it has drifted. Since steps are not applied to the monotonic time, the monotonic time retains the drift and differences in the monotonic time don't give differences in real time. Bruce From owner-cvs-src@FreeBSD.ORG Thu Oct 20 05:12:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CE3616A41F; Thu, 20 Oct 2005 05:12:23 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58FF743D5A; Thu, 20 Oct 2005 05:12:23 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9K5CMHw061649; Thu, 20 Oct 2005 05:12:23 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9K5CM7G061648; Thu, 20 Oct 2005 05:12:22 GMT (envelope-from njl) Message-Id: <200510200512.j9K5CM7G061648@repoman.freebsd.org> From: Nate Lawson Date: Thu, 20 Oct 2005 05:12:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/powerd powerd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 05:12:23 -0000 njl 2005-10-20 05:12:20 UTC FreeBSD src repository Modified files: usr.sbin/powerd powerd.c Log: Set the signal handlers before creating the thread. This is so it inherits the parent's signal mask. Once daemon() forked, signals would be ignored in the child thread. While I'm here, check the return value of daemon(). This fixes termination in the daemon case (bug introduced in last commit). Noticed by: Frederik Lindberg Revision Changes Path 1.14 +15 -4 src/usr.sbin/powerd/powerd.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 05:41:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09A7216A41F; Thu, 20 Oct 2005 05:41:39 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8FB943D5A; Thu, 20 Oct 2005 05:41:38 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9K5fce2062712; Thu, 20 Oct 2005 05:41:38 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9K5fcAi062711; Thu, 20 Oct 2005 05:41:38 GMT (envelope-from peter) Message-Id: <200510200541.j9K5fcAi062711@repoman.freebsd.org> From: Peter Wemm Date: Thu, 20 Oct 2005 05:41:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libkvm kvm_amd64.c kvm_i386.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 05:41:39 -0000 peter 2005-10-20 05:41:38 UTC FreeBSD src repository Modified files: lib/libkvm kvm_amd64.c kvm_i386.c Log: Fix a well duplicated fencepost error that stopped crashdumps being readable on certain random memory configurations. If the libkvm consumer tried to read something that was in the very last pdpe, pde or pte slot, it would bogusly fail. This is broken in RELENG_6 too. Revision Changes Path 1.19 +3 -3 src/lib/libkvm/kvm_amd64.c 1.18 +4 -4 src/lib/libkvm/kvm_i386.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 05:45:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F019D16A41F; Thu, 20 Oct 2005 05:45:34 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B97F43D62; Thu, 20 Oct 2005 05:45:32 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9K5jSUG014862; Thu, 20 Oct 2005 15:45:28 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9K5jKEa026219; Thu, 20 Oct 2005 15:45:25 +1000 Date: Thu, 20 Oct 2005 15:45:21 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Scott Long In-Reply-To: <4355080C.302@samsco.org> Message-ID: <20051020145234.H99720@delplex.bde.org> References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <435501B9.4070401@samsco.org> <17237.1482.52148.283282@grasshopper.cs.duke.edu> <4355080C.302@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 05:45:35 -0000 On Tue, 18 Oct 2005, Scott Long wrote: [Excessive quoting retained since I want to comment on separate points.] > Andrew Gallatin wrote: >> Scott Long writes: >> > Andrew Gallatin wrote: >> > > David Xu [davidxu@FreeBSD.org] wrote: >> > > > >>davidxu 2005-10-17 23:10:31 UTC >> > >> >> > >> FreeBSD src repository >> > >> >> > >> Modified files: >> > >> sys/amd64/amd64 cpu_switch.S machdep.c > >> Log: >> > >> Micro optimization for context switch. Eliminate code for saving >> gs.base >> > >> and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase >> > >> when user wants to set them, in context switch routine, we only need >> to >> > >> write them into registers, we never have to read them out from >> registers >> > >> when thread is switched away. Since rdmsr is a serialization >> instruction, >> > >> micro benchmark shows it is worthy to do. >> > > > > > > Nice. This reduces lmbench context switch latency by about >> 0.4us (7.2 >> > > -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> >> > > 35.2) on my dual core 3800+ I wonder if this reduces the context switch latency from about 1.320 usec to 0.900 usec on my A64-3000. The latency is only .520 usec in i386 mode. I use a TSC timecounter of course. The fastest loopback latency that I've seen is 5.638 usec under Linux-2.2.9 on the same machine. In Linux-2.6.10, it has regressed to 17.1 usec. In FreeBSD last year, it was 10.8 usec on the same machine in i386 mode and 19.0 in amd64 mode. So the A64 can almost keep up with an AXP-1400 running a pre-SMPng version of FreeBSD where it was 9.94 usec. [... Nonsense by phk already snipped] The timecounter is not used by schedulers, so the inefficiency of non-TSC timecounters and its effect on context switching has nothing to do with schedulers. Schedulers use mainly tick counts, and intentionally don't try hard to keep track of interrupt times because the fine-grained timekeeping needed to keep track of interrupts would be too expansive. It is still too expensive, but is now done (except for fast interrupts), but is not used by schedulers. The timestamps taken by mi_switch() are used mainly by userland statistics utilities. They are very useful for debugging and for otherwise understanding system behaviour, but are sometimes too inefficient. >> > > > > It is a shame we can't find a way to use the TSC as a timecounter >> on >> > > SMP systems. It seems that about 40% of the context switch time is >> > > spent just waiting for the PIO read of the ACPI-fast or i8254 to >> > > return. It seems to be more like 95% in year case. >> > > > > > > Drew >> > > > > > > > > The TSC represents the clock rate of the CPU, and thus >> can vary wildly >> > when thermal and power management controls kick in, and there is no way >> > to know when it changes. Because of this, I think that it's >> > practically useless on Pentium-Mobile and Pentium-M chips, among many >> > others. There is also the issue of multiple CPUs having to keep their >> > TSC's somewhat in sync in order to get consistent counting in the >> > system. The best that you can do is to periodically read a stable >> > counter and try to recalibrate, but then you'll likely start getting >> > wild operational variances. I agree that it's too hard to sync the TSC on systems with power management. It would be easy enough to sync with the i8254 every HZ, but even that would give extreme nonlinearities when the TSC frequency jumps up or down. Jumping up is the worst case. E.g, if the TSC frequency starts at 1GHz and HZ is 1000 expect the TSC count to increment by 10^6 in the next msec. If the TSC frequency jumps up to 2GHz, then the TSC count will actually increment by 2*10^6. I see nothing better than recalibrating half way into the next msec (when the TSC count reaches 10^6) and then wildly slewing the TSC clock so that the 10^6 increment in the count expected in the next half a msec from causing another half-msec error. >> As I pointed out in another thread, both linux and solaris do it. >> Solaris seems to have a nice algorithm for keeping things in sync, and >> accounting for the TSC getting cleared after suspend/resume etc. At >> my level of understanding, this argument is nothing more than "but >> Mom, all the other kids are doing it". I was just hoping that >> somebody with real understanding could pick up on it. > > Steering mutliple TSC's together isn't that hard and there are plenty of > examples, as you point out. Accounting for the changes due to thermal > and power management (note that this isn't the same problem as suspend > and resume) is what worries me. Possibly the systems with power management don't matter here. Power management is currently only essential for portable machines, and the portable machines won't have multi-Gb/s networks to keep up with and might not have such strict real time requirements. >> > It's a shame that a PIO read is still so >> > expensive. I'd hate to see just how bad your benchmark becomes when >> > ACPI-slow is used instead of ACPI-fast. >> >> It seems like reading ACPI-fast is "only" 3us or so, but when the ctx >> switch is otherwise 4us, it adds up. i8254 is much worse on this >> system (6.5us). I don't know why your system is so slow. I get ~50nsec for TSC, ~1000 nsec for ACPI-fast, ~3000 nsec for ACPI-slow and ~4000 nsec for i8254. But PIO keeps getting slower even in absolute terms. My (nearly) newest system (nForce2) has ISA PIO times of 1133 nsec for the i8254 registers where my first PCI system (with an early Intel chipset) has a read time of 703 usec and a write time of 1180 nsec. The nForce2 system also has a PCI PIO read time of 290 nsec for the same PCI card that can be read in 125 nsec (overclocked) or 150 nsec (not overclocked) on a KT266A system. >> > I wonder if moving to HZ=1000 on amd64 and i386 was really all that good >> > of an idea. Having preemption in the kernel means that ithreads can run >> > right away instead of having to wait for a tick, and various fixes to >> > 4BSD in the past year have eliminated bugs that would make the CPU wait >> > for up to a tick to schedule a thread. So all we're getting now is a >> > 10x increase in scheduler overhead, including reading the timecounters. >> >> Yeah. I moved my back to hz=1000 when I noticed 4000 interrupts/sec >> on an idle system. > > Do you mean 1000 or 100 here? Anyways, the high clock interrupt rate is > so that we can use the local apic clock to get the various system ticks > that we have instead of continuing to fight motherboards that no longer > hook up the 8259 in a sane way. This is why 5.x doesn't work well on a > number of new motherboards (nvidia ones especially) but 6.x works just > fine. [Dan actually meant 100.] I use 100 and never downgraded to use 1000 except for testing how bad it is. The default number is now up to * 2 * HZ. E.g., it is 4000 on sledge.freebsd.org. While 4000 interrupts/sec can be handled easily by any new machine, 4000 is a disgustingly large number to use for clock interrupts. Have a look at vmstat -i output on almost any machine. On most machines in the freebsd cluster, the total number of interrupts is dominated by clock interrupts even with HZ = 100. The main use for a large HZ is to low quality hardware and applications that need or want to poll very often. Bruce From owner-cvs-src@FreeBSD.ORG Thu Oct 20 05:53:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 827AF16A41F; Thu, 20 Oct 2005 05:53:21 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id D547043D62; Thu, 20 Oct 2005 05:53:20 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9K5rGV8005487; Thu, 20 Oct 2005 15:53:16 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9K5rEG5013000; Thu, 20 Oct 2005 15:53:15 +1000 Date: Thu, 20 Oct 2005 15:53:15 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: John Baldwin In-Reply-To: <200510181101.03956.jhb@freebsd.org> Message-ID: <20051020154709.U99720@delplex.bde.org> References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <200510181101.03956.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 05:53:21 -0000 On Tue, 18 Oct 2005, John Baldwin wrote: > On Tuesday 18 October 2005 09:44 am, Andrew Gallatin wrote: >> It is a shame we can't find a way to use the TSC as a timecounter on >> SMP systems. It seems that about 40% of the context switch time is >> spent just waiting for the PIO read of the ACPI-fast or i8254 to >> return. > > You can try it by just setting the kern.timecounter.smp_tsc=1 tunable on boot. There is no need for this. Just set the timecounter using sysctl after booting (and quickly switch it back if it doesn't work). This tuneable, like most, shouldn't exist. It may be a relic from when the TSC wasn't put in the list of available timecounters in the SMP case. It is now put in the list with a negative "quaility", but the sysctl to set the timecounter correctly not restricted by the quality. Bruce From owner-cvs-src@FreeBSD.ORG Thu Oct 20 06:44:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2F5816A41F; Thu, 20 Oct 2005 06:44:00 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F4D343D5A; Thu, 20 Oct 2005 06:44:00 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id C1889BC50; Thu, 20 Oct 2005 06:43:57 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 20 Oct 2005 14:01:57 +1000." <20051020131450.T99502@delplex.bde.org> Date: Thu, 20 Oct 2005 08:43:57 +0200 Message-ID: <8229.1129790637@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 06:44:00 -0000 In message <20051020131450.T99502@delplex.bde.org>, Bruce Evans writes: >On Tue, 18 Oct 2005, Poul-Henning Kamp wrote: >Using CLOCK_MONOTONIC doesn't work because it it gives the system's idea >of the time and doesn't try hard to keep in sync with the real time. >In particular, it doesn't jump when the real time is stepped by >settimeofday(2) or clock_settime(2). Uhm, Bruce, That is the exact reason why we have CLOCK_MONOTONIC: it doesn't jump. With respect to leapseconds: Whoever was responsible for POSIX's decision should be forced to work as quality assurance inspector in a factory which makes cuu-cuu clocks for the rest of their lives. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Oct 20 07:39:24 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CE7616A420; Thu, 20 Oct 2005 07:39:24 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEBAD43D5A; Thu, 20 Oct 2005 07:39:23 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9K7dJNK064404; Thu, 20 Oct 2005 07:39:20 GMT (envelope-from davidxu@freebsd.org) Message-ID: <435749A8.5070309@freebsd.org> Date: Thu, 20 Oct 2005 15:39:20 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20050928 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bruce Evans References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <435501B9.4070401@samsco.org> <17237.1482.52148.283282@grasshopper.cs.duke.edu> <4355080C.302@samsco.org> <20051020145234.H99720@delplex.bde.org> In-Reply-To: <20051020145234.H99720@delplex.bde.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Scott Long , src-committers@freebsd.org, Andrew Gallatin , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 07:39:24 -0000 Bruce Evans wrote: > On Tue, 18 Oct 2005, Scott Long wrote: > > [Excessive quoting retained since I want to comment on separate points.] > >> Andrew Gallatin wrote: >> >>> Scott Long writes: >>> > Andrew Gallatin wrote: >>> > > David Xu [davidxu@FreeBSD.org] wrote: >>> > > > >>davidxu 2005-10-17 23:10:31 UTC >>> > >> >>> > >> FreeBSD src repository >>> > >> >>> > >> Modified files: >>> > >> sys/amd64/amd64 cpu_switch.S machdep.c > >> Log: >>> > >> Micro optimization for context switch. Eliminate code for >>> saving gs.base >>> > >> and fs.base. We always update pcb.pcb_gsbase and pcb.pcb_fsbase >>> > >> when user wants to set them, in context switch routine, we >>> only need to >>> > >> write them into registers, we never have to read them out from >>> registers >>> > >> when thread is switched away. Since rdmsr is a serialization >>> instruction, >>> > >> micro benchmark shows it is worthy to do. > > >>> > > > > > > Nice. This reduces lmbench context switch latency by >>> about 0.4us (7.2 >>> > > -> 6.8us), and reduces TCP loopback latency by about 0.9us (36.1 -> >>> > > 35.2) on my dual core 3800+ > > > I wonder if this reduces the context switch latency from about 1.320 > usec to 0.900 usec on my A64-3000. The latency is only .520 usec in > i386 mode. I use a TSC timecounter of course. > > The fastest loopback latency that I've seen is 5.638 usec under > Linux-2.2.9 on the same machine. In Linux-2.6.10, it has regressed > to 17.1 usec. In FreeBSD last year, it was 10.8 usec on the same > machine in i386 mode and 19.0 in amd64 mode. So the A64 can almost > keep up with an AXP-1400 running a pre-SMPng version of FreeBSD where > it was 9.94 usec. we can avoid reloading userland GS.base MSR and FS.base MSR for system threads, I am not sure if it can reduce interrupt thread latency. David Xu From owner-cvs-src@FreeBSD.ORG Thu Oct 20 08:02:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D35C316A41F; Thu, 20 Oct 2005 08:02:09 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E90C43D5A; Thu, 20 Oct 2005 08:02:08 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9K81qh9017953; Thu, 20 Oct 2005 18:01:52 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9K81btg015774; Thu, 20 Oct 2005 18:01:39 +1000 Date: Thu, 20 Oct 2005 18:01:38 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <69026.1129649491@critter.freebsd.dk> Message-ID: <20051020155911.C99720@delplex.bde.org> References: <69026.1129649491@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Scott Long , src-committers@FreeBSD.org, Andrew Gallatin , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 08:02:10 -0000 On Tue, 18 Oct 2005, Poul-Henning Kamp wrote: > [At the risk of repeating myself once more...] > ... > One of the things you have to realize is that once you go down this > road you need a lot of code for all the conditionals. > > For instance you need to make sure that every new timestamp you > hand out not prior to another one, no matter what is happening to > the clocks. Clocks are already incoherent in many ways: - the times returned by the get*() functions incoherent with the ones returned by the functions that read the hardware, because the latter are always in advance of the former and the difference is sometimes visible at the active resolution. POSIX tests of file times have been reporting this incoherency since timecounters were implemented. The tests use time() to determine the current time and stat() to determine file times. In the sequence: t1 = time(...): sleep(1) touch(file); stat(file); t2 = mtime(file); t2 should be < t1, but the bug lets t2 == t1 happen. - times are incoherent between threads unless the threads use their own expensive locking to prevent this. This is not very different from timestamps being incoherent between CPUs unless the system uses expensive locking to prevent it. > ... >>> It seems like reading ACPI-fast is "only" 3us or so, but when the ctx >>> switch is otherwise 4us, it adds up. i8254 is much worse on this >>> system (6.5us). > > i8254 is always bad, and about as bad as it can. The i8254 is not that bad, and far from as bad as can be. > Mostly because > of the need to disable interrupts (Actually, that's a critical > section today, isn't it ?) and also hobbled by the three 8 bit > ISA-bus(-like) accesses needed. Mostly not: - disabling interrupts is not necessary is was done mainly because it is most efficient except (apparently) on P4's. It is only necessary to repeat the read if the conditions were changed underneath us by an interrupt. Whether there was an interrupt can easily be determined by looking at the interrupt count. Disabling of interrupts is still always used, at least on i386's. This is essential in the non-lapic case and good in the lapic case: - In the non-lapic case, the code hasn't changed significantly lately and still has an explicit hard-disablement. There is a magic number of 20 i8254 cycles (spelled TIMER0_LATCH_COUNT in axed code) that gives a real-time requirement on the maximum time between the i8254 timer read and the check for rollover. Disabling interrupts is not sufficient to meet this requirement since bus activity may lengthen the time for the combined i/o to many more than 20 cycles (I've measured about 200 for similar code in getit()), but it mostly works. If interrupts were not hard-disabled, then almost any interrupt would break this requirement. - In the lapic case, there is now only a spin mutex on the clock lock. The lock is essential, and it gives a critical section which is almost as essential (since without the critical section a low priority thread reading the i8254 might be preempted while holding the lock). Spin mutexes still hard-disable interrupts, so interrupts are still hard-disabled as a side effect. Hard-disabling interrupts for spinlocks is a bug, but here it is good though not essential. It prevents fast interrupt handlers and low-level non-context-switching interrupt code from running. There is no longer a requirement for completing the function in 20 i8254 cycles, but doing so is safest. The simplification in the lapic case has very little to do with interrupts, clock or otherwise. The real-time requirement is now that i8254_get_timecount() be called significantly more often than the i8254 rolls over. This is now easily satisfied by increasing the rollover period to ~55 msec and depending on users not configuring HZ to permitted values of <= 18 Hz. Even HZ = 100 provides a safety margin. This method could also be used for the non-lapic case, using either another source of periodic interrupts to keep calling i82854_get_timecount() significantly more often than every 1/HZ seconds, or by using another source for hardclock interrupts. On i386's, the RTC would work perfectly for clock interrupts too except for minor problems in schedulers and maybe applications wanting timeouts of exactly 10 msec. - only 1 or 2 accesses are needed: - 2 with only the LSB of the count used. This HZ to be larger than about 5000. Large HZ are undesirable in general but are sometimes good for dumb hardware like the i8254. - 1 with unlatched reads. I could never get this to work. >>> > I wonder if moving to HZ=1000 on amd64 and i386 was really all that good >>> > of an idea. > > The main benefit was getting more precise timeouts, something we have > at various times thought about implementing with deadline counters > on platforms that have it. Nobody has done it though. Dragonfly did it. > So, instead of looking for "quick fixes", lets look at this with a > designers or architects view: > > On a busy system the scheduler works hundred thousand times per > second, but on most systems nobody ever looks at the times(2) data. More like 1000 times a second. Even stathz = 128 gives too many decisions per second for the 4BSD scheduler, so it is divided down to 16 per second. Processes blocking on i/o may cause many more than 128/sec calls to the scheduler, but there should be nothing much to decide then. > The smart solution is therefore to postpone the heavy stuff into > times(2) and make the scheduler work as fast as it can. Once more: schedulers haven't used anything related to times(2) since the ancient version of 3BSD or 4BSD where times() was superseded by gettimeofday(), and have never used timecounters. (Even times(2) doesn't use anything related to scheduling except to fake 4BSD scheduler clock ticks in its API.) > So the scheduler should read the TSC and schedule in TSC-ticks. Schedulers never read the TSC. The schedule in statclock ticks. > times(2) will then have to convert this to clock_t compatible > numbers. It has converted from real times to clock_t's since before FreeBSD-1. The real times happen to be implemented using timecounters and the timecounter may be the TSC. times() doesn't really care. OTOH, getrusage() reports process times in real times (with only some resolution lost by converting MD times to bintimes and then bintimes to timevals). > According the The Open Group, clock_t is in microseconds by means > of historical standards mistakes. clock_t in microseconds is required for historical mistakes in OS's supported by The Open Group. FreeBSD never had these particular mistakes. It has different ones, and has sysconf(_SC_CLK_TCK) fixed at 128 to support them. (Note that the units for clock_t are not the same for all uses of clock_t, but for the historical times() mistake they are 1/sysconf(_SC_CLK_TCK) seconds. As an implementation detail, FreeBSD uses 1/128 for all clock_t's even in cases where the historical mistakes have less inertia.) > However, I can see nowhere that would collide with an interpretation > that said "clock_t is microseconds PROVIDED the cpu had run at full > speed", so a simple one second routine to latch the highest number > of TSC-tics we've seen in a second would be sufficient to generate > the conversion factor. > > And in many ways this would be a much more useful metric to offer > (in top(1)) than the current rubber-band-cpu-seconds. You seem to have left out a "not" here. Users mostly only care about the real time taken by their processes. If the conversion factor is constant then it is possible for even users to apply it to convert from the units displayed by top and friends to their favourite units, but with variable conversion factors it would be difficult for even applications to do the conversion. Syscalls would have to return a table giving their best idea of the conversion factors at different times in the processes lifetime, and applications would have to integrate over time to convert to a single number to display to the user, according to user-specified weights. Better yet, put the integration in the kernel and use syscalls to tell the kernel the weights ;-). Anyway, getrusage() has fewer historical mistakes than times(), and maintaining non-broken support for it requires using timecounters in mi_switch() almost like we already do. Hmm. Checking the history shows some anachronisms in what I said in the above. It is only necessary to go back as far as FreeBSD-1 to find a BSD where ticks are used for getrusage() too. In FreeBSD-1, there wasn't even an mi_swtch(). Context switches went directly to MD code in swtch() and swtch() was missing calls to microtime()/bintime() and many other expenses. The bogusness in times() and getrusage() was sort of reversed -- getrusage() (actually hardclock()) converted from low-resolution tick counts to high resolution timevals and times() just returned the tick counts; now getrusage() only uses the tick counts for dividing up the total time and times() converts from the high-res units back to low-res ones and ends up with less accuracy that it started with due to double rounding. So the current pessimizations from timecounter calls in mi_switch() are an end result of general pessimizations of swtch() starting in 4.4BSD. I rather like this part of the pessimizations... Bruce From owner-cvs-src@FreeBSD.ORG Thu Oct 20 08:26:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D37F916A41F; Thu, 20 Oct 2005 08:26:04 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E8FF43D79; Thu, 20 Oct 2005 08:26:04 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9K8Q3O8069092; Thu, 20 Oct 2005 08:26:03 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9K8Q3ZW069091; Thu, 20 Oct 2005 08:26:03 GMT (envelope-from stefanf) Message-Id: <200510200826.j9K8Q3ZW069091@repoman.freebsd.org> From: Stefan Farfeleder Date: Thu, 20 Oct 2005 08:26:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libedit editline.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 08:26:05 -0000 stefanf 2005-10-20 08:26:03 UTC FreeBSD src repository Modified files: lib/libedit editline.3 Log: Add el_get to the NAME section. Obtained from: OpenBSD (via NetBSD) Revision Changes Path 1.27 +2 -1 src/lib/libedit/editline.3 From owner-cvs-src@FreeBSD.ORG Thu Oct 20 08:27:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF6E516A41F; Thu, 20 Oct 2005 08:27:16 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 323FB43D62; Thu, 20 Oct 2005 08:27:16 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 447A5BC84; Thu, 20 Oct 2005 08:27:09 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 20 Oct 2005 18:01:38 +1000." <20051020155911.C99720@delplex.bde.org> Date: Thu, 20 Oct 2005 10:27:09 +0200 Message-ID: <23346.1129796829@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Scott Long , src-committers@FreeBSD.org, Andrew Gallatin , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 08:27:17 -0000 In message <20051020155911.C99720@delplex.bde.org>, Bruce Evans writes: >> One of the things you have to realize is that once you go down this >> road you need a lot of code for all the conditionals. >> >> For instance you need to make sure that every new timestamp you >> hand out not prior to another one, no matter what is happening to >> the clocks. > >Clocks are already incoherent in many ways: >- the times returned by the get*() functions incoherent with the ones > returned by the functions that read the hardware, because the latter > are always in advance of the former and the difference is sometimes > visible at the active resolution. Sorry Bruce, but this is just FUD: The entire point of the get* familiy of functions is to provide "good enough" timestamps, very fast, for code that knows it doesn't need better than roughly 1/hz precision. > visible at the active resolution. POSIX tests of file times have > been reporting this incoherency since timecounters were implemented. > The tests use time() to determine the current time and stat() to > determine file times. In the sequence: > > t1 = time(...): > sleep(1) > touch(file); > stat(file); > t2 = mtime(file); > > t2 should be < t1, but the bug lets t2 == t1 happen. t2 == t1 is not illegal. The morons who defined a non-extensible timestamp format obviously didn't belive in Andy Moore, but given a sufficiently fast computer the resolution of the standardized timestamps prevents t2 > t1 in the above test code. >- times are incoherent between threads unless the threads use their > own expensive locking to prevent this. This is not very different > from timestamps being incoherent between CPUs unless the system uses > expensive locking to prevent it. Only if the get* family of functions is used in places where they shouldn't be. I belive there is a sysctl which determines if it is used for vfs timestamp. The default can be changed if necessary. >> So, instead of looking for "quick fixes", lets look at this with a >> designers or architects view: >> >> On a busy system the scheduler works hundred thousand times per >> second, but on most systems nobody ever looks at the times(2) data. > >More like 1000 times a second. Even stathz = 128 gives too many decisions >per second for the 4BSD scheduler, so it is divided down to 16 per second. >Processes blocking on i/o may cause many more than 128/sec calls to the >scheduler, but there should be nothing much to decide then. I'm regularly running into 5 digits in the Csw field in systat -vm. I don't know what events you talk about, but they are clearly not the same as the ones I'm talking about. The problem here is context-switch time, and while we can argue if this is really scheduler related or not, the fact that the scheduler decides which thread to context-switch to should be enough to avoid a silly discussion of semantics. >So the current pessimizations from timecounter calls in mi_switch() >are an end result of general pessimizations of swtch() starting in >4.4BSD. I rather like this part of the pessimizations... It's so nice to have you back in action Bruce :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Oct 20 08:46:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E19B416A41F; Thu, 20 Oct 2005 08:46:45 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 819D743D82; Thu, 20 Oct 2005 08:46:44 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9K8kimq069994; Thu, 20 Oct 2005 08:46:44 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9K8kidE069993; Thu, 20 Oct 2005 08:46:44 GMT (envelope-from glebius) Message-Id: <200510200846.j9K8kidE069993@repoman.freebsd.org> From: Gleb Smirnoff Date: Thu, 20 Oct 2005 08:46:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 08:46:46 -0000 glebius 2005-10-20 08:46:44 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h if_em_hw.h Log: Revamp interrupt handling in em(4) driver: o Do not mask the RX overrun interrupt. o Rewrite em_intr(): - Axe EM_MAX_INTR. - Cycle acknowledging interrupts and processing packets until zero interrupt cause register is read. - If RX overrun comes in log this fact. [ NetBSD also resets adapter in this case, but my tests showed that this is not needed and only pessimizes behavior under heavy load. ] - Since almost all functions is rewritten, style the remaining lines. This fixes em(4) interfaces wedging under high load. In collaboration with: wpaul, cognet Obtained from: NetBSD Revision Changes Path 1.80 +37 -31 src/sys/dev/em/if_em.c 1.34 +1 -8 src/sys/dev/em/if_em.h 1.16 +1 -0 src/sys/dev/em/if_em_hw.h From owner-cvs-src@FreeBSD.ORG Thu Oct 20 09:55:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 808D216A41F; Thu, 20 Oct 2005 09:55:50 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3815B43D62; Thu, 20 Oct 2005 09:55:50 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9K9tn6Z079959; Thu, 20 Oct 2005 09:55:50 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9K9tndJ079958; Thu, 20 Oct 2005 09:55:49 GMT (envelope-from glebius) Message-Id: <200510200955.j9K9tndJ079958@repoman.freebsd.org> From: Gleb Smirnoff Date: Thu, 20 Oct 2005 09:55:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 09:55:50 -0000 glebius 2005-10-20 09:55:49 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h Log: Some more minor cleanups of em(4) driver: - Destroy mutex in case of attach failure. [1] - Lock properly em_watchdog(). [1] - Lock properly em_sysctl_int_delay(). [1] - Remove unused global adapter linked list. - Remove unused dma_size field from struct em_dma_alloc. - Do not touch interface statistics, that must be edited only by upper layers. [1] Submitted by: yongari [1] Revision Changes Path 1.81 +10 -33 src/sys/dev/em/if_em.c 1.35 +0 -3 src/sys/dev/em/if_em.h From owner-cvs-src@FreeBSD.ORG Thu Oct 20 10:39:14 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FDEF16A41F; Thu, 20 Oct 2005 10:39:14 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DD3D43D86; Thu, 20 Oct 2005 10:39:09 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KAd9vX081690; Thu, 20 Oct 2005 10:39:09 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KAd93E081689; Thu, 20 Oct 2005 10:39:09 GMT (envelope-from marius) Message-Id: <200510201039.j9KAd93E081689@repoman.freebsd.org> From: Marius Strobl Date: Thu, 20 Oct 2005 10:39:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/ofw/libofw elf_freebsd.c ofw_console.c ofw_memory.c openfirm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 10:39:14 -0000 marius 2005-10-20 10:39:09 UTC FreeBSD src repository Modified files: sys/boot/ofw/libofw elf_freebsd.c ofw_console.c ofw_memory.c openfirm.c Log: Remove unused variables. Revision Changes Path 1.10 +0 -1 src/sys/boot/ofw/libofw/elf_freebsd.c 1.11 +0 -1 src/sys/boot/ofw/libofw/ofw_console.c 1.7 +0 -1 src/sys/boot/ofw/libofw/ofw_memory.c 1.12 +0 -4 src/sys/boot/ofw/libofw/openfirm.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 10:45:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B279516A41F; Thu, 20 Oct 2005 10:45:33 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DF4B43D6A; Thu, 20 Oct 2005 10:45:33 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KAjXOL082107; Thu, 20 Oct 2005 10:45:33 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KAjXQx082106; Thu, 20 Oct 2005 10:45:33 GMT (envelope-from ru) Message-Id: <200510201045.j9KAjXQx082106@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 10:45:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: FSF Cc: Subject: cvs commit: src/contrib/groff - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 10:45:34 -0000 ru 2005-10-20 10:45:32 UTC FreeBSD src repository src/contrib/groff - Imported sources Update of /home/ncvs/src/contrib/groff In directory repoman.freebsd.org:/tmp/cvs-serv82085 Log Message: Virgin import of FSF groff v1.19.2 Status: Vendor Tag: FSF Release Tags: v1_19_2 U src/contrib/groff/Makefile U src/contrib/groff/aclocal.m4 U src/contrib/groff/BUG-REPORT U src/contrib/groff/ChangeLog N src/contrib/groff/ChangeLog.115 N src/contrib/groff/ChangeLog.116 N src/contrib/groff/ChangeLog.117 N src/contrib/groff/ChangeLog.118 U src/contrib/groff/configure U src/contrib/groff/configure.ac U src/contrib/groff/COPYING U src/contrib/groff/FDL U src/contrib/groff/gendef.sh U src/contrib/groff/INSTALL U src/contrib/groff/INSTALL.gen U src/contrib/groff/install-sh N src/contrib/groff/LICENSE U src/contrib/groff/Makefile.ccpg U src/contrib/groff/Makefile.comm U src/contrib/groff/Makefile.cpg U src/contrib/groff/Makefile.dev U src/contrib/groff/Makefile.in U src/contrib/groff/MANIFEST U src/contrib/groff/Makefile.init U src/contrib/groff/Makefile.lib U src/contrib/groff/Makefile.man U src/contrib/groff/Makefile.sub U src/contrib/groff/mdate.sh U src/contrib/groff/mkinstalldirs U src/contrib/groff/MORE.STUFF U src/contrib/groff/NEWS U src/contrib/groff/PROBLEMS U src/contrib/groff/PROJECTS U src/contrib/groff/README N src/contrib/groff/README.MinGW U src/contrib/groff/REVISION U src/contrib/groff/stamp-h.in N src/contrib/groff/test-groff.in U src/contrib/groff/TODO U src/contrib/groff/VERSION U src/contrib/groff/src/include/assert.h U src/contrib/groff/src/include/cmap.h U src/contrib/groff/src/include/color.h U src/contrib/groff/src/include/config.hin U src/contrib/groff/src/include/cset.h U src/contrib/groff/src/include/device.h U src/contrib/groff/src/include/driver.h N src/contrib/groff/src/include/DviChar.h U src/contrib/groff/src/include/errarg.h U src/contrib/groff/src/include/error.h U src/contrib/groff/src/include/font.h U src/contrib/groff/src/include/geometry.h C src/contrib/groff/src/include/getopt.h N src/contrib/groff/src/include/getopt_int.h N src/contrib/groff/src/include/gettext.h U src/contrib/groff/src/include/htmlhint.h U src/contrib/groff/src/include/html-strings.h U src/contrib/groff/src/include/index.h U src/contrib/groff/src/include/lib.h U src/contrib/groff/src/include/macropath.h U src/contrib/groff/src/include/Makefile.sub U src/contrib/groff/src/include/nonposix.h U src/contrib/groff/src/include/paper.h U src/contrib/groff/src/include/posix.h U src/contrib/groff/src/include/printer.h U src/contrib/groff/src/include/ptable.h U src/contrib/groff/src/include/refid.h N src/contrib/groff/src/include/relocate.h U src/contrib/groff/src/include/search.h U src/contrib/groff/src/include/searchpath.h U src/contrib/groff/src/include/stringclass.h N src/contrib/groff/src/include/symbol.h N src/contrib/groff/src/include/unicode.h N src/contrib/groff/src/include/XFontName.h U src/contrib/groff/src/libs/libgroff/assert.cpp U src/contrib/groff/src/libs/libgroff/change_lf.cpp C src/contrib/groff/src/libs/libgroff/cmap.cpp U src/contrib/groff/src/libs/libgroff/color.cpp C src/contrib/groff/src/libs/libgroff/cset.cpp U src/contrib/groff/src/libs/libgroff/device.cpp U src/contrib/groff/src/libs/libgroff/errarg.cpp U src/contrib/groff/src/libs/libgroff/error.cpp U src/contrib/groff/src/libs/libgroff/fatal.cpp U src/contrib/groff/src/libs/libgroff/filename.cpp U src/contrib/groff/src/libs/libgroff/fmod.c U src/contrib/groff/src/libs/libgroff/font.cpp U src/contrib/groff/src/libs/libgroff/fontfile.cpp U src/contrib/groff/src/libs/libgroff/geometry.cpp U src/contrib/groff/src/libs/libgroff/getcwd.c C src/contrib/groff/src/libs/libgroff/getopt1.c C src/contrib/groff/src/libs/libgroff/getopt.c N src/contrib/groff/src/libs/libgroff/glyphuni.cpp U src/contrib/groff/src/libs/libgroff/htmlhint.cpp N src/contrib/groff/src/libs/libgroff/hypot.cpp U src/contrib/groff/src/libs/libgroff/iftoa.c C src/contrib/groff/src/libs/libgroff/invalid.cpp U src/contrib/groff/src/libs/libgroff/itoa.c U src/contrib/groff/src/libs/libgroff/lf.cpp U src/contrib/groff/src/libs/libgroff/lineno.cpp U src/contrib/groff/src/libs/libgroff/macropath.cpp U src/contrib/groff/src/libs/libgroff/Makefile.sub U src/contrib/groff/src/libs/libgroff/matherr.c U src/contrib/groff/src/libs/libgroff/maxfilename.cpp N src/contrib/groff/src/libs/libgroff/maxpathname.cpp U src/contrib/groff/src/libs/libgroff/mksdir.cpp U src/contrib/groff/src/libs/libgroff/mkstemp.cpp U src/contrib/groff/src/libs/libgroff/nametoindex.cpp U src/contrib/groff/src/libs/libgroff/new.cpp U src/contrib/groff/src/libs/libgroff/paper.cpp U src/contrib/groff/src/libs/libgroff/prime.cpp N src/contrib/groff/src/libs/libgroff/progname.c U src/contrib/groff/src/libs/libgroff/ptable.cpp U src/contrib/groff/src/libs/libgroff/putenv.c N src/contrib/groff/src/libs/libgroff/quotearg.c N src/contrib/groff/src/libs/libgroff/relocate.cpp U src/contrib/groff/src/libs/libgroff/searchpath.cpp N src/contrib/groff/src/libs/libgroff/spawnvp.c U src/contrib/groff/src/libs/libgroff/strcasecmp.c U src/contrib/groff/src/libs/libgroff/strerror.c U src/contrib/groff/src/libs/libgroff/string.cpp U src/contrib/groff/src/libs/libgroff/strncasecmp.c U src/contrib/groff/src/libs/libgroff/strsave.cpp U src/contrib/groff/src/libs/libgroff/strtol.c N src/contrib/groff/src/libs/libgroff/symbol.cpp U src/contrib/groff/src/libs/libgroff/tmpfile.cpp U src/contrib/groff/src/libs/libgroff/tmpname.cpp N src/contrib/groff/src/libs/libgroff/unicode.cpp N src/contrib/groff/src/libs/libgroff/uniglyph.cpp N src/contrib/groff/src/libs/libgroff/uniuni.cpp U src/contrib/groff/src/libs/libdriver/input.cpp U src/contrib/groff/src/libs/libdriver/Makefile.sub U src/contrib/groff/src/libs/libdriver/printer.cpp U src/contrib/groff/src/libs/libbib/common.cpp U src/contrib/groff/src/libs/libbib/index.cpp U src/contrib/groff/src/libs/libbib/linear.cpp U src/contrib/groff/src/libs/libbib/Makefile.sub U src/contrib/groff/src/libs/libbib/map.c U src/contrib/groff/src/libs/libbib/search.cpp N src/contrib/groff/src/libs/libxutil/DviChar.c N src/contrib/groff/src/libs/libxutil/Makefile.sub N src/contrib/groff/src/libs/libxutil/XFontName.c N src/contrib/groff/src/libs/libxutil/xmalloc.c U src/contrib/groff/src/roff/groff/groff.cpp C src/contrib/groff/src/roff/groff/groff.man U src/contrib/groff/src/roff/groff/Makefile.sub U src/contrib/groff/src/roff/groff/pipeline.c U src/contrib/groff/src/roff/groff/pipeline.h U src/contrib/groff/src/roff/troff/charinfo.h U src/contrib/groff/src/roff/troff/column.cpp U src/contrib/groff/src/roff/troff/dictionary.cpp U src/contrib/groff/src/roff/troff/dictionary.h U src/contrib/groff/src/roff/troff/div.cpp U src/contrib/groff/src/roff/troff/div.h U src/contrib/groff/src/roff/troff/env.cpp U src/contrib/groff/src/roff/troff/env.h U src/contrib/groff/src/roff/troff/hvunits.h U src/contrib/groff/src/roff/troff/input.cpp U src/contrib/groff/src/roff/troff/input.h U src/contrib/groff/src/roff/troff/Makefile.sub N src/contrib/groff/src/roff/troff/mtsm.cpp N src/contrib/groff/src/roff/troff/mtsm.h U src/contrib/groff/src/roff/troff/node.cpp U src/contrib/groff/src/roff/troff/node.h U src/contrib/groff/src/roff/troff/number.cpp U src/contrib/groff/src/roff/troff/reg.cpp U src/contrib/groff/src/roff/troff/reg.h U src/contrib/groff/src/roff/troff/request.h U src/contrib/groff/src/roff/troff/TODO U src/contrib/groff/src/roff/troff/token.h U src/contrib/groff/src/roff/troff/troff.h U src/contrib/groff/src/roff/troff/troff.man U src/contrib/groff/src/roff/grog/grog.man U src/contrib/groff/src/roff/grog/grog.pl U src/contrib/groff/src/roff/grog/grog.sh U src/contrib/groff/src/roff/grog/Makefile.sub U src/contrib/groff/src/roff/nroff/Makefile.sub C src/contrib/groff/src/roff/nroff/nroff.man C src/contrib/groff/src/roff/nroff/nroff.sh U src/contrib/groff/src/preproc/tbl/main.cpp U src/contrib/groff/src/preproc/tbl/Makefile.sub U src/contrib/groff/src/preproc/tbl/table.cpp U src/contrib/groff/src/preproc/tbl/table.h U src/contrib/groff/src/preproc/tbl/tbl.man U src/contrib/groff/src/preproc/pic/common.cpp U src/contrib/groff/src/preproc/pic/common.h U src/contrib/groff/src/preproc/pic/lex.cpp U src/contrib/groff/src/preproc/pic/main.cpp U src/contrib/groff/src/preproc/pic/Makefile.sub U src/contrib/groff/src/preproc/pic/object.cpp U src/contrib/groff/src/preproc/pic/object.h U src/contrib/groff/src/preproc/pic/output.h U src/contrib/groff/src/preproc/pic/pic.h U src/contrib/groff/src/preproc/pic/pic.man U src/contrib/groff/src/preproc/pic/pic.y U src/contrib/groff/src/preproc/pic/position.h U src/contrib/groff/src/preproc/pic/tex.cpp U src/contrib/groff/src/preproc/pic/text.h U src/contrib/groff/src/preproc/pic/TODO U src/contrib/groff/src/preproc/pic/troff.cpp C src/contrib/groff/src/preproc/pic/pic.cpp U src/contrib/groff/src/preproc/pic/pic_tab.h U src/contrib/groff/src/preproc/eqn/box.cpp U src/contrib/groff/src/preproc/eqn/box.h U src/contrib/groff/src/preproc/eqn/delim.cpp U src/contrib/groff/src/preproc/eqn/eqn.h U src/contrib/groff/src/preproc/eqn/eqn.man U src/contrib/groff/src/preproc/eqn/eqn.y U src/contrib/groff/src/preproc/eqn/lex.cpp U src/contrib/groff/src/preproc/eqn/limit.cpp U src/contrib/groff/src/preproc/eqn/list.cpp U src/contrib/groff/src/preproc/eqn/main.cpp U src/contrib/groff/src/preproc/eqn/Makefile.sub U src/contrib/groff/src/preproc/eqn/mark.cpp U src/contrib/groff/src/preproc/eqn/neqn.man C src/contrib/groff/src/preproc/eqn/neqn.sh U src/contrib/groff/src/preproc/eqn/other.cpp U src/contrib/groff/src/preproc/eqn/over.cpp U src/contrib/groff/src/preproc/eqn/pbox.h U src/contrib/groff/src/preproc/eqn/pile.cpp U src/contrib/groff/src/preproc/eqn/script.cpp U src/contrib/groff/src/preproc/eqn/special.cpp U src/contrib/groff/src/preproc/eqn/sqrt.cpp U src/contrib/groff/src/preproc/eqn/text.cpp U src/contrib/groff/src/preproc/eqn/TODO C src/contrib/groff/src/preproc/eqn/eqn.cpp U src/contrib/groff/src/preproc/eqn/eqn_tab.h U src/contrib/groff/src/preproc/grn/gprint.h U src/contrib/groff/src/preproc/grn/grn.man U src/contrib/groff/src/preproc/grn/hdb.cpp U src/contrib/groff/src/preproc/grn/hgraph.cpp U src/contrib/groff/src/preproc/grn/hpoint.cpp U src/contrib/groff/src/preproc/grn/main.cpp U src/contrib/groff/src/preproc/grn/Makefile.sub U src/contrib/groff/src/preproc/grn/README U src/contrib/groff/src/preproc/refer/command.cpp U src/contrib/groff/src/preproc/refer/command.h U src/contrib/groff/src/preproc/refer/label.y U src/contrib/groff/src/preproc/refer/Makefile.sub U src/contrib/groff/src/preproc/refer/ref.cpp U src/contrib/groff/src/preproc/refer/refer.cpp U src/contrib/groff/src/preproc/refer/refer.h U src/contrib/groff/src/preproc/refer/refer.man U src/contrib/groff/src/preproc/refer/ref.h U src/contrib/groff/src/preproc/refer/TODO U src/contrib/groff/src/preproc/refer/token.cpp U src/contrib/groff/src/preproc/refer/token.h C src/contrib/groff/src/preproc/refer/label.cpp U src/contrib/groff/src/preproc/soelim/Makefile.sub U src/contrib/groff/src/preproc/soelim/soelim.cpp U src/contrib/groff/src/preproc/soelim/soelim.man U src/contrib/groff/src/preproc/soelim/TODO U src/contrib/groff/src/preproc/html/Makefile.sub U src/contrib/groff/src/preproc/html/pre-html.cpp U src/contrib/groff/src/preproc/html/pre-html.h U src/contrib/groff/src/preproc/html/pushback.cpp U src/contrib/groff/src/preproc/html/pushback.h U src/contrib/groff/src/devices/grops/grops.man U src/contrib/groff/src/devices/grops/Makefile.sub U src/contrib/groff/src/devices/grops/ps.cpp U src/contrib/groff/src/devices/grops/psfig.diff U src/contrib/groff/src/devices/grops/ps.h U src/contrib/groff/src/devices/grops/psrm.cpp U src/contrib/groff/src/devices/grops/TODO C src/contrib/groff/src/devices/grotty/grotty.man U src/contrib/groff/src/devices/grotty/Makefile.sub U src/contrib/groff/src/devices/grotty/TODO U src/contrib/groff/src/devices/grotty/tty.cpp U src/contrib/groff/src/devices/grodvi/dvi.cpp U src/contrib/groff/src/devices/grodvi/grodvi.man U src/contrib/groff/src/devices/grodvi/Makefile.sub U src/contrib/groff/src/devices/grolj4/grolj4.man U src/contrib/groff/src/devices/grolj4/lj4.cpp N src/contrib/groff/src/devices/grolj4/lj4_font.man U src/contrib/groff/src/devices/grolj4/Makefile.sub U src/contrib/groff/src/devices/grohtml/grohtml.man U src/contrib/groff/src/devices/grohtml/html.h U src/contrib/groff/src/devices/grohtml/html-table.cpp U src/contrib/groff/src/devices/grohtml/html-table.h U src/contrib/groff/src/devices/grohtml/html-text.cpp U src/contrib/groff/src/devices/grohtml/html-text.h U src/contrib/groff/src/devices/grohtml/Makefile.sub U src/contrib/groff/src/devices/grohtml/output.cpp U src/contrib/groff/src/devices/grohtml/post-html.cpp U src/contrib/groff/src/devices/grolbp/charset.h U src/contrib/groff/src/devices/grolbp/grolbp.man U src/contrib/groff/src/devices/grolbp/lbp.cpp U src/contrib/groff/src/devices/grolbp/lbp.h U src/contrib/groff/src/devices/grolbp/Makefile.sub N src/contrib/groff/src/devices/xditview/ad2c N src/contrib/groff/src/devices/xditview/ChangeLog N src/contrib/groff/src/devices/xditview/DESC.in N src/contrib/groff/src/devices/xditview/device.c N src/contrib/groff/src/devices/xditview/device.h N src/contrib/groff/src/devices/xditview/draw.c N src/contrib/groff/src/devices/xditview/Dvi.c N src/contrib/groff/src/devices/xditview/Dvi.h N src/contrib/groff/src/devices/xditview/DviP.h N src/contrib/groff/src/devices/xditview/font.c N src/contrib/groff/src/devices/xditview/FontMap N src/contrib/groff/src/devices/xditview/gray1.bm N src/contrib/groff/src/devices/xditview/gray2.bm N src/contrib/groff/src/devices/xditview/gray3.bm N src/contrib/groff/src/devices/xditview/gray4.bm N src/contrib/groff/src/devices/xditview/gray5.bm N src/contrib/groff/src/devices/xditview/gray6.bm N src/contrib/groff/src/devices/xditview/gray7.bm N src/contrib/groff/src/devices/xditview/gray8.bm N src/contrib/groff/src/devices/xditview/GXditview.ad N src/contrib/groff/src/devices/xditview/gxditview.man N src/contrib/groff/src/devices/xditview/lex.c N src/contrib/groff/src/devices/xditview/Makefile.sub N src/contrib/groff/src/devices/xditview/Menu.h N src/contrib/groff/src/devices/xditview/page.c N src/contrib/groff/src/devices/xditview/parse.c N src/contrib/groff/src/devices/xditview/README N src/contrib/groff/src/devices/xditview/TODO N src/contrib/groff/src/devices/xditview/xdit.bm N src/contrib/groff/src/devices/xditview/xdit_mask.bm N src/contrib/groff/src/devices/xditview/xditview.c U src/contrib/groff/src/utils/tfmtodit/Makefile.sub U src/contrib/groff/src/utils/tfmtodit/tfmtodit.cpp U src/contrib/groff/src/utils/tfmtodit/tfmtodit.man U src/contrib/groff/src/utils/hpftodit/hpftodit.cpp U src/contrib/groff/src/utils/hpftodit/hpftodit.man N src/contrib/groff/src/utils/hpftodit/hpuni.cpp U src/contrib/groff/src/utils/hpftodit/Makefile.sub U src/contrib/groff/src/utils/lookbib/lookbib.cpp U src/contrib/groff/src/utils/lookbib/lookbib.man U src/contrib/groff/src/utils/lookbib/Makefile.sub U src/contrib/groff/src/utils/indxbib/eign U src/contrib/groff/src/utils/indxbib/indxbib.cpp U src/contrib/groff/src/utils/indxbib/indxbib.man U src/contrib/groff/src/utils/indxbib/Makefile.sub U src/contrib/groff/src/utils/indxbib/signal.c U src/contrib/groff/src/utils/lkbib/lkbib.cpp U src/contrib/groff/src/utils/lkbib/lkbib.man U src/contrib/groff/src/utils/lkbib/Makefile.sub U src/contrib/groff/src/utils/addftinfo/addftinfo.cpp U src/contrib/groff/src/utils/addftinfo/addftinfo.man U src/contrib/groff/src/utils/addftinfo/guess.cpp U src/contrib/groff/src/utils/addftinfo/guess.h U src/contrib/groff/src/utils/addftinfo/Makefile.sub U src/contrib/groff/src/utils/pfbtops/Makefile.sub U src/contrib/groff/src/utils/pfbtops/pfbtops.c U src/contrib/groff/src/utils/pfbtops/pfbtops.man N src/contrib/groff/src/utils/xtotroff/Makefile.in N src/contrib/groff/src/utils/xtotroff/Makefile.sub N src/contrib/groff/src/utils/xtotroff/xtotroff.c N src/contrib/groff/src/utils/xtotroff/xtotroff.man U src/contrib/groff/src/utils/afmtodit/afmtodit.man U src/contrib/groff/src/utils/afmtodit/afmtodit.pl U src/contrib/groff/src/utils/afmtodit/Makefile.sub U src/contrib/groff/font/devps/AB U src/contrib/groff/font/devps/ABI U src/contrib/groff/font/devps/AI U src/contrib/groff/font/devps/AR U src/contrib/groff/font/devps/BMB U src/contrib/groff/font/devps/BMBI U src/contrib/groff/font/devps/BMI U src/contrib/groff/font/devps/BMR U src/contrib/groff/font/devps/CB U src/contrib/groff/font/devps/CBI U src/contrib/groff/font/devps/CI U src/contrib/groff/font/devps/CR U src/contrib/groff/font/devps/DESC.in U src/contrib/groff/font/devps/download U src/contrib/groff/font/devps/EURO U src/contrib/groff/font/devps/freeeuro.afm U src/contrib/groff/font/devps/freeeuro.pfa U src/contrib/groff/font/devps/HB U src/contrib/groff/font/devps/HBI U src/contrib/groff/font/devps/HI U src/contrib/groff/font/devps/HNB U src/contrib/groff/font/devps/HNBI U src/contrib/groff/font/devps/HNI U src/contrib/groff/font/devps/HNR U src/contrib/groff/font/devps/HR U src/contrib/groff/font/devps/Makefile.sub U src/contrib/groff/font/devps/NB U src/contrib/groff/font/devps/NBI U src/contrib/groff/font/devps/NI U src/contrib/groff/font/devps/NR U src/contrib/groff/font/devps/PB U src/contrib/groff/font/devps/PBI U src/contrib/groff/font/devps/PI U src/contrib/groff/font/devps/PR U src/contrib/groff/font/devps/prologue.ps U src/contrib/groff/font/devps/psstrip.sed U src/contrib/groff/font/devps/S U src/contrib/groff/font/devps/SS U src/contrib/groff/font/devps/symbol.afm U src/contrib/groff/font/devps/symbolmap U src/contrib/groff/font/devps/symbolsl.ps U src/contrib/groff/font/devps/TB U src/contrib/groff/font/devps/TBI U src/contrib/groff/font/devps/text.enc U src/contrib/groff/font/devps/TI U src/contrib/groff/font/devps/TR U src/contrib/groff/font/devps/zapfdr.afm U src/contrib/groff/font/devps/zapfdr.ps U src/contrib/groff/font/devps/ZCMI U src/contrib/groff/font/devps/ZD U src/contrib/groff/font/devps/ZDR U src/contrib/groff/font/devps/generate/afmname U src/contrib/groff/font/devps/generate/dingbats.map U src/contrib/groff/font/devps/generate/dingbats.rmap U src/contrib/groff/font/devps/generate/freeeuro.sfd U src/contrib/groff/font/devps/generate/lgreekmap U src/contrib/groff/font/devps/generate/Makefile U src/contrib/groff/font/devps/generate/sfdtopfa.pe U src/contrib/groff/font/devps/generate/symbolchars U src/contrib/groff/font/devps/generate/symbol.sed U src/contrib/groff/font/devps/generate/symbolsl.afm U src/contrib/groff/font/devps/generate/textmap U src/contrib/groff/font/devdvi/CW U src/contrib/groff/font/devdvi/CWEC U src/contrib/groff/font/devdvi/CWI U src/contrib/groff/font/devdvi/CWIEC U src/contrib/groff/font/devdvi/CWITC U src/contrib/groff/font/devdvi/CWTC U src/contrib/groff/font/devdvi/DESC.in U src/contrib/groff/font/devdvi/EX U src/contrib/groff/font/devdvi/HB U src/contrib/groff/font/devdvi/HBEC U src/contrib/groff/font/devdvi/HBI U src/contrib/groff/font/devdvi/HBIEC U src/contrib/groff/font/devdvi/HBITC U src/contrib/groff/font/devdvi/HBTC U src/contrib/groff/font/devdvi/HI U src/contrib/groff/font/devdvi/HIEC U src/contrib/groff/font/devdvi/HITC U src/contrib/groff/font/devdvi/HR U src/contrib/groff/font/devdvi/HREC U src/contrib/groff/font/devdvi/HRTC U src/contrib/groff/font/devdvi/Makefile.sub U src/contrib/groff/font/devdvi/MI U src/contrib/groff/font/devdvi/S U src/contrib/groff/font/devdvi/SA U src/contrib/groff/font/devdvi/SB U src/contrib/groff/font/devdvi/SC U src/contrib/groff/font/devdvi/TB U src/contrib/groff/font/devdvi/TBEC U src/contrib/groff/font/devdvi/TBI U src/contrib/groff/font/devdvi/TBIEC U src/contrib/groff/font/devdvi/TBITC U src/contrib/groff/font/devdvi/TBTC U src/contrib/groff/font/devdvi/TI U src/contrib/groff/font/devdvi/TIEC U src/contrib/groff/font/devdvi/TITC U src/contrib/groff/font/devdvi/TR U src/contrib/groff/font/devdvi/TREC U src/contrib/groff/font/devdvi/TRTC U src/contrib/groff/font/devdvi/generate/CompileFonts U src/contrib/groff/font/devdvi/generate/ec.map U src/contrib/groff/font/devdvi/generate/Makefile U src/contrib/groff/font/devdvi/generate/msam.map U src/contrib/groff/font/devdvi/generate/msbm.map U src/contrib/groff/font/devdvi/generate/tc.map U src/contrib/groff/font/devdvi/generate/texb.map U src/contrib/groff/font/devdvi/generate/texex.map U src/contrib/groff/font/devdvi/generate/texi.map U src/contrib/groff/font/devdvi/generate/texmi.map U src/contrib/groff/font/devdvi/generate/texr.map U src/contrib/groff/font/devdvi/generate/texsy.map U src/contrib/groff/font/devdvi/generate/textex.map U src/contrib/groff/font/devdvi/generate/textt.map U src/contrib/groff/font/devhtml/DESC.proto U src/contrib/groff/font/devhtml/Makefile.sub U src/contrib/groff/font/devhtml/R.proto U src/contrib/groff/font/devX75/CB U src/contrib/groff/font/devX75/CBI U src/contrib/groff/font/devX75/CI U src/contrib/groff/font/devX75/CR U src/contrib/groff/font/devX75/DESC U src/contrib/groff/font/devX75/HB U src/contrib/groff/font/devX75/HBI U src/contrib/groff/font/devX75/HI U src/contrib/groff/font/devX75/HR U src/contrib/groff/font/devX75/Makefile.sub U src/contrib/groff/font/devX75/NB U src/contrib/groff/font/devX75/NBI U src/contrib/groff/font/devX75/NI U src/contrib/groff/font/devX75/NR U src/contrib/groff/font/devX75/S U src/contrib/groff/font/devX75/TB U src/contrib/groff/font/devX75/TBI U src/contrib/groff/font/devX75/TI U src/contrib/groff/font/devX75/TR U src/contrib/groff/font/devX75-12/CB U src/contrib/groff/font/devX75-12/CBI U src/contrib/groff/font/devX75-12/CI U src/contrib/groff/font/devX75-12/CR U src/contrib/groff/font/devX75-12/DESC U src/contrib/groff/font/devX75-12/HB U src/contrib/groff/font/devX75-12/HBI U src/contrib/groff/font/devX75-12/HI U src/contrib/groff/font/devX75-12/HR U src/contrib/groff/font/devX75-12/Makefile.sub U src/contrib/groff/font/devX75-12/NB U src/contrib/groff/font/devX75-12/NBI U src/contrib/groff/font/devX75-12/NI U src/contrib/groff/font/devX75-12/NR U src/contrib/groff/font/devX75-12/S U src/contrib/groff/font/devX75-12/TB U src/contrib/groff/font/devX75-12/TBI U src/contrib/groff/font/devX75-12/TI U src/contrib/groff/font/devX75-12/TR U src/contrib/groff/font/devX100/CB U src/contrib/groff/font/devX100/CBI U src/contrib/groff/font/devX100/CI U src/contrib/groff/font/devX100/CR U src/contrib/groff/font/devX100/DESC U src/contrib/groff/font/devX100/HB U src/contrib/groff/font/devX100/HBI U src/contrib/groff/font/devX100/HI U src/contrib/groff/font/devX100/HR U src/contrib/groff/font/devX100/Makefile.sub U src/contrib/groff/font/devX100/NB U src/contrib/groff/font/devX100/NBI U src/contrib/groff/font/devX100/NI U src/contrib/groff/font/devX100/NR U src/contrib/groff/font/devX100/S U src/contrib/groff/font/devX100/TB U src/contrib/groff/font/devX100/TBI U src/contrib/groff/font/devX100/TI U src/contrib/groff/font/devX100/TR U src/contrib/groff/font/devX100-12/CB U src/contrib/groff/font/devX100-12/CBI U src/contrib/groff/font/devX100-12/CI U src/contrib/groff/font/devX100-12/CR U src/contrib/groff/font/devX100-12/DESC U src/contrib/groff/font/devX100-12/HB U src/contrib/groff/font/devX100-12/HBI U src/contrib/groff/font/devX100-12/HI U src/contrib/groff/font/devX100-12/HR U src/contrib/groff/font/devX100-12/Makefile.sub U src/contrib/groff/font/devX100-12/NB U src/contrib/groff/font/devX100-12/NBI U src/contrib/groff/font/devX100-12/NI U src/contrib/groff/font/devX100-12/NR U src/contrib/groff/font/devX100-12/S U src/contrib/groff/font/devX100-12/TB U src/contrib/groff/font/devX100-12/TBI U src/contrib/groff/font/devX100-12/TI U src/contrib/groff/font/devX100-12/TR N src/contrib/groff/font/devlj4/AB N src/contrib/groff/font/devlj4/ABI N src/contrib/groff/font/devlj4/AI U src/contrib/groff/font/devlj4/ALBB U src/contrib/groff/font/devlj4/ALBR U src/contrib/groff/font/devlj4/AOB U src/contrib/groff/font/devlj4/AOI U src/contrib/groff/font/devlj4/AOR N src/contrib/groff/font/devlj4/AR U src/contrib/groff/font/devlj4/CB U src/contrib/groff/font/devlj4/CBI U src/contrib/groff/font/devlj4/CI U src/contrib/groff/font/devlj4/CLARENDON U src/contrib/groff/font/devlj4/CORONET U src/contrib/groff/font/devlj4/CR U src/contrib/groff/font/devlj4/DESC.in U src/contrib/groff/font/devlj4/GB U src/contrib/groff/font/devlj4/GBI U src/contrib/groff/font/devlj4/GI U src/contrib/groff/font/devlj4/GR U src/contrib/groff/font/devlj4/LGB U src/contrib/groff/font/devlj4/LGI U src/contrib/groff/font/devlj4/LGR U src/contrib/groff/font/devlj4/Makefile.sub U src/contrib/groff/font/devlj4/MARIGOLD U src/contrib/groff/font/devlj4/OB U src/contrib/groff/font/devlj4/OBI U src/contrib/groff/font/devlj4/OI U src/contrib/groff/font/devlj4/OR U src/contrib/groff/font/devlj4/S N src/contrib/groff/font/devlj4/SYMBOL U src/contrib/groff/font/devlj4/TB U src/contrib/groff/font/devlj4/TBI U src/contrib/groff/font/devlj4/TI N src/contrib/groff/font/devlj4/TNRB N src/contrib/groff/font/devlj4/TNRBI N src/contrib/groff/font/devlj4/TNRI N src/contrib/groff/font/devlj4/TNRR U src/contrib/groff/font/devlj4/TR U src/contrib/groff/font/devlj4/UB U src/contrib/groff/font/devlj4/UBI U src/contrib/groff/font/devlj4/UCB U src/contrib/groff/font/devlj4/UCBI U src/contrib/groff/font/devlj4/UCI U src/contrib/groff/font/devlj4/UCR U src/contrib/groff/font/devlj4/UI U src/contrib/groff/font/devlj4/UR N src/contrib/groff/font/devlj4/WINGDINGS U src/contrib/groff/font/devlj4/generate/Makefile N src/contrib/groff/font/devlj4/generate/special.awk U src/contrib/groff/font/devlj4/generate/special.map N src/contrib/groff/font/devlj4/generate/symbol.map U src/contrib/groff/font/devlj4/generate/text.map N src/contrib/groff/font/devlj4/generate/wingdings.map U src/contrib/groff/font/devlbp/CB U src/contrib/groff/font/devlbp/CI U src/contrib/groff/font/devlbp/CR U src/contrib/groff/font/devlbp/DESC.in U src/contrib/groff/font/devlbp/EB U src/contrib/groff/font/devlbp/EI U src/contrib/groff/font/devlbp/ER U src/contrib/groff/font/devlbp/HB U src/contrib/groff/font/devlbp/HBI U src/contrib/groff/font/devlbp/HI U src/contrib/groff/font/devlbp/HNB U src/contrib/groff/font/devlbp/HNBI U src/contrib/groff/font/devlbp/HNI U src/contrib/groff/font/devlbp/HNR U src/contrib/groff/font/devlbp/HR U src/contrib/groff/font/devlbp/Makefile.sub U src/contrib/groff/font/devlbp/TB U src/contrib/groff/font/devlbp/TBI U src/contrib/groff/font/devlbp/TI U src/contrib/groff/font/devlbp/TR U src/contrib/groff/font/devascii/DESC.proto U src/contrib/groff/font/devascii/Makefile.sub U src/contrib/groff/font/devascii/R.proto U src/contrib/groff/font/devlatin1/DESC.proto U src/contrib/groff/font/devlatin1/Makefile.sub U src/contrib/groff/font/devlatin1/R.proto U src/contrib/groff/font/devutf8/DESC.proto U src/contrib/groff/font/devutf8/Makefile.sub U src/contrib/groff/font/devutf8/NOTES U src/contrib/groff/font/devutf8/R.proto U src/contrib/groff/font/devcp1047/DESC.proto U src/contrib/groff/font/devcp1047/Makefile.sub U src/contrib/groff/font/devcp1047/R.proto U src/contrib/groff/man/ditroff.man U src/contrib/groff/man/groff_char.man U src/contrib/groff/man/groff_diff.man U src/contrib/groff/man/groff_font.man U src/contrib/groff/man/groff.man C src/contrib/groff/man/groff_out.man U src/contrib/groff/man/groff_tmac.man U src/contrib/groff/man/Makefile.sub U src/contrib/groff/man/roff.man U src/contrib/groff/tmac/a4.tmac U src/contrib/groff/tmac/andoc.tmac U src/contrib/groff/tmac/an-old.tmac U src/contrib/groff/tmac/an.tmac U src/contrib/groff/tmac/composite.tmac U src/contrib/groff/tmac/cp1047.tmac N src/contrib/groff/tmac/devtag.tmac C src/contrib/groff/tmac/doc-common C src/contrib/groff/tmac/doc-ditroff C src/contrib/groff/tmac/doc-nroff U src/contrib/groff/tmac/doc-old.tmac C src/contrib/groff/tmac/doc-syms U src/contrib/groff/tmac/doc.tmac U src/contrib/groff/tmac/dvi.tmac U src/contrib/groff/tmac/ec.tmac U src/contrib/groff/tmac/eqnrc U src/contrib/groff/tmac/e.tmac U src/contrib/groff/tmac/europs.tmac U src/contrib/groff/tmac/fixmacros.sed U src/contrib/groff/tmac/groff_man.man U src/contrib/groff/tmac/groff_mdoc.man U src/contrib/groff/tmac/groff_me.man U src/contrib/groff/tmac/groff_ms.man U src/contrib/groff/tmac/groff_trace.man U src/contrib/groff/tmac/groff_www.man U src/contrib/groff/tmac/html-end.tmac U src/contrib/groff/tmac/html.tmac U src/contrib/groff/tmac/hyphenex.pl U src/contrib/groff/tmac/hyphenex.us U src/contrib/groff/tmac/hyphen.us U src/contrib/groff/tmac/latin1.tmac U src/contrib/groff/tmac/latin2.tmac N src/contrib/groff/tmac/latin5.tmac U src/contrib/groff/tmac/latin9.tmac U src/contrib/groff/tmac/lbp.tmac U src/contrib/groff/tmac/lj4.tmac U src/contrib/groff/tmac/Makefile.sub U src/contrib/groff/tmac/mandoc.tmac U src/contrib/groff/tmac/man.local U src/contrib/groff/tmac/man.tmac U src/contrib/groff/tmac/man.ultrix U src/contrib/groff/tmac/mdoc.local U src/contrib/groff/tmac/mdoc.tmac U src/contrib/groff/tmac/me.tmac U src/contrib/groff/tmac/ms.tmac U src/contrib/groff/tmac/papersize.tmac U src/contrib/groff/tmac/pic.tmac U src/contrib/groff/tmac/psatk.tmac U src/contrib/groff/tmac/psfig.tmac U src/contrib/groff/tmac/psold.tmac U src/contrib/groff/tmac/pspic.tmac U src/contrib/groff/tmac/ps.tmac U src/contrib/groff/tmac/README U src/contrib/groff/tmac/safer.tmac U src/contrib/groff/tmac/s.tmac U src/contrib/groff/tmac/strip.sed U src/contrib/groff/tmac/TODO U src/contrib/groff/tmac/trace.tmac C src/contrib/groff/tmac/troffrc U src/contrib/groff/tmac/troffrc-end C src/contrib/groff/tmac/tty-char.tmac C src/contrib/groff/tmac/tty.tmac N src/contrib/groff/tmac/unicode.tmac U src/contrib/groff/tmac/www.tmac U src/contrib/groff/tmac/Xps.tmac U src/contrib/groff/tmac/X.tmac U src/contrib/groff/doc/fdl.texi N src/contrib/groff/doc/fixinfo.sh U src/contrib/groff/doc/gnu.xpm U src/contrib/groff/doc/grnexmpl.g U src/contrib/groff/doc/grnexmpl.me N src/contrib/groff/doc/groff.css U src/contrib/groff/doc/groff.texinfo U src/contrib/groff/doc/Makefile.in U src/contrib/groff/doc/Makefile.sub U src/contrib/groff/doc/meintro.me U src/contrib/groff/doc/meref.me U src/contrib/groff/doc/pic.ms U src/contrib/groff/doc/texinfo.tex U src/contrib/groff/doc/webpage.ms U src/contrib/groff/doc/groff U src/contrib/groff/doc/groff-1 U src/contrib/groff/doc/groff-2 U src/contrib/groff/doc/groff-3 U src/contrib/groff/doc/gnu.eps U src/contrib/groff/doc/gnu.png U src/contrib/groff/contrib/mm/ChangeLog U src/contrib/groff/contrib/mm/groff_mm.man U src/contrib/groff/contrib/mm/groff_mmse.man U src/contrib/groff/contrib/mm/Makefile.sim U src/contrib/groff/contrib/mm/Makefile.sub U src/contrib/groff/contrib/mm/mmroff.man U src/contrib/groff/contrib/mm/mmroff.pl U src/contrib/groff/contrib/mm/mmse.tmac U src/contrib/groff/contrib/mm/mm.tmac U src/contrib/groff/contrib/mm/mse.tmac U src/contrib/groff/contrib/mm/m.tmac U src/contrib/groff/contrib/mm/NOTES U src/contrib/groff/contrib/mm/README U src/contrib/groff/contrib/mm/examples/APP U src/contrib/groff/contrib/mm/examples/B1B2 U src/contrib/groff/contrib/mm/examples/COVER U src/contrib/groff/contrib/mm/examples/IND U src/contrib/groff/contrib/mm/examples/LT U src/contrib/groff/contrib/mm/examples/LT.se U src/contrib/groff/contrib/mm/examples/ML U src/contrib/groff/contrib/mm/examples/MOVE U src/contrib/groff/contrib/mm/examples/MUL U src/contrib/groff/contrib/mm/examples/NCOL U src/contrib/groff/contrib/mm/examples/ND U src/contrib/groff/contrib/mm/examples/README U src/contrib/groff/contrib/mm/examples/References U src/contrib/groff/contrib/mm/examples/SETR U src/contrib/groff/contrib/mm/mm/0.MT U src/contrib/groff/contrib/mm/mm/4.MT U src/contrib/groff/contrib/mm/mm/5.MT U src/contrib/groff/contrib/mm/mm/ms.cov U src/contrib/groff/contrib/mm/mm/se_ms.cov U src/contrib/groff/contrib/pic2graph/Makefile.sub U src/contrib/groff/contrib/pic2graph/pic2graph.man U src/contrib/groff/contrib/pic2graph/pic2graph.sh U src/contrib/groff/contrib/eqn2graph/eqn2graph.man U src/contrib/groff/contrib/eqn2graph/eqn2graph.sh U src/contrib/groff/contrib/eqn2graph/Makefile.sub N src/contrib/groff/contrib/grap2graph/grap2graph.man N src/contrib/groff/contrib/grap2graph/grap2graph.sh N src/contrib/groff/contrib/grap2graph/Makefile.sub U src/contrib/groff/contrib/groffer/ChangeLog N src/contrib/groff/contrib/groffer/groffer2.sh U src/contrib/groff/contrib/groffer/groffer.man U src/contrib/groff/contrib/groffer/groffer.sh U src/contrib/groff/contrib/groffer/Makefile.sub U src/contrib/groff/contrib/groffer/README N src/contrib/groff/contrib/groffer/README_SH U src/contrib/groff/contrib/groffer/TODO U src/contrib/groff/contrib/mom/BUGS U src/contrib/groff/contrib/mom/ChangeLog U src/contrib/groff/contrib/mom/copyright U src/contrib/groff/contrib/mom/groff_mom.man U src/contrib/groff/contrib/mom/Makefile.sub U src/contrib/groff/contrib/mom/mom.tmac U src/contrib/groff/contrib/mom/NEWS U src/contrib/groff/contrib/mom/om.tmac U src/contrib/groff/contrib/mom/TODO U src/contrib/groff/contrib/mom/examples/elvis_syntax N src/contrib/groff/contrib/mom/examples/elvis_syntax.new U src/contrib/groff/contrib/mom/examples/letter.mom U src/contrib/groff/contrib/mom/examples/penguin.ps N src/contrib/groff/contrib/mom/examples/README.txt N src/contrib/groff/contrib/mom/examples/sample_docs.mom N src/contrib/groff/contrib/mom/examples/typesetting.mom U src/contrib/groff/contrib/mom/momdoc/appendices.html N src/contrib/groff/contrib/mom/momdoc/color.html U src/contrib/groff/contrib/mom/momdoc/cover.html U src/contrib/groff/contrib/mom/momdoc/definitions.html U src/contrib/groff/contrib/mom/momdoc/docelement.html U src/contrib/groff/contrib/mom/momdoc/docprocessing.html U src/contrib/groff/contrib/mom/momdoc/goodies.html U src/contrib/groff/contrib/mom/momdoc/headfootpage.html U src/contrib/groff/contrib/mom/momdoc/inlines.html U src/contrib/groff/contrib/mom/momdoc/intro.html U src/contrib/groff/contrib/mom/momdoc/letters.html N src/contrib/groff/contrib/mom/momdoc/macrolist.html U src/contrib/groff/contrib/mom/momdoc/rectoverso.html N src/contrib/groff/contrib/mom/momdoc/refer.html U src/contrib/groff/contrib/mom/momdoc/reserved.html U src/contrib/groff/contrib/mom/momdoc/toc.html U src/contrib/groff/contrib/mom/momdoc/typemacdoc.html U src/contrib/groff/contrib/mom/momdoc/typesetting.html U src/contrib/groff/contrib/mom/momdoc/using.html N src/contrib/groff/contrib/pdfmark/ChangeLog N src/contrib/groff/contrib/pdfmark/cover.ms N src/contrib/groff/contrib/pdfmark/Makefile.sub N src/contrib/groff/contrib/pdfmark/pdfmark.ms N src/contrib/groff/contrib/pdfmark/pdfmark.tmac N src/contrib/groff/contrib/pdfmark/pdfroff.man N src/contrib/groff/contrib/pdfmark/pdfroff.sh N src/contrib/groff/contrib/pdfmark/PROBLEMS N src/contrib/groff/contrib/pdfmark/README N src/contrib/groff/contrib/pdfmark/spdf.tmac N src/contrib/groff/contrib/pdfmark/TODO N src/contrib/groff/contrib/gdiffmk/ChangeLog N src/contrib/groff/contrib/gdiffmk/gdiffmk.man N src/contrib/groff/contrib/gdiffmk/gdiffmk.sh N src/contrib/groff/contrib/gdiffmk/Makefile.sub N src/contrib/groff/contrib/gdiffmk/README N src/contrib/groff/contrib/gdiffmk/tests/file1 N src/contrib/groff/contrib/gdiffmk/tests/file2 N src/contrib/groff/contrib/gdiffmk/tests/runtests.in N src/contrib/groff/contrib/gdiffmk/tests/test_baseline N src/contrib/groff/contrib/gdiffmk/tests/test_baseline10 N src/contrib/groff/contrib/gdiffmk/tests/test_baseline6 N src/contrib/groff/contrib/gdiffmk/tests/test_baseline7 N src/contrib/groff/contrib/gdiffmk/tests/test_baseline8 N src/contrib/groff/contrib/gdiffmk/tests/test_baseline9 22 conflicts created by this import. Use the following command to help the merge: cvs checkout -jFSF:yesterday -jFSF src/contrib/groff From owner-cvs-src@FreeBSD.ORG Thu Oct 20 10:47:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB4EB16A41F; Thu, 20 Oct 2005 10:47:27 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D32A43D5A; Thu, 20 Oct 2005 10:47:27 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KAlRcM082424; Thu, 20 Oct 2005 10:47:27 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KAlR6w082423; Thu, 20 Oct 2005 10:47:27 GMT (envelope-from ru) Message-Id: <200510201047.j9KAlR6w082423@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 10:47:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: FSF Cc: Subject: cvs commit: src/contrib/groff README.CVS README.WIN32 test-groff src/contrib/groff/contrib/mom/examples README.mom macros.mom typeset.mom typewrite.mom src/contrib/groff/doc groff-10 groff-11 groff-4 groff-5 groff-6 groff-7 groff-8 groff-9 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 10:47:28 -0000 ru 2005-10-20 10:47:27 UTC FreeBSD src repository Removed files: (Branch: FSF) contrib/groff README.CVS README.WIN32 test-groff contrib/groff/contrib/mom/examples README.mom macros.mom typeset.mom typewrite.mom contrib/groff/doc groff-10 groff-11 groff-4 groff-5 groff-6 groff-7 groff-8 groff-9 contrib/groff/src/include groff-getopt.h contrib/groff/src/libs/libgroff progname.cpp contrib/groff/src/roff/troff glyphuni.cpp symbol.cpp symbol.h unicode.cpp unicode.h uniglyph.cpp uniuni.cpp contrib/groff/src/xditview ChangeLog DESC Dvi.c Dvi.h DviChar.c DviChar.h DviP.h FontMap GXditview-ad.h GXditview.ad INSTALL Imakefile.in Menu.h README TODO XFontName.c XFontName.h ad2c device.c device.h draw.c font.c gray1.bm gray2.bm gray3.bm gray4.bm gray5.bm gray6.bm gray7.bm gray8.bm gxditview.man lex.c page.c parse.c xdit.bm xdit_mask.bm xditview.c xtotroff.c Log: Removed files not present in v1.19.2 import. Revision Changes Path 1.1.1.2 +0 -6 src/contrib/groff/README.CVS (dead) 1.1.1.2 +0 -68 src/contrib/groff/README.WIN32 (dead) 1.1.1.2 +0 -56 src/contrib/groff/contrib/mom/examples/README.mom (dead) 1.1.1.2 +0 -668 src/contrib/groff/contrib/mom/examples/macros.mom (dead) 1.1.1.3 +0 -535 src/contrib/groff/contrib/mom/examples/typeset.mom (dead) 1.1.1.2 +0 -233 src/contrib/groff/contrib/mom/examples/typewrite.mom (dead) 1.1.1.3 +0 -485 src/contrib/groff/doc/groff-10 (dead) 1.1.1.3 +0 -1623 src/contrib/groff/doc/groff-11 (dead) 1.1.1.3 +0 -1406 src/contrib/groff/doc/groff-4 (dead) 1.1.1.3 +0 -1327 src/contrib/groff/doc/groff-5 (dead) 1.1.1.3 +0 -1462 src/contrib/groff/doc/groff-6 (dead) 1.1.1.3 +0 -1460 src/contrib/groff/doc/groff-7 (dead) 1.1.1.3 +0 -1416 src/contrib/groff/doc/groff-8 (dead) 1.1.1.3 +0 -985 src/contrib/groff/doc/groff-9 (dead) 1.1.1.3 +0 -68 src/contrib/groff/src/include/groff-getopt.h (dead) 1.1.1.2 +0 -1 src/contrib/groff/src/libs/libgroff/progname.cpp (dead) 1.1.1.2 +0 -503 src/contrib/groff/src/roff/troff/glyphuni.cpp (dead) 1.1.1.2 +0 -154 src/contrib/groff/src/roff/troff/symbol.cpp (dead) 1.1.1.3 +0 -80 src/contrib/groff/src/roff/troff/symbol.h (dead) 1.1.1.2 +0 -67 src/contrib/groff/src/roff/troff/unicode.cpp (dead) 1.1.1.2 +0 -26 src/contrib/groff/src/roff/troff/unicode.h (dead) 1.1.1.2 +0 -503 src/contrib/groff/src/roff/troff/uniglyph.cpp (dead) 1.1.1.2 +0 -1994 src/contrib/groff/src/roff/troff/uniuni.cpp (dead) 1.1.1.5 +0 -520 src/contrib/groff/src/xditview/ChangeLog (dead) 1.1.1.2 +0 -9 src/contrib/groff/src/xditview/DESC (dead) 1.1.1.2 +0 -573 src/contrib/groff/src/xditview/Dvi.c (dead) 1.1.1.2 +0 -46 src/contrib/groff/src/xditview/Dvi.h (dead) 1.1.1.4 +0 -662 src/contrib/groff/src/xditview/DviChar.c (dead) 1.1.1.2 +0 -37 src/contrib/groff/src/xditview/DviChar.h (dead) 1.1.1.2 +0 -233 src/contrib/groff/src/xditview/DviP.h (dead) 1.1.1.2 +0 -17 src/contrib/groff/src/xditview/FontMap (dead) 1.1.1.2 +0 -52 src/contrib/groff/src/xditview/GXditview-ad.h (dead) 1.1.1.2 +0 -57 src/contrib/groff/src/xditview/GXditview.ad (dead) 1.1.1.2 +0 -20 src/contrib/groff/src/xditview/INSTALL (dead) 1.1.1.5 +0 -120 src/contrib/groff/src/xditview/Imakefile.in (dead) 1.1.1.2 +0 -46 src/contrib/groff/src/xditview/Menu.h (dead) 1.1.1.2 +0 -14 src/contrib/groff/src/xditview/README (dead) 1.1.1.2 +0 -17 src/contrib/groff/src/xditview/TODO (dead) 1.1.1.2 +0 -256 src/contrib/groff/src/xditview/XFontName.c (dead) 1.1.1.2 +0 -45 src/contrib/groff/src/xditview/XFontName.h (dead) 1.1.1.2 +0 -62 src/contrib/groff/src/xditview/ad2c (dead) 1.1.1.2 +0 -600 src/contrib/groff/src/xditview/device.c (dead) 1.1.1.2 +0 -21 src/contrib/groff/src/xditview/device.h (dead) 1.1.1.3 +0 -725 src/contrib/groff/src/xditview/draw.c (dead) 1.1.1.2 +0 -471 src/contrib/groff/src/xditview/font.c (dead) 1.1.1.2 +0 -4 src/contrib/groff/src/xditview/gray1.bm (dead) 1.1.1.2 +0 -4 src/contrib/groff/src/xditview/gray2.bm (dead) 1.1.1.2 +0 -4 src/contrib/groff/src/xditview/gray3.bm (dead) 1.1.1.2 +0 -4 src/contrib/groff/src/xditview/gray4.bm (dead) 1.1.1.2 +0 -4 src/contrib/groff/src/xditview/gray5.bm (dead) 1.1.1.2 +0 -4 src/contrib/groff/src/xditview/gray6.bm (dead) 1.1.1.2 +0 -4 src/contrib/groff/src/xditview/gray7.bm (dead) 1.1.1.2 +0 -4 src/contrib/groff/src/xditview/gray8.bm (dead) 1.1.1.3 +0 -249 src/contrib/groff/src/xditview/gxditview.man (dead) 1.1.1.2 +0 -103 src/contrib/groff/src/xditview/lex.c (dead) 1.1.1.2 +0 -88 src/contrib/groff/src/xditview/page.c (dead) 1.1.1.3 +0 -340 src/contrib/groff/src/xditview/parse.c (dead) 1.1.1.2 +0 -14 src/contrib/groff/src/xditview/xdit.bm (dead) 1.1.1.2 +0 -14 src/contrib/groff/src/xditview/xdit_mask.bm (dead) 1.1.1.3 +0 -596 src/contrib/groff/src/xditview/xditview.c (dead) 1.1.1.2 +0 -311 src/contrib/groff/src/xditview/xtotroff.c (dead) 1.1.1.6 +0 -42 src/contrib/groff/test-groff (dead) From owner-cvs-src@FreeBSD.ORG Thu Oct 20 10:52:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69FD816A41F; Thu, 20 Oct 2005 10:52:00 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2552C43D64; Thu, 20 Oct 2005 10:52:00 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KAq0d9082676; Thu, 20 Oct 2005 10:52:00 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KAq0FD082675; Thu, 20 Oct 2005 10:52:00 GMT (envelope-from ru) Message-Id: <200510201052.j9KAq0FD082675@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 10:51:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT exclude X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 10:52:00 -0000 ru 2005-10-20 10:51:59 UTC FreeBSD src repository Modified files: . exclude Log: Temporary for Groff 1.19.2 import. Revision Changes Path 1.134 +1 -0 CVSROOT/exclude From owner-cvs-src@FreeBSD.ORG Thu Oct 20 10:52:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1231416A420; Thu, 20 Oct 2005 10:52:35 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC56443D64; Thu, 20 Oct 2005 10:52:34 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KAqYn4082748; Thu, 20 Oct 2005 10:52:34 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KAqYfB082747; Thu, 20 Oct 2005 10:52:34 GMT (envelope-from ru) Message-Id: <200510201052.j9KAqYfB082747@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 10:52:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/groff/man groff_out.man src/contrib/groff/tmac doc-common doc-ditroff doc-nroff doc-syms X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 10:52:35 -0000 ru 2005-10-20 10:52:34 UTC FreeBSD src repository Modified files: contrib/groff/man groff_out.man contrib/groff/tmac doc-common doc-ditroff doc-nroff doc-syms Log: Use stock (FSF) version of this file. Revision Changes Path 1.9 +384 -175 src/contrib/groff/man/groff_out.man 1.69 +4 -4 src/contrib/groff/tmac/doc-common 1.11 +2 -4 src/contrib/groff/tmac/doc-ditroff 1.11 +2 -4 src/contrib/groff/tmac/doc-nroff 1.49 +2 -4 src/contrib/groff/tmac/doc-syms From owner-cvs-src@FreeBSD.ORG Thu Oct 20 10:53:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0086416A41F; Thu, 20 Oct 2005 10:53:15 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7858543D68; Thu, 20 Oct 2005 10:53:15 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KArFi8082912; Thu, 20 Oct 2005 10:53:15 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KArFik082911; Thu, 20 Oct 2005 10:53:15 GMT (envelope-from ru) Message-Id: <200510201053.j9KArFik082911@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 10:53:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/groff/src/devices/grotty grotty.man src/contrib/groff/src/libs/libgroff cmap.cpp cset.cpp invalid.cpp src/contrib/groff/src/preproc/eqn neqn.sh src/contrib/groff/src/roff/groff groff.man src/contrib/groff/src/roff/nroff nroff.man nroff.sh ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 10:53:16 -0000 ru 2005-10-20 10:53:15 UTC FreeBSD src repository Modified files: contrib/groff/src/devices/grotty grotty.man contrib/groff/src/libs/libgroff cmap.cpp cset.cpp invalid.cpp contrib/groff/src/preproc/eqn neqn.sh contrib/groff/src/roff/groff groff.man contrib/groff/src/roff/nroff nroff.man nroff.sh contrib/groff/tmac troffrc tty-char.tmac tty.tmac Log: Merge Groff 1.19.2 changes. Revision Changes Path 1.9 +5 -1 src/contrib/groff/src/devices/grotty/grotty.man 1.3 +1 -1 src/contrib/groff/src/libs/libgroff/cmap.cpp 1.3 +4 -2 src/contrib/groff/src/libs/libgroff/cset.cpp 1.3 +1 -1 src/contrib/groff/src/libs/libgroff/invalid.cpp 1.11 +4 -4 src/contrib/groff/src/preproc/eqn/neqn.sh 1.10 +120 -27 src/contrib/groff/src/roff/groff/groff.man 1.12 +10 -1 src/contrib/groff/src/roff/nroff/nroff.man 1.18 +25 -17 src/contrib/groff/src/roff/nroff/nroff.sh 1.17 +4 -4 src/contrib/groff/tmac/troffrc 1.3 +8 -1 src/contrib/groff/tmac/tty-char.tmac 1.3 +4 -0 src/contrib/groff/tmac/tty.tmac From owner-cvs-src@FreeBSD.ORG Thu Oct 20 10:57:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22A7916A420; Thu, 20 Oct 2005 10:57:54 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6C5043D64; Thu, 20 Oct 2005 10:57:53 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KAvr8P083316; Thu, 20 Oct 2005 10:57:53 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KAvrGV083315; Thu, 20 Oct 2005 10:57:53 GMT (envelope-from ru) Message-Id: <200510201057.j9KAvrGV083315@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 10:57:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/groff Makefile.inc src/gnu/usr.bin/groff/font Makefile.tty src/gnu/usr.bin/groff/font/devhtml Makefile src/gnu/usr.bin/groff/font/devlj4 Makefile src/gnu/usr.bin/groff/src/devices/grolj4 Makefile src/gnu/usr.bin/groff/src/devices/xditview Makefile ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 10:57:54 -0000 ru 2005-10-20 10:57:53 UTC FreeBSD src repository Modified files: gnu/usr.bin/groff Makefile.inc gnu/usr.bin/groff/font Makefile.tty gnu/usr.bin/groff/font/devhtml Makefile gnu/usr.bin/groff/font/devlj4 Makefile gnu/usr.bin/groff/src/devices/grolj4 Makefile gnu/usr.bin/groff/src/include config.h gnu/usr.bin/groff/src/libs/libgroff Makefile gnu/usr.bin/groff/src/roff/troff Makefile gnu/usr.bin/groff/src/utils/hpftodit Makefile gnu/usr.bin/groff/tmac Makefile Added files: gnu/usr.bin/groff/src/devices/xditview Makefile Log: Upgrade to Groff 1.19.2. Revision Changes Path 2.12 +3 -0 src/gnu/usr.bin/groff/Makefile.inc 2.8 +4 -1 src/gnu/usr.bin/groff/font/Makefile.tty 1.3 +2 -0 src/gnu/usr.bin/groff/font/devhtml/Makefile 1.2 +6 -3 src/gnu/usr.bin/groff/font/devlj4/Makefile 1.5 +1 -0 src/gnu/usr.bin/groff/src/devices/grolj4/Makefile 1.1 +37 -0 src/gnu/usr.bin/groff/src/devices/xditview/Makefile (new) 1.5 +31 -23 src/gnu/usr.bin/groff/src/include/config.h 1.9 +7 -6 src/gnu/usr.bin/groff/src/libs/libgroff/Makefile 1.5 +2 -3 src/gnu/usr.bin/groff/src/roff/troff/Makefile 1.5 +1 -1 src/gnu/usr.bin/groff/src/utils/hpftodit/Makefile 1.43 +2 -0 src/gnu/usr.bin/groff/tmac/Makefile From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:01:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49F8816A420; Thu, 20 Oct 2005 11:01:53 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 004E043D62; Thu, 20 Oct 2005 11:01:52 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KB1qtr083551; Thu, 20 Oct 2005 11:01:52 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KB1qOx083550; Thu, 20 Oct 2005 11:01:52 GMT (envelope-from ru) Message-Id: <200510201101.j9KB1qOx083550@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 11:01:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT exclude X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:01:53 -0000 ru 2005-10-20 11:01:52 UTC FreeBSD src repository Modified files: . exclude Log: Revert last change. Revision Changes Path 1.135 +0 -1 CVSROOT/exclude From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:10:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE8AA16A436; Thu, 20 Oct 2005 11:10:43 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6489D43D6A; Thu, 20 Oct 2005 11:10:43 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KBAhDg083989; Thu, 20 Oct 2005 11:10:43 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KBAhRL083988; Thu, 20 Oct 2005 11:10:43 GMT (envelope-from ru) Message-Id: <200510201110.j9KBAhRL083988@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 11:10:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/groff/src/devices/xditview Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:10:45 -0000 ru 2005-10-20 11:10:43 UTC FreeBSD src repository Modified files: gnu/usr.bin/groff/src/devices/xditview Makefile Log: Remove some conversion leftovers. Revision Changes Path 1.2 +0 -3 src/gnu/usr.bin/groff/src/devices/xditview/Makefile From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:11:43 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A550F16A41F; Thu, 20 Oct 2005 11:11:43 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id F164643D69; Thu, 20 Oct 2005 11:11:42 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9KBBNAI017674; Thu, 20 Oct 2005 21:11:23 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9KBBB9X021798; Thu, 20 Oct 2005 21:11:11 +1000 Date: Thu, 20 Oct 2005 21:11:11 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: David Xu In-Reply-To: <435749A8.5070309@freebsd.org> Message-ID: <20051020205717.R874@delplex.bde.org> References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <20051018094402.A29138@grasshopper.cs.duke.edu> <435501B9.4070401@samsco.org> <17237.1482.52148.283282@grasshopper.cs.duke.edu> <4355080C.302@samsco.org> <20051020145234.H99720@delplex.bde.org> <435749A8.5070309@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, Scott Long , src-committers@freebsd.org, Andrew Gallatin , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:11:43 -0000 On Thu, 20 Oct 2005, David Xu wrote: > Bruce Evans wrote: >> I wonder if this reduces the context switch latency from about 1.320 >> usec to 0.900 usec on my A64-3000. The latency is only .520 usec in >> i386 mode. I use a TSC timecounter of course. > > we can avoid reloading userland GS.base MSR and FS.base MSR for system > threads, I am not sure if it can reduce interrupt thread latency. I think it would recover some of the the other 0.400 usec of the extra overhead for the amd64 case. We already avoid null reloads of %cr3 and avoiding null reloads of FS/GS.base would be similar. Both are null only for intra-kernel switches, so the savings are smaller than for the stores of FS/GS.base since the reloads can't always be avoided. Bruce From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:14:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12A1E16A41F; Thu, 20 Oct 2005 11:14:35 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0FB743D5A; Thu, 20 Oct 2005 11:14:34 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KBEYrI084158; Thu, 20 Oct 2005 11:14:34 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KBEYks084157; Thu, 20 Oct 2005 11:14:34 GMT (envelope-from marius) Message-Id: <200510201114.j9KBEYks084157@repoman.freebsd.org> From: Marius Strobl Date: Thu, 20 Oct 2005 11:14:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/ofw/libofw libofw.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:14:35 -0000 marius 2005-10-20 11:14:34 UTC FreeBSD src repository Modified files: sys/boot/ofw/libofw libofw.h Log: Use an ihandle_t to store the instance handle of an opened device instead of a phandle_t (package handle). Since both are typedefed to unsigned int, this is more or less cosmetic. Revision Changes Path 1.11 +1 -1 src/sys/boot/ofw/libofw/libofw.h From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:18:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE42216A420; Thu, 20 Oct 2005 11:18:24 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9B4C43D69; Thu, 20 Oct 2005 11:18:24 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KBIOa2084398; Thu, 20 Oct 2005 11:18:24 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KBIO2h084397; Thu, 20 Oct 2005 11:18:24 GMT (envelope-from ru) Message-Id: <200510201118.j9KBIO2h084397@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 11:18:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/groff FREEBSD-upgrade X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:18:25 -0000 ru 2005-10-20 11:18:24 UTC FreeBSD src repository Modified files: contrib/groff FREEBSD-upgrade Log: Update upgrade instructions. Revision Changes Path 1.6 +4 -4 src/contrib/groff/FREEBSD-upgrade From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:20:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 86B2116A41F; Thu, 20 Oct 2005 11:20:56 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C4F7A43D62; Thu, 20 Oct 2005 11:20:55 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KBKtRq084590; Thu, 20 Oct 2005 11:20:55 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KBKtTA084589; Thu, 20 Oct 2005 11:20:55 GMT (envelope-from dds) Message-Id: <200510201120.j9KBKtTA084589@repoman.freebsd.org> From: Diomidis Spinellis Date: Thu, 20 Oct 2005 11:20:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/restore restore.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:20:56 -0000 dds 2005-10-20 11:20:55 UTC FreeBSD src repository Modified files: sbin/restore restore.8 Log: Remove a diagnostic message that can't occur: we lost the ability to handle the old filesystem format on 2002/06/21. Revision Changes Path 1.51 +0 -3 src/sbin/restore/restore.8 From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:22:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BB8316A41F; Thu, 20 Oct 2005 11:22:31 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD3A143D66; Thu, 20 Oct 2005 11:22:30 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KBMUkj084656; Thu, 20 Oct 2005 11:22:30 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KBMU35084655; Thu, 20 Oct 2005 11:22:30 GMT (envelope-from ru) Message-Id: <200510201122.j9KBMU35084655@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 11:22:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:22:31 -0000 ru 2005-10-20 11:22:30 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: Force an upgrade to Groff 1.19.2. Revision Changes Path 1.513 +1 -1 src/Makefile.inc1 From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:49:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 215AA16A41F; Thu, 20 Oct 2005 11:49:26 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1CE743D5A; Thu, 20 Oct 2005 11:49:25 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KBnPcX086705; Thu, 20 Oct 2005 11:49:25 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KBnPNK086704; Thu, 20 Oct 2005 11:49:25 GMT (envelope-from suz) Message-Id: <200510201149.j9KBnPNK086704@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Thu, 20 Oct 2005 11:49:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netinet6 raw_ip6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:49:26 -0000 suz 2005-10-20 11:49:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet6 raw_ip6.c Log: MFC 1.56 (added a missing unlock) Approved by: re(scottl) Revision Changes Path 1.50.2.3 +3 -1 src/sys/netinet6/raw_ip6.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 11:50:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D86F616A41F; Thu, 20 Oct 2005 11:50:35 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E75D43D5A; Thu, 20 Oct 2005 11:50:34 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9KBoXuN022831; Thu, 20 Oct 2005 21:50:33 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9KBoUrw024906; Thu, 20 Oct 2005 21:50:32 +1000 Date: Thu, 20 Oct 2005 21:50:31 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <8229.1129790637@critter.freebsd.dk> Message-ID: <20051020211131.A874@delplex.bde.org> References: <8229.1129790637@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 11:50:36 -0000 On Thu, 20 Oct 2005, Poul-Henning Kamp wrote: > In message <20051020131450.T99502@delplex.bde.org>, Bruce Evans writes: >> On Tue, 18 Oct 2005, Poul-Henning Kamp wrote: > >> Using CLOCK_MONOTONIC doesn't work because it it gives the system's idea >> of the time and doesn't try hard to keep in sync with the real time. >> In particular, it doesn't jump when the real time is stepped by >> settimeofday(2) or clock_settime(2). > > Uhm, Bruce, > > That is the exact reason why we have CLOCK_MONOTONIC: it doesn't jump. I know why we have it and what it does. > With respect to leapseconds: Whoever was responsible for POSIX's > decision should be forced to work as quality assurance inspector > in a factory which makes cuu-cuu clocks for the rest of their lives. POSIX's specification of CLOCK_MONOTONIC seems to be missing leap seconds problems. It seems to be required to actually work; thus it should give the difference in real time, in seconds with nanoseconds resolution, relative to its starting point, so it must include leap seconds. Of course it can't reasonably be expected to have nanoseconds accuracy. Since it cannot jump, it also cannot reasonably be expected to have even seconds accuracy all the time. There will be times just after the time is synced with an external accurate clock when the real time is kown very accurately but the monotonic time is known (at the kernel level) to be very innaccurate (since the monotonic time cannot jump to match the real time, especially backwards). However, it is reasonable to expect that the monotonic time is slewed to correct this difference. This is not done in FreeBSD. difftime() also seems to be required to actually work. According to draft C99 (n869.txt): % [#2] The difftime function computes the difference between % two calendar times: time1 - time0. time_t's cannot be naively subtracted in general in C, so the difference here must be formal. The difference is required to contain leap seconds by POLA. According to draft POSIX.1-2001 (d7.txt): % 8275 CX The functionality described on this reference page is aligned with the ISO C standard. Any % 8276 conflict between the requirements described here and the ISO C standard is unintentional. This % 8277 volume of IEEE Std 1003.1-200x defers to the ISO C standard. % 8278 The difftime( ) function shall compute the difference between two calendar times (as returned by % 8279 time( )): time1- time0. Here naive subtraction gives a result, but it cannot always give the correct result since time_t's don't contain leap seconds in POSIX. Since C99 has precedence, difftime() cannot be implemented using naive subtraction; it must somehow adjust for leap seconds being missing from the time_t's. Back to the utilities: according to the standards, it seems to be equally correct to implement "double uptime()" as: /* Done in kernel; happens to give 0 in FreeBSD implementation: */ clock_gettime(CLOCK_MONOTONIC, &boottime); clock_gettime(CLOCK_MONOTONIC, &now); return (now.tv_sec - boottime.tv_sec + 1e-9 * (now.tv_nsec - boottime.tv_nsec); and as: /* Done in kernel; nonzero except if you booted in 1970: */ clock_gettime(CLOCK_REALTIME, &boottime); clock_gettime(CLOCK_REALTIME, &now); /* Restore leap seconds if necessary; lose nanoseconds resolution: */ return difftime(now.tv_sec, boottime.tv_sec); Different bugs prevent both of these working as well as they should. For w, no one should even notice the inaccuracies of a few seconds caused by the bugs. For vmstat, the first method works better because the bugs in the monotonic clock cause only small relative errors in the difference, while for the second method only the bugs can be fixed -- large relative errors in the difference caused by stepping the clock are unfixable. Bruce From owner-cvs-src@FreeBSD.ORG Thu Oct 20 12:44:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D48A16A41F; Thu, 20 Oct 2005 12:44:54 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id BBF0443D5A; Thu, 20 Oct 2005 12:44:53 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 0F43CBC66; Thu, 20 Oct 2005 12:44:51 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 20 Oct 2005 21:50:31 +1000." <20051020211131.A874@delplex.bde.org> Date: Thu, 20 Oct 2005 14:44:51 +0200 Message-ID: <25112.1129812291@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 12:44:54 -0000 In message <20051020211131.A874@delplex.bde.org>, Bruce Evans writes: >POSIX's specification of CLOCK_MONOTONIC seems to be missing leap seconds >problems. It seems to be required to actually work; thus it should give >the difference in real time, in seconds with nanoseconds resolution, >relative to its starting point, so it must include leap seconds. It doesn't make sense to talk about a leap seconds on a timescale which is not UTC because leap-seconds by definition only exist in UTC. CLOCK_MONOTONIC is defined as a count of seconds (lets tacitly assume they mean SI seconds here) from an arbitrary origin. A better and unambiguous way to write that would have been: CLOCK_MONOTONIC = TAI + alpha It follows from this that CLOCK_MONOTONIC does not know what a leap-second is and doesn't notice them happening. Because of our particular choice of alpha, CLOCK_MONOTONIC is also a very convenient measure of how many seconds the kernel has been running. >Of course it can't reasonably be expected to have nanoseconds accuracy. >[...] It certainly can and should be expected to and it does. >difftime() also seems to be required to actually work. According to >draft C99 (n869.txt): > >% [#2] The difftime function computes the difference between >% two calendar times: time1 - time0. Again, this is another example of computer-geeks missing the finer points in timekeeping. The word "calendar" refers to things counting time in units of days. The above text therefore conveys no usable information about how leap-seconds should be accounted for, since leap seconds by definition are intra-day. > [clarification from other standard that the two time_t comes from time(2)] >time_t's cannot be naively subtracted in general in C, so the difference >here must be formal. The difference is required to contain leap seconds >by POLA. Yeah, right: in your dreams... You can by definition not implment difftime correctly since the time_t timescale does not contain any indication of leapseconds. This means that there is no way to tell which side of an inserted leapsecond a time(2) timestamp comes from: UTC time(2) 23:59:57 N-3 23:59:58 N-2 23:59:59 N-1 23:59:60 N 00:00:00 N 00:00:01 N+1 Worst case, difftime() will be wrong by two seconds: taking the difference from one leapsecond to another and guessing wrong in both ends. The fact that mktime() and timegm() gets it wrong the other way because of DWIM logic is merely ising on the cake. >Back to the utilities: according to the standards, it seems to be equally >correct to implement "double uptime()" as: > > /* Done in kernel; happens to give 0 in FreeBSD implementation: */ > clock_gettime(CLOCK_MONOTONIC, &boottime); > > clock_gettime(CLOCK_MONOTONIC, &now); > > return (now.tv_sec - boottime.tv_sec + > 1e-9 * (now.tv_nsec - boottime.tv_nsec); On FreeBSD this delivers the correct answer. >and as: > > /* Done in kernel; nonzero except if you booted in 1970: */ > clock_gettime(CLOCK_REALTIME, &boottime); > > clock_gettime(CLOCK_REALTIME, &now); > > /* Restore leap seconds if necessary; lose nanoseconds resolution: */ > return difftime(now.tv_sec, boottime.tv_sec); This suffers from the +/-2 second error from difftime(2) and will return the wrong result if the clock is stepped. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Oct 20 12:55:54 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D19AA16A41F; Thu, 20 Oct 2005 12:55:53 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DB5043D5A; Thu, 20 Oct 2005 12:55:51 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9KCtbVE013693; Thu, 20 Oct 2005 22:55:37 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9KCtMGX011464; Thu, 20 Oct 2005 22:55:23 +1000 Date: Thu, 20 Oct 2005 22:55:23 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <23346.1129796829@critter.freebsd.dk> Message-ID: <20051020215101.Y874@delplex.bde.org> References: <23346.1129796829@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Scott Long , src-committers@freebsd.org, Andrew Gallatin , cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 12:55:54 -0000 On Thu, 20 Oct 2005, Poul-Henning Kamp wrote: > In message <20051020155911.C99720@delplex.bde.org>, Bruce Evans writes: > >>> One of the things you have to realize is that once you go down this >>> road you need a lot of code for all the conditionals. >>> >>> For instance you need to make sure that every new timestamp you >>> hand out not prior to another one, no matter what is happening to >>> the clocks. >> >> Clocks are already incoherent in many ways: >> - the times returned by the get*() functions incoherent with the ones >> returned by the functions that read the hardware, because the latter >> are always in advance of the former and the difference is sometimes >> visible at the active resolution. > > Sorry Bruce, but this is just FUD: The entire point of the get* > familiy of functions is to provide "good enough" timestamps, very > fast, for code that knows it doesn't need better than roughly 1/hz > precision. This bug shows that the get* functions don't actually provide "good enough" timestamps, even for what is probably their primary use -- ffs file times are probably their primary use, and these only need a resolution of 1 second; however, they need to be accurate relative to other clocks, and a precision of ~1/hz doesn't provide enough accuracy due to implementation details. >> visible at the active resolution. POSIX tests of file times have >> been reporting this incoherency since timecounters were implemented. >> The tests use time() to determine the current time and stat() to >> determine file times. In the sequence: >> >> t1 = time(...): >> sleep(1) >> touch(file); >> stat(file); >> t2 = mtime(file); >> >> t2 should be < t1, but the bug lets t2 == t1 happen. > > t2 == t1 is not illegal. It is just invalid and of low quality for file systems that provide a resolution of 1 second in their timestamps. The sleep of 1 second in there is specific to such file systems; it is to ensure that at least 1 second has elapsed between the time() and the touch(). > The morons who defined a non-extensible timestamp format obviously > didn't belive in Andy Moore, but given a sufficiently fast computer > the resolution of the standardized timestamps prevents t2 > t1 in > the above test code. POSIX specifies the resolution for file times but doesn't specify their accuracy AFAIK (not far). Quality of implementation specifies their accuracy. The above is a simple test for strict monotonicity of file times that happens to test for accuracy and coherency too. This monotonicity is very easy to get right. sleep(3) is required to sleep for at least 1 second. nanosleep(2) is sloppy about this -- it uses a get* function so it risks similar bugs, but I think none here since the extra tick in the timeout provides a sufficient margin for error. After sleeping for at least 1 second, the time has surely advanced by 1 second and timestamps taken by a coherent clock will see this. With a time(2) in it, the test would just not see incoherencies of 1 second. >> - times are incoherent between threads unless the threads use their >> own expensive locking to prevent this. This is not very different >> from timestamps being incoherent between CPUs unless the system uses >> expensive locking to prevent it. > > Only if the get* family of functions is used in places where they > shouldn't be. I belive there is a sysctl which determines if it > is used for vfs timestamp. The default can be changed if necessary. This point is for all the functions. A timestamp taken by 1 thread might not be used until after many timestamps are taken and used by other threads. Naive comparison of these timestamps would then give apparent incoherencies. It is up to the threads to provide synchronization points if they want to compare times. More interestingly, there is no need to keep the timecounters seen by different threads perfectly in sync except at synchronization points, since any differences would be indistinguishable frome ones caused be unsynchronized preemption. (Strict real time to ~nanoseconds accuracy wouldn't work for either.) I use the sysctl in POSIX tests to as not to keep seeing the the file times bugs, but I sometimes forget to use it so I get remined of the bugs anyway. IIRC, I got jdp to change the sysctl a bit to handle more cases. He wanted an option for more resolution and I wanted one to unbreak seconds resolution. The implementation actually uses the get* functions for seconds and 1/hz resolution and the non-get* functions for microseconds and nanoseconds resolution. So I use an unnecessarily high resolution to avoid the bug. >>> On a busy system the scheduler works hundred thousand times per >>> second, but on most systems nobody ever looks at the times(2) data. >> >> More like 1000 times a second. Even stathz = 128 gives too many decisions >> per second for the 4BSD scheduler, so it is divided down to 16 per second. >> Processes blocking on i/o may cause many more than 128/sec calls to the >> scheduler, but there should be nothing much to decide then. > > I'm regularly running into 5 digits in the Csw field in systat -vm. > I don't know what events you talk about, but they are clearly not > the same as the ones I'm talking about. I just looked at csw values on machines in the freebsd cluster. They may be underpowered and not heavily used, but they are more active than any machine that I run and may be representative of general server machines. On hub a few hours ago, csw was a transient 100-500 and the average since boot time was 1010. The count since boot time may have overflowed but the average is reasonable. hub has been up for 236 days and an average of 1010/sec gives a count of just below INT_MAX. The 128/16 events is for timekeeping for scheduling. 4BSD does little more than incrememnt a tick count here. ULE does a bit more. Then there are the rescheduling every second for 4BSD, and more distributed rescheduling for ULE. On context switches, the scheduler has (or should have) little to do. It is context switching itself that makes the timestamps that become too expensive when csw is high. > The problem here is context-switch time, and while we can argue if > this is really scheduler related or not, the fact that the scheduler > decides which thread to context-switch to should be enough to > avoid a silly discussion of semantics. The problem is still unrelated to (non-broken) schedulers. Most context switches happens because something blocks on i/o or is preempted by an interrupt handler (it's a very low level of scheduling -- just interrupt priority -- that allows the preemption, so I don't count it as part of scheduling). So unavoidable context switches can happen a lot on busy machines and the scheduler can't/shouldn't affect their count except possibly to reduce it a bit. Given that they happen a lot on some systems, they should be as efficient as possible. I think the timecounter part of their inefficiency is not very important except in the usual case of a slow timecounter. Losses from busted caches may dominate. >> So the current pessimizations from timecounter calls in mi_switch() >> are an end result of general pessimizations of swtch() starting in >> 4.4BSD. I rather like this part of the pessimizations... > > It's so nice to have you back in action Bruce :-) I don't plan to stay very active. Bruce From owner-cvs-src@FreeBSD.ORG Thu Oct 20 13:05:27 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE49116A41F; Thu, 20 Oct 2005 13:05:27 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61B5343D62; Thu, 20 Oct 2005 13:05:27 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 9BA7FBC66; Thu, 20 Oct 2005 13:05:20 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 20 Oct 2005 22:55:23 +1000." <20051020215101.Y874@delplex.bde.org> Date: Thu, 20 Oct 2005 15:05:19 +0200 Message-ID: <25362.1129813519@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Scott Long , src-committers@freebsd.org, Andrew Gallatin , cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 13:05:28 -0000 In message <20051020215101.Y874@delplex.bde.org>, Bruce Evans writes: >On Thu, 20 Oct 2005, Poul-Henning Kamp wrote: >This point is for all the functions. A timestamp taken by 1 thread >might not be used until after many timestamps are taken and used by >other threads. Naive comparison of these timestamps would then give >apparent incoherencies. Ahh, but now we're into the "programmer doesn't understand concurrency" territory, that has little to do with our timekeeping functions. >On hub a few hours ago, csw was a transient 100-500 and the >average since boot time was 1010. The average since boot should not be optimized for, since we don't really care what the machine does (or doesn't) when we are not offering any workload to it. >So unavoidable context switches can happen >a lot on busy machines and the scheduler can't/shouldn't affect their >count except possibly to reduce it a bit. Given that they happen a lot >on some systems, they should be as efficient as possible. I think the >timecounter part of their inefficiency is not very important except in >the usual case of a slow timecounter. Losses from busted caches may >dominate. I would tend to agree with you there, but any sensible optimization should be done. >> It's so nice to have you back in action Bruce :-) > >I don't plan to stay very active. Too bad, your considered opinion, even though we often disagree, is one of the things I really enjoy around here: it forces me to think harder. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Oct 20 14:28:27 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 472D616A420; Thu, 20 Oct 2005 14:28:27 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39CE743D88; Thu, 20 Oct 2005 14:28:22 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Thu, 20 Oct 2005 10:44:30 -0400 From: John Baldwin To: Bruce Evans Date: Thu, 20 Oct 2005 09:59:19 -0400 User-Agent: KMail/1.8.2 References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <200510181101.03956.jhb@freebsd.org> <20051020154709.U99720@delplex.bde.org> In-Reply-To: <20051020154709.U99720@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510200959.21234.jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andrew Gallatin , cvs-all@freebsd.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 14:28:27 -0000 On Thursday 20 October 2005 01:53 am, Bruce Evans wrote: > On Tue, 18 Oct 2005, John Baldwin wrote: > > On Tuesday 18 October 2005 09:44 am, Andrew Gallatin wrote: > >> It is a shame we can't find a way to use the TSC as a timecounter on > >> SMP systems. It seems that about 40% of the context switch time is > >> spent just waiting for the PIO read of the ACPI-fast or i8254 to > >> return. > > > > You can try it by just setting the kern.timecounter.smp_tsc=1 tunable on > > boot. > > There is no need for this. Just set the timecounter using sysctl after > booting (and quickly switch it back if it doesn't work). > > This tuneable, like most, shouldn't exist. It may be a relic from > when the TSC wasn't put in the list of available timecounters in the > SMP case. It is now put in the list with a negative "quaility", but > the sysctl to set the timecounter correctly not restricted by the > quality. Ah, I didn't realize the sysctl let you use negative quality timecounters. The tunable does serve to automate it for remote machines I guess since it doesn't pessimize the quality on SMP. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Oct 20 14:28:45 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28EB816A424; Thu, 20 Oct 2005 14:28:45 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68AF643D70; Thu, 20 Oct 2005 14:28:43 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Thu, 20 Oct 2005 10:44:30 -0400 From: John Baldwin To: Bruce Evans Date: Thu, 20 Oct 2005 09:58:07 -0400 User-Agent: KMail/1.8.2 References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <4355080C.302@samsco.org> <20051020145234.H99720@delplex.bde.org> In-Reply-To: <20051020145234.H99720@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510200958.09182.jhb@freebsd.org> Cc: Scott Long , src-committers@freebsd.org, Andrew Gallatin , cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 14:28:45 -0000 On Thursday 20 October 2005 01:45 am, Bruce Evans wrote: > On Tue, 18 Oct 2005, Scott Long wrote: > I use 100 and never downgraded to use 1000 except for testing how bad > it is. The default number is now up to * 2 * HZ. > E.g., it is 4000 on sledge.freebsd.org. While 4000 interrupts/sec can > be handled easily by any new machine, 4000 is a disgustingly large > number to use for clock interrupts. Have a look at vmstat -i output > on almost any machine. On most machines in the freebsd cluster, the > total number of interrupts is dominated by clock interrupts even with > HZ = 100. Note that on 4.x you don't get to see the interrupt counts for the hz + stathz * (cpus - 1) IPIs for all the clock interrupts, so in real numbers, each CPU has gone from hz + stathz to hz * 2 interrupts. However, the higher number is offset by the fact that the interrupt handler for the lapic case doesn't have to touch any hardware, and it also works much more reliably (getting irq0 to work in APIC mode on some amd64 nvidia chipsets required several quirks, and future motherboards will probably continue to require quirks since Windows uses the APIC timer in APIC mode and doesn't require irq0 to work in APIC mode). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Oct 20 14:34:51 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B902C16A421; Thu, 20 Oct 2005 14:34:51 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7A9A43D5A; Thu, 20 Oct 2005 14:34:49 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.1.105] (69-161-144-40.miamfl.adelphia.net [69.161.144.40]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id j9KEYgjx073211; Thu, 20 Oct 2005 08:34:42 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4357AAFE.2070002@samsco.org> Date: Thu, 20 Oct 2005 08:34:38 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <4355080C.302@samsco.org> <20051020145234.H99720@delplex.bde.org> <200510200958.09182.jhb@freebsd.org> In-Reply-To: <200510200958.09182.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.0 required=3.8 tests=RCVD_IN_SORBS_DUL autolearn=no version=3.1.0 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: src-committers@freebsd.org, Andrew Gallatin , Bruce Evans , cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 14:34:52 -0000 John Baldwin wrote: > On Thursday 20 October 2005 01:45 am, Bruce Evans wrote: > >>On Tue, 18 Oct 2005, Scott Long wrote: >>I use 100 and never downgraded to use 1000 except for testing how bad >>it is. The default number is now up to * 2 * HZ. >>E.g., it is 4000 on sledge.freebsd.org. While 4000 interrupts/sec can >>be handled easily by any new machine, 4000 is a disgustingly large >>number to use for clock interrupts. Have a look at vmstat -i output >>on almost any machine. On most machines in the freebsd cluster, the >>total number of interrupts is dominated by clock interrupts even with >>HZ = 100. > > > Note that on 4.x you don't get to see the interrupt counts for the hz + stathz > * (cpus - 1) IPIs for all the clock interrupts, so in real numbers, each CPU > has gone from hz + stathz to hz * 2 interrupts. However, the higher number > is offset by the fact that the interrupt handler for the lapic case doesn't > have to touch any hardware, and it also works much more reliably (getting > irq0 to work in APIC mode on some amd64 nvidia chipsets required several > quirks, and future motherboards will probably continue to require quirks > since Windows uses the APIC timer in APIC mode and doesn't require irq0 to > work in APIC mode). > I'm in complete argreement that using the APIC timer is the right thing to do, and I believe that we did some tests to show that the high interrupt rate didn't have an appreciable effect on performance. However, I'd like to revisit the HZ=1000 decision for 7-CURRENT. Scott From owner-cvs-src@FreeBSD.ORG Thu Oct 20 14:50:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C9F716A41F; Thu, 20 Oct 2005 14:50:00 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE5F243D5A; Thu, 20 Oct 2005 14:49:59 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KEnxE1002505; Thu, 20 Oct 2005 14:49:59 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KEnxsY002504; Thu, 20 Oct 2005 14:49:59 GMT (envelope-from jhb) Message-Id: <200510201449.j9KEnxsY002504@repoman.freebsd.org> From: John Baldwin Date: Thu, 20 Oct 2005 14:49:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 14:50:00 -0000 jhb 2005-10-20 14:49:59 UTC FreeBSD src repository Modified files: sys/kern subr_witness.c Log: Add entry for the spin mutex used by the hptmv(4) driver. MFC after: 1 day Tested by: Philip Kizer pckizer at nostrum dot com Revision Changes Path 1.203 +1 -0 src/sys/kern/subr_witness.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 14:56:00 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A5BF16A41F; Thu, 20 Oct 2005 14:56:00 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7519143D62; Thu, 20 Oct 2005 14:55:59 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Thu, 20 Oct 2005 11:12:26 -0400 From: John Baldwin To: Scott Long Date: Thu, 20 Oct 2005 10:53:01 -0400 User-Agent: KMail/1.8.2 References: <200510172310.j9HNAVPL013057@repoman.freebsd.org> <200510200958.09182.jhb@freebsd.org> <4357AAFE.2070002@samsco.org> In-Reply-To: <4357AAFE.2070002@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510201053.03881.jhb@freebsd.org> Cc: src-committers@freebsd.org, Andrew Gallatin , Bruce Evans , cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 14:56:00 -0000 On Thursday 20 October 2005 10:34 am, Scott Long wrote: > John Baldwin wrote: > > On Thursday 20 October 2005 01:45 am, Bruce Evans wrote: > >>On Tue, 18 Oct 2005, Scott Long wrote: > >>I use 100 and never downgraded to use 1000 except for testing how bad > >>it is. The default number is now up to * 2 * HZ. > >>E.g., it is 4000 on sledge.freebsd.org. While 4000 interrupts/sec can > >>be handled easily by any new machine, 4000 is a disgustingly large > >>number to use for clock interrupts. Have a look at vmstat -i output > >>on almost any machine. On most machines in the freebsd cluster, the > >>total number of interrupts is dominated by clock interrupts even with > >>HZ = 100. > > > > Note that on 4.x you don't get to see the interrupt counts for the hz + > > stathz * (cpus - 1) IPIs for all the clock interrupts, so in real > > numbers, each CPU has gone from hz + stathz to hz * 2 interrupts. > > However, the higher number is offset by the fact that the interrupt > > handler for the lapic case doesn't have to touch any hardware, and it > > also works much more reliably (getting irq0 to work in APIC mode on some > > amd64 nvidia chipsets required several quirks, and future motherboards > > will probably continue to require quirks since Windows uses the APIC > > timer in APIC mode and doesn't require irq0 to work in APIC mode). > > I'm in complete argreement that using the APIC timer is the right thing > to do, and I believe that we did some tests to show that the high > interrupt rate didn't have an appreciable effect on performance. > However, I'd like to revisit the HZ=1000 decision for 7-CURRENT. > > Scott Agreed. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Oct 20 15:21:32 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC57816A420; Thu, 20 Oct 2005 15:21:32 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB39843D62; Thu, 20 Oct 2005 15:21:31 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j9KFI4Iq010425; Thu, 20 Oct 2005 09:18:04 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 20 Oct 2005 09:19:25 -0600 (MDT) Message-Id: <20051020.091925.109166235.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <4357AAFE.2070002@samsco.org> References: <20051020145234.H99720@delplex.bde.org> <200510200958.09182.jhb@freebsd.org> <4357AAFE.2070002@samsco.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Thu, 20 Oct 2005 09:18:06 -0600 (MDT) Cc: src-committers@freebsd.org, jhb@freebsd.org, bde@zeta.org.au, cvs-src@freebsd.org, cvs-all@freebsd.org, davidxu@freebsd.org, gallatin@cs.duke.edu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 15:21:32 -0000 In message: <4357AAFE.2070002@samsco.org> Scott Long writes: : However, I'd like to revisit the HZ=1000 decision for 7-CURRENT. At Timing Solutions, we run with HZ=1000 to reduce the latency for interacting with serial devices (since we have highly synchronous protocols that are spoken over them). Other than that, we've seen no performance differences between HZ=100 and HZ=1000 in other areas of our systems. We have noted a small increase in overhead with 1000, but since we have plenty of CPU to burn, we burn a little to get better latencies... We'll likely tune the number based on our experience, so changing the default HZ won't impact us. Warner From owner-cvs-src@FreeBSD.ORG Thu Oct 20 15:24:28 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E9CA16A420; Thu, 20 Oct 2005 15:24:28 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2DA543D8B; Thu, 20 Oct 2005 15:24:18 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j9KFNLrH010481; Thu, 20 Oct 2005 09:23:21 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 20 Oct 2005 09:24:42 -0600 (MDT) Message-Id: <20051020.092442.32432175.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <25112.1129812291@critter.freebsd.dk> References: <20051020211131.A874@delplex.bde.org> <25112.1129812291@critter.freebsd.dk> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Thu, 20 Oct 2005 09:23:22 -0600 (MDT) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, andre@freebsd.org, cvs-all@freebsd.org, bde@zeta.org.au Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 15:24:28 -0000 In message: <25112.1129812291@critter.freebsd.dk> "Poul-Henning Kamp" writes: : This means that there is no way to tell which side of an inserted : leapsecond a time(2) timestamp comes from: : : UTC time(2) : 23:59:57 N-3 : 23:59:58 N-2 : 23:59:59 N-1 : 23:59:60 N : 00:00:00 N : 00:00:01 N+1 Actually, time goes like the following near a leap second: 23:59:57 N-3 23:59:58 N-2 23:59:59 N-1 23:59:60 N-1 00:00:00 N 00:00:01 N+1 although mktime() will turn the above times into the sequence that you posted, mostly because POSIX didn't grok that the leap second was added to the end of the prior day, not the beginning of the next day. They mandated 'just normalize it' behavior which is sadly wrong. Ntp mandates the latter, so that's what we do over a leap second for system time. : Worst case, difftime() will be wrong by two seconds: taking the difference : from one leapsecond to another and guessing wrong in both ends. However, this nit doesn't change your main point. Warner From owner-cvs-src@FreeBSD.ORG Thu Oct 20 15:44:12 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A0C9416A41F; Thu, 20 Oct 2005 15:44:12 +0000 (GMT) (envelope-from frank@exit.com) Received: from tinker.exit.com (tinker.exit.com [206.223.0.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B0F543D68; Thu, 20 Oct 2005 15:44:11 +0000 (GMT) (envelope-from frank@exit.com) Received: from realtime.exit.com (realtime [206.223.0.5]) by tinker.exit.com (8.13.4/8.13.4) with ESMTP id j9KFiB1D073858; Thu, 20 Oct 2005 08:44:11 -0700 (PDT) (envelope-from frank@exit.com) Received: from realtime.exit.com (localhost [127.0.0.1]) by realtime.exit.com (8.13.4/8.13.4) with ESMTP id j9KFiA0i023316; Thu, 20 Oct 2005 08:44:10 -0700 (PDT) (envelope-from frank@exit.com) Received: (from frank@localhost) by realtime.exit.com (8.13.4/8.13.4/Submit) id j9KFiAf7023315; Thu, 20 Oct 2005 08:44:10 -0700 (PDT) (envelope-from frank@exit.com) X-Authentication-Warning: realtime.exit.com: frank set sender to frank@exit.com using -f From: Frank Mayhar To: Gleb Smirnoff In-Reply-To: <200510200846.j9K8kidE069993@repoman.freebsd.org> References: <200510200846.j9K8kidE069993@repoman.freebsd.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Exit Consulting Date: Thu, 20 Oct 2005 08:44:10 -0700 Message-Id: <1129823050.22346.4.camel@realtime.exit.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 FreeBSD GNOME Team Port X-Virus-Scanned: ClamAV 0.86.2/1145/Thu Oct 20 05:01:39 2005 on tinker.exit.com X-Virus-Status: Clean Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: frank@exit.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 15:44:12 -0000 On Thu, 2005-10-20 at 08:46 +0000, Gleb Smirnoff wrote: > glebius 2005-10-20 08:46:44 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c if_em.h if_em_hw.h > Log: > Revamp interrupt handling in em(4) driver: > > This fixes em(4) interfaces wedging under high load. Yay! I very much hope that this will get into 6.0 before release. This problem has been making me seriously consider tossing my Intel NICs as they've been almost unusable due to this problem. This fix will make my life a lot easier. -- Frank Mayhar frank@exit.com http://www.exit.com/ Exit Consulting http://www.gpsclock.com/ http://www.exit.com/blog/frank/ From owner-cvs-src@FreeBSD.ORG Thu Oct 20 15:46:29 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AFE6916A41F; Thu, 20 Oct 2005 15:46:29 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5602943D5A; Thu, 20 Oct 2005 15:46:29 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id E875846C32; Thu, 20 Oct 2005 11:46:28 -0400 (EDT) Date: Thu, 20 Oct 2005 16:46:28 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: "M. Warner Losh" In-Reply-To: <20051020.091925.109166235.imp@bsdimp.com> Message-ID: <20051020164246.O28249@fledge.watson.org> References: <20051020145234.H99720@delplex.bde.org> <200510200958.09182.jhb@freebsd.org> <4357AAFE.2070002@samsco.org> <20051020.091925.109166235.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: scottl@samsco.org, src-committers@freebsd.org, jhb@freebsd.org, bde@zeta.org.au, cvs-src@freebsd.org, cvs-all@freebsd.org, davidxu@freebsd.org, gallatin@cs.duke.edu Subject: Re: cvs commit: src/sys/amd64/amd64 cpu_switch.S machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 15:46:29 -0000 On Thu, 20 Oct 2005, M. Warner Losh wrote: > In message: <4357AAFE.2070002@samsco.org> > Scott Long writes: > : However, I'd like to revisit the HZ=1000 decision for 7-CURRENT. > > At Timing Solutions, we run with HZ=1000 to reduce the latency for > interacting with serial devices (since we have highly synchronous > protocols that are spoken over them). Other than that, we've seen no > performance differences between HZ=100 and HZ=1000 in other areas of our > systems. We have noted a small increase in overhead with 1000, but > since we have plenty of CPU to burn, we burn a little to get better > latencies... We'll likely tune the number based on our experience, so > changing the default HZ won't impact us. I've seen reports of TCP improvements as a result of more precise timing, but I've also seen reports of minor performance reduction as a result of the increased overhead. Some of the problems here were reduced by removing naive uses of callouts that ran every tick in order to run their own job scheduler which then selected to run jobs only every now and then. This still exists in some of the RPC-related code in NFS, and needs to be addressed. It's also important for Xen, because in Xen it's desirable to only run per-domain clock ticks if there's work to do, so there are optimizations in Xen to use programmable timers for callouts rather than running them frequently in order to avoid having to run all the domains every time a timer tick fires. Revisiting the 1000hz decision does make sense, but there are real trade-offs here: higher accuracy in timing potentially improves the behavior of retransmission and drop detection for network services in high performance environments. With time scales on packet processing events being on the order of a millionth of a second, things are a lot different than previously. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Thu Oct 20 16:03:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A52D16A41F; Thu, 20 Oct 2005 16:03:15 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD40443D80; Thu, 20 Oct 2005 16:03:13 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9KG3BX8020220; Fri, 21 Oct 2005 02:03:11 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9KG38w8004750; Fri, 21 Oct 2005 02:03:09 +1000 Date: Fri, 21 Oct 2005 02:03:09 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <25112.1129812291@critter.freebsd.dk> Message-ID: <20051021011035.T1945@delplex.bde.org> References: <25112.1129812291@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 16:03:15 -0000 On Thu, 20 Oct 2005, Poul-Henning Kamp wrote: > In message <20051020211131.A874@delplex.bde.org>, Bruce Evans writes: > >> POSIX's specification of CLOCK_MONOTONIC seems to be missing leap seconds >> problems. It seems to be required to actually work; thus it should give >> the difference in real time, in seconds with nanoseconds resolution, >> relative to its starting point, so it must include leap seconds. > > It doesn't make sense to talk about a leap seconds on a timescale > which is not UTC because leap-seconds by definition only exist in UTC. That's true for time_t's, but for differences between times there is no UTC (or time_t's). Leap seconds (if they happen) are just ordinary seconds in differences. > CLOCK_MONOTONIC is defined as a count of seconds (lets tacitly > assume they mean SI seconds here) from an arbitrary origin. > > A better and unambiguous way to write that would have been: > > CLOCK_MONOTONIC = TAI + alpha > > It follows from this that CLOCK_MONOTONIC does not know what a > leap-second is and doesn't notice them happening. Same for difftime(). Even if time_t is specified to be broken, difftime() doesn't have to be; it can handle leap seconds just as uneasily as localtime(). > Because of our particular choice of alpha, CLOCK_MONOTONIC is also > a very convenient measure of how many seconds the kernel has been > running. But slightly wrong. >> Of course it can't reasonably be expected to have nanoseconds accuracy. >> [...] > > It certainly can and should be expected to and it does. Nah, it only has nanoseconds precision, since reading timecounters takes several nanosecond (several hundred for the ACPI timecounter) and you can't control the timing of the start of the read. >> difftime() also seems to be required to actually work. According to >> draft C99 (n869.txt): >> >> % [#2] The difftime function computes the difference between >> % two calendar times: time1 - time0. > > Again, this is another example of computer-geeks missing the finer > points in timekeeping. > > The word "calendar" refers to things counting time in units of days. > > The above text therefore conveys no usable information about how > leap-seconds should be accounted for, since leap seconds by definition > are intra-day. It's supposed to be an informal definition, since the details are large and belong in a more specialized standard. >> [clarification from other standard that the two time_t comes from time(2)] > >> time_t's cannot be naively subtracted in general in C, so the difference >> here must be formal. The difference is required to contain leap seconds >> by POLA. > > Yeah, right: in your dreams... In localtime.c. > You can by definition not implment difftime correctly since the > time_t timescale does not contain any indication of leapseconds. > > This means that there is no way to tell which side of an inserted > leapsecond a time(2) timestamp comes from: > > UTC time(2) > 23:59:57 N-3 > 23:59:58 N-2 > 23:59:59 N-1 > 23:59:60 N > 00:00:00 N > 00:00:01 N+1 > > Worst case, difftime() will be wrong by two seconds: taking the difference > from one leapsecond to another and guessing wrong in both ends. It only has to be wrong by 1 or 2 seconds for short intervals when a leap seconds occurs. Not adjusting makes difftime() wrong across all intervals containing a leap second, with an error of the number of leap seconds in the interval (+- 1 or 2 for leap seconds at endpoints). > The fact that mktime() and timegm() gets it wrong the other way because > of DWIM logic is merely ising on the cake. > >> Back to the utilities: according to the standards, it seems to be equally >> correct to implement "double uptime()" as: >> >> /* Done in kernel; happens to give 0 in FreeBSD implementation: */ >> clock_gettime(CLOCK_MONOTONIC, &boottime); >> >> clock_gettime(CLOCK_MONOTONIC, &now); >> >> return (now.tv_sec - boottime.tv_sec + >> 1e-9 * (now.tv_nsec - boottime.tv_nsec); > > On FreeBSD this delivers the correct answer. Nope. As I already explained, this drifts at the same rate as CLOCK_REALTIME (possibly 0 on average if you correct the drift using micro-adjustments (*adjtime*()). Then stepping the clock using a macro-adjustment (*settime*()) may fix the drift in CLOCK_REALTIME but always leaves it in CLOCK_MONOTONIC. >> and as: >> >> /* Done in kernel; nonzero except if you booted in 1970: */ >> clock_gettime(CLOCK_REALTIME, &boottime); >> >> clock_gettime(CLOCK_REALTIME, &now); >> >> /* Restore leap seconds if necessary; lose nanoseconds resolution: */ >> return difftime(now.tv_sec, boottime.tv_sec); > > This suffers from the +/-2 second error from difftime(2) and will > return the wrong result if the clock is stepped. The errors from stepping are because stepping bogusly changes `boottime' so as to make adjkerntz -i and old implementations of uptime() work. Changing boottime is bogus because the boot time is whatever it is; it doesn't change just because the clock drifts after booting and is fixed later by stepping it. Adjusting boottime makes both methods have the same error from stepping. Bruce From owner-cvs-src@FreeBSD.ORG Thu Oct 20 16:31:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C324D16A41F; Thu, 20 Oct 2005 16:31:55 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9724343D5A; Thu, 20 Oct 2005 16:31:55 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KGVt2g006195; Thu, 20 Oct 2005 16:31:55 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KGVt9i006194; Thu, 20 Oct 2005 16:31:55 GMT (envelope-from wpaul) Message-Id: <200510201631.j9KGVt9i006194@repoman.freebsd.org> From: Bill Paul Date: Thu, 20 Oct 2005 16:31:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: MALINEN Cc: Subject: cvs commit: src/contrib/wpa_supplicant - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 16:31:55 -0000 wpaul 2005-10-20 16:31:55 UTC FreeBSD src repository src/contrib/wpa_supplicant - Imported sources Update of /home/ncvs/src/contrib/wpa_supplicant In directory repoman.freebsd.org:/tmp/cvs-serv6153 Log Message: Import a fixed version of driver_ndis.c from the vendor. The existing version has a bug where it fails to properly cancel the polling loop that periodically queries the BSSID (this is done to detect the association/disassociation state). The timeout is supposed to fire once a second, but the eloop_cancel_timeout() call uses a different 'user data' value than what was passed to eloop_register_timeout(), so cancelling the timeouts fails. This results in an additional timeout being created each time an EAPOL packet is received, which can lead to dozens of unwanted timeouts firing every second instead of just one. Status: Vendor Tag: MALINEN Release Tags: v0_3_latest U src/contrib/wpa_supplicant/driver_ndis.c No conflicts created by this import From owner-cvs-src@FreeBSD.ORG Thu Oct 20 16:39:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 35D3C16A41F; Thu, 20 Oct 2005 16:39:34 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E7B1F43D5A; Thu, 20 Oct 2005 16:39:33 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KGdX72006627; Thu, 20 Oct 2005 16:39:33 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KGdXZa006626; Thu, 20 Oct 2005 16:39:33 GMT (envelope-from rwatson) Message-Id: <200510201639.j9KGdXZa006626@repoman.freebsd.org> From: Robert Watson Date: Thu, 20 Oct 2005 16:39:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 16:39:34 -0000 rwatson 2005-10-20 16:39:33 UTC FreeBSD src repository Modified files: sys/vm uma_core.c Log: Add a "show uma" command to DDB, which prints out the current stats for available UMA zones. Quite useful for post-mortem debugging of memory leaks without a dump device configured on a panicked box. MFC after: 2 weeks Revision Changes Path 1.132 +36 -0 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 16:49:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37DA816A420; Thu, 20 Oct 2005 16:49:32 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF86C43D62; Thu, 20 Oct 2005 16:49:31 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KGnV5q014179; Thu, 20 Oct 2005 16:49:31 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KGnVdx014178; Thu, 20 Oct 2005 16:49:31 GMT (envelope-from wpaul) Message-Id: <200510201649.j9KGnVdx014178@repoman.freebsd.org> From: Bill Paul Date: Thu, 20 Oct 2005 16:49:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/wpa/wpa_supplicant Packet32.c Packet32.h ntddndis.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 16:49:32 -0000 wpaul 2005-10-20 16:49:31 UTC FreeBSD src repository Modified files: usr.sbin/wpa/wpa_supplicant Packet32.c Packet32.h ntddndis.h Log: Implement the PacketGetVersion() routine, which is used in the 0.4.x versions of wpa_supplicant. Revision Changes Path 1.2 +6 -0 src/usr.sbin/wpa/wpa_supplicant/Packet32.c 1.2 +1 -0 src/usr.sbin/wpa/wpa_supplicant/Packet32.h 1.2 +1 -0 src/usr.sbin/wpa/wpa_supplicant/ntddndis.h From owner-cvs-src@FreeBSD.ORG Thu Oct 20 17:10:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24C6416A41F; Thu, 20 Oct 2005 17:10:22 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D63CD43D62; Thu, 20 Oct 2005 17:10:21 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KHALBb015037; Thu, 20 Oct 2005 17:10:21 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KHALEW015036; Thu, 20 Oct 2005 17:10:21 GMT (envelope-from wpaul) Message-Id: <200510201710.j9KHALEW015036@repoman.freebsd.org> From: Bill Paul Date: Thu, 20 Oct 2005 17:10:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/usr.sbin/ndiscvt Makefile ndisgen.8 ndisgen.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 17:10:22 -0000 wpaul 2005-10-20 17:10:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) usr.sbin/ndiscvt Makefile ndisgen.8 ndisgen.sh Log: MFC updates from the head: - install ndisgen.8 man page - fixes for ndisgen.8 man page - fixes for ndisgen.sh script to make it work correctly on amd64 and various documentation cleanups Revision Changes Path 1.5.2.2 +1 -0 src/usr.sbin/ndiscvt/Makefile 1.1.2.2 +12 -7 src/usr.sbin/ndiscvt/ndisgen.8 1.1.2.2 +158 -99 src/usr.sbin/ndiscvt/ndisgen.sh From owner-cvs-src@FreeBSD.ORG Thu Oct 20 17:41:48 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 168EB16A41F; Thu, 20 Oct 2005 17:41:48 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA22643D64; Thu, 20 Oct 2005 17:41:47 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KHflYx016525; Thu, 20 Oct 2005 17:41:47 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KHflpn016524; Thu, 20 Oct 2005 17:41:47 GMT (envelope-from rwatson) Message-Id: <200510201741.j9KHflpn016524@repoman.freebsd.org> From: Robert Watson Date: Thu, 20 Oct 2005 17:41:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_malloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 17:41:48 -0000 rwatson 2005-10-20 17:41:47 UTC FreeBSD src repository Modified files: sys/kern kern_malloc.c Log: Add a "show malloc" command to DDB, which prints out the current stats for available kernel malloc types. Quite useful for post-mortem debugging of memory leaks without a dump device configured on a panicked box. MFC after: 2 weeks Revision Changes Path 1.147 +27 -0 src/sys/kern/kern_malloc.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 17:45:59 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4561E16A41F; Thu, 20 Oct 2005 17:45:59 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03FE943D64; Thu, 20 Oct 2005 17:45:59 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KHjwNR016820; Thu, 20 Oct 2005 17:45:58 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KHjwkV016819; Thu, 20 Oct 2005 17:45:58 GMT (envelope-from wpaul) Message-Id: <200510201745.j9KHjwkV016819@repoman.freebsd.org> From: Bill Paul Date: Thu, 20 Oct 2005 17:45:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 17:45:59 -0000 wpaul 2005-10-20 17:45:58 UTC FreeBSD src repository Modified files: sys/compat/ndis subr_ntoskrnl.c Log: Use sched_bind() to make sure the DPC threads are bound to the correct processor, to insure DPC thread 0 runs on CPU0, DPC thread 1 runs on CPU1, and so on. Elevate the priority of the workitem threads, though don't use as high a priority as the DPC threads. Revision Changes Path 1.75 +15 -1 src/sys/compat/ndis/subr_ntoskrnl.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 17:52:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E68D16A41F; Thu, 20 Oct 2005 17:52:29 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8390543D64; Thu, 20 Oct 2005 17:52:27 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KHqRab017253; Thu, 20 Oct 2005 17:52:27 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KHqRdG017252; Thu, 20 Oct 2005 17:52:27 GMT (envelope-from wpaul) Message-Id: <200510201752.j9KHqRdG017252@repoman.freebsd.org> From: Bill Paul Date: Thu, 20 Oct 2005 17:52:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/compat/ndis kern_ndis.c kern_windrv.c ndis_var.h ntoskrnl_var.h subr_hal.c subr_ndis.c subr_ntoskrnl.c winx32_wrap.S src/sys/dev/if_ndis if_ndis.c if_ndisvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 17:52:29 -0000 wpaul 2005-10-20 17:52:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/compat/ndis kern_ndis.c kern_windrv.c ndis_var.h ntoskrnl_var.h subr_hal.c subr_ndis.c subr_ntoskrnl.c winx32_wrap.S sys/dev/if_ndis if_ndis.c if_ndisvar.h Log: MFC all the updates from the HEAD Revision Changes Path 1.60.2.7 +193 -133 src/sys/compat/ndis/kern_ndis.c 1.3.2.4 +29 -27 src/sys/compat/ndis/kern_windrv.c 1.29.2.5 +131 -13 src/sys/compat/ndis/ndis_var.h 1.17.2.8 +118 -38 src/sys/compat/ndis/ntoskrnl_var.h 1.13.2.5 +88 -22 src/sys/compat/ndis/subr_hal.c 1.67.2.9 +418 -314 src/sys/compat/ndis/subr_ndis.c 1.43.2.8 +1123 -474 src/sys/compat/ndis/subr_ntoskrnl.c 1.2.2.2 +20 -4 src/sys/compat/ndis/winx32_wrap.S 1.69.2.8 +1094 -216 src/sys/dev/if_ndis/if_ndis.c 1.15.2.4 +80 -13 src/sys/dev/if_ndis/if_ndisvar.h From owner-cvs-src@FreeBSD.ORG Thu Oct 20 18:13:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B41616A41F; Thu, 20 Oct 2005 18:13:11 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB34943D62; Thu, 20 Oct 2005 18:13:10 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j9KIBwrk012132; Thu, 20 Oct 2005 12:11:59 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 20 Oct 2005 12:13:18 -0600 (MDT) Message-Id: <20051020.121318.117917917.imp@bsdimp.com> To: bde@zeta.org.au From: "M. Warner Losh" In-Reply-To: <20051021011035.T1945@delplex.bde.org> References: <25112.1129812291@critter.freebsd.dk> <20051021011035.T1945@delplex.bde.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Thu, 20 Oct 2005 12:12:01 -0600 (MDT) Cc: cvs-src@FreeBSD.org, phk@phk.freebsd.dk, src-committers@FreeBSD.org, andre@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 18:13:11 -0000 In message: <20051021011035.T1945@delplex.bde.org> Bruce Evans writes: : > You can by definition not implment difftime correctly since the : > time_t timescale does not contain any indication of leapseconds. : > : > This means that there is no way to tell which side of an inserted : > leapsecond a time(2) timestamp comes from: : > : > UTC time(2) : > 23:59:57 N-3 : > 23:59:58 N-2 : > 23:59:59 N-1 : > 23:59:60 N : > 00:00:00 N : > 00:00:01 N+1 : > : > Worst case, difftime() will be wrong by two seconds: taking the difference : > from one leapsecond to another and guessing wrong in both ends. : : It only has to be wrong by 1 or 2 seconds for short intervals when a leap : seconds occurs. Not adjusting makes difftime() wrong across all intervals : containing a leap second, with an error of the number of leap seconds in : the interval (+- 1 or 2 for leap seconds at endpoints). Where do you keep the table of leapseconds? How do you make sure it gets updated? As far as I know, there's no installed leap second data on the system, unless you've enabled the 'run in TAI instead of UTC' mode. Leaving aside the leap table issue for the moment, there's a more fundamental problem. You cannot possibly compute correct answers for times that are in the future, even a little ways in the future. What if time1 is June 30, 2006 23:59:58 and time2 is July 1, 2006 00:00:01. While neither of these seconds are ambiguous, no one on the planet can say today, with certainty, what the answer will be. We have to wait until early January when IERS issues the next Bulletin C. You cannot know today if the right answer is 2, 3 or 4. If there's a negative leap second at the end of June 30, then the answer is 2, if there's no leap second the answer is 3, if there is a positive leap second, the answer is 4. One can only predict what might happen. Until 6 months before the leap second, no one knows what the schedule will be. Have I mentioned my extreme and abiding love for leap seconds lately? Now you know why :-) Warner From owner-cvs-src@FreeBSD.ORG Thu Oct 20 18:33:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1824316A41F; Thu, 20 Oct 2005 18:33:47 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA33343D5A; Thu, 20 Oct 2005 18:33:46 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KIXkxr019158; Thu, 20 Oct 2005 18:33:46 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KIXkjw019157; Thu, 20 Oct 2005 18:33:46 GMT (envelope-from wpaul) Message-Id: <200510201833.j9KIXkjw019157@repoman.freebsd.org> From: Bill Paul Date: Thu, 20 Oct 2005 18:33:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/wpa/ndis_events ndis_events.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 18:33:47 -0000 wpaul 2005-10-20 18:33:46 UTC FreeBSD src repository Modified files: usr.sbin/wpa/ndis_events ndis_events.8 Log: Fix small grammar nit. Revision Changes Path 1.3 +1 -1 src/usr.sbin/wpa/ndis_events/ndis_events.8 From owner-cvs-src@FreeBSD.ORG Thu Oct 20 19:23:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F87B16A420; Thu, 20 Oct 2005 19:23:20 +0000 (GMT) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70C0143D82; Thu, 20 Oct 2005 19:23:16 +0000 (GMT) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KJNG4h021299; Thu, 20 Oct 2005 19:23:16 GMT (envelope-from brooks@repoman.freebsd.org) Received: (from brooks@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KJNG7H021298; Thu, 20 Oct 2005 19:23:16 GMT (envelope-from brooks) Message-Id: <200510201923.j9KJNG7H021298@repoman.freebsd.org> From: Brooks Davis Date: Thu, 20 Oct 2005 19:23:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/vipw vipw.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 19:23:20 -0000 brooks 2005-10-20 19:23:16 UTC FreeBSD src repository Modified files: usr.sbin/vipw vipw.8 Log: Mention the possibility of non-interactive scripts for EDITOR and add a BUGS section mentioning the requirement that such scripts run "sleep 1" or equivalent to work reliably. Revision Changes Path 1.15 +9 -0 src/usr.sbin/vipw/vipw.8 From owner-cvs-src@FreeBSD.ORG Thu Oct 20 20:30:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2144316A488; Thu, 20 Oct 2005 20:30:52 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D45E643D5A; Thu, 20 Oct 2005 20:30:51 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KKUp1v024116; Thu, 20 Oct 2005 20:30:51 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KKUp6t024115; Thu, 20 Oct 2005 20:30:51 GMT (envelope-from cognet) Message-Id: <200510202030.j9KKUp6t024115@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 20 Oct 2005 20:30:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/xscale/i80321 i80321_space.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 20:30:52 -0000 cognet 2005-10-20 20:30:51 UTC FreeBSD src repository Modified files: sys/arm/xscale/i80321 i80321_space.c Log: Cleanup. Revision Changes Path 1.4 +1 -13 src/sys/arm/xscale/i80321/i80321_space.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 20:40:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4D5216A41F; Thu, 20 Oct 2005 20:40:42 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from heff.fud.org.nz (60-234-149-201.bitstream.orcon.net.nz [60.234.149.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3094343D7F; Thu, 20 Oct 2005 20:40:41 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: by heff.fud.org.nz (Postfix, from userid 1001) id C561E1CCE5; Fri, 21 Oct 2005 09:40:40 +1300 (NZDT) Date: Fri, 21 Oct 2005 09:40:40 +1300 From: Andrew Thompson To: SUZUKI Shinsuke Message-ID: <20051020204040.GA53853@heff.fud.org.nz> References: <200510201149.j9KBnPNK086704@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510201149.j9KBnPNK086704@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 raw_ip6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 20:40:42 -0000 On Thu, Oct 20, 2005 at 11:49:25AM +0000, SUZUKI Shinsuke wrote: > suz 2005-10-20 11:49:25 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/netinet6 raw_ip6.c > Log: > MFC 1.56 (added a missing unlock) > > Approved by: re(scottl) > Did you intend to commit to RELENG_6_0 too? Andrew From owner-cvs-src@FreeBSD.ORG Thu Oct 20 20:51:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C705316A420; Thu, 20 Oct 2005 20:51:31 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94E9943D76; Thu, 20 Oct 2005 20:51:30 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KKpULV032793; Thu, 20 Oct 2005 20:51:30 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KKpUtV032792; Thu, 20 Oct 2005 20:51:30 GMT (envelope-from ru) Message-Id: <200510202051.j9KKpUtV032792@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 20 Oct 2005 20:51:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 20:51:32 -0000 ru 2005-10-20 20:51:30 UTC FreeBSD src repository Modified files: sys/conf files Log: Remove duplicate entry. Revision Changes Path 1.1059 +0 -1 src/sys/conf/files From owner-cvs-src@FreeBSD.ORG Thu Oct 20 21:04:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 75A4B16A41F; Thu, 20 Oct 2005 21:04:21 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA03343D66; Thu, 20 Oct 2005 21:04:20 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id A86E9BC7A; Thu, 20 Oct 2005 21:04:17 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 21 Oct 2005 02:03:09 +1000." <20051021011035.T1945@delplex.bde.org> Date: Thu, 20 Oct 2005 23:04:16 +0200 Message-ID: <27345.1129842256@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 21:04:21 -0000 I can see that Warner has already handled some of the necessary rebuttals so I will not repeat his arguments apart from noting my agreement that leapseconds are evil and should be abandonned as soon as possible. But let me step back a bit and explain the rationale for the way we keep time in FreeBSD, as a means for clearing up some of the confusion which the discussion between Bruce and me have caused. The first thing to remember is that a clock consists of a frequency source and a counter. The counter is trivial [1], you can do it with any technology and get it right, it's the frequency source which is the tricky bit. So our hardest task is to decide how long we think seconds are. Initially we trust the timecount hardware to know this (some of them autocalibrate) but we take corrections from NTPD and other programs via a specialized group of syscalls, because unless the computer has timecounting hardware driven by a primary frequency standard (Cesium or a steered oscillator) corrections are necessary to get the length of seconds right. But we also need to get the counter synchronized with UTC. If the length of our seconds is perfect, we need to do this only once. If the length of our seconds are not perfect, the phase error will become non-zero, and we can either fix this with a correction to the phase, a time step, or we do it by overcorrection of the frequency (the length of our seconds) for a period of time until we have regained or lost the phase synchronization. If we are able to estimate the frequency error, we can of course apply the correction predictively. Hardware or software, like NTPD, which does all of the above three are called a second order Phase Locked Loop ("a PLL"), and has a lot of mathematical theory hidden in dusty textbooks. If people do stupid things like use hard steps (*settime*()) to correct rate problems, then they get what they deserve, including potentially backwards jumps in time, but the integral over time of all steps apart from the first one amounts to a rate correction. When NTPD is running it gives the kernel gets a rate correction which is really mix of a corrective phase adjustment, a corrective rate adjustment and a predictve rate adjustment. The math works out the same however: leaving out the first phase adjustment (which is usually handled by a step anyway) the integral over time of the sum of the phase and rate adjustments is the true rate correction [2]. Adjtime() is a middle case, it implements a phase step but spreads it out over time (by doing frequency corrections) to avoid large gaps or backwards steps in the CLOCK_REALTIME timescale. Adjtime() is used by various time synchronization tools which doesn't do rate estimation at all but rather implements occational phase synchronization using these "soft steps". Again repeated phase synchronization amounts to crude frequency steering, and therefore again, the integral over time is our best estimate of SI second duration. But as I said: timekeeping in all forms consists of getting the phase right the first time, and keeping the frequency right (on average) afterwards and there is no escaping this basic mathematical fact because you can't go back and remeasure the past. FreeBSD incorporates everything but the hard steps into the CLOCK_MONOTONIC timescale, because over time, the integral of those corrections are our best estimate of the correct length of SI seconds. It can be argued that any hard steps after the second should be factored in as well, but in practice subsequent hard steps are either to correct mistakes in the initial hard step or so infrequent that averaging out the corrections doesn't make sense, so we treat all hard steps as phase only corrections. In summary: CLOCK_MONOTONIC is our best estimate of how many SI seconds the system have been runing [3]. Given that CLOCK_MONOTONIC is our best guess how long the kernel has been running, it follows that CLOCK_REALTIME - CLOCK_MONOTONIC must be our best estimate of what time the kernel booted. CLOCK_REALTIME aka. UTC is therefore maintained in FreeBSD by keeping around our best estimate of when the system booted in UTC time and adding CLOCK_MONOTONIC to it. Hard phase steps are implemented by changing our boottime estimate according to the desired step. The only snag in this is that leapsecond does not exist in CLOCK_REALTIME, but they very much exist in the real world. We deal with (ie: ignore) leap seconds by either replaying or skipping a second on the CLOCK_REALTIME timescale [5], and in order to make the math come out right, we do that by adjusting boottime one second either way. This is technically wrong, and will mean that the boottime estimate is wrong by the number of leapseconds the system has experienced while running. Considering that leapseconds happen once every 500 days or so and that POSIX found them so insignificant that they just defined them out of existence as far as computers go, I have no problem with this approximation. Conclusion: Provided root doesn't go out of his way to muck it up, timekeeping in FreeBSD will Do The Right Thing, and do it a fair bit better and with higher precicion than any other operating system. If you want to know how long time the system has been running, CLOCK_MONOTONIC is the best number you will get. Footnotes: [1] Actually, as leapseconds have proven it is possible for a highly skilled group of scientists to get the counting part wrong also. [2] Because NTPD implements a 2nd order PLL, the integral over time of the phase adjustment alone is the frequency drift divided by the PLL timeconstant, a number which is lost in the noise unless you have an hi-quality OCXO or better timebase. [3] As Bruce has correctly pointed out, if the root plays silly buggers with time management systemcalls, he can muck it up [4]. One way would be to apply a 500PPM frequency correction and step one second in the other direction every 2000 seconds. On average the clock would be right, but the CLOCK_MONOTONIC would be 500PPM wrong. [4] Toot could also do "killall -9 sh" or "rm -rf /", either of which would be both faster and more spectacular. [5] Warner is right: I got the actual sequence it wrong in my previous email. References: http://phk.freebsd.dk/pubs/timecounter.pdf -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Oct 20 21:28:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C2C716A41F; Thu, 20 Oct 2005 21:28:32 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 48D0A43D5A; Thu, 20 Oct 2005 21:28:32 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KLSWVn034631; Thu, 20 Oct 2005 21:28:32 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KLSWMQ034630; Thu, 20 Oct 2005 21:28:32 GMT (envelope-from rwatson) Message-Id: <200510202128.j9KLSWMQ034630@repoman.freebsd.org> From: Robert Watson Date: Thu, 20 Oct 2005 21:28:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_malloc.c src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 21:28:32 -0000 rwatson 2005-10-20 21:28:32 UTC FreeBSD src repository Modified files: sys/kern kern_malloc.c sys/vm uma_core.c Log: Change format string for u_int64_t to %ju from %llu, in order to use the correct format string on 64-bit systems. Pointed out by: pjd Revision Changes Path 1.148 +1 -1 src/sys/kern/kern_malloc.c 1.133 +1 -1 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 21:50:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D28916A41F; Thu, 20 Oct 2005 21:50:45 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A49CE43D5A; Thu, 20 Oct 2005 21:50:44 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9KLoi99035649; Thu, 20 Oct 2005 21:50:44 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9KLoinG035648; Thu, 20 Oct 2005 21:50:44 GMT (envelope-from jkim) Message-Id: <200510202150.j9KLoinG035648@repoman.freebsd.org> From: Jung-uk Kim Date: Thu, 20 Oct 2005 21:50:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/grep grep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 21:50:45 -0000 jkim 2005-10-20 21:50:44 UTC FreeBSD src repository Modified files: gnu/usr.bin/grep grep.c Log: Fix a longstanding buglet in bz-prefixed grep(1). Revision Changes Path 1.32 +5 -5 src/gnu/usr.bin/grep/grep.c From owner-cvs-src@FreeBSD.ORG Thu Oct 20 23:18:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A07EB16A41F; Thu, 20 Oct 2005 23:18:35 +0000 (GMT) (envelope-from suz@alaxala.net) Received: from pc1.alaxala.kame.net (kame219.kame.net [203.178.141.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0545543D68; Thu, 20 Oct 2005 23:18:34 +0000 (GMT) (envelope-from suz@alaxala.net) Received: from localhost (localhost [127.0.0.1]) by pc1.alaxala.kame.net (Postfix) with ESMTP id 56B8962A9; Fri, 21 Oct 2005 08:19:27 +0900 (JST) Received: from pc1.alaxala.kame.net ([127.0.0.1]) by localhost (pc1.alaxala.kame.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 85111-01; Fri, 21 Oct 2005 08:19:22 +0900 (JST) Received: from flora220.uki-uki.net (240.163.192.61.tokyo.global.alpha-net.ne.jp [61.192.163.240]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pc1.alaxala.kame.net (Postfix) with ESMTP id B5DE26203; Fri, 21 Oct 2005 08:19:20 +0900 (JST) Date: Fri, 21 Oct 2005 08:17:29 +0900 Message-ID: From: SUZUKI Shinsuke To: thompsa@freebsd.org X-cite: xcite 1.33 In-Reply-To: <20051020204040.GA53853@heff.fud.org.nz> References: <200510201149.j9KBnPNK086704@repoman.freebsd.org> <20051020204040.GA53853@heff.fud.org.nz> User-Agent: Wanderlust/2.15.1 (Almost Unreal) Emacs/22.0 Mule/5.0 (SAKAKI) Organization: Technical Marketing Dept., ALAXALA Networks Corporation MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: amavisd-new at alaxala.kame.net Cc: suz@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 raw_ip6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 23:18:35 -0000 >>>>> On Fri, 21 Oct 2005 09:40:40 +1300 >>>>> thompsa@freebsd.org(Andrew Thompson) said: > On Thu, Oct 20, 2005 at 11:49:25AM +0000, SUZUKI Shinsuke wrote: > > suz 2005-10-20 11:49:25 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/netinet6 raw_ip6.c > > Log: > > MFC 1.56 (added a missing unlock) > > > > Approved by: re(scottl) > > > > Did you intend to commit to RELENG_6_0 too? Ah, I forgot it... I'll commit to RELENG_6_0, too. Thanks, ---- SUZUKI, Shinsuke @ KAME Project From owner-cvs-src@FreeBSD.ORG Fri Oct 21 01:54:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78B2716A420; Fri, 21 Oct 2005 01:54:01 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0771D43D62; Fri, 21 Oct 2005 01:54:01 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9L1s0P6054678; Fri, 21 Oct 2005 01:54:00 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9L1s0uH054677; Fri, 21 Oct 2005 01:54:00 GMT (envelope-from njl) Message-Id: <200510210154.j9L1s0uH054677@repoman.freebsd.org> From: Nate Lawson Date: Fri, 21 Oct 2005 01:54:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 01:54:01 -0000 njl 2005-10-21 01:54:00 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_vfsops.c Log: Adjust maxfilesize for UFS1 and old 4.4 FFS. For UFS1, increase the limit to (max block - 1) * bsize. For DEV_BSIZE, this doubles the limit from 0.5 TB to 1 TB. For the old 4.4 FFS case, decrease the limit from 0.5 TB to 2 GB - 1. Older systems had a 32 bit off_t so they couldn't access the larger files anyway. Collaboration with: bde Revision Changes Path 1.295 +2 -2 src/sys/ufs/ffs/ffs_vfsops.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 05:23:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E5A216A41F; Fri, 21 Oct 2005 05:23:21 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0DD1143D46; Fri, 21 Oct 2005 05:23:21 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9L5NK8o070835; Fri, 21 Oct 2005 05:23:20 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9L5NKKK070834; Fri, 21 Oct 2005 05:23:20 GMT (envelope-from wpaul) Message-Id: <200510210523.j9L5NKKK070834@repoman.freebsd.org> From: Bill Paul Date: Fri, 21 Oct 2005 05:23:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/ndis ntoskrnl_var.h subr_hal.c subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 05:23:21 -0000 wpaul 2005-10-21 05:23:20 UTC FreeBSD src repository Modified files: sys/compat/ndis ntoskrnl_var.h subr_hal.c subr_ntoskrnl.c Log: Correct the macro definition for KeRaiseIrql(). The official API is KeRaiseIrql(newirql, &oldirql), not oldirql = KeRaiseIrql(newirql). (The macro ultimately translates to KfRaiseIrql() which does use the latter API, so this has no effect on generated code.) Also, wait for thread termination the right way: kthread_exit() will ultimately do a wakeup(td->td_proc). This is the event we should wait on. Eliminate the previous synchronization machinery for this since it was never guaranteed to work correctly. Revision Changes Path 1.40 +2 -2 src/sys/compat/ndis/ntoskrnl_var.h 1.26 +1 -1 src/sys/compat/ndis/subr_hal.c 1.76 +5 -22 src/sys/compat/ndis/subr_ntoskrnl.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 05:29:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 394F216A41F; Fri, 21 Oct 2005 05:29:55 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFFF243D46; Fri, 21 Oct 2005 05:29:54 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9L5TsKn071111; Fri, 21 Oct 2005 05:29:54 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9L5TsrN071110; Fri, 21 Oct 2005 05:29:54 GMT (envelope-from wpaul) Message-Id: <200510210529.j9L5TsrN071110@repoman.freebsd.org> From: Bill Paul Date: Fri, 21 Oct 2005 05:29:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/compat/ndis ntoskrnl_var.h subr_hal.c subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 05:29:55 -0000 wpaul 2005-10-21 05:29:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/compat/ndis ntoskrnl_var.h subr_hal.c subr_ntoskrnl.c Log: MFC from head (fix KeRaiseIrql() API, wait for DPC/workitem thread termination the right way). Revision Changes Path 1.17.2.9 +2 -2 src/sys/compat/ndis/ntoskrnl_var.h 1.13.2.6 +1 -1 src/sys/compat/ndis/subr_hal.c 1.43.2.9 +5 -22 src/sys/compat/ndis/subr_ntoskrnl.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 05:48:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48E4F16A41F; Fri, 21 Oct 2005 05:48:39 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06AFD43D4C; Fri, 21 Oct 2005 05:48:39 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9L5mcLm071746; Fri, 21 Oct 2005 05:48:38 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9L5mcxQ071745; Fri, 21 Oct 2005 05:48:38 GMT (envelope-from alc) Message-Id: <200510210548.j9L5mcxQ071745@repoman.freebsd.org> From: Alan Cox Date: Fri, 21 Oct 2005 05:48:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_cow.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 05:48:39 -0000 alc 2005-10-21 05:48:38 UTC FreeBSD src repository Modified files: sys/kern uipc_cow.c Log: Eliminate spl* calls. Revision Changes Path 1.24 +0 -6 src/sys/kern/uipc_cow.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 09:15:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99A9D16A420; Fri, 21 Oct 2005 09:15:26 +0000 (GMT) (envelope-from dumbbell@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5427E43D48; Fri, 21 Oct 2005 09:15:26 +0000 (GMT) (envelope-from dumbbell@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9L9FQdw086876; Fri, 21 Oct 2005 09:15:26 GMT (envelope-from dumbbell@repoman.freebsd.org) Received: (from dumbbell@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9L9FQc7086875; Fri, 21 Oct 2005 09:15:26 GMT (envelope-from dumbbell) Message-Id: <200510210915.j9L9FQc7086875@repoman.freebsd.org> From: Jean-Sebastien Pedron Date: Fri, 21 Oct 2005 09:15:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/gnu/fs/reiserfs reiserfs_namei.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 09:15:26 -0000 dumbbell 2005-10-21 09:15:26 UTC FreeBSD src repository Modified files: sys/gnu/fs/reiserfs reiserfs_namei.c Log: Apply the same fix to a potential race in the ISDOTDOT code in reiserfs_lookup() that was used to fix an actual race in ufs_lookup.c:1.78. This is not currently a hazard, but the bug would be activated by marking reiserfs as MPSAFE. Reviewed by: mux (mentor) MFC after: 2 weeks Revision Changes Path 1.2 +3 -1 src/sys/gnu/fs/reiserfs/reiserfs_namei.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 11:10:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D7F4F16A41F; Fri, 21 Oct 2005 11:10:47 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9607C43D46; Fri, 21 Oct 2005 11:10:47 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LBAlkf091355; Fri, 21 Oct 2005 11:10:47 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LBAlK1091354; Fri, 21 Oct 2005 11:10:47 GMT (envelope-from suz) Message-Id: <200510211110.j9LBAlK1091354@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Fri, 21 Oct 2005 11:10:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/netinet6 raw_ip6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 11:10:48 -0000 suz 2005-10-21 11:10:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/netinet6 raw_ip6.c Log: MFC 1.56 (added a missing unlock) Approved by: re(scottl) Revision Changes Path 1.50.2.2.2.1 +3 -1 src/sys/netinet6/raw_ip6.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 12:38:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F37A516A41F; Fri, 21 Oct 2005 12:38:43 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 381BB43D70; Fri, 21 Oct 2005 12:38:43 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LCcXQe024035; Fri, 21 Oct 2005 22:38:33 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LCcTRh011378; Fri, 21 Oct 2005 22:38:30 +1000 Date: Fri, 21 Oct 2005 22:38:30 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: "M. Warner Losh" In-Reply-To: <20051020.121318.117917917.imp@bsdimp.com> Message-ID: <20051021210822.E4739@delplex.bde.org> References: <25112.1129812291@critter.freebsd.dk> <20051021011035.T1945@delplex.bde.org> <20051020.121318.117917917.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, phk@phk.freebsd.dk, src-committers@FreeBSD.org, andre@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 12:38:44 -0000 On Thu, 20 Oct 2005, M. Warner Losh wrote: > In message: <20051021011035.T1945@delplex.bde.org> > Bruce Evans writes: > : > You can by definition not implment difftime correctly since the > : > time_t timescale does not contain any indication of leapseconds. > : > > : > This means that there is no way to tell which side of an inserted > : > leapsecond a time(2) timestamp comes from: > : > > : > UTC time(2) > : > 23:59:57 N-3 > : > 23:59:58 N-2 > : > 23:59:59 N-1 > : > 23:59:60 N > : > 00:00:00 N > : > 00:00:01 N+1 > : > > : > Worst case, difftime() will be wrong by two seconds: taking the difference > : > from one leapsecond to another and guessing wrong in both ends. > : > : It only has to be wrong by 1 or 2 seconds for short intervals when a leap > : seconds occurs. Not adjusting makes difftime() wrong across all intervals > : containing a leap second, with an error of the number of leap seconds in > : the interval (+- 1 or 2 for leap seconds at endpoints). > > Where do you keep the table of leapseconds? How do you make sure it > gets updated? As far as I know, there's no installed leap second data > on the system, unless you've enabled the 'run in TAI instead of UTC' > mode. At the source level, the table is in /usr/src/share/zoneinfo/leapseconds. This file was updated in revs.1.[13-14] (2005/07/05-2005/08/26) to add the leap second at the end of this year. Before that, the file hasn't needed to change since the previous leap second in 1998, but has some cosmetic changes. Complain to wollman if this file is not updated. :-) At runtime, _a_ table is in /etc/localtime. According to tzfile(5): % DESCRIPTION % The time zone information files used by tzset(3) begin with the magic % characters ``TZif'' to identify them as time zone information files, fol- % lowed by sixteen bytes reserved for future use, followed by four four- % byte values written in a ``standard'' byte order (the high-order byte of % the value is written first). These values are, in order: % ... % tzh_leapcnt The number of leap seconds for which data is stored in % the file. % ... % Then there are tzh_leapcnt pairs of four-byte values, written in standard % byte order; the first value of each pair gives the time (as returned by % time(3)) at which a leap second occurs; the second gives the total number % of leap seconds to be applied after the given time. The pairs of values % are sorted in ascending order by time. Unfortunately, a null table is used by default since LEAPSECONDS is not defined (see zoneinfo/Makefile). This dates from FreeBSD-2. In zoneinfo/Makefile before 1.6 and in FreeBSD-1, instead of LEAPSECONDS there were targets posix_only, right_only, posix_right and right_posix to support various amounts of POSIX time_t mistakes. FreeBSD-1.1.5 used posix_right, which gave "both sets of data available, with leap seconds not counted normally". I think this means FreeBSD-1.1.5 used full POSIX time_t mistakes but put the leapseconds database in binaries for abnormal use (whatever that is; I guess it is controlled by a runtime switch). FreeBSD_1.0 used right_posix, which gave right behaviour normally and POSIX mistakes abnormally. This was found to be to abnormal to be the default, so FreeBSD switched to posix_right. Then in rev.1.6 before FreeBSD_2.0, the right/posix stuff was replaced by the LEAPSECONDS knob and the knob was for some reason turned around so the behaviour changed from posix_right to plain posix[_wrong]. There was also a change from right_only to posix_right in rev.1.5. > Leaving aside the leap table issue for the moment, there's a more > fundamental problem. You cannot possibly compute correct answers for > times that are in the future, even a little ways in the future. What > if time1 is June 30, 2006 23:59:58 and time2 is July 1, 2006 00:00:01. > While neither of these seconds are ambiguous, no one on the planet can > say today, with certainty, what the answer will be. We have to wait > until early January when IERS issues the next Bulletin C. You cannot > know today if the right answer is 2, 3 or 4. If there's a negative > leap second at the end of June 30, then the answer is 2, if there's no > leap second the answer is 3, if there is a positive leap second, the > answer is 4. One can only predict what might happen. Until 6 months > before the leap second, no one knows what the schedule will be. This is not a problem for times returned by clock_gettime(), since those times are in the past. 64-bit time_t's and/or ints also permit asking the time library to do impossible predictions. Bruce From owner-cvs-src@FreeBSD.ORG Fri Oct 21 14:23:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8892116A420; Fri, 21 Oct 2005 14:23:08 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1EFC43D45; Fri, 21 Oct 2005 14:23:07 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LEN6Mr015514; Sat, 22 Oct 2005 00:23:06 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LEN3TI021531; Sat, 22 Oct 2005 00:23:04 +1000 Date: Sat, 22 Oct 2005 00:23:03 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <27345.1129842256@critter.freebsd.dk> Message-ID: <20051021230751.Q5110@delplex.bde.org> References: <27345.1129842256@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 14:23:08 -0000 On Thu, 20 Oct 2005, Poul-Henning Kamp wrote: > ... > If people do stupid things like use hard steps (*settime*()) to > correct rate problems, then they get what they deserve, including > potentially backwards jumps in time, but the integral over time of > all steps apart from the first one amounts to a rate correction. Using *settime*() isn't stupid. It is always done by ntpdate -b and sometimes done by ntpd. (I use ntpd -x to prevent stepping, but -x shouldn't be used except for debugging since stepping is the best way to correct large errors, and at least old versions of ntpd are broken if they would prefer to step but are prevent from doing so by -x.) > In summary: CLOCK_MONOTONIC is our best estimate of how many SI > seconds the system have been runing [3]. Actual testing shows that CLOCK_MONOTONIC, or possibly CLOCK_REALTIME less the boot time, gives a very bad estimate of how long the system has been running. The difference between these clocks was about 500 seconds on all systems tested: % sledge: % 1:03PM up 22:45, 1 user, load averages: 0.23, 0.08, 0.02 % uptime 1 81900 % uptime 2 82887 % % pluto1: % 1:05PM up 15 days, 10:18, 1 user, load averages: 1.28, 1.15, 1.26 % uptime 1 1333090 % uptime 2 1333540 % % pluto2: % 1:06PM up 10 days, 7:19, 1 user, load averages: 1.95, 1.83, 1.80 % uptime 1 890323 % uptime 2 890721 These are freebsd machines. uptime1 is from gettimeofday() less boottime. uptime2 is from CLOCK_MONOTONIC. I don't know what root has been doing to mess up the clocks on these machines. % delplex: % 11:00PM up 31 days, 4:37, 2 users, load averages: 0.06, 0.02, 0.00 % uptime 1 2695028 % uptime 2 2695926 % % epsplex: % 11:00PM up 3:34, 4 users, load averages: 0.00, 0.00, 0.00 % uptime 1 12856 % uptime 2 13390 % % besplex: % 11:01PM up 26 days, 1:09, 1 user, load averages: 0.00, 0.00, 0.00 % uptime 1 2250584 % uptime 2 2251311 These are my local machines. Root did a lot of ntpdate -b's on delplex and besplex when they rebooted after a power failure 26 days ago, but the steps were much smaller than 500 seconds and there haven't been any since. epsplex has the ~500 second difference after not doing any steps except: % Oct 21 19:26:59 epsplex kernel: tc_windup: large step 1129922814 Usual step from 0 to year 2005 on startup: % Oct 21 19:26:59 epsplex kernel: tc_windup: negative step 36000 Usual step by adjkerntz to fix up hardware clock being on local time. Doesn't affect deltas. % Oct 21 19:27:01 epsplex kernel: tc_windup: negative step 2 By ntpdate to sync with delplex. A large fairly machdine-independent differece is hard to explain. I will reboot after sending this to see if one of the values is much larger than the uptime when the uptime is < 60 seconds. > Given that CLOCK_MONOTONIC is our best guess how long the kernel > has been running, it follows that CLOCK_REALTIME - CLOCK_MONOTONIC > must be our best estimate of what time the kernel booted. Not given, and not true. After syncing with an accurate external clock by a step, we know the real time very accurately. Normally we sync soon after booting. Then we know the boot time very accurately (it is the current real time less CLOCK_MONOTONIC). Then if we resync with the external clock later using a step, we again know the real time very accurately, and our best guess at the uptime is the current real time less the previously determined boot time (with a non-broken time_t or difftime() restoring leap seconds). CLOCK_MONOTONIC cannot track this because it cannot jump. You might say that the uptime cannot jump either. This is OK, but then it (like CLOCK_MONOTONIC) should be slewed to catch up with the jump. Bruce From owner-cvs-src@FreeBSD.ORG Fri Oct 21 14:31:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC0AF16A41F; Fri, 21 Oct 2005 14:31:44 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CAD843D48; Fri, 21 Oct 2005 14:31:44 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LEVhUR016348; Sat, 22 Oct 2005 00:31:43 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LEVfe6022257; Sat, 22 Oct 2005 00:31:41 +1000 Date: Sat, 22 Oct 2005 00:31:41 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <20051021230751.Q5110@delplex.bde.org> Message-ID: <20051022002904.P5334@delplex.bde.org> References: <27345.1129842256@critter.freebsd.dk> <20051021230751.Q5110@delplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 14:31:45 -0000 On Sat, 22 Oct 2005, Bruce Evans wrote: > On Thu, 20 Oct 2005, Poul-Henning Kamp wrote: >> In summary: CLOCK_MONOTONIC is our best estimate of how many SI >> seconds the system have been runing [3]. > > Actual testing shows that CLOCK_MONOTONIC, or possibly CLOCK_REALTIME > less the boot time, gives a very bad estimate of how long the system has > been running. The difference between these clocks was about 500 seconds > on all systems tested: > > % sledge: > % 1:03PM up 22:45, 1 user, load averages: 0.23, 0.08, 0.02 > % uptime 1 81900 > % uptime 2 82887 > ... > A large fairly machdine-independent differece is hard to explain. I > will reboot after sending this to see if one of the values is much > larger than the uptime when the uptime is < 60 seconds. Please ignore this. It was a stupid bug. After fixing the bug, there were no differences. Bruce From owner-cvs-src@FreeBSD.ORG Fri Oct 21 14:47:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 983D116A423; Fri, 21 Oct 2005 14:47:38 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0195E43D67; Fri, 21 Oct 2005 14:47:34 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 38F03BC50; Fri, 21 Oct 2005 14:47:30 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 22 Oct 2005 00:23:03 +1000." <20051021230751.Q5110@delplex.bde.org> Date: Fri, 21 Oct 2005 16:47:29 +0200 Message-ID: <30613.1129906049@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 14:47:39 -0000 In message <20051021230751.Q5110@delplex.bde.org>, Bruce Evans writes: >On Thu, 20 Oct 2005, Poul-Henning Kamp wrote: >> ... >> If people do stupid things like use hard steps (*settime*()) to >> correct rate problems, then they get what they deserve, including >> potentially backwards jumps in time, but the integral over time of >> all steps apart from the first one amounts to a rate correction. > >Using *settime*() isn't stupid. Using it more than once per boot is stupid, and abundantly makes it clear that precise timekeeping is not what you are attempting. >> In summary: CLOCK_MONOTONIC is our best estimate of how many SI >> seconds the system have been runing [3]. > >Actual testing shows that CLOCK_MONOTONIC, or possibly CLOCK_REALTIME >less the boot time, gives a very bad estimate of how long the system has >been running. The difference between these clocks was about 500 seconds >on all systems tested: > >% sledge: >% 1:03PM up 22:45, 1 user, load averages: 0.23, 0.08, 0.02 >% uptime 1 81900 >% uptime 2 82887 Works fine for me: sledge phk> cat > a.c #include #include int main(int argc __unused, char **argv __unused) { struct timeval boottime; struct timespec up, utc; size_t s; s = sizeof boottime; sysctlbyname("kern.boottime", &boottime, &s, NULL, 0); printf("Boottime\t%ld.%06d\n", boottime.tv_sec, boottime.tv_usec); clock_gettime(CLOCK_MONOTONIC, &up); printf("Uptime\t\t%ld.%09d\n", up.tv_sec, up.tv_nsec); clock_gettime(CLOCK_REALTIME, &utc); printf("UTC\t\t%ld.%09d\n", utc.tv_sec, utc.tv_nsec); return(0); } ^D sledge phk> make a cc -O2 -fno-strict-aliasing -pipe a.c -o a sledge phk> ./a Boottime 1129904420.816916 Uptime 1317.689747507 UTC 1129905738.506671500 sledge phk> bc [...] 1129904420.816916+1317.689747507 1129905738.506663507 Mind you, there is no way the above cannot work because that is how the math in the kernel works. >Not given, and not true. After syncing with an accurate external clock >by a step, we know the real time very accurately. Normally we sync >soon after booting. Then we know the boot time very accurately (it >is the current real time less CLOCK_MONOTONIC). Then if we resync >with the external clock later using a step, we again know the real >time very accurately, [...] But have resigned ourselves to not caring about the actual length of seconds and therefore, presumably, having no serious interest in timekeeping quality. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Fri Oct 21 15:17:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1FD4816A41F; Fri, 21 Oct 2005 15:17:19 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5CD943D49; Fri, 21 Oct 2005 15:17:18 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LFHIlq008841; Fri, 21 Oct 2005 15:17:18 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LFHIh3008840; Fri, 21 Oct 2005 15:17:18 GMT (envelope-from jkim) Message-Id: <200510211517.j9LFHIh3008840@repoman.freebsd.org> From: Jung-uk Kim Date: Fri, 21 Oct 2005 15:17:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/grep grep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 15:17:19 -0000 jkim 2005-10-21 15:17:18 UTC FreeBSD src repository Modified files: gnu/usr.bin/grep grep.c Log: Remove redundant string length check from the previous commit. Revision Changes Path 1.33 +2 -2 src/gnu/usr.bin/grep/grep.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 15:33:54 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA87C16A41F; Fri, 21 Oct 2005 15:33:54 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75CF543D49; Fri, 21 Oct 2005 15:33:54 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j9LFVBkO025843; Fri, 21 Oct 2005 09:31:12 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 21 Oct 2005 09:32:34 -0600 (MDT) Message-Id: <20051021.093234.116607170.imp@bsdimp.com> To: bde@zeta.org.au From: "M. Warner Losh" In-Reply-To: <20051021210822.E4739@delplex.bde.org> References: <20051021011035.T1945@delplex.bde.org> <20051020.121318.117917917.imp@bsdimp.com> <20051021210822.E4739@delplex.bde.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 21 Oct 2005 09:31:12 -0600 (MDT) Cc: cvs-src@freebsd.org, phk@phk.freebsd.dk, src-committers@freebsd.org, andre@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 15:33:55 -0000 In message: <20051021210822.E4739@delplex.bde.org> Bruce Evans writes: : Complain to wollman if this file is not updated. :-) I can't complain to Wollman if I have a system that's at a customer site that's been running for a while before the leap second is announced. Such systems need a way to get and keep a table. : This is not a problem for times returned by clock_gettime(), since those : times are in the past. : : 64-bit time_t's and/or ints also permit asking the time library to do : impossible predictions. It is a problem. If I boot a system today, the authors of the software still cannot know the example that I gave. Since there's no leap second table by default, the system may get the answer wrong. That's what is so evil about leap seconds. You can't plan more than 6 months into the future. Warner From owner-cvs-src@FreeBSD.ORG Fri Oct 21 15:42:07 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3D1616A41F; Fri, 21 Oct 2005 15:42:07 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1740D43D45; Fri, 21 Oct 2005 15:42:07 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 97623BC84; Fri, 21 Oct 2005 15:42:03 +0000 (UTC) To: "M. Warner Losh" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 21 Oct 2005 09:32:34 MDT." <20051021.093234.116607170.imp@bsdimp.com> Date: Fri, 21 Oct 2005 17:42:02 +0200 Message-ID: <30677.1129909322@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@freebsd.org, src-committers@freebsd.org, andre@freebsd.org, cvs-all@freebsd.org, bde@zeta.org.au Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 15:42:08 -0000 In message <20051021.093234.116607170.imp@bsdimp.com>, "M. Warner Losh" writes: >It is a problem. If I boot a system today, the authors of the >software still cannot know the example that I gave. Since there's no >leap second table by default, the system may get the answer wrong. >That's what is so evil about leap seconds. You can't plan more than 6 >months into the future. It's worse than 6 months, just because IERS says there will or wont be a leap second in 6 months time doesn't mean that they can't change their mind later on, technically it is only one month ahead. Fortunately, this is not relevant with the current geophysics. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Fri Oct 21 15:44:48 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C59AB16A41F; Fri, 21 Oct 2005 15:44:48 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80D5D43D45; Fri, 21 Oct 2005 15:44:48 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LFimoX010024; Fri, 21 Oct 2005 15:44:48 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LFimKW010023; Fri, 21 Oct 2005 15:44:48 GMT (envelope-from yar) Message-Id: <200510211544.j9LFimKW010023@repoman.freebsd.org> From: Yar Tikhiy Date: Fri, 21 Oct 2005 15:44:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 15:44:48 -0000 yar 2005-10-21 15:44:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC notes on ifconfig(8): -tunnel, -vlandev. Approved by: re (hrs) Revision Changes Path 1.883.2.8 +9 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Fri Oct 21 15:45:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50B6D16A436; Fri, 21 Oct 2005 15:45:26 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4227543D5E; Fri, 21 Oct 2005 15:45:14 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LFjEts010077; Fri, 21 Oct 2005 15:45:14 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LFjEDV010076; Fri, 21 Oct 2005 15:45:14 GMT (envelope-from suz) Message-Id: <200510211545.j9LFjEDV010076@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Fri, 21 Oct 2005 15:45:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 ip6_output.c ip6_var.h nd6_nbr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 15:45:27 -0000 suz 2005-10-21 15:45:13 UTC FreeBSD src repository Modified files: sys/netinet6 ip6_output.c ip6_var.h nd6_nbr.c Log: sync with KAME (renamed a macro IPV6_DADOUTPUT to IPV6_UNSPECSRC) Obtained from: KAME Revision Changes Path 1.99 +1 -1 src/sys/netinet6/ip6_output.c 1.36 +1 -1 src/sys/netinet6/ip6_var.h 1.38 +1 -1 src/sys/netinet6/nd6_nbr.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 15:45:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5F6816A41F; Fri, 21 Oct 2005 15:45:51 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 150D743D45; Fri, 21 Oct 2005 15:45:50 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LFjnGJ023707; Sat, 22 Oct 2005 01:45:49 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LFjkQo009979; Sat, 22 Oct 2005 01:45:47 +1000 Date: Sat, 22 Oct 2005 01:45:47 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <30613.1129906049@critter.freebsd.dk> Message-ID: <20051022011020.T5554@delplex.bde.org> References: <30613.1129906049@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 15:45:51 -0000 On Fri, 21 Oct 2005, Poul-Henning Kamp wrote: > In message <20051021230751.Q5110@delplex.bde.org>, Bruce Evans writes: >> On Thu, 20 Oct 2005, Poul-Henning Kamp wrote: > >>> ... >>> If people do stupid things like use hard steps (*settime*()) to >>> correct rate problems, then they get what they deserve, including >>> potentially backwards jumps in time, but the integral over time of >>> all steps apart from the first one amounts to a rate correction. >> >> Using *settime*() isn't stupid. > > Using it more than once per boot is stupid, and abundantly makes > it clear that precise timekeeping is not what you are attempting. How do you resync laptops after suspending them for long enough for the clock to drift? Use ntpd and let it step, or use ntpd -x and let it take hours to resync? The right thing to do is step the clocks to the current time immediately so that they are correct while the system is actually being used. [>>> Given that CLOCK_MONOTONIC gives our best idea of the uptime] >> Not given, and not true. After syncing with an accurate external clock >> by a step, we know the real time very accurately. Normally we sync >> soon after booting. Then we know the boot time very accurately (it >> is the current real time less CLOCK_MONOTONIC). Then if we resync >> with the external clock later using a step, we again know the real >> time very accurately, [...] > > But have resigned ourselves to not caring about the actual length > of seconds and therefore, presumably, having no serious interest > in timekeeping quality. I certainly care about errors of 1 microsecond (although I don't need to), and just remembered that I use stepping to fix up the clock after sitting in ddb with the clock stopped. This reduces the error in the real time clock to ~1 microsecond per second stopped, but gives an error of 1 second per second stopped in the monotonic time and the boot time. Here the correct treatment is to jump the monotonic time forward and not touch the boot time. Bruce From owner-cvs-src@FreeBSD.ORG Fri Oct 21 15:59:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C76916A41F; Fri, 21 Oct 2005 15:59:01 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0A6443D45; Fri, 21 Oct 2005 15:59:00 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LFx0lQ010712; Fri, 21 Oct 2005 15:59:00 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LFx07j010711; Fri, 21 Oct 2005 15:59:00 GMT (envelope-from suz) Message-Id: <200510211559.j9LFx07j010711@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Fri, 21 Oct 2005 15:59:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 nd6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 15:59:01 -0000 suz 2005-10-21 15:59:00 UTC FreeBSD src repository Modified files: sys/netinet6 nd6.c Log: perform NUD on an IPv6-aware point-to-point interface Obtained from: KAME MFC after: 1 week Revision Changes Path 1.60 +2 -0 src/sys/netinet6/nd6.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:01:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C93BA16A41F; Fri, 21 Oct 2005 16:01:47 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85DD643D46; Fri, 21 Oct 2005 16:01:47 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LG1lx3010897; Fri, 21 Oct 2005 16:01:47 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LG1lf2010896; Fri, 21 Oct 2005 16:01:47 GMT (envelope-from yar) Message-Id: <200510211601.j9LG1lf2010896@repoman.freebsd.org> From: Yar Tikhiy Date: Fri, 21 Oct 2005 16:01:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:01:48 -0000 yar 2005-10-21 16:01:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC notes on ifconfig(8): -tunnel, -vlandev. Approved by: re (hrs) Revision Changes Path 1.883.2.7.2.1 +9 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:03:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 431F016A41F; Fri, 21 Oct 2005 16:03:58 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id C987143D45; Fri, 21 Oct 2005 16:03:57 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j9LG0tFs026115; Fri, 21 Oct 2005 10:00:56 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 21 Oct 2005 10:02:19 -0600 (MDT) Message-Id: <20051021.100219.111271614.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <30677.1129909322@critter.freebsd.dk> References: <20051021.093234.116607170.imp@bsdimp.com> <30677.1129909322@critter.freebsd.dk> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 21 Oct 2005 10:00:56 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, andre@FreeBSD.org, cvs-all@FreeBSD.org, bde@zeta.org.au Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:03:58 -0000 In message: <30677.1129909322@critter.freebsd.dk> "Poul-Henning Kamp" writes: : In message <20051021.093234.116607170.imp@bsdimp.com>, "M. Warner Losh" writes: : : >It is a problem. If I boot a system today, the authors of the : >software still cannot know the example that I gave. Since there's no : >leap second table by default, the system may get the answer wrong. : >That's what is so evil about leap seconds. You can't plan more than 6 : >months into the future. : : It's worse than 6 months, just because IERS says there will or wont : be a leap second in 6 months time doesn't mean that they can't change : their mind later on, technically it is only one month ahead. : : Fortunately, this is not relevant with the current geophysics. True. The international standard on leap seconds does say they can happen at the end of any month, with June/Dec being primary and Mar/Sept being secondary. If current models are accurate, we'll need more than two leap seconds a year in the next century or so. We'll need more than 12 a century or so after that. And more than one a day in a few thousand years. Clearly a better way to sychronize time will be needed at some point. I vote steering the earth so that its rotation is restored to its true length :-) Still haven't mentioned that deep and abiding love for leap seconds... Warner From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:05:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A077E16A41F; Fri, 21 Oct 2005 16:05:54 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2CB8843D49; Fri, 21 Oct 2005 16:05:54 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 71E69BC7A; Fri, 21 Oct 2005 16:05:50 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 22 Oct 2005 01:45:47 +1000." <20051022011020.T5554@delplex.bde.org> Date: Fri, 21 Oct 2005 18:05:50 +0200 Message-ID: <30805.1129910750@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:05:54 -0000 In message <20051022011020.T5554@delplex.bde.org>, Bruce Evans writes: >How do you resync laptops after suspending them for long enough for >the clock to drift? Use ntpd and let it step, or use ntpd -x and let >it take hours to resync? The right thing to do is step the clocks to >the current time immediately so that they are correct while the system >is actually being used. Ahh, and now we get into interesting territory: What _is_ the definition of uptime for a laptop which has been suspended ? No matter which way you turn, there are dragons... >> But have resigned ourselves to not caring about the actual length >> of seconds and therefore, presumably, having no serious interest >> in timekeeping quality. > >I certainly care about errors of 1 microsecond (although I don't need >to), and just remembered that I use stepping to fix up the clock after >sitting in ddb with the clock stopped. This reduces the error in the >real time clock to ~1 microsecond per second stopped, but gives an error >of 1 second per second stopped in the monotonic time and the boot time. >Here the correct treatment is to jump the monotonic time forward and >not touch the boot time. Again, if you have been sitting in DDB, what exactly is the definition of "uptime" ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:06:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACA5A16A48E; Fri, 21 Oct 2005 16:06:07 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D74543D46; Fri, 21 Oct 2005 16:06:05 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id j9LG5qwH073219; Fri, 21 Oct 2005 09:05:56 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200510211605.j9LG5qwH073219@gw.catspoiler.org> Date: Fri, 21 Oct 2005 09:05:52 -0700 (PDT) From: Don Lewis To: imp@bsdimp.com In-Reply-To: <20051020.121318.117917917.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: src-committers@FreeBSD.org, andre@FreeBSD.org, bde@zeta.org.au, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, phk@phk.freebsd.dk Subject: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:06:08 -0000 On 20 Oct, M. Warner Losh wrote: > Leaving aside the leap table issue for the moment, there's a more > fundamental problem. You cannot possibly compute correct answers for > times that are in the future, even a little ways in the future. What > if time1 is June 30, 2006 23:59:58 and time2 is July 1, 2006 00:00:01. > While neither of these seconds are ambiguous, no one on the planet can > say today, with certainty, what the answer will be. We have to wait > until early January when IERS issues the next Bulletin C. There's a similar problem with computing time differences across daylight savings change transitions, since the date of the transition and even whether there will be a transition is subject to political whim. From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:14:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E37AB16A420 for ; Fri, 21 Oct 2005 16:14:38 +0000 (GMT) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5907E43D5E for ; Fri, 21 Oct 2005 16:14:37 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 19064 invoked from network); 21 Oct 2005 16:19:52 -0000 Received: from c00l3r.networx.ch (HELO freebsd.org) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 21 Oct 2005 16:19:52 -0000 Message-ID: <435913FE.774C683D@freebsd.org> Date: Fri, 21 Oct 2005 18:14:54 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Poul-Henning Kamp References: <30805.1129910750@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Bruce Evans Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:14:39 -0000 Poul-Henning Kamp wrote: > > In message <20051022011020.T5554@delplex.bde.org>, Bruce Evans writes: > > >How do you resync laptops after suspending them for long enough for > >the clock to drift? Use ntpd and let it step, or use ntpd -x and let > >it take hours to resync? The right thing to do is step the clocks to > >the current time immediately so that they are correct while the system > >is actually being used. > > Ahh, and now we get into interesting territory: What _is_ the > definition of uptime for a laptop which has been suspended ? > > No matter which way you turn, there are dragons... > > >> But have resigned ourselves to not caring about the actual length > >> of seconds and therefore, presumably, having no serious interest > >> in timekeeping quality. > > > >I certainly care about errors of 1 microsecond (although I don't need > >to), and just remembered that I use stepping to fix up the clock after > >sitting in ddb with the clock stopped. This reduces the error in the > >real time clock to ~1 microsecond per second stopped, but gives an error > >of 1 second per second stopped in the monotonic time and the boot time. > >Here the correct treatment is to jump the monotonic time forward and > >not touch the boot time. > > Again, if you have been sitting in DDB, what exactly is the definition > of "uptime" ? IMO it's this: Uptime is the time the operating was available to present it's common services to userland. That excludes any suspend and ddb times. Single user mode however counts because the OS was servicing userland even if there was only one user. Uptime is represented in SI seconds. Time since boottime is the UTC delta from the time of when the OS initialized itself to now. Leap seconds cause deviations from uptime. Time since boottime is represented as numerical delta in seconds from two UTC timestamps. Uptime != Time since boottime. -- Andre From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:23:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A56B516A41F; Fri, 21 Oct 2005 16:23:01 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6ABCA43D45; Fri, 21 Oct 2005 16:23:01 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LGN1qO011885; Fri, 21 Oct 2005 16:23:01 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LGN1A7011884; Fri, 21 Oct 2005 16:23:01 GMT (envelope-from suz) Message-Id: <200510211623.j9LGN1A7011884@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Fri, 21 Oct 2005 16:23:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet icmp6.h src/sys/netinet6 icmp6.c in6.c in6.h in6_ifattach.c in6_ifattach.h in6_var.h ip6_output.c mld6.c mld6_var.h nd6.c nd6.h nd6_nbr.c nd6_rtr.c src/share/doc/IPv6 IMPLEMENTATION X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:23:01 -0000 suz 2005-10-21 16:23:01 UTC FreeBSD src repository Modified files: sys/netinet icmp6.h sys/netinet6 icmp6.c in6.c in6.h in6_ifattach.c in6_ifattach.h in6_var.h ip6_output.c mld6.c mld6_var.h nd6.c nd6.h nd6_nbr.c nd6_rtr.c share/doc/IPv6 IMPLEMENTATION Log: sync with KAME regarding NDP - introduced fine-grain-timer to manage ND-caches and IPv6 Multicast-Listeners - supports Router-Preference - better prefix lifetime management - more spec-comformant DAD advertisement - updated RFC/internet-draft revisions Obtained from: KAME Reviewed by: ume, gnn MFC after: 2 month Revision Changes Path 1.9 +157 -83 src/share/doc/IPv6/IMPLEMENTATION 1.20 +5 -1 src/sys/netinet/icmp6.h 1.69 +2 -2 src/sys/netinet6/icmp6.c 1.57 +322 -80 src/sys/netinet6/in6.c 1.42 +6 -4 src/sys/netinet6/in6.h 1.31 +7 -21 src/sys/netinet6/in6_ifattach.c 1.7 +1 -1 src/sys/netinet6/in6_ifattach.h 1.27 +15 -4 src/sys/netinet6/in6_var.h 1.100 +14 -13 src/sys/netinet6/ip6_output.c 1.24 +116 -46 src/sys/netinet6/mld6.c 1.7 +1 -0 src/sys/netinet6/mld6_var.h 1.61 +337 -209 src/sys/netinet6/nd6.c 1.21 +32 -21 src/sys/netinet6/nd6.h 1.39 +37 -30 src/sys/netinet6/nd6_nbr.c 1.31 +479 -282 src/sys/netinet6/nd6_rtr.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:25:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84CDB16A41F; Fri, 21 Oct 2005 16:25:06 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4A4143D45; Fri, 21 Oct 2005 16:25:05 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LGP4r1016527; Sat, 22 Oct 2005 02:25:04 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9LGP1d9019340; Sat, 22 Oct 2005 02:25:02 +1000 Date: Sat, 22 Oct 2005 02:25:01 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <30805.1129910750@critter.freebsd.dk> Message-ID: <20051022021817.X5902@delplex.bde.org> References: <30805.1129910750@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:25:06 -0000 On Fri, 21 Oct 2005, Poul-Henning Kamp wrote: > In message <20051022011020.T5554@delplex.bde.org>, Bruce Evans writes: > >> How do you resync laptops after suspending them for long enough for >> the clock to drift? Use ntpd and let it step, or use ntpd -x and let >> it take hours to resync? The right thing to do is step the clocks to >> the current time immediately so that they are correct while the system >> is actually being used. > > Ahh, and now we get into interesting territory: What _is_ the > definition of uptime for a laptop which has been suspended ? > > No matter which way you turn, there are dragons... >> I certainly care about errors of 1 microsecond (although I don't need >> to), and just remembered that I use stepping to fix up the clock after >> sitting in ddb with the clock stopped. This reduces the error in the >> real time clock to ~1 microsecond per second stopped, but gives an error >> of 1 second per second stopped in the monotonic time and the boot time. >> Here the correct treatment is to jump the monotonic time forward and >> not touch the boot time. > > Again, if you have been sitting in DDB, what exactly is the definition > of "uptime" ? This is clear. The system is up while it is sitting in ddb. It's actually more active then average then, since doesn't idle or halt :-). Bruce From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:31:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 692B316A421; Fri, 21 Oct 2005 16:31:40 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 263B843D45; Fri, 21 Oct 2005 16:31:40 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LGVe5Q012279; Fri, 21 Oct 2005 16:31:40 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LGVepo012278; Fri, 21 Oct 2005 16:31:40 GMT (envelope-from suz) Message-Id: <200510211631.j9LGVepo012278@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Fri, 21 Oct 2005 16:31:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:31:40 -0000 suz 2005-10-21 16:31:39 UTC FreeBSD src repository Modified files: sys/netinet6 README Log: nuked non-existing commands Revision Changes Path 1.3 +1 -6 src/sys/netinet6/README From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:47:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C19E16A41F; Fri, 21 Oct 2005 16:47:30 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE55343D45; Fri, 21 Oct 2005 16:47:29 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j9LGlSXH087200; Fri, 21 Oct 2005 09:47:29 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <30805.1129910750@critter.freebsd.dk> References: <30805.1129910750@critter.freebsd.dk> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <0D10B55A-A82D-433F-81CA-A5A02B36DA75@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Fri, 21 Oct 2005 09:47:27 -0700 To: Poul-Henning Kamp X-Mailer: Apple Mail (2.734) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org, Bruce Evans Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:47:30 -0000 On Oct 21, 2005, at 9:05 AM, Poul-Henning Kamp wrote: > In message <20051022011020.T5554@delplex.bde.org>, Bruce Evans writes: > > > >> How do you resync laptops after suspending them for long enough for >> the clock to drift? Use ntpd and let it step, or use ntpd -x and let >> it take hours to resync? The right thing to do is step the clocks to >> the current time immediately so that they are correct while the >> system >> is actually being used. >> > > Ahh, and now we get into interesting territory: What _is_ the > definition of uptime for a laptop which has been suspended ? I don't think the definition has to change, but I don't know what the *exact* definition of uptime is. Wikipedia says this: "Uptime is a measure of the time a computer system has been up and running. It came into use to describe the opposite of downtime, times when a system was non-operational." Given this, suspend is downtime and the uptime is therefore defined as the amount of time since resume. Doesn't seem unreasonable to me. > Again, if you have been sitting in DDB, what exactly is the definition > of "uptime" ? Since the kernel is non-operational while in DDB, uptime is to reset when leaving DDB. Again, according to the Wikipedia definition of uptime. I'm having more problems finding this reasonable, but it's not unacceptable. The question therefore is: which definition of uptime do we try to implement? -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Fri Oct 21 16:57:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 887F316A41F; Fri, 21 Oct 2005 16:57:58 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4734943D58; Fri, 21 Oct 2005 16:57:57 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LGvvLv020393; Fri, 21 Oct 2005 16:57:57 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LGvvI0020392; Fri, 21 Oct 2005 16:57:57 GMT (envelope-from wpaul) Message-Id: <200510211657.j9LGvvI0020392@repoman.freebsd.org> From: Bill Paul Date: Fri, 21 Oct 2005 16:57:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/wpa/ndis_events ndis_events.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 16:57:58 -0000 wpaul 2005-10-21 16:57:57 UTC FreeBSD src repository Modified files: usr.sbin/wpa/ndis_events ndis_events.c Log: Hide a diagnostic message under if (verbose) to avoid cluttering the system log when not in verbose logging mode. Revision Changes Path 1.4 +8 -5 src/usr.sbin/wpa/ndis_events/ndis_events.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 17:10:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B72216A420; Fri, 21 Oct 2005 17:10:10 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD2FD43D46; Fri, 21 Oct 2005 17:10:09 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 7BD8EBC84; Fri, 21 Oct 2005 17:10:07 +0000 (UTC) To: Andre Oppermann From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 21 Oct 2005 18:14:54 +0200." <435913FE.774C683D@freebsd.org> Date: Fri, 21 Oct 2005 19:10:07 +0200 Message-ID: <31030.1129914607@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Bruce Evans Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 17:10:10 -0000 In message <435913FE.774C683D@freebsd.org>, Andre Oppermann writes: >> Again, if you have been sitting in DDB, what exactly is the definition >> of "uptime" ? > >IMO it's this: > > Uptime is the time the operating was available to present it's common > services to userland. That excludes any suspend and ddb times. Single > user mode however counts because the OS was servicing userland even if > there was only one user. Uptime is represented in SI seconds. I can live with this definition. So now we just need to be able to reliably measure the "not-uptime". -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Fri Oct 21 17:11:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C979616A41F for ; Fri, 21 Oct 2005 17:11:55 +0000 (GMT) (envelope-from oppermann@networx.ch) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DAEC43D4C for ; Fri, 21 Oct 2005 17:11:54 +0000 (GMT) (envelope-from oppermann@networx.ch) Received: (qmail 19575 invoked from network); 21 Oct 2005 17:17:09 -0000 Received: from c00l3r.networx.ch (HELO networx.ch) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 21 Oct 2005 17:17:09 -0000 Message-ID: <4359216B.68A42960@networx.ch> Date: Fri, 21 Oct 2005 19:12:11 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Marcel Moolenaar References: <30805.1129910750@critter.freebsd.dk> <0D10B55A-A82D-433F-81CA-A5A02B36DA75@xcllnt.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, Andre Oppermann , Bruce Evans , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Poul-Henning Kamp Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 17:11:56 -0000 Marcel Moolenaar wrote: > > On Oct 21, 2005, at 9:05 AM, Poul-Henning Kamp wrote: > > > In message <20051022011020.T5554@delplex.bde.org>, Bruce Evans writes: > > > > > > > >> How do you resync laptops after suspending them for long enough for > >> the clock to drift? Use ntpd and let it step, or use ntpd -x and let > >> it take hours to resync? The right thing to do is step the clocks to > >> the current time immediately so that they are correct while the > >> system > >> is actually being used. > >> > > > > Ahh, and now we get into interesting territory: What _is_ the > > definition of uptime for a laptop which has been suspended ? > > I don't think the definition has to change, but I don't know what > the *exact* definition of uptime is. Wikipedia says this: > > "Uptime is a measure of the time a computer system has been up and > running. It came into use to describe the opposite of downtime, > times when a system was non-operational." > > Given this, suspend is downtime and the uptime is therefore defined > as the amount of time since resume. > > Doesn't seem unreasonable to me. > > > Again, if you have been sitting in DDB, what exactly is the definition > > of "uptime" ? > > Since the kernel is non-operational while in DDB, uptime is to > reset when leaving DDB. Again, according to the Wikipedia definition > of uptime. I'm having more problems finding this reasonable, but > it's not unacceptable. > > The question therefore is: which definition of uptime do we try to > implement? The question is "up and running" since when? Since the last interruption (suspend or ddb) or since the last initialization of the kernel (boot or reboot)? IMO the latter minus the former in SI seconds. -- Andre From owner-cvs-src@FreeBSD.ORG Fri Oct 21 17:14:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBE9816A420 for ; Fri, 21 Oct 2005 17:14:09 +0000 (GMT) (envelope-from oppermann@networx.ch) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6807043D48 for ; Fri, 21 Oct 2005 17:14:08 +0000 (GMT) (envelope-from oppermann@networx.ch) Received: (qmail 19604 invoked from network); 21 Oct 2005 17:19:23 -0000 Received: from c00l3r.networx.ch (HELO networx.ch) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 21 Oct 2005 17:19:23 -0000 Message-ID: <435921F1.5E9050AD@networx.ch> Date: Fri, 21 Oct 2005 19:14:25 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Poul-Henning Kamp References: <31030.1129914607@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org, Bruce Evans Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 17:14:09 -0000 Poul-Henning Kamp wrote: > > In message <435913FE.774C683D@freebsd.org>, Andre Oppermann writes: > > >> Again, if you have been sitting in DDB, what exactly is the definition > >> of "uptime" ? > > > >IMO it's this: > > > > Uptime is the time the operating was available to present it's common > > services to userland. That excludes any suspend and ddb times. Single > > user mode however counts because the OS was servicing userland even if > > there was only one user. Uptime is represented in SI seconds. > > I can live with this definition. > > So now we just need to be able to reliably measure the "not-uptime". Umm... Whenever the onesec tick is not incrementing the uptime (and monotonic) counter. Which conviniently already is the case when OS is suspended or in DDB. -- Andre From owner-cvs-src@FreeBSD.ORG Fri Oct 21 17:19:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 45C5A16A41F; Fri, 21 Oct 2005 17:19:57 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id C21EF43D45; Fri, 21 Oct 2005 17:19:56 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 73E74BC50; Fri, 21 Oct 2005 17:19:55 +0000 (UTC) To: Andre Oppermann From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 21 Oct 2005 19:14:25 +0200." <435921F1.5E9050AD@networx.ch> Date: Fri, 21 Oct 2005 19:19:54 +0200 Message-ID: <31104.1129915194@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org, Bruce Evans Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 17:19:57 -0000 In message <435921F1.5E9050AD@networx.ch>, Andre Oppermann writes: >> >IMO it's this: >> > >> > Uptime is the time the operating was available to present it's common >> > services to userland. That excludes any suspend and ddb times. Single >> > user mode however counts because the OS was servicing userland even if >> > there was only one user. Uptime is represented in SI seconds. >> >> I can live with this definition. >> >> So now we just need to be able to reliably measure the "not-uptime". > >Umm... Whenever the onesec tick is not incrementing the uptime (and >monotonic) counter. Which conviniently already is the case when OS is >suspended or in DDB. Uhm, yes. Only... How do we measure the time our clock does _not_ tick ? We need to use another clock for that. The RTC comes to mind, but it's precision leaves a lot to be desired. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Fri Oct 21 18:59:59 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6E9716A420; Fri, 21 Oct 2005 18:59:59 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F39143D45; Fri, 21 Oct 2005 18:59:59 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LIxxOg028057; Fri, 21 Oct 2005 18:59:59 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LIxxuu028056; Fri, 21 Oct 2005 18:59:59 GMT (envelope-from jkoshy) Message-Id: <200510211859.j9LIxxuu028056@repoman.freebsd.org> From: Joseph Koshy Date: Fri, 21 Oct 2005 18:59:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pmcstat pmcstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 19:00:00 -0000 jkoshy 2005-10-21 18:59:59 UTC FreeBSD src repository Modified files: usr.sbin/pmcstat pmcstat.c Log: Warn the user if the kernel driver dropped samples or ran out of event buffers during a data collection run. Revision Changes Path 1.10 +27 -2 src/usr.sbin/pmcstat/pmcstat.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 19:04:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14F8516A41F; Fri, 21 Oct 2005 19:04:25 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 541EE43D46; Fri, 21 Oct 2005 19:04:24 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j9LJ4MXR087858; Fri, 21 Oct 2005 12:04:22 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <4359216B.68A42960@networx.ch> References: <30805.1129910750@critter.freebsd.dk> <0D10B55A-A82D-433F-81CA-A5A02B36DA75@xcllnt.net> <4359216B.68A42960@networx.ch> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <3F6E14D5-73B2-448A-9440-32DFFBF4E9C4@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Fri, 21 Oct 2005 12:04:20 -0700 To: Andre Oppermann X-Mailer: Apple Mail (2.734) Cc: src-committers@FreeBSD.org, Andre Oppermann , Bruce Evans , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Poul-Henning Kamp Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 19:04:25 -0000 On Oct 21, 2005, at 10:12 AM, Andre Oppermann wrote: > Marcel Moolenaar wrote: > >> >> On Oct 21, 2005, at 9:05 AM, Poul-Henning Kamp wrote: >> >> >>> In message <20051022011020.T5554@delplex.bde.org>, Bruce Evans >>> writes: >>> >>> >>> >>> >>>> How do you resync laptops after suspending them for long enough for >>>> the clock to drift? Use ntpd and let it step, or use ntpd -x >>>> and let >>>> it take hours to resync? The right thing to do is step the >>>> clocks to >>>> the current time immediately so that they are correct while the >>>> system >>>> is actually being used. >>>> >>>> >>> >>> Ahh, and now we get into interesting territory: What _is_ the >>> definition of uptime for a laptop which has been suspended ? >>> >> >> I don't think the definition has to change, but I don't know what >> the *exact* definition of uptime is. Wikipedia says this: >> >> "Uptime is a measure of the time a computer system has been up and >> running. It came into use to describe the opposite of downtime, >> times when a system was non-operational." >> >> Given this, suspend is downtime and the uptime is therefore defined >> as the amount of time since resume. >> >> Doesn't seem unreasonable to me. >> >> >>> Again, if you have been sitting in DDB, what exactly is the >>> definition >>> of "uptime" ? >>> >> >> Since the kernel is non-operational while in DDB, uptime is to >> reset when leaving DDB. Again, according to the Wikipedia definition >> of uptime. I'm having more problems finding this reasonable, but >> it's not unacceptable. >> >> The question therefore is: which definition of uptime do we try to >> implement? >> > > The question is "up and running" since when? Since the last > interruption (suspend or ddb) or since the last initialization > of the kernel (boot or reboot)? IMO the latter minus the former > in SI seconds. I think the accepted property is that uptime is continuous. Put differently: the Wikipedia definition defines uptime as the opposite of downtime. Since downtime is non-qualified, there's no distinction between boot, reboot, suspend or in-debugger. Non-operational is non-operational. Thus the question of "since when" can be answered as: the first time it became operational after being non-operational. Note also that the state of being non-operational is unqualified as to its duration. It is, theoretically speaking, possible to define a missed clock interrupt as having had a state of non- operation because operation implies being able to service clock interrupts... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Fri Oct 21 19:12:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9EFC116A41F; Fri, 21 Oct 2005 19:12:07 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A27743D46; Fri, 21 Oct 2005 19:12:07 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id DE07ABC84; Fri, 21 Oct 2005 19:12:03 +0000 (UTC) To: Marcel Moolenaar From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 21 Oct 2005 12:04:20 PDT." <3F6E14D5-73B2-448A-9440-32DFFBF4E9C4@xcllnt.net> Date: Fri, 21 Oct 2005 21:12:03 +0200 Message-ID: <31627.1129921923@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: src-committers@FreeBSD.org, Andre Oppermann , Bruce Evans , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Andre Oppermann Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 19:12:07 -0000 In message <3F6E14D5-73B2-448A-9440-32DFFBF4E9C4@xcllnt.net>, Marcel Moolenaar writes: >Thus the question of "since when" can be answered as: the first >time it became operational after being non-operational. Bad definition: it literally means it should start counting from the first boot of the operating system. I think we need the definition to consider if (process- ?)state is retained while the system is unconcious or not. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Fri Oct 21 19:39:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5125A16A420; Fri, 21 Oct 2005 19:39:02 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9BA343D46; Fri, 21 Oct 2005 19:39:01 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j9LJcx6N088064; Fri, 21 Oct 2005 12:39:00 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <31627.1129921923@critter.freebsd.dk> References: <31627.1129921923@critter.freebsd.dk> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <01DFB595-5279-4D3A-BEDA-5F0285E9519B@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Fri, 21 Oct 2005 12:38:59 -0700 To: Poul-Henning Kamp X-Mailer: Apple Mail (2.734) Cc: src-committers@FreeBSD.org, Andre Oppermann , Bruce Evans , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Andre Oppermann Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 19:39:02 -0000 On Oct 21, 2005, at 12:12 PM, Poul-Henning Kamp wrote: > In message <3F6E14D5-73B2-448A-9440-32DFFBF4E9C4@xcllnt.net>, > Marcel Moolenaar > writes: > > >> Thus the question of "since when" can be answered as: the first >> time it became operational after being non-operational. >> > > Bad definition: it literally means it should start counting from > the first boot of the operating system. No I meant that uptime is defined in terms of the most recent activation time, where activation is the switch from non-operational to operational. The use of "first" was confusing as it would imply there can be more, which there can't be. Bad wording... > I think we need the definition to consider if (process- ?)state is > retained while the system is unconcious or not. I'm not sure. I think that might be what makes the definition complex. The use of operational vs. non-operational in absolute sense seems to avoid a lot of complexities without being unnatural. Sure, the DDB case is weird, but we can all agree that no new processes can be forked while in DDB (due to the fact that no process is running). This, the running of processes, is also part of the operational state of an operating system. Even suspend and hibernation are covered quite naturally. We only have to let go of boot or reboot as the beginning of the operational state... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Fri Oct 21 19:42:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CAD1716A41F; Fri, 21 Oct 2005 19:42:43 +0000 (GMT) (envelope-from ade@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A48143D46; Fri, 21 Oct 2005 19:42:43 +0000 (GMT) (envelope-from ade@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9LJghe8030034; Fri, 21 Oct 2005 19:42:43 GMT (envelope-from ade@repoman.freebsd.org) Received: (from ade@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9LJghO1030033; Fri, 21 Oct 2005 19:42:43 GMT (envelope-from ade) Message-Id: <200510211942.j9LJghO1030033@repoman.freebsd.org> From: Ade Lovett Date: Fri, 21 Oct 2005 19:42:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/alpha/alpha pmap.c src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 19:42:43 -0000 ade 2005-10-21 19:42:43 UTC FreeBSD src repository Modified files: sys/alpha/alpha pmap.c sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c sys/ia64/ia64 pmap.c Log: Specifically panic() in the case where pmap_insert_entry() fails to get a new pv under high system load where the available pv entries have been exhausted before the pagedaemon has a chance to wake up to reclaim some. Prior to this, the NULL pointer dereference ended up causing secondary panics with rather less than useful resulting tracebacks. Reviewed by: alc, jhb MFC after: 1 week Revision Changes Path 1.180 +2 -0 src/sys/alpha/alpha/pmap.c 1.529 +2 -0 src/sys/amd64/amd64/pmap.c 1.533 +2 -0 src/sys/i386/i386/pmap.c 1.167 +2 -0 src/sys/ia64/ia64/pmap.c From owner-cvs-src@FreeBSD.ORG Fri Oct 21 19:47:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 876D516A41F; Fri, 21 Oct 2005 19:47:05 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AE0E43D49; Fri, 21 Oct 2005 19:47:05 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from freefall.freebsd.org (csjp@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9LJl58A080236; Fri, 21 Oct 2005 19:47:05 GMT (envelope-from csjp@freefall.freebsd.org) Received: (from csjp@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9LJl5FX080235; Fri, 21 Oct 2005 19:47:05 GMT (envelope-from csjp) Date: Fri, 21 Oct 2005 19:47:05 +0000 From: "Christian S.J. Peron" To: Ade Lovett Message-ID: <20051021194705.GA75578@freefall.freebsd.org> References: <200510211942.j9LJghO1030033@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510211942.j9LJghO1030033@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 19:47:05 -0000 On Fri, Oct 21, 2005 at 07:42:43PM +0000, Ade Lovett wrote: > Specifically panic() in the case where pmap_insert_entry() fails to > get a new pv under high system load where the available pv entries > have been exhausted before the pagedaemon has a chance to wake up > to reclaim some. > > Prior to this, the NULL pointer dereference ended up causing > secondary panics with rather less than useful resulting tracebacks. > This sounds similar to an issue that kris is experiencing on one of his sparc64 SMP devices. It looks likes vm_map_entry_splay() is crashing then while vm_fault is running, it recurses a non-recursable mutex making it difficult to do any debugging. Is it possible that this issue affects sparc64, too? -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team From owner-cvs-src@FreeBSD.ORG Fri Oct 21 19:53:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 368B116A41F; Fri, 21 Oct 2005 19:53:29 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9321243D45; Fri, 21 Oct 2005 19:53:28 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 30B7CBC50; Fri, 21 Oct 2005 19:53:24 +0000 (UTC) To: Marcel Moolenaar From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 21 Oct 2005 12:38:59 PDT." <01DFB595-5279-4D3A-BEDA-5F0285E9519B@xcllnt.net> Date: Fri, 21 Oct 2005 21:53:24 +0200 Message-ID: <31753.1129924404@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: src-committers@FreeBSD.org, Andre Oppermann , Bruce Evans , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Andre Oppermann Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 19:53:29 -0000 In message <01DFB595-5279-4D3A-BEDA-5F0285E9519B@xcllnt.net>, Marcel Moolenaar writes: >> I think we need the definition to consider if (process- ?)state is >> retained while the system is unconcious or not. > >I'm not sure. I think that might be what makes the definition >complex. Actually I don't think it does, it simplifies it. If a process survives across the "unconcious" period, then it follows that CLOCK_MONOTONIC cannot be reset to zero in relation to the unconcious period. But we are only just scratching the surface here, there are tons of ambiguities we need to resolve, for instance: select(...., {3m0s}) suspend [ 2 minutes pass ] resume When does select time out ? One minute after the resume ? Three minutes after the resume ? Right after the resume with a special errno ? Some code should obviously know about the suspend/resume event, dhclient, wep, wpa, bgpd, sshd, just to mention a few But the majority of processes couldn't care less. I wish POSIX gang had taken a look at the HP Integral (I think it came out in 1985 ?) and thought "Gee, we better think about how portable unix should work in the future..." -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Fri Oct 21 19:59:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF52216A41F; Fri, 21 Oct 2005 19:59:31 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45B5343D45; Fri, 21 Oct 2005 19:59:31 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j9LJxRnn010886; Fri, 21 Oct 2005 15:59:29 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <4359216B.68A42960@networx.ch> References: <30805.1129910750@critter.freebsd.dk> <0D10B55A-A82D-433F-81CA-A5A02B36DA75@xcllnt.net> <4359216B.68A42960@networx.ch> Date: Fri, 21 Oct 2005 15:59:27 -0400 To: Andre Oppermann , Marcel Moolenaar From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.1 Cc: src-committers@FreeBSD.org, Andre Oppermann , Bruce Evans , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Poul-Henning Kamp Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 19:59:31 -0000 At 7:12 PM +0200 10/21/05, Andre Oppermann wrote: >Marcel Moolenaar wrote: > > > > The question therefore is: which definition of uptime do we > > try to implement? > >The question is "up and running" since when? Since the last >interruption (suspend or ddb) or since the last initialization >of the kernel (boot or reboot)? IMO the latter minus the former >in SI seconds. For what it is worth, I think both of those measures might be useful for people to know. If both are to be available, I think I would call uptime "the time since the most-recent system initialization", and call the other value something like "waketime". I don't have a strong preference for the specific names to use, but I do think both values can be valuable. So pick one as uptime, and pick a new name for the second one, and add an option to the `uptime' command to report both values. IMO. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Fri Oct 21 20:40:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57D1C16A41F; Fri, 21 Oct 2005 20:40:07 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDC4243D45; Fri, 21 Oct 2005 20:40:06 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j9LKe5An088347; Fri, 21 Oct 2005 13:40:05 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <31753.1129924404@critter.freebsd.dk> References: <31753.1129924404@critter.freebsd.dk> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <440C26C7-38DF-45C8-A36C-31BB75454FE7@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Fri, 21 Oct 2005 13:40:04 -0700 To: "Poul-Henning Kamp" X-Mailer: Apple Mail (2.734) Cc: src-committers@FreeBSD.org, Andre Oppermann , Bruce Evans , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Andre Oppermann Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 20:40:07 -0000 On Oct 21, 2005, at 12:53 PM, Poul-Henning Kamp wrote: > In message <01DFB595-5279-4D3A-BEDA-5F0285E9519B@xcllnt.net>, > Marcel Moolenaar > writes: > > >>> I think we need the definition to consider if (process- ?)state is >>> retained while the system is unconcious or not. >>> >> >> I'm not sure. I think that might be what makes the definition >> complex. >> > > Actually I don't think it does, it simplifies it. > > If a process survives across the "unconcious" period, then it follows > that CLOCK_MONOTONIC cannot be reset to zero in relation to the > unconcious period. Yes, true. But technically speaking, this has no inherent relation to uptime other than in our implementation. It should be perfectly valid to preserve the value of CLOCK_MONOTONIC and not reset it across (some) non-operational states while resetting uptime for those states. Processes just need to be informed about a reset in uptime when they are sensitive to it (and let the system know about it). > select(...., {3m0s}) > suspend > [ 2 minutes pass ] > resume > > When does select time out ? > > One minute after the resume ? > > Three minutes after the resume ? > > Right after the resume with a special errno ? Ah, yes. These are the interesting questions. One possible attempt to solve the problem is that if time is not tracked during the suspend, the suspension has not or can be treated as not having happened. The answer then would be 3 minutes. If time is tracked during the suspension, the select should timeout 1 minute after resume. Another possible solution would be: it depends on what CLOCK_MONOTONIC does. It's probably good to have CLOCK_MONOTONIC represent a difference of 3 minutes when sampled across the timed-out select(2). Anyway: I have not invested anything in understanding timekeeping so I basically don't have any grounds for the statements I make. I think I'd better leave the details to others. I just found the question of what the definition of uptime is interesting in a metaphysical way... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Fri Oct 21 20:48:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E889B16A41F; Fri, 21 Oct 2005 20:48:40 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52D7843D45; Fri, 21 Oct 2005 20:48:40 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id CC559BC7A; Fri, 21 Oct 2005 20:48:36 +0000 (UTC) To: Marcel Moolenaar From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 21 Oct 2005 13:40:04 PDT." <440C26C7-38DF-45C8-A36C-31BB75454FE7@xcllnt.net> Date: Fri, 21 Oct 2005 22:48:36 +0200 Message-ID: <32057.1129927716@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: src-committers@FreeBSD.org, Andre Oppermann , Bruce Evans , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Andre Oppermann Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 20:48:41 -0000 In message <440C26C7-38DF-45C8-A36C-31BB75454FE7@xcllnt.net>, Marcel Moolenaar writes: >Anyway: I have not invested anything in understanding timekeeping >so I basically don't have any grounds for the statements I make. >I think I'd better leave the details to others. I just found the >question of what the definition of uptime is interesting in a >metaphysical way... As in: "Daddy, Do I grow older while I sleep ?" :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sat Oct 22 02:04:43 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A51216A41F; Sat, 22 Oct 2005 02:04:43 +0000 (GMT) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id D911A43D45; Sat, 22 Oct 2005 02:04:42 +0000 (GMT) (envelope-from max@love2party.net) Received: from p54A3F71C.dip.t-dialin.net [84.163.247.28] (helo=donor.laier.local) by mrelayeu.kundenserver.de with ESMTP (Nemesis), id 0ML29c-1ET8kT26nn-00020L; Sat, 22 Oct 2005 04:04:41 +0200 From: Max Laier To: SUZUKI Shinsuke Date: Sat, 22 Oct 2005 04:04:22 +0200 User-Agent: KMail/1.8.2 References: <200510211623.j9LGN1A7011884@repoman.freebsd.org> In-Reply-To: <200510211623.j9LGN1A7011884@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2040384.QgqllQq2HO"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200510220404.39977.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet icmp6.h src/sys/netinet6 icmp6.c in6.c in6.h in6_ifattach.c in6_ifattach.h in6_var.h ip6_output.c mld6.c mld6_var.h nd6.c nd6.h nd6_nbr.c nd6_rtr.c src/share/doc/IPv6 IMPLEMENTATION X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 02:04:43 -0000 --nextPart2040384.QgqllQq2HO Content-Type: multipart/mixed; boundary="Boundary-01=_z4ZWDZLFD8bN0EN" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_z4ZWDZLFD8bN0EN Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 21 October 2005 18:23, you wrote: > suz 2005-10-21 16:23:01 UTC > > FreeBSD src repository > > Modified files: > sys/netinet icmp6.h > sys/netinet6 icmp6.c in6.c in6.h in6_ifattach.c > in6_ifattach.h in6_var.h ip6_output.c > mld6.c mld6_var.h nd6.c nd6.h nd6_nbr.c > nd6_rtr.c > share/doc/IPv6 IMPLEMENTATION > Log: > sync with KAME regarding NDP > > - introduced fine-grain-timer to manage ND-caches and IPv6 > Multicast-Listeners - supports Router-Preference > - better prefix lifetime > management > - more spec-comformant DAD advertisement > - updated RFC/internet-draft revisions > > Obtained from: KAME > Reviewed by: ume, gnn > MFC after: 2 month This fixes build on AMD64 (and maybe others) and should (from my poor=20 understanding of C) do the right thing for anything with a signed time_t -= =20 nontheless this should be fixed better. I assume you want to loop it back = to=20 KAME, still. > Revision Changes Path > 1.9 +157 -83 src/share/doc/IPv6/IMPLEMENTATION > 1.20 +5 -1 src/sys/netinet/icmp6.h > 1.69 +2 -2 src/sys/netinet6/icmp6.c > 1.57 +322 -80 src/sys/netinet6/in6.c > 1.42 +6 -4 src/sys/netinet6/in6.h > 1.31 +7 -21 src/sys/netinet6/in6_ifattach.c > 1.7 +1 -1 src/sys/netinet6/in6_ifattach.h > 1.27 +15 -4 src/sys/netinet6/in6_var.h > 1.100 +14 -13 src/sys/netinet6/ip6_output.c > 1.24 +116 -46 src/sys/netinet6/mld6.c > 1.7 +1 -0 src/sys/netinet6/mld6_var.h > 1.61 +337 -209 src/sys/netinet6/nd6.c > 1.21 +32 -21 src/sys/netinet6/nd6.h > 1.39 +37 -30 src/sys/netinet6/nd6_nbr.c > 1.31 +479 -282 src/sys/netinet6/nd6_rtr.c =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --Boundary-01=_z4ZWDZLFD8bN0EN Content-Type: text/x-diff; charset="iso-8859-6"; name="fix_dirty_shift.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="fix_dirty_shift.diff" Index: in6.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/store/mlaier/fcvs/src/sys/netinet6/in6.c,v retrieving revision 1.57 diff -u -r1.57 in6.c =2D-- in6.c 21 Oct 2005 16:23:00 -0000 1.57 +++ in6.c 22 Oct 2005 01:55:04 -0000 @@ -586,7 +586,7 @@ * signed. */ maxexpire =3D (-1) & =2D ~(1 << ((sizeof(maxexpire) * 8) - 1)); + ~((time_t)1 << ((sizeof(maxexpire) * 8) - 1)); if (ia->ia6_lifetime.ia6t_vltime < maxexpire - ia->ia6_updatetime) { retlt->ia6t_expire =3D ia->ia6_updatetime + @@ -604,7 +604,7 @@ * signed. */ maxexpire =3D (-1) & =2D ~(1 << ((sizeof(maxexpire) * 8) - 1)); + ~((time_t)1 << ((sizeof(maxexpire) * 8) - 1)); if (ia->ia6_lifetime.ia6t_pltime < maxexpire - ia->ia6_updatetime) { retlt->ia6t_preferred =3D ia->ia6_updatetime + Index: nd6.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/store/mlaier/fcvs/src/sys/netinet6/nd6.c,v retrieving revision 1.61 diff -u -r1.61 nd6.c =2D-- nd6.c 21 Oct 2005 16:23:00 -0000 1.61 +++ nd6.c 22 Oct 2005 01:59:05 -0000 @@ -1481,7 +1481,8 @@ =20 /* XXX: we assume time_t is signed. */ maxexpire =3D (-1) & =2D ~(1 << ((sizeof(maxexpire) * 8) - 1)); + ~((time_t)1 << + ((sizeof(maxexpire) * 8) - 1)); if (pr->ndpr_vltime < maxexpire - pr->ndpr_lastupdate) { oprl->prefix[i].expire =3D @@ -2330,7 +2331,8 @@ =20 /* XXX: we assume time_t is signed. */ maxexpire =3D (-1) & =2D ~(1 << ((sizeof(maxexpire) * 8) - 1)); + ~((time_t)1 << + ((sizeof(maxexpire) * 8) - 1)); if (pr->ndpr_vltime < maxexpire - pr->ndpr_lastupdate) { p->expire =3D pr->ndpr_lastupdate + --Boundary-01=_z4ZWDZLFD8bN0EN-- --nextPart2040384.QgqllQq2HO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDWZ43XyyEoT62BG0RAqvwAJ9kWzuVDrPQ2647M8V+SLgWY3PpMACePm/t LCYifskxUpwF+dohZxVOee0= =fQyv -----END PGP SIGNATURE----- --nextPart2040384.QgqllQq2HO-- From owner-cvs-src@FreeBSD.ORG Sat Oct 22 05:01:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8917516A41F; Sat, 22 Oct 2005 05:01:12 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4818C43D46; Sat, 22 Oct 2005 05:01:12 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9M51CKh072962; Sat, 22 Oct 2005 05:01:12 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9M51Ctb072961; Sat, 22 Oct 2005 05:01:12 GMT (envelope-from imp) Message-Id: <200510220501.j9M51Ctb072961@repoman.freebsd.org> From: Warner Losh Date: Sat, 22 Oct 2005 05:01:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 05:01:12 -0000 imp 2005-10-22 05:01:11 UTC FreeBSD src repository Modified files: sys/dev/re if_re.c Log: The controller -> device switch happened in 4.0, fix comment Revision Changes Path 1.59 +1 -1 src/sys/dev/re/if_re.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 05:03:48 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D271F16A41F; Sat, 22 Oct 2005 05:03:48 +0000 (GMT) (envelope-from suz@alaxala.net) Received: from pc1.alaxala.kame.net (kame219.kame.net [203.178.141.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97E8843D46; Sat, 22 Oct 2005 05:03:46 +0000 (GMT) (envelope-from suz@alaxala.net) Received: from localhost (localhost [127.0.0.1]) by pc1.alaxala.kame.net (Postfix) with ESMTP id 4B57D61C6; Sat, 22 Oct 2005 14:04:51 +0900 (JST) Received: from pc1.alaxala.kame.net ([127.0.0.1]) by localhost (pc1.alaxala.kame.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 13515-04; Sat, 22 Oct 2005 14:04:46 +0900 (JST) Received: from flora220.uki-uki.net (240.163.192.61.tokyo.global.alpha-net.ne.jp [61.192.163.240]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pc1.alaxala.kame.net (Postfix) with ESMTP id F23D760C8; Sat, 22 Oct 2005 14:04:45 +0900 (JST) Date: Sat, 22 Oct 2005 14:02:42 +0900 Message-ID: From: SUZUKI Shinsuke To: max@love2party.net X-cite: xcite 1.33 In-Reply-To: <200510220404.39977.max@love2party.net> References: <200510211623.j9LGN1A7011884@repoman.freebsd.org> <200510220404.39977.max@love2party.net> User-Agent: Wanderlust/2.15.1 (Almost Unreal) Emacs/22.0 Mule/5.0 (SAKAKI) Organization: Technical Marketing Dept., ALAXALA Networks Corporation MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: amavisd-new at alaxala.kame.net Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet icmp6.h src/sys/netinet6 icmp6.c in6.c in6.h in6_ifattach.c in6_ifattach.h in6_var.h ip6_output.c mld6.c mld6_var.h nd6.c nd6.h nd6_nbr.c nd6_rtr.c src/share/doc/IPv6 IMPLEMENTATION X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 05:03:49 -0000 Hello Max, >>>>> On Sat, 22 Oct 2005 04:04:22 +0200 >>>>> max@love2party.net(Max Laier) said: > This fixes build on AMD64 (and maybe others) and should (from my > poor understanding of C) do the right thing for anything with a > signed time_t - nontheless this should be fixed better. I assume > you want to loop it back to KAME, still. You patch is okay for me, and I've confirmed it's compiled on sparc64 and ia64, as well as amd64. So I'll commit it soon, and report it back to KAME. Thanks, ---- SUZUKI, Shinsuke @ KAME Project From owner-cvs-src@FreeBSD.ORG Sat Oct 22 05:06:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54D4116A41F; Sat, 22 Oct 2005 05:06:56 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1707043D46; Sat, 22 Oct 2005 05:06:56 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9M56t24073396; Sat, 22 Oct 2005 05:06:55 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9M56tJM073395; Sat, 22 Oct 2005 05:06:55 GMT (envelope-from imp) Message-Id: <200510220506.j9M56tJM073395@repoman.freebsd.org> From: Warner Losh Date: Sat, 22 Oct 2005 05:06:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bfe if_bfe.c src/sys/dev/bge if_bge.c src/sys/dev/lge if_lge.c src/sys/dev/nge if_nge.c src/sys/dev/vge if_vge.c src/sys/dev/usb if_aue.c if_axe.c if_rue.c if_udav.c src/sys/pci if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_tl.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 05:06:56 -0000 imp 2005-10-22 05:06:55 UTC FreeBSD src repository Modified files: sys/dev/bfe if_bfe.c sys/dev/bge if_bge.c sys/dev/lge if_lge.c sys/dev/nge if_nge.c sys/dev/vge if_vge.c sys/dev/usb if_aue.c if_axe.c if_rue.c if_udav.c sys/pci if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_tl.c if_vr.c if_wb.c Log: Replace FreeBSD 3.x syntax (controller miibus0) with 4.x syntax (device miibus) in time for 7.0 :-) Revision Changes Path 1.29 +1 -1 src/sys/dev/bfe/if_bfe.c 1.97 +1 -1 src/sys/dev/bge/if_bge.c 1.44 +1 -1 src/sys/dev/lge/if_lge.c 1.83 +1 -1 src/sys/dev/nge/if_nge.c 1.94 +1 -1 src/sys/dev/usb/if_aue.c 1.34 +1 -1 src/sys/dev/usb/if_axe.c 1.26 +1 -1 src/sys/dev/usb/if_rue.c 1.18 +1 -1 src/sys/dev/usb/if_udav.c 1.21 +1 -1 src/sys/dev/vge/if_vge.c 1.161 +1 -1 src/sys/pci/if_rl.c 1.91 +1 -1 src/sys/pci/if_sf.c 1.143 +1 -1 src/sys/pci/if_sis.c 1.113 +1 -1 src/sys/pci/if_sk.c 1.93 +1 -1 src/sys/pci/if_ste.c 1.105 +1 -1 src/sys/pci/if_tl.c 1.111 +1 -1 src/sys/pci/if_vr.c 1.86 +1 -1 src/sys/pci/if_wb.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 05:07:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44CA316A41F; Sat, 22 Oct 2005 05:07:17 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 034F843D46; Sat, 22 Oct 2005 05:07:17 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9M57Ga6073436; Sat, 22 Oct 2005 05:07:16 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9M57GNA073435; Sat, 22 Oct 2005 05:07:16 GMT (envelope-from suz) Message-Id: <200510220507.j9M57GNA073435@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Sat, 22 Oct 2005 05:07:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 in6.c nd6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 05:07:17 -0000 suz 2005-10-22 05:07:16 UTC FreeBSD src repository Modified files: sys/netinet6 in6.c nd6.c Log: fixed a compilation failure on amd64/sparc64/ia64 Submitted by: max MFC after: 2 month Revision Changes Path 1.58 +2 -2 src/sys/netinet6/in6.c 1.62 +4 -2 src/sys/netinet6/nd6.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 05:12:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7118316A41F; Sat, 22 Oct 2005 05:12:29 +0000 (GMT) (envelope-from suz@alaxala.net) Received: from pc1.alaxala.kame.net (kame219.kame.net [203.178.141.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0950E43D45; Sat, 22 Oct 2005 05:12:29 +0000 (GMT) (envelope-from suz@alaxala.net) Received: from localhost (localhost [127.0.0.1]) by pc1.alaxala.kame.net (Postfix) with ESMTP id DEA9E61C6; Sat, 22 Oct 2005 14:13:33 +0900 (JST) Received: from pc1.alaxala.kame.net ([127.0.0.1]) by localhost (pc1.alaxala.kame.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 13468-09; Sat, 22 Oct 2005 14:13:29 +0900 (JST) Received: from flora220.uki-uki.net (240.163.192.61.tokyo.global.alpha-net.ne.jp [61.192.163.240]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pc1.alaxala.kame.net (Postfix) with ESMTP id 6795B60C8; Sat, 22 Oct 2005 14:13:29 +0900 (JST) Date: Sat, 22 Oct 2005 14:11:26 +0900 Message-ID: From: SUZUKI Shinsuke To: suz@FreeBSD.org X-cite: xcite 1.33 In-Reply-To: <200510220507.j9M57GNA073435@repoman.freebsd.org> References: <200510220507.j9M57GNA073435@repoman.freebsd.org> User-Agent: Wanderlust/2.15.1 (Almost Unreal) Emacs/22.0 Mule/5.0 (SAKAKI) Organization: Technical Marketing Dept., ALAXALA Networks Corporation MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: amavisd-new at alaxala.kame.net Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 in6.c nd6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 05:12:29 -0000 >>>>> On Sat, 22 Oct 2005 05:07:16 +0000 (UTC) >>>>> suz@FreeBSD.org(SUZUKI Shinsuke) said: > Modified files: > sys/netinet6 in6.c nd6.c > Log: > fixed a compilation failure on amd64/sparc64/ia64 > > Submitted by: max Oops, "max" should be "mlaier". From owner-cvs-src@FreeBSD.ORG Sat Oct 22 05:14:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 763EB16A41F; Sat, 22 Oct 2005 05:14:19 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31B0A43D45; Sat, 22 Oct 2005 05:14:19 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9M5EJNX073789; Sat, 22 Oct 2005 05:14:19 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9M5EJl7073788; Sat, 22 Oct 2005 05:14:19 GMT (envelope-from imp) Message-Id: <200510220514.j9M5EJl7073788@repoman.freebsd.org> From: Warner Losh Date: Sat, 22 Oct 2005 05:14:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed_rtl80x9.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 05:14:19 -0000 imp 2005-10-22 05:14:19 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_rtl80x9.c Log: In the ISA case, we call ed_probe_WD80x3 before we call ed_probe_rtl80x9. In the pci case we call ed_probe_rtl80x9 first. In the PCI case we were using the correct nic_offset by accident because softc is initialized to zero. In the isa case we were using the wrong value by accident, since ed_probe_WD80x3 sets the offset value to 0x10. This lead to the identification routines failing. Fix this problem by always initalizing the nic_offset and asic_offset before making ed_{asic,nic}_{in,out}* calls. Revision Changes Path 1.3 +3 -3 src/sys/dev/ed/if_ed_rtl80x9.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 05:15:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 17C9A16A41F; Sat, 22 Oct 2005 05:15:21 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF14C43D48; Sat, 22 Oct 2005 05:15:20 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9M5FKqV073883; Sat, 22 Oct 2005 05:15:20 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9M5FKqu073882; Sat, 22 Oct 2005 05:15:20 GMT (envelope-from wpaul) Message-Id: <200510220515.j9M5FKqu073882@repoman.freebsd.org> From: Bill Paul Date: Sat, 22 Oct 2005 05:15:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 05:15:21 -0000 wpaul 2005-10-22 05:15:20 UTC FreeBSD src repository Modified files: sys/compat/ndis subr_ntoskrnl.c Log: Make the multiple DPC threads an option, and create only one by default. This avoids the need for sched_bind() in the default case so that you can start up the NDIS subsystem at boot time when only CPU 0 is running. There are potentially ways to fix it so that the DPC threads aren't started until after the other CPUs are launched, but doing it correctly is tricky. You need to defer the startup of the ntoskrnl subsystem (ntoskrnl_libinit()), not just defer ndis_attach(). For now, I don't think it will make much difference having just the single DPC thread (I started out with just one anyway). Note that this turns the KeSetTargetProcessorDpc() routine into a no-op, since the CPU number in struct kdpc is now ignored. Revision Changes Path 1.77 +31 -2 src/sys/compat/ndis/subr_ntoskrnl.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 05:16:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 471FB16A41F; Sat, 22 Oct 2005 05:16:54 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0338943D45; Sat, 22 Oct 2005 05:16:54 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9M5GrAP073995; Sat, 22 Oct 2005 05:16:53 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9M5Grh2073994; Sat, 22 Oct 2005 05:16:53 GMT (envelope-from wpaul) Message-Id: <200510220516.j9M5Grh2073994@repoman.freebsd.org> From: Bill Paul Date: Sat, 22 Oct 2005 05:16:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 05:16:54 -0000 wpaul 2005-10-22 05:16:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/compat/ndis subr_ntoskrnl.c Log: MFC: launch just one DPC thread, to avoid possible panic when calling sched_bind() during bootstrap before APs are launched. Revision Changes Path 1.43.2.10 +31 -2 src/sys/compat/ndis/subr_ntoskrnl.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 07:26:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39FEA16A41F; Sat, 22 Oct 2005 07:26:06 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EADC743D46; Sat, 22 Oct 2005 07:26:05 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9M7Q5ls078630; Sat, 22 Oct 2005 07:26:05 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9M7Q5eZ078629; Sat, 22 Oct 2005 07:26:05 GMT (envelope-from imp) Message-Id: <200510220726.j9M7Q5eZ078629@repoman.freebsd.org> From: Warner Losh Date: Sat, 22 Oct 2005 07:26:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed_isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 07:26:06 -0000 imp 2005-10-22 07:26:05 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_isa.c Log: Turns out that we're asking for the MAC address at a bad time in the attach routine. Go ahead and ask for it in the probe routine and be just as wrong as all the other cards that ask for it there... # this gets the RTL8019 on a SBC at work fully functional. 6.0 still treats # the 8019 as a generic NE-2000, so these changes aren't relevant there. Revision Changes Path 1.27 +3 -4 src/sys/dev/ed/if_ed_isa.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 07:43:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6117216A41F; Sat, 22 Oct 2005 07:43:21 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB3A743D48; Sat, 22 Oct 2005 07:43:20 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9M7hKX1079421; Sat, 22 Oct 2005 07:43:20 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9M7hKHv079420; Sat, 22 Oct 2005 07:43:20 GMT (envelope-from imp) Message-Id: <200510220743.j9M7hKHv079420@repoman.freebsd.org> From: Warner Losh Date: Sat, 22 Oct 2005 07:43:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed_isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 07:43:21 -0000 imp 2005-10-22 07:43:20 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_isa.c Log: Add missing softc Revision Changes Path 1.28 +1 -0 src/sys/dev/ed/if_ed_isa.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 08:36:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 867CE16A41F; Sat, 22 Oct 2005 08:36:53 +0000 (GMT) (envelope-from ade@lovett.com) Received: from mail.lovett.com (foo.lovett.com [67.134.38.158]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29F9C43D46; Sat, 22 Oct 2005 08:36:52 +0000 (GMT) (envelope-from ade@lovett.com) Received: from hellfire.lovett.com ([67.134.38.157]:61683) by mail.lovett.com with esmtpa (Exim 4.54 (FreeBSD)) id 1ETEs0-000Fn0-Fk; Sat, 22 Oct 2005 01:36:52 -0700 In-Reply-To: <20051021194705.GA75578@freefall.freebsd.org> References: <200510211942.j9LJghO1030033@repoman.freebsd.org> <20051021194705.GA75578@freefall.freebsd.org> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <2DDE99FB-58D5-496A-97DB-0966DC521DBD@FreeBSD.org> Content-Transfer-Encoding: 7bit From: Ade Lovett Date: Sat, 22 Oct 2005 01:36:51 -0700 To: Christian S.J. Peron X-Mailer: Apple Mail (2.734) Sender: ade@lovett.com X-SA-Exim-Connect-IP: 67.134.38.157 X-SA-Exim-Mail-From: ade@lovett.com X-SA-Exim-Scanned: No (on mail.lovett.com); SAEximRunCond expanded to false Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 08:36:53 -0000 On Oct 21, 2005, at 12:47 , Christian S.J. Peron wrote: > This sounds similar to an issue that kris is experiencing on one of > his sparc64 SMP devices. It looks likes vm_map_entry_splay() is > crashing > then while vm_fault is running, it recurses a non-recursable mutex > making it difficult to do any debugging. Is it possible that this > issue > affects sparc64, too? Not directly, no. pv entries are allocated in a different manner on sparc64. If I can get access to crashdumps on such machines running kernels with both INVARIANTS on *and* off, then I can certainly do some investigation. The backtrace from a non-INVARIANTS kernel wasn't particularly helpful by itself, but when coupled with that of a kernel with it turned on, we were able to locate the underlying source of the problem. -aDe From owner-cvs-src@FreeBSD.ORG Sat Oct 22 08:51:50 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08EC016A41F; Sat, 22 Oct 2005 08:51:50 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5959C43D53; Sat, 22 Oct 2005 08:51:49 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9M8pljG016254; Sat, 22 Oct 2005 18:51:47 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9M8piR9005060; Sat, 22 Oct 2005 18:51:45 +1000 Date: Sat, 22 Oct 2005 18:51:44 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <31104.1129915194@critter.freebsd.dk> Message-ID: <20051022175218.F8139@delplex.bde.org> References: <31104.1129915194@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Andre Oppermann , src-committers@freebsd.org, Andre Oppermann , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 08:51:50 -0000 On Fri, 21 Oct 2005, Poul-Henning Kamp wrote: > In message <435921F1.5E9050AD@networx.ch>, Andre Oppermann writes: >>>> IMO it's this: >>>> >>>> Uptime is the time the operating was available to present it's common >>>> services to userland. That excludes any suspend and ddb times. Single >>>> user mode however counts because the OS was servicing userland even if >>>> there was only one user. Uptime is represented in SI seconds. >>> >>> I can live with this definition. This is a good measure from the point of view of the users of the services. It is not quite right for statistics utilities like vmstat. But systat uses different units that end up being almost equivalent to monotonic time. It doesn't use any of boottime, time(3), gettimeofday(2) or clock_gettime(2); it uses on tick counts. Since the tick counts don't increase during suspend and ddb activity, the act in the same way as CLOCK_MONOTONIC except they are less accurate and are not slewed except for the physical slew from drift in the hardware clock that generates the clock interrupts. >>> So now we just need to be able to reliably measure the "not-uptime". >> >> Umm... Whenever the onesec tick is not incrementing the uptime (and >> monotonic) counter. Which conviniently already is the case when OS is >> suspended or in DDB. > > Uhm, yes. Only... > > How do we measure the time our clock does _not_ tick ? > > We need to use another clock for that. > > The RTC comes to mind, but it's precision leaves a lot to be > desired. It is more than enough except for short term "suspensions" (e.g., ones involving non-interactive single-stepping in ddb), and timecounters normally keep working across short term "suspensions". It's more of a problem that the system might not know when it is suspended or resumed, so it couldn't take the timestamps needed to decide when it wasn't running. As a worst case, suspend/resume might be per-cycle. Bruce From owner-cvs-src@FreeBSD.ORG Sat Oct 22 09:28:02 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E639316A420; Sat, 22 Oct 2005 09:28:02 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E6CBE43D55; Sat, 22 Oct 2005 09:28:01 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9M9S0AC019933; Sat, 22 Oct 2005 19:28:00 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9M9Rvhe009380; Sat, 22 Oct 2005 19:27:58 +1000 Date: Sat, 22 Oct 2005 19:27:57 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Andre Oppermann In-Reply-To: <435913FE.774C683D@freebsd.org> Message-ID: <20051022185422.Q8268@delplex.bde.org> References: <30805.1129910750@critter.freebsd.dk> <435913FE.774C683D@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, Poul-Henning Kamp , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 09:28:03 -0000 On Fri, 21 Oct 2005, Andre Oppermann wrote: > Poul-Henning Kamp wrote: >> Again, if you have been sitting in DDB, what exactly is the definition >> of "uptime" ? > > IMO it's this: > > Uptime is the time the operating was available to present it's common > services to userland. That excludes any suspend and ddb times. Single > user mode however counts because the OS was servicing userland even if > there was only one user. Uptime is represented in SI seconds. I agree for suspend and ddb, but not for single user mode. The system can be shut down to single user mode and restarted without rebooting. Restarting runs /etc/rc etc. The system can hardly be considered to be up until /etc/rc has completed, but we've never bother breaking boottime of providing a beginning-of-uptime variable to give the actual start of uptime. SIngle user mode is even more clearly down for remote services, but ruptime doesn't understand this. I don't really understand the protocol, but ruptime seems to just talk to rwhod; rwhod never understood the difference between local and remote uptime and just uses the kernel boottime like w used to. > Time since boottime is the UTC delta from the time of when the OS > initialized itself to now. Leap seconds cause deviations from uptime. > Time since boottime is represented as numerical delta in seconds from > two UTC timestamps. What's a UTC delta? Deltas don't (shouldn't) depend on the calendar. Leap seconds shouldn't cause deviations. They don't now, since boottime is broken (set backwards) to compensate for them. What are numerical deltas and UTC timestamps? In C99, there are only time_t's in some scale and difftime() to not-necessarily-numerically subtract them. In POSIX, using difftime() is essential sonce the broken scale breaks mainly numerical differences. > Uptime != Time since boottime. Only because the correct base point is not the boot time. We still use boottime for the base, so CLOCK_MONOTONIC only gives a different value due to bugs. Bruce From owner-cvs-src@FreeBSD.ORG Sat Oct 22 09:48:39 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CD1E16A420; Sat, 22 Oct 2005 09:48:39 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id F01B243D46; Sat, 22 Oct 2005 09:48:38 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 4F1ACBC50; Sat, 22 Oct 2005 09:48:36 +0000 (UTC) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 22 Oct 2005 19:27:57 +1000." <20051022185422.Q8268@delplex.bde.org> Date: Sat, 22 Oct 2005 11:48:36 +0200 Message-ID: <34506.1129974516@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andre Oppermann , cvs-all@freebsd.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 09:48:39 -0000 In message <20051022185422.Q8268@delplex.bde.org>, Bruce Evans writes: >What's a UTC delta? Deltas don't (shouldn't) depend on the calendar. As easy as it would be to stick our head in the sand, ignore international treaties,geophysics and astronomy, point to POSIX and ignore leapseconds, it is not an feasible way out for us as an operating system project. UTC deltas does depend on the calendar for now. There is proposal from USA to make them DTRT pending in ITU-R Working Party 7A, but it is meeting fierce opposition from astronomers and geophysicists who hold the position that we can just ignore computers Until the future of leapseconds are resolved, something that could easily take 25 years, we have to deal with them. So an UTC offect contains any leap seconds we are aware off, and consequently, it depends on the calendar. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sat Oct 22 10:17:26 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C144616A41F; Sat, 22 Oct 2005 10:17:26 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D35243D6B; Sat, 22 Oct 2005 10:17:21 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9MAHKbd012534; Sat, 22 Oct 2005 20:17:20 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9MAHGv0015850; Sat, 22 Oct 2005 20:17:17 +1000 Date: Sat, 22 Oct 2005 20:17:16 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <31753.1129924404@critter.freebsd.dk> Message-ID: <20051022193119.R8350@delplex.bde.org> References: <31753.1129924404@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, Andre Oppermann , cvs-src@freebsd.org, cvs-all@freebsd.org, Marcel Moolenaar , Andre Oppermann Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 10:17:27 -0000 On Fri, 21 Oct 2005, Poul-Henning Kamp wrote: > In message <01DFB595-5279-4D3A-BEDA-5F0285E9519B@xcllnt.net>, Marcel Moolenaar > writes: > >>> I think we need the definition to consider if (process- ?)state is >>> retained while the system is unconcious or not. >> >> I'm not sure. I think that might be what makes the definition >> complex. > > Actually I don't think it does, it simplifies it. I agree. Except for statistics progams, it is necessary to keep as much history as practical; in particular, don't forgot the original boot time, and keep supporting averages since boot in vmstat and systat. > If a process survives across the "unconcious" period, then it follows > that CLOCK_MONOTONIC cannot be reset to zero in relation to the > unconcious period. What is survival? Everything might be restarted virtually. > But we are only just scratching the surface here, there are tons of > ambiguities we need to resolve, for instance: > > select(...., {3m0s}) > suspend > [ 2 minutes pass ] > resume > > When does select time out ? > > One minute after the resume ? > > Three minutes after the resume ? > > Right after the resume with a special errno ? As close as possible to 3m0s after select() was called. There are many longstanding bugs in this area. I remember the following: - the stillborn non-option APM_FIXUP_CALLTODO attempts to fix some of them, by reducing all timeouts by the suspend time. (It was stillborn because it is for the pre-callwheel implementation of timeouts but was committed after callwheel timeouts, so it never compiled in any committed version. The uselessness of APM_FIXUP_CALLTODO was hidden by not making it a normal option.) The problem of wrong timeouts after suspend is very old. Not fixing it avoids thundering herds of timeout expiries after suspend. - nanosleep(), select() and poll() use getnanouptime(), getmicrouptime() and getmicrouptime() to not-so-carefully check that the timeout has expired after they wake up (the wakeup is sometimes early or late due to minor inaccuracies; when it is early, we detect that not-so-carefully and go back to sleep; when it is late, we can't recover so we should request the timeout to always be a little early so that we can be as close to on time as possible). These syscalls should use non-get*() versions and non-*uptime() versions so that they actually know if the timeout expired. Using *uptime() doesn't work because it doesn't count suspend time. Using non-*uptime() doesn't quite work either, since the system's best idea of the real time may jump backwards. A monotonic clock that jumps forwards by the suspend time is needed. - realitimexpire() has the same bug as nanosleep() and friends. The very name of this function shows that it should not be using *uptime(). According to setitimer(2), "ITIMER_REAL decrements in real time". Using get*() in it is more justified than in nanosleep() since it is lower level so its efficiency may be important. > Some code should obviously know about the suspend/resume event, > dhclient, wep, wpa, bgpd, sshd, just to mention a few Code like cron should get enough notification be having timeouts expires as soon as possible after resume (if they would have expired during the suspend interval if there was no suspend). Such code can then check the actual time on the correct clock like nanosleep() and friends to see if a critical time has been reached. Bruce From owner-cvs-src@FreeBSD.ORG Sat Oct 22 10:24:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D09C816A41F; Sat, 22 Oct 2005 10:24:53 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5691D43D48; Sat, 22 Oct 2005 10:24:53 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MAOroY092954; Sat, 22 Oct 2005 10:24:53 GMT (envelope-from trhodes@repoman.freebsd.org) Received: (from trhodes@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MAOrPh092953; Sat, 22 Oct 2005 10:24:53 GMT (envelope-from trhodes) Message-Id: <200510221024.j9MAOrPh092953@repoman.freebsd.org> From: Tom Rhodes Date: Sat, 22 Oct 2005 10:24:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 make.conf.5 src/share/examples/etc make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 10:24:54 -0000 trhodes 2005-10-22 10:24:53 UTC FreeBSD src repository Modified files: share/man/man5 make.conf.5 share/examples/etc make.conf Log: A better, more correct explination of NO_SHARED. This could probably use a quick touch up, but at least it's correct. Requested by: ru Revision Changes Path 1.268 +1 -1 src/share/examples/etc/make.conf 1.124 +5 -2 src/share/man/man5/make.conf.5 From owner-cvs-src@FreeBSD.ORG Sat Oct 22 11:32:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 863B816A41F; Sat, 22 Oct 2005 11:32:02 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D6E5B43D48; Sat, 22 Oct 2005 11:32:01 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9MBW0ih032578; Sat, 22 Oct 2005 21:32:00 +1000 Received: from epsplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9MBVuBk012393; Sat, 22 Oct 2005 21:31:58 +1000 Date: Sat, 22 Oct 2005 21:31:57 +1000 (EST) From: Bruce Evans X-X-Sender: bde@epsplex.bde.org To: Poul-Henning Kamp In-Reply-To: <34506.1129974516@critter.freebsd.dk> Message-ID: <20051022205219.O1843@epsplex.bde.org> References: <34506.1129974516@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: Timekeeping [Was: Re: cvs commit: src/usr.bin/vmstat vmstat.c src/usr.bin/w w.c] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 11:32:02 -0000 On Sat, 22 Oct 2005, Poul-Henning Kamp wrote: > In message <20051022185422.Q8268@delplex.bde.org>, Bruce Evans writes: > >> What's a UTC delta? Deltas don't (shouldn't) depend on the calendar. > > As easy as it would be to stick our head in the sand, ignore > international treaties,geophysics and astronomy, point to POSIX and > ignore leapseconds, it is not an feasible way out for us as an > operating system project. > > UTC deltas does depend on the calendar for now. Um, my question was rhetorical. We don't have times in UTC, so calandars are irrelvant. If we had times in UTC, then the right way to determine the delta time seems to be to convert the times to time_t's using timegm(), then subtract using difftime(). Times in UTC cannot be simply be subracted by subtracting in minutes and multiplying by 60, etc. But we can just use difftime(). Provided difftime() actually works. > There is proposal from USA to make them DTRT pending in ITU-R Working > Party 7A, but it is meeting fierce opposition from astronomers and > geophysicists who hold the position that we can just ignore computers They already DTRT IMO. It is what the astronomers want. > Until the future of leapseconds are resolved, something that could > easily take 25 years, we have to deal with them. > > So an UTC offect contains any leap seconds we are aware off, and > consequently, it depends on the calendar. Sure, but we don't have UTC. We have broken time_t's for real times but non-broken time_t's for monotonic times. To subtract these times, the opposite methods to the ones stated by Andre should work (but don't): numerical deltas don't work for either UTC or real times -- they don't work for UTC because UTC isn't numeric, and they don't work for real times since POSIX left out the leap seconds -- difftime() should work for subtracting real times; OTOH, numerical deltas work for monotonic times while difftime() doesn't -- although difftime() takes time_t's as args you can't pass the time_t's given by CLOCK_MONOTONIC to it, since the latter are differences relative to an undocumented start time but difftime() only handles absolute times. Bruce From owner-cvs-src@FreeBSD.ORG Sat Oct 22 14:31:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC32716A41F; Sat, 22 Oct 2005 14:31:02 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88EEF43D46; Sat, 22 Oct 2005 14:31:02 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MEV2w5009043; Sat, 22 Oct 2005 14:31:02 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MEV2JF009042; Sat, 22 Oct 2005 14:31:02 GMT (envelope-from glebius) Message-Id: <200510221431.j9MEV2JF009042@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 22 Oct 2005 14:31:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 14:31:02 -0000 glebius 2005-10-22 14:31:02 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Introduce polling(4) capability for bge(4). Submitted by: Oleg Bulyzhin Revision Changes Path 1.98 +110 -2 src/sys/dev/bge/if_bge.c 1.37 +3 -0 src/sys/dev/bge/if_bgereg.h From owner-cvs-src@FreeBSD.ORG Sat Oct 22 14:38:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44D5816A41F; Sat, 22 Oct 2005 14:38:53 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 023C543D45; Sat, 22 Oct 2005 14:38:53 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MEcqqG009336; Sat, 22 Oct 2005 14:38:52 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MEcqb1009335; Sat, 22 Oct 2005 14:38:52 GMT (envelope-from glebius) Message-Id: <200510221438.j9MEcqb1009335@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 22 Oct 2005 14:38:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 polling.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 14:38:53 -0000 glebius 2005-10-22 14:38:52 UTC FreeBSD src repository Modified files: share/man/man4 polling.4 Log: Add bge(4) to the list of supported devices. Revision Changes Path 1.22 +2 -1 src/share/man/man4/polling.4 From owner-cvs-src@FreeBSD.ORG Sat Oct 22 14:50:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7195616A41F; Sat, 22 Oct 2005 14:50:31 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3901743D5C; Sat, 22 Oct 2005 14:50:28 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MEoRQq009777; Sat, 22 Oct 2005 14:50:27 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MEoR7x009776; Sat, 22 Oct 2005 14:50:27 GMT (envelope-from glebius) Message-Id: <200510221450.j9MEoR7x009776@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 22 Oct 2005 14:50:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet in.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 14:50:31 -0000 glebius 2005-10-22 14:50:27 UTC FreeBSD src repository Modified files: sys/netinet in.c Log: In in_addprefix() compare not only route addresses, but their masks, too. This fixes problem when connected prefixes overlap. Obtained from: OpenBSD (rev. 1.40 by claudio); [ I came to this fix myself, and then found out that OpenBSD had already fixed it the same way.] Revision Changes Path 1.91 +13 -8 src/sys/netinet/in.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 14:54:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B62E16A41F; Sat, 22 Oct 2005 14:54:03 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD6D643D46; Sat, 22 Oct 2005 14:54:02 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MEs2XT009923; Sat, 22 Oct 2005 14:54:02 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MEs2RR009922; Sat, 22 Oct 2005 14:54:02 GMT (envelope-from mlaier) Message-Id: <200510221454.j9MEs2RR009922@repoman.freebsd.org> From: Max Laier Date: Sat, 22 Oct 2005 14:54:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_carp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 14:54:03 -0000 mlaier 2005-10-22 14:54:02 UTC FreeBSD src repository Modified files: sys/netinet ip_carp.c Log: Fix build after in6_joingroup change. It remains unclear if DAD breaks CARP or not. Revision Changes Path 1.33 +2 -2 src/sys/netinet/ip_carp.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 17:50:46 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0155816A41F; Sat, 22 Oct 2005 17:50:46 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B27B043D45; Sat, 22 Oct 2005 17:50:45 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MHoj3Z023385; Sat, 22 Oct 2005 17:50:45 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MHojSc023384; Sat, 22 Oct 2005 17:50:45 GMT (envelope-from mlaier) Message-Id: <200510221750.j9MHojSc023384@repoman.freebsd.org> From: Max Laier Date: Sat, 22 Oct 2005 17:50:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/netstat main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 17:50:46 -0000 mlaier 2005-10-22 17:50:45 UTC FreeBSD src repository Modified files: usr.bin/netstat main.c Log: Fix obvious copy'n'paste-O in rev.1.36 While here nit style. PR: bin/87783 Submitted by: Mats Palmgren MFC after: 1 week Revision Changes Path 1.79 +3 -3 src/usr.bin/netstat/main.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 18:46:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BE4E16A41F; Sat, 22 Oct 2005 18:46:38 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57F2343D45; Sat, 22 Oct 2005 18:46:38 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MIkcxI025447; Sat, 22 Oct 2005 18:46:38 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MIkcgY025446; Sat, 22 Oct 2005 18:46:38 GMT (envelope-from alc) Message-Id: <200510221846.j9MIkcgY025446@repoman.freebsd.org> From: Alan Cox Date: Sat, 22 Oct 2005 18:46:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 18:46:38 -0000 alc 2005-10-22 18:46:38 UTC FreeBSD src repository Modified files: sys/vm vm_object.c Log: Use of the ZERO_COPY_SOCKETS options can result in an unusual state that vm_object_backing_scan() was not written to handle. Specifically, a wired page within a backing object that is shadowed by a page within the shadow object. Handle this state by removing the wired page from the backing object. The wired page will be freed by socow_iodone(). Stop masking errors: If a page is being freed by vm_object_backing_scan(), assert that it is no longer mapped rather than quietly destroying any mappings. Tested by: Harald Schmalzbauer Revision Changes Path 1.351 +12 -4 src/sys/vm/vm_object.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 20:03:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E19416A420; Sat, 22 Oct 2005 20:03:00 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF54643D62; Sat, 22 Oct 2005 20:02:59 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MK2xWY030058; Sat, 22 Oct 2005 20:02:59 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MK2xHH030057; Sat, 22 Oct 2005 20:02:59 GMT (envelope-from alc) Message-Id: <200510222002.j9MK2xHH030057@repoman.freebsd.org> From: Alan Cox Date: Sat, 22 Oct 2005 20:02:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_cow.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 20:03:00 -0000 alc 2005-10-22 20:02:59 UTC FreeBSD src repository Modified files: sys/kern uipc_cow.c Log: Verify that access to the given address is allowed from user-space. Discussed with: rwatson@ Revision Changes Path 1.25 +8 -1 src/sys/kern/uipc_cow.c From owner-cvs-src@FreeBSD.ORG Sat Oct 22 20:47:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D60E816A41F; Sat, 22 Oct 2005 20:47:42 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 549EF43D49; Sat, 22 Oct 2005 20:47:39 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MKldUT038854; Sat, 22 Oct 2005 20:47:39 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MKldHd038853; Sat, 22 Oct 2005 20:47:39 GMT (envelope-from glebius) Message-Id: <200510222047.j9MKldHd038853@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 22 Oct 2005 20:47:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 polling.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 20:47:43 -0000 glebius 2005-10-22 20:47:39 UTC FreeBSD src repository Modified files: share/man/man4 polling.4 Log: Fix typo from last commit. Submitted by: simon Revision Changes Path 1.23 +1 -1 src/share/man/man4/polling.4 From owner-cvs-src@FreeBSD.ORG Sat Oct 22 21:20:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE0AB16A41F; Sat, 22 Oct 2005 21:20:18 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E6D643D6A; Sat, 22 Oct 2005 21:20:18 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MLKIl6039993; Sat, 22 Oct 2005 21:20:18 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MLKIit039992; Sat, 22 Oct 2005 21:20:18 GMT (envelope-from glebius) Message-Id: <200510222120.j9MLKIit039992@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 22 Oct 2005 21:20:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 21:20:19 -0000 glebius 2005-10-22 21:20:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/em if_em.c if_em.h if_em_hw.h Log: Sync with HEAD. Revisions merged: - rev. 1.76. Removed FreeBSD 4.x code. - rev. 1.77, 1.79. Together with rev. 1.71 (already merged) this fixes problems when some code is executed in driver when em_process_receive_interrupts() drops lock. This can occur at runtime, when polling(4) mode is changed to interrupt driver or vise versa, but more likely this can happen when administrator issues some ifconfig commands. - rev. 1.78. In em_process_receive_interrupts(), call bus_dmamap_sync() for the descriptors set each time we modify one descriptor, instead of doing it only at the function exit. - rev. 1.80. Loop in em_intr() until interrupt cause register is clear, don't mask overrun interrupt. - rev. 1.81. Several locking and other fixes. See particular revision logs for more detailed information. Approved by: re Revision Changes Path 1.65.2.6 +72 -157 src/sys/dev/em/if_em.c 1.32.2.1 +1 -12 src/sys/dev/em/if_em.h 1.15.2.1 +1 -0 src/sys/dev/em/if_em_hw.h From owner-cvs-src@FreeBSD.ORG Sat Oct 22 22:07:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19A0016A41F; Sat, 22 Oct 2005 22:07:21 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB26D43D48; Sat, 22 Oct 2005 22:07:20 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9MM7KKe041744; Sat, 22 Oct 2005 22:07:20 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9MM7KRc041743; Sat, 22 Oct 2005 22:07:20 GMT (envelope-from glebius) Message-Id: <200510222207.j9MM7KRc041743@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 22 Oct 2005 22:07:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 22:07:21 -0000 glebius 2005-10-22 22:07:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) sys/dev/em if_em.c if_em.h if_em_hw.h Log: Sync with HEAD. Revisions merged: - rev. 1.76. Removed FreeBSD 4.x code. - rev. 1.77, 1.79. Together with rev. 1.71 (already merged) this fixes problems when some code is executed in driver when em_process_receive_interrupts() drops lock. This can occur at runtime, when polling(4) mode is changed to interrupt driver or vise versa, but more likely this can happen when administrator issues some ifconfig commands. - rev. 1.78. In em_process_receive_interrupts(), call bus_dmamap_sync() for the descriptors set each time we modify one descriptor, instead of doing it only at the function exit. - rev. 1.80. Loop in em_intr() until interrupt cause register is clear, don't mask overrun interrupt. - rev. 1.81. Several locking and other fixes. See particular revision logs for more detailed information. Approved by: re Revision Changes Path 1.65.2.5.2.1 +72 -157 src/sys/dev/em/if_em.c 1.32.4.1 +1 -12 src/sys/dev/em/if_em.h 1.15.4.1 +1 -0 src/sys/dev/em/if_em_hw.h