From owner-freebsd-bugs@FreeBSD.ORG  Sun Apr 17 02:53:29 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 49F0916A4CE; Sun, 17 Apr 2005 02:53:29 +0000 (GMT)
Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E477743D39; Sun, 17 Apr 2005 02:53:28 +0000 (GMT)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (localhost [127.0.0.1])
	by VARK.MIT.EDU (8.13.3/8.13.1) with ESMTP id j3H2rRcs064473;
	Sat, 16 Apr 2005 22:53:27 -0400 (EDT)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.MIT.EDU (8.13.3/8.13.1/Submit) id j3H2rRNE064471;
	Sat, 16 Apr 2005 22:53:27 -0400 (EDT)
	(envelope-from das@FreeBSD.ORG)
Date: Sat, 16 Apr 2005 22:53:27 -0400
From: David Schultz <das@FreeBSD.ORG>
To: Xin LI <delphij@FreeBSD.ORG>
Message-ID: <20050417025327.GA20089@VARK.MIT.EDU>
Mail-Followup-To: Xin LI <delphij@FreeBSD.ORG>,
	lx@knight.6test.edu.cn, freebsd-bugs@FreeBSD.ORG,
	freebsd-standards@FreeBSD.ORG
References: <200504161637.j3GGbchA015884@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200504161637.j3GGbchA015884@freefall.freebsd.org>
cc: freebsd-standards@FreeBSD.ORG
cc: freebsd-bugs@FreeBSD.ORG
cc: lx@knight.6test.edu.cn
Subject: Re: kern/80008: Unnecessary requirement of sa_len in getnameinfo()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Apr 2005 02:53:29 -0000

On Sat, Apr 16, 2005, Xin LI wrote:
> Synopsis: Unnecessary requirement of sa_len in getnameinfo()
> 
> State-Changed-From-To: open->analyzed
> State-Changed-By: delphij
> State-Changed-When: Sat Apr 16 16:33:02 GMT 2005
> State-Changed-Why: 
> Dear freebsd-standards,
> 
> Would you please review the following patch?  I have consulted with POSIX
> standard and there is no requirement that there must be a "sa_len" field
> in sockaddr.  Therefore, I think the check should be either removed, or
> be replaced with an assignment.

Yeah, sa_len has always been a portability problem.  Your proposed
change looks fine to me.