From owner-freebsd-bugs@FreeBSD.ORG Sun May 22 10:30:06 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A98D16A41C for ; Sun, 22 May 2005 10:30:06 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D995343D4C for ; Sun, 22 May 2005 10:30:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4MAU58r072859 for ; Sun, 22 May 2005 10:30:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4MAU5Bb072856; Sun, 22 May 2005 10:30:05 GMT (envelope-from gnats) Date: Sun, 22 May 2005 10:30:05 GMT Message-Id: <200505221030.j4MAU5Bb072856@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Wojciech A. Koszek" Cc: Subject: Re: kern/81349: [PATCH] Wrong error code is returned in ng_eiface(4) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Wojciech A. Koszek" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 May 2005 10:30:06 -0000 The following reply was made to PR kern/81349; it has been noted by GNATS. From: "Wojciech A. Koszek" To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/81349: [PATCH] Wrong error code is returned in ng_eiface(4) Date: Sun, 22 May 2005 10:35:05 +0000 --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, I've noticed error returned in other Netgraph nodes when we create hook with improper name differs without any reason. Attachement contains patch which fixes inconsistency. -- * Wojciech A. Koszek && dunstan@FreeBSD.czest.pl --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=NG-errorcode Index: ng_eiface.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_eiface.c,v retrieving revision 1.31 diff -r1.31 ng_eiface.c 384c384 < return (EPFNOSUPPORT); --- > return (EINVAL); Index: ng_gif_demux.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_gif_demux.c,v retrieving revision 1.10 diff -r1.10 ng_gif_demux.c 263c263 < return (EPFNOSUPPORT); --- > return (EINVAL); Index: ng_iface.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_iface.c,v retrieving revision 1.41 diff -r1.41 ng_iface.c 527c527 < return (EPFNOSUPPORT); --- > return (EINVAL); Index: ng_split.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_split.c,v retrieving revision 1.5 diff -r1.5 ng_split.c 116c116 < return (EPFNOSUPPORT); --- > return (EINVAL); --GvXjxJ+pjyke8COw--