From owner-freebsd-current@FreeBSD.ORG Sun Jun 26 01:50:35 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B95E216A41C; Sun, 26 Jun 2005 01:50:35 +0000 (GMT) (envelope-from maksim.yevmenkin@savvis.net) Received: from mta11.adelphia.net (mta11.adelphia.net [68.168.78.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5977A43D48; Sun, 26 Jun 2005 01:50:35 +0000 (GMT) (envelope-from maksim.yevmenkin@savvis.net) Received: from [192.168.1.254] (really [70.32.199.60]) by mta11.adelphia.net (InterMail vM.6.01.04.01 201-2131-118-101-20041129) with ESMTP id <20050626015034.GWKS24042.mta11.adelphia.net@[192.168.1.254]>; Sat, 25 Jun 2005 21:50:34 -0400 Message-ID: <42BE09FA.8080000@savvis.net> Date: Sat, 25 Jun 2005 18:50:50 -0700 From: Maksim Yevmenkin User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <20050625115421.GA13063@ip.net.ua> <20050625120226.GK14567@elvis.mu.org> <42BD6865.4090608@savvis.net> <20050625.145357.85412052.imp@bsdimp.com> In-Reply-To: <20050625.145357.85412052.imp@bsdimp.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: [patch] ep(4) panic X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2005 01:50:35 -0000 Warner, > : the way i understand it: this code is in the "probe" routine and when > : its called ifp structure was not allocated/setup yet. the "attach" > : routine will call "ep_attach" later that will allocate/setup ifp and > : read/set mac address (once again). so, the card works just fine. > : > : it is interesting that my 4.x has different comment > : > : $FreeBSD: /repoman/r/ncvs/src/sys/dev/ep/if_ep_pccard.c,v 1.12.2.3 > : 2003/10/06 02:53:51 imp Exp $ > : > : /* > : * For some reason the 3c574 needs this. > : */ > : ep_get_macaddr(sc, (u_char *)&sc->arpcom.ac_enaddr); > : > : > : perhaps the comment in -current should be changed as well? can anyone > : please shed some light on this? > > The comment in -current is wrong. The routine doesn't set the MAC > address, but instead just reads it out of EEPROM. For reasons I still > don't know or understand, this still seems to be required. I'll have > to look into when I have an hour or two to kill. > > The following patch works on: > 3CCFE547BT, 3C574-TX, 3CCE589EC, 3C589D-TP, 3C589C, 3C589B, > 3C562D/3C563D, 3CCFEM556 > > which covers almost all the cards that are obtainable these days. It > doesn't work with: > > 3C1 (we've never worked with this card) > 3C562 or 3C562B/3C563B I think that there's an address line > work around needed for thse two cards. > 5.x doesn't seem to work with them > either. > > So I think it is good/safe to commit. I'll ask the RE if people here > test it. thank you for spending your time and looking into this. your patch is essentially the same as my original patch. i expect this patch to work just fine. i will double check it on monday. thanks, max