From owner-freebsd-cvsweb@FreeBSD.ORG Mon Apr 4 22:35:20 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E58A316A4CE for ; Mon, 4 Apr 2005 22:35:19 +0000 (GMT) Received: from smtp818.mail.sc5.yahoo.com (smtp818.mail.sc5.yahoo.com [66.163.170.4]) by mx1.FreeBSD.org (Postfix) with SMTP id 6489343D31 for ; Mon, 4 Apr 2005 22:35:19 +0000 (GMT) (envelope-from noackjr@alumni.rice.edu) Received: from unknown (HELO optimator.noacks.org) (noacks@swbell.net@70.240.208.130 with login) by smtp818.mail.sc5.yahoo.com with SMTP; 4 Apr 2005 21:51:24 -0000 Received: from localhost (localhost [127.0.0.1]) by optimator.noacks.org (Postfix) with ESMTP id 1662C6196; Mon, 4 Apr 2005 16:51:24 -0500 (CDT) Received: from optimator.noacks.org ([127.0.0.1]) by localhost (optimator.noacks.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 84862-09; Mon, 4 Apr 2005 16:51:22 -0500 (CDT) Received: from [127.0.0.1] (optimator [192.168.1.11]) by optimator.noacks.org (Postfix) with ESMTP id 352B9610A; Mon, 4 Apr 2005 16:51:22 -0500 (CDT) Message-ID: <4251B6D8.4090907@alumni.rice.edu> Date: Mon, 04 Apr 2005 16:51:20 -0500 From: Jon Noack User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jerry Nairn References: <3bccd73d050401103575526b2c@mail.gmail.com> In-Reply-To: <3bccd73d050401103575526b2c@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at noacks.org cc: scop@FreeBSD.org cc: freebsd-cvsweb@freebsd.org Subject: Re: [BUG] unknown-left unknown-right on diff of identical revisions X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: noackjr@alumni.rice.edu List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2005 22:35:20 -0000 Jerry Nairn wrote: > Hi, > When you do a human readable colored or long colored diff of revisions > which happen to be identical, like you might get by merging two branches, > the revisions shown in the page are 'unknown-left' and 'unknown-right'. > Maybe this is because of a difference in the way rcsdiff works on > different platforms. I don't know. > In the human_readable_diff subroutine, rcsdiff output is parsed to get > revision numbers. (Seems kind of goofy when you already have the revision > numbers.) When there is no output from rcsdiff, this doesn't work, and > these lines set the revisions to 'unknown-left' and 'unknown-right': > > $rev1 = 'unknown-left' unless defined($rev1); > $rev2 = 'unknown-right' unless defined($rev2); > > I added these lines before those two lines above to fix this problem. I'm > sure there's a nicer way to do this. > > $rev1 = $input{tr1} unless defined($rev1); > $rev2 = $input{tr2} unless defined($rev2); > > Sorry if you get this twice. I sent this yesterday, but got no bounced > mail and did not see it on the list. > Cheers, > > Jerry Nairn Hi Jerry, Your change only works for revisions you type into the text field. Here's a more robust fix: Index: cvsweb.cgi =================================================================== RCS file: /home/ncvs/projects/cvsweb/cvsweb.cgi,v retrieving revision 1.291 diff -u -r1.291 cvsweb.cgi --- cvsweb.cgi 22 Jan 2005 12:43:55 -0000 1.291 +++ cvsweb.cgi 4 Apr 2005 20:32:03 -0000 @@ -3641,8 +3641,14 @@ $rev2 = $r2r; $date2 = $r2d; } - $rev1 = 'unknown-left' unless defined($rev1); - $rev2 = 'unknown-right' unless defined($rev2); + $rev1 = $input{r1} unless defined($rev1); + if ($rev1 eq 'text') { + $rev1 = $input{tr1}; + } + $rev2 = $input{r2} unless defined($rev2); + if ($rev2 eq 'text') { + $rev2 = $input{tr2}; + } $date1 = defined($date1) ? ', ' . htmlquote($date1) : ''; $date2 = defined($date2) ? ', ' . htmlquote($date2) : ''; Note that you can still enter arbitrary revisions as we are not validating them and rcsdiff seems to default to the latest revision on the branch for invalid revisions. For example, if the latest revision is 1.35 and you try for a diff between 1.34 and 1.45, it will give you the diff between 1.34 and 1.35 instead. Likewise, if the latest revision on a branch is 1.14.2.9 and you try for 1.14.2.10, it'll use 1.14.2.9 instead. Not also that rcsdiff doesn't produce any (normal) output for invalid branches, so you'll get "no viewable change" in that case. Ideally we should be parsing the STDERR output of rcsdiff. That will give us revision numbers even if the files are identical and will also provide a helpful error message when an invalid branch is specified. Either that or we should validate all revisions/branches ourselves... Ville, if this patch looks good to you please commit it. Jon From owner-freebsd-cvsweb@FreeBSD.ORG Tue Apr 5 17:05:45 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA32A16A4CE for ; Tue, 5 Apr 2005 17:05:45 +0000 (GMT) Received: from ms-smtp-03-eri0.southeast.rr.com (ms-smtp-03-lbl.southeast.rr.com [24.25.9.102]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECC2B43D1F for ; Tue, 5 Apr 2005 17:05:44 +0000 (GMT) (envelope-from enviro-tech@carolina.rr.com) Received: from oemcomputer (cpe-024-074-022-011.carolina.res.rr.com [24.74.22.11])j35H5aY4021399; Tue, 5 Apr 2005 13:05:37 -0400 (EDT) Message-ID: <4252C565.2000900@carolina.rr.com> Date: Tue, 05 Apr 2005 13:05:41 -0400 From: Dennis McGee Organization: Enviro-Tech Enterprises, Inc. User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-cvsweb@FreeBSD.org Content-Type: multipart/mixed; boundary="------------080601070606060108020407" X-Antivirus: avast! (VPS 0514-0, 04/05/2005), Outbound message X-Antivirus-Status: Clean X-Virus-Scanned: Symantec AntiVirus Scan Engine X-Content-Filtered-By: Mailman/MimeDel 2.1.1 Subject: http://cvs.handhelds.org/cgi-bin/viewcvs.cgi/linux/kernel.? X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: enviro-tech@carolina.rr.com List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2005 17:05:45 -0000 This is a multi-part message in MIME format. --------------080601070606060108020407 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Looking for: http://cvs.handhelds.org/cgi-bin/viewcvs.cgi/linux/kernel. Is it available some place? Thanks loads! DM --------------080601070606060108020407 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-Description: avast info --- avast! Antivirus: Outbound message clean. Virus Database (VPS): 0514-0, 04/05/2005 Tested on: 4/5/05 1:05:47 PM avast! - copyright (c) 1988-2005 ALWIL Software. http://www.avast.com --------------080601070606060108020407-- From owner-freebsd-cvsweb@FreeBSD.ORG Tue Apr 5 17:26:39 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1ACB716A4CE for ; Tue, 5 Apr 2005 17:26:39 +0000 (GMT) Received: from smtp804.mail.sc5.yahoo.com (smtp804.mail.sc5.yahoo.com [66.163.168.183]) by mx1.FreeBSD.org (Postfix) with SMTP id D1FD743D55 for ; Tue, 5 Apr 2005 17:26:38 +0000 (GMT) (envelope-from noackjr@alumni.rice.edu) Received: from unknown (HELO optimator.noacks.org) (noacks@swbell.net@70.240.251.38 with login) by smtp804.mail.sc5.yahoo.com with SMTP; 5 Apr 2005 17:26:04 -0000 Received: from localhost (localhost [127.0.0.1]) by optimator.noacks.org (Postfix) with ESMTP id 0422861D0; Tue, 5 Apr 2005 12:26:01 -0500 (CDT) Received: from optimator.noacks.org ([127.0.0.1]) by localhost (optimator.noacks.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 06990-13; Tue, 5 Apr 2005 12:25:58 -0500 (CDT) Received: from [127.0.0.1] (optimator [192.168.1.11]) by optimator.noacks.org (Postfix) with ESMTP id 3AB0461A7; Tue, 5 Apr 2005 12:25:58 -0500 (CDT) Message-ID: <4252CA22.7050403@alumni.rice.edu> Date: Tue, 05 Apr 2005 12:25:54 -0500 From: Jon Noack User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: enviro-tech@carolina.rr.com References: <4252C565.2000900@carolina.rr.com> In-Reply-To: <4252C565.2000900@carolina.rr.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at noacks.org cc: freebsd-cvsweb@FreeBSD.org Subject: Re: http://cvs.handhelds.org/cgi-bin/viewcvs.cgi/linux/kernel.? X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: noackjr@alumni.rice.edu List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2005 17:26:39 -0000 On 4/5/2005 12:05 PM, Dennis McGee wrote: > http://cvs.handhelds.org/cgi-bin/viewcvs.cgi/linux/kernel. > > Is it available some place? Thanks loads! I tried to go there and got redirected to the following: http://handhelds.org/cgi-bin/cvsweb.cgi/linux/kernel/ If that is not what you are looking for, more information can be found here: http://www.handhelds.org/sources.html Specifically, the handhelds@handhelds.org mailing list may be relevant. This mailing list (freebsd-cvsweb@freebsd.org) is for CVSweb and is not affiliated with handhelds.org. Jon From owner-freebsd-cvsweb@FreeBSD.ORG Tue Apr 5 20:41:59 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3BF416A4CE for ; Tue, 5 Apr 2005 20:41:59 +0000 (GMT) Received: from smtp818.mail.sc5.yahoo.com (smtp818.mail.sc5.yahoo.com [66.163.170.4]) by mx1.FreeBSD.org (Postfix) with SMTP id 8043743D48 for ; Tue, 5 Apr 2005 20:41:59 +0000 (GMT) (envelope-from noackjr@alumni.rice.edu) Received: from unknown (HELO optimator.noacks.org) (noacks@swbell.net@70.240.251.38 with login) by smtp818.mail.sc5.yahoo.com with SMTP; 5 Apr 2005 20:41:38 -0000 Received: from localhost (localhost [127.0.0.1]) by optimator.noacks.org (Postfix) with ESMTP id 9D89461D0; Tue, 5 Apr 2005 15:41:37 -0500 (CDT) Received: from optimator.noacks.org ([127.0.0.1]) by localhost (optimator.noacks.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 08875-04; Tue, 5 Apr 2005 15:41:34 -0500 (CDT) Received: from [127.0.0.1] (optimator [192.168.1.11]) by optimator.noacks.org (Postfix) with ESMTP id BBA1F612C; Tue, 5 Apr 2005 15:41:34 -0500 (CDT) Message-ID: <4252F7FE.1050507@alumni.rice.edu> Date: Tue, 05 Apr 2005 15:41:34 -0500 From: Jon Noack User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Klas Eriksson References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: amavisd-new at noacks.org cc: freebsd-cvsweb@freebsd.org Subject: Re: [BUG] download link doesn't work if path has spaces. X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: noackjr@alumni.rice.edu List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2005 20:41:59 -0000 On 3/14/2005 10:00 AM, Klas Eriksson wrote: > Ville Skyttä wrote: >>On Wed, 2004-10-13 at 23:12, Russell Francis wrote: >>>I am using CVSweb 3.0.1 and discovered that if any file contained in a >>>CVS module has a space character in it's path, the download link will >>>fail to download the file. >> >>Known issue, fixed in the current version of CVSweb, 3.0.2.scape($revision); > > Still a bug in 3.0.5, but on the "CVS log" page . > Click 'download', then space is encoded as "+", not "%20". Klas, I am unable to recreate this issue. Every download link I can find encodes spaces as "%20". In my testing I created files with spaces inside of directories with spaces and had no problems. Can you provide a link that shows the issue or a more detailed procedure for how to recreate it? Note that CVSweb uses URI::Escape to do the actual encoding. You might want to check that you have the most recent version (URI 1.35 includes URI::Escape 3.28; these are the versions I am using): http://search.cpan.org/dist/URI/ http://www.freshports.org/net/p5-URI/ Regards, Jon