From owner-freebsd-cvsweb@FreeBSD.ORG Mon May 2 17:11:17 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA19816A4CE for ; Mon, 2 May 2005 17:11:17 +0000 (GMT) Received: from smtp2.pp.htv.fi (smtp2.pp.htv.fi [213.243.153.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5874143D55 for ; Mon, 2 May 2005 17:11:17 +0000 (GMT) (envelope-from scop@FreeBSD.org) Received: from cs78130200.pp.htv.fi (cs78130200.pp.htv.fi [62.78.130.200]) by smtp2.pp.htv.fi (Postfix) with ESMTP id A3A99296BEF for ; Mon, 2 May 2005 20:11:15 +0300 (EEST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@freebsd.org In-Reply-To: References: Content-Type: text/plain Organization: FreeBSD Date: Mon, 02 May 2005 20:11:14 +0300 Message-Id: <1115053874.16399.2.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit Subject: Re: Patch to add html download link. X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2005 17:11:17 -0000 On Thu, 2005-04-28 at 15:17 -0700, Allen Reese wrote: > I store html files in a cvs repository that we access via cvsweb. I > find myself downloading the html file to open it in a web browser, or > changing the link that I clicked on so I can just display the html > file straight from cvsweb. Just clicking the "download" link should result it being sent as text/html assuming you have it configured so in cvsweb.conf (which is by default set up to do that). See for example the *.html files at http://cvs.fedora.us/cgi-bin/cvsweb.cgi/docs/ Which version of cvsweb are you running? > I got sick of it and wrote a patch to get around this today. ;) > > The patch adds a html link between text & markup that passes the > mimetype as text/html. That doesn't make much sense for files other than HTML. From owner-freebsd-cvsweb@FreeBSD.ORG Mon May 2 18:36:55 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2DE716A4CE for ; Mon, 2 May 2005 18:36:55 +0000 (GMT) Received: from smtp819.mail.sc5.yahoo.com (smtp819.mail.sc5.yahoo.com [66.163.170.5]) by mx1.FreeBSD.org (Postfix) with SMTP id 6667443D53 for ; Mon, 2 May 2005 18:36:55 +0000 (GMT) (envelope-from noackjr@alumni.rice.edu) Received: from unknown (HELO optimator.noacks.org) (noacks@swbell.net@70.240.205.64 with login) by smtp819.mail.sc5.yahoo.com with SMTP; 2 May 2005 18:36:54 -0000 Received: from localhost (localhost [127.0.0.1]) by optimator.noacks.org (Postfix) with ESMTP id C5004610A; Mon, 2 May 2005 13:36:53 -0500 (CDT) Received: from optimator.noacks.org ([127.0.0.1]) by localhost (optimator.noacks.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 06573-16-2; Mon, 2 May 2005 13:36:51 -0500 (CDT) Received: from [127.0.0.1] (optimator [192.168.1.11]) by optimator.noacks.org (Postfix) with ESMTP id 34C3660D2; Mon, 2 May 2005 13:36:51 -0500 (CDT) Message-ID: <4276733C.8090509@alumni.rice.edu> Date: Mon, 02 May 2005 13:36:44 -0500 From: Jonathan Noack User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Flitter, David" References: <2E39EFC6E5FD974DB7F9727D78B5E3360FAA59@sr1mm01.corp.UKrail.net> In-Reply-To: <2E39EFC6E5FD974DB7F9727D78B5E3360FAA59@sr1mm01.corp.UKrail.net> X-Enigmail-Version: 0.91.0.0 OpenPGP: id=991D8195; url=http://www.noacks.org/cert/noackjr.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9276B32F577BEBF5FBEBC524" X-Virus-Scanned: amavisd-new at noacks.org cc: freebsd-cvsweb@FreeBSD.org Subject: Re: CVS Document Access Error X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: noackjr@alumni.rice.edu List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2005 18:36:55 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9276B32F577BEBF5FBEBC524 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 4/21/2005 8:01 AM, Flitter, David wrote: > Hi, > When trying to read a document from idcvs I get the following error: > > docs/ID+Standards/Information Delivery Development Handbook v0.1.doc: no such file or directory Dave, Other people have reported the same problem but I have been unable to reproduce it. Which version of CVSweb are you running? What OS? Also, can you tell me the absolute path to the file in the repository? That should be of the form: /path/to/cvsroot/docs/ID Standards/Information Delivery Development Handbook v0.1.doc Would it be possible for you to send me a copy of the page with the bad link? Note that CVSweb uses URI::Escape to do the actual encoding. You might want to check that you have the most recent version (URI 1.35 includes URI::Escape 3.28; these are the versions I am using): http://search.cpan.org/dist/URI/ If running FreeBSD and using ports: http://www.freshports.org/net/p5-URI/ -- Jonathan Noack | noackjr@alumni.rice.edu | OpenPGP: 0x991D8195 --------------enig9276B32F577BEBF5FBEBC524 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (MingW32) iD8DBQFCdnNCUFz01pkdgZURAk6FAKCbXFwPchpBJINifuSMhmUkv4sVnACfZQMk /DwiZonK3RbPqekZhqQmRMc= =Qhei -----END PGP SIGNATURE----- --------------enig9276B32F577BEBF5FBEBC524-- From owner-freebsd-cvsweb@FreeBSD.ORG Tue May 3 18:18:37 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DB8B16A4D0 for ; Tue, 3 May 2005 18:18:37 +0000 (GMT) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7583943D5C for ; Tue, 3 May 2005 18:18:34 +0000 (GMT) (envelope-from ubercoderus@gmail.com) Received: by rproxy.gmail.com with SMTP id j1so1104777rnf for ; Tue, 03 May 2005 11:18:20 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=sajqr86/dpijFMs/scdIGonznbrMcQDpbqe03QTTyw0zKe+roERm/ZnkNZ68vKPCw6SelxXHlTQjUawxdrzHbqNTl5HsRuWFRze6uGgSjKqZ7i53AhXVzmovUnCrQ188oSGvFjsipXrzTnmtnzeNte0uV5pNIdFbwsr/orE0VBg= Received: by 10.38.65.8 with SMTP id n8mr7753850rna; Tue, 03 May 2005 11:18:20 -0700 (PDT) Received: by 10.38.88.53 with HTTP; Tue, 3 May 2005 11:18:20 -0700 (PDT) Message-ID: Date: Tue, 3 May 2005 11:18:20 -0700 From: Allen Reese To: freebsd-cvsweb@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Subject: Re: Re: Patch to add html download link. X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Allen Reese List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2005 18:18:37 -0000 Date: Mon, 02 May 2005 20:11:14 +0300 From: VilleSkytt? Subject: Re: Patch to add html download link. To: freebsd-cvsweb@freebsd.org Message-ID: <1115053874.16399.2.camel@bobcat.mine.nu> Content-Type: text/plain >On Thu, 2005-04-28 at 15:17 -0700, Allen Reese wrote: >> I store html files in a cvs repository that we access via cvsweb. I >> find myself downloading the html file to open it in a web browser, or >> changing the link that I clicked on so I can just display the html >> file straight from cvsweb. >Just clicking the "download" link should result it being sent as >text/html assuming you have it configured so in cvsweb.conf (which is by >default set up to do that). See for example the *.html files at >http://cvs.fedora.us/cgi-bin/cvsweb.cgi/docs/ >Which version of cvsweb are you running? I'm not sure. I'll pester our admins to fix the cvsweb.conf. I bet they just configured it wrong. >> I got sick of it and wrote a patch to get around this today. ;) >> >> The patch adds a html link between text & markup that passes the >> mimetype as text/html. >That doesn't make much sense for files other than HTML. Yes you're right there. :) From owner-freebsd-cvsweb@FreeBSD.ORG Wed May 4 08:36:28 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6268916A4CE for ; Wed, 4 May 2005 08:36:28 +0000 (GMT) Received: from bay0-pcs2.bay0.hotmail.com (bay0-pcs2.bay0.hotmail.com [65.54.241.240]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33BD643D78 for ; Wed, 4 May 2005 08:36:28 +0000 (GMT) (envelope-from sales@hotmail.com) Received: (from root@localhost) by bay0-pcs2.bay0.hotmail.com (8.12.10/8.12.10) id j448ZiIc010557 for freebsd-cvsweb@freebsd.org; Wed, 4 May 2005 01:35:44 -0700 (PDT) Date: Wed, 4 May 2005 01:35:44 -0700 (PDT) Message-Id: <200505040835.j448ZiIc010557@bay0-pcs2.bay0.hotmail.com> To: freebsd-cvsweb@freebsd.org From: MSN Hotmail MIME-Version: 1.0 X-Originating-IP: [65.54.241.240] Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-transfer-encoding: 8bit Subject: FwD: Re: X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2005 08:36:28 -0000 Thank you for contacting MSN Hotmail Sales. This is an auto-generated response designed to answer your question as quickly as possible. Please note that you will not receive a reply if you respond directly to this message. For information regarding advertising on MSN Hotmail, or other MSN properties, please visit http://mediacenter.msn.com/ From owner-freebsd-cvsweb@FreeBSD.ORG Thu May 5 17:53:10 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C19A16A4CE for ; Thu, 5 May 2005 17:53:10 +0000 (GMT) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.195]) by mx1.FreeBSD.org (Postfix) with ESMTP id C92E043D64 for ; Thu, 5 May 2005 17:53:09 +0000 (GMT) (envelope-from jpnairn@gmail.com) Received: by wproxy.gmail.com with SMTP id 69so196934wra for ; Thu, 05 May 2005 10:53:05 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=fVp2V2W1qvEJBivRa17jxcOq1chg3Z8xBgQoqRN5Gt4V/VeS0rehsu2K43/4EXgX0jt7nCx6zfzHA5aNzyAwRmdRK5B6qT9jsXj4SbPzTajiYqrzUsWQVE6hwOMYbwGAL0R5rbioMQ7odK4OyTS9DiUMgQHd2/fwnWE27fg7LqY= Received: by 10.54.70.2 with SMTP id s2mr324103wra; Thu, 05 May 2005 10:53:05 -0700 (PDT) Received: by 10.54.153.4 with HTTP; Thu, 5 May 2005 10:53:05 -0700 (PDT) Message-ID: <3bccd73d05050510534ec38692@mail.gmail.com> Date: Thu, 5 May 2005 10:53:05 -0700 From: Jerry Nairn To: freebsd-cvsweb@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Subject: cvsweb options forms X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jerry Nairn List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2005 17:53:10 -0000 Suggestion for the cvsweb TODO list: o Make sense out of all of the cvsweb options forms. The division of options into different sections is quizzical. In a directory listing window, you have: "General options" form containing options for: Sorting and displaying files: sort criteria, case sensitivity, hide/show Attic Sort criteria for log entries Diff format selection Show/Do not show line numbers in markup view If it has files in it*, there is a form to select: "Show only" tag (here it says this is for files) Module path or alias In a file log window, you have: Diff request form Log view options form to select: Preferred diff type, same as Diff format above View only branch, same as "Show only" above, BUT lists only branches. However, other tags can be inherited from "Show only" form. These tags of course, do not appear selected in this window. Sort criteria for log entries The options are useful, but the presentation is muddled. Currently they are sometimes in an unnamed section, sometimes in "General options," and sometimes in "Log view options." It would be better to just call them all "Options." The caption on the diff type and the tag selection should not change between windows. They are the same options, called by different names. I feel that the fact that you can view a file's log and not see all of the entries even when nothing is selected in the "View only..." list is a bug. (* I've modified my copy of cvs web to always show the "Show only" tag selection menu and the "Module path or alias" text box. I did that so that in addition to the "Go" button, I could have a link to a "Module diff" cgi I've written. It may not be ready for primetime, but I will send it to you if you want an example of one way to skin that cat. At some point I hope to integrate it better into cvsweb.) Jerry Nairn From owner-freebsd-cvsweb@FreeBSD.ORG Thu May 5 21:09:46 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0071316A4CE for ; Thu, 5 May 2005 21:09:46 +0000 (GMT) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id A39C043DC9 for ; Thu, 5 May 2005 21:09:45 +0000 (GMT) (envelope-from jpnairn@gmail.com) Received: by wproxy.gmail.com with SMTP id 69so264536wra for ; Thu, 05 May 2005 14:09:44 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=W1H3ysYvpuQZFbj/bydlCdOqNKwurepG9MupSN/5nz6Ee+thpdTVebP080x/gkRKXSRX/G7T1lRB6ZrPhWFBhqOBoZSGeDMG84+H//JMqq0SuSzhT44L9DKf+MfmjoPYBTd7bLBHhlGLVez4Uq3y9uiy5Dcmh60vGBlGoIqqhfc= Received: by 10.54.13.76 with SMTP id 76mr396308wrm; Thu, 05 May 2005 14:09:44 -0700 (PDT) Received: by 10.54.153.4 with HTTP; Thu, 5 May 2005 14:09:44 -0700 (PDT) Message-ID: <3bccd73d05050514095645d09e@mail.gmail.com> Date: Thu, 5 May 2005 14:09:44 -0700 From: Jerry Nairn To: freebsd-cvsweb@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Subject: Log view diff line X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jerry Nairn List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2005 21:09:46 -0000 Suggested changes to diff links in the log view: On the four lines which have: $diff =3D ''; $printed =3D 1; I have changed it to: $diff =3D ','; $printed =3D 1; I feel it is clearer with the separator in it. Other characters or combinations of characters might be better. I changed the string ' next main ' to ' to next main ' to be consistent with the other links, ' to previous ' and ' to branchpoint '. Thanks, Jerry Nairn From owner-freebsd-cvsweb@FreeBSD.ORG Fri May 6 10:31:53 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 07F7616A4CE for ; Fri, 6 May 2005 10:31:53 +0000 (GMT) Received: from smtp3.pp.htv.fi (smtp3.pp.htv.fi [213.243.153.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C99D43DAA for ; Fri, 6 May 2005 10:31:52 +0000 (GMT) (envelope-from scop@FreeBSD.org) Received: from cs78130200.pp.htv.fi (cs78130200.pp.htv.fi [62.78.130.200]) by smtp3.pp.htv.fi (Postfix) with ESMTP id DF2EA27ADB0 for ; Fri, 6 May 2005 13:31:50 +0300 (EEST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@freebsd.org In-Reply-To: <3bccd73d05050514095645d09e@mail.gmail.com> References: <3bccd73d05050514095645d09e@mail.gmail.com> Content-Type: multipart/mixed; boundary="=-z6/4HqkXAcFO9CTZ3SCg" Organization: FreeBSD Date: Fri, 06 May 2005 13:31:50 +0300 Message-Id: <1115375510.17931.38.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Subject: Re: Log view diff line X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2005 10:31:53 -0000 --=-z6/4HqkXAcFO9CTZ3SCg Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, 2005-05-05 at 14:09 -0700, Jerry Nairn wrote: > Suggested changes to diff links in the log view: > > On the four lines which have: > > $diff = ''; $printed = 1; > > I have changed it to: > > $diff = ','; $printed = 1; > > I feel it is clearer with the separator in it. Other characters or > combinations of characters might be better. Agreed. > I changed the string ' next main ' to ' to next main ' to be > consistent with the other links, ' to previous ' and ' to branchpoint > '. Good catch. Thoughts about the attached patch? It uses a semicolon for separating the diff link "categories", moves the "to" to be only at the beginning of the line, and adds parens around the displayed revision numbers. I'm not sure if the parens add any value though. --=-z6/4HqkXAcFO9CTZ3SCg Content-Disposition: attachment; filename=diffs.patch Content-Type: text/x-patch; name=diffs.patch; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Index: cvsweb.cgi =================================================================== RCS file: /home/projcvs/projects/cvsweb/cvsweb.cgi,v retrieving revision 1.292 diff -u -r1.292 cvsweb.cgi --- cvsweb.cgi 11 Apr 2005 17:47:38 -0000 1.292 +++ cvsweb.cgi 6 May 2005 10:26:20 -0000 @@ -2984,7 +2984,7 @@ my %diffrev = (); $diffrev{$_} = 1; $diffrev{""} = 1; - my $diff = 'Diff'; + my $diff = 'Diff to:'; my $printed = 0; # @@ -2994,8 +2994,8 @@ my $url = sprintf('%s.diff?r1=%s;r2=%s%s', $fileurl, $prev, $_, $barequery); if (my @dlinks = getDiffLinks($url, $mimetype, $isbin)) { - print $diff, ' to previous ', $prev, ': ', join(', ', @dlinks); - $diff = ''; $printed = 1; + print $diff, ' previous (', $prev, '): ', join(', ', @dlinks); + $diff = ';'; $printed = 1; } } @@ -3009,8 +3009,8 @@ my $url = sprintf('%s.diff?r1=%s;r2=%s%s', $fileurl, $brp, $_, $barequery); if (my @dlinks = getDiffLinks($url, $mimetype, $isbin)) { - print $diff, ' to branchpoint ', $brp, ': ', join(', ', @dlinks); - $diff = ''; $printed = 1; + print $diff, ' branchpoint (', $brp, '): ', join(', ', @dlinks); + $diff = ';'; $printed = 1; } } @@ -3035,7 +3035,7 @@ } # Only the highest version on a branch should have - # a diff for the "next main". + # a diff for the "next MAIN". last if (@tmp1 - 1 <= @tmp2 && join (".", @tmp1[0 .. $#tmp1 - 1]) eq @@ -3047,8 +3047,8 @@ my $url = sprintf('%s.diff?r1=%s;r2=%s%s', $fileurl, $nextmain, $_, $barequery); if (my @dlinks = getDiffLinks($url, $mimetype, $isbin)) { - print $diff, ' next main ', $nextmain, ': ', join(', ', @dlinks); - $diff = ''; $printed = 1; + print $diff, ' next MAIN (', $nextmain, '): ', join(', ', @dlinks); + $diff = ';'; $printed = 1; } } } @@ -3060,8 +3060,8 @@ my $url = sprintf('%s.diff?r1=%s;r2=%s%s', $fileurl, $input{r1}, $_, $barequery); if (my @dlinks = getDiffLinks($url, $mimetype, $isbin)) { - print $diff, ' to selected ', $input{r1}, ': ', join(', ', @dlinks); - $diff = ''; $printed = 1; + print $diff, ' selected (', $input{r1}, '): ', join(', ', @dlinks); + $diff = ';'; $printed = 1; } } --=-z6/4HqkXAcFO9CTZ3SCg-- From owner-freebsd-cvsweb@FreeBSD.ORG Fri May 6 16:39:06 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E49916A4D4 for ; Fri, 6 May 2005 16:39:06 +0000 (GMT) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 279E643D41 for ; Fri, 6 May 2005 16:39:06 +0000 (GMT) (envelope-from jpnairn@gmail.com) Received: by wproxy.gmail.com with SMTP id 71so809752wra for ; Fri, 06 May 2005 09:39:02 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=Q95nVw/TH/aFz4FBJ6Sx5ZH2PyrpZwfBwo742VBBPPnVePV6n0q670I4G/NjmgzC+CqQm8PgjUAVsRXi74DtzK9YIze83u7aXaeOXjllsiyv2AKWp1xWtrZYYCkW+JysdUnG9Vdx+ltoqpnv0aqxnE+Dj1WFRG9qbjRy9tVZkEM= Received: by 10.54.36.13 with SMTP id j13mr968919wrj; Fri, 06 May 2005 09:39:02 -0700 (PDT) Received: by 10.54.153.4 with HTTP; Fri, 6 May 2005 09:39:02 -0700 (PDT) Message-ID: <3bccd73d050506093958f6c0d2@mail.gmail.com> Date: Fri, 6 May 2005 09:39:02 -0700 From: Jerry Nairn To: freebsd-cvsweb@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Subject: Re: Log view diff line X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jerry Nairn List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2005 16:39:06 -0000 > Thoughts about the attached patch? It uses a semicolon for separating > the diff link "categories", moves the "to" to be only at the beginning > of the line, and adds parens around the displayed revision numbers. I'm > not sure if the parens add any value though. If it were my choice, I would not add the parens around the revision number, but it's not anything I feel strongly about. I like the other changes. Jerry Nairn From owner-freebsd-cvsweb@FreeBSD.ORG Sat May 7 18:12:31 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C442316A4DB for ; Sat, 7 May 2005 18:12:31 +0000 (GMT) Received: from smtp2.pp.htv.fi (smtp2.pp.htv.fi [213.243.153.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8070143D5F for ; Sat, 7 May 2005 18:12:31 +0000 (GMT) (envelope-from scop@FreeBSD.org) Received: from cs78131082.pp.htv.fi (cs78131082.pp.htv.fi [62.78.131.82]) by smtp2.pp.htv.fi (Postfix) with ESMTP id F082E296C36 for ; Sat, 7 May 2005 21:12:29 +0300 (EEST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@freebsd.org In-Reply-To: <3bccd73d050506093958f6c0d2@mail.gmail.com> References: <3bccd73d050506093958f6c0d2@mail.gmail.com> Content-Type: text/plain Organization: FreeBSD Date: Sat, 07 May 2005 21:12:29 +0300 Message-Id: <1115489549.4682.0.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit Subject: Re: Log view diff line X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2005 18:12:31 -0000 On Fri, 2005-05-06 at 09:39 -0700, Jerry Nairn wrote: > > Thoughts about the attached patch? It uses a semicolon for separating > > the diff link "categories", moves the "to" to be only at the beginning > > of the line, and adds parens around the displayed revision numbers. I'm > > not sure if the parens add any value though. > > If it were my choice, I would not add the parens around the revision > number, but it's not anything I feel strongly about. > I like the other changes. Ok, committed without the parens. Thanks again for the feedback.