From owner-freebsd-eclipse@FreeBSD.ORG  Sun Oct 30 12:50:31 2005
Return-Path: <owner-freebsd-eclipse@FreeBSD.ORG>
X-Original-To: freebsd-eclipse@freebsd.org
Delivered-To: freebsd-eclipse@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D9E7716A420
	for <freebsd-eclipse@freebsd.org>; Sun, 30 Oct 2005 12:50:31 +0000 (GMT)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
Received: from arabica.esil.univ-mrs.fr (arabica.esil.univ-mrs.fr
	[139.124.41.108])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 46E5F43D45
	for <freebsd-eclipse@freebsd.org>; Sun, 30 Oct 2005 12:50:30 +0000 (GMT)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
Received: from arabica.esil.univ-mrs.fr (localhost [127.0.0.1])
	by arabica.esil.univ-mrs.fr (8.13.4/8.13.4) with ESMTP id
	j9UCoIbH091100; Sun, 30 Oct 2005 13:50:18 +0100 (CET)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
Received: (from rv@localhost)
	by arabica.esil.univ-mrs.fr (8.13.4/8.13.4/Submit) id j9UCoG6x091099;
	Sun, 30 Oct 2005 13:50:16 +0100 (CET)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
X-Authentication-Warning: arabica.esil.univ-mrs.fr: rv set sender to
	herve.quiroz@esil.univ-mrs.fr using -f
Date: Sun, 30 Oct 2005 13:50:16 +0100
From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To: Panagiotis Astithas <past@ebs.gr>
Message-ID: <20051030125016.GA91020@arabica.esil.univ-mrs.fr>
References: <4364B574.5000904@ebs.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4364B574.5000904@ebs.gr>
User-Agent: Mutt/1.4.2.1i
Cc: Loren James Rittle <rittle@latour.waar.labs.mot.com>,
	freebsd-eclipse@freebsd.org
Subject: Re: [Fwd: Required patch after -r1.6 files/eclipse.in]
X-BeenThere: freebsd-eclipse@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps &amp;
	ports." <freebsd-eclipse.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse>, 
	<mailto:freebsd-eclipse-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-eclipse>
List-Post: <mailto:freebsd-eclipse@freebsd.org>
List-Help: <mailto:freebsd-eclipse-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse>,
	<mailto:freebsd-eclipse-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Oct 2005 12:50:32 -0000

Hi Panagiotis,

On Sun, Oct 30, 2005 at 01:58:44PM +0200, Panagiotis Astithas wrote:
> I'm not sure if you monitor freebsd-eclipse, so I wanted to let you know.

Indeed I do not monitor freebsd-eclipse so thanks for notifying me.

So Loren is right, %%JAVA_VERSION%% and %%JAVA_OS%% should be part of
the substitutions. Actually, given the suffix of eclipse.in, I thought
the substitutions were performed through SUB_FILES, which supports
JAVA_VERSION an JAVA_OS natively.

Anyway, I just commited the patch.

Herve

> Date: Fri, 28 Oct 2005 10:17:25 -0500 (CDT)
> From: Loren James Rittle <rittle@latour.waar.labs.mot.com>
> Subject: Required patch after -r1.6 files/eclipse.in
> To: freebsd-eclipse@freebsd.org, rittle@latour.waar.labs.mot.com
> Cc: 
> 
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/ports/java/eclipse/Makefile,v
> retrieving revision 1.41
> diff -c -r1.41 Makefile
> *** Makefile	9 Oct 2005 14:54:20 -0000	1.41
> --- Makefile	28 Oct 2005 15:17:24 -0000
> ***************
> *** 123,128 ****
> --- 123,130 ----
>   	  -e "s+%%PREFIX%%+${PREFIX}+g" \
>   	  -e "s+%%X11BASE%%+${X11BASE}+g" \
>   	  -e "s+%%BROWSER%%+${BROWSER}+g" \
> + 	  -e "s,%%JAVA_VERSION%%,${JAVA_VERSION},g" \
> + 	  -e "s+%%JAVA_OS%%+${JAVA_OS}+g" \
>   	${FILESDIR}/eclipse.in > ${WRKSRC}/eclipse.tmp
>   	${INSTALL_SCRIPT} ${WRKSRC}/eclipse.tmp ${PREFIX}/bin/eclipse
>   	@${SED} \