From owner-freebsd-multimedia@FreeBSD.ORG Sun Apr 10 04:56:27 2005 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 017D416A4CE; Sun, 10 Apr 2005 04:56:27 +0000 (GMT) Received: from cliffclavin.cs.rpi.edu (cliffclavin.cs.rpi.edu [128.213.1.9]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A7A243D53; Sun, 10 Apr 2005 04:56:26 +0000 (GMT) (envelope-from crossd@cs.rpi.edu) Received: from monica.cs.rpi.edu (root@monica.cs.rpi.edu [128.213.7.2]) j3A4uPCU005129 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 10 Apr 2005 00:56:25 -0400 (EDT) Received: from monica.cs.rpi.edu (crossd@localhost [127.0.0.1]) by monica.cs.rpi.edu (8.12.9p2/8.12.6) with ESMTP id j3A4uPir042622; Sun, 10 Apr 2005 00:56:25 -0400 (EDT) (envelope-from crossd@monica.cs.rpi.edu) Received: from localhost (crossd@localhost)j3A4uPuc042619; Sun, 10 Apr 2005 00:56:25 -0400 (EDT) (envelope-from crossd@monica.cs.rpi.edu) Date: Sun, 10 Apr 2005 00:56:25 -0400 (EDT) From: "David E. Cross" To: re@freebsd.org, freebsd-multimedia@freebsd.org Message-ID: <20050410004807.M33800@monica.cs.rpi.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.43 Subject: patch to src/sys/dev/sound/pcm/ac97.c X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Apr 2005 04:56:27 -0000 I would like to request the following be added to src/sys/dev/sound/pcm/ac97.c prior to 5.4-RELEASE (if at all possible) *** ac97.c.orig Sun Apr 10 00:49:08 2005 --- ac97.c Sun Apr 10 00:48:29 2005 *************** *** 129,134 **** --- 129,135 ---- { 0x41445360, 0x00, 0, "AD1885", 0 }, { 0x41445361, 0x00, 0, "AD1886", ad1886_patch }, { 0x41445362, 0x00, 0, "AD1887", 0 }, + { 0x41445368, 0x00, 0, "AD1888", ad198x_patch }, { 0x41445363, 0x00, 0, "AD1886A", 0 }, { 0x41445370, 0x00, 0, "AD1980", ad198x_patch }, { 0x41445372, 0x00, 0, "AD1981A", 0 }, I can summarize its affects to various classes of people: Affects to people without an AD1888 codec: None Affects to people WITH an AD1888 codec, the system will output to the port labeled "speaker" instead of microphone. System will work the same in multiple operating systems. If people are currently using their systems with this codec they will need to swap their output ports. I have _not_ checked audio input or line input (basically, I have checked nothing other than line-out). I believe this is an appropriate change, it makes us consistent with documentation, and other operating systems. Furthermore, this feature (playing) is the vast majority of sound activities, so if this makes is right for playback and wrong for recording... playback is more important, and we can fix recoding in the future without worries of screwing people again in the future (since we'll be "right" on the playback). -- David E. Cross