From owner-freebsd-python@FreeBSD.ORG Wed Nov 2 15:12:34 2005 Return-Path: X-Original-To: python@freebsd.org Delivered-To: freebsd-python@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D541716A420; Wed, 2 Nov 2005 15:12:34 +0000 (GMT) (envelope-from perky@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 78A3643D5F; Wed, 2 Nov 2005 15:12:31 +0000 (GMT) (envelope-from perky@FreeBSD.org) Received: from freefall.freebsd.org (perky@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jA2FCVHV015363; Wed, 2 Nov 2005 15:12:31 GMT (envelope-from perky@freefall.freebsd.org) Received: from localhost (localhost [[UNIX: localhost]]) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jA2FCVlx015361; Wed, 2 Nov 2005 15:12:31 GMT (envelope-from perky) Date: Thu, 3 Nov 2005 00:12:28 +0900 From: Hye-Shik Chang To: Filippo Natali Message-ID: <20051102151228.GA6483@FreeBSD.org> References: <1129366769.0@ulby.hq.netwing.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1129366769.0@ulby.hq.netwing.it> User-Agent: Mutt/1.4.2.1i X-Accept-Language: ko, en Cc: FreeBSD gnats submit , python@freebsd.org Subject: Re: ports/87476: [PATCH] Mk/bsd.python.mk: allow to choose Zope version in Products ports X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2005 15:12:35 -0000 On Sat, Oct 15, 2005 at 10:59:29AM +0200, Filippo Natali wrote: > >Number: 87476 > >Category: ports > >Synopsis: [PATCH] Mk/bsd.python.mk: allow to choose Zope version in Products ports > > Allow users to choose which Zope version when installing a Zope Product from ports. If a port Makefile contains USE_ZOPE it will depend from www/zope, but when WITH_ZOPE28 is defined it will depend from www/zope28. > The right python dependency (2.3 for Zope 2.7 and 2.4 for 2.8) will be also set. > Thanks for the patch! Here's my revise for the functionality. How's this? http://people.freebsd.org/~perky/pythonmk-zope28support.diff A new variable, ZOPE_VERSION is intented to be used as specified in /etc/make.conf. (or what about WANT_ZOPE_VER for more consistent naming in bsd.*.mk?) Hye-Shik From owner-freebsd-python@FreeBSD.ORG Wed Nov 2 16:59:50 2005 Return-Path: X-Original-To: python@freebsd.org Delivered-To: freebsd-python@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53BAE16A41F for ; Wed, 2 Nov 2005 16:59:50 +0000 (GMT) (envelope-from filippo.natali@gmail.com) Received: from nproxy.gmail.com (nproxy.gmail.com [64.233.182.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FD0B43D45 for ; Wed, 2 Nov 2005 16:59:49 +0000 (GMT) (envelope-from filippo.natali@gmail.com) Received: by nproxy.gmail.com with SMTP id p48so46509nfa for ; Wed, 02 Nov 2005 08:59:48 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:organization:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=NwcrJsh1S7DEo3nIdyynBIX9zNotZsAyUhz5bvZiQVUht/2PesPVISlFOmOt8ufs4Itz6zRClZmYZtf2ijuHHMwuaJKZ4feQGqe7tvp5Wxc1yZ9F0qplNRCxtfYgNmklFo47FU9QXSch9oLnBn0qKgS7exq9OX5df6Dx/+/W4N8= Received: by 10.48.4.12 with SMTP id 12mr834992nfd; Wed, 02 Nov 2005 08:53:30 -0800 (PST) Received: from ulby.hq.netwing.it ( [81.72.43.241]) by mx.gmail.com with ESMTP id d2sm376893nfe.2005.11.02.08.53.29; Wed, 02 Nov 2005 08:53:30 -0800 (PST) From: Filippo Natali Organization: Netwing To: Hye-Shik Chang Date: Wed, 2 Nov 2005 17:53:26 +0100 User-Agent: KMail/1.8.2 References: <1129366769.0@ulby.hq.netwing.it> <20051102151228.GA6483@FreeBSD.org> In-Reply-To: <20051102151228.GA6483@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200511021753.27516.filippo.natali@gmail.com> Cc: FreeBSD gnats submit , python@freebsd.org Subject: Re: ports/87476: [PATCH] Mk/bsd.python.mk: allow to choose Zope version in Products ports X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2005 16:59:50 -0000 Alle 16:12, mercoled=EC 2 novembre 2005, Hye-Shik Chang ha scritto: > Thanks for the patch! Here's my revise for the functionality. > How's this? > http://people.freebsd.org/~perky/pythonmk-zope28support.diff > > A new variable, ZOPE_VERSION is intented to be used as specified > in /etc/make.conf. (or what about WANT_ZOPE_VER for more consistent > naming in bsd.*.mk?) > > > Hye-Shik I like the use and behaviour of PYTHON_VERSION, I've discussed this with=20 vsevolod in Plone pr=20 (http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/86451), maybe he is als= o=20 working at the same patch for bsd.python.mk. btw Zope 3.1 is in ports, so it should be also included for selection. cheers =46ilippo From owner-freebsd-python@FreeBSD.ORG Thu Nov 3 15:06:47 2005 Return-Path: X-Original-To: python@freebsd.org Delivered-To: freebsd-python@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBCB016A420; Thu, 3 Nov 2005 15:06:47 +0000 (GMT) (envelope-from perky@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E9BF43D45; Thu, 3 Nov 2005 15:06:47 +0000 (GMT) (envelope-from perky@FreeBSD.org) Received: from freefall.freebsd.org (perky@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jA3F6lgP039933; Thu, 3 Nov 2005 15:06:47 GMT (envelope-from perky@freefall.freebsd.org) Received: from localhost (localhost [[UNIX: localhost]]) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jA3F6l48039932; Thu, 3 Nov 2005 15:06:47 GMT (envelope-from perky) Date: Fri, 4 Nov 2005 00:06:44 +0900 From: Hye-Shik Chang To: Filippo Natali Message-ID: <20051103150643.GA30821@FreeBSD.org> References: <1129366769.0@ulby.hq.netwing.it> <20051102151228.GA6483@FreeBSD.org> <200511021753.27516.filippo.natali@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/9DWx/yDrRhgMJTb" Content-Disposition: inline In-Reply-To: <200511021753.27516.filippo.natali@gmail.com> User-Agent: Mutt/1.4.2.1i X-Accept-Language: ko, en Cc: FreeBSD gnats submit , python@freebsd.org Subject: Re: ports/87476: [PATCH] Mk/bsd.python.mk: allow to choose Zope version in Products ports X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2005 15:06:47 -0000 --/9DWx/yDrRhgMJTb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 02, 2005 at 05:53:26PM +0100, Filippo Natali wrote: > Alle 16:12, mercoled? 2 novembre 2005, Hye-Shik Chang ha scritto: > > Thanks for the patch! Here's my revise for the functionality. > > How's this? > > http://people.freebsd.org/~perky/pythonmk-zope28support.diff > > > > A new variable, ZOPE_VERSION is intented to be used as specified > > in /etc/make.conf. (or what about WANT_ZOPE_VER for more consistent > > naming in bsd.*.mk?) > > > > > > Hye-Shik >=20 > I like the use and behaviour of PYTHON_VERSION, I've discussed this with= =20 > vsevolod in Plone pr=20 > (http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/86451), maybe he is a= lso=20 > working at the same patch for bsd.python.mk. >=20 > btw Zope 3.1 is in ports, so it should be also included for selection. >=20 Okay. I revised the patch for some flexibility for USE_ZOPE and ZOPE_VERSION simliar to PYTHON equivalents. http://people.freebsd.org/~perky/pythonmk-zope28support-2.diff Hye-Shik --/9DWx/yDrRhgMJTb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD4DBQFDaieADWUsWc/bS6QRAg3/AJYiDwlGOAHSHr5HpQbO0lmEalsQAJ4tfU49 rigant+vh4aiofx3ZBnLug== =VgdJ -----END PGP SIGNATURE----- --/9DWx/yDrRhgMJTb-- From owner-freebsd-python@FreeBSD.ORG Thu Nov 3 19:35:43 2005 Return-Path: X-Original-To: python@freebsd.org Delivered-To: freebsd-python@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2E9F16A41F for ; Thu, 3 Nov 2005 19:35:43 +0000 (GMT) (envelope-from filippo.natali@gmail.com) Received: from cadrega.netwing.it (iprov-srv2.housing.tomato.it [213.92.0.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 648F543D48 for ; Thu, 3 Nov 2005 19:35:41 +0000 (GMT) (envelope-from filippo.natali@gmail.com) Received: (qmail 12651 invoked from network); 3 Nov 2005 19:35:40 -0000 Received: from host241-43.pool8172.interbusiness.it (HELO ulby.hq.netwing.it) (netwing.it@81.72.43.241) by cadrega.netwing.it with RC4-MD5 encrypted SMTP; 3 Nov 2005 19:35:40 -0000 From: Filippo Natali Organization: Netwing To: Hye-Shik Chang Date: Thu, 3 Nov 2005 20:35:39 +0100 User-Agent: KMail/1.8.2 References: <1129366769.0@ulby.hq.netwing.it> <200511021753.27516.filippo.natali@gmail.com> <20051103150643.GA30821@FreeBSD.org> In-Reply-To: <20051103150643.GA30821@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200511032035.40302.filippo.natali@gmail.com> Cc: FreeBSD gnats submit , python@freebsd.org Subject: Re: ports/87476: [PATCH] Mk/bsd.python.mk: allow to choose Zope version in Products ports X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2005 19:35:43 -0000 Alle 16:06, gioved=EC 3 novembre 2005, Hye-Shik Chang ha scritto: > Okay. I revised the patch for some flexibility for USE_ZOPE and > ZOPE_VERSION simliar to PYTHON equivalents. > > http://people.freebsd.org/~perky/pythonmk-zope28support-2.diff > > > Hye-Shik There's a little typo in Zope 3.1 selection: [snip] =2D# Zope specific variables +# Zope-related variables .if defined(USE_ZOPE) +.if ${ZOPE_VERSION} =3D=3D "3.1" +SZOPEBASEDIR?=3D www/Zope28 +ZOPE_PORTSDIR=3D ${PORTSDIR}/www/zope28 +.elif ${ZOPE_VERSION} =3D=3D "2.8" [snip] Except this, it works fine. =46ilippo