From owner-freebsd-python@FreeBSD.ORG  Sun Nov  6 01:30:40 2005
Return-Path: <owner-freebsd-python@FreeBSD.ORG>
X-Original-To: python@freebsd.org
Delivered-To: freebsd-python@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E59B216A420;
	Sun,  6 Nov 2005 01:30:40 +0000 (GMT)
	(envelope-from perky@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 97D9043D45;
	Sun,  6 Nov 2005 01:30:40 +0000 (GMT)
	(envelope-from perky@FreeBSD.org)
Received: from freefall.freebsd.org (perky@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jA61UeIe060720;
	Sun, 6 Nov 2005 01:30:40 GMT
	(envelope-from perky@freefall.freebsd.org)
Received: from localhost (localhost [[UNIX: localhost]])
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jA61Uebo060719;
	Sun, 6 Nov 2005 01:30:40 GMT (envelope-from perky)
Date: Sun, 6 Nov 2005 10:30:36 +0900
From: Hye-Shik Chang <perky@freebsd.org>
To: Filippo Natali <filippo.natali@gmail.com>
Message-ID: <20051106013036.GA39761@FreeBSD.org>
References: <1129366769.0@ulby.hq.netwing.it>
	<200511021753.27516.filippo.natali@gmail.com>
	<20051103150643.GA30821@FreeBSD.org>
	<200511032035.40302.filippo.natali@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="lrZ03NoBR/3+SXJZ"
Content-Disposition: inline
In-Reply-To: <200511032035.40302.filippo.natali@gmail.com>
User-Agent: Mutt/1.4.2.1i
X-Accept-Language: ko, en
Cc: FreeBSD gnats submit <FreeBSD-gnats-submit@freebsd.org>, python@freebsd.org
Subject: Re: ports/87476: [PATCH] Mk/bsd.python.mk: allow to choose Zope
	version in Products ports
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>, 
	<mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>,
	<mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Nov 2005 01:30:41 -0000


--lrZ03NoBR/3+SXJZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 03, 2005 at 08:35:39PM +0100, Filippo Natali wrote:
> Alle 16:06, gioved? 3 novembre 2005, Hye-Shik Chang ha scritto:
> > Okay. I revised the patch for some flexibility for USE_ZOPE and
> > ZOPE_VERSION simliar to PYTHON equivalents.
> >
> > http://people.freebsd.org/~perky/pythonmk-zope28support-2.diff
> >
>=20
> There's a little typo in Zope 3.1 selection:
>=20
> [snip]
> -# Zope specific variables
> +# Zope-related variables
>  .if defined(USE_ZOPE)
> +.if ${ZOPE_VERSION} =3D=3D "3.1"
> +SZOPEBASEDIR?=3D			www/Zope28
> +ZOPE_PORTSDIR=3D			${PORTSDIR}/www/zope28
> +.elif ${ZOPE_VERSION} =3D=3D "2.8"
> [snip]
>=20
> Except this, it works fine.

Thanks for the review and comments!  I just committed it in CVS.
If you find any problem for that, please let me know.


Hye-Shik

--lrZ03NoBR/3+SXJZ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iD8DBQFDbVy8DWUsWc/bS6QRAoW4AKCSr5aIL6FVtxKkDXGiouGOavdfYQCgyoCd
78pqD2EjOFYIy9/zhzs34JM=
=rExP
-----END PGP SIGNATURE-----

--lrZ03NoBR/3+SXJZ--