From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 11:01:53 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D68216A41F for ; Mon, 6 Jun 2005 11:01:53 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B0E843D1F for ; Mon, 6 Jun 2005 11:01:53 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j56B1raM065655 for ; Mon, 6 Jun 2005 11:01:53 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j56B1qkU065649 for freebsd-rc@freebsd.org; Mon, 6 Jun 2005 11:01:52 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 6 Jun 2005 11:01:52 GMT Message-Id: <200506061101.j56B1qkU065649@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 11:01:53 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- a [2004/03/09] kern/63954 rc devfs loses permissions o [2005/02/10] conf/77340 rc awk used in /etc/rc.d/nsswitch when not a 2 problems total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2003/08/29] conf/56144 rc [PATCH] /etc/rc.d/ipmon, /etc/rc.d/ipfilt o [2004/06/30] conf/68525 rc Loader's verbose boot mode has rc.d/local o [2004/07/07] conf/68745 rc /etc/rc.d/devfs runs after ntpd so links o [2005/04/22] conf/80244 rc [PATCH] rc.conf + rc.d/jail should enable 4 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 16:40:53 2005 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7EDFD16A420; Mon, 6 Jun 2005 16:40:53 +0000 (GMT) (envelope-from arved@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 478C843D1F; Mon, 6 Jun 2005 16:40:53 +0000 (GMT) (envelope-from arved@FreeBSD.org) Received: from freefall.freebsd.org (arved@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j56GerUp014877; Mon, 6 Jun 2005 16:40:53 GMT (envelope-from arved@freefall.freebsd.org) Received: (from arved@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j56GerPh014873; Mon, 6 Jun 2005 16:40:53 GMT (envelope-from arved) Date: Mon, 6 Jun 2005 16:40:53 GMT From: Tilman Linneweh Message-Id: <200506061640.j56GerPh014873@freefall.freebsd.org> To: arved@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org Cc: Subject: Re: kern/81006: ipnat not working with tunnel interfaces on startup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 16:40:53 -0000 Synopsis: ipnat not working with tunnel interfaces on startup Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: arved Responsible-Changed-When: Mon Jun 6 16:40:23 GMT 2005 Responsible-Changed-Why: This seems to be a bug in the rc system, over to Mailinglist. http://www.freebsd.org/cgi/query-pr.cgi?pr=81006 From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 22:12:15 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BF1716A41C for ; Mon, 6 Jun 2005 22:12:15 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [66.150.201.101]) by mx1.FreeBSD.org (Postfix) with SMTP id 1CEA343D49 for ; Mon, 6 Jun 2005 22:12:15 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 49359 invoked by uid 399); 6 Jun 2005 22:12:13 -0000 Received: from unknown (HELO ?192.0.35.182?) (dougb@dougbarton.net@192.0.35.182) by mail1.fluidhosting.com with SMTP; 6 Jun 2005 22:12:13 -0000 Message-ID: <42A4CA37.1050201@FreeBSD.org> Date: Mon, 06 Jun 2005 15:12:07 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050326) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "J.R. Oldroyd" References: <20050603143803.GP886@linwhf.opal.com> In-Reply-To: <20050603143803.GP886@linwhf.opal.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 22:12:15 -0000 J.R. Oldroyd wrote: > I posted this to -current yesterday; it was suggested I resend to > this list. Thanks for bringing this up, and yes, we prefer discussion here on rc.d topics. > ----- Forwarded message from "J.R. Oldroyd" ----- > > From: "J.R. Oldroyd" > Date: Thu, 2 Jun 2005 17:10:23 -0400 > Subject: Use of rcorder for local rc.d/*.sh scripts > To: freebsd-current@freebsd.org > > Is there a reason that rcorder is not used in /etc/rc.d/localpkg > so that the scripts there can be ordered using their tags? > > If not, could we make the following change to /etc/rc.d/localpkg: > > --- localpkg.orig Fri Oct 8 13:52:43 2004 > +++ localpkg Thu Jun 2 16:53:56 2005 > @@ -36,7 +36,7 @@ > done > script_save_sep="$IFS" > IFS="${script_name_sep}" > - for script in ${slist}; do > + for script in `rcorder -s nostart ${slist} 2>/dev/null`; do This is an interesting approach. I'm in favor of incorporating rcorder for local scripts (whether ports, or homegrown stuff), but I think I prefer an approach that brings all the scripts into the fray, so that local scripts that need to execute before parts of the base can do so. Have you put any thought into such an approach? > If we do, there may be some scripts that ports install in the > local/etc/rc.d dirs that need rcorder tags adding, notably those > that currently use "000.foo.sh" names to ensure they're started > first. Yeah, if we're going to do something like this, it would be nice to do it before the 6.0 code slush, so if we can at least agree in principle that it should be done, and roughly on how, then we can send a message to the -ports list with a heads up on this topic. The ports code freeze comes after the base, so there will be time to fix ports that are broken by this change. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 23:08:54 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90ACE16A41C; Mon, 6 Jun 2005 23:08:54 +0000 (GMT) (envelope-from jr@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19DD443D4C; Mon, 6 Jun 2005 23:08:53 +0000 (GMT) (envelope-from jr@opal.com) Received: from linwhf.opal.com (112.79.171.66.subscriber.vzavenue.net [66.171.79.112]) by smtp.vzavenue.net (MOS 3.4.8-GR) with ESMTP id CIS08939; Mon, 6 Jun 2005 19:08:51 -0400 (EDT) Received: from ASSP-nospam (localhost [127.0.0.1]) by linwhf.opal.com (8.13.3/8.13.3) with ESMTP id j56N8pHW038137; Mon, 6 Jun 2005 19:08:51 -0400 (EDT) (envelope-from jr@opal.com) Received: from 127.0.0.1 ([127.0.0.1] helo=linwhf.opal.com) by ASSP-nospam ; 6 Jun 05 23:08:51 -0000 Received: (from jr@localhost) by linwhf.opal.com (8.13.3/8.13.3/Submit) id j56N8pOV038136; Mon, 6 Jun 2005 19:08:51 -0400 (EDT) (envelope-from jr) Date: Mon, 6 Jun 2005 19:08:51 -0400 From: "J.R. Oldroyd" To: Doug Barton Message-ID: <20050606230850.GE37208@linwhf.opal.com> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42A4CA37.1050201@FreeBSD.org> User-Agent: Mutt/1.4.2.1i X-Junkmail-Status: score=0/50, host=smtp.vzavenue.net Cc: freebsd-rc@FreeBSD.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 23:08:54 -0000 On Jun 06, 15:12, Doug Barton wrote: > >If not, could we make the following change to /etc/rc.d/localpkg: > > > >--- localpkg.orig Fri Oct 8 13:52:43 2004 > >+++ localpkg Thu Jun 2 16:53:56 2005 > >@@ -36,7 +36,7 @@ > > done > > script_save_sep="$IFS" > > IFS="${script_name_sep}" > >- for script in ${slist}; do > >+ for script in `rcorder -s nostart ${slist} 2>/dev/null`; do > > This is an interesting approach. I'm in favor of incorporating rcorder for > local scripts (whether ports, or homegrown stuff), but I think I prefer an > approach that brings all the scripts into the fray, so that local scripts > that need to execute before parts of the base can do so. Have you put any > thought into such an approach? > Yes, and I'd prefer that myself. We'd need to eliminate /etc/rc.d/localpkg and merge its functionality into /etc/rc. The change would actually be trivial: --- /etc/rc Thu Jun 2 09:07:12 2005 +++ rc.new Mon Jun 6 19:03:05 2005 @@ -72,7 +72,23 @@ skip="-s nostart" [ `/sbin/sysctl -n security.jail.jailed` -eq 1 ] && skip="$skip -s nojail" -files=`rcorder ${skip} /etc/rc.d/* 2>/dev/null` + +# For each dir in $local_startup, search for init scripts matching *.sh +# +case ${local_startup} in +[Nn][Oo] | '') + ;; +*) + local_rc_files="" + for dir in ${local_startup}; do + if [ -d "${dir}" ]; then + local_rc_files="${local_rc_files} ${dir}/*.sh" + fi + done + ;; +esac + +files=`rcorder ${skip} /etc/rc.d/* ${local_rc_files} 2>/dev/null` for _rc_elem in ${files}; do run_rc_script ${_rc_elem} ${_boot} Also, a similar change for /etc/rc.shutdown. -jr From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 23:39:46 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D1B8916A41C for ; Mon, 6 Jun 2005 23:39:46 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [66.150.201.101]) by mx1.FreeBSD.org (Postfix) with SMTP id 65E7643D48 for ; Mon, 6 Jun 2005 23:39:46 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 37418 invoked by uid 399); 6 Jun 2005 23:39:44 -0000 Received: from unknown (HELO ?192.0.35.182?) (dougb@dougbarton.net@192.0.35.182) by mail1.fluidhosting.com with SMTP; 6 Jun 2005 23:39:44 -0000 Message-ID: <42A4DEC0.3010404@FreeBSD.org> Date: Mon, 06 Jun 2005 16:39:44 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050326) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "J.R. Oldroyd" References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606230850.GE37208@linwhf.opal.com> In-Reply-To: <20050606230850.GE37208@linwhf.opal.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 23:39:46 -0000 J.R. Oldroyd wrote: > On Jun 06, 15:12, Doug Barton wrote: > >>>If not, could we make the following change to /etc/rc.d/localpkg: >>> >>>--- localpkg.orig Fri Oct 8 13:52:43 2004 >>>+++ localpkg Thu Jun 2 16:53:56 2005 >>>@@ -36,7 +36,7 @@ >>> done >>> script_save_sep="$IFS" >>> IFS="${script_name_sep}" >>>- for script in ${slist}; do >>>+ for script in `rcorder -s nostart ${slist} 2>/dev/null`; do >> >>This is an interesting approach. I'm in favor of incorporating rcorder for >>local scripts (whether ports, or homegrown stuff), but I think I prefer an >>approach that brings all the scripts into the fray, so that local scripts >>that need to execute before parts of the base can do so. Have you put any >>thought into such an approach? >> > > > Yes, and I'd prefer that myself. > > We'd need to eliminate /etc/rc.d/localpkg and merge its functionality > into /etc/rc. > > The change would actually be trivial: > > --- /etc/rc Thu Jun 2 09:07:12 2005 > +++ rc.new Mon Jun 6 19:03:05 2005 > @@ -72,7 +72,23 @@ > > skip="-s nostart" > [ `/sbin/sysctl -n security.jail.jailed` -eq 1 ] && skip="$skip -s nojail" > -files=`rcorder ${skip} /etc/rc.d/* 2>/dev/null` > + > +# For each dir in $local_startup, search for init scripts matching *.sh > +# > +case ${local_startup} in > +[Nn][Oo] | '') > + ;; > +*) > + local_rc_files="" > + for dir in ${local_startup}; do > + if [ -d "${dir}" ]; then > + local_rc_files="${local_rc_files} ${dir}/*.sh" I like this, except I'd prefer to test -x than to use the *.sh idiom. We've always told people that in order for files to be run in local/rc.d that they need to be executable, and I (personal preference, not trying to dictate policy) would like to get away from having to name these startup scripts *.sh, as we've done in /etc/rc.d. Thoughts? > + fi > + done > + ;; > +esac > + > +files=`rcorder ${skip} /etc/rc.d/* ${local_rc_files} 2>/dev/null` > > for _rc_elem in ${files}; do > run_rc_script ${_rc_elem} ${_boot} > > > Also, a similar change for /etc/rc.shutdown. This is very cool! I would like to hear from some of the other -rc folks, especially Mike. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 23:54:27 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A6C516A41C; Mon, 6 Jun 2005 23:54:27 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09F8343D53; Mon, 6 Jun 2005 23:54:26 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j56NsQar011157; Mon, 6 Jun 2005 16:54:26 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j56NsQWI011156; Mon, 6 Jun 2005 16:54:26 -0700 Date: Mon, 6 Jun 2005 16:54:26 -0700 From: Brooks Davis To: Doug Barton Message-ID: <20050606235426.GA10526@odin.ac.hmc.edu> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: <42A4CA37.1050201@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org, "J.R. Oldroyd" Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 23:54:27 -0000 --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 06, 2005 at 03:12:07PM -0700, Doug Barton wrote: > J.R. Oldroyd wrote: > >I posted this to -current yesterday; it was suggested I resend to > >this list. >=20 > Thanks for bringing this up, and yes, we prefer discussion here on rc.d= =20 > topics. >=20 > >----- Forwarded message from "J.R. Oldroyd" ----- > > > >From: "J.R. Oldroyd" > >Date: Thu, 2 Jun 2005 17:10:23 -0400 > >Subject: Use of rcorder for local rc.d/*.sh scripts > >To: freebsd-current@freebsd.org > > > >Is there a reason that rcorder is not used in /etc/rc.d/localpkg > >so that the scripts there can be ordered using their tags? > > > >If not, could we make the following change to /etc/rc.d/localpkg: > > > >--- localpkg.orig Fri Oct 8 13:52:43 2004 > >+++ localpkg Thu Jun 2 16:53:56 2005 > >@@ -36,7 +36,7 @@ > > done > > script_save_sep=3D"$IFS" > > IFS=3D"${script_name_sep}" > >- for script in ${slist}; do > >+ for script in `rcorder -s nostart ${slist} 2>/dev/null`; do >=20 > This is an interesting approach. I'm in favor of incorporating rcorder fo= r=20 > local scripts (whether ports, or homegrown stuff), but I think I prefer a= n=20 > approach that brings all the scripts into the fray, so that local scripts= =20 > that need to execute before parts of the base can do so. Have you put any= =20 > thought into such an approach? This isn't feasable in the general case with current infrastructure. The problem is that you need to make it up to mountcritremote before you have any assurance that /usr/local/etc exists. Ports contains a work around that allows port to install script in /etc/rc.d if they truly need to appear before localpkg. Such ports generally still need to have scripts that run after mountcritlocal and won't work on systems where /usr/local is remote unless it is on /. =46rom the perspective of someone who works on the diskless scripts, I think that sorting scripts in localpkg and using this hack is a decent comprimise. Another note, this decision will need to be discussed with ports@ since there are a lot of scripts in ${LOCALBASE}/rc.d. There's also at least one binary (postfix). I'd like to see this change happen, but there are a lot of issues to work out. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCpOIxXY6L6fI4GtQRAsnWAJ9oPMlKK7h4IDNTDWXiBflwAOv5rQCeKZ98 p7Cg4fyA5YGpbn3A5BGrDM0= =OIuY -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/-- From owner-freebsd-rc@FreeBSD.ORG Tue Jun 7 00:14:59 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2EEE16A41C; Tue, 7 Jun 2005 00:14:59 +0000 (GMT) (envelope-from jr@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E96443D48; Tue, 7 Jun 2005 00:14:58 +0000 (GMT) (envelope-from jr@opal.com) Received: from linwhf.opal.com (112.79.171.66.subscriber.vzavenue.net [66.171.79.112]) by smtp.vzavenue.net (MOS 3.4.8-GR) with ESMTP id CIS14010; Mon, 6 Jun 2005 20:14:48 -0400 (EDT) Received: from ASSP-nospam (localhost [127.0.0.1]) by linwhf.opal.com (8.13.3/8.13.3) with ESMTP id j570EmDZ038741; Mon, 6 Jun 2005 20:14:48 -0400 (EDT) (envelope-from jr@opal.com) Received: from 127.0.0.1 ([127.0.0.1] helo=linwhf.opal.com) by ASSP-nospam ; 7 Jun 05 00:14:48 -0000 Received: (from jr@localhost) by linwhf.opal.com (8.13.3/8.13.3/Submit) id j570ElnI038740; Mon, 6 Jun 2005 20:14:47 -0400 (EDT) (envelope-from jr) Date: Mon, 6 Jun 2005 20:14:47 -0400 From: "J.R. Oldroyd" To: Brooks Davis Message-ID: <20050607001447.GG37208@linwhf.opal.com> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <20050606235426.GA10526@odin.ac.hmc.edu> User-Agent: Mutt/1.4.2.1i X-Junkmail-Status: score=0/50, host=smtp.vzavenue.net Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 00:14:59 -0000 --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jun 06, 16:54, Brooks Davis wrote: >=20 > This isn't feasable in the general case with current infrastructure. > The problem is that you need to make it up to mountcritremote before you > have any assurance that /usr/local/etc exists. >=20 > Ports contains a work around that allows port to install script in > /etc/rc.d if they truly need to appear before localpkg. Such ports > generally still need to have scripts that run after mountcritlocal and > won't work on systems where /usr/local is remote unless it is on /. >=20 > From the perspective of someone who works on the diskless scripts, I > think that sorting scripts in localpkg and using this hack is a decent > comprimise. >=20 > Another note, this decision will need to be discussed with ports@ since > there are a lot of scripts in ${LOCALBASE}/rc.d. There's also at least > one binary (postfix). I'd like to see this change happen, but there are > a lot of issues to work out. >=20 The solution for that would be to: - rcorder the /etc/rc.d scripts - execute the scripts up to mountcritlocal and a dummy script that has a "PROVIDE: MOUNTCRITLOCAL" or similar - rerun rcorder on the complete script list (including the locals) - execute the list again, this time skipping over any in /etc/rc.d before the MOUNTCRITLOCAL is reached (since they were done before) I don't know if that's getting too complicated. I have to say I prefer to keep things simple. I also looked at /etc/rc.subr:run_rc_script and discovered that it handles "foo" and "foo.sh" differently. "foo", if executable, is run in a subshell, whereas "foo.sh" is sourced into the current shell. I suspect we don't want all the local rc foo.sh scripts sourcing into the /etc/rc shell. I.e., to make a change like this, all local rc scripts would need to be renamed as well as having rcorder tags added if not already there. I currently use the hack to localpkg which I originally suggested. I needed it because several existing ports fail to start without it and that change does fix the problem. -jr --ibTvN161/egqYuK8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iQDVAwUBQqTm90kkqUax7f6FAQK8oQX7BBy9iw9lbbb9wcHCasjBnPye1PlG+kqG K5T9FLpjvSDwXdKaTunk+ERNAcm0Y92K9ATGIVSZhXCBzBqFNErSGbbQOgsHNgLG 7/AAHl8H5XcNefqTKopH4r7vXhhACDMIdhMGbyMlrR1OAeSltfZi3x7XbkylXg8d rkFLQ6SGSYPP1kAdSiEL8h+KwN/CfDVn/Y/l4iaassOJSxxysJSB+b/rNzFk1Oav yhTHg2gnANhb+LC0FekE9X6C8RQe5GJ+ =KeLv -----END PGP SIGNATURE----- --ibTvN161/egqYuK8-- From owner-freebsd-rc@FreeBSD.ORG Tue Jun 7 00:31:43 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E90F16A41C; Tue, 7 Jun 2005 00:31:43 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE0CF43D4C; Tue, 7 Jun 2005 00:31:42 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j570Vgx7015101; Mon, 6 Jun 2005 17:31:42 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j570Vg5V015100; Mon, 6 Jun 2005 17:31:42 -0700 Date: Mon, 6 Jun 2005 17:31:42 -0700 From: Brooks Davis To: "J.R. Oldroyd" Message-ID: <20050607003142.GD10526@odin.ac.hmc.edu> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AkbCVLjbJ9qUtAXD" Content-Disposition: inline In-Reply-To: <20050607001447.GG37208@linwhf.opal.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 00:31:43 -0000 --AkbCVLjbJ9qUtAXD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 06, 2005 at 08:14:47PM -0400, J.R. Oldroyd wrote: > On Jun 06, 16:54, Brooks Davis wrote: > >=20 > > This isn't feasable in the general case with current infrastructure. > > The problem is that you need to make it up to mountcritremote before you > > have any assurance that /usr/local/etc exists. > >=20 > > Ports contains a work around that allows port to install script in > > /etc/rc.d if they truly need to appear before localpkg. Such ports > > generally still need to have scripts that run after mountcritlocal and > > won't work on systems where /usr/local is remote unless it is on /. > >=20 > > From the perspective of someone who works on the diskless scripts, I > > think that sorting scripts in localpkg and using this hack is a decent > > comprimise. > >=20 > > Another note, this decision will need to be discussed with ports@ since > > there are a lot of scripts in ${LOCALBASE}/rc.d. There's also at least > > one binary (postfix). I'd like to see this change happen, but there are > > a lot of issues to work out. > >=20 >=20 > The solution for that would be to: > - rcorder the /etc/rc.d scripts > - execute the scripts up to mountcritlocal and a dummy script > that has a "PROVIDE: MOUNTCRITLOCAL" or similar > - rerun rcorder on the complete script list (including the > locals) > - execute the list again, this time skipping over any in > /etc/rc.d before the MOUNTCRITLOCAL is reached (since they > were done before) >=20 > I don't know if that's getting too complicated. I have to say I > prefer to keep things simple. You actually have to run to mountcritremote not mountcritlocal since you may not actually have /usr until after mountcritremote. I don't think this is worth it. > I also looked at /etc/rc.subr:run_rc_script and discovered that it > handles "foo" and "foo.sh" differently. "foo", if executable, is run > in a subshell, whereas "foo.sh" is sourced into the current shell. > I suspect we don't want all the local rc foo.sh scripts sourcing into > the /etc/rc shell. I.e., to make a change like this, all local rc > scripts would need to be renamed as well as having rcorder tags > added if not already there. I would recommend against this change. We have to keep compatibility with 5.x and probably 4.11 for now which means we can change the comments to preserve necessary ordering within the directory, but removing the .sh will cause problems. > I currently use the hack to localpkg which I originally suggested. > I needed it because several existing ports fail to start without it > and that change does fix the problem. I think your original suggestion is the direction we should take. Things that truly need to run before or after localpkg can be handled by an existing ports mechanism. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --AkbCVLjbJ9qUtAXD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCpOrrXY6L6fI4GtQRAmsiAKC6xUaR14iPHC0a6PSnxo+i1IR6kQCfYp2B AY24LfHQhToZDlNQvx46AvY= =wITR -----END PGP SIGNATURE----- --AkbCVLjbJ9qUtAXD-- From owner-freebsd-rc@FreeBSD.ORG Tue Jun 7 03:37:36 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42A2816A41C; Tue, 7 Jun 2005 03:37:36 +0000 (GMT) (envelope-from jr@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 717FE43D49; Tue, 7 Jun 2005 03:37:35 +0000 (GMT) (envelope-from jr@opal.com) Received: from linwhf.opal.com (112.79.171.66.subscriber.vzavenue.net [66.171.79.112]) by smtp.vzavenue.net (MOS 3.4.8-GR) with ESMTP id CIT00790; Mon, 6 Jun 2005 23:35:50 -0400 (EDT) Received: from ASSP-nospam (localhost [127.0.0.1]) by linwhf.opal.com (8.13.3/8.13.3) with ESMTP id j573ZnQK041399; Mon, 6 Jun 2005 23:35:49 -0400 (EDT) (envelope-from jr@opal.com) Received: from 127.0.0.1 ([127.0.0.1] helo=linwhf.opal.com) by ASSP-nospam ; 7 Jun 05 03:35:49 -0000 Received: (from jr@localhost) by linwhf.opal.com (8.13.3/8.13.3/Submit) id j573ZavE041398; Mon, 6 Jun 2005 23:35:36 -0400 (EDT) (envelope-from jr) Date: Mon, 6 Jun 2005 23:35:36 -0400 From: "J.R. Oldroyd" To: Brooks Davis Message-ID: <20050607033536.GH37208@linwhf.opal.com> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Y7xTucakfITjPcLV" Content-Disposition: inline In-Reply-To: <20050607003142.GD10526@odin.ac.hmc.edu> User-Agent: Mutt/1.4.2.1i X-Junkmail-Status: score=0/50, host=smtp.vzavenue.net Cc: freebsd-rc@freebsd.org, "J.R. Oldroyd" Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 03:37:36 -0000 --Y7xTucakfITjPcLV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jun 06, 17:31, Brooks Davis wrote: >=20 > I think your original suggestion is the direction we should take. > Things that truly need to run before or after localpkg can be handled by > an existing ports mechanism. >=20 OK, well, below is probably a more complete patch. I've added the shutdown part, and copied the "-k shutdown" option and the "-s nojail" option from /etc/rc and /etc/rc.shutdown. The code to handle file names with embedded spaces using the IFS change is not actually needed if the shell patterns to match the filenames are expanded in the for loop which executes the scripts. So this patch removes all that code. Note that the matching of "*.sh" is what the script does now. I've not changed that. If we want to remove the requirement that scripts in the local_startup dirs be named *.sh, this code can be simplified even further. -jr --- /etc/rc.d/localpkg.orig Fri Oct 8 13:52:43 2004 +++ /etc/rc.d/localpkg Mon Jun 6 23:25:47 2005 @@ -14,6 +14,9 @@ start_cmd=3D"pkg_start" stop_cmd=3D"pkg_stop" =20 +rcorder_opts=3D"" +[ `/sbin/sysctl -n security.jail.jailed` -eq 1 ] && rcorder_opts=3D"-s noj= ail" + pkg_start() { # For each dir in $local_startup, search for init scripts matching *.sh @@ -24,19 +27,12 @@ *) echo -n 'Local package initialization:' slist=3D"" - if [ -z "${script_name_sep}" ]; then - script_name_sep=3D" " - fi for dir in ${local_startup}; do if [ -d "${dir}" ]; then - for script in ${dir}/*.sh; do - slist=3D"${slist}${script_name_sep}${script}" - done + slist=3D"${slist} ${dir}/*.sh" fi done - script_save_sep=3D"$IFS" - IFS=3D"${script_name_sep}" - for script in ${slist}; do + for script in `rcorder -s nostart ${rcorder_opts} ${slist} 2>/dev/null`;= do if [ -x "${script}" ]; then (set -T trap 'exit 1' 2 @@ -45,7 +41,6 @@ echo -n " (skipping ${script##*/}, not executable)" fi done - IFS=3D"${script_save_sep}" echo '.' ;; esac @@ -61,26 +56,18 @@ ;; *) slist=3D"" - if [ -z "${script_name_sep}" ]; then - script_name_sep=3D" " - fi for dir in ${local_startup}; do if [ -d "${dir}" ]; then - for script in ${dir}/*.sh; do - slist=3D"${slist}${script_name_sep}${script}" - done + slist=3D"${slist} ${dir}/*.sh" fi done - script_save_sep=3D"$IFS" - IFS=3D"${script_name_sep}" - for script in `reverse_list ${slist}`; do + for script in `reverse_list \`rcorder -k shutdown ${rcorder_opts} ${slis= t} 2>/dev/null\``; do if [ -x "${script}" ]; then (set -T trap 'exit 1' 2 ${script} stop) fi done - IFS=3D"${script_save_sep}" echo '.' ;; esac --Y7xTucakfITjPcLV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iQDVAwUBQqUWCEkkqUax7f6FAQKXKQX9HuoVmwQZ3zHR2d3ghjwsKafyyvQZy/Y1 PDTAD5AnO5ccPcsmiCYXRGfLs04zg4hnx/Wb35fdFSmSLSxI+Dl9NHV4tKIzYsn/ Sw6ihXVWMAGU5kDgY6Tq32onTcaHpv+fcgss1H6Vqy0k7PUOA/HtzuZgZmq1u+Es ryu3+sPkKt6wK8RdBZ4XY2stEIxvYzkO6RMOvGyOE//5CSX24MEc1MEHHgqMPNkb t4v4PV52p08tAzbxtJqc1z2IgTSsAqz0 =DuN3 -----END PGP SIGNATURE----- --Y7xTucakfITjPcLV-- From owner-freebsd-rc@FreeBSD.ORG Tue Jun 7 06:26:14 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3FA716A41C; Tue, 7 Jun 2005 06:26:13 +0000 (GMT) (envelope-from roth@droopy.unibe.ch) Received: from mailhub03.unibe.ch (mailhub03-eth0.unibe.ch [130.92.9.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E33843D48; Tue, 7 Jun 2005 06:26:13 +0000 (GMT) (envelope-from roth@droopy.unibe.ch) Received: from localhost (scanhub02.unibe.ch [130.92.254.66]) by mailhub03.unibe.ch (Postfix) with ESMTP id 71B9111ABF; Tue, 7 Jun 2005 08:26:13 +0200 (CEST) Received: from mailhub03.unibe.ch ([130.92.9.70]) by localhost (scanhub02.unibe.ch [130.92.254.66]) (amavisd-new, port 10024) with LMTP id 04886-06-4; Tue, 7 Jun 2005 08:26:08 +0200 (CEST) Received: from asterix.unibe.ch (asterix.unibe.ch [130.92.64.4]) by mailhub03.unibe.ch (Postfix) with ESMTP id 9528E11A7F; Tue, 7 Jun 2005 08:26:12 +0200 (CEST) Received: from droopy.unibe.ch (droopy [130.92.64.20]) by asterix.unibe.ch (8.12.10+Sun/8.12.10) with ESMTP id j576QA8n005622; Tue, 7 Jun 2005 08:26:10 +0200 (MEST) Received: (from roth@localhost) by droopy.unibe.ch (8.12.10+Sun/8.12.9/Submit) id j576QApe017235; Tue, 7 Jun 2005 08:26:10 +0200 (MEST) Date: Tue, 7 Jun 2005 08:26:10 +0200 From: Tobias Roth To: Doug Barton Message-ID: <20050607062610.GA17215@droopy.unibe.ch> References: <20050605022207.GA18499@dragon.NUXI.org> <42A4C8CB.8090809@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42A4C8CB.8090809@FreeBSD.org> User-Agent: Mutt/1.4i X-message-flag: Warning! Using Outlook is insecure and promotes virus distribution. Please use a different email client. X-Virus-checked: by University of Berne Cc: freebsd-current@freebsd.org, freebsd-rc@freebsd.org Subject: Re: I'd like to rm these RCng files X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 06:26:14 -0000 On Mon, Jun 06, 2005 at 03:06:03PM -0700, Doug Barton wrote: > > In the future though, it would be nice to ask about rc.d related stuff on > the freebsd-rc@freebsd.org mailing list. To increase the chances of having topics like that sent to freebsd-rc, you may want to consider to tell people about it on the FreeBSD website. For instance here: http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/eresources.html cheers, t. From owner-freebsd-rc@FreeBSD.ORG Tue Jun 7 16:10:56 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3338416A41C; Tue, 7 Jun 2005 16:10:56 +0000 (GMT) (envelope-from jr@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4703243D48; Tue, 7 Jun 2005 16:10:51 +0000 (GMT) (envelope-from jr@opal.com) Received: from linwhf.opal.com (112.79.171.66.subscriber.vzavenue.net [66.171.79.112]) by smtp.vzavenue.net (MOS 3.4.8-GR) with ESMTP id CIW18678; Tue, 7 Jun 2005 12:08:56 -0400 (EDT) Received: from ASSP-nospam (localhost [127.0.0.1]) by linwhf.opal.com (8.13.3/8.13.3) with ESMTP id j57G8tBb046195; Tue, 7 Jun 2005 12:08:55 -0400 (EDT) (envelope-from jr@opal.com) Received: from 127.0.0.1 ([127.0.0.1] helo=linwhf.opal.com) by ASSP-nospam ; 7 Jun 05 16:08:55 -0000 Received: (from jr@localhost) by linwhf.opal.com (8.13.3/8.13.3/Submit) id j57G8tGM046194; Tue, 7 Jun 2005 12:08:55 -0400 (EDT) (envelope-from jr) Date: Tue, 7 Jun 2005 12:08:55 -0400 From: "J.R. Oldroyd" To: Brooks Davis Message-ID: <20050607160855.GO37208@linwhf.opal.com> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="w7PDEPdKQumQfZlR" Content-Disposition: inline In-Reply-To: <20050607033536.GH37208@linwhf.opal.com> User-Agent: Mutt/1.4.2.1i X-Junkmail-Status: score=0/50, host=smtp.vzavenue.net Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 16:10:56 -0000 --w7PDEPdKQumQfZlR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Having slept on this, I am in two minds as to which approach is better: hacking localpkg or fixing /etc/rc to handle everything in all startup dirs. I do think that the use of a single rc script to run all rc files is probably the proper approach, even though moving to this from where we are now will require more changes. So, I offer the following solution as an alternative to the hack to localpkg. Below I: - add /etc/rc.d/MOUNTDONE a dummy script to flag the point in the list when we've completed the fs mounts - patches to /etc/rc to run the files list in two passes, once for the files in /etc/rc.d up to the MOUNTDONE point, and then a second time with the files in the local startup dirs included, this time skipping files in /etc/rc.d prior to the MOUNTDONE point In this version, I have removed the code that required local startup scripts to be named *.sh since rc.subr's run_rc_script function handles *.sh specially. So, if this approach were adopted, several changes will be needed to all local rc scripts: - any with a .sh suffix will need to be renamed from "foo.sh" to "foo" - any files like "*.sh.sample" will have to be moved elsewhere, or made non-executable - rcorder tags will need to be added to any that care about the order of their execution, and names like "000.*" can be eliminated Obviously, similar changes will be needed for /etc/rc.shutdown. -jr --- /etc/rc.d/MOUNTDONE.orig Wed Dec 31 19:00:00 1969 +++ /etc/rc.d/MOUNTDONE Tue Jun 7 11:23:01 2005 @@ -0,0 +1,12 @@ +#!/bin/sh +# +# $FreeBSD$ +# + +# PROVIDE: MOUNTDONE +# REQUIRE: mountcritlocal mountcritremote +# BEFORE: SERVERS DAEMON LOGIN + +# This is a dummy dependency to flag when fs mounts are done +# after which local rc scripts can be merged into the rc startup +# list. --- /etc/rc.orig Thu Jun 2 09:07:12 2005 +++ /etc/rc Tue Jun 7 11:53:49 2005 @@ -72,9 +72,51 @@ =20 skip=3D"-s nostart" [ `/sbin/sysctl -n security.jail.jailed` -eq 1 ] && skip=3D"$skip -s nojai= l" + files=3D`rcorder ${skip} /etc/rc.d/* 2>/dev/null` =20 +# run all startup scripts to the point where fs mounts are done +for _rc_elem in ${files}; do + case "${_rc_elem}" in + /etc/rc.d/MOUNTDONE) + break + ;; + esac + run_rc_script ${_rc_elem} ${_boot} +done + +# now look for additional startup scripts in local startup dirs +local_rc_files=3D"" +case ${local_startup} in +[Nn][Oo] | '') + ;; +*) + for dir in ${local_startup}; do + if [ -d "${dir}" ]; then + local_rc_files=3D"${local_rc_files} ${dir}/*" + fi + done + ;; +esac + +files=3D`rcorder ${skip} /etc/rc.d/* ${local_rc_files} 2>/dev/null` + +# redo the list, skipping any already done, which are files in +# /etc/rc.d prior to MOUNTDONE +_rc_skip=3D1 for _rc_elem in ${files}; do + case "${_rc_elem}" in + /etc/rc.d/MOUNTDONE) + _rc_skip=3D"" + ;; + esac + if [ -n "${_rc_skip}" ]; then + case "${_rc_elem}" in + /etc/rc.d/*) + continue + ;; + esac + fi run_rc_script ${_rc_elem} ${_boot} done =20 --w7PDEPdKQumQfZlR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iQDVAwUBQqXGl0kkqUax7f6FAQL35gX/RhVTUa7jNlVhJnbdm7E3X4dekJJxw+gX MI39sMZ8IiisSMSHgX4YchxRwZPWFYcSW4zwaFszAMCd7U+TEQZiZFGrHBLvb1PI IgmHjL/9V3SeCh5RM6Cmpc4II2CW2L+o/zEi6Ui8RxhPqNN/CjCOo3f1LjyA7+a1 /YXKFYiAp80XbrMFHOMzmpA2BkpTtT35LZJNg/knsyMa00xDGj1ewKzg1SJpK7yl XRTRw/IqlDJbcBZ6U1wUOrR10pVXDzDN =f80C -----END PGP SIGNATURE----- --w7PDEPdKQumQfZlR-- From owner-freebsd-rc@FreeBSD.ORG Tue Jun 7 17:37:42 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 316FA16A41C; Tue, 7 Jun 2005 17:37:42 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF25C43D49; Tue, 7 Jun 2005 17:37:41 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j57Hbf0w030678; Tue, 7 Jun 2005 10:37:41 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j57HbfWj030677; Tue, 7 Jun 2005 10:37:41 -0700 Date: Tue, 7 Jun 2005 10:37:41 -0700 From: Brooks Davis To: "J.R. Oldroyd" Message-ID: <20050607173741.GI11758@odin.ac.hmc.edu> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7SrMUQONj8Rl9QNG" Content-Disposition: inline In-Reply-To: <20050607160855.GO37208@linwhf.opal.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 17:37:42 -0000 --7SrMUQONj8Rl9QNG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 07, 2005 at 12:08:55PM -0400, J.R. Oldroyd wrote: > Having slept on this, I am in two minds as to which approach is > better: hacking localpkg or fixing /etc/rc to handle everything > in all startup dirs. >=20 > I do think that the use of a single rc script to run all rc files > is probably the proper approach, even though moving to this from > where we are now will require more changes. >=20 > So, I offer the following solution as an alternative to the hack > to localpkg. Below I: > - add /etc/rc.d/MOUNTDONE > a dummy script to flag the point in the list > when we've completed the fs mounts > - patches to /etc/rc > to run the files list in two passes, once > for the files in /etc/rc.d up to the MOUNTDONE > point, and then a second time with the files > in the local startup dirs included, this time > skipping files in /etc/rc.d prior to the > MOUNTDONE point This part looks like it's probably a feasible solution, though I'm not fully convinced of its value relative to the complexity it adds. > In this version, I have removed the code that required local startup > scripts to be named *.sh since rc.subr's run_rc_script function > handles *.sh specially. So, if this approach were adopted, several > changes will be needed to all local rc scripts: > - any with a .sh suffix will need to be renamed from > "foo.sh" to "foo" > - any files like "*.sh.sample" will have to be moved > elsewhere, or made non-executable > - rcorder tags will need to be added to any that care > about the order of their execution, and names like > "000.*" can be eliminated There is very little chance of getting this to fly. Remember, any solution has to work for all releases currently supported by ports. In practice, this currently means the security branches so anything that breaks existing localpkg based systems is not going to work. I think that keeping the .sh extension is going to be required for the foreseeable future. Requiring that rcorder runs on all the .sh files generate an appropriate order is probably a reasonable goal for 6.0. If we did that in 6.0, we could require the removal of non .sh files for 7.0 and remove the .sh extensions through a release dependent action in the RC_SUBR support in bsd.port.mk. In theory you could do the RC_SUBR changes for 6.0, but big changes to requirements for ports are very time consuming, especially if you are going to modify bsd.port.mk. Any change of this order is going to require discussion on ports, and buy-in from portmgr. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --7SrMUQONj8Rl9QNG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCpdtjXY6L6fI4GtQRAuC/AJ96C6BF2iY0QvLJCdg0jYKOtfExvQCeIfOQ 29LiUTtbLKtKdINOWPGn5IU= =CxVf -----END PGP SIGNATURE----- --7SrMUQONj8Rl9QNG-- From owner-freebsd-rc@FreeBSD.ORG Tue Jun 7 18:35:05 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AAB9716A41F for ; Tue, 7 Jun 2005 18:35:05 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [66.150.201.101]) by mx1.FreeBSD.org (Postfix) with SMTP id 0B41343D49 for ; Tue, 7 Jun 2005 18:35:04 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 84289 invoked by uid 399); 7 Jun 2005 18:35:03 -0000 Received: from unknown (HELO ?192.0.35.182?) (dougb@dougbarton.net@192.0.35.182) by mail1.fluidhosting.com with SMTP; 7 Jun 2005 18:35:03 -0000 Message-ID: <42A5E8D7.6090607@FreeBSD.org> Date: Tue, 07 Jun 2005 11:35:03 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050326) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tobias Roth References: <20050605022207.GA18499@dragon.NUXI.org> <42A4C8CB.8090809@FreeBSD.org> <20050607062610.GA17215@droopy.unibe.ch> In-Reply-To: <20050607062610.GA17215@droopy.unibe.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, freebsd-rc@freebsd.org Subject: Re: I'd like to rm these RCng files X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 18:35:05 -0000 Tobias Roth wrote: > On Mon, Jun 06, 2005 at 03:06:03PM -0700, Doug Barton wrote: > >>In the future though, it would be nice to ask about rc.d related stuff on >>the freebsd-rc@freebsd.org mailing list. > > > To increase the chances of having topics like that sent to > freebsd-rc, you may want to consider to tell people about it on the > FreeBSD website. For instance here: > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/eresources.html I wasn't aware that this had not been done, thanks for the reminder. I did it just now. Should show up on the web site in < 24 hours. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Tue Jun 7 19:11:29 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3DB6E16A41C; Tue, 7 Jun 2005 19:11:29 +0000 (GMT) (envelope-from jr@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BC6F43D1F; Tue, 7 Jun 2005 19:11:28 +0000 (GMT) (envelope-from jr@opal.com) Received: from linwhf.opal.com (112.79.171.66.subscriber.vzavenue.net [66.171.79.112]) by smtp.vzavenue.net (MOS 3.4.8-GR) with ESMTP id CIW37396; Tue, 7 Jun 2005 15:11:12 -0400 (EDT) Received: from ASSP-nospam (localhost [127.0.0.1]) by linwhf.opal.com (8.13.3/8.13.3) with ESMTP id j57JBBiR047565; Tue, 7 Jun 2005 15:11:11 -0400 (EDT) (envelope-from jr@opal.com) Received: from 127.0.0.1 ([127.0.0.1] helo=linwhf.opal.com) by ASSP-nospam ; 7 Jun 05 19:11:11 -0000 Received: (from jr@localhost) by linwhf.opal.com (8.13.3/8.13.3/Submit) id j57JB9Eo047564; Tue, 7 Jun 2005 15:11:09 -0400 (EDT) (envelope-from jr) Date: Tue, 7 Jun 2005 15:11:09 -0400 From: "J.R. Oldroyd" To: Brooks Davis Message-ID: <20050607191109.GU37208@linwhf.opal.com> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h" Content-Disposition: inline In-Reply-To: <20050607173741.GI11758@odin.ac.hmc.edu> User-Agent: Mutt/1.4.2.1i X-Junkmail-Status: score=0/50, host=smtp.vzavenue.net Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 19:11:29 -0000 --veXX9dWIonWZEC6h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jun 07, 10:37, Brooks Davis wrote: > > So, if this approach were adopted, several > > changes will be needed to all local rc scripts: > > - any with a .sh suffix will need to be renamed from > > "foo.sh" to "foo" > > - any files like "*.sh.sample" will have to be moved > > elsewhere, or made non-executable > > - rcorder tags will need to be added to any that care > > about the order of their execution, and names like > > "000.*" can be eliminated >=20 > There is very little chance of getting this to fly. Remember, any > solution has to work for all releases currently supported by ports. In > practice, this currently means the security branches so anything that > breaks existing localpkg based systems is not going to work. I think > that keeping the .sh extension is going to be required for the > foreseeable future. Requiring that rcorder runs on all the .sh files > generate an appropriate order is probably a reasonable goal for 6.0. > If we did that in 6.0, we could require the removal of non .sh files for > 7.0 and remove the .sh extensions through a release dependent action in > the RC_SUBR support in bsd.port.mk. In theory you could do the RC_SUBR > changes for 6.0, but big changes to requirements for ports are very time > consuming, especially if you are going to modify bsd.port.mk. >=20 > Any change of this order is going to require discussion on ports, and > buy-in from portmgr. >=20 Is this as bad as you're suggesting? Agreed, requiring "foo.sh" be renamed to "foo" for so many ports is a biggie, so perhaps we keep the *.sh for now, and arrange that files in the local scripts dirs are run in a subshell from rc.subr, rather than being sourced. This is probably important for security reasons, anyway. It also keeps existing semantics, so should work on all systems. It also eliminates the issue with foo.sh.sample as such files will continue to be ignored. We only need to add rcorder tags on ports which currently use "NNN.foo.sh" scripts, and we could even delay this by introducing an extra rc.conf flag to have /etc/rc execute any local NNN files immediately after SERVERS or such suitable point. If you feel this is not the desired direction, let's revert back to the "localpkg hack". My goal here was to simply introduce the use of rcorder for local scripts so that those scripts which do have tags can take advantage of them and thereby fix a problem in which some things currently don't start. -jr --veXX9dWIonWZEC6h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iQDVAwUBQqXxTUkkqUax7f6FAQLH0gYAnwsFo3YgGxXfg6Y/lvkqDZifz0lscp5Q UNGDDCVw0SzpnPW9kcJwzjW55VPn1RTKSB23AQ0+vehk8ZhxgksyPzGPSscuP0fD yZjBTMihjJ7QutVprGmaqrNpW8wVPcyjmCzsN94qjVZqSRZT0/A9KlkvPugv9EnJ nmi73HkXsNp9Fbi5MLyKLBWIFnkxYRlgXuIpDZ/Bs48yFFzRHMW5En2DiTw6sUlu KAFHW0vWpYYVXjk+2dyYz8IVimbFHttO =UfOE -----END PGP SIGNATURE----- --veXX9dWIonWZEC6h-- From owner-freebsd-rc@FreeBSD.ORG Wed Jun 8 23:38:03 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD43A16A41C; Wed, 8 Jun 2005 23:38:03 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FC3A43D4C; Wed, 8 Jun 2005 23:38:03 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j58Nc2Cd032410; Wed, 8 Jun 2005 16:38:02 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j58Nc2m7032409; Wed, 8 Jun 2005 16:38:02 -0700 Date: Wed, 8 Jun 2005 16:38:02 -0700 From: Brooks Davis To: "J.R. Oldroyd" Message-ID: <20050608233802.GA29707@odin.ac.hmc.edu> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> <20050607191109.GU37208@linwhf.opal.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <20050607191109.GU37208@linwhf.opal.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2005 23:38:03 -0000 --KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 07, 2005 at 03:11:09PM -0400, J.R. Oldroyd wrote: > On Jun 07, 10:37, Brooks Davis wrote: > > > So, if this approach were adopted, several > > > changes will be needed to all local rc scripts: > > > - any with a .sh suffix will need to be renamed from > > > "foo.sh" to "foo" > > > - any files like "*.sh.sample" will have to be moved > > > elsewhere, or made non-executable > > > - rcorder tags will need to be added to any that care > > > about the order of their execution, and names like > > > "000.*" can be eliminated > >=20 > > There is very little chance of getting this to fly. Remember, any > > solution has to work for all releases currently supported by ports. In > > practice, this currently means the security branches so anything that > > breaks existing localpkg based systems is not going to work. I think > > that keeping the .sh extension is going to be required for the > > foreseeable future. Requiring that rcorder runs on all the .sh files > > generate an appropriate order is probably a reasonable goal for 6.0. > > If we did that in 6.0, we could require the removal of non .sh files for > > 7.0 and remove the .sh extensions through a release dependent action in > > the RC_SUBR support in bsd.port.mk. In theory you could do the RC_SUBR > > changes for 6.0, but big changes to requirements for ports are very time > > consuming, especially if you are going to modify bsd.port.mk. > >=20 > > Any change of this order is going to require discussion on ports, and > > buy-in from portmgr. > >=20 >=20 > Is this as bad as you're suggesting? Possibly. :-| The curse of having nearly 13,000 ports is that changes in any significant portion are quite difficult if you have to have a flag day. It's by no means impossible, but it's a lot of work. > Agreed, requiring "foo.sh" be renamed to "foo" for so many ports > is a biggie, so perhaps we keep the *.sh for now, and arrange that > files in the local scripts dirs are run in a subshell from rc.subr, > rather than being sourced. This is probably important for security > reasons, anyway. It also keeps existing semantics, so should work > on all systems. >=20 > It also eliminates the issue with foo.sh.sample as such files > will continue to be ignored. I think we definitely want to keep the existing semantics of *.sh scripts being run for the time being, if not permanently. > We only need to add rcorder tags on ports which currently use > "NNN.foo.sh" scripts, and we could even delay this by introducing > an extra rc.conf flag to have /etc/rc execute any local NNN files > immediately after SERVERS or such suitable point. The trick is finding all of them. We don't currently have a plist database. It's something that needs to happen, but until it exists, finding all the rc files is an interesting challenge. It's probably not infeasible by 6.0 though if you can get kris to help you. > If you feel this is not the desired direction, let's revert back > to the "localpkg hack". My goal here was to simply introduce the > use of rcorder for local scripts so that those scripts which do > have tags can take advantage of them and thereby fix a problem > in which some things currently don't start. What I like about the localpkg hack is that it doesn't change much. I think you have solutions to most of my concerns though. My gut feeling is that full integration of /usr/local in rcorder is not feasible for 6.0, but localpkg with rcorder should be. Remember, feature freeze is nominally Friday. My suggestion would be to push for the localpkg hack and the port changes it requires for 6.0 so ports can depend on each other's services with the plan of doing full integration in 7.0. That would get the most critical feature working now and give us over a year to shake out any issues with full ordering. After a good period of settling, I think we could even MFC the localpkg hack to 5.x, probably in time for 5.5. If that, happened, I think we'd be able to fully mandate rc.d style scripts for 7.0 because all supported versions of FreeBSD would run rcorder on their scripts. BTW, thanks for working on this. It's a feature I've been wanting for some time now. As always the devil is the details. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --KsGdsel6WgEHnImy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCp4FZXY6L6fI4GtQRAhx6AJ9JefC/eGcFb0EF8VyJr848IkekTQCeM5fo ra5aMUQ2o8jEGubUftCAwZ0= =Em6W -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy-- From owner-freebsd-rc@FreeBSD.ORG Thu Jun 9 00:35:13 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBFA516A41C; Thu, 9 Jun 2005 00:35:13 +0000 (GMT) (envelope-from jr@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5969C43D58; Thu, 9 Jun 2005 00:35:12 +0000 (GMT) (envelope-from jr@opal.com) Received: from linwhf.opal.com (112.79.171.66.subscriber.vzavenue.net [66.171.79.112]) by smtp.vzavenue.net (MOS 3.4.8-GR) with ESMTP id CJB20781; Wed, 8 Jun 2005 20:35:00 -0400 (EDT) Received: from ASSP-nospam (localhost [127.0.0.1]) by linwhf.opal.com (8.13.3/8.13.3) with ESMTP id j590YxvY065544; Wed, 8 Jun 2005 20:34:59 -0400 (EDT) (envelope-from jr@opal.com) Received: from 127.0.0.1 ([127.0.0.1] helo=linwhf.opal.com) by ASSP-nospam ; 9 Jun 05 00:34:59 -0000 Received: (from jr@localhost) by linwhf.opal.com (8.13.3/8.13.3/Submit) id j590YxIi065543; Wed, 8 Jun 2005 20:34:59 -0400 (EDT) (envelope-from jr) Date: Wed, 8 Jun 2005 20:34:59 -0400 From: "J.R. Oldroyd" To: Brooks Davis Message-ID: <20050609003459.GK37208@linwhf.opal.com> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> <20050607191109.GU37208@linwhf.opal.com> <20050608233802.GA29707@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pWOmaDnDlrCGjNh4" Content-Disposition: inline In-Reply-To: <20050608233802.GA29707@odin.ac.hmc.edu> User-Agent: Mutt/1.4.2.1i X-Junkmail-Status: score=0/50, host=smtp.vzavenue.net Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 00:35:14 -0000 --pWOmaDnDlrCGjNh4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jun 08, 16:38, Brooks Davis wrote: >=20 > What I like about the localpkg hack is that it doesn't change much. I > think you have solutions to most of my concerns though. My gut feeling > is that full integration of /usr/local in rcorder is not feasible for > 6.0, but localpkg with rcorder should be. Remember, feature freeze is > nominally Friday. My suggestion would be to push for the localpkg hack > and the port changes it requires for 6.0 so ports can depend on > each other's services with the plan of doing full integration in 7.0. > That would get the most critical feature working now and give us over a > year to shake out any issues with full ordering. After a good period of > settling, I think we could even MFC the localpkg hack to 5.x, probably in > time for 5.5. If that, happened, I think we'd be able to fully mandate > rc.d style scripts for 7.0 because all supported versions of FreeBSD > would run rcorder on their scripts. >=20 I have yet another diff to localpkg, this one explicitly creates two lists, one for [^0-9]*.sh files and the other for [0-9]*.sh files. It then uses rcorder to sort the non-numeric-named ones, prepends the numeric-named ones and runs them. This retains existing 000.foo.sh functionality and makes it, I believe, so that no port changes are needed! It's below. =20 OK, so what needs to be done next in terms of "push[ing] for the localpkg hack and the port changes it requires" before Friday? To whom should I send this? > BTW, thanks for working on this. It's a feature I've been wanting for > some time now. As always the devil is the details. >=20 You're welcome. -jr --- /etc/rc.d/localpkg.orig Fri Oct 8 13:52:43 2004 +++ /etc/rc.d/localpkg Tue Jun 7 15:19:19 2005 @@ -14,6 +14,9 @@ start_cmd=3D"pkg_start" stop_cmd=3D"pkg_stop" =20 +rcorder_opts=3D"" +[ `/sbin/sysctl -n security.jail.jailed` -eq 1 ] && rcorder_opts=3D"-s noj= ail" + pkg_start() { # For each dir in $local_startup, search for init scripts matching *.sh @@ -24,19 +27,14 @@ *) echo -n 'Local package initialization:' slist=3D"" - if [ -z "${script_name_sep}" ]; then - script_name_sep=3D" " - fi + zlist=3D"" for dir in ${local_startup}; do if [ -d "${dir}" ]; then - for script in ${dir}/*.sh; do - slist=3D"${slist}${script_name_sep}${script}" - done + slist=3D"${slist} ${dir}/[^0-9]*.sh" + zlist=3D"${zlist} ${dir}/[0-9]*.sh" fi done - script_save_sep=3D"$IFS" - IFS=3D"${script_name_sep}" - for script in ${slist}; do + for script in ${zlist} `rcorder -s nostart ${rcorder_opts} ${slist} 2>/d= ev/null`; do if [ -x "${script}" ]; then (set -T trap 'exit 1' 2 @@ -45,7 +43,6 @@ echo -n " (skipping ${script##*/}, not executable)" fi done - IFS=3D"${script_save_sep}" echo '.' ;; esac @@ -61,26 +58,20 @@ ;; *) slist=3D"" - if [ -z "${script_name_sep}" ]; then - script_name_sep=3D" " - fi + zlist=3D"" for dir in ${local_startup}; do if [ -d "${dir}" ]; then - for script in ${dir}/*.sh; do - slist=3D"${slist}${script_name_sep}${script}" - done + slist=3D"${slist} ${dir}/[^0-9]*.sh" + zlist=3D"${zlist} ${dir}/[0-9]*.sh" fi done - script_save_sep=3D"$IFS" - IFS=3D"${script_name_sep}" - for script in `reverse_list ${slist}`; do + for script in `reverse_list ${zlist} \`rcorder -k shutdown ${rcorder_opt= s} ${slist} 2>/dev/null\``; do if [ -x "${script}" ]; then (set -T trap 'exit 1' 2 ${script} stop) fi done - IFS=3D"${script_save_sep}" echo '.' ;; esac --pWOmaDnDlrCGjNh4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iQDVAwUBQqeOskkkqUax7f6FAQKnvAX/Uq+0+oe0LOmKcesqZa8mtBVG3PLt1zYJ UJklV2oE5zCihfJrEJIEtZ9I/yPd99uRQJaZzOhe+pUufkFkoNRh/etdQvqs28xq G010VNjXSkhrYCVtSS33g3ccKgDT3OtcehbWqoA9A4ANrhPsetlH3eWmRIXmNcg1 sOWC8GYFHmRm7BN5k4e60hDuPskey+MBmBwv9p8WueohVz79j2q18fAtaBAtZr1f 18nz2wkSRA7TEe7WaiHqkPZLFU08ruPg =A4li -----END PGP SIGNATURE----- --pWOmaDnDlrCGjNh4-- From owner-freebsd-rc@FreeBSD.ORG Thu Jun 9 05:05:18 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D0D816A41C; Thu, 9 Jun 2005 05:05:18 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F32B43D49; Thu, 9 Jun 2005 05:05:18 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j5955H84029918; Wed, 8 Jun 2005 22:05:17 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j5955HW1029917; Wed, 8 Jun 2005 22:05:17 -0700 Date: Wed, 8 Jun 2005 22:05:17 -0700 From: Brooks Davis To: "J.R. Oldroyd" Message-ID: <20050609050517.GA28710@odin.ac.hmc.edu> References: <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> <20050607191109.GU37208@linwhf.opal.com> <20050608233802.GA29707@odin.ac.hmc.edu> <20050609003459.GK37208@linwhf.opal.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: <20050609003459.GK37208@linwhf.opal.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 05:05:18 -0000 --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 08, 2005 at 08:34:59PM -0400, J.R. Oldroyd wrote: > On Jun 08, 16:38, Brooks Davis wrote: > >=20 > > What I like about the localpkg hack is that it doesn't change much. I > > think you have solutions to most of my concerns though. My gut feeling > > is that full integration of /usr/local in rcorder is not feasible for > > 6.0, but localpkg with rcorder should be. Remember, feature freeze is > > nominally Friday. My suggestion would be to push for the localpkg hack > > and the port changes it requires for 6.0 so ports can depend on > > each other's services with the plan of doing full integration in 7.0. > > That would get the most critical feature working now and give us over a > > year to shake out any issues with full ordering. After a good period of > > settling, I think we could even MFC the localpkg hack to 5.x, probably = in > > time for 5.5. If that, happened, I think we'd be able to fully mandate > > rc.d style scripts for 7.0 because all supported versions of FreeBSD > > would run rcorder on their scripts. >=20 > I have yet another diff to localpkg, this one explicitly creates > two lists, one for [^0-9]*.sh files and the other for [0-9]*.sh files. > It then uses rcorder to sort the non-numeric-named ones, prepends > the numeric-named ones and runs them. This retains existing > 000.foo.sh functionality and makes it, I believe, so that no port > changes are needed! It's below. My one concern about this is that if we don't force a change it will never happen. The problem is that we need to keep the 000.* files around until versions without rcorder in localpkg are not supported, but if we don't force people to switch to correct rcorder declerations in the files, it's going to be painful when the time comes to get rid of this hack. > OK, so what needs to be done next in terms of "push[ing] for the localpkg > hack and the port changes it requires" before Friday? To whom should > I send this? I'd float the concept on ports@ and make sure no one is too upset by it. I'd actually propose both this version and a total rcorder based version. Feel free to say I reviewed the concept. Also, propose it to re@ and cc me on that. If they approve it, it can go in after the freeze, the bar is just slightly higher. In the patch, I'm actually of two minds about the script_name_sep removal. On one hand, it's somewhat unintuative, on the other hand, it keeps the line lengths more sane. Overall, I don't think it matters much and I'm ok with the patch as is. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCp84MXY6L6fI4GtQRAr0hAJwLcigLmkxZIFIc/k77mi9Ggr9rEACgieGk M4JIeKAXkfMVe1vXWRM1w+Q= =idsW -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV-- From owner-freebsd-rc@FreeBSD.ORG Thu Jun 9 19:47:40 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09A3116A41C for ; Thu, 9 Jun 2005 19:47:40 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [66.150.201.101]) by mx1.FreeBSD.org (Postfix) with SMTP id 7532643D49 for ; Thu, 9 Jun 2005 19:47:39 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 63380 invoked by uid 399); 9 Jun 2005 19:47:37 -0000 Received: from unknown (HELO ?192.0.35.182?) (dougb@dougbarton.net@192.0.35.182) by mail1.fluidhosting.com with SMTP; 9 Jun 2005 19:47:37 -0000 Message-ID: <42A89CD7.1080404@FreeBSD.org> Date: Thu, 09 Jun 2005 12:47:35 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brooks Davis References: <42A4CA37.1050201@FreeBSD.org> <20050606235426.GA10526@odin.ac.hmc.edu> <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> <20050607191109.GU37208@linwhf.opal.com> <20050608233802.GA29707@odin.ac.hmc.edu> <20050609003459.GK37208@linwhf.opal.com> <20050609050517.GA28710@odin.ac.hmc.edu> In-Reply-To: <20050609050517.GA28710@odin.ac.hmc.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org, "J.R. Oldroyd" Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 19:47:40 -0000 I've been following this discussion with interest, and I think that Brooks is right about not having a flag day. On the other hand, I have seen many people say that they want to get the ports rc.d scripts integrated into the main rcorder, since some of their software "needs" this functionality. This will become increasingly important as we move to modularize the base more and more (ala BIND and openssl). So, what about this for a compromise? We continue running localpkg to handle the 000.*.sh and such, with JR's hack to incorporate those better. But we ALSO build in the functionality to the main rcorder implementation to handle scripts that do not have *.sh, and we require port authors to include a special keyword in the script so that rc.subr will know that it is "safe" to handle them this way. Once the transition is "complete," we drop processing of the keyword, and the port authors can remove it at their leisure. Thoughts? Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Thu Jun 9 20:10:19 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBA6316A41C; Thu, 9 Jun 2005 20:10:18 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9978743D1F; Thu, 9 Jun 2005 20:10:18 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j59KAHUk011696; Thu, 9 Jun 2005 13:10:17 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j59KAHxu011695; Thu, 9 Jun 2005 13:10:17 -0700 Date: Thu, 9 Jun 2005 13:10:17 -0700 From: Brooks Davis To: Doug Barton Message-ID: <20050609201017.GA10248@odin.ac.hmc.edu> References: <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> <20050607191109.GU37208@linwhf.opal.com> <20050608233802.GA29707@odin.ac.hmc.edu> <20050609003459.GK37208@linwhf.opal.com> <20050609050517.GA28710@odin.ac.hmc.edu> <42A89CD7.1080404@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <42A89CD7.1080404@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@FreeBSD.org, "J.R. Oldroyd" Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 20:10:19 -0000 --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 09, 2005 at 12:47:35PM -0700, Doug Barton wrote: > I've been following this discussion with interest, and I think that Brooks > is right about not having a flag day. On the other hand, I have seen many > people say that they want to get the ports rc.d scripts integrated into t= he > main rcorder, since some of their software "needs" this functionality. Th= is > will become increasingly important as we move to modularize the base more > and more (ala BIND and openssl). > > So, what about this for a compromise? We continue running localpkg to han= dle > the 000.*.sh and such, with JR's hack to incorporate those better. But we > ALSO build in the functionality to the main rcorder implementation to han= dle > scripts that do not have *.sh, and we require port authors to include a > special keyword in the script so that rc.subr will know that it is "safe"= to > handle them this way. Once the transition is "complete," we drop processi= ng > of the keyword, and the port authors can remove it at their leisure. This sounds mostly workable. The generation of the rcorder commandline gets a bit more complicated because we'll need to make two passes through /usr/local/etc/rc.d in rc, but that's probably acceptable. I'm a bit unhappy with doubling the size of code in /etc/rc to do this, but I suppose it's probably worth it. One thing to worry about is that this does actually require a flagday. Currently, the RC_ORDER bsd.port.mk variable allows scripts to be included in rcorder by installing them directly in /etc/rc.d. Any thing that used the new flag and moved back to /usr/local/etc/rc.d would stop working on 5.x in this case. I suppose we could modify the RC_ORDER support to install the files in /usr/local/etc/rc.d on systems with the rc changes. That would require a couple of port build runs though. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCqKIpXY6L6fI4GtQRAsQMAKDEtFlN0DY3dfjNTeSo5IWfiJfL3gCeLtKm 5NzcOP1+MkVR0tcw9EEhWbM= =0Dcp -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY-- From owner-freebsd-rc@FreeBSD.ORG Thu Jun 9 20:39:57 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7399D16A41C for ; Thu, 9 Jun 2005 20:39:57 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [66.150.201.101]) by mx1.FreeBSD.org (Postfix) with SMTP id DC62043D53 for ; Thu, 9 Jun 2005 20:39:56 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 84089 invoked by uid 399); 9 Jun 2005 20:39:55 -0000 Received: from unknown (HELO ?192.0.35.182?) (dougb@dougbarton.net@192.0.35.182) by mail1.fluidhosting.com with SMTP; 9 Jun 2005 20:39:55 -0000 Message-ID: <42A8A91B.8000402@FreeBSD.org> Date: Thu, 09 Jun 2005 13:39:55 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brooks Davis References: <20050607001447.GG37208@linwhf.opal.com> <20050607003142.GD10526@odin.ac.hmc.edu> <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> <20050607191109.GU37208@linwhf.opal.com> <20050608233802.GA29707@odin.ac.hmc.edu> <20050609003459.GK37208@linwhf.opal.com> <20050609050517.GA28710@odin.ac.hmc.edu> <42A89CD7.1080404@FreeBSD.org> <20050609201017.GA10248@odin.ac.hmc.edu> In-Reply-To: <20050609201017.GA10248@odin.ac.hmc.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org, "J.R. Oldroyd" Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 20:39:57 -0000 Glad to hear that we're more or less in agreement ... Brooks Davis wrote: > One thing to worry about is that this does actually require a flagday. > Currently, the RC_ORDER bsd.port.mk variable allows scripts to be > included in rcorder by installing them directly in /etc/rc.d. Any thing > that used the new flag and moved back to /usr/local/etc/rc.d would stop > working on 5.x in this case. I suppose we could modify the RC_ORDER > support to install the files in /usr/local/etc/rc.d on systems with the > rc changes. That would require a couple of port build runs though. Agreed, we need to coordinate this with the ports folks carefully, but I'm less concerned about that because the ports freeze for 6-release won't be for a long time. The freeze/slushie for the base is tomorrow. :) I sent a note to re@ saying that this change was coming, so hopefully they can cut us a little slack. But it sounds like we agree on the big picture stuff, if we can get some patches out tonight for broader review (say on -current and -ports), then I would feel comfortable getting the code in the base tomorrow before the freeze, then refining it in the next couple months. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Thu Jun 9 21:02:24 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84F3C16A41C; Thu, 9 Jun 2005 21:02:24 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 438B743D1D; Thu, 9 Jun 2005 21:02:24 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j59L2NNr017569; Thu, 9 Jun 2005 14:02:23 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j59L2N0D017568; Thu, 9 Jun 2005 14:02:23 -0700 Date: Thu, 9 Jun 2005 14:02:23 -0700 From: Brooks Davis To: Doug Barton Message-ID: <20050609210223.GB16168@odin.ac.hmc.edu> References: <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> <20050607191109.GU37208@linwhf.opal.com> <20050608233802.GA29707@odin.ac.hmc.edu> <20050609003459.GK37208@linwhf.opal.com> <20050609050517.GA28710@odin.ac.hmc.edu> <42A89CD7.1080404@FreeBSD.org> <20050609201017.GA10248@odin.ac.hmc.edu> <42A8A91B.8000402@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="v9Ux+11Zm5mwPlX6" Content-Disposition: inline In-Reply-To: <42A8A91B.8000402@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@FreeBSD.org, "J.R. Oldroyd" Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 21:02:24 -0000 --v9Ux+11Zm5mwPlX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 09, 2005 at 01:39:55PM -0700, Doug Barton wrote: > Glad to hear that we're more or less in agreement ... >=20 > Brooks Davis wrote: >=20 > > One thing to worry about is that this does actually require a flagday. > > Currently, the RC_ORDER bsd.port.mk variable allows scripts to be > > included in rcorder by installing them directly in /etc/rc.d. Any thing > > that used the new flag and moved back to /usr/local/etc/rc.d would stop > > working on 5.x in this case. I suppose we could modify the RC_ORDER > > support to install the files in /usr/local/etc/rc.d on systems with the > > rc changes. That would require a couple of port build runs though. >=20 > Agreed, we need to coordinate this with the ports folks carefully, but I'm > less concerned about that because the ports freeze for 6-release won't be > for a long time. The freeze/slushie for the base is tomorrow. :) > > I sent a note to re@ saying that this change was coming, so hopefully they > can cut us a little slack. But it sounds like we agree on the big picture > stuff, if we can get some patches out tonight for broader review (say on > -current and -ports), then I would feel comfortable getting the code in t= he > base tomorrow before the freeze, then refining it in the next couple mont= hs. Do you want to work up a patch for /etc/rc or at least the outline of the idea to sent out for wider exposure? JR told me in private e-mail that he will be mostly out of contact until next Tuesday so one of us needs to do it. I've got more build testing to do on my ifnet patch, a few changes to dig up that I forgot I hadn't committed, and some real-job work to do before tomarrow so I'd rather it wasn't me. I think JR's localpkg changes in gnats are right subject to some testing. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --v9Ux+11Zm5mwPlX6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCqK5eXY6L6fI4GtQRArO4AJ9KOgWN2w8lU5p9m04NK3D5MK3o2ACfcJ4Q AfiRhUKuilYZkg82Yxm4Xfo= =tESN -----END PGP SIGNATURE----- --v9Ux+11Zm5mwPlX6-- From owner-freebsd-rc@FreeBSD.ORG Thu Jun 9 21:16:38 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 87E8316A41C for ; Thu, 9 Jun 2005 21:16:38 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [66.150.201.101]) by mx1.FreeBSD.org (Postfix) with SMTP id 0E92543D1F for ; Thu, 9 Jun 2005 21:16:37 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 66380 invoked by uid 399); 9 Jun 2005 21:16:33 -0000 Received: from unknown (HELO ?192.0.35.182?) (dougb@dougbarton.net@192.0.35.182) by mail1.fluidhosting.com with SMTP; 9 Jun 2005 21:16:33 -0000 Message-ID: <42A8B1B1.1070208@FreeBSD.org> Date: Thu, 09 Jun 2005 14:16:33 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brooks Davis References: <20050607033536.GH37208@linwhf.opal.com> <20050607160855.GO37208@linwhf.opal.com> <20050607173741.GI11758@odin.ac.hmc.edu> <20050607191109.GU37208@linwhf.opal.com> <20050608233802.GA29707@odin.ac.hmc.edu> <20050609003459.GK37208@linwhf.opal.com> <20050609050517.GA28710@odin.ac.hmc.edu> <42A89CD7.1080404@FreeBSD.org> <20050609201017.GA10248@odin.ac.hmc.edu> <42A8A91B.8000402@FreeBSD.org> <20050609210223.GB16168@odin.ac.hmc.edu> In-Reply-To: <20050609210223.GB16168@odin.ac.hmc.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org, "J.R. Oldroyd" Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 21:16:38 -0000 Brooks Davis wrote: > Do you want to work up a patch for /etc/rc or at least the outline of > the idea to sent out for wider exposure? JR told me in private e-mail > that he will be mostly out of contact until next Tuesday so one of us > needs to do it. I've got more build testing to do on my ifnet patch, > a few changes to dig up that I forgot I hadn't committed, and some > real-job work to do before tomarrow so I'd rather it wasn't me. I think > JR's localpkg changes in gnats are right subject to some testing. I'm happy to do that. I think JR has us most of the way there already. Thanks for the info on him being unavailable, makes it easier to move forward. Doug -- This .signature sanitized for your protection