From owner-freebsd-rc@FreeBSD.ORG Mon Oct 24 11:02:15 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 887DD16A41F for ; Mon, 24 Oct 2005 11:02:15 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 500FE43D46 for ; Mon, 24 Oct 2005 11:02:15 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9OB2FvC062075 for ; Mon, 24 Oct 2005 11:02:15 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9OB2EEK062069 for freebsd-rc@freebsd.org; Mon, 24 Oct 2005 11:02:14 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 24 Oct 2005 11:02:14 GMT Message-Id: <200510241102.j9OB2EEK062069@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2005 11:02:15 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2005/02/10] conf/77340 rc awk used in /etc/rc.d/nsswitch when not a 1 problem total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2004/06/30] conf/68525 rc Loader's verbose boot mode has rc.d/local o [2004/07/07] conf/68745 rc /etc/rc.d/devfs runs after ntpd so links o [2005/05/14] kern/81006 rc ipnat not working with tunnel interfaces 3 problems total. From owner-freebsd-rc@FreeBSD.ORG Wed Oct 26 04:47:25 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 483AF16A41F for ; Wed, 26 Oct 2005 04:47:25 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F8B143D46; Wed, 26 Oct 2005 04:47:25 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from freefall.freebsd.org (yar@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9Q4lON2026813; Wed, 26 Oct 2005 04:47:24 GMT (envelope-from yar@freefall.freebsd.org) Received: (from yar@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9Q4lOj5026812; Wed, 26 Oct 2005 04:47:24 GMT (envelope-from yar) Date: Wed, 26 Oct 2005 04:47:23 +0000 From: Yar Tikhiy To: Christian Brueffer Message-ID: <20051026044723.GA26479@freefall.freebsd.org> References: <20051006020056.GD36427@comp.chem.msu.su> <20051006200232.GC5166@unixpages.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051006200232.GC5166@unixpages.org> User-Agent: Mutt/1.4.2.1i Cc: freebsd-rc@freebsd.org Subject: Re: An article on BSD rc.d scripting X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2005 04:47:25 -0000 On Thu, Oct 06, 2005 at 10:02:32PM +0200, Christian Brueffer wrote: > On Thu, Oct 06, 2005 at 06:00:56AM +0400, Yar Tikhiy wrote: > > All, > > > > I was so pleased with the rc.d framework when I met it closely for > > the first time that I decided to write an article based on my > > experience of learning how to write rc.d scripts. Finally, I've > > got something like the article. Here it is: > > > > http://people.freebsd.org/~yar/rcng/ > > > > As usual, article.sgml is the source and article.html is an HTML > > document built from it. > > > > Looking forward for your comments and suggestions. Thanks! > > > > Cool! Maybe this would better fit into the developer's/architecture > handbook? I'm not sure, what do you think? Sorry, I missed your reply for some reason. I thought about including my article in one of our greater books, but my argument against it was that its approach didn't agree well with that of the books. Yar From owner-freebsd-rc@FreeBSD.ORG Wed Oct 26 05:10:36 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC8AA16A41F for ; Wed, 26 Oct 2005 05:10:36 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3779743D45 for ; Wed, 26 Oct 2005 05:10:35 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9Q5AUU2037354; Wed, 26 Oct 2005 09:10:30 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9Q5AT30037353; Wed, 26 Oct 2005 09:10:29 +0400 (MSD) (envelope-from yar) Date: Wed, 26 Oct 2005 09:10:29 +0400 From: Yar Tikhiy To: freebsd-rc@freebsd.org Message-ID: <20051026051029.GA32620@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.9i Cc: Subject: A fix for `restart' X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2005 05:10:37 -0000 Folks, Would you mind testing the following patch to /etc/rc.subr that should remedy problems with `restart', e.g., as found for /etc/rc.d/jail? It is safe as it doesn't affect other commans and hence it won't disrupt your boot sequence :-) I'm just concerned about possible side-effects for restart I might have overlooked. The test case of scripts taking additional arguments besides the command is the most intriguing. ----- Begin patch ----- --- //depot/user/yar/hack/etc/rc.subr 2005/10/26 04:02:40 +++ //depot/user/yar/hack/etc/rc.subr 2005/10/26 04:57:21 @@ -770,8 +770,9 @@ fi _rc_restart_done=true - ( $0 ${_rc_prefix}stop $rc_extra_args ) - $0 ${_rc_prefix}start $rc_extra_args + # run stop in a subshell to keep variables for start + ( run_rc_command ${_rc_prefix}stop $rc_extra_args ) + run_rc_command ${_rc_prefix}start $rc_extra_args if [ -n "$_postcmd" ]; then eval $_postcmd $rc_extra_args ----- End patch ----- -- Yar From owner-freebsd-rc@FreeBSD.ORG Thu Oct 27 09:19:26 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 100AC16A41F; Thu, 27 Oct 2005 09:19:26 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0E0E43D48; Thu, 27 Oct 2005 09:19:24 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9R9JLPH012921; Thu, 27 Oct 2005 13:19:21 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9R9JLvO012920; Thu, 27 Oct 2005 13:19:21 +0400 (MSD) (envelope-from yar) Date: Thu, 27 Oct 2005 13:19:20 +0400 From: Yar Tikhiy To: Pawel Jakub Dawidek Message-ID: <20051027091920.GA11982@comp.chem.msu.su> Mail-Followup-To: yar@comp.chem.msu.su, pjd@FreeBSD.org, freebsd-rc@FreeBSD.org References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027063353.GA63896@garage.freebsd.pl> <20051027071456.GA6598@comp.chem.msu.su> <20051027082115.GA749@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051027082115.GA749@garage.freebsd.pl> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, freebsd-rc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 09:19:26 -0000 On Thu, Oct 27, 2005 at 10:21:16AM +0200, Pawel Jakub Dawidek wrote: > On Thu, Oct 27, 2005 at 11:14:56AM +0400, Yar Tikhiy wrote: > +> On Thu, Oct 27, 2005 at 08:33:53AM +0200, Pawel Jakub Dawidek wrote: > +> > On Sun, Oct 23, 2005 at 02:06:53PM +0000, Yar Tikhiy wrote: > +> > +> yar 2005-10-23 14:06:53 UTC > +> > +> > +> > +> FreeBSD src repository > +> > +> > +> > +> Modified files: > +> > +> etc/rc.d ike named ppp-user sshd > +> > +> Log: > +> > +> Don't be lazy, set the "command" variable even if > +> > +> /etc/defaults/rc.conf will provide foo_program, too. > +> > +> By specifying "command" we explicitly say that we're > +> > +> going to rely on rc.subr(8) default methods, and > +> > +> rc.subr(8) will take advantage of this soon. > +> > +> > +> > +> The majority of our rc.d scripts already set "command" > +> > +> if appropriate, so fix just the non-compliant handful. > +> > [...] > +> > +> name="named" > +> > +> rcvar=`set_rcvar` > +> > +> +command="/usr/sbin/${name}" > +> > [...] > +> > +> name="ppp" > +> > +> rcvar=`set_rcvar` > +> > +> +command="/usr/sbin/ppp" > +> > [...] > +> > +> name="sshd" > +> > +> rcvar=`set_rcvar` > +> > +> +command="/usr/sbin/${name}" > +> > > +> > Any reason you didn't used ${name} in ppp case? > +> > +> I was just blinded by my being solid sure that $name was "ppp-user". > +> Nowever, now I'm in doubt whether $name should be "ppp". The script > +> is named ppp-user and it PROVIDEs ppp-user, hence sysadmins can > +> rightfully assume that its rc.conf.d file is ppp-user, too. Such > +> assumption will be broken since it is $name that is passed to > +> load_rc_config. I think $name should be changed to "ppp-user" in > +> CURRENT. This will introduce minor incompatibility, but also > +> eliminate a source of further confusion. > > It is confusing, but maybe we should rename ppp-user to ppp? > I'm not sure how well sh(1) will handle things like > ppp-user_enable="YES", etc. Yes, this is much better than my lame proposal because so we will have to worry about neither variable naming nor compatibility with installations using ppp and rc.conf.d at once. We change the PROVIDE line and fix all dependent rc.d scripts, then request the repocopy of ppp-user to ppp, fix /etc/netstart, and finally kill the old file. Does this plan look OK? P.S. Looks like it's time to move this thread to -rc, setting Mail-Followup-To accordingly. -- Yar From owner-freebsd-rc@FreeBSD.ORG Thu Oct 27 09:24:06 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8EF2316A41F for ; Thu, 27 Oct 2005 09:24:06 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id E882543D46 for ; Thu, 27 Oct 2005 09:24:05 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 03AFF50F95; Thu, 27 Oct 2005 11:24:02 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 9B214509F1; Thu, 27 Oct 2005 11:23:55 +0200 (CEST) Date: Thu, 27 Oct 2005 11:23:51 +0200 From: Pawel Jakub Dawidek To: yar@comp.chem.msu.su, freebsd-rc@FreeBSD.org Message-ID: <20051027092351.GC749@garage.freebsd.pl> References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027063353.GA63896@garage.freebsd.pl> <20051027071456.GA6598@comp.chem.msu.su> <20051027082115.GA749@garage.freebsd.pl> <20051027091920.GA11982@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6zdv2QT/q3FMhpsV" Content-Disposition: inline In-Reply-To: <20051027091920.GA11982@comp.chem.msu.su> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 09:24:06 -0000 --6zdv2QT/q3FMhpsV Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 27, 2005 at 01:19:20PM +0400, Yar Tikhiy wrote: +> On Thu, Oct 27, 2005 at 10:21:16AM +0200, Pawel Jakub Dawidek wrote: +> > It is confusing, but maybe we should rename ppp-user to ppp? +> > I'm not sure how well sh(1) will handle things like +> > ppp-user_enable=3D"YES", etc. +>=20 +> Yes, this is much better than my lame proposal because so we will +> have to worry about neither variable naming nor compatibility with +> installations using ppp and rc.conf.d at once. We change the PROVIDE +> line and fix all dependent rc.d scripts, then request the repocopy +> of ppp-user to ppp, fix /etc/netstart, and finally kill the old +> file. Does this plan look OK? Sounds good to me. Will be also good to investigate why it was named ppp-user in the first place, maybe it was taken under this name from NetBSD? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --6zdv2QT/q3FMhpsV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDYJynForvXbEpPzQRAuo2AJsEqeLTAz9bihIRrJvSk8QmjAcIXACgj402 lipOaPOATmMSQLaxbZBKbVw= =UKOz -----END PGP SIGNATURE----- --6zdv2QT/q3FMhpsV-- From owner-freebsd-rc@FreeBSD.ORG Thu Oct 27 10:13:36 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6085916A41F; Thu, 27 Oct 2005 10:13:36 +0000 (GMT) (envelope-from sem@FreeBSD.org) Received: from relay-er5.mbrd.ru (relay-er5.mbrd.ru [194.117.71.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F4BE43D45; Thu, 27 Oct 2005 10:13:35 +0000 (GMT) (envelope-from sem@FreeBSD.org) Received: from msd.mbrd.ru ([172.16.4.9]) by relay-er5.mbrd.ru with esmtp (Exim 4.x) id 1EV4lF-000Gx2-5K; Thu, 27 Oct 2005 14:13:29 +0400 Message-ID: <4360A848.5020508@FreeBSD.org> Date: Thu, 27 Oct 2005 14:13:28 +0400 From: Sergey Matveychuk User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027063353.GA63896@garage.freebsd.pl> <20051027071456.GA6598@comp.chem.msu.su> <20051027082115.GA749@garage.freebsd.pl> <20051027091920.GA11982@comp.chem.msu.su> <20051027092351.GC749@garage.freebsd.pl> In-Reply-To: <20051027092351.GC749@garage.freebsd.pl> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 10:13:36 -0000 Pawel Jakub Dawidek wrote: > > Sounds good to me. Will be also good to investigate why it was named > ppp-user in the first place, maybe it was taken under this name from > NetBSD? > I guess to reflect a difference with pppd. -- Sem. From owner-freebsd-rc@FreeBSD.ORG Thu Oct 27 10:15:09 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B375B16A41F; Thu, 27 Oct 2005 10:15:09 +0000 (GMT) (envelope-from sem@FreeBSD.org) Received: from relay-er5.mbrd.ru (relay-er5.mbrd.ru [194.117.71.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88FD643D46; Thu, 27 Oct 2005 10:15:08 +0000 (GMT) (envelope-from sem@FreeBSD.org) Received: from msd.mbrd.ru ([172.16.4.9]) by relay-er5.mbrd.ru with esmtp (Exim 4.x) id 1EV4mp-000H5K-5F; Thu, 27 Oct 2005 14:15:07 +0400 Message-ID: <4360A8AA.5000904@FreeBSD.org> Date: Thu, 27 Oct 2005 14:15:06 +0400 From: Sergey Matveychuk User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027063353.GA63896@garage.freebsd.pl> <20051027071456.GA6598@comp.chem.msu.su> <20051027082115.GA749@garage.freebsd.pl> <20051027091920.GA11982@comp.chem.msu.su> <20051027092351.GC749@garage.freebsd.pl> In-Reply-To: <20051027092351.GC749@garage.freebsd.pl> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 10:15:09 -0000 Pawel Jakub Dawidek wrote: > Sounds good to me. Will be also good to investigate why it was named > ppp-user in the first place, maybe it was taken under this name from > NetBSD? > BTW, it's named ppp in NetBSD. -- Sem. From owner-freebsd-rc@FreeBSD.ORG Thu Oct 27 10:19:23 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E03A516A41F; Thu, 27 Oct 2005 10:19:23 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2917F43D46; Thu, 27 Oct 2005 10:19:22 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9RAJKVe015652; Thu, 27 Oct 2005 14:19:21 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9RAJKAt015651; Thu, 27 Oct 2005 14:19:20 +0400 (MSD) (envelope-from yar) Date: Thu, 27 Oct 2005 14:19:20 +0400 From: Yar Tikhiy To: Sergey Matveychuk Message-ID: <20051027101919.GF12941@comp.chem.msu.su> References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027063353.GA63896@garage.freebsd.pl> <20051027071456.GA6598@comp.chem.msu.su> <20051027082115.GA749@garage.freebsd.pl> <20051027091920.GA11982@comp.chem.msu.su> <20051027092351.GC749@garage.freebsd.pl> <4360A848.5020508@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4360A848.5020508@FreeBSD.org> User-Agent: Mutt/1.5.9i Cc: freebsd-rc@FreeBSD.org, Pawel Jakub Dawidek Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 10:19:24 -0000 On Thu, Oct 27, 2005 at 02:13:28PM +0400, Sergey Matveychuk wrote: > Pawel Jakub Dawidek wrote: > > > >Sounds good to me. Will be also good to investigate why it was named > >ppp-user in the first place, maybe it was taken under this name from > >NetBSD? > > > > I guess to reflect a difference with pppd. IMHO the community should be used to having /usr/sbin/ppp and /usr/sbin/pppd already, so there is more confusion than benefit in trying to put this difference in other way. -- Yar From owner-freebsd-rc@FreeBSD.ORG Thu Oct 27 10:24:29 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B13BE16A41F; Thu, 27 Oct 2005 10:24:29 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id F013143D45; Thu, 27 Oct 2005 10:24:26 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9RAONDW015920; Thu, 27 Oct 2005 14:24:23 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9RAONf0015919; Thu, 27 Oct 2005 14:24:23 +0400 (MSD) (envelope-from yar) Date: Thu, 27 Oct 2005 14:24:22 +0400 From: Yar Tikhiy To: Sergey Matveychuk Message-ID: <20051027102422.GG12941@comp.chem.msu.su> References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027063353.GA63896@garage.freebsd.pl> <20051027071456.GA6598@comp.chem.msu.su> <20051027082115.GA749@garage.freebsd.pl> <20051027091920.GA11982@comp.chem.msu.su> <20051027092351.GC749@garage.freebsd.pl> <4360A8AA.5000904@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4360A8AA.5000904@FreeBSD.org> User-Agent: Mutt/1.5.9i Cc: freebsd-rc@FreeBSD.org, Pawel Jakub Dawidek Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 10:24:29 -0000 On Thu, Oct 27, 2005 at 02:15:06PM +0400, Sergey Matveychuk wrote: > Pawel Jakub Dawidek wrote: > >Sounds good to me. Will be also good to investigate why it was named > >ppp-user in the first place, maybe it was taken under this name from > >NetBSD? > > > > BTW, it's named ppp in NetBSD. Thanks for looking at NetBSD! Now the issue has been clarified. I think I can do the commit work. -- Yar From owner-freebsd-rc@FreeBSD.ORG Fri Oct 28 15:46:04 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF4F316A4CD; Fri, 28 Oct 2005 15:46:03 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8932743D79; Fri, 28 Oct 2005 15:45:55 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Fri, 28 Oct 2005 12:02:14 -0400 From: John Baldwin To: Yar Tikhiy Date: Fri, 28 Oct 2005 10:45:55 -0400 User-Agent: KMail/1.8.2 References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027082115.GA749@garage.freebsd.pl> <20051027091920.GA11982@comp.chem.msu.su> In-Reply-To: <20051027091920.GA11982@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510281045.57862.jhb@freebsd.org> Cc: freebsd-rc@freebsd.org, cvs-src@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek , cvs-all@freebsd.org Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 15:46:04 -0000 On Thursday 27 October 2005 05:19 am, Yar Tikhiy wrote: > On Thu, Oct 27, 2005 at 10:21:16AM +0200, Pawel Jakub Dawidek wrote: > > On Thu, Oct 27, 2005 at 11:14:56AM +0400, Yar Tikhiy wrote: > > +> On Thu, Oct 27, 2005 at 08:33:53AM +0200, Pawel Jakub Dawidek wrote: > > +> > On Sun, Oct 23, 2005 at 02:06:53PM +0000, Yar Tikhiy wrote: > > +> > +> yar 2005-10-23 14:06:53 UTC > > +> > +> > > +> > +> FreeBSD src repository > > +> > +> > > +> > +> Modified files: > > +> > +> etc/rc.d ike named ppp-user sshd > > +> > +> Log: > > +> > +> Don't be lazy, set the "command" variable even if > > +> > +> /etc/defaults/rc.conf will provide foo_program, too. > > +> > +> By specifying "command" we explicitly say that we're > > +> > +> going to rely on rc.subr(8) default methods, and > > +> > +> rc.subr(8) will take advantage of this soon. > > +> > +> > > +> > +> The majority of our rc.d scripts already set "command" > > +> > +> if appropriate, so fix just the non-compliant handful. > > +> > [...] > > +> > +> name="named" > > +> > +> rcvar=`set_rcvar` > > +> > +> +command="/usr/sbin/${name}" > > +> > [...] > > +> > +> name="ppp" > > +> > +> rcvar=`set_rcvar` > > +> > +> +command="/usr/sbin/ppp" > > +> > [...] > > +> > +> name="sshd" > > +> > +> rcvar=`set_rcvar` > > +> > +> +command="/usr/sbin/${name}" > > +> > > > +> > Any reason you didn't used ${name} in ppp case? > > +> > > +> I was just blinded by my being solid sure that $name was "ppp-user". > > +> Nowever, now I'm in doubt whether $name should be "ppp". The script > > +> is named ppp-user and it PROVIDEs ppp-user, hence sysadmins can > > +> rightfully assume that its rc.conf.d file is ppp-user, too. Such > > +> assumption will be broken since it is $name that is passed to > > +> load_rc_config. I think $name should be changed to "ppp-user" in > > +> CURRENT. This will introduce minor incompatibility, but also > > +> eliminate a source of further confusion. > > > > It is confusing, but maybe we should rename ppp-user to ppp? > > I'm not sure how well sh(1) will handle things like > > ppp-user_enable="YES", etc. > > Yes, this is much better than my lame proposal because so we will > have to worry about neither variable naming nor compatibility with > installations using ppp and rc.conf.d at once. We change the PROVIDE > line and fix all dependent rc.d scripts, then request the repocopy > of ppp-user to ppp, fix /etc/netstart, and finally kill the old > file. Does this plan look OK? > > P.S. Looks like it's time to move this thread to -rc, setting > Mail-Followup-To accordingly. Yeah, I was actually surprised it was called /etc/rc.d/ppp-user instead of /etc/rc.d/ppp when I went to setup pppoe at home yesterday. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-freebsd-rc@FreeBSD.ORG Fri Oct 28 16:40:30 2005 Return-Path: X-Original-To: rc@freebsd.org Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E95216A44D for ; Fri, 28 Oct 2005 16:40:30 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id C35E443D45 for ; Fri, 28 Oct 2005 16:40:29 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 3988A2384 for ; Fri, 28 Oct 2005 18:40:24 +0200 (CEST) X-Spam-Tests: ALL_TRUSTED,AWL,BAYES_00 X-Spam-Learn: ham X-Spam-Score: -4.4/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on tim.des.no Received: from xps.des.no (des.no [80.203.228.37]) by tim.des.no (Postfix) with ESMTP id BCFA12383 for ; Fri, 28 Oct 2005 18:40:23 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id 90A9E33C21; Fri, 28 Oct 2005 18:40:23 +0200 (CEST) To: rc@freebsd.org From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Fri, 28 Oct 2005 18:40:23 +0200 Message-ID: <86ll0d4mtk.fsf@xps.des.no> User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: Subject: ifconfig_foo0 syntax X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 16:40:30 -0000 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable I've been having trouble with a bridge interface. It seemed logical to me to do cloned_interfaces=3D"bridge0" ifconfig_bridge0=3D"addm foo0 addm bar0 inet 10.0.0.1/24" but ifconfig(8) does not accept "inet" after "addm". (perhaps I should have put the inet bit at the front?) In any case, I came up with a patch that allows me to do ifconfig_bridge0=3D"addm foo0; addm bar0; inet 10.0.0.1/24" which translates into three different ifconfig invocations. there's probably a better / cleaner way to do this... DES --=20 Dag-Erling Sm=F8rgrav - des@des.no --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=network_subr.diff Index: etc/network.subr =================================================================== RCS file: /home/ncvs/src/etc/network.subr,v retrieving revision 1.167 diff -u -r1.167 network.subr --- etc/network.subr 2 Sep 2005 17:11:13 -0000 1.167 +++ etc/network.subr 1 Jan 2002 18:24:17 -0000 @@ -44,7 +44,12 @@ ifconfig_args=`ifconfig_getargs $1` if [ -n "${ifconfig_args}" ]; then ifconfig $1 up - eval "ifconfig $1 ${ifconfig_args}" + while :; do + _args="${ifconfig_args%%;*}" + eval "ifconfig $1 ${_args}" + ifconfig_args="${ifconfig_args#*;}" + [ "${_args}" = "${ifconfig_args}" ] && break + done _cfg=0 fi --=-=-=-- From owner-freebsd-rc@FreeBSD.ORG Fri Oct 28 16:50:07 2005 Return-Path: X-Original-To: rc@freebsd.org Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB38916A41F for ; Fri, 28 Oct 2005 16:50:07 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2161843D46 for ; Fri, 28 Oct 2005 16:50:05 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9SGnuAP097047; Fri, 28 Oct 2005 20:49:56 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9SGnscl097046; Fri, 28 Oct 2005 20:49:54 +0400 (MSD) (envelope-from yar) Date: Fri, 28 Oct 2005 20:49:53 +0400 From: Yar Tikhiy To: Dag-Erling Sm?rgrav Message-ID: <20051028164953.GD89861@comp.chem.msu.su> References: <86ll0d4mtk.fsf@xps.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86ll0d4mtk.fsf@xps.des.no> User-Agent: Mutt/1.5.9i Cc: rc@freebsd.org Subject: Re: ifconfig_foo0 syntax X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 16:50:07 -0000 On Fri, Oct 28, 2005 at 06:40:23PM +0200, Dag-Erling Sm?rgrav wrote: > I've been having trouble with a bridge interface. It seemed logical > to me to do > > cloned_interfaces="bridge0" > ifconfig_bridge0="addm foo0 addm bar0 inet 10.0.0.1/24" > > but ifconfig(8) does not accept "inet" after "addm". > > (perhaps I should have put the inet bit at the front?) Yes, the address should come first on the command line. The only word that can precede the address is "create". I myself played with bridge just yesterday using a line similar to the following one: ifconfig_bridge0="inet 10.0.0.1/24 addm foo0 addm bar0" Similarly, vlan interfaces are to be brought up as follows: ifconfig_vlan0="inet 10.0.0.1/24 vlan 10 vlandev baz0" And so on. The ifconfig(8) manpage seems to specify that. ifconfig(8) should be clever enough to do the actual syscalls in the proper order, and it is in all cases I've met :-) > In any case, I came up with a patch that allows me to do > > ifconfig_bridge0="addm foo0; addm bar0; inet 10.0.0.1/24" > > which translates into three different ifconfig invocations. > > there's probably a better / cleaner way to do this... Do you agree now that there is no need to patch rc files? -- Yar From owner-freebsd-rc@FreeBSD.ORG Fri Oct 28 17:12:52 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 58EC316A41F; Fri, 28 Oct 2005 17:12:52 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86DFC43D46; Fri, 28 Oct 2005 17:12:49 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9SHCl9w098533; Fri, 28 Oct 2005 21:12:47 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9SHCl4A098532; Fri, 28 Oct 2005 21:12:47 +0400 (MSD) (envelope-from yar) Date: Fri, 28 Oct 2005 21:12:47 +0400 From: Yar Tikhiy To: John Baldwin Message-ID: <20051028171246.GF89861@comp.chem.msu.su> References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027082115.GA749@garage.freebsd.pl> <20051027091920.GA11982@comp.chem.msu.su> <200510281045.57862.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510281045.57862.jhb@freebsd.org> User-Agent: Mutt/1.5.9i Cc: freebsd-rc@freebsd.org, Pawel Jakub Dawidek Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 17:12:52 -0000 On Fri, Oct 28, 2005 at 10:45:55AM -0400, John Baldwin wrote: > On Thursday 27 October 2005 05:19 am, Yar Tikhiy wrote: > > On Thu, Oct 27, 2005 at 10:21:16AM +0200, Pawel Jakub Dawidek wrote: > > > On Thu, Oct 27, 2005 at 11:14:56AM +0400, Yar Tikhiy wrote: > > > +> On Thu, Oct 27, 2005 at 08:33:53AM +0200, Pawel Jakub Dawidek wrote: > > > +> > On Sun, Oct 23, 2005 at 02:06:53PM +0000, Yar Tikhiy wrote: > > > +> > +> yar 2005-10-23 14:06:53 UTC > > > +> > +> > > > +> > +> FreeBSD src repository > > > +> > +> > > > +> > +> Modified files: > > > +> > +> etc/rc.d ike named ppp-user sshd > > > +> > +> Log: > > > +> > +> Don't be lazy, set the "command" variable even if > > > +> > +> /etc/defaults/rc.conf will provide foo_program, too. > > > +> > +> By specifying "command" we explicitly say that we're > > > +> > +> going to rely on rc.subr(8) default methods, and > > > +> > +> rc.subr(8) will take advantage of this soon. > > > +> > +> > > > +> > +> The majority of our rc.d scripts already set "command" > > > +> > +> if appropriate, so fix just the non-compliant handful. > > > +> > [...] > > > +> > +> name="named" > > > +> > +> rcvar=`set_rcvar` > > > +> > +> +command="/usr/sbin/${name}" > > > +> > [...] > > > +> > +> name="ppp" > > > +> > +> rcvar=`set_rcvar` > > > +> > +> +command="/usr/sbin/ppp" > > > +> > [...] > > > +> > +> name="sshd" > > > +> > +> rcvar=`set_rcvar` > > > +> > +> +command="/usr/sbin/${name}" > > > +> > > > > +> > Any reason you didn't used ${name} in ppp case? > > > +> > > > +> I was just blinded by my being solid sure that $name was "ppp-user". > > > +> Nowever, now I'm in doubt whether $name should be "ppp". The script > > > +> is named ppp-user and it PROVIDEs ppp-user, hence sysadmins can > > > +> rightfully assume that its rc.conf.d file is ppp-user, too. Such > > > +> assumption will be broken since it is $name that is passed to > > > +> load_rc_config. I think $name should be changed to "ppp-user" in > > > +> CURRENT. This will introduce minor incompatibility, but also > > > +> eliminate a source of further confusion. > > > > > > It is confusing, but maybe we should rename ppp-user to ppp? > > > I'm not sure how well sh(1) will handle things like > > > ppp-user_enable="YES", etc. > > > > Yes, this is much better than my lame proposal because so we will > > have to worry about neither variable naming nor compatibility with > > installations using ppp and rc.conf.d at once. We change the PROVIDE > > line and fix all dependent rc.d scripts, then request the repocopy > > of ppp-user to ppp, fix /etc/netstart, and finally kill the old > > file. Does this plan look OK? > > > > P.S. Looks like it's time to move this thread to -rc, setting > > Mail-Followup-To accordingly. > > Yeah, I was actually surprised it was called /etc/rc.d/ppp-user instead > of /etc/rc.d/ppp when I went to setup pppoe at home yesterday. The ppp-user -> ppp transformation is under way already, I've just submitted the repocopy request. There will be no more confusion with this really soon :-) -- Yar From owner-freebsd-rc@FreeBSD.ORG Fri Oct 28 18:06:37 2005 Return-Path: X-Original-To: rc@freebsd.org Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BEDE16A41F for ; Fri, 28 Oct 2005 18:06:37 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F0D143D6B for ; Fri, 28 Oct 2005 18:06:29 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j9SI6OIS020676; Fri, 28 Oct 2005 11:06:24 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j9SI6OqZ020673; Fri, 28 Oct 2005 11:06:24 -0700 Date: Fri, 28 Oct 2005 11:06:24 -0700 From: Brooks Davis To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20051028180624.GB17096@odin.ac.hmc.edu> References: <86ll0d4mtk.fsf@xps.des.no> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mxv5cy4qt+RJ9ypb" Content-Disposition: inline In-Reply-To: <86ll0d4mtk.fsf@xps.des.no> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: rc@freebsd.org Subject: Re: ifconfig_foo0 syntax X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 18:06:37 -0000 --mxv5cy4qt+RJ9ypb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2005 at 06:40:23PM +0200, Dag-Erling Sm=F8rgrav wrote: > I've been having trouble with a bridge interface. It seemed logical > to me to do >=20 > cloned_interfaces=3D"bridge0" > ifconfig_bridge0=3D"addm foo0 addm bar0 inet 10.0.0.1/24" >=20 > but ifconfig(8) does not accept "inet" after "addm". >=20 > (perhaps I should have put the inet bit at the front?) >=20 > In any case, I came up with a patch that allows me to do >=20 > ifconfig_bridge0=3D"addm foo0; addm bar0; inet 10.0.0.1/24" >=20 > which translates into three different ifconfig invocations. >=20 > there's probably a better / cleaner way to do this... In addition to Yar's comments, I'll be committing a patch from Philipp Wuensche which adds a new ipv4_addrs_ variable that you could use to set the IPv4 address even if the ordering issue wasn't resolvable. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --mxv5cy4qt+RJ9ypb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDYmifXY6L6fI4GtQRAv5NAKCF6z9Xzwt/F/AeaOv/3o2iC2FQUgCbBBQf 2rVBMl+hx7cQgsPTi65cZUI= =UcoF -----END PGP SIGNATURE----- --mxv5cy4qt+RJ9ypb-- From owner-freebsd-rc@FreeBSD.ORG Sat Oct 29 05:30:19 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4524316A41F; Sat, 29 Oct 2005 05:30:19 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 49BC443D45; Sat, 29 Oct 2005 05:30:18 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9T5UGir031079; Sat, 29 Oct 2005 09:30:16 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9T5UGX3031078; Sat, 29 Oct 2005 09:30:16 +0400 (MSD) (envelope-from yar) Date: Sat, 29 Oct 2005 09:30:15 +0400 From: Yar Tikhiy To: freebsd-rc@freebsd.org Message-ID: <20051029053015.GC28199@comp.chem.msu.su> References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027063353.GA63896@garage.freebsd.pl> <20051027071456.GA6598@comp.chem.msu.su> <20051027082115.GA749@garage.freebsd.pl> <20051027091920.GA11982@comp.chem.msu.su> <20051027092351.GC749@garage.freebsd.pl> <4360A8AA.5000904@FreeBSD.org> <20051027102422.GG12941@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051027102422.GG12941@comp.chem.msu.su> User-Agent: Mutt/1.5.9i Cc: Pawel Jakub Dawidek Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Oct 2005 05:30:19 -0000 On Thu, Oct 27, 2005 at 02:24:22PM +0400, Yar Tikhiy wrote: > On Thu, Oct 27, 2005 at 02:15:06PM +0400, Sergey Matveychuk wrote: > > Pawel Jakub Dawidek wrote: > > >Sounds good to me. Will be also good to investigate why it was named > > >ppp-user in the first place, maybe it was taken under this name from > > >NetBSD? > > > > > > > BTW, it's named ppp in NetBSD. > > Thanks for looking at NetBSD! Now the issue has been clarified. > I think I can do the commit work. All done! Now we have rc.d/ppp in place of rc.d/ppp-user. -- Yar From owner-freebsd-rc@FreeBSD.ORG Sat Oct 29 07:18:36 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81C1216A41F for ; Sat, 29 Oct 2005 07:18:36 +0000 (GMT) (envelope-from erdgeist@erdgeist.org) Received: from elektropost.org (elektropost.org [80.237.196.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD23643D4C for ; Sat, 29 Oct 2005 07:18:35 +0000 (GMT) (envelope-from erdgeist@erdgeist.org) Received: (qmail 78291 invoked by uid 0); 29 Oct 2005 07:17:53 -0000 Received: from erdgeist.org (erdgeist@erdgeist.org@80.237.196.15) by elektropost.org with AES256-SHA encrypted SMTP; 29 Oct 2005 07:17:53 -0000 Date: Sat, 29 Oct 2005 09:17:51 +0200 (CEST) From: Dirk Engling To: Yar Tikhiy In-Reply-To: <20051026051029.GA32620@comp.chem.msu.su> Message-ID: <20051029090008.J74189@erdgeist.org> References: <20051026051029.GA32620@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-rc@freebsd.org Subject: Re: A fix for `restart' X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Oct 2005 07:18:36 -0000 On Wed, 26 Oct 2005, Yar Tikhiy wrote: > Would you mind testing the following patch to /etc/rc.subr > that should remedy problems with `restart', e.g., as found > for /etc/rc.d/jail? It is safe as it doesn't affect other > commans and hence it won't disrupt your boot sequence :-) > I'm just concerned about possible side-effects for restart > I might have overlooked. The test case of scripts taking > additional arguments besides the command is the most intriguing. I included that patch and successfully ran it for a week and dozends of restarts. For me it looks like the patch solves the problem I had and stands little chance of making things worse than before. Thanks a lot. Is there any chance that this bug fix will find its way into 6.0RELEASE? Regards, Dirk