From owner-freebsd-rc@FreeBSD.ORG Mon Nov 14 10:37:28 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02E4816A41F; Mon, 14 Nov 2005 10:37:28 +0000 (GMT) (envelope-from past@ebs.gr) Received: from fly.ebs.gr (fly.ebs.gr [62.103.84.177]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0AD6443D45; Mon, 14 Nov 2005 10:37:26 +0000 (GMT) (envelope-from past@ebs.gr) Received: from ebs.gr (root@hal.ebs.gr [10.1.1.2]) by fly.ebs.gr (8.12.9p1/8.12.9) with ESMTP id jAEAb79V058295; Mon, 14 Nov 2005 12:37:07 +0200 (EET) (envelope-from past@ebs.gr) Received: from [10.1.1.158] (pc158.ebs.gr [10.1.1.158]) by ebs.gr (8.13.3/8.12.11) with ESMTP id jAEAbE69048965; Mon, 14 Nov 2005 12:37:18 +0200 (EET) (envelope-from past@ebs.gr) Message-ID: <437868C8.10508@ebs.gr> Date: Mon, 14 Nov 2005 12:36:56 +0200 From: Panagiotis Astithas Organization: EBS Ltd. User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051106) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Maksim Yevmenkin References: <43519460.1090605@ebs.gr> <1129491219.1616.18.camel@localhost> <4375246E.3050303@savvis.net> <20051111.165103.110975378.imp@bsdimp.com> <20051112000929.GB10648@odin.ac.hmc.edu> <4375681B.6030808@savvis.net> <20051112175541.GA18302@odin.ac.hmc.edu> <437667D4.5030205@savvis.net> In-Reply-To: <437667D4.5030205@savvis.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-bluetooth@freebsd.org, freebsd-rc@freebsd.org, "M. Warner Losh" Subject: Re: [RFC] rc.d integration for the bluetooth subsystem X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2005 10:37:28 -0000 Maksim Yevmenkin wrote: > Brooks, > > [...] > >> Instead, I would suggest creating a port that installs the firmware >> and a /usr/local/etc/devd/ script simliar to the iwi-firmware port. > > > ok. that sounds fine to me. does anyone have experience with this like > this? i mean do i have to contact 3com and broadcom and obtain some sort > of permission for this? how does this work? > > linux bluez has rpm that contains firmware. it seems like they have > contacted broadcom, because they have firmware files in their cvs > > http://cvs.sourceforge.net/viewcvs.py/bluez/firmware/broadcom/ > > can i legally get those files and include them into freebsd port's > collection? if this is going to lead to too much corporate brouhaha then > perhaps i should leave it as it is. bcmfw(8) and bt3cfw(8) man pages > already tell users where they can get the firmware. You could just have the port fetch the files from sourceforge and avoid including any copyrighted material in the ports repository. Regards, Panagiotis From owner-freebsd-rc@FreeBSD.ORG Mon Nov 14 11:02:35 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29FA916A425 for ; Mon, 14 Nov 2005 11:02:35 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EAEBF43D45 for ; Mon, 14 Nov 2005 11:02:34 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jAEB2YBo073829 for ; Mon, 14 Nov 2005 11:02:34 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jAEB2YV5073823 for freebsd-rc@freebsd.org; Mon, 14 Nov 2005 11:02:34 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 14 Nov 2005 11:02:34 GMT Message-Id: <200511141102.jAEB2YV5073823@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2005 11:02:35 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2005/02/10] conf/77340 rc awk used in /etc/rc.d/nsswitch when not a 1 problem total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2004/06/30] conf/68525 rc Loader's verbose boot mode has rc.d/local o [2004/07/07] conf/68745 rc /etc/rc.d/devfs runs after ntpd so links o [2005/05/14] kern/81006 rc ipnat not working with tunnel interfaces 3 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Nov 14 17:18:07 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C74BB16A420; Mon, 14 Nov 2005 17:18:07 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 326E043D46; Mon, 14 Nov 2005 17:18:07 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id jAEHI1Hk005487; Mon, 14 Nov 2005 09:18:01 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id jAEHI0Of005486; Mon, 14 Nov 2005 09:18:00 -0800 Date: Mon, 14 Nov 2005 09:18:00 -0800 From: Brooks Davis To: Panagiotis Astithas Message-ID: <20051114171800.GA1928@odin.ac.hmc.edu> References: <43519460.1090605@ebs.gr> <1129491219.1616.18.camel@localhost> <4375246E.3050303@savvis.net> <20051111.165103.110975378.imp@bsdimp.com> <20051112000929.GB10648@odin.ac.hmc.edu> <4375681B.6030808@savvis.net> <20051112175541.GA18302@odin.ac.hmc.edu> <437667D4.5030205@savvis.net> <437868C8.10508@ebs.gr> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline In-Reply-To: <437868C8.10508@ebs.gr> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-bluetooth@freebsd.org, freebsd-rc@freebsd.org, "M. Warner Losh" Subject: Re: [RFC] rc.d integration for the bluetooth subsystem X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2005 17:18:07 -0000 --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 14, 2005 at 12:36:56PM +0200, Panagiotis Astithas wrote: > Maksim Yevmenkin wrote: > >Brooks, > > > >[...] > > > >>Instead, I would suggest creating a port that installs the firmware > >>and a /usr/local/etc/devd/ script simliar to the iwi-firmware port. > > > > > >ok. that sounds fine to me. does anyone have experience with this like= =20 > >this? i mean do i have to contact 3com and broadcom and obtain some sort= =20 > >of permission for this? how does this work? > > > >linux bluez has rpm that contains firmware. it seems like they have=20 > >contacted broadcom, because they have firmware files in their cvs > > > >http://cvs.sourceforge.net/viewcvs.py/bluez/firmware/broadcom/ > > > >can i legally get those files and include them into freebsd port's=20 > >collection? if this is going to lead to too much corporate brouhaha then= =20 > >perhaps i should leave it as it is. bcmfw(8) and bt3cfw(8) man pages=20 > >already tell users where they can get the firmware. >=20 > You could just have the port fetch the files from sourceforge and avoid= =20 > including any copyrighted material in the ports repository. Yes. Just make sure to set the RESTRICTED variable to cause the distfiles and packages to not be distributed. I'd suggest starting with the net/ipw-firmware port (it's a little overly complex as it's the master port for net/iwi-firmware, but it's got the basics.) -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDeMbHXY6L6fI4GtQRAqlxAJ0dqYkSpwbwp3RKzj52c/1mkixWagCgg0wM 0HfW8FcwIOgWIELWE1TTsZk= =xnXP -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm-- From owner-freebsd-rc@FreeBSD.ORG Wed Nov 16 13:02:48 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E8E616A41F; Wed, 16 Nov 2005 13:02:48 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A9B543D45; Wed, 16 Nov 2005 13:02:43 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id jAGD2bcO038558; Wed, 16 Nov 2005 16:02:37 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id jAGD2aAm038557; Wed, 16 Nov 2005 16:02:37 +0300 (MSK) (envelope-from yar) Date: Wed, 16 Nov 2005 16:02:36 +0300 From: Yar Tikhiy To: freebsd-rc@freebsd.org Message-ID: <20051116130236.GC35168@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.9i Cc: Subject: exit in rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2005 13:02:48 -0000 Hi there, There are a few calls to "exit" in rc.subr, which creates problems for rc.d script writers. As a rule, library functions shouldn't exit, it's up to the caller to decide whether to exit or keep running. Any objections to the below patch? It's by sem@ with minor additions by me. Thanks. --- //depot/user/yar/hack/etc/rc.subr 2005/10/31 13:30:04 +++ //depot/user/yar/hack/etc/rc.subr 2005/11/16 10:56:56 @@ -598,12 +598,12 @@ start) if [ -z "$rc_fast" -a -n "$rc_pid" ]; then echo "${name} already running? (pid=$rc_pid)." - exit 1 + return 1 fi if [ ! -x ${_chroot}${command} ]; then info "run_rc_command: cannot run ($command)." - return 0 + return 1 fi # check for required variables, @@ -681,14 +681,14 @@ stop) if [ -z "$rc_pid" ]; then - [ -n "$rc_fast" ] && exit 0 + [ -n "$rc_fast" ] && return 0 if [ -n "$pidfile" ]; then echo \ "${name} not running? (check $pidfile)." else echo "${name} not running?" fi - exit 1 + return 1 fi # if the precmd failed and force @@ -733,7 +733,7 @@ else echo "${name} not running?" fi - exit 1 + return 1 fi echo "Reloading ${name} config files." if [ -n "$_precmd" ]; then @@ -807,7 +807,7 @@ echo 1>&2 "$0: unknown directive '$rc_arg'." rc_usage $_keywords - exit 1 + # not reached } #